rubocop 1.29.1 → 1.30.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (452) hide show
  1. checksums.yaml +4 -4
  2. data/README.md +1 -1
  3. data/config/default.yml +16 -2
  4. data/lib/rubocop/cli/command/auto_genenerate_config.rb +19 -4
  5. data/lib/rubocop/cli/command/execute_runner.rb +1 -1
  6. data/lib/rubocop/cli/command/show_cops.rb +1 -1
  7. data/lib/rubocop/cli.rb +1 -0
  8. data/lib/rubocop/config_loader.rb +2 -1
  9. data/lib/rubocop/config_validator.rb +15 -2
  10. data/lib/rubocop/cop/autocorrect_logic.rb +4 -2
  11. data/lib/rubocop/cop/base.rb +1 -1
  12. data/lib/rubocop/cop/bundler/gem_filename.rb +1 -1
  13. data/lib/rubocop/cop/correctors/alignment_corrector.rb +1 -1
  14. data/lib/rubocop/cop/correctors/condition_corrector.rb +1 -1
  15. data/lib/rubocop/cop/correctors/each_to_for_corrector.rb +1 -1
  16. data/lib/rubocop/cop/correctors/empty_line_corrector.rb +1 -1
  17. data/lib/rubocop/cop/correctors/for_to_each_corrector.rb +4 -2
  18. data/lib/rubocop/cop/correctors/if_then_corrector.rb +1 -1
  19. data/lib/rubocop/cop/correctors/lambda_literal_to_method_corrector.rb +1 -1
  20. data/lib/rubocop/cop/correctors/line_break_corrector.rb +7 -1
  21. data/lib/rubocop/cop/correctors/ordered_gem_corrector.rb +1 -1
  22. data/lib/rubocop/cop/correctors/parentheses_corrector.rb +1 -1
  23. data/lib/rubocop/cop/correctors/percent_literal_corrector.rb +1 -1
  24. data/lib/rubocop/cop/correctors/punctuation_corrector.rb +1 -1
  25. data/lib/rubocop/cop/correctors/space_corrector.rb +1 -1
  26. data/lib/rubocop/cop/correctors/string_literal_corrector.rb +1 -1
  27. data/lib/rubocop/cop/correctors/unused_arg_corrector.rb +1 -1
  28. data/lib/rubocop/cop/gemspec/date_assignment.rb +1 -1
  29. data/lib/rubocop/cop/gemspec/deprecated_attribute_assignment.rb +77 -0
  30. data/lib/rubocop/cop/internal_affairs/cop_description.rb +96 -0
  31. data/lib/rubocop/cop/internal_affairs/empty_line_between_expect_offense_and_correction.rb +1 -1
  32. data/lib/rubocop/cop/internal_affairs/location_line_equality_comparison.rb +1 -1
  33. data/lib/rubocop/cop/internal_affairs/method_name_end_with.rb +1 -1
  34. data/lib/rubocop/cop/internal_affairs/redundant_described_class_as_subject.rb +1 -1
  35. data/lib/rubocop/cop/internal_affairs/redundant_let_rubocop_config_new.rb +1 -1
  36. data/lib/rubocop/cop/internal_affairs.rb +1 -0
  37. data/lib/rubocop/cop/layout/argument_alignment.rb +22 -1
  38. data/lib/rubocop/cop/layout/assignment_indentation.rb +1 -1
  39. data/lib/rubocop/cop/layout/begin_end_alignment.rb +1 -1
  40. data/lib/rubocop/cop/layout/block_alignment.rb +1 -1
  41. data/lib/rubocop/cop/layout/block_end_newline.rb +1 -1
  42. data/lib/rubocop/cop/layout/case_indentation.rb +1 -1
  43. data/lib/rubocop/cop/layout/closing_parenthesis_indentation.rb +1 -1
  44. data/lib/rubocop/cop/layout/comment_indentation.rb +1 -1
  45. data/lib/rubocop/cop/layout/condition_position.rb +1 -1
  46. data/lib/rubocop/cop/layout/def_end_alignment.rb +1 -1
  47. data/lib/rubocop/cop/layout/dot_position.rb +1 -1
  48. data/lib/rubocop/cop/layout/else_alignment.rb +1 -1
  49. data/lib/rubocop/cop/layout/empty_comment.rb +1 -1
  50. data/lib/rubocop/cop/layout/empty_line_after_guard_clause.rb +1 -1
  51. data/lib/rubocop/cop/layout/empty_line_after_multiline_condition.rb +1 -1
  52. data/lib/rubocop/cop/layout/empty_line_between_defs.rb +1 -1
  53. data/lib/rubocop/cop/layout/empty_lines.rb +1 -1
  54. data/lib/rubocop/cop/layout/empty_lines_around_arguments.rb +1 -1
  55. data/lib/rubocop/cop/layout/empty_lines_around_begin_body.rb +1 -1
  56. data/lib/rubocop/cop/layout/empty_lines_around_block_body.rb +1 -1
  57. data/lib/rubocop/cop/layout/empty_lines_around_class_body.rb +1 -1
  58. data/lib/rubocop/cop/layout/empty_lines_around_exception_handling_keywords.rb +1 -1
  59. data/lib/rubocop/cop/layout/empty_lines_around_method_body.rb +1 -1
  60. data/lib/rubocop/cop/layout/empty_lines_around_module_body.rb +1 -1
  61. data/lib/rubocop/cop/layout/end_alignment.rb +1 -1
  62. data/lib/rubocop/cop/layout/end_of_line.rb +1 -1
  63. data/lib/rubocop/cop/layout/extra_spacing.rb +1 -1
  64. data/lib/rubocop/cop/layout/first_argument_indentation.rb +1 -1
  65. data/lib/rubocop/cop/layout/first_array_element_indentation.rb +1 -1
  66. data/lib/rubocop/cop/layout/first_array_element_line_break.rb +1 -1
  67. data/lib/rubocop/cop/layout/first_hash_element_indentation.rb +1 -1
  68. data/lib/rubocop/cop/layout/first_hash_element_line_break.rb +1 -1
  69. data/lib/rubocop/cop/layout/first_method_argument_line_break.rb +1 -1
  70. data/lib/rubocop/cop/layout/first_method_parameter_line_break.rb +1 -1
  71. data/lib/rubocop/cop/layout/first_parameter_indentation.rb +1 -1
  72. data/lib/rubocop/cop/layout/hash_alignment.rb +2 -0
  73. data/lib/rubocop/cop/layout/heredoc_argument_closing_parenthesis.rb +1 -1
  74. data/lib/rubocop/cop/layout/heredoc_indentation.rb +1 -1
  75. data/lib/rubocop/cop/layout/indentation_consistency.rb +1 -1
  76. data/lib/rubocop/cop/layout/indentation_style.rb +1 -1
  77. data/lib/rubocop/cop/layout/indentation_width.rb +8 -5
  78. data/lib/rubocop/cop/layout/initial_indentation.rb +1 -1
  79. data/lib/rubocop/cop/layout/leading_comment_space.rb +1 -1
  80. data/lib/rubocop/cop/layout/leading_empty_lines.rb +1 -1
  81. data/lib/rubocop/cop/layout/line_end_string_concatenation_indentation.rb +1 -1
  82. data/lib/rubocop/cop/layout/line_length.rb +1 -1
  83. data/lib/rubocop/cop/layout/multiline_array_brace_layout.rb +1 -1
  84. data/lib/rubocop/cop/layout/multiline_array_line_breaks.rb +1 -1
  85. data/lib/rubocop/cop/layout/multiline_assignment_layout.rb +1 -1
  86. data/lib/rubocop/cop/layout/multiline_block_layout.rb +1 -1
  87. data/lib/rubocop/cop/layout/multiline_hash_brace_layout.rb +1 -1
  88. data/lib/rubocop/cop/layout/multiline_hash_key_line_breaks.rb +1 -1
  89. data/lib/rubocop/cop/layout/multiline_method_argument_line_breaks.rb +1 -1
  90. data/lib/rubocop/cop/layout/multiline_method_call_brace_layout.rb +1 -1
  91. data/lib/rubocop/cop/layout/multiline_method_call_indentation.rb +1 -1
  92. data/lib/rubocop/cop/layout/multiline_method_definition_brace_layout.rb +1 -1
  93. data/lib/rubocop/cop/layout/multiline_operation_indentation.rb +1 -1
  94. data/lib/rubocop/cop/layout/redundant_line_break.rb +1 -1
  95. data/lib/rubocop/cop/layout/rescue_ensure_alignment.rb +1 -1
  96. data/lib/rubocop/cop/layout/single_line_block_chain.rb +1 -1
  97. data/lib/rubocop/cop/layout/space_after_not.rb +1 -1
  98. data/lib/rubocop/cop/layout/space_before_block_braces.rb +2 -2
  99. data/lib/rubocop/cop/layout/space_before_comment.rb +1 -1
  100. data/lib/rubocop/cop/layout/space_in_lambda_literal.rb +1 -1
  101. data/lib/rubocop/cop/layout/space_inside_block_braces.rb +3 -3
  102. data/lib/rubocop/cop/layout/space_inside_string_interpolation.rb +1 -1
  103. data/lib/rubocop/cop/layout/trailing_empty_lines.rb +1 -1
  104. data/lib/rubocop/cop/layout/trailing_whitespace.rb +1 -1
  105. data/lib/rubocop/cop/lint/ambiguous_assignment.rb +1 -1
  106. data/lib/rubocop/cop/lint/ambiguous_block_association.rb +1 -1
  107. data/lib/rubocop/cop/lint/ambiguous_operator.rb +1 -1
  108. data/lib/rubocop/cop/lint/ambiguous_operator_precedence.rb +1 -1
  109. data/lib/rubocop/cop/lint/ambiguous_range.rb +3 -3
  110. data/lib/rubocop/cop/lint/ambiguous_regexp_literal.rb +1 -1
  111. data/lib/rubocop/cop/lint/assignment_in_condition.rb +1 -1
  112. data/lib/rubocop/cop/lint/binary_operator_with_identical_operands.rb +1 -1
  113. data/lib/rubocop/cop/lint/boolean_symbol.rb +1 -1
  114. data/lib/rubocop/cop/lint/circular_argument_reference.rb +1 -1
  115. data/lib/rubocop/cop/lint/debugger.rb +1 -1
  116. data/lib/rubocop/cop/lint/deprecated_class_methods.rb +1 -1
  117. data/lib/rubocop/cop/lint/deprecated_constants.rb +1 -1
  118. data/lib/rubocop/cop/lint/disjunctive_assignment_in_constructor.rb +1 -1
  119. data/lib/rubocop/cop/lint/duplicate_branch.rb +1 -1
  120. data/lib/rubocop/cop/lint/duplicate_case_condition.rb +1 -1
  121. data/lib/rubocop/cop/lint/duplicate_elsif_condition.rb +1 -1
  122. data/lib/rubocop/cop/lint/duplicate_hash_key.rb +1 -1
  123. data/lib/rubocop/cop/lint/duplicate_methods.rb +1 -1
  124. data/lib/rubocop/cop/lint/duplicate_regexp_character_class_element.rb +1 -1
  125. data/lib/rubocop/cop/lint/duplicate_require.rb +1 -1
  126. data/lib/rubocop/cop/lint/duplicate_rescue_exception.rb +1 -1
  127. data/lib/rubocop/cop/lint/each_with_object_argument.rb +1 -1
  128. data/lib/rubocop/cop/lint/else_layout.rb +3 -3
  129. data/lib/rubocop/cop/lint/empty_block.rb +1 -1
  130. data/lib/rubocop/cop/lint/empty_class.rb +1 -1
  131. data/lib/rubocop/cop/lint/empty_conditional_body.rb +1 -1
  132. data/lib/rubocop/cop/lint/empty_ensure.rb +1 -1
  133. data/lib/rubocop/cop/lint/empty_expression.rb +1 -1
  134. data/lib/rubocop/cop/lint/empty_file.rb +1 -1
  135. data/lib/rubocop/cop/lint/empty_in_pattern.rb +1 -1
  136. data/lib/rubocop/cop/lint/empty_interpolation.rb +1 -1
  137. data/lib/rubocop/cop/lint/empty_when.rb +1 -1
  138. data/lib/rubocop/cop/lint/ensure_return.rb +1 -1
  139. data/lib/rubocop/cop/lint/flip_flop.rb +1 -1
  140. data/lib/rubocop/cop/lint/float_comparison.rb +1 -1
  141. data/lib/rubocop/cop/lint/float_out_of_range.rb +1 -1
  142. data/lib/rubocop/cop/lint/heredoc_method_call_position.rb +1 -1
  143. data/lib/rubocop/cop/lint/implicit_string_concatenation.rb +1 -1
  144. data/lib/rubocop/cop/lint/incompatible_io_select_with_fiber_scheduler.rb +1 -1
  145. data/lib/rubocop/cop/lint/ineffective_access_modifier.rb +1 -1
  146. data/lib/rubocop/cop/lint/inherit_exception.rb +1 -1
  147. data/lib/rubocop/cop/lint/interpolation_check.rb +1 -1
  148. data/lib/rubocop/cop/lint/lambda_without_literal_block.rb +2 -2
  149. data/lib/rubocop/cop/lint/literal_as_condition.rb +1 -1
  150. data/lib/rubocop/cop/lint/literal_in_interpolation.rb +1 -1
  151. data/lib/rubocop/cop/lint/loop.rb +1 -1
  152. data/lib/rubocop/cop/lint/missing_cop_enable_directive.rb +1 -1
  153. data/lib/rubocop/cop/lint/missing_super.rb +1 -1
  154. data/lib/rubocop/cop/lint/nested_method_definition.rb +1 -1
  155. data/lib/rubocop/cop/lint/nested_percent_literal.rb +1 -1
  156. data/lib/rubocop/cop/lint/non_local_exit_from_iterator.rb +1 -1
  157. data/lib/rubocop/cop/lint/number_conversion.rb +1 -1
  158. data/lib/rubocop/cop/lint/numbered_parameter_assignment.rb +1 -1
  159. data/lib/rubocop/cop/lint/or_assignment_to_constant.rb +2 -3
  160. data/lib/rubocop/cop/lint/percent_string_array.rb +1 -1
  161. data/lib/rubocop/cop/lint/percent_symbol_array.rb +1 -1
  162. data/lib/rubocop/cop/lint/raise_exception.rb +1 -1
  163. data/lib/rubocop/cop/lint/rand_one.rb +1 -1
  164. data/lib/rubocop/cop/lint/redundant_cop_disable_directive.rb +1 -1
  165. data/lib/rubocop/cop/lint/redundant_cop_enable_directive.rb +1 -1
  166. data/lib/rubocop/cop/lint/redundant_require_statement.rb +3 -0
  167. data/lib/rubocop/cop/lint/redundant_safe_navigation.rb +3 -3
  168. data/lib/rubocop/cop/lint/redundant_splat_expansion.rb +1 -1
  169. data/lib/rubocop/cop/lint/redundant_string_coercion.rb +1 -1
  170. data/lib/rubocop/cop/lint/redundant_with_index.rb +1 -1
  171. data/lib/rubocop/cop/lint/redundant_with_object.rb +1 -1
  172. data/lib/rubocop/cop/lint/refinement_import_methods.rb +1 -1
  173. data/lib/rubocop/cop/lint/regexp_as_condition.rb +1 -1
  174. data/lib/rubocop/cop/lint/require_parentheses.rb +1 -1
  175. data/lib/rubocop/cop/lint/rescue_exception.rb +1 -1
  176. data/lib/rubocop/cop/lint/return_in_void_context.rb +1 -1
  177. data/lib/rubocop/cop/lint/safe_navigation_chain.rb +3 -0
  178. data/lib/rubocop/cop/lint/safe_navigation_consistency.rb +1 -1
  179. data/lib/rubocop/cop/lint/safe_navigation_with_empty.rb +1 -1
  180. data/lib/rubocop/cop/lint/script_permission.rb +1 -1
  181. data/lib/rubocop/cop/lint/self_assignment.rb +1 -1
  182. data/lib/rubocop/cop/lint/shadowed_argument.rb +1 -1
  183. data/lib/rubocop/cop/lint/shadowed_exception.rb +1 -1
  184. data/lib/rubocop/cop/lint/shadowing_outer_local_variable.rb +1 -1
  185. data/lib/rubocop/cop/lint/struct_new_override.rb +1 -1
  186. data/lib/rubocop/cop/lint/suppressed_exception.rb +1 -1
  187. data/lib/rubocop/cop/lint/symbol_conversion.rb +1 -1
  188. data/lib/rubocop/cop/lint/syntax.rb +1 -1
  189. data/lib/rubocop/cop/lint/to_enum_arguments.rb +1 -1
  190. data/lib/rubocop/cop/lint/to_json.rb +1 -1
  191. data/lib/rubocop/cop/lint/top_level_return_with_argument.rb +1 -1
  192. data/lib/rubocop/cop/lint/trailing_comma_in_attribute_declaration.rb +1 -1
  193. data/lib/rubocop/cop/lint/triple_quotes.rb +1 -1
  194. data/lib/rubocop/cop/lint/underscore_prefixed_variable_name.rb +1 -1
  195. data/lib/rubocop/cop/lint/unexpected_block_arity.rb +1 -1
  196. data/lib/rubocop/cop/lint/unified_integer.rb +3 -1
  197. data/lib/rubocop/cop/lint/unreachable_code.rb +1 -1
  198. data/lib/rubocop/cop/lint/unreachable_loop.rb +1 -1
  199. data/lib/rubocop/cop/lint/unused_block_argument.rb +1 -1
  200. data/lib/rubocop/cop/lint/unused_method_argument.rb +1 -1
  201. data/lib/rubocop/cop/lint/uri_escape_unescape.rb +1 -1
  202. data/lib/rubocop/cop/lint/uri_regexp.rb +1 -1
  203. data/lib/rubocop/cop/lint/useless_access_modifier.rb +1 -1
  204. data/lib/rubocop/cop/lint/useless_assignment.rb +1 -1
  205. data/lib/rubocop/cop/lint/useless_method_definition.rb +1 -1
  206. data/lib/rubocop/cop/lint/useless_ruby2_keywords.rb +1 -1
  207. data/lib/rubocop/cop/lint/useless_setter_call.rb +2 -2
  208. data/lib/rubocop/cop/lint/useless_times.rb +1 -1
  209. data/lib/rubocop/cop/lint/void.rb +1 -1
  210. data/lib/rubocop/cop/metrics/abc_size.rb +1 -1
  211. data/lib/rubocop/cop/metrics/block_length.rb +1 -1
  212. data/lib/rubocop/cop/metrics/block_nesting.rb +1 -1
  213. data/lib/rubocop/cop/metrics/class_length.rb +1 -1
  214. data/lib/rubocop/cop/metrics/cyclomatic_complexity.rb +1 -1
  215. data/lib/rubocop/cop/metrics/method_length.rb +1 -1
  216. data/lib/rubocop/cop/metrics/module_length.rb +1 -1
  217. data/lib/rubocop/cop/metrics/parameter_lists.rb +1 -1
  218. data/lib/rubocop/cop/metrics/perceived_complexity.rb +1 -1
  219. data/lib/rubocop/cop/mixin/hash_shorthand_syntax.rb +7 -2
  220. data/lib/rubocop/cop/mixin/string_help.rb +1 -1
  221. data/lib/rubocop/cop/naming/accessor_method_name.rb +1 -1
  222. data/lib/rubocop/cop/naming/ascii_identifiers.rb +1 -1
  223. data/lib/rubocop/cop/naming/binary_operator_parameter_name.rb +1 -1
  224. data/lib/rubocop/cop/naming/block_forwarding.rb +2 -2
  225. data/lib/rubocop/cop/naming/block_parameter_name.rb +1 -1
  226. data/lib/rubocop/cop/naming/class_and_module_camel_case.rb +1 -1
  227. data/lib/rubocop/cop/naming/constant_name.rb +1 -1
  228. data/lib/rubocop/cop/naming/file_name.rb +1 -1
  229. data/lib/rubocop/cop/naming/heredoc_delimiter_case.rb +1 -1
  230. data/lib/rubocop/cop/naming/heredoc_delimiter_naming.rb +1 -1
  231. data/lib/rubocop/cop/naming/memoized_instance_variable_name.rb +1 -1
  232. data/lib/rubocop/cop/naming/method_name.rb +1 -1
  233. data/lib/rubocop/cop/naming/method_parameter_name.rb +1 -1
  234. data/lib/rubocop/cop/naming/predicate_name.rb +1 -1
  235. data/lib/rubocop/cop/naming/rescued_exceptions_variable_name.rb +1 -1
  236. data/lib/rubocop/cop/naming/variable_name.rb +1 -1
  237. data/lib/rubocop/cop/naming/variable_number.rb +1 -1
  238. data/lib/rubocop/cop/security/compound_hash.rb +1 -1
  239. data/lib/rubocop/cop/security/eval.rb +1 -1
  240. data/lib/rubocop/cop/security/json_load.rb +1 -1
  241. data/lib/rubocop/cop/security/marshal_load.rb +1 -1
  242. data/lib/rubocop/cop/security/open.rb +1 -1
  243. data/lib/rubocop/cop/security/yaml_load.rb +1 -1
  244. data/lib/rubocop/cop/style/accessor_grouping.rb +3 -3
  245. data/lib/rubocop/cop/style/alias.rb +1 -1
  246. data/lib/rubocop/cop/style/and_or.rb +3 -3
  247. data/lib/rubocop/cop/style/array_coercion.rb +1 -1
  248. data/lib/rubocop/cop/style/array_join.rb +1 -1
  249. data/lib/rubocop/cop/style/ascii_comments.rb +1 -1
  250. data/lib/rubocop/cop/style/attr.rb +1 -1
  251. data/lib/rubocop/cop/style/auto_resource_cleanup.rb +1 -1
  252. data/lib/rubocop/cop/style/bare_percent_literals.rb +1 -1
  253. data/lib/rubocop/cop/style/bisected_attr_accessor.rb +1 -1
  254. data/lib/rubocop/cop/style/block_comments.rb +1 -1
  255. data/lib/rubocop/cop/style/case_equality.rb +1 -1
  256. data/lib/rubocop/cop/style/case_like_if.rb +1 -1
  257. data/lib/rubocop/cop/style/class_and_module_children.rb +1 -1
  258. data/lib/rubocop/cop/style/class_check.rb +1 -1
  259. data/lib/rubocop/cop/style/class_equality_comparison.rb +1 -1
  260. data/lib/rubocop/cop/style/class_methods.rb +1 -1
  261. data/lib/rubocop/cop/style/class_methods_definitions.rb +1 -1
  262. data/lib/rubocop/cop/style/class_vars.rb +1 -1
  263. data/lib/rubocop/cop/style/collection_compact.rb +1 -1
  264. data/lib/rubocop/cop/style/collection_methods.rb +1 -1
  265. data/lib/rubocop/cop/style/colon_method_call.rb +1 -1
  266. data/lib/rubocop/cop/style/colon_method_definition.rb +1 -1
  267. data/lib/rubocop/cop/style/combinable_loops.rb +1 -1
  268. data/lib/rubocop/cop/style/command_literal.rb +1 -1
  269. data/lib/rubocop/cop/style/comment_annotation.rb +1 -1
  270. data/lib/rubocop/cop/style/commented_keyword.rb +3 -3
  271. data/lib/rubocop/cop/style/conditional_assignment.rb +1 -1
  272. data/lib/rubocop/cop/style/constant_visibility.rb +1 -1
  273. data/lib/rubocop/cop/style/date_time.rb +1 -1
  274. data/lib/rubocop/cop/style/def_with_parentheses.rb +1 -1
  275. data/lib/rubocop/cop/style/dir.rb +4 -1
  276. data/lib/rubocop/cop/style/documentation.rb +1 -1
  277. data/lib/rubocop/cop/style/documentation_method.rb +1 -1
  278. data/lib/rubocop/cop/style/double_negation.rb +1 -1
  279. data/lib/rubocop/cop/style/each_for_simple_loop.rb +1 -1
  280. data/lib/rubocop/cop/style/each_with_object.rb +1 -1
  281. data/lib/rubocop/cop/style/empty_block_parameter.rb +1 -1
  282. data/lib/rubocop/cop/style/empty_case_condition.rb +1 -1
  283. data/lib/rubocop/cop/style/empty_lambda_parameter.rb +1 -1
  284. data/lib/rubocop/cop/style/empty_literal.rb +1 -1
  285. data/lib/rubocop/cop/style/empty_method.rb +1 -1
  286. data/lib/rubocop/cop/style/encoding.rb +1 -1
  287. data/lib/rubocop/cop/style/end_block.rb +1 -1
  288. data/lib/rubocop/cop/style/endless_method.rb +1 -1
  289. data/lib/rubocop/cop/style/env_home.rb +1 -1
  290. data/lib/rubocop/cop/style/eval_with_location.rb +1 -1
  291. data/lib/rubocop/cop/style/even_odd.rb +1 -1
  292. data/lib/rubocop/cop/style/expand_path_arguments.rb +1 -1
  293. data/lib/rubocop/cop/style/explicit_block_argument.rb +1 -1
  294. data/lib/rubocop/cop/style/exponential_notation.rb +1 -1
  295. data/lib/rubocop/cop/style/fetch_env_var.rb +56 -83
  296. data/lib/rubocop/cop/style/float_division.rb +1 -1
  297. data/lib/rubocop/cop/style/for.rb +1 -1
  298. data/lib/rubocop/cop/style/format_string.rb +1 -1
  299. data/lib/rubocop/cop/style/frozen_string_literal_comment.rb +5 -2
  300. data/lib/rubocop/cop/style/global_std_stream.rb +1 -1
  301. data/lib/rubocop/cop/style/global_vars.rb +1 -1
  302. data/lib/rubocop/cop/style/guard_clause.rb +1 -1
  303. data/lib/rubocop/cop/style/hash_conversion.rb +1 -1
  304. data/lib/rubocop/cop/style/hash_each_methods.rb +1 -1
  305. data/lib/rubocop/cop/style/hash_except.rb +1 -1
  306. data/lib/rubocop/cop/style/hash_like_case.rb +1 -1
  307. data/lib/rubocop/cop/style/hash_syntax.rb +1 -1
  308. data/lib/rubocop/cop/style/hash_transform_keys.rb +6 -1
  309. data/lib/rubocop/cop/style/hash_transform_values.rb +4 -1
  310. data/lib/rubocop/cop/style/identical_conditional_branches.rb +2 -2
  311. data/lib/rubocop/cop/style/if_with_boolean_literal_branches.rb +2 -2
  312. data/lib/rubocop/cop/style/implicit_runtime_error.rb +1 -1
  313. data/lib/rubocop/cop/style/in_pattern_then.rb +1 -1
  314. data/lib/rubocop/cop/style/inline_comment.rb +1 -1
  315. data/lib/rubocop/cop/style/inverse_methods.rb +2 -2
  316. data/lib/rubocop/cop/style/ip_addresses.rb +1 -1
  317. data/lib/rubocop/cop/style/keyword_parameters_order.rb +1 -1
  318. data/lib/rubocop/cop/style/lambda.rb +1 -1
  319. data/lib/rubocop/cop/style/lambda_call.rb +1 -1
  320. data/lib/rubocop/cop/style/line_end_concatenation.rb +1 -1
  321. data/lib/rubocop/cop/style/map_compact_with_conditional_block.rb +136 -0
  322. data/lib/rubocop/cop/style/map_to_hash.rb +2 -2
  323. data/lib/rubocop/cop/style/method_call_with_args_parentheses.rb +1 -1
  324. data/lib/rubocop/cop/style/method_call_without_args_parentheses.rb +1 -1
  325. data/lib/rubocop/cop/style/method_called_on_do_end_block.rb +1 -1
  326. data/lib/rubocop/cop/style/method_def_parentheses.rb +1 -1
  327. data/lib/rubocop/cop/style/min_max.rb +1 -1
  328. data/lib/rubocop/cop/style/missing_respond_to_missing.rb +1 -1
  329. data/lib/rubocop/cop/style/mixin_grouping.rb +1 -1
  330. data/lib/rubocop/cop/style/mixin_usage.rb +1 -1
  331. data/lib/rubocop/cop/style/module_function.rb +1 -1
  332. data/lib/rubocop/cop/style/multiline_block_chain.rb +1 -1
  333. data/lib/rubocop/cop/style/multiline_in_pattern_then.rb +1 -1
  334. data/lib/rubocop/cop/style/multiline_memoization.rb +1 -1
  335. data/lib/rubocop/cop/style/multiline_method_signature.rb +1 -1
  336. data/lib/rubocop/cop/style/multiline_ternary_operator.rb +2 -2
  337. data/lib/rubocop/cop/style/multiline_when_then.rb +1 -1
  338. data/lib/rubocop/cop/style/multiple_comparison.rb +1 -1
  339. data/lib/rubocop/cop/style/mutable_constant.rb +1 -1
  340. data/lib/rubocop/cop/style/negated_if_else_condition.rb +1 -1
  341. data/lib/rubocop/cop/style/nested_file_dirname.rb +1 -1
  342. data/lib/rubocop/cop/style/nested_modifier.rb +1 -1
  343. data/lib/rubocop/cop/style/nested_parenthesized_calls.rb +1 -1
  344. data/lib/rubocop/cop/style/nested_ternary_operator.rb +1 -1
  345. data/lib/rubocop/cop/style/nil_comparison.rb +1 -1
  346. data/lib/rubocop/cop/style/nil_lambda.rb +1 -1
  347. data/lib/rubocop/cop/style/non_nil_check.rb +1 -1
  348. data/lib/rubocop/cop/style/not.rb +1 -1
  349. data/lib/rubocop/cop/style/numbered_parameters.rb +1 -1
  350. data/lib/rubocop/cop/style/numbered_parameters_limit.rb +1 -1
  351. data/lib/rubocop/cop/style/numeric_literal_prefix.rb +1 -1
  352. data/lib/rubocop/cop/style/numeric_literals.rb +1 -1
  353. data/lib/rubocop/cop/style/numeric_predicate.rb +10 -2
  354. data/lib/rubocop/cop/style/object_then.rb +1 -1
  355. data/lib/rubocop/cop/style/one_line_conditional.rb +1 -1
  356. data/lib/rubocop/cop/style/open_struct_use.rb +1 -1
  357. data/lib/rubocop/cop/style/option_hash.rb +1 -1
  358. data/lib/rubocop/cop/style/optional_arguments.rb +1 -1
  359. data/lib/rubocop/cop/style/optional_boolean_parameter.rb +1 -1
  360. data/lib/rubocop/cop/style/or_assignment.rb +1 -1
  361. data/lib/rubocop/cop/style/parentheses_around_condition.rb +1 -1
  362. data/lib/rubocop/cop/style/percent_literal_delimiters.rb +1 -1
  363. data/lib/rubocop/cop/style/percent_q_literals.rb +1 -1
  364. data/lib/rubocop/cop/style/perl_backrefs.rb +1 -1
  365. data/lib/rubocop/cop/style/preferred_hash_methods.rb +1 -1
  366. data/lib/rubocop/cop/style/proc.rb +1 -1
  367. data/lib/rubocop/cop/style/raise_args.rb +1 -1
  368. data/lib/rubocop/cop/style/random_with_offset.rb +1 -1
  369. data/lib/rubocop/cop/style/redundant_argument.rb +1 -1
  370. data/lib/rubocop/cop/style/redundant_assignment.rb +1 -1
  371. data/lib/rubocop/cop/style/redundant_begin.rb +17 -6
  372. data/lib/rubocop/cop/style/redundant_capital_w.rb +1 -1
  373. data/lib/rubocop/cop/style/redundant_condition.rb +9 -5
  374. data/lib/rubocop/cop/style/redundant_conditional.rb +1 -1
  375. data/lib/rubocop/cop/style/redundant_exception.rb +1 -1
  376. data/lib/rubocop/cop/style/redundant_fetch_block.rb +1 -1
  377. data/lib/rubocop/cop/style/redundant_file_extension_in_require.rb +1 -1
  378. data/lib/rubocop/cop/style/redundant_freeze.rb +1 -1
  379. data/lib/rubocop/cop/style/redundant_interpolation.rb +22 -1
  380. data/lib/rubocop/cop/style/redundant_parentheses.rb +1 -1
  381. data/lib/rubocop/cop/style/redundant_percent_q.rb +1 -1
  382. data/lib/rubocop/cop/style/redundant_regexp_character_class.rb +2 -2
  383. data/lib/rubocop/cop/style/redundant_regexp_escape.rb +1 -1
  384. data/lib/rubocop/cop/style/redundant_return.rb +1 -1
  385. data/lib/rubocop/cop/style/redundant_self.rb +1 -1
  386. data/lib/rubocop/cop/style/redundant_self_assignment.rb +1 -1
  387. data/lib/rubocop/cop/style/redundant_self_assignment_branch.rb +1 -1
  388. data/lib/rubocop/cop/style/redundant_sort.rb +1 -1
  389. data/lib/rubocop/cop/style/redundant_sort_by.rb +1 -1
  390. data/lib/rubocop/cop/style/regexp_literal.rb +1 -1
  391. data/lib/rubocop/cop/style/rescue_modifier.rb +1 -1
  392. data/lib/rubocop/cop/style/rescue_standard_error.rb +3 -3
  393. data/lib/rubocop/cop/style/return_nil.rb +1 -1
  394. data/lib/rubocop/cop/style/safe_navigation.rb +1 -1
  395. data/lib/rubocop/cop/style/sample.rb +1 -1
  396. data/lib/rubocop/cop/style/select_by_regexp.rb +1 -1
  397. data/lib/rubocop/cop/style/self_assignment.rb +1 -1
  398. data/lib/rubocop/cop/style/semicolon.rb +1 -1
  399. data/lib/rubocop/cop/style/send.rb +1 -1
  400. data/lib/rubocop/cop/style/signal_exception.rb +1 -1
  401. data/lib/rubocop/cop/style/single_line_block_params.rb +1 -1
  402. data/lib/rubocop/cop/style/single_line_methods.rb +2 -2
  403. data/lib/rubocop/cop/style/slicing_with_range.rb +1 -1
  404. data/lib/rubocop/cop/style/sole_nested_conditional.rb +26 -7
  405. data/lib/rubocop/cop/style/static_class.rb +1 -1
  406. data/lib/rubocop/cop/style/stderr_puts.rb +1 -1
  407. data/lib/rubocop/cop/style/string_concatenation.rb +1 -1
  408. data/lib/rubocop/cop/style/string_hash_keys.rb +1 -1
  409. data/lib/rubocop/cop/style/string_literals_in_interpolation.rb +1 -1
  410. data/lib/rubocop/cop/style/string_methods.rb +1 -1
  411. data/lib/rubocop/cop/style/strip.rb +1 -1
  412. data/lib/rubocop/cop/style/struct_inheritance.rb +2 -2
  413. data/lib/rubocop/cop/style/swap_values.rb +1 -1
  414. data/lib/rubocop/cop/style/symbol_array.rb +6 -2
  415. data/lib/rubocop/cop/style/symbol_literal.rb +1 -1
  416. data/lib/rubocop/cop/style/symbol_proc.rb +3 -3
  417. data/lib/rubocop/cop/style/ternary_parentheses.rb +1 -1
  418. data/lib/rubocop/cop/style/trailing_body_on_class.rb +1 -1
  419. data/lib/rubocop/cop/style/trailing_body_on_method_definition.rb +1 -1
  420. data/lib/rubocop/cop/style/trailing_body_on_module.rb +1 -1
  421. data/lib/rubocop/cop/style/trailing_comma_in_arguments.rb +1 -1
  422. data/lib/rubocop/cop/style/trailing_comma_in_array_literal.rb +1 -1
  423. data/lib/rubocop/cop/style/trailing_comma_in_block_args.rb +1 -1
  424. data/lib/rubocop/cop/style/trailing_comma_in_hash_literal.rb +1 -1
  425. data/lib/rubocop/cop/style/trailing_method_end_statement.rb +1 -1
  426. data/lib/rubocop/cop/style/trailing_underscore_variable.rb +1 -1
  427. data/lib/rubocop/cop/style/trivial_accessors.rb +1 -1
  428. data/lib/rubocop/cop/style/unless_else.rb +1 -1
  429. data/lib/rubocop/cop/style/unless_logical_operators.rb +1 -1
  430. data/lib/rubocop/cop/style/unpack_first.rb +4 -1
  431. data/lib/rubocop/cop/style/variable_interpolation.rb +1 -1
  432. data/lib/rubocop/cop/style/when_then.rb +1 -1
  433. data/lib/rubocop/cop/style/word_array.rb +1 -1
  434. data/lib/rubocop/cop/style/yoda_condition.rb +1 -1
  435. data/lib/rubocop/cop/style/zero_length_predicate.rb +1 -1
  436. data/lib/rubocop/cop/team.rb +2 -2
  437. data/lib/rubocop/cop/util.rb +1 -1
  438. data/lib/rubocop/formatter/disabled_config_formatter.rb +2 -2
  439. data/lib/rubocop/formatter/markdown_formatter.rb +2 -0
  440. data/lib/rubocop/formatter/simple_text_formatter.rb +4 -2
  441. data/lib/rubocop/magic_comment.rb +27 -2
  442. data/lib/rubocop/options.rb +60 -38
  443. data/lib/rubocop/rake_task.rb +3 -3
  444. data/lib/rubocop/result_cache.rb +2 -1
  445. data/lib/rubocop/rspec/cop_helper.rb +1 -1
  446. data/lib/rubocop/rspec/expect_offense.rb +3 -3
  447. data/lib/rubocop/rspec/shared_contexts.rb +20 -0
  448. data/lib/rubocop/runner.rb +3 -3
  449. data/lib/rubocop/target_ruby.rb +7 -5
  450. data/lib/rubocop/version.rb +1 -1
  451. data/lib/rubocop.rb +2 -0
  452. metadata +8 -5
@@ -73,7 +73,7 @@ module RuboCop
73
73
  # work
74
74
  # end
75
75
  #
76
- # do_someting
76
+ # do_something
77
77
  #
78
78
  # if bar? # <- reports an offense
79
79
  # work
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop checks the usage of pre-2.1 `Hash[args]` method of converting enumerables and
6
+ # Checks the usage of pre-2.1 `Hash[args]` method of converting enumerables and
7
7
  # sequences of values to hashes.
8
8
  #
9
9
  # Correction code from splat argument (`Hash[*ary]`) is not simply determined. For example,
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop checks for uses of `each_key` and `each_value` Hash methods.
6
+ # Checks for uses of `each_key` and `each_value` Hash methods.
7
7
  #
8
8
  # NOTE: If you have an array of two-element arrays, you can put
9
9
  # parentheses around the block arguments to indicate that you're not
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop checks for usages of `Hash#reject`, `Hash#select`, and `Hash#filter` methods
6
+ # Checks for usages of `Hash#reject`, `Hash#select`, and `Hash#filter` methods
7
7
  # that can be replaced with `Hash#except` method.
8
8
  #
9
9
  # This cop should only be enabled on Ruby version 3.0 or higher.
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop checks for places where `case-when` represents a simple 1:1
6
+ # Checks for places where `case-when` represents a simple 1:1
7
7
  # mapping and can be replaced with a hash lookup.
8
8
  #
9
9
  # @example MinBranchesCount: 3 (default)
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop checks hash literal syntax.
6
+ # Checks hash literal syntax.
7
7
  #
8
8
  # It can enforce either the use of the class hash rocket syntax or
9
9
  # the use of the newer Ruby 1.9 syntax (when applicable).
@@ -3,10 +3,12 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop looks for uses of `_.each_with_object({}) {...}`,
6
+ # Looks for uses of `_.each_with_object({}) {...}`,
7
7
  # `_.map {...}.to_h`, and `Hash[_.map {...}]` that are actually just
8
8
  # transforming the keys of a hash, and tries to use a simpler & faster
9
9
  # call to `transform_keys` instead.
10
+ # It should only be enabled on Ruby version 2.5 or newer.
11
+ # (`transform_keys` was added in Ruby 2.5.)
10
12
  #
11
13
  # @safety
12
14
  # This cop is unsafe, as it can produce false positives if we are
@@ -26,6 +28,9 @@ module RuboCop
26
28
  class HashTransformKeys < Base
27
29
  include HashTransformMethod
28
30
  extend AutoCorrector
31
+ extend TargetRubyVersion
32
+
33
+ minimum_target_ruby_version 2.5
29
34
 
30
35
  # @!method on_bad_each_with_object(node)
31
36
  def_node_matcher :on_bad_each_with_object, <<~PATTERN
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop looks for uses of `_.each_with_object({}) {...}`,
6
+ # Looks for uses of `_.each_with_object({}) {...}`,
7
7
  # `_.map {...}.to_h`, and `Hash[_.map {...}]` that are actually just
8
8
  # transforming the values of a hash, and tries to use a simpler & faster
9
9
  # call to `transform_values` instead.
@@ -26,6 +26,9 @@ module RuboCop
26
26
  class HashTransformValues < Base
27
27
  include HashTransformMethod
28
28
  extend AutoCorrector
29
+ extend TargetRubyVersion
30
+
31
+ minimum_target_ruby_version 2.4
29
32
 
30
33
  # @!method on_bad_each_with_object(node)
31
34
  def_node_matcher :on_bad_each_with_object, <<~PATTERN
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop checks for identical expressions at the beginning or end of
6
+ # Checks for identical expressions at the beginning or end of
7
7
  # each branch of a conditional expression. Such expressions should normally
8
8
  # be placed outside the conditional expression - before or after it.
9
9
  #
@@ -12,7 +12,7 @@ module RuboCop
12
12
  # in a future major RuboCop release.
13
13
  #
14
14
  # @safety
15
- # Auto-correction is unsafe because changing the order of method invocations
15
+ # Autocorrection is unsafe because changing the order of method invocations
16
16
  # may change the behavior of the code. For example:
17
17
  #
18
18
  # [source,ruby]
@@ -3,12 +3,12 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop checks for redundant `if` with boolean literal branches.
6
+ # Checks for redundant `if` with boolean literal branches.
7
7
  # It checks only conditions to return boolean value (`true` or `false`) for safe detection.
8
8
  # The conditions to be checked are comparison methods, predicate methods, and double negative.
9
9
  #
10
10
  # @safety
11
- # Auto-correction is unsafe because there is no guarantee that all predicate methods
11
+ # Autocorrection is unsafe because there is no guarantee that all predicate methods
12
12
  # will return a boolean value. Those methods can be allowed with `AllowedMethods` config.
13
13
  #
14
14
  # @example
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop checks for `raise` or `fail` statements which do not specify an
6
+ # Checks for `raise` or `fail` statements which do not specify an
7
7
  # explicit exception class. (This raises a `RuntimeError`. Some projects
8
8
  # might prefer to use exception classes which more precisely identify the
9
9
  # nature of the error.)
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop checks for `in;` uses in `case` expressions.
6
+ # Checks for `in;` uses in `case` expressions.
7
7
  #
8
8
  # @example
9
9
  # # bad
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop checks for trailing inline comments.
6
+ # Checks for trailing inline comments.
7
7
  #
8
8
  # @example
9
9
  #
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop check for usages of not (`not` or `!`) called on a method
6
+ # Check for usages of not (`not` or `!`) called on a method
7
7
  # when an inverse of that method can be used instead.
8
8
  #
9
9
  # Methods that can be inverted by a not (`not` or `!`) should be defined
@@ -94,7 +94,7 @@ module RuboCop
94
94
 
95
95
  # Inverse method offenses inside of the block of an inverse method
96
96
  # offense, such as `y.reject { |key, _value| !(key =~ /c\d/) }`,
97
- # can cause auto-correction to apply improper corrections.
97
+ # can cause autocorrection to apply improper corrections.
98
98
  ignore_node(block)
99
99
  add_offense(node, message: message(method, inverse_blocks[method])) do |corrector|
100
100
  correct_inverse_block(corrector, node)
@@ -5,7 +5,7 @@ require 'resolv'
5
5
  module RuboCop
6
6
  module Cop
7
7
  module Style
8
- # This cop checks for hardcoded IP addresses, which can make code
8
+ # Checks for hardcoded IP addresses, which can make code
9
9
  # brittle. IP addresses are likely to need to be changed when code
10
10
  # is deployed to a different server or environment, which may break
11
11
  # a deployment if forgotten. Prefer setting IP addresses in ENV or
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop enforces that optional keyword parameters are placed at the
6
+ # Enforces that optional keyword parameters are placed at the
7
7
  # end of the parameters list.
8
8
  #
9
9
  # This improves readability, because when looking through the source,
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop (by default) checks for uses of the lambda literal syntax for
6
+ # (by default) checks for uses of the lambda literal syntax for
7
7
  # single line lambdas, and the method call syntax for multiline lambdas.
8
8
  # It is configurable to enforce one of the styles for both single line
9
9
  # and multiline lambdas as well.
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop checks for use of the lambda.(args) syntax.
6
+ # Checks for use of the lambda.(args) syntax.
7
7
  #
8
8
  # @example EnforcedStyle: call (default)
9
9
  # # bad
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop checks for string literal concatenation at
6
+ # Checks for string literal concatenation at
7
7
  # the end of a line.
8
8
  #
9
9
  # @safety
@@ -0,0 +1,136 @@
1
+ # frozen_string_literal: true
2
+
3
+ module RuboCop
4
+ module Cop
5
+ module Style
6
+ # Prefer `select` or `reject` over `map { ... }.compact`.
7
+ #
8
+ # @example
9
+ #
10
+ # # bad
11
+ # array.map { |e| some_condition? ? e : next }.compact
12
+ #
13
+ # # bad
14
+ # array.map do |e|
15
+ # if some_condition?
16
+ # e
17
+ # else
18
+ # next
19
+ # end
20
+ # end.compact
21
+ #
22
+ # # bad
23
+ # array.map do |e|
24
+ # next if some_condition?
25
+ #
26
+ # e
27
+ # end.compact
28
+ #
29
+ # # bad
30
+ # array.map do |e|
31
+ # e if some_condition?
32
+ # end.compact
33
+ #
34
+ # # good
35
+ # array.select { |e| some_condition? }
36
+ #
37
+ # # good
38
+ # array.reject { |e| some_condition? }
39
+ #
40
+ class MapCompactWithConditionalBlock < Base
41
+ extend AutoCorrector
42
+
43
+ MSG = 'Replace `map { ... }.compact` with `%<method>s`.'
44
+
45
+ # @!method map_and_compact?(node)
46
+ def_node_matcher :map_and_compact?, <<~RUBY
47
+ (send
48
+ (block
49
+ (send _ :map)
50
+ (args
51
+ $(arg _))
52
+ {
53
+ (if $_ $(lvar _) {next nil?})
54
+ (if $_ {next nil?} $(lvar _))
55
+ (if $_ (next $(lvar _)) {next nil nil?})
56
+ (if $_ {next nil nil?} (next $(lvar _)))
57
+ (begin
58
+ {
59
+ (if $_ next nil?)
60
+ (if $_ nil? next)
61
+ }
62
+ $(lvar _))
63
+ (begin
64
+ {
65
+ (if $_ (next $(lvar _)) nil?)
66
+ (if $_ nil? (next $(lvar _)))
67
+ }
68
+ (nil))
69
+ }) :compact)
70
+ RUBY
71
+
72
+ def on_send(node)
73
+ map_and_compact?(node) do |block_argument_node, condition_node, return_value_node|
74
+ return unless returns_block_argument?(block_argument_node, return_value_node)
75
+ return if condition_node.parent.elsif?
76
+
77
+ method = truthy_branch?(return_value_node) ? 'select' : 'reject'
78
+ range = range(node)
79
+
80
+ add_offense(range, message: format(MSG, method: method)) do |corrector|
81
+ corrector.replace(
82
+ range,
83
+ "#{method} { |#{block_argument_node.source}| #{condition_node.source} }"
84
+ )
85
+ end
86
+ end
87
+ end
88
+
89
+ private
90
+
91
+ def returns_block_argument?(block_argument_node, return_value_node)
92
+ block_argument_node.name == return_value_node.children.first
93
+ end
94
+
95
+ def truthy_branch?(node)
96
+ if node.parent.begin_type?
97
+ truthy_branch_for_guard?(node)
98
+ elsif node.parent.next_type?
99
+ truthy_branch_for_if?(node.parent)
100
+ else
101
+ truthy_branch_for_if?(node)
102
+ end
103
+ end
104
+
105
+ def truthy_branch_for_if?(node)
106
+ if_node = node.parent
107
+
108
+ if if_node.if? || if_node.ternary?
109
+ if_node.if_branch == node
110
+ elsif if_node.unless?
111
+ if_node.else_branch == node
112
+ end
113
+ end
114
+
115
+ def truthy_branch_for_guard?(node)
116
+ if_node = node.left_sibling
117
+
118
+ if if_node.if? || if_node.ternary?
119
+ if_node.else_branch.nil?
120
+ elsif if_node.unless?
121
+ if_node.if_branch.nil?
122
+ end
123
+ end
124
+
125
+ def range(node)
126
+ buffer = node.loc.expression.source_buffer
127
+ map_node = node.receiver.send_node
128
+ begin_pos = map_node.loc.selector.begin_pos
129
+ end_pos = node.loc.expression.end_pos
130
+
131
+ Parser::Source::Range.new(buffer, begin_pos, end_pos)
132
+ end
133
+ end
134
+ end
135
+ end
136
+ end
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop looks for uses of `map.to_h` or `collect.to_h` that could be
6
+ # Looks for uses of `map.to_h` or `collect.to_h` that could be
7
7
  # written with just `to_h` in Ruby >= 2.6.
8
8
  #
9
9
  # NOTE: `Style/HashTransformKeys` and `Style/HashTransformValues` will
@@ -47,7 +47,7 @@ module RuboCop
47
47
 
48
48
  message = format(MSG, method: map_node.loc.selector.source)
49
49
  add_offense(map_node.loc.selector, message: message) do |corrector|
50
- # If the `to_h` call already has a block, do not auto-correct.
50
+ # If the `to_h` call already has a block, do not autocorrect.
51
51
  next if to_h_node.block_node
52
52
 
53
53
  autocorrect(corrector, to_h_node, map_node)
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop enforces the presence (default) or absence of parentheses in
6
+ # Enforces the presence (default) or absence of parentheses in
7
7
  # method calls containing parameters.
8
8
  #
9
9
  # In the default style (require_parentheses), macro methods are ignored.
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop checks for unwanted parentheses in parameterless method calls.
6
+ # Checks for unwanted parentheses in parameterless method calls.
7
7
  #
8
8
  # @example
9
9
  # # bad
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop checks for methods called on a do...end block. The point of
6
+ # Checks for methods called on a do...end block. The point of
7
7
  # this check is that it's easy to miss the call tacked on to the block
8
8
  # when reading code.
9
9
  #
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop checks for parentheses around the arguments in method
6
+ # Checks for parentheses around the arguments in method
7
7
  # definitions. Both instance and class/singleton methods are checked.
8
8
  #
9
9
  # Regardless of style, parentheses are necessary for:
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop checks for potential uses of `Enumerable#minmax`.
6
+ # Checks for potential uses of `Enumerable#minmax`.
7
7
  #
8
8
  # @example
9
9
  #
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop checks for the presence of `method_missing` without also
6
+ # Checks for the presence of `method_missing` without also
7
7
  # defining `respond_to_missing?`.
8
8
  #
9
9
  # @example
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop checks for grouping of mixins in `class` and `module` bodies.
6
+ # Checks for grouping of mixins in `class` and `module` bodies.
7
7
  # By default it enforces mixins to be placed in separate declarations,
8
8
  # but it can be configured to enforce grouping them in one declaration.
9
9
  #
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop checks that `include`, `extend` and `prepend` statements appear
6
+ # Checks that `include`, `extend` and `prepend` statements appear
7
7
  # inside classes and modules, not at the top level, so as to not affect
8
8
  # the behavior of `Object`.
9
9
  #
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop checks for use of `extend self` or `module_function` in a
6
+ # Checks for use of `extend self` or `module_function` in a
7
7
  # module.
8
8
  #
9
9
  # Supported styles are: module_function, extend_self, forbidden. `forbidden`
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop checks for chaining of a block after another block that spans
6
+ # Checks for chaining of a block after another block that spans
7
7
  # multiple lines.
8
8
  #
9
9
  # @example
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop checks uses of the `then` keyword in multi-line `in` statement.
6
+ # Checks uses of the `then` keyword in multi-line `in` statement.
7
7
  #
8
8
  # @example
9
9
  # # bad
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop checks expressions wrapping styles for multiline memoization.
6
+ # Checks expressions wrapping styles for multiline memoization.
7
7
  #
8
8
  # @example EnforcedStyle: keyword (default)
9
9
  # # bad
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop checks for method signatures that span multiple lines.
6
+ # Checks for method signatures that span multiple lines.
7
7
  #
8
8
  # @example
9
9
  #
@@ -3,10 +3,10 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop checks for multi-line ternary op expressions.
6
+ # Checks for multi-line ternary op expressions.
7
7
  #
8
8
  # NOTE: `return if ... else ... end` is syntax error. If `return` is used before
9
- # multiline ternary operator expression, it will be auto-corrected to single-line
9
+ # multiline ternary operator expression, it will be autocorrected to single-line
10
10
  # ternary operator. The same is true for `break`, `next`, and method call.
11
11
  #
12
12
  # @example
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop checks uses of the `then` keyword
6
+ # Checks uses of the `then` keyword
7
7
  # in multi-line when statements.
8
8
  #
9
9
  # @example
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop checks against comparing a variable with multiple items, where
6
+ # Checks against comparing a variable with multiple items, where
7
7
  # `Array#include?`, `Set#include?` or a `case` could be used instead
8
8
  # to avoid code repetition.
9
9
  # It accepts comparisons of multiple method calls to avoid unnecessary method calls
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop checks whether some constant value isn't a
6
+ # Checks whether some constant value isn't a
7
7
  # mutable literal (e.g. array or hash).
8
8
  #
9
9
  # Strict mode can be used to freeze all constants, rather than
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop checks for uses of `if-else` and ternary operators with a negated condition
6
+ # Checks for uses of `if-else` and ternary operators with a negated condition
7
7
  # which can be simplified by inverting condition and swapping branches.
8
8
  #
9
9
  # @example
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop checks for nested `File.dirname`.
6
+ # Checks for nested `File.dirname`.
7
7
  # It replaces nested `File.dirname` with the level argument introduced in Ruby 3.1.
8
8
  #
9
9
  # @example
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop checks for nested use of if, unless, while and until in their
6
+ # Checks for nested use of if, unless, while and until in their
7
7
  # modifier form.
8
8
  #
9
9
  # @example
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop checks for unparenthesized method calls in the argument list
6
+ # Checks for unparenthesized method calls in the argument list
7
7
  # of a parenthesized method call.
8
8
  #
9
9
  # @example
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop checks for nested ternary op expressions.
6
+ # Checks for nested ternary op expressions.
7
7
  #
8
8
  # @example
9
9
  # # bad
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop checks for comparison of something with nil using `==` and
6
+ # Checks for comparison of something with nil using `==` and
7
7
  # `nil?`.
8
8
  #
9
9
  # Supported styles are: predicate, comparison.
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop checks for lambdas and procs that always return nil,
6
+ # Checks for lambdas and procs that always return nil,
7
7
  # which can be replaced with an empty lambda or proc instead.
8
8
  #
9
9
  # @example
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop checks for non-nil checks, which are usually redundant.
6
+ # Checks for non-nil checks, which are usually redundant.
7
7
  #
8
8
  # With `IncludeSemanticChanges` set to `false` by default, this cop
9
9
  # does not report offenses for `!x.nil?` and does no changes that might