rubocop 1.12.1 → 1.13.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (395) hide show
  1. checksums.yaml +4 -4
  2. data/README.md +3 -2
  3. data/config/default.yml +10 -0
  4. data/exe/rubocop +1 -3
  5. data/lib/rubocop.rb +1 -1
  6. data/lib/rubocop/cached_data.rb +1 -3
  7. data/lib/rubocop/cli.rb +4 -6
  8. data/lib/rubocop/cli/command/auto_genenerate_config.rb +9 -19
  9. data/lib/rubocop/cli/command/init_dotfile.rb +1 -3
  10. data/lib/rubocop/cli/command/show_cops.rb +1 -4
  11. data/lib/rubocop/comment_config.rb +2 -7
  12. data/lib/rubocop/config.rb +11 -26
  13. data/lib/rubocop/config_loader.rb +5 -11
  14. data/lib/rubocop/config_loader_resolver.rb +22 -14
  15. data/lib/rubocop/config_obsoletion/cop_rule.rb +1 -2
  16. data/lib/rubocop/config_store.rb +1 -2
  17. data/lib/rubocop/config_validator.rb +5 -10
  18. data/lib/rubocop/cop/autocorrect_logic.rb +3 -8
  19. data/lib/rubocop/cop/badge.rb +1 -2
  20. data/lib/rubocop/cop/base.rb +8 -6
  21. data/lib/rubocop/cop/bundler/duplicated_gem.rb +1 -2
  22. data/lib/rubocop/cop/bundler/gem_comment.rb +42 -8
  23. data/lib/rubocop/cop/bundler/ordered_gems.rb +1 -4
  24. data/lib/rubocop/cop/commissioner.rb +2 -8
  25. data/lib/rubocop/cop/cop.rb +4 -18
  26. data/lib/rubocop/cop/corrector.rb +1 -4
  27. data/lib/rubocop/cop/correctors/alignment_corrector.rb +3 -6
  28. data/lib/rubocop/cop/correctors/each_to_for_corrector.rb +2 -4
  29. data/lib/rubocop/cop/correctors/for_to_each_corrector.rb +1 -2
  30. data/lib/rubocop/cop/correctors/line_break_corrector.rb +3 -6
  31. data/lib/rubocop/cop/correctors/multiline_literal_brace_corrector.rb +1 -3
  32. data/lib/rubocop/cop/correctors/ordered_gem_corrector.rb +1 -3
  33. data/lib/rubocop/cop/correctors/percent_literal_corrector.rb +2 -8
  34. data/lib/rubocop/cop/gemspec/duplicated_assignment.rb +1 -2
  35. data/lib/rubocop/cop/gemspec/ordered_dependencies.rb +1 -4
  36. data/lib/rubocop/cop/generator.rb +1 -4
  37. data/lib/rubocop/cop/generator/configuration_injector.rb +1 -2
  38. data/lib/rubocop/cop/generator/require_file_injector.rb +2 -5
  39. data/lib/rubocop/cop/internal_affairs/example_description.rb +6 -4
  40. data/lib/rubocop/cop/internal_affairs/method_name_equal.rb +2 -5
  41. data/lib/rubocop/cop/internal_affairs/node_destructuring.rb +1 -3
  42. data/lib/rubocop/cop/internal_affairs/node_type_predicate.rb +1 -3
  43. data/lib/rubocop/cop/internal_affairs/offense_location_keyword.rb +1 -2
  44. data/lib/rubocop/cop/internal_affairs/style_detected_api_use.rb +1 -2
  45. data/lib/rubocop/cop/internal_affairs/useless_message_assertion.rb +1 -3
  46. data/lib/rubocop/cop/layout/access_modifier_indentation.rb +1 -2
  47. data/lib/rubocop/cop/layout/argument_alignment.rb +2 -4
  48. data/lib/rubocop/cop/layout/assignment_indentation.rb +2 -4
  49. data/lib/rubocop/cop/layout/begin_end_alignment.rb +1 -4
  50. data/lib/rubocop/cop/layout/block_alignment.rb +7 -19
  51. data/lib/rubocop/cop/layout/case_indentation.rb +1 -3
  52. data/lib/rubocop/cop/layout/class_structure.rb +4 -10
  53. data/lib/rubocop/cop/layout/closing_parenthesis_indentation.rb +4 -15
  54. data/lib/rubocop/cop/layout/comment_indentation.rb +1 -5
  55. data/lib/rubocop/cop/layout/def_end_alignment.rb +2 -6
  56. data/lib/rubocop/cop/layout/dot_position.rb +1 -3
  57. data/lib/rubocop/cop/layout/else_alignment.rb +1 -3
  58. data/lib/rubocop/cop/layout/empty_comment.rb +5 -12
  59. data/lib/rubocop/cop/layout/empty_line_after_guard_clause.rb +2 -5
  60. data/lib/rubocop/cop/layout/empty_line_between_defs.rb +2 -6
  61. data/lib/rubocop/cop/layout/empty_lines.rb +1 -3
  62. data/lib/rubocop/cop/layout/empty_lines_around_access_modifier.rb +8 -18
  63. data/lib/rubocop/cop/layout/empty_lines_around_exception_handling_keywords.rb +2 -8
  64. data/lib/rubocop/cop/layout/end_alignment.rb +1 -2
  65. data/lib/rubocop/cop/layout/end_of_line.rb +1 -1
  66. data/lib/rubocop/cop/layout/extra_spacing.rb +3 -7
  67. data/lib/rubocop/cop/layout/first_array_element_indentation.rb +1 -2
  68. data/lib/rubocop/cop/layout/first_array_element_line_break.rb +1 -2
  69. data/lib/rubocop/cop/layout/first_hash_element_indentation.rb +2 -5
  70. data/lib/rubocop/cop/layout/first_hash_element_line_break.rb +1 -2
  71. data/lib/rubocop/cop/layout/first_method_argument_line_break.rb +1 -2
  72. data/lib/rubocop/cop/layout/first_method_parameter_line_break.rb +1 -2
  73. data/lib/rubocop/cop/layout/hash_alignment.rb +3 -6
  74. data/lib/rubocop/cop/layout/heredoc_argument_closing_parenthesis.rb +2 -9
  75. data/lib/rubocop/cop/layout/heredoc_indentation.rb +2 -6
  76. data/lib/rubocop/cop/layout/indentation_style.rb +1 -3
  77. data/lib/rubocop/cop/layout/indentation_width.rb +1 -2
  78. data/lib/rubocop/cop/layout/initial_indentation.rb +1 -4
  79. data/lib/rubocop/cop/layout/line_length.rb +4 -15
  80. data/lib/rubocop/cop/layout/multiline_array_line_breaks.rb +1 -2
  81. data/lib/rubocop/cop/layout/multiline_block_layout.rb +7 -15
  82. data/lib/rubocop/cop/layout/multiline_hash_key_line_breaks.rb +1 -2
  83. data/lib/rubocop/cop/layout/multiline_method_argument_line_breaks.rb +1 -2
  84. data/lib/rubocop/cop/layout/multiline_method_call_indentation.rb +4 -10
  85. data/lib/rubocop/cop/layout/redundant_line_break.rb +125 -0
  86. data/lib/rubocop/cop/layout/rescue_ensure_alignment.rb +3 -6
  87. data/lib/rubocop/cop/layout/space_after_colon.rb +1 -3
  88. data/lib/rubocop/cop/layout/space_after_method_name.rb +2 -4
  89. data/lib/rubocop/cop/layout/space_around_block_parameters.rb +6 -14
  90. data/lib/rubocop/cop/layout/space_around_equals_in_parameter_default.rb +1 -2
  91. data/lib/rubocop/cop/layout/space_around_keyword.rb +3 -6
  92. data/lib/rubocop/cop/layout/space_around_operators.rb +4 -9
  93. data/lib/rubocop/cop/layout/space_before_block_braces.rb +1 -2
  94. data/lib/rubocop/cop/layout/space_before_brackets.rb +1 -3
  95. data/lib/rubocop/cop/layout/space_before_comment.rb +1 -3
  96. data/lib/rubocop/cop/layout/space_before_first_arg.rb +5 -11
  97. data/lib/rubocop/cop/layout/space_in_lambda_literal.rb +2 -4
  98. data/lib/rubocop/cop/layout/space_inside_array_literal_brackets.rb +5 -10
  99. data/lib/rubocop/cop/layout/space_inside_array_percent_literal.rb +2 -7
  100. data/lib/rubocop/cop/layout/space_inside_block_braces.rb +5 -10
  101. data/lib/rubocop/cop/layout/space_inside_hash_literal_braces.rb +1 -2
  102. data/lib/rubocop/cop/layout/space_inside_reference_brackets.rb +1 -2
  103. data/lib/rubocop/cop/legacy/corrections_proxy.rb +2 -8
  104. data/lib/rubocop/cop/legacy/corrector.rb +1 -3
  105. data/lib/rubocop/cop/lint/ambiguous_assignment.rb +1 -6
  106. data/lib/rubocop/cop/lint/ambiguous_block_association.rb +14 -7
  107. data/lib/rubocop/cop/lint/boolean_symbol.rb +1 -2
  108. data/lib/rubocop/cop/lint/constant_resolution.rb +1 -2
  109. data/lib/rubocop/cop/lint/deprecated_class_methods.rb +2 -4
  110. data/lib/rubocop/cop/lint/deprecated_constants.rb +3 -3
  111. data/lib/rubocop/cop/lint/deprecated_open_ssl_constant.rb +2 -5
  112. data/lib/rubocop/cop/lint/duplicate_branch.rb +1 -2
  113. data/lib/rubocop/cop/lint/duplicate_hash_key.rb +1 -3
  114. data/lib/rubocop/cop/lint/duplicate_methods.rb +3 -7
  115. data/lib/rubocop/cop/lint/else_layout.rb +1 -3
  116. data/lib/rubocop/cop/lint/empty_ensure.rb +1 -3
  117. data/lib/rubocop/cop/lint/empty_file.rb +1 -3
  118. data/lib/rubocop/cop/lint/empty_interpolation.rb +1 -3
  119. data/lib/rubocop/cop/lint/ensure_return.rb +1 -3
  120. data/lib/rubocop/cop/lint/erb_new_arguments.rb +3 -7
  121. data/lib/rubocop/cop/lint/float_out_of_range.rb +1 -2
  122. data/lib/rubocop/cop/lint/format_parameter_mismatch.rb +3 -6
  123. data/lib/rubocop/cop/lint/heredoc_method_call_position.rb +1 -2
  124. data/lib/rubocop/cop/lint/implicit_string_concatenation.rb +1 -2
  125. data/lib/rubocop/cop/lint/ineffective_access_modifier.rb +3 -7
  126. data/lib/rubocop/cop/lint/inherit_exception.rb +1 -2
  127. data/lib/rubocop/cop/lint/interpolation_check.rb +3 -11
  128. data/lib/rubocop/cop/lint/literal_in_interpolation.rb +3 -6
  129. data/lib/rubocop/cop/lint/loop.rb +1 -2
  130. data/lib/rubocop/cop/lint/missing_cop_enable_directive.rb +3 -7
  131. data/lib/rubocop/cop/lint/missing_super.rb +1 -2
  132. data/lib/rubocop/cop/lint/mixed_regexp_capture_types.rb +1 -2
  133. data/lib/rubocop/cop/lint/nested_method_definition.rb +1 -2
  134. data/lib/rubocop/cop/lint/nested_percent_literal.rb +1 -3
  135. data/lib/rubocop/cop/lint/non_deterministic_require_order.rb +1 -3
  136. data/lib/rubocop/cop/lint/number_conversion.rb +1 -2
  137. data/lib/rubocop/cop/lint/ordered_magic_comments.rb +1 -2
  138. data/lib/rubocop/cop/lint/out_of_range_regexp_ref.rb +1 -3
  139. data/lib/rubocop/cop/lint/parentheses_as_grouped_expression.rb +1 -3
  140. data/lib/rubocop/cop/lint/percent_symbol_array.rb +1 -3
  141. data/lib/rubocop/cop/lint/raise_exception.rb +1 -2
  142. data/lib/rubocop/cop/lint/rand_one.rb +1 -2
  143. data/lib/rubocop/cop/lint/redundant_cop_disable_directive.rb +8 -20
  144. data/lib/rubocop/cop/lint/redundant_safe_navigation.rb +1 -3
  145. data/lib/rubocop/cop/lint/redundant_splat_expansion.rb +3 -7
  146. data/lib/rubocop/cop/lint/redundant_string_coercion.rb +1 -2
  147. data/lib/rubocop/cop/lint/redundant_with_index.rb +1 -4
  148. data/lib/rubocop/cop/lint/redundant_with_object.rb +1 -4
  149. data/lib/rubocop/cop/lint/regexp_as_condition.rb +1 -3
  150. data/lib/rubocop/cop/lint/require_parentheses.rb +2 -4
  151. data/lib/rubocop/cop/lint/rescue_exception.rb +1 -2
  152. data/lib/rubocop/cop/lint/rescue_type.rb +2 -7
  153. data/lib/rubocop/cop/lint/return_in_void_context.rb +1 -2
  154. data/lib/rubocop/cop/lint/safe_navigation_chain.rb +1 -2
  155. data/lib/rubocop/cop/lint/safe_navigation_consistency.rb +4 -10
  156. data/lib/rubocop/cop/lint/safe_navigation_with_empty.rb +1 -2
  157. data/lib/rubocop/cop/lint/send_with_mixin_argument.rb +2 -7
  158. data/lib/rubocop/cop/lint/shadowed_argument.rb +4 -11
  159. data/lib/rubocop/cop/lint/shadowed_exception.rb +7 -8
  160. data/lib/rubocop/cop/lint/struct_new_override.rb +1 -2
  161. data/lib/rubocop/cop/lint/symbol_conversion.rb +2 -4
  162. data/lib/rubocop/cop/lint/syntax.rb +1 -3
  163. data/lib/rubocop/cop/lint/to_json.rb +1 -2
  164. data/lib/rubocop/cop/lint/trailing_comma_in_attribute_declaration.rb +1 -3
  165. data/lib/rubocop/cop/lint/underscore_prefixed_variable_name.rb +1 -3
  166. data/lib/rubocop/cop/lint/unreachable_code.rb +2 -5
  167. data/lib/rubocop/cop/lint/unreachable_loop.rb +2 -5
  168. data/lib/rubocop/cop/lint/unused_block_argument.rb +4 -8
  169. data/lib/rubocop/cop/lint/unused_method_argument.rb +1 -2
  170. data/lib/rubocop/cop/lint/useless_access_modifier.rb +2 -4
  171. data/lib/rubocop/cop/lint/useless_assignment.rb +4 -9
  172. data/lib/rubocop/cop/lint/useless_setter_call.rb +1 -3
  173. data/lib/rubocop/cop/lint/void.rb +4 -11
  174. data/lib/rubocop/cop/message_annotator.rb +1 -3
  175. data/lib/rubocop/cop/metrics/block_nesting.rb +2 -7
  176. data/lib/rubocop/cop/metrics/class_length.rb +1 -3
  177. data/lib/rubocop/cop/metrics/cyclomatic_complexity.rb +1 -2
  178. data/lib/rubocop/cop/metrics/module_length.rb +2 -6
  179. data/lib/rubocop/cop/metrics/parameter_lists.rb +2 -5
  180. data/lib/rubocop/cop/metrics/perceived_complexity.rb +1 -2
  181. data/lib/rubocop/cop/metrics/utils/abc_size_calculator.rb +4 -7
  182. data/lib/rubocop/cop/metrics/utils/repeated_attribute_discount.rb +2 -7
  183. data/lib/rubocop/cop/migration/department_name.rb +3 -7
  184. data/lib/rubocop/cop/mixin/alignment.rb +2 -4
  185. data/lib/rubocop/cop/mixin/code_length.rb +1 -3
  186. data/lib/rubocop/cop/mixin/configurable_enforced_style.rb +2 -2
  187. data/lib/rubocop/cop/mixin/configurable_formatting.rb +3 -8
  188. data/lib/rubocop/cop/mixin/def_node.rb +2 -5
  189. data/lib/rubocop/cop/mixin/documentation_comment.rb +2 -5
  190. data/lib/rubocop/cop/mixin/empty_lines_around_body.rb +3 -7
  191. data/lib/rubocop/cop/mixin/empty_parameter.rb +1 -3
  192. data/lib/rubocop/cop/mixin/end_keyword_alignment.rb +1 -3
  193. data/lib/rubocop/cop/mixin/enforce_superclass.rb +2 -6
  194. data/lib/rubocop/cop/mixin/first_element_line_break.rb +1 -3
  195. data/lib/rubocop/cop/mixin/frozen_string_literal.rb +3 -9
  196. data/lib/rubocop/cop/mixin/hash_alignment_styles.rb +3 -6
  197. data/lib/rubocop/cop/mixin/hash_transform_method.rb +7 -22
  198. data/lib/rubocop/cop/mixin/interpolation.rb +1 -3
  199. data/lib/rubocop/cop/mixin/line_length_help.rb +2 -4
  200. data/lib/rubocop/cop/mixin/match_range.rb +2 -5
  201. data/lib/rubocop/cop/mixin/method_complexity.rb +1 -3
  202. data/lib/rubocop/cop/mixin/method_preference.rb +1 -2
  203. data/lib/rubocop/cop/mixin/multiline_element_indentation.rb +1 -2
  204. data/lib/rubocop/cop/mixin/multiline_element_line_breaks.rb +1 -3
  205. data/lib/rubocop/cop/mixin/multiline_expression_indentation.rb +7 -17
  206. data/lib/rubocop/cop/mixin/multiline_literal_brace_layout.rb +1 -2
  207. data/lib/rubocop/cop/mixin/negative_conditional.rb +1 -2
  208. data/lib/rubocop/cop/mixin/ordered_gem_node.rb +1 -4
  209. data/lib/rubocop/cop/mixin/percent_array.rb +1 -3
  210. data/lib/rubocop/cop/mixin/percent_literal.rb +0 -6
  211. data/lib/rubocop/cop/mixin/preceding_following_alignment.rb +5 -11
  212. data/lib/rubocop/cop/mixin/preferred_delimiters.rb +3 -6
  213. data/lib/rubocop/cop/mixin/range_help.rb +10 -13
  214. data/lib/rubocop/cop/mixin/rescue_node.rb +2 -6
  215. data/lib/rubocop/cop/mixin/safe_assignment.rb +1 -2
  216. data/lib/rubocop/cop/mixin/space_after_punctuation.rb +2 -4
  217. data/lib/rubocop/cop/mixin/space_before_punctuation.rb +1 -2
  218. data/lib/rubocop/cop/mixin/statement_modifier.rb +1 -3
  219. data/lib/rubocop/cop/mixin/trailing_body.rb +1 -2
  220. data/lib/rubocop/cop/mixin/trailing_comma.rb +1 -2
  221. data/lib/rubocop/cop/mixin/uncommunicative_name.rb +3 -7
  222. data/lib/rubocop/cop/mixin/unused_argument.rb +1 -3
  223. data/lib/rubocop/cop/naming/ascii_identifiers.rb +2 -4
  224. data/lib/rubocop/cop/naming/binary_operator_parameter_name.rb +1 -2
  225. data/lib/rubocop/cop/naming/file_name.rb +7 -16
  226. data/lib/rubocop/cop/naming/memoized_instance_variable_name.rb +2 -3
  227. data/lib/rubocop/cop/naming/method_name.rb +1 -2
  228. data/lib/rubocop/cop/naming/predicate_name.rb +1 -2
  229. data/lib/rubocop/cop/offense.rb +3 -8
  230. data/lib/rubocop/cop/registry.rb +3 -11
  231. data/lib/rubocop/cop/style/access_modifier_declarations.rb +1 -3
  232. data/lib/rubocop/cop/style/accessor_grouping.rb +1 -3
  233. data/lib/rubocop/cop/style/alias.rb +5 -12
  234. data/lib/rubocop/cop/style/arguments_forwarding.rb +1 -3
  235. data/lib/rubocop/cop/style/ascii_comments.rb +1 -2
  236. data/lib/rubocop/cop/style/attr.rb +1 -3
  237. data/lib/rubocop/cop/style/auto_resource_cleanup.rb +2 -5
  238. data/lib/rubocop/cop/style/bisected_attr_accessor/macro.rb +1 -3
  239. data/lib/rubocop/cop/style/case_like_if.rb +1 -2
  240. data/lib/rubocop/cop/style/character_literal.rb +2 -4
  241. data/lib/rubocop/cop/style/class_and_module_children.rb +3 -6
  242. data/lib/rubocop/cop/style/class_methods.rb +1 -3
  243. data/lib/rubocop/cop/style/collection_compact.rb +1 -3
  244. data/lib/rubocop/cop/style/colon_method_call.rb +1 -3
  245. data/lib/rubocop/cop/style/combinable_loops.rb +3 -2
  246. data/lib/rubocop/cop/style/command_literal.rb +3 -8
  247. data/lib/rubocop/cop/style/comment_annotation.rb +3 -6
  248. data/lib/rubocop/cop/style/commented_keyword.rb +2 -8
  249. data/lib/rubocop/cop/style/conditional_assignment.rb +10 -24
  250. data/lib/rubocop/cop/style/copyright.rb +3 -6
  251. data/lib/rubocop/cop/style/date_time.rb +2 -5
  252. data/lib/rubocop/cop/style/def_with_parentheses.rb +1 -2
  253. data/lib/rubocop/cop/style/each_for_simple_loop.rb +1 -2
  254. data/lib/rubocop/cop/style/empty_case_condition.rb +2 -7
  255. data/lib/rubocop/cop/style/empty_else.rb +3 -9
  256. data/lib/rubocop/cop/style/empty_literal.rb +4 -8
  257. data/lib/rubocop/cop/style/empty_method.rb +3 -7
  258. data/lib/rubocop/cop/style/end_block.rb +1 -2
  259. data/lib/rubocop/cop/style/endless_method.rb +1 -3
  260. data/lib/rubocop/cop/style/eval_with_location.rb +2 -4
  261. data/lib/rubocop/cop/style/expand_path_arguments.rb +1 -3
  262. data/lib/rubocop/cop/style/explicit_block_argument.rb +1 -4
  263. data/lib/rubocop/cop/style/format_string_token.rb +1 -4
  264. data/lib/rubocop/cop/style/frozen_string_literal_comment.rb +3 -8
  265. data/lib/rubocop/cop/style/guard_clause.rb +3 -7
  266. data/lib/rubocop/cop/style/hash_conversion.rb +28 -3
  267. data/lib/rubocop/cop/style/hash_each_methods.rb +1 -2
  268. data/lib/rubocop/cop/style/hash_like_case.rb +1 -2
  269. data/lib/rubocop/cop/style/hash_syntax.rb +4 -9
  270. data/lib/rubocop/cop/style/identical_conditional_branches.rb +1 -3
  271. data/lib/rubocop/cop/style/if_unless_modifier.rb +41 -13
  272. data/lib/rubocop/cop/style/infinite_loop.rb +2 -5
  273. data/lib/rubocop/cop/style/inverse_methods.rb +3 -7
  274. data/lib/rubocop/cop/style/ip_addresses.rb +1 -2
  275. data/lib/rubocop/cop/style/lambda.rb +2 -4
  276. data/lib/rubocop/cop/style/lambda_call.rb +1 -2
  277. data/lib/rubocop/cop/style/line_end_concatenation.rb +5 -12
  278. data/lib/rubocop/cop/style/method_call_with_args_parentheses.rb +1 -1
  279. data/lib/rubocop/cop/style/method_call_with_args_parentheses/omit_parentheses.rb +7 -13
  280. data/lib/rubocop/cop/style/method_call_without_args_parentheses.rb +1 -2
  281. data/lib/rubocop/cop/style/method_called_on_do_end_block.rb +2 -4
  282. data/lib/rubocop/cop/style/method_def_parentheses.rb +4 -8
  283. data/lib/rubocop/cop/style/min_max.rb +1 -2
  284. data/lib/rubocop/cop/style/missing_else.rb +2 -4
  285. data/lib/rubocop/cop/style/missing_respond_to_missing.rb +1 -2
  286. data/lib/rubocop/cop/style/mixin_grouping.rb +4 -10
  287. data/lib/rubocop/cop/style/mixin_usage.rb +1 -2
  288. data/lib/rubocop/cop/style/module_function.rb +3 -6
  289. data/lib/rubocop/cop/style/multiline_block_chain.rb +1 -2
  290. data/lib/rubocop/cop/style/multiline_method_signature.rb +1 -3
  291. data/lib/rubocop/cop/style/multiline_ternary_operator.rb +1 -2
  292. data/lib/rubocop/cop/style/multiple_comparison.rb +2 -4
  293. data/lib/rubocop/cop/style/mutable_constant.rb +4 -10
  294. data/lib/rubocop/cop/style/negated_if.rb +1 -2
  295. data/lib/rubocop/cop/style/negated_unless.rb +1 -2
  296. data/lib/rubocop/cop/style/nested_modifier.rb +3 -7
  297. data/lib/rubocop/cop/style/nested_ternary_operator.rb +2 -3
  298. data/lib/rubocop/cop/style/next.rb +4 -9
  299. data/lib/rubocop/cop/style/non_nil_check.rb +2 -5
  300. data/lib/rubocop/cop/style/numeric_literals.rb +3 -11
  301. data/lib/rubocop/cop/style/numeric_predicate.rb +2 -7
  302. data/lib/rubocop/cop/style/one_line_conditional.rb +1 -2
  303. data/lib/rubocop/cop/style/option_hash.rb +1 -3
  304. data/lib/rubocop/cop/style/optional_arguments.rb +2 -5
  305. data/lib/rubocop/cop/style/or_assignment.rb +2 -6
  306. data/lib/rubocop/cop/style/parallel_assignment.rb +6 -9
  307. data/lib/rubocop/cop/style/percent_literal_delimiters.rb +1 -3
  308. data/lib/rubocop/cop/style/percent_q_literals.rb +1 -2
  309. data/lib/rubocop/cop/style/perl_backrefs.rb +2 -9
  310. data/lib/rubocop/cop/style/preferred_hash_methods.rb +1 -4
  311. data/lib/rubocop/cop/style/proc.rb +1 -2
  312. data/lib/rubocop/cop/style/raise_args.rb +4 -8
  313. data/lib/rubocop/cop/style/random_with_offset.rb +3 -8
  314. data/lib/rubocop/cop/style/redundant_argument.rb +2 -11
  315. data/lib/rubocop/cop/style/redundant_assignment.rb +1 -3
  316. data/lib/rubocop/cop/style/redundant_begin.rb +4 -4
  317. data/lib/rubocop/cop/style/redundant_capital_w.rb +1 -2
  318. data/lib/rubocop/cop/style/redundant_condition.rb +2 -5
  319. data/lib/rubocop/cop/style/redundant_conditional.rb +3 -6
  320. data/lib/rubocop/cop/style/redundant_exception.rb +3 -6
  321. data/lib/rubocop/cop/style/redundant_file_extension_in_require.rb +1 -1
  322. data/lib/rubocop/cop/style/redundant_freeze.rb +1 -2
  323. data/lib/rubocop/cop/style/redundant_interpolation.rb +1 -2
  324. data/lib/rubocop/cop/style/redundant_parentheses.rb +8 -20
  325. data/lib/rubocop/cop/style/redundant_percent_q.rb +1 -2
  326. data/lib/rubocop/cop/style/redundant_regexp_escape.rb +1 -4
  327. data/lib/rubocop/cop/style/redundant_return.rb +3 -5
  328. data/lib/rubocop/cop/style/redundant_self.rb +2 -6
  329. data/lib/rubocop/cop/style/redundant_self_assignment.rb +2 -2
  330. data/lib/rubocop/cop/style/redundant_sort.rb +2 -5
  331. data/lib/rubocop/cop/style/regexp_literal.rb +4 -8
  332. data/lib/rubocop/cop/style/rescue_modifier.rb +4 -0
  333. data/lib/rubocop/cop/style/rescue_standard_error.rb +3 -7
  334. data/lib/rubocop/cop/style/return_nil.rb +1 -2
  335. data/lib/rubocop/cop/style/safe_navigation.rb +10 -21
  336. data/lib/rubocop/cop/style/send.rb +1 -2
  337. data/lib/rubocop/cop/style/signal_exception.rb +3 -7
  338. data/lib/rubocop/cop/style/single_argument_dig.rb +1 -2
  339. data/lib/rubocop/cop/style/single_line_block_params.rb +2 -5
  340. data/lib/rubocop/cop/style/single_line_methods.rb +15 -4
  341. data/lib/rubocop/cop/style/sole_nested_conditional.rb +1 -2
  342. data/lib/rubocop/cop/style/special_global_vars.rb +6 -18
  343. data/lib/rubocop/cop/style/stabby_lambda_parentheses.rb +1 -2
  344. data/lib/rubocop/cop/style/stderr_puts.rb +2 -6
  345. data/lib/rubocop/cop/style/string_chars.rb +2 -1
  346. data/lib/rubocop/cop/style/string_concatenation.rb +8 -10
  347. data/lib/rubocop/cop/style/string_literals.rb +2 -5
  348. data/lib/rubocop/cop/style/struct_inheritance.rb +9 -1
  349. data/lib/rubocop/cop/style/symbol_literal.rb +1 -3
  350. data/lib/rubocop/cop/style/symbol_proc.rb +4 -9
  351. data/lib/rubocop/cop/style/ternary_parentheses.rb +3 -6
  352. data/lib/rubocop/cop/style/trailing_body_on_method_definition.rb +1 -2
  353. data/lib/rubocop/cop/style/trailing_comma_in_block_args.rb +2 -6
  354. data/lib/rubocop/cop/style/trailing_method_end_statement.rb +2 -5
  355. data/lib/rubocop/cop/style/trailing_underscore_variable.rb +4 -10
  356. data/lib/rubocop/cop/style/trivial_accessors.rb +2 -4
  357. data/lib/rubocop/cop/style/unless_else.rb +1 -2
  358. data/lib/rubocop/cop/style/unless_logical_operators.rb +2 -2
  359. data/lib/rubocop/cop/style/variable_interpolation.rb +1 -1
  360. data/lib/rubocop/cop/style/when_then.rb +1 -3
  361. data/lib/rubocop/cop/style/while_until_modifier.rb +1 -2
  362. data/lib/rubocop/cop/style/word_array.rb +1 -2
  363. data/lib/rubocop/cop/style/yoda_condition.rb +3 -11
  364. data/lib/rubocop/cop/style/zero_length_predicate.rb +1 -2
  365. data/lib/rubocop/cop/team.rb +2 -5
  366. data/lib/rubocop/cop/util.rb +4 -10
  367. data/lib/rubocop/cop/utils/format_string.rb +1 -3
  368. data/lib/rubocop/cop/variable_force.rb +6 -15
  369. data/lib/rubocop/cop/variable_force/assignment.rb +1 -2
  370. data/lib/rubocop/cop/variable_force/branch.rb +1 -2
  371. data/lib/rubocop/cop/variable_force/reference.rb +1 -3
  372. data/lib/rubocop/cop/variable_force/scope.rb +4 -8
  373. data/lib/rubocop/cop/variable_force/variable.rb +2 -4
  374. data/lib/rubocop/cops_documentation_generator.rb +7 -21
  375. data/lib/rubocop/file_finder.rb +1 -3
  376. data/lib/rubocop/formatter/disabled_config_formatter.rb +3 -8
  377. data/lib/rubocop/formatter/git_hub_actions_formatter.rb +1 -5
  378. data/lib/rubocop/formatter/html_formatter.rb +4 -10
  379. data/lib/rubocop/formatter/json_formatter.rb +1 -5
  380. data/lib/rubocop/formatter/junit_formatter.rb +3 -9
  381. data/lib/rubocop/formatter/progress_formatter.rb +1 -3
  382. data/lib/rubocop/options.rb +27 -41
  383. data/lib/rubocop/path_util.rb +1 -3
  384. data/lib/rubocop/rake_task.rb +3 -0
  385. data/lib/rubocop/remote_config.rb +4 -7
  386. data/lib/rubocop/result_cache.rb +5 -12
  387. data/lib/rubocop/rspec/cop_helper.rb +1 -1
  388. data/lib/rubocop/rspec/expect_offense.rb +4 -9
  389. data/lib/rubocop/rspec/shared_contexts.rb +4 -15
  390. data/lib/rubocop/runner.rb +7 -14
  391. data/lib/rubocop/target_finder.rb +11 -16
  392. data/lib/rubocop/target_ruby.rb +4 -8
  393. data/lib/rubocop/version.rb +1 -1
  394. metadata +5 -5
  395. data/lib/rubocop/core_ext/hash.rb +0 -20
@@ -90,8 +90,7 @@ module RuboCop
90
90
  end
91
91
 
92
92
  def correct_style?(node)
93
- style == :prefix && node.modifier_form? ||
94
- style == :postfix && !node.modifier_form?
93
+ style == :prefix && node.modifier_form? || style == :postfix && !node.modifier_form?
95
94
  end
96
95
  end
97
96
  end
@@ -80,8 +80,7 @@ module RuboCop
80
80
  end
81
81
 
82
82
  def correct_style?(node)
83
- style == :prefix && node.modifier_form? ||
84
- style == :postfix && !node.modifier_form?
83
+ style == :prefix && node.modifier_form? || style == :postfix && !node.modifier_form?
85
84
  end
86
85
  end
87
86
  end
@@ -31,9 +31,7 @@ module RuboCop
31
31
  return if part_of_ignored_node?(node)
32
32
  return unless modifier?(node) && modifier?(node.parent)
33
33
 
34
- add_offense(node.loc.keyword) do |corrector|
35
- autocorrect(corrector, node)
36
- end
34
+ add_offense(node.loc.keyword) { |corrector| autocorrect(corrector, node) }
37
35
  ignore_node(node)
38
36
  end
39
37
 
@@ -66,8 +64,7 @@ module RuboCop
66
64
 
67
65
  def left_hand_operand(node, operator)
68
66
  expr = node.condition.source
69
- expr = "(#{expr})" if node.condition.or_type? &&
70
- operator == '&&'
67
+ expr = "(#{expr})" if node.condition.or_type? && operator == '&&'
71
68
  expr
72
69
  end
73
70
 
@@ -95,8 +92,7 @@ module RuboCop
95
92
  end
96
93
 
97
94
  def requires_parens?(node)
98
- node.or_type? ||
99
- !(RuboCop::AST::Node::COMPARISON_OPERATORS & node.children).empty?
95
+ node.or_type? || !(RuboCop::AST::Node::COMPARISON_OPERATORS & node.children).empty?
100
96
  end
101
97
  end
102
98
  end
@@ -18,8 +18,7 @@ module RuboCop
18
18
  class NestedTernaryOperator < Base
19
19
  extend AutoCorrector
20
20
 
21
- MSG = 'Ternary operators must not be nested. Prefer `if` or `else` ' \
22
- 'constructs instead.'
21
+ MSG = 'Ternary operators must not be nested. Prefer `if` or `else` constructs instead.'
23
22
 
24
23
  def on_if(node)
25
24
  return unless node.ternary?
@@ -51,7 +50,7 @@ module RuboCop
51
50
  def remove_parentheses(source)
52
51
  return source unless source.start_with?('(')
53
52
 
54
- source.gsub(/\A\(/, '').gsub(/\)\z/, '')
53
+ source.delete_prefix('(').delete_suffix(')')
55
54
  end
56
55
  end
57
56
  end
@@ -66,8 +66,7 @@ module RuboCop
66
66
  end
67
67
 
68
68
  def on_block(node)
69
- return unless node.send_node.send_type? &&
70
- node.send_node.enumerator_method?
69
+ return unless node.send_node.send_type? && node.send_node.enumerator_method?
71
70
 
72
71
  check(node)
73
72
  end
@@ -180,8 +179,7 @@ module RuboCop
180
179
  source_buffer = node.source_range.source_buffer
181
180
  end_pos = node.loc.end.end_pos
182
181
  begin_pos = node.loc.end.begin_pos - node.loc.end.column
183
- begin_pos -= 1 if end_followed_by_whitespace_only?(source_buffer,
184
- end_pos)
182
+ begin_pos -= 1 if end_followed_by_whitespace_only?(source_buffer, end_pos)
185
183
 
186
184
  range_between(begin_pos, end_pos)
187
185
  end
@@ -207,9 +205,7 @@ module RuboCop
207
205
 
208
206
  target_indent = range.source_line =~ /\S/
209
207
  delta = actual_indent(lines, buffer) - target_indent
210
- lines.each do |lineno|
211
- reindent_line(corrector, lineno, delta, buffer)
212
- end
208
+ lines.each { |lineno| reindent_line(corrector, lineno, delta, buffer) }
213
209
  end
214
210
 
215
211
  def actual_indent(lines, buffer)
@@ -230,8 +226,7 @@ module RuboCop
230
226
  if adjustment.positive?
231
227
  corrector.remove_leading(buffer.line_range(lineno), adjustment)
232
228
  elsif adjustment.negative?
233
- corrector.insert_before(buffer.line_range(lineno),
234
- ' ' * -adjustment)
229
+ corrector.insert_before(buffer.line_range(lineno), ' ' * -adjustment)
235
230
  end
236
231
  end
237
232
  end
@@ -67,9 +67,7 @@ module RuboCop
67
67
  return unless register_offense?(node)
68
68
 
69
69
  message = message(node)
70
- add_offense(node, message: message) do |corrector|
71
- autocorrect(corrector, node)
72
- end
70
+ add_offense(node, message: message) { |corrector| autocorrect(corrector, node) }
73
71
  end
74
72
 
75
73
  def on_def(node)
@@ -106,8 +104,7 @@ module RuboCop
106
104
  def unless_and_nil_check?(send_node)
107
105
  parent = send_node.parent
108
106
 
109
- nil_check?(send_node) && unless_check?(parent) && !parent.ternary? &&
110
- parent.unless?
107
+ nil_check?(send_node) && unless_check?(parent) && !parent.ternary? && parent.unless?
111
108
  end
112
109
 
113
110
  def message(node)
@@ -31,8 +31,7 @@ module RuboCop
31
31
  include IntegerNode
32
32
  extend AutoCorrector
33
33
 
34
- MSG = 'Use underscores(_) as thousands separator and ' \
35
- 'separate every 3 digits with them.'
34
+ MSG = 'Use underscores(_) as thousands separator and separate every 3 digits with them.'
36
35
  DELIMITER_REGEXP = /[eE.]/.freeze
37
36
 
38
37
  # The parameter is called MinDigits (meaning the minimum number of
@@ -70,9 +69,7 @@ module RuboCop
70
69
  end
71
70
 
72
71
  def register_offense(node)
73
- add_offense(node) do |corrector|
74
- corrector.replace(node, format_number(node))
75
- end
72
+ add_offense(node) { |corrector| corrector.replace(node, format_number(node)) }
76
73
  end
77
74
 
78
75
  def short_group_regex
@@ -95,12 +92,7 @@ module RuboCop
95
92
  # @param int_part [String]
96
93
  def format_int_part(int_part)
97
94
  int_part = Integer(int_part)
98
- formatted_int = int_part
99
- .abs
100
- .to_s
101
- .reverse
102
- .gsub(/...(?=.)/, '\&_')
103
- .reverse
95
+ formatted_int = int_part.abs.to_s.reverse.gsub(/...(?=.)/, '\&_').reverse
104
96
  formatted_int.insert(0, '-') if int_part.negative?
105
97
  formatted_int
106
98
  end
@@ -48,11 +48,7 @@ module RuboCop
48
48
 
49
49
  MSG = 'Use `%<prefer>s` instead of `%<current>s`.'
50
50
 
51
- REPLACEMENTS = {
52
- 'zero?' => '==',
53
- 'positive?' => '>',
54
- 'negative?' => '<'
55
- }.freeze
51
+ REPLACEMENTS = { 'zero?' => '==', 'positive?' => '>', 'negative?' => '<' }.freeze
56
52
 
57
53
  RESTRICT_ON_SEND = %i[== > < positive? negative? zero?].freeze
58
54
 
@@ -88,8 +84,7 @@ module RuboCop
88
84
 
89
85
  def replacement(numeric, operation)
90
86
  if style == :predicate
91
- [parenthesized_source(numeric),
92
- REPLACEMENTS.invert[operation.to_s]].join('.')
87
+ [parenthesized_source(numeric), REPLACEMENTS.invert[operation.to_s]].join('.')
93
88
  else
94
89
  [numeric.source, REPLACEMENTS[operation.to_s], 0].join(' ')
95
90
  end
@@ -139,8 +139,7 @@ module RuboCop
139
139
  return false unless node.keyword?
140
140
  return true if node.respond_to?(:prefix_not?) && node.prefix_not?
141
141
 
142
- node.respond_to?(:arguments?) && node.arguments? &&
143
- !node.parenthesized_call?
142
+ node.respond_to?(:arguments?) && node.arguments? && !node.parenthesized_call?
144
143
  end
145
144
  end
146
145
  end
@@ -31,9 +31,7 @@ module RuboCop
31
31
  return if super_used?(node)
32
32
  return if allowlist.include?(node.parent.method_name.to_s)
33
33
 
34
- option_hash(node) do |options|
35
- add_offense(options)
36
- end
34
+ option_hash(node) { |options| add_offense(options) }
37
35
  end
38
36
 
39
37
  private
@@ -18,13 +18,10 @@ module RuboCop
18
18
  # def foobar(a = 1, b = 2, c = 3)
19
19
  # end
20
20
  class OptionalArguments < Base
21
- MSG = 'Optional arguments should appear at the end ' \
22
- 'of the argument list.'
21
+ MSG = 'Optional arguments should appear at the end of the argument list.'
23
22
 
24
23
  def on_def(node)
25
- each_misplaced_optional_arg(node.arguments) do |argument|
26
- add_offense(argument)
27
- end
24
+ each_misplaced_optional_arg(node.arguments) { |argument| add_offense(argument) }
28
25
  end
29
26
 
30
27
  private
@@ -51,18 +51,14 @@ module RuboCop
51
51
  def on_if(node)
52
52
  return unless unless_assignment?(node)
53
53
 
54
- add_offense(node) do |corrector|
55
- autocorrect(corrector, node)
56
- end
54
+ add_offense(node) { |corrector| autocorrect(corrector, node) }
57
55
  end
58
56
 
59
57
  def on_lvasgn(node)
60
58
  return unless (else_branch = ternary_assignment?(node))
61
59
  return if else_branch.if_type?
62
60
 
63
- add_offense(node) do |corrector|
64
- autocorrect(corrector, node)
65
- end
61
+ add_offense(node) { |corrector| autocorrect(corrector, node) }
66
62
  end
67
63
 
68
64
  alias on_ivasgn on_lvasgn
@@ -36,9 +36,7 @@ module RuboCop
36
36
  return if allowed_lhs?(lhs) || allowed_rhs?(rhs) ||
37
37
  allowed_masign?(lhs_elements, rhs_elements)
38
38
 
39
- add_offense(node) do |corrector|
40
- autocorrect(corrector, node)
41
- end
39
+ add_offense(node) { |corrector| autocorrect(corrector, node) }
42
40
  end
43
41
 
44
42
  private
@@ -72,9 +70,7 @@ module RuboCop
72
70
  elements = Array(node).compact
73
71
 
74
72
  # Account for edge case of `Constant::CONSTANT`
75
- !node.array_type? ||
76
- return_of_method_call?(node) ||
77
- elements.any?(&:splat_type?)
73
+ !node.array_type? || return_of_method_call?(node) || elements.any?(&:splat_type?)
78
74
  end
79
75
 
80
76
  def return_of_method_call?(node)
@@ -164,9 +160,10 @@ module RuboCop
164
160
  # Does `rhs` access the same value which is assigned by `lhs`?
165
161
  def accesses?(rhs, lhs)
166
162
  if lhs.method?(:[]=)
167
- matching_calls(rhs, lhs.receiver, :[]).any? do |args|
168
- args == lhs.arguments
169
- end
163
+ # FIXME: Workaround `rubocop:disable` comment for JRuby.
164
+ # rubocop:disable Performance/RedundantEqualityComparisonBlock
165
+ matching_calls(rhs, lhs.receiver, :[]).any? { |args| args == lhs.arguments }
166
+ # rubocop:enable Performance/RedundantEqualityComparisonBlock
170
167
  else
171
168
  access_method = lhs.method_name.to_s.chop.to_sym
172
169
  matching_calls(rhs, lhs.receiver, access_method).any?
@@ -72,9 +72,7 @@ module RuboCop
72
72
  end
73
73
 
74
74
  def preferred_delimiters_for(type)
75
- PreferredDelimiters
76
- .new(type, @config, nil)
77
- .delimiters
75
+ PreferredDelimiters.new(type, @config, nil).delimiters
78
76
  end
79
77
 
80
78
  def uses_preferred_delimiter?(node, type)
@@ -30,8 +30,7 @@ module RuboCop
30
30
  include ConfigurableEnforcedStyle
31
31
  extend AutoCorrector
32
32
 
33
- LOWER_CASE_Q_MSG = 'Do not use `%Q` unless interpolation is ' \
34
- 'needed. Use `%q`.'
33
+ LOWER_CASE_Q_MSG = 'Do not use `%Q` unless interpolation is needed. Use `%q`.'
35
34
  UPPER_CASE_Q_MSG = 'Use `%Q` instead of `%q`.'
36
35
 
37
36
  def on_str(node)
@@ -36,11 +36,7 @@ module RuboCop
36
36
  # @param [RuboCop::AST::Node] node
37
37
  # @return [Boolean]
38
38
  def derived_from_braceless_interpolation?(node)
39
- %i[
40
- dstr
41
- regexp
42
- xstr
43
- ].include?(node.parent&.type)
39
+ %i[dstr regexp xstr].include?(node.parent&.type)
44
40
  end
45
41
 
46
42
  # @private
@@ -95,10 +91,7 @@ module RuboCop
95
91
 
96
92
  add_offense(
97
93
  node,
98
- message: format_message(
99
- node: node,
100
- preferred_expression: preferred_expression
101
- )
94
+ message: format_message(node: node, preferred_expression: preferred_expression)
102
95
  ) do |corrector|
103
96
  if derived_from_braceless_interpolation?(node)
104
97
  preferred_expression = "{#{preferred_expression}}"
@@ -31,10 +31,7 @@ module RuboCop
31
31
 
32
32
  MSG = 'Use `Hash#%<prefer>s` instead of `Hash#%<current>s`.'
33
33
 
34
- OFFENDING_SELECTORS = {
35
- short: %i[has_key? has_value?],
36
- verbose: %i[key? value?]
37
- }.freeze
34
+ OFFENDING_SELECTORS = { short: %i[has_key? has_value?], verbose: %i[key? value?] }.freeze
38
35
 
39
36
  RESTRICT_ON_SEND = OFFENDING_SELECTORS.values.flatten.freeze
40
37
 
@@ -19,8 +19,7 @@ module RuboCop
19
19
  MSG = 'Use `proc` instead of `Proc.new`.'
20
20
 
21
21
  # @!method proc_new?(node)
22
- def_node_matcher :proc_new?,
23
- '(block $(send (const {nil? cbase} :Proc) :new) ...)'
22
+ def_node_matcher :proc_new?, '(block $(send (const {nil? cbase} :Proc) :new) ...)'
24
23
 
25
24
  def on_block(node)
26
25
  proc_new?(node) do |block_method|
@@ -43,10 +43,8 @@ module RuboCop
43
43
  include ConfigurableEnforcedStyle
44
44
  extend AutoCorrector
45
45
 
46
- EXPLODED_MSG = 'Provide an exception class and message ' \
47
- 'as arguments to `%<method>s`.'
48
- COMPACT_MSG = 'Provide an exception object ' \
49
- 'as an argument to `%<method>s`.'
46
+ EXPLODED_MSG = 'Provide an exception class and message as arguments to `%<method>s`.'
47
+ COMPACT_MSG = 'Provide an exception object as an argument to `%<method>s`.'
50
48
 
51
49
  RESTRICT_ON_SEND = %i[raise fail].freeze
52
50
 
@@ -66,8 +64,7 @@ module RuboCop
66
64
  def correction_compact_to_exploded(node)
67
65
  exception_node, _new, message_node = *node.first_argument
68
66
 
69
- arguments =
70
- [exception_node, message_node].compact.map(&:source).join(', ')
67
+ arguments = [exception_node, message_node].compact.map(&:source).join(', ')
71
68
 
72
69
  if node.parent && requires_parens?(node.parent)
73
70
  "#{node.method_name}(#{arguments})"
@@ -142,8 +139,7 @@ module RuboCop
142
139
  end
143
140
 
144
141
  def requires_parens?(parent)
145
- parent.and_type? || parent.or_type? ||
146
- parent.if_type? && parent.ternary?
142
+ parent.and_type? || parent.or_type? || parent.if_type? && parent.ternary?
147
143
  end
148
144
  end
149
145
  end
@@ -26,8 +26,7 @@ module RuboCop
26
26
  class RandomWithOffset < Base
27
27
  extend AutoCorrector
28
28
 
29
- MSG = 'Prefer ranges when generating random numbers instead of ' \
30
- 'integers with offsets.'
29
+ MSG = 'Prefer ranges when generating random numbers instead of integers with offsets.'
31
30
  RESTRICT_ON_SEND = %i[+ - succ pred next].freeze
32
31
 
33
32
  # @!method integer_op_rand?(node)
@@ -63,13 +62,9 @@ module RuboCop
63
62
 
64
63
  def on_send(node)
65
64
  return unless node.receiver
66
- return unless integer_op_rand?(node) ||
67
- rand_op_integer?(node) ||
68
- rand_modified?(node)
65
+ return unless integer_op_rand?(node) || rand_op_integer?(node) || rand_modified?(node)
69
66
 
70
- add_offense(node) do |corrector|
71
- autocorrect(corrector, node)
72
- end
67
+ add_offense(node) { |corrector| autocorrect(corrector, node) }
73
68
  end
74
69
 
75
70
  private
@@ -1,7 +1,5 @@
1
1
  # frozen_string_literal: true
2
2
 
3
- require 'parser/current'
4
-
5
3
  module RuboCop
6
4
  module Cop
7
5
  module Style
@@ -68,17 +66,10 @@ module RuboCop
68
66
  end
69
67
 
70
68
  def redundant_arg_for_method(method_name)
71
- return nil unless cop_config['Methods'].key?(method_name)
69
+ arg = cop_config['Methods'].fetch(method_name) { return }
72
70
 
73
71
  @mem ||= {}
74
- @mem[method_name] ||=
75
- begin
76
- arg = cop_config['Methods'].fetch(method_name)
77
- buffer = Parser::Source::Buffer.new('(string)', 1)
78
- buffer.source = arg.inspect
79
- builder = RuboCop::AST::Builder.new
80
- Parser::CurrentRuby.new(builder).parse(buffer)
81
- end
72
+ @mem[method_name] ||= parse(arg.inspect).ast
82
73
  end
83
74
 
84
75
  def argument_range(node)