rubocop 1.10.0 → 1.11.0
Sign up to get free protection for your applications and to get access to all the features.
- checksums.yaml +4 -4
- data/README.md +12 -12
- data/assets/output.html.erb +1 -1
- data/config/default.yml +13 -0
- data/lib/rubocop.rb +1 -0
- data/lib/rubocop/cli/command/execute_runner.rb +1 -1
- data/lib/rubocop/cli/command/suggest_extensions.rb +1 -1
- data/lib/rubocop/cop/bundler/duplicated_gem.rb +2 -1
- data/lib/rubocop/cop/bundler/gem_comment.rb +1 -0
- data/lib/rubocop/cop/bundler/insecure_protocol_source.rb +1 -0
- data/lib/rubocop/cop/bundler/ordered_gems.rb +1 -0
- data/lib/rubocop/cop/gemspec/date_assignment.rb +1 -0
- data/lib/rubocop/cop/gemspec/duplicated_assignment.rb +2 -0
- data/lib/rubocop/cop/gemspec/ordered_dependencies.rb +1 -0
- data/lib/rubocop/cop/gemspec/required_ruby_version.rb +2 -0
- data/lib/rubocop/cop/gemspec/ruby_version_globals_usage.rb +2 -0
- data/lib/rubocop/cop/generator.rb +2 -2
- data/lib/rubocop/cop/internal_affairs.rb +1 -0
- data/lib/rubocop/cop/internal_affairs/example_description.rb +1 -0
- data/lib/rubocop/cop/internal_affairs/method_name_equal.rb +1 -0
- data/lib/rubocop/cop/internal_affairs/node_destructuring.rb +2 -0
- data/lib/rubocop/cop/internal_affairs/node_matcher_directive.rb +151 -0
- data/lib/rubocop/cop/internal_affairs/node_type_predicate.rb +1 -0
- data/lib/rubocop/cop/internal_affairs/offense_location_keyword.rb +2 -0
- data/lib/rubocop/cop/internal_affairs/redundant_described_class_as_subject.rb +1 -0
- data/lib/rubocop/cop/internal_affairs/redundant_let_rubocop_config_new.rb +1 -0
- data/lib/rubocop/cop/internal_affairs/redundant_location_argument.rb +1 -0
- data/lib/rubocop/cop/internal_affairs/redundant_message_argument.rb +3 -0
- data/lib/rubocop/cop/internal_affairs/style_detected_api_use.rb +4 -0
- data/lib/rubocop/cop/internal_affairs/useless_message_assertion.rb +2 -0
- data/lib/rubocop/cop/layout/block_alignment.rb +1 -0
- data/lib/rubocop/cop/layout/class_structure.rb +1 -0
- data/lib/rubocop/cop/layout/extra_spacing.rb +2 -2
- data/lib/rubocop/cop/layout/first_argument_indentation.rb +6 -1
- data/lib/rubocop/cop/layout/indentation_width.rb +1 -0
- data/lib/rubocop/cop/layout/space_before_block_braces.rb +1 -1
- data/lib/rubocop/cop/layout/space_inside_block_braces.rb +1 -1
- data/lib/rubocop/cop/lint/big_decimal_new.rb +1 -0
- data/lib/rubocop/cop/lint/boolean_symbol.rb +1 -0
- data/lib/rubocop/cop/lint/constant_definition_in_block.rb +2 -0
- data/lib/rubocop/cop/lint/constant_resolution.rb +1 -0
- data/lib/rubocop/cop/lint/debugger.rb +3 -1
- data/lib/rubocop/cop/lint/deprecated_open_ssl_constant.rb +1 -0
- data/lib/rubocop/cop/lint/duplicate_branch.rb +1 -1
- data/lib/rubocop/cop/lint/duplicate_methods.rb +3 -0
- data/lib/rubocop/cop/lint/duplicate_require.rb +1 -0
- data/lib/rubocop/cop/lint/each_with_object_argument.rb +1 -0
- data/lib/rubocop/cop/lint/erb_new_arguments.rb +1 -0
- data/lib/rubocop/cop/lint/format_parameter_mismatch.rb +1 -0
- data/lib/rubocop/cop/lint/hash_compare_by_identity.rb +1 -0
- data/lib/rubocop/cop/lint/ineffective_access_modifier.rb +1 -0
- data/lib/rubocop/cop/lint/inherit_exception.rb +1 -0
- data/lib/rubocop/cop/lint/multiple_comparison.rb +1 -0
- data/lib/rubocop/cop/lint/nested_method_definition.rb +3 -0
- data/lib/rubocop/cop/lint/next_without_accumulator.rb +1 -0
- data/lib/rubocop/cop/lint/non_deterministic_require_order.rb +7 -0
- data/lib/rubocop/cop/lint/non_local_exit_from_iterator.rb +3 -0
- data/lib/rubocop/cop/lint/number_conversion.rb +2 -0
- data/lib/rubocop/cop/lint/raise_exception.rb +2 -0
- data/lib/rubocop/cop/lint/rand_one.rb +1 -0
- data/lib/rubocop/cop/lint/redundant_require_statement.rb +1 -0
- data/lib/rubocop/cop/lint/redundant_safe_navigation.rb +1 -0
- data/lib/rubocop/cop/lint/redundant_splat_expansion.rb +2 -0
- data/lib/rubocop/cop/lint/redundant_string_coercion.rb +1 -0
- data/lib/rubocop/cop/lint/redundant_with_index.rb +1 -0
- data/lib/rubocop/cop/lint/redundant_with_object.rb +1 -0
- data/lib/rubocop/cop/lint/safe_navigation_chain.rb +1 -0
- data/lib/rubocop/cop/lint/safe_navigation_with_empty.rb +1 -0
- data/lib/rubocop/cop/lint/send_with_mixin_argument.rb +1 -0
- data/lib/rubocop/cop/lint/shadowed_argument.rb +1 -0
- data/lib/rubocop/cop/lint/shadowing_outer_local_variable.rb +1 -0
- data/lib/rubocop/cop/lint/struct_new_override.rb +1 -0
- data/lib/rubocop/cop/lint/to_enum_arguments.rb +3 -0
- data/lib/rubocop/cop/lint/unified_integer.rb +1 -0
- data/lib/rubocop/cop/lint/unmodified_reduce_accumulator.rb +5 -0
- data/lib/rubocop/cop/lint/unreachable_code.rb +1 -0
- data/lib/rubocop/cop/lint/unreachable_loop.rb +1 -0
- data/lib/rubocop/cop/lint/unused_method_argument.rb +1 -0
- data/lib/rubocop/cop/lint/uri_escape_unescape.rb +1 -0
- data/lib/rubocop/cop/lint/useless_access_modifier.rb +4 -0
- data/lib/rubocop/cop/lint/useless_setter_call.rb +1 -0
- data/lib/rubocop/cop/lint/useless_times.rb +3 -0
- data/lib/rubocop/cop/metrics/module_length.rb +1 -0
- data/lib/rubocop/cop/metrics/parameter_lists.rb +1 -0
- data/lib/rubocop/cop/metrics/utils/code_length_calculator.rb +6 -4
- data/lib/rubocop/cop/metrics/utils/repeated_attribute_discount.rb +2 -0
- data/lib/rubocop/cop/mixin/def_node.rb +1 -0
- data/lib/rubocop/cop/mixin/empty_lines_around_body.rb +3 -0
- data/lib/rubocop/cop/mixin/empty_parameter.rb +1 -0
- data/lib/rubocop/cop/mixin/enforce_superclass.rb +2 -0
- data/lib/rubocop/cop/mixin/hash_transform_method.rb +1 -0
- data/lib/rubocop/cop/mixin/method_complexity.rb +1 -0
- data/lib/rubocop/cop/mixin/negative_conditional.rb +3 -0
- data/lib/rubocop/cop/mixin/preferred_delimiters.rb +1 -1
- data/lib/rubocop/cop/mixin/rational_literal.rb +1 -0
- data/lib/rubocop/cop/mixin/safe_assignment.rb +5 -0
- data/lib/rubocop/cop/mixin/visibility_help.rb +1 -0
- data/lib/rubocop/cop/naming/binary_operator_parameter_name.rb +1 -0
- data/lib/rubocop/cop/naming/constant_name.rb +2 -0
- data/lib/rubocop/cop/naming/memoized_instance_variable_name.rb +2 -0
- data/lib/rubocop/cop/naming/method_name.rb +3 -0
- data/lib/rubocop/cop/naming/predicate_name.rb +1 -0
- data/lib/rubocop/cop/security/eval.rb +1 -0
- data/lib/rubocop/cop/security/json_load.rb +1 -0
- data/lib/rubocop/cop/security/marshal_load.rb +1 -0
- data/lib/rubocop/cop/security/open.rb +1 -0
- data/lib/rubocop/cop/security/yaml_load.rb +1 -0
- data/lib/rubocop/cop/style/access_modifier_declarations.rb +1 -0
- data/lib/rubocop/cop/style/alias.rb +1 -0
- data/lib/rubocop/cop/style/arguments_forwarding.rb +3 -0
- data/lib/rubocop/cop/style/array_coercion.rb +2 -0
- data/lib/rubocop/cop/style/array_join.rb +1 -0
- data/lib/rubocop/cop/style/attr.rb +1 -0
- data/lib/rubocop/cop/style/case_equality.rb +2 -1
- data/lib/rubocop/cop/style/class_equality_comparison.rb +1 -0
- data/lib/rubocop/cop/style/collection_compact.rb +2 -0
- data/lib/rubocop/cop/style/colon_method_call.rb +1 -0
- data/lib/rubocop/cop/style/command_literal.rb +1 -1
- data/lib/rubocop/cop/style/conditional_assignment.rb +2 -0
- data/lib/rubocop/cop/style/constant_visibility.rb +1 -0
- data/lib/rubocop/cop/style/date_time.rb +3 -0
- data/lib/rubocop/cop/style/dir.rb +1 -0
- data/lib/rubocop/cop/style/documentation.rb +5 -0
- data/lib/rubocop/cop/style/documentation_method.rb +1 -0
- data/lib/rubocop/cop/style/double_negation.rb +1 -0
- data/lib/rubocop/cop/style/each_for_simple_loop.rb +1 -0
- data/lib/rubocop/cop/style/each_with_object.rb +1 -0
- data/lib/rubocop/cop/style/empty_literal.rb +9 -0
- data/lib/rubocop/cop/style/endless_method.rb +1 -0
- data/lib/rubocop/cop/style/eval_with_location.rb +2 -0
- data/lib/rubocop/cop/style/even_odd.rb +1 -0
- data/lib/rubocop/cop/style/expand_path_arguments.rb +3 -0
- data/lib/rubocop/cop/style/explicit_block_argument.rb +1 -0
- data/lib/rubocop/cop/style/float_division.rb +4 -0
- data/lib/rubocop/cop/style/format_string.rb +2 -0
- data/lib/rubocop/cop/style/format_string_token.rb +1 -0
- data/lib/rubocop/cop/style/global_std_stream.rb +1 -0
- data/lib/rubocop/cop/style/hash_conversion.rb +26 -2
- data/lib/rubocop/cop/style/hash_each_methods.rb +1 -0
- data/lib/rubocop/cop/style/hash_except.rb +1 -0
- data/lib/rubocop/cop/style/hash_like_case.rb +1 -0
- data/lib/rubocop/cop/style/hash_transform_keys.rb +4 -0
- data/lib/rubocop/cop/style/hash_transform_values.rb +4 -0
- data/lib/rubocop/cop/style/if_with_boolean_literal_branches.rb +2 -0
- data/lib/rubocop/cop/style/implicit_runtime_error.rb +1 -0
- data/lib/rubocop/cop/style/inverse_methods.rb +2 -0
- data/lib/rubocop/cop/style/min_max.rb +1 -0
- data/lib/rubocop/cop/style/mixin_usage.rb +2 -0
- data/lib/rubocop/cop/style/module_function.rb +5 -0
- data/lib/rubocop/cop/style/multiple_comparison.rb +21 -2
- data/lib/rubocop/cop/style/mutable_constant.rb +3 -0
- data/lib/rubocop/cop/style/negated_if_else_condition.rb +1 -0
- data/lib/rubocop/cop/style/nil_comparison.rb +3 -0
- data/lib/rubocop/cop/style/nil_lambda.rb +1 -0
- data/lib/rubocop/cop/style/non_nil_check.rb +7 -0
- data/lib/rubocop/cop/style/numeric_predicate.rb +3 -0
- data/lib/rubocop/cop/style/option_hash.rb +1 -0
- data/lib/rubocop/cop/style/or_assignment.rb +2 -0
- data/lib/rubocop/cop/style/parallel_assignment.rb +6 -0
- data/lib/rubocop/cop/style/parentheses_around_condition.rb +1 -0
- data/lib/rubocop/cop/style/proc.rb +1 -0
- data/lib/rubocop/cop/style/random_with_offset.rb +5 -0
- data/lib/rubocop/cop/style/redundant_assignment.rb +1 -0
- data/lib/rubocop/cop/style/redundant_begin.rb +7 -1
- data/lib/rubocop/cop/style/redundant_conditional.rb +2 -0
- data/lib/rubocop/cop/style/redundant_exception.rb +2 -0
- data/lib/rubocop/cop/style/redundant_fetch_block.rb +2 -0
- data/lib/rubocop/cop/style/redundant_file_extension_in_require.rb +1 -0
- data/lib/rubocop/cop/style/redundant_freeze.rb +1 -0
- data/lib/rubocop/cop/style/redundant_parentheses.rb +13 -0
- data/lib/rubocop/cop/style/redundant_self_assignment.rb +2 -0
- data/lib/rubocop/cop/style/redundant_sort.rb +1 -0
- data/lib/rubocop/cop/style/redundant_sort_by.rb +1 -0
- data/lib/rubocop/cop/style/regexp_literal.rb +1 -1
- data/lib/rubocop/cop/style/rescue_standard_error.rb +2 -0
- data/lib/rubocop/cop/style/return_nil.rb +6 -0
- data/lib/rubocop/cop/style/safe_navigation.rb +2 -0
- data/lib/rubocop/cop/style/sample.rb +1 -0
- data/lib/rubocop/cop/style/signal_exception.rb +3 -0
- data/lib/rubocop/cop/style/single_argument_dig.rb +1 -0
- data/lib/rubocop/cop/style/slicing_with_range.rb +1 -0
- data/lib/rubocop/cop/style/stderr_puts.rb +1 -0
- data/lib/rubocop/cop/style/string_concatenation.rb +1 -0
- data/lib/rubocop/cop/style/string_hash_keys.rb +2 -0
- data/lib/rubocop/cop/style/strip.rb +1 -0
- data/lib/rubocop/cop/style/struct_inheritance.rb +1 -0
- data/lib/rubocop/cop/style/symbol_proc.rb +25 -1
- data/lib/rubocop/cop/style/ternary_parentheses.rb +1 -0
- data/lib/rubocop/cop/style/trailing_body_on_method_definition.rb +1 -0
- data/lib/rubocop/cop/style/trailing_method_end_statement.rb +1 -1
- data/lib/rubocop/cop/style/trivial_accessors.rb +1 -0
- data/lib/rubocop/cop/style/unless_logical_operators.rb +99 -0
- data/lib/rubocop/cop/style/unpack_first.rb +1 -0
- data/lib/rubocop/cop/style/yoda_condition.rb +1 -0
- data/lib/rubocop/cop/style/zero_length_predicate.rb +5 -0
- data/lib/rubocop/name_similarity.rb +1 -1
- data/lib/rubocop/target_ruby.rb +21 -13
- data/lib/rubocop/version.rb +1 -1
- metadata +9 -7
@@ -115,14 +115,17 @@ module RuboCop
|
|
115
115
|
end
|
116
116
|
end
|
117
117
|
|
118
|
+
# @!method predicate(node)
|
118
119
|
def_node_matcher :predicate, <<~PATTERN
|
119
120
|
(send $(...) ${:zero? :positive? :negative?})
|
120
121
|
PATTERN
|
121
122
|
|
123
|
+
# @!method comparison(node)
|
122
124
|
def_node_matcher :comparison, <<~PATTERN
|
123
125
|
(send [$(...) !gvar_type?] ${:== :> :<} (int 0))
|
124
126
|
PATTERN
|
125
127
|
|
128
|
+
# @!method inverted_comparison(node)
|
126
129
|
def_node_matcher :inverted_comparison, <<~PATTERN
|
127
130
|
(send (int 0) ${:== :> :<} [$(...) !gvar_type?])
|
128
131
|
PATTERN
|
@@ -31,6 +31,7 @@ module RuboCop
|
|
31
31
|
|
32
32
|
MSG = 'Use the double pipe equals operator `||=` instead.'
|
33
33
|
|
34
|
+
# @!method ternary_assignment?(node)
|
34
35
|
def_node_matcher :ternary_assignment?, <<~PATTERN
|
35
36
|
({lvasgn ivasgn cvasgn gvasgn} _var
|
36
37
|
(if
|
@@ -39,6 +40,7 @@ module RuboCop
|
|
39
40
|
$_))
|
40
41
|
PATTERN
|
41
42
|
|
43
|
+
# @!method unless_assignment?(node)
|
42
44
|
def_node_matcher :unless_assignment?, <<~PATTERN
|
43
45
|
(if
|
44
46
|
({lvar ivar cvar gvar} _var) nil?
|
@@ -115,6 +115,7 @@ module RuboCop
|
|
115
115
|
end
|
116
116
|
end
|
117
117
|
|
118
|
+
# @!method implicit_self_getter?(node)
|
118
119
|
def_node_matcher :implicit_self_getter?, '(send nil? $_)'
|
119
120
|
|
120
121
|
# Helper class necessitated by silly design of TSort prior to Ruby 2.1
|
@@ -123,8 +124,13 @@ module RuboCop
|
|
123
124
|
include TSort
|
124
125
|
extend RuboCop::NodePattern::Macros
|
125
126
|
|
127
|
+
# @!method var_name(node)
|
126
128
|
def_node_matcher :var_name, '{(casgn _ $_) (_ $_)}'
|
129
|
+
|
130
|
+
# @!method uses_var?(node)
|
127
131
|
def_node_search :uses_var?, '{({lvar ivar cvar gvar} %) (const _ %)}'
|
132
|
+
|
133
|
+
# @!method matching_calls(node, receiver, method_name)
|
128
134
|
def_node_search :matching_calls, '(send %1 %2 $...)'
|
129
135
|
|
130
136
|
def initialize(assignments)
|
@@ -30,6 +30,7 @@ module RuboCop
|
|
30
30
|
'integers with offsets.'
|
31
31
|
RESTRICT_ON_SEND = %i[+ - succ pred next].freeze
|
32
32
|
|
33
|
+
# @!method integer_op_rand?(node)
|
33
34
|
def_node_matcher :integer_op_rand?, <<~PATTERN
|
34
35
|
(send
|
35
36
|
int {:+ :-}
|
@@ -39,6 +40,7 @@ module RuboCop
|
|
39
40
|
{int (irange int int) (erange int int)}))
|
40
41
|
PATTERN
|
41
42
|
|
43
|
+
# @!method rand_op_integer?(node)
|
42
44
|
def_node_matcher :rand_op_integer?, <<~PATTERN
|
43
45
|
(send
|
44
46
|
(send
|
@@ -49,6 +51,7 @@ module RuboCop
|
|
49
51
|
int)
|
50
52
|
PATTERN
|
51
53
|
|
54
|
+
# @!method rand_modified?(node)
|
52
55
|
def_node_matcher :rand_modified?, <<~PATTERN
|
53
56
|
(send
|
54
57
|
(send
|
@@ -71,6 +74,7 @@ module RuboCop
|
|
71
74
|
|
72
75
|
private
|
73
76
|
|
77
|
+
# @!method random_call(node)
|
74
78
|
def_node_matcher :random_call, <<~PATTERN
|
75
79
|
{(send (send $_ _ $_) ...)
|
76
80
|
(send _ _ (send $_ _ $_))}
|
@@ -144,6 +148,7 @@ module RuboCop
|
|
144
148
|
end
|
145
149
|
end
|
146
150
|
|
151
|
+
# @!method to_int(node)
|
147
152
|
def_node_matcher :to_int, <<~PATTERN
|
148
153
|
(int $_)
|
149
154
|
PATTERN
|
@@ -85,7 +85,9 @@ module RuboCop
|
|
85
85
|
end
|
86
86
|
|
87
87
|
def on_kwbegin(node)
|
88
|
-
return if
|
88
|
+
return if empty_begin?(node) ||
|
89
|
+
contain_rescue_or_ensure?(node) ||
|
90
|
+
valid_context_using_only_begin?(node)
|
89
91
|
|
90
92
|
register_offense(node)
|
91
93
|
end
|
@@ -99,6 +101,10 @@ module RuboCop
|
|
99
101
|
end
|
100
102
|
end
|
101
103
|
|
104
|
+
def empty_begin?(node)
|
105
|
+
node.children.empty?
|
106
|
+
end
|
107
|
+
|
102
108
|
def contain_rescue_or_ensure?(node)
|
103
109
|
first_child = node.children.first
|
104
110
|
|
@@ -53,10 +53,12 @@ module RuboCop
|
|
53
53
|
format(MSG, msg: msg)
|
54
54
|
end
|
55
55
|
|
56
|
+
# @!method redundant_condition?(node)
|
56
57
|
def_node_matcher :redundant_condition?, <<~RUBY
|
57
58
|
(if (send _ #{COMPARISON_OPERATOR_MATCHER} _) true false)
|
58
59
|
RUBY
|
59
60
|
|
61
|
+
# @!method redundant_condition_inverted?(node)
|
60
62
|
def_node_matcher :redundant_condition_inverted?, <<~RUBY
|
61
63
|
(if (send _ #{COMPARISON_OPERATOR_MATCHER} _) false true)
|
62
64
|
RUBY
|
@@ -53,10 +53,12 @@ module RuboCop
|
|
53
53
|
end
|
54
54
|
end
|
55
55
|
|
56
|
+
# @!method exploded?(node)
|
56
57
|
def_node_matcher :exploded?, <<~PATTERN
|
57
58
|
(send nil? ${:raise :fail} (const {nil? cbase} :RuntimeError) $_)
|
58
59
|
PATTERN
|
59
60
|
|
61
|
+
# @!method compact?(node)
|
60
62
|
def_node_matcher :compact?, <<~PATTERN
|
61
63
|
(send nil? {:raise :fail} $(send (const {nil? cbase} :RuntimeError) :new $_))
|
62
64
|
PATTERN
|
@@ -38,6 +38,7 @@ module RuboCop
|
|
38
38
|
|
39
39
|
MSG = 'Use `%<good>s` instead of `%<bad>s`.'
|
40
40
|
|
41
|
+
# @!method redundant_fetch_block_candidate?(node)
|
41
42
|
def_node_matcher :redundant_fetch_block_candidate?, <<~PATTERN
|
42
43
|
(block
|
43
44
|
$(send _ :fetch _)
|
@@ -78,6 +79,7 @@ module RuboCop
|
|
78
79
|
rails_cache?(send.receiver)
|
79
80
|
end
|
80
81
|
|
82
|
+
# @!method rails_cache?(node)
|
81
83
|
def_node_matcher :rails_cache?, <<~PATTERN
|
82
84
|
(send (const _ :Rails) :cache)
|
83
85
|
PATTERN
|
@@ -30,6 +30,7 @@ module RuboCop
|
|
30
30
|
MSG = 'Redundant `.rb` file extension detected.'
|
31
31
|
RESTRICT_ON_SEND = %i[require require_relative].freeze
|
32
32
|
|
33
|
+
# @!method require_call?(node)
|
33
34
|
def_node_matcher :require_call?, <<~PATTERN
|
34
35
|
(send nil? {:require :require_relative} $str_type?)
|
35
36
|
PATTERN
|
@@ -17,11 +17,20 @@ module RuboCop
|
|
17
17
|
include Parentheses
|
18
18
|
extend AutoCorrector
|
19
19
|
|
20
|
+
# @!method square_brackets?(node)
|
20
21
|
def_node_matcher :square_brackets?,
|
21
22
|
'(send {(send _recv _msg) str array hash} :[] ...)'
|
23
|
+
|
24
|
+
# @!method range_end?(node)
|
22
25
|
def_node_matcher :range_end?, '^^{irange erange}'
|
26
|
+
|
27
|
+
# @!method method_node_and_args(node)
|
23
28
|
def_node_matcher :method_node_and_args, '$(call _recv _msg $...)'
|
29
|
+
|
30
|
+
# @!method rescue?(node)
|
24
31
|
def_node_matcher :rescue?, '{^resbody ^^resbody}'
|
32
|
+
|
33
|
+
# @!method arg_in_call_with_block?(node)
|
25
34
|
def_node_matcher :arg_in_call_with_block?,
|
26
35
|
'^^(block (send _ _ equal?(%0) ...) ...)'
|
27
36
|
|
@@ -109,6 +118,7 @@ module RuboCop
|
|
109
118
|
check_send(begin_node, node) if node.call_type?
|
110
119
|
end
|
111
120
|
|
121
|
+
# @!method interpolation?(node)
|
112
122
|
def_node_matcher :interpolation?, '[^begin ^^dstr]'
|
113
123
|
|
114
124
|
def check_send(begin_node, node)
|
@@ -220,14 +230,17 @@ module RuboCop
|
|
220
230
|
first_yield_argument?(node)
|
221
231
|
end
|
222
232
|
|
233
|
+
# @!method first_send_argument?(node)
|
223
234
|
def_node_matcher :first_send_argument?, <<~PATTERN
|
224
235
|
^(send _ _ equal?(%0) ...)
|
225
236
|
PATTERN
|
226
237
|
|
238
|
+
# @!method first_super_argument?(node)
|
227
239
|
def_node_matcher :first_super_argument?, <<~PATTERN
|
228
240
|
^(super equal?(%0) ...)
|
229
241
|
PATTERN
|
230
242
|
|
243
|
+
# @!method first_yield_argument?(node)
|
231
244
|
def_node_matcher :first_yield_argument?, <<~PATTERN
|
232
245
|
^(yield equal?(%0) ...)
|
233
246
|
PATTERN
|
@@ -82,6 +82,7 @@ module RuboCop
|
|
82
82
|
METHODS_RETURNING_SELF.include?(method_name)
|
83
83
|
end
|
84
84
|
|
85
|
+
# @!method redundant_self_assignment?(node, method_name)
|
85
86
|
def_node_matcher :redundant_self_assignment?, <<~PATTERN
|
86
87
|
(send
|
87
88
|
(self) _
|
@@ -91,6 +92,7 @@ module RuboCop
|
|
91
92
|
...))
|
92
93
|
PATTERN
|
93
94
|
|
95
|
+
# @!method redundant_nonself_assignment?(node, receiver, method_name)
|
94
96
|
def_node_matcher :redundant_nonself_assignment?, <<~PATTERN
|
95
97
|
(send
|
96
98
|
%1 _
|
@@ -81,10 +81,12 @@ module RuboCop
|
|
81
81
|
MSG_EXPLICIT = 'Avoid rescuing without specifying ' \
|
82
82
|
'an error class.'
|
83
83
|
|
84
|
+
# @!method rescue_without_error_class?(node)
|
84
85
|
def_node_matcher :rescue_without_error_class?, <<~PATTERN
|
85
86
|
(resbody nil? _ _)
|
86
87
|
PATTERN
|
87
88
|
|
89
|
+
# @!method rescue_standard_error?(node)
|
88
90
|
def_node_matcher :rescue_standard_error?, <<~PATTERN
|
89
91
|
(resbody $(array (const {nil? cbase} :StandardError)) _ _)
|
90
92
|
PATTERN
|
@@ -35,7 +35,10 @@ module RuboCop
|
|
35
35
|
RETURN_MSG = 'Use `return` instead of `return nil`.'
|
36
36
|
RETURN_NIL_MSG = 'Use `return nil` instead of `return`.'
|
37
37
|
|
38
|
+
# @!method return_node?(node)
|
38
39
|
def_node_matcher :return_node?, '(return)'
|
40
|
+
|
41
|
+
# @!method return_nil_node?(node)
|
39
42
|
def_node_matcher :return_nil_node?, '(return nil)'
|
40
43
|
|
41
44
|
def on_return(node)
|
@@ -79,7 +82,10 @@ module RuboCop
|
|
79
82
|
node.def_type? || node.defs_type? || node.lambda?
|
80
83
|
end
|
81
84
|
|
85
|
+
# @!method chained_send?(node)
|
82
86
|
def_node_matcher :chained_send?, '(send !nil? ...)'
|
87
|
+
|
88
|
+
# @!method define_method?(node)
|
83
89
|
def_node_matcher :define_method?, <<~PATTERN
|
84
90
|
(send _ {:define_method :define_singleton_method} _)
|
85
91
|
PATTERN
|
@@ -74,6 +74,7 @@ module RuboCop
|
|
74
74
|
|
75
75
|
# if format: (if checked_variable body nil)
|
76
76
|
# unless format: (if checked_variable nil body)
|
77
|
+
# @!method modifier_if_safe_navigation_candidate(node)
|
77
78
|
def_node_matcher :modifier_if_safe_navigation_candidate, <<~PATTERN
|
78
79
|
{
|
79
80
|
(if {
|
@@ -88,6 +89,7 @@ module RuboCop
|
|
88
89
|
}
|
89
90
|
PATTERN
|
90
91
|
|
92
|
+
# @!method not_nil_check?(node)
|
91
93
|
def_node_matcher :not_nil_check?, '(send (send $_ :nil?) :!)'
|
92
94
|
|
93
95
|
def on_if(node)
|
@@ -33,6 +33,7 @@ module RuboCop
|
|
33
33
|
MSG = 'Use `%<correct>s` instead of `%<incorrect>s`.'
|
34
34
|
RESTRICT_ON_SEND = %i[first last [] at slice].freeze
|
35
35
|
|
36
|
+
# @!method sample_candidate?(node)
|
36
37
|
def_node_matcher :sample_candidate?, <<~PATTERN
|
37
38
|
(send $(send _ :shuffle $...) ${:#{RESTRICT_ON_SEND.join(' :')}} $...)
|
38
39
|
PATTERN
|
@@ -114,7 +114,10 @@ module RuboCop
|
|
114
114
|
|
115
115
|
RESTRICT_ON_SEND = %i[raise fail].freeze
|
116
116
|
|
117
|
+
# @!method kernel_call?(node, name)
|
117
118
|
def_node_matcher :kernel_call?, '(send (const {nil? cbase} :Kernel) %1 ...)'
|
119
|
+
|
120
|
+
# @!method custom_fail_methods(node)
|
118
121
|
def_node_search :custom_fail_methods,
|
119
122
|
'{(def :fail ...) (defs _ :fail ...)}'
|
120
123
|
|
@@ -22,6 +22,7 @@ module RuboCop
|
|
22
22
|
'Use `warn` instead of `%<bad>s` to allow such output to be disabled.'
|
23
23
|
RESTRICT_ON_SEND = %i[puts].freeze
|
24
24
|
|
25
|
+
# @!method stderr_puts?(node)
|
25
26
|
def_node_matcher :stderr_puts?, <<~PATTERN
|
26
27
|
(send
|
27
28
|
{(gvar #stderr_gvar?) (const {nil? cbase} :STDERR)}
|
@@ -17,10 +17,12 @@ module RuboCop
|
|
17
17
|
|
18
18
|
MSG = 'Prefer symbols instead of strings as hash keys.'
|
19
19
|
|
20
|
+
# @!method string_hash_key?(node)
|
20
21
|
def_node_matcher :string_hash_key?, <<~PATTERN
|
21
22
|
(pair (str _) _)
|
22
23
|
PATTERN
|
23
24
|
|
25
|
+
# @!method receive_environments_method?(node)
|
24
26
|
def_node_matcher :receive_environments_method?, <<~PATTERN
|
25
27
|
{
|
26
28
|
^^(send (const {nil? cbase} :IO) :popen ...)
|
@@ -20,6 +20,7 @@ module RuboCop
|
|
20
20
|
MSG = 'Use `strip` instead of `%<methods>s`.'
|
21
21
|
RESTRICT_ON_SEND = %i[lstrip rstrip].freeze
|
22
22
|
|
23
|
+
# @!method lstrip_rstrip(node)
|
23
24
|
def_node_matcher :lstrip_rstrip, <<~PATTERN
|
24
25
|
{(send $(send _ $:rstrip) $:lstrip)
|
25
26
|
(send $(send _ $:lstrip) $:rstrip)}
|