rubocop 0.93.0 → 0.93.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4d381604ba6395ffc42db74e3f57245307935ec7a56d365e10b8d07207d432a1
-  data.tar.gz: 2b290525226f487d860b5a1201266d1b20e403a05ed8a704c1270b7edaca5e2f
+  metadata.gz: b8ce11205d6a6bb518654cbe498544aa799fbb8d9c9057afd2f551edfc35bbb8
+  data.tar.gz: a1f79001991b28508ca7c9a79d75ed58f39ae0dcf2bad419d6a75919b3a3d539
 SHA512:
-  metadata.gz: 8639a2098ab1fb1e50fe6993e0a2d9f305998b7cc0215ab6bdd615506a4f8271de1fe78dbe1592b1ade597b40b79acfe4c5bc0503d8ee72940ff1732fd25a19d
-  data.tar.gz: 11278958d9183ba56561ffc1f6b3cc69ac0b2f7d883cf5192cb31ab3ace1eacce21a23a13f998f4f2917d14574a6c27309be8f48085fc7abf940eab2ba0d1cce
+  metadata.gz: a32001a91575c41b5ca71b6a148af79f45b2a7b8cbc3909a0dcbb7a652f5e62b6a79a84c14189eda64fd3d2a9e8c40d207c37c0f5a78a156e1f636c5191b995e
+  data.tar.gz: 9ac5df57938099031807a96bd87a7fb9c5f7f40c314528b4c3254edb45b1386ce199fa9c394c9e7531655d117df9d3d5215bd66e4a927b9b2b0878e0eac2a1f6

data/README.md

@@ -49,7 +49,7 @@ haven't reached version 1.0 yet). To prevent an unwanted RuboCop update you
 might want to use a conservative version lock in your `Gemfile`:
 
 ```rb
-gem 'rubocop', '~> 0.93.0', require: false
+gem 'rubocop', '~> 0.93.1', require: false
 ```
 
 ## Quickstart

data/config/default.yml

@@ -1757,16 +1757,14 @@ Lint/RedundantSafeNavigation:
   Description: 'Checks for redundant safe navigation calls.'
   Enabled: pending
   VersionAdded: '0.93'
+  AllowedMethods:
+    - instance_of?
+    - kind_of?
+    - is_a?
+    - eql?
+    - respond_to?
+    - equal?
   Safe: false
-  IgnoredMethods:
-    - to_c
-    - to_f
-    - to_i
-    - to_r
-    - rationalize
-    - public_send
-    - send
-    - __send__
 
 Lint/RedundantSplatExpansion:
   Description: 'Checks for splat unnecessarily being called on literals.'

data/lib/rubocop/cop/lint/ambiguous_regexp_literal.rb

@@ -53,15 +53,18 @@ module RuboCop
         def find_offense_node(node, regexp_receiver)
           return node unless node.parent
 
-          if node.parent.send_type? || method_chain_to_regexp_receiver?(node)
+          if node.parent.send_type? || method_chain_to_regexp_receiver?(node, regexp_receiver)
             node = find_offense_node(node.parent, regexp_receiver)
           end
 
           node
         end
 
-        def method_chain_to_regexp_receiver?(node)
-          node.parent.parent && node.parent.receiver.receiver == regexp_receiver
+        def method_chain_to_regexp_receiver?(node, regexp_receiver)
+          return false unless (parent = node.parent)
+          return false unless (parent_receiver = parent.receiver)
+
+          parent.parent && parent_receiver.receiver == regexp_receiver
         end
       end
     end

data/lib/rubocop/cop/lint/redundant_safe_navigation.rb

@@ -4,29 +4,52 @@ module RuboCop
   module Cop
     module Lint
       # This cop checks for redundant safe navigation calls.
-      # It is marked as unsafe, because it can produce code that returns
-      # non `nil` while `nil` result is expected on `nil` receiver.
+      # `instance_of?`, `kind_of?`, `is_a?`, `eql?`, `respond_to?`, and `equal?` methods
+      # are checked by default. These are customizable with `AllowedMethods` option.
+      #
+      # This cop is marked as unsafe, because auto-correction can change the
+      # return type of the expression. An offending expression that previously
+      # could return `nil` will be auto-corrected to never return `nil`.
+      #
+      # In the example below, the safe navigation operator (`&.`) is unnecessary
+      # because `NilClass` has methods like `respond_to?` and `is_a?`.
       #
       # @example
       #   # bad
-      #   attrs&.respond_to?(:[])
-      #   foo&.dup&.inspect
+      #   do_something if attrs&.respond_to?(:[])
+      #
+      #   # good
+      #   do_something if attrs.respond_to?(:[])
+      #
+      #   # bad
+      #   while node&.is_a?(BeginNode)
+      #     node = node.parent
+      #   end
       #
       #   # good
-      #   attrs.respond_to?(:[])
-      #   foo.dup.inspect
+      #   while node.is_a?(BeginNode)
+      #     node = node.parent
+      #   end
+      #
+      #   # good - without `&.` this will always return `true`
+      #   foo&.respond_to?(:to_a)
       #
       class RedundantSafeNavigation < Base
-        include IgnoredMethods
+        include AllowedMethods
         include RangeHelp
         extend AutoCorrector
 
         MSG = 'Redundant safe navigation detected.'
 
-        NIL_METHODS = nil.methods.to_set.freeze
+        NIL_SPECIFIC_METHODS = (nil.methods - Object.new.methods).to_set.freeze
+
+        def_node_matcher :respond_to_nil_specific_method?, <<~PATTERN
+          (csend _ :respond_to? (sym %NIL_SPECIFIC_METHODS))
+        PATTERN
 
         def on_csend(node)
-          return unless check_method?(node.method_name)
+          return unless check?(node) && allowed_method?(node.method_name)
+          return if respond_to_nil_specific_method?(node)
 
           range = range_between(node.loc.dot.begin_pos, node.source_range.end_pos)
           add_offense(range) do |corrector|
@@ -36,8 +59,18 @@ module RuboCop
 
         private
 
-        def check_method?(method_name)
-          NIL_METHODS.include?(method_name) && !ignored_method?(method_name)
+        def check?(node)
+          parent = node.parent
+          return false unless parent
+
+          condition?(parent, node) ||
+            parent.and_type? ||
+            parent.or_type? ||
+            (parent.send_type? && parent.negation_method?)
+        end
+
+        def condition?(parent, node)
+          (parent.conditional? || parent.post_condition_loop?) && parent.condition == node
         end
       end
     end

data/lib/rubocop/cop/metrics/class_length.rb

@@ -39,13 +39,19 @@ module RuboCop
         end
 
         def on_casgn(node)
-          if node.parent&.assignment?
-            block_node = node.parent.children[1]
+          parent = node.parent
+
+          if parent&.assignment?
+            block_node = parent.children[1]
+          elsif parent&.parent&.masgn_type?
+            block_node = parent.parent.children[1]
           else
             _scope, _name, block_node = *node
           end
 
-          check_code_length(block_node) if block_node.class_definition?
+          return unless block_node.respond_to?(:class_definition?) && block_node.class_definition?
+
+          check_code_length(block_node)
         end
 
         private

data/lib/rubocop/cop/style/class_equality_comparison.rb

@@ -21,7 +21,7 @@ module RuboCop
         include IgnoredMethods
         extend AutoCorrector
 
-        MSG = 'Use `Object.instance_of?` instead of comparing classes.'
+        MSG = 'Use `instance_of?(%<class_name>s)` instead of comparing classes.'
 
         RESTRICT_ON_SEND = %i[== equal? eql?].freeze
 
@@ -36,13 +36,28 @@ module RuboCop
           return if def_node && ignored_method?(def_node.method_name)
 
           class_comparison_candidate?(node) do |receiver_node, class_node|
-            range = range_between(receiver_node.loc.selector.begin_pos, node.source_range.end_pos)
+            range = offense_range(receiver_node, node)
+            class_name = class_name(class_node, node)
 
-            add_offense(range) do |corrector|
-              corrector.replace(range, "instance_of?(#{class_node.source})")
+            add_offense(range, message: format(MSG, class_name: class_name)) do |corrector|
+              corrector.replace(range, "instance_of?(#{class_name})")
             end
           end
         end
+
+        private
+
+        def class_name(class_node, node)
+          if node.children.first.method?(:name)
+            class_node.source.delete('"').delete("'")
+          else
+            class_node.source
+          end
+        end
+
+        def offense_range(receiver_node, node)
+          range_between(receiver_node.loc.selector.begin_pos, node.source_range.end_pos)
+        end
       end
     end
   end

data/lib/rubocop/cop/style/redundant_begin.rb

@@ -85,10 +85,7 @@ module RuboCop
         end
 
         def on_kwbegin(node)
-          return if node.parent&.assignment?
-
-          first_child = node.children.first
-          return if first_child.rescue_type? || first_child.ensure_type?
+          return if contain_rescue_or_ensure?(node) || valid_context_using_only_begin?(node)
 
           register_offense(node)
         end
@@ -101,6 +98,19 @@ module RuboCop
             corrector.remove(node.loc.end)
           end
         end
+
+        def contain_rescue_or_ensure?(node)
+          first_child = node.children.first
+
+          first_child.rescue_type? || first_child.ensure_type?
+        end
+
+        def valid_context_using_only_begin?(node)
+          parent = node.parent
+
+          node.each_ancestor.any?(&:assignment?) || parent&.post_condition_loop? ||
+            parent&.send_type? || parent&.operator_keyword?
+        end
       end
     end
   end

data/lib/rubocop/cop/style/ternary_parentheses.rb

@@ -192,7 +192,7 @@ module RuboCop
         end
 
         def_node_matcher :method_name, <<~PATTERN
-          {($:defined? (send nil? _) ...)
+          {($:defined? _ ...)
            (send {_ nil?} $_ _ ...)}
         PATTERN
 

data/lib/rubocop/version.rb

@@ -3,7 +3,7 @@
 module RuboCop
   # This module holds the RuboCop version information.
   module Version
-    STRING = '0.93.0'
+    STRING = '0.93.1'
 
     MSG = '%<version>s (using Parser %<parser_version>s, '\
           'rubocop-ast %<rubocop_ast_version>s, ' \

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop
 version: !ruby/object:Gem::Version
-  version: 0.93.0
+  version: 0.93.1
 platform: ruby
 authors:
 - Bozhidar Batsov
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-10-08 00:00:00.000000000 Z
+date: 2020-10-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: parallel
@@ -822,7 +822,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
+rubygems_version: 3.1.4
 signing_key: 
 specification_version: 4
 summary: Automatic Ruby code style checking tool.