rubocop 0.89.1 → 0.93.0
Sign up to get free protection for your applications and to get access to all the features.
- checksums.yaml +4 -4
- data/README.md +2 -2
- data/config/default.yml +160 -14
- data/lib/rubocop.rb +33 -5
- data/lib/rubocop/cached_data.rb +3 -1
- data/lib/rubocop/cli/command.rb +1 -0
- data/lib/rubocop/cli/command/auto_genenerate_config.rb +1 -0
- data/lib/rubocop/cli/command/base.rb +1 -0
- data/lib/rubocop/cli/command/execute_runner.rb +9 -0
- data/lib/rubocop/cli/command/init_dotfile.rb +1 -0
- data/lib/rubocop/cli/command/show_cops.rb +1 -0
- data/lib/rubocop/cli/command/version.rb +1 -0
- data/lib/rubocop/cli/environment.rb +1 -0
- data/lib/rubocop/comment_config.rb +14 -5
- data/lib/rubocop/config_loader.rb +20 -9
- data/lib/rubocop/config_loader_resolver.rb +1 -0
- data/lib/rubocop/config_obsoletion.rb +1 -0
- data/lib/rubocop/config_regeneration.rb +33 -0
- data/lib/rubocop/config_store.rb +3 -3
- data/lib/rubocop/config_validator.rb +3 -0
- data/lib/rubocop/cop/base.rb +23 -0
- data/lib/rubocop/cop/bundler/duplicated_gem.rb +5 -1
- data/lib/rubocop/cop/bundler/gem_comment.rb +8 -3
- data/lib/rubocop/cop/bundler/insecure_protocol_source.rb +2 -0
- data/lib/rubocop/cop/commissioner.rb +47 -7
- data/lib/rubocop/cop/correctors/alignment_corrector.rb +4 -4
- data/lib/rubocop/cop/correctors/condition_corrector.rb +3 -5
- data/lib/rubocop/cop/correctors/empty_line_corrector.rb +9 -10
- data/lib/rubocop/cop/correctors/line_break_corrector.rb +4 -4
- data/lib/rubocop/cop/correctors/multiline_literal_brace_corrector.rb +8 -3
- data/lib/rubocop/cop/correctors/parentheses_corrector.rb +5 -8
- data/lib/rubocop/cop/correctors/percent_literal_corrector.rb +4 -9
- data/lib/rubocop/cop/correctors/punctuation_corrector.rb +8 -10
- data/lib/rubocop/cop/documentation.rb +22 -0
- data/lib/rubocop/cop/gemspec/required_ruby_version.rb +10 -10
- data/lib/rubocop/cop/generator.rb +2 -1
- data/lib/rubocop/cop/internal_affairs/method_name_equal.rb +1 -0
- data/lib/rubocop/cop/internal_affairs/node_type_predicate.rb +1 -0
- data/lib/rubocop/cop/internal_affairs/offense_location_keyword.rb +1 -0
- data/lib/rubocop/cop/internal_affairs/redundant_location_argument.rb +1 -0
- data/lib/rubocop/cop/internal_affairs/redundant_message_argument.rb +1 -0
- data/lib/rubocop/cop/layout/array_alignment.rb +1 -0
- data/lib/rubocop/cop/layout/begin_end_alignment.rb +77 -0
- data/lib/rubocop/cop/layout/block_alignment.rb +23 -19
- data/lib/rubocop/cop/layout/case_indentation.rb +4 -7
- data/lib/rubocop/cop/layout/class_structure.rb +11 -10
- data/lib/rubocop/cop/layout/closing_heredoc_indentation.rb +4 -6
- data/lib/rubocop/cop/layout/condition_position.rb +13 -15
- data/lib/rubocop/cop/layout/def_end_alignment.rb +8 -5
- data/lib/rubocop/cop/layout/dot_position.rb +21 -20
- data/lib/rubocop/cop/layout/empty_comment.rb +30 -23
- data/lib/rubocop/cop/layout/empty_line_after_guard_clause.rb +21 -18
- data/lib/rubocop/cop/layout/empty_line_after_magic_comment.rb +13 -13
- data/lib/rubocop/cop/layout/empty_line_after_multiline_condition.rb +136 -0
- data/lib/rubocop/cop/layout/empty_line_between_defs.rb +21 -23
- data/lib/rubocop/cop/layout/empty_lines.rb +6 -7
- data/lib/rubocop/cop/layout/empty_lines_around_access_modifier.rb +17 -14
- data/lib/rubocop/cop/layout/empty_lines_around_arguments.rb +7 -8
- data/lib/rubocop/cop/layout/empty_lines_around_attribute_accessor.rb +5 -8
- data/lib/rubocop/cop/layout/empty_lines_around_begin_body.rb +2 -5
- data/lib/rubocop/cop/layout/empty_lines_around_block_body.rb +2 -5
- data/lib/rubocop/cop/layout/empty_lines_around_class_body.rb +2 -5
- data/lib/rubocop/cop/layout/empty_lines_around_exception_handling_keywords.rb +3 -7
- data/lib/rubocop/cop/layout/empty_lines_around_method_body.rb +2 -5
- data/lib/rubocop/cop/layout/empty_lines_around_module_body.rb +2 -5
- data/lib/rubocop/cop/layout/end_alignment.rb +11 -17
- data/lib/rubocop/cop/layout/first_array_element_line_break.rb +2 -5
- data/lib/rubocop/cop/layout/first_hash_element_line_break.rb +2 -5
- data/lib/rubocop/cop/layout/first_method_argument_line_break.rb +4 -8
- data/lib/rubocop/cop/layout/first_method_parameter_line_break.rb +2 -5
- data/lib/rubocop/cop/layout/hash_alignment.rb +17 -20
- data/lib/rubocop/cop/layout/heredoc_argument_closing_parenthesis.rb +15 -14
- data/lib/rubocop/cop/layout/heredoc_indentation.rb +14 -11
- data/lib/rubocop/cop/layout/initial_indentation.rb +6 -7
- data/lib/rubocop/cop/layout/leading_comment_space.rb +11 -9
- data/lib/rubocop/cop/layout/leading_empty_lines.rb +6 -11
- data/lib/rubocop/cop/layout/multiline_array_brace_layout.rb +2 -5
- data/lib/rubocop/cop/layout/multiline_array_line_breaks.rb +2 -5
- data/lib/rubocop/cop/layout/multiline_assignment_layout.rb +10 -14
- data/lib/rubocop/cop/layout/multiline_block_layout.rb +21 -19
- data/lib/rubocop/cop/layout/multiline_hash_brace_layout.rb +2 -5
- data/lib/rubocop/cop/layout/multiline_hash_key_line_breaks.rb +2 -5
- data/lib/rubocop/cop/layout/multiline_method_argument_line_breaks.rb +5 -9
- data/lib/rubocop/cop/layout/multiline_method_call_brace_layout.rb +2 -5
- data/lib/rubocop/cop/layout/multiline_method_definition_brace_layout.rb +2 -5
- data/lib/rubocop/cop/layout/rescue_ensure_alignment.rb +41 -22
- data/lib/rubocop/cop/layout/space_after_colon.rb +11 -7
- data/lib/rubocop/cop/layout/space_after_comma.rb +2 -5
- data/lib/rubocop/cop/layout/space_after_method_name.rb +5 -6
- data/lib/rubocop/cop/layout/space_after_not.rb +9 -11
- data/lib/rubocop/cop/layout/space_after_semicolon.rb +2 -5
- data/lib/rubocop/cop/layout/space_around_equals_in_parameter_default.rb +17 -21
- data/lib/rubocop/cop/layout/space_around_keyword.rb +17 -18
- data/lib/rubocop/cop/layout/space_around_operators.rb +17 -16
- data/lib/rubocop/cop/layout/space_before_block_braces.rb +23 -22
- data/lib/rubocop/cop/layout/space_before_comma.rb +3 -5
- data/lib/rubocop/cop/layout/space_before_comment.rb +10 -7
- data/lib/rubocop/cop/layout/space_before_first_arg.rb +7 -7
- data/lib/rubocop/cop/layout/space_before_semicolon.rb +2 -5
- data/lib/rubocop/cop/layout/space_in_lambda_literal.rb +9 -17
- data/lib/rubocop/cop/layout/space_inside_array_literal_brackets.rb +20 -23
- data/lib/rubocop/cop/layout/space_inside_array_percent_literal.rb +3 -8
- data/lib/rubocop/cop/layout/space_inside_block_braces.rb +13 -16
- data/lib/rubocop/cop/layout/space_inside_hash_literal_braces.rb +19 -37
- data/lib/rubocop/cop/layout/space_inside_parens.rb +9 -14
- data/lib/rubocop/cop/layout/space_inside_percent_literal_delimiters.rb +5 -10
- data/lib/rubocop/cop/layout/space_inside_range_literal.rb +8 -17
- data/lib/rubocop/cop/layout/space_inside_reference_brackets.rb +16 -24
- data/lib/rubocop/cop/layout/space_inside_string_interpolation.rb +12 -13
- data/lib/rubocop/cop/layout/trailing_empty_lines.rb +10 -15
- data/lib/rubocop/cop/layout/trailing_whitespace.rb +11 -11
- data/lib/rubocop/cop/lint/ambiguous_block_association.rb +2 -0
- data/lib/rubocop/cop/lint/ambiguous_operator.rb +2 -0
- data/lib/rubocop/cop/lint/ambiguous_regexp_literal.rb +15 -1
- data/lib/rubocop/cop/lint/big_decimal_new.rb +1 -2
- data/lib/rubocop/cop/lint/binary_operator_with_identical_operands.rb +1 -1
- data/lib/rubocop/cop/lint/boolean_symbol.rb +3 -0
- data/lib/rubocop/cop/lint/constant_definition_in_block.rb +74 -0
- data/lib/rubocop/cop/lint/constant_resolution.rb +1 -1
- data/lib/rubocop/cop/lint/debugger.rb +2 -3
- data/lib/rubocop/cop/lint/deprecated_class_methods.rb +1 -3
- data/lib/rubocop/cop/lint/duplicate_methods.rb +2 -4
- data/lib/rubocop/cop/lint/duplicate_require.rb +46 -0
- data/lib/rubocop/cop/lint/duplicate_rescue_exception.rb +2 -15
- data/lib/rubocop/cop/lint/each_with_object_argument.rb +1 -0
- data/lib/rubocop/cop/lint/empty_file.rb +50 -0
- data/lib/rubocop/cop/lint/erb_new_arguments.rb +2 -0
- data/lib/rubocop/cop/lint/float_comparison.rb +2 -2
- data/lib/rubocop/cop/lint/format_parameter_mismatch.rb +2 -2
- data/lib/rubocop/cop/lint/hash_compare_by_identity.rb +37 -0
- data/lib/rubocop/cop/lint/identity_comparison.rb +51 -0
- data/lib/rubocop/cop/lint/ineffective_access_modifier.rb +2 -5
- data/lib/rubocop/cop/lint/inherit_exception.rb +2 -2
- data/lib/rubocop/cop/lint/missing_super.rb +2 -2
- data/lib/rubocop/cop/lint/mixed_regexp_capture_types.rb +3 -35
- data/lib/rubocop/cop/lint/multiple_comparison.rb +3 -1
- data/lib/rubocop/cop/lint/number_conversion.rb +1 -0
- data/lib/rubocop/cop/lint/out_of_range_regexp_ref.rb +9 -20
- data/lib/rubocop/cop/lint/parentheses_as_grouped_expression.rb +1 -1
- data/lib/rubocop/cop/lint/percent_string_array.rb +8 -12
- data/lib/rubocop/cop/lint/raise_exception.rb +1 -0
- data/lib/rubocop/cop/lint/rand_one.rb +2 -1
- data/lib/rubocop/cop/lint/redundant_cop_disable_directive.rb +22 -12
- data/lib/rubocop/cop/lint/redundant_cop_enable_directive.rb +14 -4
- data/lib/rubocop/cop/lint/redundant_require_statement.rb +1 -0
- data/lib/rubocop/cop/lint/redundant_safe_navigation.rb +45 -0
- data/lib/rubocop/cop/lint/rescue_type.rb +0 -1
- data/lib/rubocop/cop/lint/send_with_mixin_argument.rb +3 -1
- data/lib/rubocop/cop/lint/shadowed_exception.rb +6 -6
- data/lib/rubocop/cop/lint/shadowing_outer_local_variable.rb +4 -4
- data/lib/rubocop/cop/lint/struct_new_override.rb +1 -0
- data/lib/rubocop/cop/lint/to_json.rb +16 -5
- data/lib/rubocop/cop/lint/top_level_return_with_argument.rb +1 -1
- data/lib/rubocop/cop/lint/trailing_comma_in_attribute_declaration.rb +57 -0
- data/lib/rubocop/cop/lint/unreachable_loop.rb +3 -6
- data/lib/rubocop/cop/lint/uri_escape_unescape.rb +3 -1
- data/lib/rubocop/cop/lint/uri_regexp.rb +2 -1
- data/lib/rubocop/cop/lint/useless_access_modifier.rb +3 -9
- data/lib/rubocop/cop/lint/useless_method_definition.rb +70 -0
- data/lib/rubocop/cop/lint/useless_times.rb +106 -0
- data/lib/rubocop/cop/metrics/block_length.rb +3 -1
- data/lib/rubocop/cop/metrics/class_length.rb +8 -6
- data/lib/rubocop/cop/metrics/utils/abc_size_calculator.rb +27 -16
- data/lib/rubocop/cop/metrics/utils/code_length_calculator.rb +1 -0
- data/lib/rubocop/cop/mixin/alignment.rb +3 -0
- data/lib/rubocop/cop/mixin/allowed_methods.rb +2 -0
- data/lib/rubocop/cop/mixin/annotation_comment.rb +5 -0
- data/lib/rubocop/cop/mixin/check_line_breakable.rb +16 -7
- data/lib/rubocop/cop/mixin/comments_help.rb +48 -0
- data/lib/rubocop/cop/mixin/configurable_naming.rb +2 -2
- data/lib/rubocop/cop/mixin/configurable_numbering.rb +3 -3
- data/lib/rubocop/cop/mixin/empty_lines_around_body.rb +8 -7
- data/lib/rubocop/cop/mixin/empty_parameter.rb +3 -1
- data/lib/rubocop/cop/mixin/end_keyword_alignment.rb +12 -1
- data/lib/rubocop/cop/mixin/first_element_line_break.rb +3 -1
- data/lib/rubocop/cop/mixin/hash_transform_method.rb +27 -2
- data/lib/rubocop/cop/mixin/multiline_element_line_breaks.rb +3 -1
- data/lib/rubocop/cop/mixin/multiline_literal_brace_layout.rb +12 -10
- data/lib/rubocop/cop/mixin/negative_conditional.rb +2 -2
- data/lib/rubocop/cop/mixin/percent_array.rb +14 -3
- data/lib/rubocop/cop/mixin/rescue_node.rb +11 -1
- data/lib/rubocop/cop/mixin/space_after_punctuation.rb +4 -3
- data/lib/rubocop/cop/mixin/space_before_punctuation.rb +4 -3
- data/lib/rubocop/cop/mixin/statement_modifier.rb +9 -3
- data/lib/rubocop/cop/mixin/surrounding_space.rb +8 -4
- data/lib/rubocop/cop/mixin/trailing_comma.rb +7 -7
- data/lib/rubocop/cop/mixin/visibility_help.rb +4 -16
- data/lib/rubocop/cop/naming/binary_operator_parameter_name.rb +1 -1
- data/lib/rubocop/cop/naming/file_name.rb +1 -1
- data/lib/rubocop/cop/offense.rb +16 -2
- data/lib/rubocop/cop/security/eval.rb +1 -0
- data/lib/rubocop/cop/security/json_load.rb +1 -0
- data/lib/rubocop/cop/security/marshal_load.rb +1 -0
- data/lib/rubocop/cop/security/open.rb +1 -0
- data/lib/rubocop/cop/security/yaml_load.rb +1 -0
- data/lib/rubocop/cop/severity.rb +0 -8
- data/lib/rubocop/cop/style/access_modifier_declarations.rb +7 -11
- data/lib/rubocop/cop/style/accessor_grouping.rb +3 -0
- data/lib/rubocop/cop/style/alias.rb +2 -0
- data/lib/rubocop/cop/style/array_coercion.rb +4 -0
- data/lib/rubocop/cop/style/array_join.rb +1 -0
- data/lib/rubocop/cop/style/attr.rb +1 -0
- data/lib/rubocop/cop/style/auto_resource_cleanup.rb +2 -0
- data/lib/rubocop/cop/style/case_equality.rb +11 -3
- data/lib/rubocop/cop/style/case_like_if.rb +40 -8
- data/lib/rubocop/cop/style/class_and_module_children.rb +2 -0
- data/lib/rubocop/cop/style/class_check.rb +6 -9
- data/lib/rubocop/cop/style/class_equality_comparison.rb +49 -0
- data/lib/rubocop/cop/style/class_methods_definitions.rb +157 -0
- data/lib/rubocop/cop/style/class_vars.rb +1 -2
- data/lib/rubocop/cop/style/combinable_loops.rb +91 -0
- data/lib/rubocop/cop/style/comment_annotation.rb +6 -0
- data/lib/rubocop/cop/style/commented_keyword.rb +7 -8
- data/lib/rubocop/cop/style/conditional_assignment.rb +49 -60
- data/lib/rubocop/cop/style/date_time.rb +12 -1
- data/lib/rubocop/cop/style/dir.rb +1 -0
- data/lib/rubocop/cop/style/double_negation.rb +1 -0
- data/lib/rubocop/cop/style/empty_block_parameter.rb +9 -10
- data/lib/rubocop/cop/style/empty_lambda_parameter.rb +9 -10
- data/lib/rubocop/cop/style/empty_literal.rb +3 -1
- data/lib/rubocop/cop/style/eval_with_location.rb +1 -3
- data/lib/rubocop/cop/style/even_odd.rb +1 -0
- data/lib/rubocop/cop/style/expand_path_arguments.rb +2 -2
- data/lib/rubocop/cop/style/explicit_block_argument.rb +7 -3
- data/lib/rubocop/cop/style/float_division.rb +2 -0
- data/lib/rubocop/cop/style/for.rb +0 -4
- data/lib/rubocop/cop/style/format_string.rb +1 -4
- data/lib/rubocop/cop/style/format_string_token.rb +1 -1
- data/lib/rubocop/cop/style/guard_clause.rb +1 -0
- data/lib/rubocop/cop/style/hash_as_last_array_item.rb +24 -5
- data/lib/rubocop/cop/style/hash_syntax.rb +6 -5
- data/lib/rubocop/cop/style/hash_transform_keys.rb +16 -9
- data/lib/rubocop/cop/style/hash_transform_values.rb +16 -9
- data/lib/rubocop/cop/style/if_unless_modifier.rb +2 -6
- data/lib/rubocop/cop/style/implicit_runtime_error.rb +1 -0
- data/lib/rubocop/cop/style/keyword_parameters_order.rb +53 -0
- data/lib/rubocop/cop/style/lambda_call.rb +3 -1
- data/lib/rubocop/cop/style/method_called_on_do_end_block.rb +10 -1
- data/lib/rubocop/cop/style/method_def_parentheses.rb +0 -4
- data/lib/rubocop/cop/style/mixin_usage.rb +8 -27
- data/lib/rubocop/cop/style/multiline_block_chain.rb +2 -2
- data/lib/rubocop/cop/style/multiline_ternary_operator.rb +14 -1
- data/lib/rubocop/cop/style/multiline_when_then.rb +3 -2
- data/lib/rubocop/cop/style/negated_if.rb +6 -6
- data/lib/rubocop/cop/style/negated_unless.rb +6 -6
- data/lib/rubocop/cop/style/negated_while.rb +7 -15
- data/lib/rubocop/cop/style/nested_modifier.rb +10 -13
- data/lib/rubocop/cop/style/nested_parenthesized_calls.rb +11 -11
- data/lib/rubocop/cop/style/nested_ternary_operator.rb +16 -16
- data/lib/rubocop/cop/style/next.rb +10 -14
- data/lib/rubocop/cop/style/nil_comparison.rb +13 -11
- data/lib/rubocop/cop/style/non_nil_check.rb +34 -26
- data/lib/rubocop/cop/style/not.rb +20 -26
- data/lib/rubocop/cop/style/numeric_literal_prefix.rb +4 -9
- data/lib/rubocop/cop/style/numeric_predicate.rb +5 -14
- data/lib/rubocop/cop/style/one_line_conditional.rb +73 -23
- data/lib/rubocop/cop/style/option_hash.rb +1 -1
- data/lib/rubocop/cop/style/optional_arguments.rb +1 -1
- data/lib/rubocop/cop/style/optional_boolean_parameter.rb +12 -1
- data/lib/rubocop/cop/style/or_assignment.rb +13 -10
- data/lib/rubocop/cop/style/parallel_assignment.rb +14 -14
- data/lib/rubocop/cop/style/parentheses_around_condition.rb +6 -6
- data/lib/rubocop/cop/style/percent_literal_delimiters.rb +13 -19
- data/lib/rubocop/cop/style/percent_q_literals.rb +8 -10
- data/lib/rubocop/cop/style/perl_backrefs.rb +8 -10
- data/lib/rubocop/cop/style/preferred_hash_methods.rb +11 -14
- data/lib/rubocop/cop/style/proc.rb +6 -6
- data/lib/rubocop/cop/style/raise_args.rb +12 -24
- data/lib/rubocop/cop/style/random_with_offset.rb +19 -19
- data/lib/rubocop/cop/style/redundant_assignment.rb +8 -18
- data/lib/rubocop/cop/style/redundant_begin.rb +28 -12
- data/lib/rubocop/cop/style/redundant_capital_w.rb +6 -9
- data/lib/rubocop/cop/style/redundant_condition.rb +10 -7
- data/lib/rubocop/cop/style/redundant_conditional.rb +4 -5
- data/lib/rubocop/cop/style/redundant_exception.rb +1 -3
- data/lib/rubocop/cop/style/redundant_fetch_block.rb +3 -12
- data/lib/rubocop/cop/style/redundant_file_extension_in_require.rb +9 -8
- data/lib/rubocop/cop/style/redundant_freeze.rb +5 -7
- data/lib/rubocop/cop/style/redundant_interpolation.rb +31 -25
- data/lib/rubocop/cop/style/redundant_parentheses.rb +21 -15
- data/lib/rubocop/cop/style/redundant_percent_q.rb +9 -11
- data/lib/rubocop/cop/style/redundant_regexp_character_class.rb +44 -36
- data/lib/rubocop/cop/style/redundant_regexp_escape.rb +13 -29
- data/lib/rubocop/cop/style/redundant_return.rb +17 -17
- data/lib/rubocop/cop/style/redundant_self.rb +9 -11
- data/lib/rubocop/cop/style/redundant_self_assignment.rb +116 -0
- data/lib/rubocop/cop/style/redundant_sort.rb +12 -29
- data/lib/rubocop/cop/style/redundant_sort_by.rb +5 -9
- data/lib/rubocop/cop/style/regexp_literal.rb +10 -21
- data/lib/rubocop/cop/style/rescue_modifier.rb +29 -9
- data/lib/rubocop/cop/style/rescue_standard_error.rb +20 -16
- data/lib/rubocop/cop/style/return_nil.rb +5 -5
- data/lib/rubocop/cop/style/safe_navigation.rb +18 -12
- data/lib/rubocop/cop/style/sample.rb +12 -14
- data/lib/rubocop/cop/style/self_assignment.rb +26 -22
- data/lib/rubocop/cop/style/semicolon.rb +6 -9
- data/lib/rubocop/cop/style/send.rb +4 -5
- data/lib/rubocop/cop/style/signal_exception.rb +23 -19
- data/lib/rubocop/cop/style/single_argument_dig.rb +1 -0
- data/lib/rubocop/cop/style/single_line_block_params.rb +4 -2
- data/lib/rubocop/cop/style/single_line_methods.rb +17 -16
- data/lib/rubocop/cop/style/slicing_with_range.rb +6 -8
- data/lib/rubocop/cop/style/sole_nested_conditional.rb +66 -0
- data/lib/rubocop/cop/style/special_global_vars.rb +10 -15
- data/lib/rubocop/cop/style/stabby_lambda_parentheses.rb +17 -21
- data/lib/rubocop/cop/style/stderr_puts.rb +5 -6
- data/lib/rubocop/cop/style/string_concatenation.rb +17 -3
- data/lib/rubocop/cop/style/string_hash_keys.rb +6 -7
- data/lib/rubocop/cop/style/string_methods.rb +7 -17
- data/lib/rubocop/cop/style/strip.rb +9 -14
- data/lib/rubocop/cop/style/struct_inheritance.rb +3 -6
- data/lib/rubocop/cop/style/symbol_array.rb +5 -16
- data/lib/rubocop/cop/style/symbol_literal.rb +4 -6
- data/lib/rubocop/cop/style/symbol_proc.rb +14 -18
- data/lib/rubocop/cop/style/ternary_parentheses.rb +22 -22
- data/lib/rubocop/cop/style/trailing_body_on_class.rb +3 -6
- data/lib/rubocop/cop/style/trailing_body_on_method_definition.rb +4 -7
- data/lib/rubocop/cop/style/trailing_body_on_module.rb +3 -6
- data/lib/rubocop/cop/style/trailing_comma_in_arguments.rb +2 -5
- data/lib/rubocop/cop/style/trailing_comma_in_array_literal.rb +2 -5
- data/lib/rubocop/cop/style/trailing_comma_in_block_args.rb +11 -9
- data/lib/rubocop/cop/style/trailing_comma_in_hash_literal.rb +2 -5
- data/lib/rubocop/cop/style/trailing_underscore_variable.rb +8 -17
- data/lib/rubocop/cop/style/trivial_accessors.rb +26 -30
- data/lib/rubocop/cop/style/unless_else.rb +5 -8
- data/lib/rubocop/cop/style/unpack_first.rb +5 -8
- data/lib/rubocop/cop/style/variable_interpolation.rb +7 -10
- data/lib/rubocop/cop/style/when_then.rb +4 -6
- data/lib/rubocop/cop/style/while_until_do.rb +6 -16
- data/lib/rubocop/cop/style/while_until_modifier.rb +6 -20
- data/lib/rubocop/cop/style/word_array.rb +5 -23
- data/lib/rubocop/cop/style/yoda_condition.rb +4 -15
- data/lib/rubocop/cop/style/zero_length_predicate.rb +12 -18
- data/lib/rubocop/cop/team.rb +1 -0
- data/lib/rubocop/cop/util.rb +1 -2
- data/lib/rubocop/cop/utils/format_string.rb +3 -5
- data/lib/rubocop/cop/variable_force.rb +2 -0
- data/lib/rubocop/cop/variable_force/branch.rb +0 -4
- data/lib/rubocop/cops_documentation_generator.rb +4 -2
- data/lib/rubocop/core_ext/string.rb +2 -2
- data/lib/rubocop/directive_comment.rb +32 -0
- data/lib/rubocop/ext/regexp_node.rb +62 -0
- data/lib/rubocop/file_finder.rb +1 -0
- data/lib/rubocop/formatter/auto_gen_config_formatter.rb +2 -1
- data/lib/rubocop/formatter/disabled_config_formatter.rb +12 -5
- data/lib/rubocop/formatter/html_formatter.rb +2 -0
- data/lib/rubocop/formatter/progress_formatter.rb +2 -1
- data/lib/rubocop/formatter/quiet_formatter.rb +1 -1
- data/lib/rubocop/formatter/simple_text_formatter.rb +36 -6
- data/lib/rubocop/name_similarity.rb +1 -0
- data/lib/rubocop/options.rb +40 -17
- data/lib/rubocop/remote_config.rb +1 -0
- data/lib/rubocop/result_cache.rb +39 -15
- data/lib/rubocop/rspec/cop_helper.rb +5 -2
- data/lib/rubocop/rspec/expect_offense.rb +14 -9
- data/lib/rubocop/rspec/shared_contexts.rb +12 -0
- data/lib/rubocop/runner.rb +38 -18
- data/lib/rubocop/string_interpreter.rb +3 -0
- data/lib/rubocop/target_finder.rb +28 -26
- data/lib/rubocop/target_ruby.rb +7 -1
- data/lib/rubocop/version.rb +7 -1
- data/lib/rubocop/yaml_duplication_checker.rb +1 -0
- metadata +31 -17
- data/lib/rubocop/cop/mixin/regexp_literal_help.rb +0 -43
- data/lib/rubocop/cop/tokens_util.rb +0 -84
@@ -8,8 +8,8 @@ module RuboCop
|
|
8
8
|
include ConfigurableFormatting
|
9
9
|
|
10
10
|
FORMATS = {
|
11
|
-
snake_case: /^@{0,2}[\
|
12
|
-
camelCase: /^@{0,2}(?:_|_?[
|
11
|
+
snake_case: /^@{0,2}[\d[[:lower:]]_]+[!?=]?$/,
|
12
|
+
camelCase: /^@{0,2}(?:_|_?[[[:lower:]]][\d[[:lower:]][[:upper:]]]*)[!?=]?$/
|
13
13
|
}.freeze
|
14
14
|
end
|
15
15
|
end
|
@@ -8,9 +8,9 @@ module RuboCop
|
|
8
8
|
include ConfigurableFormatting
|
9
9
|
|
10
10
|
FORMATS = {
|
11
|
-
snake_case: /(?:[
|
12
|
-
normalcase: /(?:_\D*|[
|
13
|
-
non_integer: /[
|
11
|
+
snake_case: /(?:[[[:lower:]]_]|_\d+)$/,
|
12
|
+
normalcase: /(?:_\D*|[[[:upper:]][[:lower:]]]\d*)$/,
|
13
|
+
non_integer: /[[[:upper:]][[:lower:]]_]$/
|
14
14
|
}.freeze
|
15
15
|
end
|
16
16
|
end
|
@@ -19,7 +19,8 @@ module RuboCop
|
|
19
19
|
private
|
20
20
|
|
21
21
|
def_node_matcher :constant_definition?, '{class module}'
|
22
|
-
def_node_matcher :empty_line_required?,
|
22
|
+
def_node_matcher :empty_line_required?,
|
23
|
+
'{def defs class module (send nil? {:private :protected :public})}'
|
23
24
|
|
24
25
|
def check(node, body, adjusted_first_line: nil)
|
25
26
|
return if valid_body_style?(body)
|
@@ -100,7 +101,9 @@ module RuboCop
|
|
100
101
|
|
101
102
|
offset = style == :empty_lines && msg.include?('end.') ? 2 : 1
|
102
103
|
range = source_range(processed_source.buffer, line + offset, 0)
|
103
|
-
add_offense(
|
104
|
+
add_offense(range, message: msg) do |corrector|
|
105
|
+
EmptyLineCorrector.correct(corrector, [style, range])
|
106
|
+
end
|
104
107
|
end
|
105
108
|
|
106
109
|
def check_deferred_empty_line(body)
|
@@ -112,11 +115,9 @@ module RuboCop
|
|
112
115
|
|
113
116
|
range = source_range(processed_source.buffer, line + 2, 0)
|
114
117
|
|
115
|
-
add_offense(
|
116
|
-
[:empty_lines, range]
|
117
|
-
|
118
|
-
message: deferred_message(node)
|
119
|
-
)
|
118
|
+
add_offense(range, message: deferred_message(node)) do |corrector|
|
119
|
+
EmptyLineCorrector.correct(corrector, [:empty_lines, range])
|
120
|
+
end
|
120
121
|
end
|
121
122
|
|
122
123
|
def namespace?(body, with_one_child: false)
|
@@ -39,6 +39,15 @@ module RuboCop
|
|
39
39
|
end
|
40
40
|
end
|
41
41
|
|
42
|
+
def start_line_range(node)
|
43
|
+
expr = node.source_range
|
44
|
+
buffer = expr.source_buffer
|
45
|
+
source = buffer.source_line(expr.line)
|
46
|
+
range = buffer.line_range(expr.line)
|
47
|
+
|
48
|
+
range_between(range.begin_pos + (source =~ /\S/), range.begin_pos + (source =~ /\s*\z/))
|
49
|
+
end
|
50
|
+
|
42
51
|
def add_offense_for_misalignment(node, align_with)
|
43
52
|
end_loc = node.loc.end
|
44
53
|
msg = format(MSG, end_line: end_loc.line,
|
@@ -46,7 +55,9 @@ module RuboCop
|
|
46
55
|
source: align_with.source,
|
47
56
|
align_line: align_with.line,
|
48
57
|
align_col: align_with.column)
|
49
|
-
add_offense(
|
58
|
+
add_offense(end_loc, message: msg) do |corrector|
|
59
|
+
autocorrect(corrector, node)
|
60
|
+
end
|
50
61
|
end
|
51
62
|
|
52
63
|
def accept_end_kw_alignment?(end_loc)
|
@@ -4,11 +4,25 @@ module RuboCop
|
|
4
4
|
module Cop
|
5
5
|
# Common functionality for Style/HashTransformKeys and
|
6
6
|
# Style/HashTransformValues
|
7
|
-
module HashTransformMethod
|
7
|
+
module HashTransformMethod # rubocop:disable Metrics/ModuleLength
|
8
|
+
extend NodePattern::Macros
|
9
|
+
|
10
|
+
RESTRICT_ON_SEND = %i[[] to_h].freeze
|
11
|
+
|
12
|
+
def_node_matcher :array_receiver?, <<~PATTERN
|
13
|
+
{(array ...) (send _ :each_with_index) (send _ :with_index _ ?) (send _ :zip ...)}
|
14
|
+
PATTERN
|
15
|
+
|
8
16
|
def on_block(node)
|
9
17
|
on_bad_each_with_object(node) do |*match|
|
10
18
|
handle_possible_offense(node, match, 'each_with_object')
|
11
19
|
end
|
20
|
+
|
21
|
+
return if target_ruby_version < 2.6
|
22
|
+
|
23
|
+
on_bad_to_h(node) do |*match|
|
24
|
+
handle_possible_offense(node, match, 'to_h {...}')
|
25
|
+
end
|
12
26
|
end
|
13
27
|
|
14
28
|
def on_send(node)
|
@@ -43,6 +57,11 @@ module RuboCop
|
|
43
57
|
raise NotImplementedError
|
44
58
|
end
|
45
59
|
|
60
|
+
# @abstract Implemented with `def_node_matcher`
|
61
|
+
def on_bad_to_h(_node)
|
62
|
+
raise NotImplementedError
|
63
|
+
end
|
64
|
+
|
46
65
|
def handle_possible_offense(node, match, match_desc)
|
47
66
|
captures = extract_captures(match)
|
48
67
|
|
@@ -82,6 +101,8 @@ module RuboCop
|
|
82
101
|
Autocorrection.from_hash_brackets_map(node, match)
|
83
102
|
elsif (match = on_bad_map_to_h(node))
|
84
103
|
Autocorrection.from_map_to_h(node, match)
|
104
|
+
elsif (match = on_bad_to_h(node))
|
105
|
+
Autocorrection.from_to_h(node, match)
|
85
106
|
else
|
86
107
|
raise 'unreachable'
|
87
108
|
end
|
@@ -116,7 +137,7 @@ module RuboCop
|
|
116
137
|
end
|
117
138
|
|
118
139
|
# Internal helper class to hold autocorrect data
|
119
|
-
Autocorrection = Struct.new(:match, :block_node, :leading, :trailing) do
|
140
|
+
Autocorrection = Struct.new(:match, :block_node, :leading, :trailing) do
|
120
141
|
def self.from_each_with_object(node, match)
|
121
142
|
new(match, node, 0, 0)
|
122
143
|
end
|
@@ -137,6 +158,10 @@ module RuboCop
|
|
137
158
|
new(match, node.children.first, 0, strip_trailing_chars)
|
138
159
|
end
|
139
160
|
|
161
|
+
def self.from_to_h(node, match)
|
162
|
+
new(match, node, 0, 0)
|
163
|
+
end
|
164
|
+
|
140
165
|
def strip_prefix_and_suffix(node, corrector)
|
141
166
|
expression = node.loc.expression
|
142
167
|
corrector.remove_leading(expression, leading)
|
@@ -16,7 +16,9 @@ module RuboCop
|
|
16
16
|
last_seen_line = -1
|
17
17
|
children.each do |child|
|
18
18
|
if last_seen_line >= child.first_line
|
19
|
-
add_offense(child)
|
19
|
+
add_offense(child) do |corrector|
|
20
|
+
EmptyLineCorrector.insert_before(corrector, child)
|
21
|
+
end
|
20
22
|
else
|
21
23
|
last_seen_line = child.last_line
|
22
24
|
end
|
@@ -43,30 +43,32 @@ module RuboCop
|
|
43
43
|
def check_new_line(node)
|
44
44
|
return unless closing_brace_on_same_line?(node)
|
45
45
|
|
46
|
-
add_offense(node,
|
47
|
-
|
48
|
-
|
46
|
+
add_offense(node.loc.end, message: self.class::ALWAYS_NEW_LINE_MESSAGE) do |corrector|
|
47
|
+
MultilineLiteralBraceCorrector.correct(corrector, node, processed_source)
|
48
|
+
end
|
49
49
|
end
|
50
50
|
|
51
51
|
def check_same_line(node)
|
52
52
|
return if closing_brace_on_same_line?(node)
|
53
53
|
|
54
|
-
add_offense(node,
|
55
|
-
|
56
|
-
|
54
|
+
add_offense(node.loc.end, message: self.class::ALWAYS_SAME_LINE_MESSAGE) do |corrector|
|
55
|
+
MultilineLiteralBraceCorrector.correct(corrector, node, processed_source)
|
56
|
+
end
|
57
57
|
end
|
58
58
|
|
59
59
|
def check_symmetrical(node)
|
60
60
|
if opening_brace_on_same_line?(node)
|
61
61
|
return if closing_brace_on_same_line?(node)
|
62
62
|
|
63
|
-
add_offense(node,
|
64
|
-
|
63
|
+
add_offense(node.loc.end, message: self.class::SAME_LINE_MESSAGE) do |corrector|
|
64
|
+
MultilineLiteralBraceCorrector.correct(corrector, node, processed_source)
|
65
|
+
end
|
65
66
|
else
|
66
67
|
return unless closing_brace_on_same_line?(node)
|
67
68
|
|
68
|
-
add_offense(node,
|
69
|
-
|
69
|
+
add_offense(node.loc.end, message: self.class::NEW_LINE_MESSAGE) do |corrector|
|
70
|
+
MultilineLiteralBraceCorrector.correct(corrector, node, processed_source)
|
71
|
+
end
|
70
72
|
end
|
71
73
|
end
|
72
74
|
|
@@ -15,7 +15,7 @@ module RuboCop
|
|
15
15
|
def_node_matcher :single_negative?, '(send !(send _ :!) :!)'
|
16
16
|
def_node_matcher :empty_condition?, '(begin)'
|
17
17
|
|
18
|
-
def check_negative_conditional(node)
|
18
|
+
def check_negative_conditional(node, message:, &block)
|
19
19
|
condition = node.condition
|
20
20
|
|
21
21
|
return if empty_condition?(condition)
|
@@ -25,7 +25,7 @@ module RuboCop
|
|
25
25
|
return unless single_negative?(condition)
|
26
26
|
return if node.if_type? && node.else?
|
27
27
|
|
28
|
-
add_offense(node)
|
28
|
+
add_offense(node, message: message, &block)
|
29
29
|
end
|
30
30
|
end
|
31
31
|
end
|
@@ -34,14 +34,25 @@ module RuboCop
|
|
34
34
|
|
35
35
|
def check_percent_array(node)
|
36
36
|
array_style_detected(:percent, node.values.size)
|
37
|
-
|
37
|
+
|
38
|
+
return unless style == :brackets
|
39
|
+
|
40
|
+
add_offense(node) do |corrector|
|
41
|
+
correct_bracketed(corrector, node)
|
42
|
+
end
|
38
43
|
end
|
39
44
|
|
40
|
-
def check_bracketed_array(node)
|
45
|
+
def check_bracketed_array(node, literal_prefix)
|
41
46
|
return if allowed_bracket_array?(node)
|
42
47
|
|
43
48
|
array_style_detected(:brackets, node.values.size)
|
44
|
-
|
49
|
+
|
50
|
+
return unless style == :percent
|
51
|
+
|
52
|
+
add_offense(node) do |corrector|
|
53
|
+
percent_literal_corrector = PercentLiteralCorrector.new(@config, @preferred_delimiters)
|
54
|
+
percent_literal_corrector.correct(corrector, node, literal_prefix)
|
55
|
+
end
|
45
56
|
end
|
46
57
|
end
|
47
58
|
end
|
@@ -4,7 +4,7 @@ module RuboCop
|
|
4
4
|
module Cop
|
5
5
|
# Common functionality for checking `rescue` nodes.
|
6
6
|
module RescueNode
|
7
|
-
def
|
7
|
+
def on_new_investigation
|
8
8
|
@modifier_locations = processed_source
|
9
9
|
.tokens
|
10
10
|
.select(&:rescue_modifier?)
|
@@ -17,6 +17,16 @@ module RuboCop
|
|
17
17
|
node&.resbody_type? &&
|
18
18
|
@modifier_locations.include?(node.loc.keyword)
|
19
19
|
end
|
20
|
+
|
21
|
+
# @deprecated Use ResbodyNode#exceptions instead
|
22
|
+
def rescued_exceptions(resbody)
|
23
|
+
rescue_group, = *resbody
|
24
|
+
if rescue_group
|
25
|
+
rescue_group.values
|
26
|
+
else
|
27
|
+
[]
|
28
|
+
end
|
29
|
+
end
|
20
30
|
end
|
21
31
|
end
|
22
32
|
end
|
@@ -7,10 +7,11 @@ module RuboCop
|
|
7
7
|
module SpaceAfterPunctuation
|
8
8
|
MSG = 'Space missing after %<token>s.'
|
9
9
|
|
10
|
-
def
|
10
|
+
def on_new_investigation
|
11
11
|
each_missing_space(processed_source.tokens) do |token|
|
12
|
-
add_offense(token,
|
13
|
-
|
12
|
+
add_offense(token.pos, message: format(MSG, token: kind(token))) do |corrector|
|
13
|
+
PunctuationCorrector.add_space(corrector, token)
|
14
|
+
end
|
14
15
|
end
|
15
16
|
end
|
16
17
|
|
@@ -9,10 +9,11 @@ module RuboCop
|
|
9
9
|
|
10
10
|
MSG = 'Space found before %<token>s.'
|
11
11
|
|
12
|
-
def
|
12
|
+
def on_new_investigation
|
13
13
|
each_missing_space(processed_source.tokens) do |token, pos_before|
|
14
|
-
add_offense(pos_before,
|
15
|
-
|
14
|
+
add_offense(pos_before, message: format(MSG, token: kind(token))) do |corrector|
|
15
|
+
PunctuationCorrector.remove_space(corrector, pos_before)
|
16
|
+
end
|
16
17
|
end
|
17
18
|
end
|
18
19
|
|
@@ -57,10 +57,11 @@ module RuboCop
|
|
57
57
|
end
|
58
58
|
|
59
59
|
def first_line_comment(node)
|
60
|
-
comment =
|
61
|
-
|
60
|
+
comment = processed_source.find_comment { |c| c.loc.line == node.loc.line }
|
61
|
+
return unless comment
|
62
62
|
|
63
|
-
|
63
|
+
comment_source = comment.loc.expression.source
|
64
|
+
comment_source unless comment_disables_cop?(comment_source)
|
64
65
|
end
|
65
66
|
|
66
67
|
def parenthesize?(node)
|
@@ -80,6 +81,11 @@ module RuboCop
|
|
80
81
|
|
81
82
|
config.for_cop('Layout/LineLength')['Max']
|
82
83
|
end
|
84
|
+
|
85
|
+
def comment_disables_cop?(comment)
|
86
|
+
regexp_pattern = "# rubocop : (disable|todo) ([^,],)* (all|#{cop_name})"
|
87
|
+
Regexp.new(regexp_pattern.gsub(' ', '\s*')).match?(comment)
|
88
|
+
end
|
83
89
|
end
|
84
90
|
end
|
85
91
|
end
|
@@ -81,8 +81,11 @@ module RuboCop
|
|
81
81
|
|
82
82
|
def space_offense(node, token, side, message, command)
|
83
83
|
range = side_space_range(range: token.pos, side: side)
|
84
|
-
add_offense(
|
85
|
-
|
84
|
+
add_offense(range, message: format(message, command: command)) do |corrector|
|
85
|
+
autocorrect(corrector, node) unless ignored_node?(node)
|
86
|
+
|
87
|
+
ignore_node(node)
|
88
|
+
end
|
86
89
|
end
|
87
90
|
|
88
91
|
def empty_offenses(node, left, right, message)
|
@@ -96,8 +99,9 @@ module RuboCop
|
|
96
99
|
end
|
97
100
|
|
98
101
|
def empty_offense(node, range, message, command)
|
99
|
-
add_offense(
|
100
|
-
|
102
|
+
add_offense(range, message: format(message, command: command)) do |corrector|
|
103
|
+
autocorrect(corrector, node)
|
104
|
+
end
|
101
105
|
end
|
102
106
|
|
103
107
|
def empty_brackets?(left_bracket_token, right_bracket_token)
|
@@ -140,7 +140,9 @@ module RuboCop
|
|
140
140
|
unit: format(kind, article: article) + extra_info.to_s
|
141
141
|
)
|
142
142
|
|
143
|
-
add_offense(range,
|
143
|
+
add_offense(range, message: msg) do |corrector|
|
144
|
+
PunctuationCorrector.swap_comma(corrector, range)
|
145
|
+
end
|
144
146
|
end
|
145
147
|
|
146
148
|
def put_comma(items, kind)
|
@@ -148,13 +150,11 @@ module RuboCop
|
|
148
150
|
return if last_item.block_pass_type?
|
149
151
|
|
150
152
|
range = autocorrect_range(last_item)
|
151
|
-
msg = format(
|
152
|
-
MSG,
|
153
|
-
command: 'Put a',
|
154
|
-
unit: format(kind, article: 'a multiline')
|
155
|
-
)
|
153
|
+
msg = format(MSG, command: 'Put a', unit: format(kind, article: 'a multiline'))
|
156
154
|
|
157
|
-
add_offense(range,
|
155
|
+
add_offense(range, message: msg) do |corrector|
|
156
|
+
PunctuationCorrector.swap_comma(corrector, range)
|
157
|
+
end
|
158
158
|
end
|
159
159
|
|
160
160
|
def autocorrect_range(item)
|
@@ -16,32 +16,20 @@ module RuboCop
|
|
16
16
|
end
|
17
17
|
|
18
18
|
def find_visibility_start(node)
|
19
|
-
|
20
|
-
|
21
|
-
|
19
|
+
node.left_siblings
|
20
|
+
.reverse
|
21
|
+
.find(&method(:visibility_block?))
|
22
22
|
end
|
23
23
|
|
24
24
|
# Navigate to find the last protected method
|
25
25
|
def find_visibility_end(node)
|
26
26
|
possible_visibilities = VISIBILITY_SCOPES - [node_visibility(node)]
|
27
|
-
right =
|
27
|
+
right = node.right_siblings
|
28
28
|
right.find do |child_node|
|
29
29
|
possible_visibilities.include?(node_visibility(child_node))
|
30
30
|
end || right.last
|
31
31
|
end
|
32
32
|
|
33
|
-
def left_siblings_of(node)
|
34
|
-
siblings_of(node)[0, node.sibling_index]
|
35
|
-
end
|
36
|
-
|
37
|
-
def right_siblings_of(node)
|
38
|
-
siblings_of(node)[node.sibling_index..-1]
|
39
|
-
end
|
40
|
-
|
41
|
-
def siblings_of(node)
|
42
|
-
node.parent.children
|
43
|
-
end
|
44
|
-
|
45
33
|
def_node_matcher :visibility_block?, <<~PATTERN
|
46
34
|
(send nil? { :private :protected :public })
|
47
35
|
PATTERN
|