rubocop 0.89.1 → 0.90.0
Sign up to get free protection for your applications and to get access to all the features.
- checksums.yaml +4 -4
- data/README.md +1 -1
- data/config/default.yml +79 -11
- data/lib/rubocop.rb +13 -0
- data/lib/rubocop/cached_data.rb +1 -0
- data/lib/rubocop/cli/command.rb +1 -0
- data/lib/rubocop/cli/command/auto_genenerate_config.rb +1 -0
- data/lib/rubocop/cli/command/base.rb +1 -0
- data/lib/rubocop/cli/command/execute_runner.rb +1 -0
- data/lib/rubocop/cli/command/init_dotfile.rb +1 -0
- data/lib/rubocop/cli/command/show_cops.rb +1 -0
- data/lib/rubocop/cli/command/version.rb +1 -0
- data/lib/rubocop/cli/environment.rb +1 -0
- data/lib/rubocop/comment_config.rb +5 -0
- data/lib/rubocop/config_loader.rb +17 -6
- data/lib/rubocop/config_loader_resolver.rb +1 -0
- data/lib/rubocop/config_obsoletion.rb +1 -0
- data/lib/rubocop/config_validator.rb +3 -0
- data/lib/rubocop/cop/base.rb +23 -0
- data/lib/rubocop/cop/bundler/gem_comment.rb +7 -3
- data/lib/rubocop/cop/commissioner.rb +47 -7
- data/lib/rubocop/cop/correctors/alignment_corrector.rb +4 -4
- data/lib/rubocop/cop/correctors/condition_corrector.rb +3 -5
- data/lib/rubocop/cop/correctors/empty_line_corrector.rb +9 -10
- data/lib/rubocop/cop/correctors/line_break_corrector.rb +2 -2
- data/lib/rubocop/cop/correctors/multiline_literal_brace_corrector.rb +8 -3
- data/lib/rubocop/cop/correctors/parentheses_corrector.rb +5 -8
- data/lib/rubocop/cop/correctors/percent_literal_corrector.rb +4 -9
- data/lib/rubocop/cop/correctors/punctuation_corrector.rb +8 -10
- data/lib/rubocop/cop/documentation.rb +22 -0
- data/lib/rubocop/cop/generator.rb +1 -0
- data/lib/rubocop/cop/layout/block_alignment.rb +23 -19
- data/lib/rubocop/cop/layout/class_structure.rb +10 -9
- data/lib/rubocop/cop/layout/closing_heredoc_indentation.rb +4 -6
- data/lib/rubocop/cop/layout/condition_position.rb +13 -15
- data/lib/rubocop/cop/layout/def_end_alignment.rb +7 -4
- data/lib/rubocop/cop/layout/dot_position.rb +21 -17
- data/lib/rubocop/cop/layout/empty_comment.rb +30 -23
- data/lib/rubocop/cop/layout/empty_line_after_guard_clause.rb +19 -16
- data/lib/rubocop/cop/layout/empty_line_after_magic_comment.rb +13 -13
- data/lib/rubocop/cop/layout/empty_line_after_multiline_condition.rb +144 -0
- data/lib/rubocop/cop/layout/empty_line_between_defs.rb +21 -23
- data/lib/rubocop/cop/layout/empty_lines.rb +6 -7
- data/lib/rubocop/cop/layout/empty_lines_around_access_modifier.rb +4 -6
- data/lib/rubocop/cop/layout/empty_lines_around_arguments.rb +7 -8
- data/lib/rubocop/cop/layout/empty_lines_around_attribute_accessor.rb +3 -6
- data/lib/rubocop/cop/layout/empty_lines_around_begin_body.rb +2 -5
- data/lib/rubocop/cop/layout/empty_lines_around_block_body.rb +2 -5
- data/lib/rubocop/cop/layout/empty_lines_around_class_body.rb +2 -5
- data/lib/rubocop/cop/layout/empty_lines_around_exception_handling_keywords.rb +2 -5
- data/lib/rubocop/cop/layout/empty_lines_around_method_body.rb +2 -5
- data/lib/rubocop/cop/layout/empty_lines_around_module_body.rb +2 -5
- data/lib/rubocop/cop/layout/end_alignment.rb +6 -7
- data/lib/rubocop/cop/layout/first_array_element_line_break.rb +2 -5
- data/lib/rubocop/cop/layout/first_hash_element_line_break.rb +2 -5
- data/lib/rubocop/cop/layout/first_method_argument_line_break.rb +4 -8
- data/lib/rubocop/cop/layout/first_method_parameter_line_break.rb +2 -5
- data/lib/rubocop/cop/layout/hash_alignment.rb +17 -20
- data/lib/rubocop/cop/layout/heredoc_argument_closing_parenthesis.rb +15 -14
- data/lib/rubocop/cop/layout/heredoc_indentation.rb +14 -11
- data/lib/rubocop/cop/layout/initial_indentation.rb +6 -7
- data/lib/rubocop/cop/layout/leading_comment_space.rb +11 -9
- data/lib/rubocop/cop/layout/leading_empty_lines.rb +6 -11
- data/lib/rubocop/cop/layout/multiline_array_brace_layout.rb +2 -5
- data/lib/rubocop/cop/layout/multiline_array_line_breaks.rb +2 -5
- data/lib/rubocop/cop/layout/multiline_assignment_layout.rb +10 -14
- data/lib/rubocop/cop/layout/multiline_block_layout.rb +21 -19
- data/lib/rubocop/cop/layout/multiline_hash_brace_layout.rb +2 -5
- data/lib/rubocop/cop/layout/multiline_hash_key_line_breaks.rb +2 -5
- data/lib/rubocop/cop/layout/multiline_method_argument_line_breaks.rb +5 -9
- data/lib/rubocop/cop/layout/multiline_method_call_brace_layout.rb +2 -5
- data/lib/rubocop/cop/layout/multiline_method_definition_brace_layout.rb +2 -5
- data/lib/rubocop/cop/layout/rescue_ensure_alignment.rb +18 -21
- data/lib/rubocop/cop/layout/space_after_colon.rb +11 -7
- data/lib/rubocop/cop/layout/space_after_comma.rb +2 -5
- data/lib/rubocop/cop/layout/space_after_method_name.rb +5 -6
- data/lib/rubocop/cop/layout/space_after_not.rb +9 -11
- data/lib/rubocop/cop/layout/space_after_semicolon.rb +2 -5
- data/lib/rubocop/cop/layout/space_around_equals_in_parameter_default.rb +20 -15
- data/lib/rubocop/cop/layout/space_around_keyword.rb +17 -18
- data/lib/rubocop/cop/layout/space_around_operators.rb +17 -16
- data/lib/rubocop/cop/layout/space_before_block_braces.rb +23 -22
- data/lib/rubocop/cop/layout/space_before_comma.rb +3 -5
- data/lib/rubocop/cop/layout/space_before_comment.rb +10 -7
- data/lib/rubocop/cop/layout/space_before_first_arg.rb +7 -7
- data/lib/rubocop/cop/layout/space_before_semicolon.rb +2 -5
- data/lib/rubocop/cop/layout/space_in_lambda_literal.rb +9 -17
- data/lib/rubocop/cop/layout/space_inside_array_literal_brackets.rb +13 -16
- data/lib/rubocop/cop/layout/space_inside_array_percent_literal.rb +3 -8
- data/lib/rubocop/cop/layout/space_inside_block_braces.rb +17 -16
- data/lib/rubocop/cop/layout/space_inside_hash_literal_braces.rb +16 -19
- data/lib/rubocop/cop/layout/space_inside_parens.rb +9 -14
- data/lib/rubocop/cop/layout/space_inside_percent_literal_delimiters.rb +5 -10
- data/lib/rubocop/cop/layout/space_inside_range_literal.rb +8 -17
- data/lib/rubocop/cop/layout/space_inside_reference_brackets.rb +13 -16
- data/lib/rubocop/cop/layout/space_inside_string_interpolation.rb +10 -11
- data/lib/rubocop/cop/layout/trailing_empty_lines.rb +10 -15
- data/lib/rubocop/cop/layout/trailing_whitespace.rb +11 -11
- data/lib/rubocop/cop/lint/binary_operator_with_identical_operands.rb +1 -1
- data/lib/rubocop/cop/lint/constant_resolution.rb +1 -1
- data/lib/rubocop/cop/lint/duplicate_require.rb +41 -0
- data/lib/rubocop/cop/lint/duplicate_rescue_exception.rb +0 -11
- data/lib/rubocop/cop/lint/empty_file.rb +53 -0
- data/lib/rubocop/cop/lint/missing_super.rb +2 -2
- data/lib/rubocop/cop/lint/mixed_regexp_capture_types.rb +2 -35
- data/lib/rubocop/cop/lint/out_of_range_regexp_ref.rb +9 -19
- data/lib/rubocop/cop/lint/percent_string_array.rb +8 -12
- data/lib/rubocop/cop/lint/shadowing_outer_local_variable.rb +4 -4
- data/lib/rubocop/cop/lint/top_level_return_with_argument.rb +1 -1
- data/lib/rubocop/cop/lint/trailing_comma_in_attribute_declaration.rb +57 -0
- data/lib/rubocop/cop/lint/useless_method_definition.rb +77 -0
- data/lib/rubocop/cop/metrics/utils/abc_size_calculator.rb +2 -0
- data/lib/rubocop/cop/metrics/utils/code_length_calculator.rb +1 -0
- data/lib/rubocop/cop/mixin/alignment.rb +3 -0
- data/lib/rubocop/cop/mixin/allowed_methods.rb +2 -0
- data/lib/rubocop/cop/mixin/annotation_comment.rb +5 -0
- data/lib/rubocop/cop/mixin/check_line_breakable.rb +16 -7
- data/lib/rubocop/cop/mixin/comments_help.rb +54 -0
- data/lib/rubocop/cop/mixin/empty_lines_around_body.rb +8 -7
- data/lib/rubocop/cop/mixin/empty_parameter.rb +3 -1
- data/lib/rubocop/cop/mixin/end_keyword_alignment.rb +3 -1
- data/lib/rubocop/cop/mixin/first_element_line_break.rb +3 -1
- data/lib/rubocop/cop/mixin/hash_transform_method.rb +17 -0
- data/lib/rubocop/cop/mixin/multiline_element_line_breaks.rb +3 -1
- data/lib/rubocop/cop/mixin/multiline_literal_brace_layout.rb +12 -10
- data/lib/rubocop/cop/mixin/negative_conditional.rb +2 -2
- data/lib/rubocop/cop/mixin/percent_array.rb +14 -3
- data/lib/rubocop/cop/mixin/regexp_literal_help.rb +1 -1
- data/lib/rubocop/cop/mixin/rescue_node.rb +10 -1
- data/lib/rubocop/cop/mixin/space_after_punctuation.rb +4 -3
- data/lib/rubocop/cop/mixin/space_before_punctuation.rb +4 -3
- data/lib/rubocop/cop/mixin/surrounding_space.rb +8 -4
- data/lib/rubocop/cop/mixin/trailing_comma.rb +7 -7
- data/lib/rubocop/cop/offense.rb +1 -0
- data/lib/rubocop/cop/severity.rb +0 -8
- data/lib/rubocop/cop/style/case_equality.rb +8 -3
- data/lib/rubocop/cop/style/case_like_if.rb +20 -4
- data/lib/rubocop/cop/style/class_methods_definitions.rb +131 -0
- data/lib/rubocop/cop/style/combinable_loops.rb +89 -0
- data/lib/rubocop/cop/style/empty_block_parameter.rb +9 -10
- data/lib/rubocop/cop/style/empty_lambda_parameter.rb +9 -10
- data/lib/rubocop/cop/style/guard_clause.rb +1 -0
- data/lib/rubocop/cop/style/hash_syntax.rb +6 -5
- data/lib/rubocop/cop/style/hash_transform_keys.rb +14 -1
- data/lib/rubocop/cop/style/hash_transform_values.rb +14 -1
- data/lib/rubocop/cop/style/if_unless_modifier.rb +2 -2
- data/lib/rubocop/cop/style/keyword_parameters_order.rb +58 -0
- data/lib/rubocop/cop/style/method_called_on_do_end_block.rb +10 -1
- data/lib/rubocop/cop/style/multiline_when_then.rb +2 -2
- data/lib/rubocop/cop/style/negated_if.rb +6 -6
- data/lib/rubocop/cop/style/negated_unless.rb +6 -6
- data/lib/rubocop/cop/style/negated_while.rb +7 -15
- data/lib/rubocop/cop/style/nested_modifier.rb +10 -13
- data/lib/rubocop/cop/style/nested_parenthesized_calls.rb +11 -11
- data/lib/rubocop/cop/style/nested_ternary_operator.rb +14 -16
- data/lib/rubocop/cop/style/next.rb +10 -14
- data/lib/rubocop/cop/style/nil_comparison.rb +11 -11
- data/lib/rubocop/cop/style/non_nil_check.rb +32 -26
- data/lib/rubocop/cop/style/not.rb +19 -26
- data/lib/rubocop/cop/style/numeric_literal_prefix.rb +4 -9
- data/lib/rubocop/cop/style/numeric_predicate.rb +4 -11
- data/lib/rubocop/cop/style/one_line_conditional.rb +71 -23
- data/lib/rubocop/cop/style/option_hash.rb +1 -1
- data/lib/rubocop/cop/style/optional_arguments.rb +1 -1
- data/lib/rubocop/cop/style/or_assignment.rb +13 -10
- data/lib/rubocop/cop/style/parallel_assignment.rb +14 -14
- data/lib/rubocop/cop/style/parentheses_around_condition.rb +6 -6
- data/lib/rubocop/cop/style/percent_literal_delimiters.rb +13 -19
- data/lib/rubocop/cop/style/percent_q_literals.rb +8 -10
- data/lib/rubocop/cop/style/perl_backrefs.rb +8 -10
- data/lib/rubocop/cop/style/preferred_hash_methods.rb +9 -14
- data/lib/rubocop/cop/style/proc.rb +6 -6
- data/lib/rubocop/cop/style/raise_args.rb +13 -24
- data/lib/rubocop/cop/style/random_with_offset.rb +15 -16
- data/lib/rubocop/cop/style/redundant_assignment.rb +8 -10
- data/lib/rubocop/cop/style/redundant_begin.rb +7 -9
- data/lib/rubocop/cop/style/redundant_capital_w.rb +6 -9
- data/lib/rubocop/cop/style/redundant_condition.rb +5 -6
- data/lib/rubocop/cop/style/redundant_fetch_block.rb +3 -12
- data/lib/rubocop/cop/style/redundant_file_extension_in_require.rb +8 -8
- data/lib/rubocop/cop/style/redundant_freeze.rb +3 -6
- data/lib/rubocop/cop/style/redundant_interpolation.rb +25 -24
- data/lib/rubocop/cop/style/redundant_parentheses.rb +7 -9
- data/lib/rubocop/cop/style/redundant_regexp_character_class.rb +6 -13
- data/lib/rubocop/cop/style/redundant_regexp_escape.rb +5 -14
- data/lib/rubocop/cop/style/redundant_self.rb +2 -2
- data/lib/rubocop/cop/style/redundant_self_assignment.rb +116 -0
- data/lib/rubocop/cop/style/regexp_literal.rb +10 -21
- data/lib/rubocop/cop/style/rescue_modifier.rb +29 -9
- data/lib/rubocop/cop/style/return_nil.rb +5 -5
- data/lib/rubocop/cop/style/safe_navigation.rb +13 -12
- data/lib/rubocop/cop/style/sample.rb +10 -13
- data/lib/rubocop/cop/style/self_assignment.rb +26 -22
- data/lib/rubocop/cop/style/semicolon.rb +6 -9
- data/lib/rubocop/cop/style/send.rb +2 -2
- data/lib/rubocop/cop/style/signal_exception.rb +21 -19
- data/lib/rubocop/cop/style/single_line_block_params.rb +4 -2
- data/lib/rubocop/cop/style/single_line_methods.rb +17 -16
- data/lib/rubocop/cop/style/slicing_with_range.rb +4 -7
- data/lib/rubocop/cop/style/sole_nested_conditional.rb +66 -0
- data/lib/rubocop/cop/style/special_global_vars.rb +10 -15
- data/lib/rubocop/cop/style/stabby_lambda_parentheses.rb +17 -21
- data/lib/rubocop/cop/style/stderr_puts.rb +4 -6
- data/lib/rubocop/cop/style/string_hash_keys.rb +6 -7
- data/lib/rubocop/cop/style/string_methods.rb +7 -17
- data/lib/rubocop/cop/style/strip.rb +8 -14
- data/lib/rubocop/cop/style/struct_inheritance.rb +3 -6
- data/lib/rubocop/cop/style/symbol_array.rb +5 -16
- data/lib/rubocop/cop/style/symbol_literal.rb +4 -6
- data/lib/rubocop/cop/style/symbol_proc.rb +14 -18
- data/lib/rubocop/cop/style/ternary_parentheses.rb +21 -20
- data/lib/rubocop/cop/style/trailing_body_on_class.rb +3 -6
- data/lib/rubocop/cop/style/trailing_body_on_method_definition.rb +4 -7
- data/lib/rubocop/cop/style/trailing_body_on_module.rb +3 -6
- data/lib/rubocop/cop/style/trailing_comma_in_arguments.rb +2 -5
- data/lib/rubocop/cop/style/trailing_comma_in_array_literal.rb +2 -5
- data/lib/rubocop/cop/style/trailing_comma_in_block_args.rb +7 -6
- data/lib/rubocop/cop/style/trailing_comma_in_hash_literal.rb +2 -5
- data/lib/rubocop/cop/style/trailing_underscore_variable.rb +8 -17
- data/lib/rubocop/cop/style/trivial_accessors.rb +26 -30
- data/lib/rubocop/cop/style/unless_else.rb +5 -8
- data/lib/rubocop/cop/style/unpack_first.rb +4 -8
- data/lib/rubocop/cop/style/variable_interpolation.rb +7 -10
- data/lib/rubocop/cop/style/when_then.rb +4 -6
- data/lib/rubocop/cop/style/while_until_do.rb +6 -16
- data/lib/rubocop/cop/style/while_until_modifier.rb +6 -20
- data/lib/rubocop/cop/style/word_array.rb +5 -23
- data/lib/rubocop/cop/style/yoda_condition.rb +4 -15
- data/lib/rubocop/cop/style/zero_length_predicate.rb +11 -13
- data/lib/rubocop/cop/team.rb +1 -0
- data/lib/rubocop/cop/util.rb +1 -1
- data/lib/rubocop/cop/utils/format_string.rb +3 -5
- data/lib/rubocop/cop/variable_force.rb +2 -0
- data/lib/rubocop/cops_documentation_generator.rb +4 -2
- data/lib/rubocop/core_ext/string.rb +1 -1
- data/lib/rubocop/ext/regexp_node.rb +46 -0
- data/lib/rubocop/file_finder.rb +1 -0
- data/lib/rubocop/formatter/auto_gen_config_formatter.rb +2 -1
- data/lib/rubocop/formatter/html_formatter.rb +2 -0
- data/lib/rubocop/formatter/progress_formatter.rb +2 -1
- data/lib/rubocop/formatter/quiet_formatter.rb +1 -1
- data/lib/rubocop/formatter/simple_text_formatter.rb +36 -6
- data/lib/rubocop/name_similarity.rb +1 -0
- data/lib/rubocop/options.rb +3 -0
- data/lib/rubocop/remote_config.rb +1 -0
- data/lib/rubocop/result_cache.rb +1 -0
- data/lib/rubocop/rspec/cop_helper.rb +4 -1
- data/lib/rubocop/rspec/expect_offense.rb +10 -5
- data/lib/rubocop/rspec/shared_contexts.rb +12 -0
- data/lib/rubocop/runner.rb +1 -0
- data/lib/rubocop/string_interpreter.rb +3 -0
- data/lib/rubocop/target_finder.rb +1 -0
- data/lib/rubocop/target_ruby.rb +6 -0
- data/lib/rubocop/version.rb +2 -1
- data/lib/rubocop/yaml_duplication_checker.rb +1 -0
- metadata +15 -2
@@ -13,8 +13,9 @@ module RuboCop
|
|
13
13
|
# # good
|
14
14
|
# x = !something
|
15
15
|
#
|
16
|
-
class Not <
|
16
|
+
class Not < Base
|
17
17
|
include RangeHelp
|
18
|
+
extend AutoCorrector
|
18
19
|
|
19
20
|
MSG = 'Use `!` instead of `not`.'
|
20
21
|
|
@@ -30,19 +31,16 @@ module RuboCop
|
|
30
31
|
def on_send(node)
|
31
32
|
return unless node.prefix_not?
|
32
33
|
|
33
|
-
add_offense(node
|
34
|
-
|
35
|
-
|
36
|
-
def autocorrect(node)
|
37
|
-
range = range_with_surrounding_space(range: node.loc.selector,
|
38
|
-
side: :right)
|
34
|
+
add_offense(node.loc.selector) do |corrector|
|
35
|
+
range = range_with_surrounding_space(range: node.loc.selector, side: :right)
|
39
36
|
|
40
|
-
|
41
|
-
|
42
|
-
|
43
|
-
|
44
|
-
|
45
|
-
|
37
|
+
if opposite_method?(node.receiver)
|
38
|
+
correct_opposite_method(corrector, range, node.receiver)
|
39
|
+
elsif requires_parens?(node.receiver)
|
40
|
+
correct_with_parens(corrector, range, node)
|
41
|
+
else
|
42
|
+
correct_without_parens(corrector, range)
|
43
|
+
end
|
46
44
|
end
|
47
45
|
end
|
48
46
|
|
@@ -58,23 +56,18 @@ module RuboCop
|
|
58
56
|
child.if_type? && child.ternary?
|
59
57
|
end
|
60
58
|
|
61
|
-
def correct_opposite_method(range, child)
|
62
|
-
|
63
|
-
|
64
|
-
corrector.replace(child.loc.selector,
|
65
|
-
OPPOSITE_METHODS[child.method_name].to_s)
|
66
|
-
end
|
59
|
+
def correct_opposite_method(corrector, range, child)
|
60
|
+
corrector.remove(range)
|
61
|
+
corrector.replace(child.loc.selector, OPPOSITE_METHODS[child.method_name].to_s)
|
67
62
|
end
|
68
63
|
|
69
|
-
def correct_with_parens(range, node)
|
70
|
-
|
71
|
-
|
72
|
-
corrector.insert_after(node, ')')
|
73
|
-
end
|
64
|
+
def correct_with_parens(corrector, range, node)
|
65
|
+
corrector.replace(range, '!(')
|
66
|
+
corrector.insert_after(node, ')')
|
74
67
|
end
|
75
68
|
|
76
|
-
def correct_without_parens(range)
|
77
|
-
|
69
|
+
def correct_without_parens(corrector, range)
|
70
|
+
corrector.replace(range, '!')
|
78
71
|
end
|
79
72
|
end
|
80
73
|
end
|
@@ -33,8 +33,9 @@ module RuboCop
|
|
33
33
|
#
|
34
34
|
# # good
|
35
35
|
# num = 01234
|
36
|
-
class NumericLiteralPrefix <
|
36
|
+
class NumericLiteralPrefix < Base
|
37
37
|
include IntegerNode
|
38
|
+
extend AutoCorrector
|
38
39
|
|
39
40
|
OCTAL_ZERO_ONLY_REGEX = /^0[Oo][0-7]+$/.freeze
|
40
41
|
OCTAL_REGEX = /^0O?[0-7]+$/.freeze
|
@@ -53,14 +54,8 @@ module RuboCop
|
|
53
54
|
|
54
55
|
return unless type
|
55
56
|
|
56
|
-
add_offense(node)
|
57
|
-
|
58
|
-
|
59
|
-
def autocorrect(node)
|
60
|
-
lambda do |corrector|
|
61
|
-
type = literal_type(node)
|
62
|
-
corrector.replace(node,
|
63
|
-
send(:"format_#{type}", node.source))
|
57
|
+
add_offense(node) do |corrector|
|
58
|
+
corrector.replace(node, send(:"format_#{type}", node.source))
|
64
59
|
end
|
65
60
|
end
|
66
61
|
|
@@ -41,9 +41,10 @@ module RuboCop
|
|
41
41
|
# foo == 0
|
42
42
|
# 0 > foo
|
43
43
|
# bar.baz > 0
|
44
|
-
class NumericPredicate <
|
44
|
+
class NumericPredicate < Base
|
45
45
|
include ConfigurableEnforcedStyle
|
46
46
|
include IgnoredMethods
|
47
|
+
extend AutoCorrector
|
47
48
|
|
48
49
|
MSG = 'Use `%<prefer>s` instead of `%<current>s`.'
|
49
50
|
|
@@ -66,16 +67,8 @@ module RuboCop
|
|
66
67
|
ignored_method?(ancestor.method_name)
|
67
68
|
end
|
68
69
|
|
69
|
-
|
70
|
-
|
71
|
-
prefer: replacement,
|
72
|
-
current: node.source))
|
73
|
-
end
|
74
|
-
|
75
|
-
def autocorrect(node)
|
76
|
-
_, replacement = check(node)
|
77
|
-
|
78
|
-
lambda do |corrector|
|
70
|
+
message = format(MSG, prefer: replacement, current: node.source)
|
71
|
+
add_offense(node, message: message) do |corrector|
|
79
72
|
corrector.replace(node, replacement)
|
80
73
|
end
|
81
74
|
end
|
@@ -3,39 +3,48 @@
|
|
3
3
|
module RuboCop
|
4
4
|
module Cop
|
5
5
|
module Style
|
6
|
-
#
|
7
|
-
#
|
6
|
+
# Checks for uses of if/then/else/end constructs on a single line.
|
7
|
+
# AlwaysCorrectToMultiline config option can be set to true to auto-convert all offenses to
|
8
|
+
# multi-line constructs. When AlwaysCorrectToMultiline is false (default case) the
|
9
|
+
# auto-correct will first try converting them to ternary operators.
|
8
10
|
#
|
9
11
|
# @example
|
10
12
|
# # bad
|
11
|
-
# if foo then
|
12
|
-
#
|
13
|
+
# if foo then bar else baz end
|
14
|
+
#
|
15
|
+
# # bad
|
16
|
+
# unless foo then baz else bar end
|
13
17
|
#
|
14
18
|
# # good
|
15
|
-
# foo ?
|
16
|
-
#
|
17
|
-
#
|
19
|
+
# foo ? bar : baz
|
20
|
+
#
|
21
|
+
# # good
|
22
|
+
# bar if foo
|
23
|
+
#
|
24
|
+
# # good
|
25
|
+
# if foo then bar end
|
18
26
|
#
|
19
27
|
# # good
|
20
28
|
# if foo
|
21
|
-
#
|
29
|
+
# bar
|
22
30
|
# else
|
23
|
-
#
|
31
|
+
# baz
|
24
32
|
# end
|
25
|
-
class OneLineConditional <
|
33
|
+
class OneLineConditional < Base
|
34
|
+
include ConfigurableEnforcedStyle
|
26
35
|
include OnNormalIfUnless
|
36
|
+
extend AutoCorrector
|
27
37
|
|
28
|
-
MSG = 'Favor the ternary operator (`?:`) ' \
|
29
|
-
'over `%<keyword>s/then/else/end` constructs.'
|
38
|
+
MSG = 'Favor the ternary operator (`?:`) or multi-line constructs ' \
|
39
|
+
'over single-line `%<keyword>s/then/else/end` constructs.'
|
30
40
|
|
31
41
|
def on_normal_if_unless(node)
|
32
|
-
return unless node.single_line?
|
33
|
-
|
34
|
-
|
35
|
-
end
|
42
|
+
return unless node.single_line?
|
43
|
+
return unless node.else_branch
|
44
|
+
return if node.elsif?
|
36
45
|
|
37
|
-
|
38
|
-
|
46
|
+
message = message(node)
|
47
|
+
add_offense(node, message: message) do |corrector|
|
39
48
|
corrector.replace(node, replacement(node))
|
40
49
|
end
|
41
50
|
end
|
@@ -47,16 +56,55 @@ module RuboCop
|
|
47
56
|
end
|
48
57
|
|
49
58
|
def replacement(node)
|
50
|
-
|
59
|
+
if always_multiline? || cannot_replace_to_ternary?(node)
|
60
|
+
multiline_replacement(node)
|
61
|
+
else
|
62
|
+
replaced_node = ternary_replacement(node)
|
63
|
+
return replaced_node unless node.parent
|
64
|
+
return "(#{replaced_node})" if %i[and or].include?(node.parent.type)
|
65
|
+
return "(#{replaced_node})" if node.parent.send_type? && node.parent.operator_method?
|
66
|
+
|
67
|
+
replaced_node
|
68
|
+
end
|
69
|
+
end
|
70
|
+
|
71
|
+
def always_multiline?
|
72
|
+
@config.for_cop('Style/OneLineConditional')['AlwaysCorrectToMultiline']
|
73
|
+
end
|
74
|
+
|
75
|
+
def cannot_replace_to_ternary?(node)
|
76
|
+
node.elsif_conditional?
|
77
|
+
end
|
51
78
|
|
52
|
-
|
79
|
+
def multiline_replacement(node, indentation = nil)
|
80
|
+
indentation = ' ' * node.source_range.column if indentation.nil?
|
81
|
+
if_branch_source = node.if_branch&.source || 'nil'
|
82
|
+
elsif_indentation = indentation if node.respond_to?(:elsif?) && node.elsif?
|
83
|
+
if_branch = <<~RUBY
|
84
|
+
#{elsif_indentation}#{node.keyword} #{node.condition.source}
|
85
|
+
#{indentation}#{branch_body_indentation}#{if_branch_source}
|
86
|
+
RUBY
|
87
|
+
else_branch = else_branch_to_multiline(node.else_branch, indentation)
|
88
|
+
if_branch + else_branch
|
89
|
+
end
|
53
90
|
|
54
|
-
|
91
|
+
def else_branch_to_multiline(else_branch, indentation)
|
92
|
+
if else_branch.if_type? && else_branch.elsif?
|
93
|
+
multiline_replacement(else_branch, indentation)
|
94
|
+
else
|
95
|
+
<<~RUBY.chomp
|
96
|
+
#{indentation}else
|
97
|
+
#{indentation}#{branch_body_indentation}#{else_branch.source}
|
98
|
+
#{indentation}end
|
99
|
+
RUBY
|
100
|
+
end
|
101
|
+
end
|
55
102
|
|
56
|
-
|
103
|
+
def branch_body_indentation
|
104
|
+
' ' * (@config.for_cop('Layout/IndentationWidth')['Width'] || 2)
|
57
105
|
end
|
58
106
|
|
59
|
-
def
|
107
|
+
def ternary_replacement(node)
|
60
108
|
condition, if_branch, else_branch = *node
|
61
109
|
|
62
110
|
"#{expr_replacement(condition)} ? " \
|
@@ -26,7 +26,9 @@ module RuboCop
|
|
26
26
|
#
|
27
27
|
# # good - set name to 'Bozhidar', only if it's nil or false
|
28
28
|
# name ||= 'Bozhidar'
|
29
|
-
class OrAssignment <
|
29
|
+
class OrAssignment < Base
|
30
|
+
extend AutoCorrector
|
31
|
+
|
30
32
|
MSG = 'Use the double pipe equals operator `||=` instead.'
|
31
33
|
|
32
34
|
def_node_matcher :ternary_assignment?, <<~PATTERN
|
@@ -47,35 +49,36 @@ module RuboCop
|
|
47
49
|
def on_if(node)
|
48
50
|
return unless unless_assignment?(node)
|
49
51
|
|
50
|
-
add_offense(node)
|
52
|
+
add_offense(node) do |corrector|
|
53
|
+
autocorrect(corrector, node)
|
54
|
+
end
|
51
55
|
end
|
52
56
|
|
53
57
|
def on_lvasgn(node)
|
54
58
|
return unless (else_branch = ternary_assignment?(node))
|
55
59
|
return if else_branch.if_type?
|
56
60
|
|
57
|
-
add_offense(node)
|
61
|
+
add_offense(node) do |corrector|
|
62
|
+
autocorrect(corrector, node)
|
63
|
+
end
|
58
64
|
end
|
59
65
|
|
60
66
|
alias on_ivasgn on_lvasgn
|
61
67
|
alias on_cvasgn on_lvasgn
|
62
68
|
alias on_gvasgn on_lvasgn
|
63
69
|
|
64
|
-
|
70
|
+
private
|
71
|
+
|
72
|
+
def autocorrect(corrector, node)
|
65
73
|
if ternary_assignment?(node)
|
66
74
|
variable, default = take_variable_and_default_from_ternary(node)
|
67
75
|
else
|
68
76
|
variable, default = take_variable_and_default_from_unless(node)
|
69
77
|
end
|
70
78
|
|
71
|
-
|
72
|
-
corrector.replace(node,
|
73
|
-
"#{variable} ||= #{default.source}")
|
74
|
-
end
|
79
|
+
corrector.replace(node, "#{variable} ||= #{default.source}")
|
75
80
|
end
|
76
81
|
|
77
|
-
private
|
78
|
-
|
79
82
|
def take_variable_and_default_from_ternary(node)
|
80
83
|
variable, if_statement = *node
|
81
84
|
[variable, if_statement.else_branch]
|
@@ -22,8 +22,9 @@ module RuboCop
|
|
22
22
|
# a = 1
|
23
23
|
# b = 2
|
24
24
|
# c = 3
|
25
|
-
class ParallelAssignment <
|
25
|
+
class ParallelAssignment < Base
|
26
26
|
include RescueNode
|
27
|
+
extend AutoCorrector
|
27
28
|
|
28
29
|
MSG = 'Do not use parallel assignment.'
|
29
30
|
|
@@ -35,24 +36,23 @@ module RuboCop
|
|
35
36
|
return if allowed_lhs?(lhs) || allowed_rhs?(rhs) ||
|
36
37
|
allowed_masign?(lhs_elements, rhs_elements)
|
37
38
|
|
38
|
-
add_offense(node)
|
39
|
-
|
40
|
-
|
41
|
-
def autocorrect(node)
|
42
|
-
lambda do |corrector|
|
43
|
-
left, right = *node
|
44
|
-
left_elements = *left
|
45
|
-
right_elements = Array(right).compact
|
46
|
-
order = find_valid_order(left_elements, right_elements)
|
47
|
-
correction = assignment_corrector(node, order)
|
48
|
-
|
49
|
-
corrector.replace(correction.correction_range,
|
50
|
-
correction.correction)
|
39
|
+
add_offense(node) do |corrector|
|
40
|
+
autocorrect(corrector, node)
|
51
41
|
end
|
52
42
|
end
|
53
43
|
|
54
44
|
private
|
55
45
|
|
46
|
+
def autocorrect(corrector, node)
|
47
|
+
left, right = *node
|
48
|
+
left_elements = *left
|
49
|
+
right_elements = Array(right).compact
|
50
|
+
order = find_valid_order(left_elements, right_elements)
|
51
|
+
correction = assignment_corrector(node, order)
|
52
|
+
|
53
|
+
corrector.replace(correction.correction_range, correction.correction)
|
54
|
+
end
|
55
|
+
|
56
56
|
def allowed_masign?(lhs_elements, rhs_elements)
|
57
57
|
lhs_elements.size != rhs_elements.size ||
|
58
58
|
!find_valid_order(lhs_elements,
|
@@ -53,9 +53,10 @@ module RuboCop
|
|
53
53
|
# y > 10)
|
54
54
|
# end
|
55
55
|
#
|
56
|
-
class ParenthesesAroundCondition <
|
56
|
+
class ParenthesesAroundCondition < Base
|
57
57
|
include SafeAssignment
|
58
58
|
include Parentheses
|
59
|
+
extend AutoCorrector
|
59
60
|
|
60
61
|
def on_if(node)
|
61
62
|
return if node.ternary?
|
@@ -68,10 +69,6 @@ module RuboCop
|
|
68
69
|
end
|
69
70
|
alias on_until on_while
|
70
71
|
|
71
|
-
def autocorrect(node)
|
72
|
-
ParenthesesCorrector.correct(node)
|
73
|
-
end
|
74
|
-
|
75
72
|
private
|
76
73
|
|
77
74
|
def_node_matcher :control_op_condition, <<~PATTERN
|
@@ -85,7 +82,10 @@ module RuboCop
|
|
85
82
|
return if modifier_op?(first_child)
|
86
83
|
return if parens_allowed?(cond)
|
87
84
|
|
88
|
-
|
85
|
+
message = message(cond)
|
86
|
+
add_offense(cond, message: message) do |corrector|
|
87
|
+
ParenthesesCorrector.correct(corrector, cond)
|
88
|
+
end
|
89
89
|
end
|
90
90
|
end
|
91
91
|
|
@@ -23,8 +23,9 @@ module RuboCop
|
|
23
23
|
#
|
24
24
|
# # bad
|
25
25
|
# %I(alpha beta)
|
26
|
-
class PercentLiteralDelimiters <
|
26
|
+
class PercentLiteralDelimiters < Base
|
27
27
|
include PercentLiteral
|
28
|
+
extend AutoCorrector
|
28
29
|
|
29
30
|
def on_array(node)
|
30
31
|
process(node, '%w', '%W', '%i', '%I')
|
@@ -47,34 +48,27 @@ module RuboCop
|
|
47
48
|
process(node, '%x')
|
48
49
|
end
|
49
50
|
|
50
|
-
|
51
|
-
type = type(node)
|
52
|
-
delimiters = preferred_delimiters_for(type)
|
53
|
-
|
54
|
-
"`#{type}`-literals should be delimited by " \
|
55
|
-
"`#{delimiters[0]}` and `#{delimiters[1]}`."
|
56
|
-
end
|
51
|
+
private
|
57
52
|
|
58
|
-
def
|
53
|
+
def on_percent_literal(node)
|
59
54
|
type = type(node)
|
55
|
+
return if uses_preferred_delimiter?(node, type) ||
|
56
|
+
contains_preferred_delimiter?(node, type) ||
|
57
|
+
include_same_character_as_used_for_delimiter?(node, type)
|
60
58
|
|
61
|
-
|
59
|
+
add_offense(node, message: message(type)) do |corrector|
|
60
|
+
opening_delimiter, closing_delimiter = preferred_delimiters_for(type)
|
62
61
|
|
63
|
-
lambda do |corrector|
|
64
62
|
corrector.replace(node.loc.begin, "#{type}#{opening_delimiter}")
|
65
63
|
corrector.replace(node.loc.end, closing_delimiter)
|
66
64
|
end
|
67
65
|
end
|
68
66
|
|
69
|
-
|
70
|
-
|
71
|
-
def on_percent_literal(node)
|
72
|
-
type = type(node)
|
73
|
-
return if uses_preferred_delimiter?(node, type) ||
|
74
|
-
contains_preferred_delimiter?(node, type) ||
|
75
|
-
include_same_character_as_used_for_delimiter?(node, type)
|
67
|
+
def message(type)
|
68
|
+
delimiters = preferred_delimiters_for(type)
|
76
69
|
|
77
|
-
|
70
|
+
"`#{type}`-literals should be delimited by " \
|
71
|
+
"`#{delimiters[0]}` and `#{delimiters[1]}`."
|
78
72
|
end
|
79
73
|
|
80
74
|
def preferred_delimiters_for(type)
|