rubocop 0.87.1 → 0.91.0

data/lib/rubocop/yaml_duplication_checker.rb

@@ -2,6 +2,7 @@
 
 module RuboCop
   # Find duplicated keys from YAML.
+  # @api private
   module YAMLDuplicationChecker
     def self.check(yaml_string, filename, &on_duplicated)
       # Ruby 2.6+

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop
 version: !ruby/object:Gem::Version
-  version: 0.87.1
+  version: 0.91.0
 platform: ruby
 authors:
 - Bozhidar Batsov
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-07-07 00:00:00.000000000 Z
+date: 2020-09-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: parallel
@@ -94,7 +94,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.1.0
+        version: 0.4.0
     - - "<"
       - !ruby/object:Gem::Version
         version: '1.0'
@@ -104,7 +104,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.1.0
+        version: 0.4.0
     - - "<"
       - !ruby/object:Gem::Version
         version: '1.0'
@@ -178,6 +178,7 @@ files:
 - assets/logo.png
 - assets/output.html.erb
 - bin/console
+- bin/rubocop-profile
 - bin/setup
 - config/default.yml
 - exe/rubocop
@@ -225,6 +226,7 @@ files:
 - lib/rubocop/cop/correctors/space_corrector.rb
 - lib/rubocop/cop/correctors/string_literal_corrector.rb
 - lib/rubocop/cop/correctors/unused_arg_corrector.rb
+- lib/rubocop/cop/documentation.rb
 - lib/rubocop/cop/force.rb
 - lib/rubocop/cop/gemspec/duplicated_assignment.rb
 - lib/rubocop/cop/gemspec/ordered_dependencies.rb
@@ -246,6 +248,7 @@ files:
 - lib/rubocop/cop/layout/argument_alignment.rb
 - lib/rubocop/cop/layout/array_alignment.rb
 - lib/rubocop/cop/layout/assignment_indentation.rb
+- lib/rubocop/cop/layout/begin_end_alignment.rb
 - lib/rubocop/cop/layout/block_alignment.rb
 - lib/rubocop/cop/layout/block_end_newline.rb
 - lib/rubocop/cop/layout/case_indentation.rb
@@ -260,6 +263,7 @@ files:
 - lib/rubocop/cop/layout/empty_comment.rb
 - lib/rubocop/cop/layout/empty_line_after_guard_clause.rb
 - lib/rubocop/cop/layout/empty_line_after_magic_comment.rb
+- lib/rubocop/cop/layout/empty_line_after_multiline_condition.rb
 - lib/rubocop/cop/layout/empty_line_between_defs.rb
 - lib/rubocop/cop/layout/empty_lines.rb
 - lib/rubocop/cop/layout/empty_lines_around_access_modifier.rb
@@ -339,28 +343,37 @@ files:
 - lib/rubocop/cop/lint/ambiguous_regexp_literal.rb
 - lib/rubocop/cop/lint/assignment_in_condition.rb
 - lib/rubocop/cop/lint/big_decimal_new.rb
+- lib/rubocop/cop/lint/binary_operator_with_identical_operands.rb
 - lib/rubocop/cop/lint/boolean_symbol.rb
 - lib/rubocop/cop/lint/circular_argument_reference.rb
+- lib/rubocop/cop/lint/constant_definition_in_block.rb
 - lib/rubocop/cop/lint/constant_resolution.rb
 - lib/rubocop/cop/lint/debugger.rb
 - lib/rubocop/cop/lint/deprecated_class_methods.rb
 - lib/rubocop/cop/lint/deprecated_open_ssl_constant.rb
 - lib/rubocop/cop/lint/disjunctive_assignment_in_constructor.rb
 - lib/rubocop/cop/lint/duplicate_case_condition.rb
+- lib/rubocop/cop/lint/duplicate_elsif_condition.rb
 - lib/rubocop/cop/lint/duplicate_hash_key.rb
 - lib/rubocop/cop/lint/duplicate_methods.rb
+- lib/rubocop/cop/lint/duplicate_require.rb
+- lib/rubocop/cop/lint/duplicate_rescue_exception.rb
 - lib/rubocop/cop/lint/each_with_object_argument.rb
 - lib/rubocop/cop/lint/else_layout.rb
+- lib/rubocop/cop/lint/empty_conditional_body.rb
 - lib/rubocop/cop/lint/empty_ensure.rb
 - lib/rubocop/cop/lint/empty_expression.rb
+- lib/rubocop/cop/lint/empty_file.rb
 - lib/rubocop/cop/lint/empty_interpolation.rb
 - lib/rubocop/cop/lint/empty_when.rb
 - lib/rubocop/cop/lint/ensure_return.rb
 - lib/rubocop/cop/lint/erb_new_arguments.rb
 - lib/rubocop/cop/lint/flip_flop.rb
+- lib/rubocop/cop/lint/float_comparison.rb
 - lib/rubocop/cop/lint/float_out_of_range.rb
 - lib/rubocop/cop/lint/format_parameter_mismatch.rb
 - lib/rubocop/cop/lint/heredoc_method_call_position.rb
+- lib/rubocop/cop/lint/identity_comparison.rb
 - lib/rubocop/cop/lint/implicit_string_concatenation.rb
 - lib/rubocop/cop/lint/ineffective_access_modifier.rb
 - lib/rubocop/cop/lint/inherit_exception.rb
@@ -369,6 +382,7 @@ files:
 - lib/rubocop/cop/lint/literal_in_interpolation.rb
 - lib/rubocop/cop/lint/loop.rb
 - lib/rubocop/cop/lint/missing_cop_enable_directive.rb
+- lib/rubocop/cop/lint/missing_super.rb
 - lib/rubocop/cop/lint/mixed_regexp_capture_types.rb
 - lib/rubocop/cop/lint/multiple_comparison.rb
 - lib/rubocop/cop/lint/nested_method_definition.rb
@@ -378,6 +392,7 @@ files:
 - lib/rubocop/cop/lint/non_local_exit_from_iterator.rb
 - lib/rubocop/cop/lint/number_conversion.rb
 - lib/rubocop/cop/lint/ordered_magic_comments.rb
+- lib/rubocop/cop/lint/out_of_range_regexp_ref.rb
 - lib/rubocop/cop/lint/parentheses_as_grouped_expression.rb
 - lib/rubocop/cop/lint/percent_string_array.rb
 - lib/rubocop/cop/lint/percent_symbol_array.rb
@@ -399,6 +414,7 @@ files:
 - lib/rubocop/cop/lint/safe_navigation_consistency.rb
 - lib/rubocop/cop/lint/safe_navigation_with_empty.rb
 - lib/rubocop/cop/lint/script_permission.rb
+- lib/rubocop/cop/lint/self_assignment.rb
 - lib/rubocop/cop/lint/send_with_mixin_argument.rb
 - lib/rubocop/cop/lint/shadowed_argument.rb
 - lib/rubocop/cop/lint/shadowed_exception.rb
@@ -407,18 +423,22 @@ files:
 - lib/rubocop/cop/lint/suppressed_exception.rb
 - lib/rubocop/cop/lint/syntax.rb
 - lib/rubocop/cop/lint/to_json.rb
+- lib/rubocop/cop/lint/top_level_return_with_argument.rb
+- lib/rubocop/cop/lint/trailing_comma_in_attribute_declaration.rb
 - lib/rubocop/cop/lint/underscore_prefixed_variable_name.rb
 - lib/rubocop/cop/lint/unified_integer.rb
 - lib/rubocop/cop/lint/unreachable_code.rb
+- lib/rubocop/cop/lint/unreachable_loop.rb
 - lib/rubocop/cop/lint/unused_block_argument.rb
 - lib/rubocop/cop/lint/unused_method_argument.rb
 - lib/rubocop/cop/lint/uri_escape_unescape.rb
 - lib/rubocop/cop/lint/uri_regexp.rb
 - lib/rubocop/cop/lint/useless_access_modifier.rb
 - lib/rubocop/cop/lint/useless_assignment.rb
-- lib/rubocop/cop/lint/useless_comparison.rb
 - lib/rubocop/cop/lint/useless_else_without_rescue.rb
+- lib/rubocop/cop/lint/useless_method_definition.rb
 - lib/rubocop/cop/lint/useless_setter_call.rb
+- lib/rubocop/cop/lint/useless_times.rb
 - lib/rubocop/cop/lint/void.rb
 - lib/rubocop/cop/message_annotator.rb
 - lib/rubocop/cop/metrics/abc_size.rb
@@ -433,6 +453,7 @@ files:
 - lib/rubocop/cop/metrics/utils/abc_size_calculator.rb
 - lib/rubocop/cop/metrics/utils/code_length_calculator.rb
 - lib/rubocop/cop/metrics/utils/iterating_block.rb
+- lib/rubocop/cop/metrics/utils/repeated_csend_discount.rb
 - lib/rubocop/cop/migration/department_name.rb
 - lib/rubocop/cop/mixin/alignment.rb
 - lib/rubocop/cop/mixin/allowed_methods.rb
@@ -443,6 +464,7 @@ files:
 - lib/rubocop/cop/mixin/check_assignment.rb
 - lib/rubocop/cop/mixin/check_line_breakable.rb
 - lib/rubocop/cop/mixin/code_length.rb
+- lib/rubocop/cop/mixin/comments_help.rb
 - lib/rubocop/cop/mixin/configurable_enforced_style.rb
 - lib/rubocop/cop/mixin/configurable_formatting.rb
 - lib/rubocop/cop/mixin/configurable_max.rb
@@ -478,7 +500,6 @@ files:
 - lib/rubocop/cop/mixin/on_normal_if_unless.rb
 - lib/rubocop/cop/mixin/ordered_gem_node.rb
 - lib/rubocop/cop/mixin/parentheses.rb
-- lib/rubocop/cop/mixin/parser_diagnostic.rb
 - lib/rubocop/cop/mixin/percent_array.rb
 - lib/rubocop/cop/mixin/percent_literal.rb
 - lib/rubocop/cop/mixin/preceding_following_alignment.rb
@@ -495,7 +516,6 @@ files:
 - lib/rubocop/cop/mixin/string_literals_help.rb
 - lib/rubocop/cop/mixin/surrounding_space.rb
 - lib/rubocop/cop/mixin/target_ruby_version.rb
-- lib/rubocop/cop/mixin/too_many_lines.rb
 - lib/rubocop/cop/mixin/trailing_body.rb
 - lib/rubocop/cop/mixin/trailing_comma.rb
 - lib/rubocop/cop/mixin/uncommunicative_name.rb
@@ -529,6 +549,7 @@ files:
 - lib/rubocop/cop/style/accessor_grouping.rb
 - lib/rubocop/cop/style/alias.rb
 - lib/rubocop/cop/style/and_or.rb
+- lib/rubocop/cop/style/array_coercion.rb
 - lib/rubocop/cop/style/array_join.rb
 - lib/rubocop/cop/style/ascii_comments.rb
 - lib/rubocop/cop/style/attr.rb
@@ -539,14 +560,17 @@ files:
 - lib/rubocop/cop/style/block_comments.rb
 - lib/rubocop/cop/style/block_delimiters.rb
 - lib/rubocop/cop/style/case_equality.rb
+- lib/rubocop/cop/style/case_like_if.rb
 - lib/rubocop/cop/style/character_literal.rb
 - lib/rubocop/cop/style/class_and_module_children.rb
 - lib/rubocop/cop/style/class_check.rb
 - lib/rubocop/cop/style/class_methods.rb
+- lib/rubocop/cop/style/class_methods_definitions.rb
 - lib/rubocop/cop/style/class_vars.rb
 - lib/rubocop/cop/style/collection_methods.rb
 - lib/rubocop/cop/style/colon_method_call.rb
 - lib/rubocop/cop/style/colon_method_definition.rb
+- lib/rubocop/cop/style/combinable_loops.rb
 - lib/rubocop/cop/style/command_literal.rb
 - lib/rubocop/cop/style/comment_annotation.rb
 - lib/rubocop/cop/style/commented_keyword.rb
@@ -574,15 +598,19 @@ files:
 - lib/rubocop/cop/style/eval_with_location.rb
 - lib/rubocop/cop/style/even_odd.rb
 - lib/rubocop/cop/style/expand_path_arguments.rb
+- lib/rubocop/cop/style/explicit_block_argument.rb
 - lib/rubocop/cop/style/exponential_notation.rb
 - lib/rubocop/cop/style/float_division.rb
 - lib/rubocop/cop/style/for.rb
 - lib/rubocop/cop/style/format_string.rb
 - lib/rubocop/cop/style/format_string_token.rb
 - lib/rubocop/cop/style/frozen_string_literal_comment.rb
+- lib/rubocop/cop/style/global_std_stream.rb
 - lib/rubocop/cop/style/global_vars.rb
 - lib/rubocop/cop/style/guard_clause.rb
+- lib/rubocop/cop/style/hash_as_last_array_item.rb
 - lib/rubocop/cop/style/hash_each_methods.rb
+- lib/rubocop/cop/style/hash_like_case.rb
 - lib/rubocop/cop/style/hash_syntax.rb
 - lib/rubocop/cop/style/hash_transform_keys.rb
 - lib/rubocop/cop/style/hash_transform_values.rb
@@ -596,6 +624,7 @@ files:
 - lib/rubocop/cop/style/inline_comment.rb
 - lib/rubocop/cop/style/inverse_methods.rb
 - lib/rubocop/cop/style/ip_addresses.rb
+- lib/rubocop/cop/style/keyword_parameters_order.rb
 - lib/rubocop/cop/style/lambda.rb
 - lib/rubocop/cop/style/lambda_call.rb
 - lib/rubocop/cop/style/line_end_concatenation.rb
@@ -605,7 +634,6 @@ files:
 - lib/rubocop/cop/style/method_call_without_args_parentheses.rb
 - lib/rubocop/cop/style/method_called_on_do_end_block.rb
 - lib/rubocop/cop/style/method_def_parentheses.rb
-- lib/rubocop/cop/style/method_missing_super.rb
 - lib/rubocop/cop/style/min_max.rb
 - lib/rubocop/cop/style/missing_else.rb
 - lib/rubocop/cop/style/missing_respond_to_missing.rb
@@ -637,6 +665,7 @@ files:
 - lib/rubocop/cop/style/one_line_conditional.rb
 - lib/rubocop/cop/style/option_hash.rb
 - lib/rubocop/cop/style/optional_arguments.rb
+- lib/rubocop/cop/style/optional_boolean_parameter.rb
 - lib/rubocop/cop/style/or_assignment.rb
 - lib/rubocop/cop/style/parallel_assignment.rb
 - lib/rubocop/cop/style/parentheses_around_condition.rb
@@ -654,6 +683,7 @@ files:
 - lib/rubocop/cop/style/redundant_conditional.rb
 - lib/rubocop/cop/style/redundant_exception.rb
 - lib/rubocop/cop/style/redundant_fetch_block.rb
+- lib/rubocop/cop/style/redundant_file_extension_in_require.rb
 - lib/rubocop/cop/style/redundant_freeze.rb
 - lib/rubocop/cop/style/redundant_interpolation.rb
 - lib/rubocop/cop/style/redundant_parentheses.rb
@@ -662,6 +692,7 @@ files:
 - lib/rubocop/cop/style/redundant_regexp_escape.rb
 - lib/rubocop/cop/style/redundant_return.rb
 - lib/rubocop/cop/style/redundant_self.rb
+- lib/rubocop/cop/style/redundant_self_assignment.rb
 - lib/rubocop/cop/style/redundant_sort.rb
 - lib/rubocop/cop/style/redundant_sort_by.rb
 - lib/rubocop/cop/style/regexp_literal.rb
@@ -674,12 +705,15 @@ files:
 - lib/rubocop/cop/style/semicolon.rb
 - lib/rubocop/cop/style/send.rb
 - lib/rubocop/cop/style/signal_exception.rb
+- lib/rubocop/cop/style/single_argument_dig.rb
 - lib/rubocop/cop/style/single_line_block_params.rb
 - lib/rubocop/cop/style/single_line_methods.rb
 - lib/rubocop/cop/style/slicing_with_range.rb
+- lib/rubocop/cop/style/sole_nested_conditional.rb
 - lib/rubocop/cop/style/special_global_vars.rb
 - lib/rubocop/cop/style/stabby_lambda_parentheses.rb
 - lib/rubocop/cop/style/stderr_puts.rb
+- lib/rubocop/cop/style/string_concatenation.rb
 - lib/rubocop/cop/style/string_hash_keys.rb
 - lib/rubocop/cop/style/string_literals.rb
 - lib/rubocop/cop/style/string_literals_in_interpolation.rb
@@ -710,6 +744,7 @@ files:
 - lib/rubocop/cop/style/yoda_condition.rb
 - lib/rubocop/cop/style/zero_length_predicate.rb
 - lib/rubocop/cop/team.rb
+- lib/rubocop/cop/tokens_util.rb
 - lib/rubocop/cop/util.rb
 - lib/rubocop/cop/utils/format_string.rb
 - lib/rubocop/cop/variable_force.rb
@@ -720,9 +755,11 @@ files:
 - lib/rubocop/cop/variable_force/scope.rb
 - lib/rubocop/cop/variable_force/variable.rb
 - lib/rubocop/cop/variable_force/variable_table.rb
+- lib/rubocop/cops_documentation_generator.rb
 - lib/rubocop/core_ext/string.rb
 - lib/rubocop/error.rb
 - lib/rubocop/ext/processed_source.rb
+- lib/rubocop/ext/regexp_node.rb
 - lib/rubocop/file_finder.rb
 - lib/rubocop/formatter/auto_gen_config_formatter.rb
 - lib/rubocop/formatter/base_formatter.rb

data/lib/rubocop/cop/lint/useless_comparison.rb

@@ -1,28 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    module Lint
-      # This cop checks for comparison of something with itself.
-      #
-      # @example
-      #
-      #   # bad
-      #
-      #   x.top >= x.top
-      class UselessComparison < Cop
-        MSG = 'Comparison of something with itself detected.'
-        OPS = %w[== === != < > <= >= <=>].freeze
-
-        def_node_matcher :useless_comparison?,
-                         "(send $_match {:#{OPS.join(' :')}} $_match)"
-
-        def on_send(node)
-          return unless useless_comparison?(node)
-
-          add_offense(node, location: :selector)
-        end
-      end
-    end
-  end
-end

data/lib/rubocop/cop/mixin/parser_diagnostic.rb

@@ -1,37 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    # Common functionality for cops which processes Parser's diagnostics.
-    # This mixin requires its user class to define `#relevant_diagnostic?`.
-    #
-    #     def relevant_diagnostic?(diagnostic)
-    #       diagnostic.reason == :my_interested_diagnostic_type
-    #     end
-    #
-    # If you want to use an alternative offense message rather than the one in
-    # Parser's diagnostic, define `#alternative_message`.
-    #
-    #     def alternative_message(diagnostic)
-    #       'My custom message'
-    #     end
-    module ParserDiagnostic
-      def investigate(processed_source)
-        processed_source.diagnostics.each do |d|
-          next unless relevant_diagnostic?(d)
-
-          message = if respond_to?(:alternative_message, true)
-                      alternative_message(d)
-                    else
-                      d.message.capitalize
-                    end
-
-          add_offense(find_offense_node_by(d),
-                      location: d.location,
-                      message: message,
-                      severity: d.level)
-        end
-      end
-    end
-  end
-end

data/lib/rubocop/cop/mixin/too_many_lines.rb

@@ -1,25 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    # Common functionality for checking for too many lines.
-    module TooManyLines
-      include ConfigurableMax
-      include CodeLength
-
-      MSG = '%<label>s has too many lines. [%<length>d/%<max>d]'
-
-      private
-
-      def message(length, max_length)
-        format(MSG, label: cop_label, length: length, max: max_length)
-      end
-
-      def code_length(node)
-        Metrics::Utils::CodeLengthCalculator.new(node,
-                                                 count_comments: count_comments?,
-                                                 foldable_types: count_as_one).calculate
-      end
-    end
-  end
-end

data/lib/rubocop/cop/style/method_missing_super.rb

@@ -1,34 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    module Style
-      # This cop checks for the presence of `method_missing` without
-      # falling back on `super`.
-      #
-      # @example
-      #   #bad
-      #   def method_missing(name, *args)
-      #     # ...
-      #   end
-      #
-      #   #good
-      #
-      #   def method_missing(name, *args)
-      #     # ...
-      #     super
-      #   end
-      class MethodMissingSuper < Cop
-        MSG = 'When using `method_missing`, fall back on `super`.'
-
-        def on_def(node)
-          return unless node.method?(:method_missing)
-          return if node.descendants.any?(&:zsuper_type?)
-
-          add_offense(node)
-        end
-        alias on_defs on_def
-      end
-    end
-  end
-end