rubocop 0.82.0 → 1.18.4

Sign up to get free protection for your applications and to get access to all the features.
Files changed (744) hide show
  1. checksums.yaml +4 -4
  2. data/LICENSE.txt +1 -1
  3. data/README.md +69 -37
  4. data/assets/output.html.erb +1 -1
  5. data/config/default.yml +1025 -139
  6. data/config/obsoletion.yml +200 -0
  7. data/exe/rubocop +2 -4
  8. data/lib/rubocop.rb +137 -68
  9. data/lib/rubocop/ast_aliases.rb +8 -0
  10. data/lib/rubocop/cached_data.rb +4 -4
  11. data/lib/rubocop/cli.rb +11 -11
  12. data/lib/rubocop/cli/command.rb +1 -0
  13. data/lib/rubocop/cli/command/auto_genenerate_config.rb +46 -19
  14. data/lib/rubocop/cli/command/base.rb +2 -0
  15. data/lib/rubocop/cli/command/execute_runner.rb +36 -12
  16. data/lib/rubocop/cli/command/init_dotfile.rb +3 -4
  17. data/lib/rubocop/cli/command/show_cops.rb +6 -12
  18. data/lib/rubocop/cli/command/suggest_extensions.rb +81 -0
  19. data/lib/rubocop/cli/command/version.rb +3 -2
  20. data/lib/rubocop/cli/environment.rb +1 -0
  21. data/lib/rubocop/comment_config.rb +54 -103
  22. data/lib/rubocop/config.rb +45 -29
  23. data/lib/rubocop/config_loader.rb +101 -106
  24. data/lib/rubocop/config_loader_resolver.rb +100 -29
  25. data/lib/rubocop/config_obsoletion.rb +67 -242
  26. data/lib/rubocop/config_obsoletion/changed_enforced_styles.rb +33 -0
  27. data/lib/rubocop/config_obsoletion/changed_parameter.rb +21 -0
  28. data/lib/rubocop/config_obsoletion/cop_rule.rb +33 -0
  29. data/lib/rubocop/config_obsoletion/extracted_cop.rb +44 -0
  30. data/lib/rubocop/config_obsoletion/parameter_rule.rb +44 -0
  31. data/lib/rubocop/config_obsoletion/removed_cop.rb +41 -0
  32. data/lib/rubocop/config_obsoletion/renamed_cop.rb +34 -0
  33. data/lib/rubocop/config_obsoletion/rule.rb +41 -0
  34. data/lib/rubocop/config_obsoletion/split_cop.rb +27 -0
  35. data/lib/rubocop/config_regeneration.rb +33 -0
  36. data/lib/rubocop/config_store.rb +31 -7
  37. data/lib/rubocop/config_validator.rb +53 -28
  38. data/lib/rubocop/cop/autocorrect_logic.rb +37 -38
  39. data/lib/rubocop/cop/badge.rb +11 -27
  40. data/lib/rubocop/cop/base.rb +450 -0
  41. data/lib/rubocop/cop/bundler/duplicated_gem.rb +31 -7
  42. data/lib/rubocop/cop/bundler/gem_comment.rb +117 -10
  43. data/lib/rubocop/cop/bundler/gem_version.rb +133 -0
  44. data/lib/rubocop/cop/bundler/insecure_protocol_source.rb +13 -20
  45. data/lib/rubocop/cop/bundler/ordered_gems.rb +2 -4
  46. data/lib/rubocop/cop/commissioner.rb +98 -74
  47. data/lib/rubocop/cop/cop.rb +84 -234
  48. data/lib/rubocop/cop/corrector.rb +41 -119
  49. data/lib/rubocop/cop/correctors/alignment_corrector.rb +11 -21
  50. data/lib/rubocop/cop/correctors/condition_corrector.rb +3 -5
  51. data/lib/rubocop/cop/correctors/each_to_for_corrector.rb +2 -4
  52. data/lib/rubocop/cop/correctors/empty_line_corrector.rb +9 -10
  53. data/lib/rubocop/cop/correctors/for_to_each_corrector.rb +1 -2
  54. data/lib/rubocop/cop/correctors/lambda_literal_to_method_corrector.rb +1 -1
  55. data/lib/rubocop/cop/correctors/line_break_corrector.rb +8 -11
  56. data/lib/rubocop/cop/correctors/multiline_literal_brace_corrector.rb +35 -6
  57. data/lib/rubocop/cop/correctors/ordered_gem_corrector.rb +1 -3
  58. data/lib/rubocop/cop/correctors/parentheses_corrector.rb +5 -8
  59. data/lib/rubocop/cop/correctors/percent_literal_corrector.rb +10 -21
  60. data/lib/rubocop/cop/correctors/punctuation_corrector.rb +8 -10
  61. data/lib/rubocop/cop/correctors/space_corrector.rb +1 -3
  62. data/lib/rubocop/cop/correctors/string_literal_corrector.rb +6 -8
  63. data/lib/rubocop/cop/correctors/unused_arg_corrector.rb +15 -18
  64. data/lib/rubocop/cop/documentation.rb +22 -0
  65. data/lib/rubocop/cop/exclude_limit.rb +26 -0
  66. data/lib/rubocop/cop/force.rb +2 -1
  67. data/lib/rubocop/cop/gemspec/date_assignment.rb +57 -0
  68. data/lib/rubocop/cop/gemspec/duplicated_assignment.rb +6 -5
  69. data/lib/rubocop/cop/gemspec/ordered_dependencies.rb +3 -7
  70. data/lib/rubocop/cop/gemspec/required_ruby_version.rb +48 -20
  71. data/lib/rubocop/cop/gemspec/ruby_version_globals_usage.rb +4 -2
  72. data/lib/rubocop/cop/generator.rb +12 -22
  73. data/lib/rubocop/cop/generator/configuration_injector.rb +4 -5
  74. data/lib/rubocop/cop/generator/require_file_injector.rb +2 -5
  75. data/lib/rubocop/cop/ignored_node.rb +1 -3
  76. data/lib/rubocop/cop/internal_affairs.rb +7 -1
  77. data/lib/rubocop/cop/internal_affairs/empty_line_between_expect_offense_and_correction.rb +68 -0
  78. data/lib/rubocop/cop/internal_affairs/example_description.rb +92 -0
  79. data/lib/rubocop/cop/internal_affairs/method_name_equal.rb +8 -17
  80. data/lib/rubocop/cop/internal_affairs/node_destructuring.rb +4 -4
  81. data/lib/rubocop/cop/internal_affairs/node_matcher_directive.rb +151 -0
  82. data/lib/rubocop/cop/internal_affairs/node_type_predicate.rb +11 -14
  83. data/lib/rubocop/cop/internal_affairs/offense_location_keyword.rb +12 -10
  84. data/lib/rubocop/cop/internal_affairs/redundant_described_class_as_subject.rb +62 -0
  85. data/lib/rubocop/cop/internal_affairs/redundant_let_rubocop_config_new.rb +65 -0
  86. data/lib/rubocop/cop/internal_affairs/redundant_location_argument.rb +12 -7
  87. data/lib/rubocop/cop/internal_affairs/redundant_message_argument.rb +11 -8
  88. data/lib/rubocop/cop/internal_affairs/style_detected_api_use.rb +148 -0
  89. data/lib/rubocop/cop/internal_affairs/useless_message_assertion.rb +6 -6
  90. data/lib/rubocop/cop/layout/access_modifier_indentation.rb +12 -10
  91. data/lib/rubocop/cop/layout/argument_alignment.rb +36 -19
  92. data/lib/rubocop/cop/layout/array_alignment.rb +10 -8
  93. data/lib/rubocop/cop/layout/assignment_indentation.rb +8 -7
  94. data/lib/rubocop/cop/layout/begin_end_alignment.rb +74 -0
  95. data/lib/rubocop/cop/layout/block_alignment.rb +36 -44
  96. data/lib/rubocop/cop/layout/block_end_newline.rb +4 -8
  97. data/lib/rubocop/cop/layout/case_indentation.rb +72 -30
  98. data/lib/rubocop/cop/layout/class_structure.rb +62 -74
  99. data/lib/rubocop/cop/layout/closing_heredoc_indentation.rb +4 -6
  100. data/lib/rubocop/cop/layout/closing_parenthesis_indentation.rb +24 -30
  101. data/lib/rubocop/cop/layout/comment_indentation.rb +22 -26
  102. data/lib/rubocop/cop/layout/condition_position.rb +16 -8
  103. data/lib/rubocop/cop/layout/def_end_alignment.rb +9 -10
  104. data/lib/rubocop/cop/layout/dot_position.rb +26 -21
  105. data/lib/rubocop/cop/layout/else_alignment.rb +25 -11
  106. data/lib/rubocop/cop/layout/empty_comment.rb +29 -29
  107. data/lib/rubocop/cop/layout/empty_line_after_guard_clause.rb +51 -36
  108. data/lib/rubocop/cop/layout/empty_line_after_magic_comment.rb +13 -13
  109. data/lib/rubocop/cop/layout/empty_line_after_multiline_condition.rb +136 -0
  110. data/lib/rubocop/cop/layout/empty_line_between_defs.rb +140 -40
  111. data/lib/rubocop/cop/layout/empty_lines.rb +7 -12
  112. data/lib/rubocop/cop/layout/empty_lines_around_access_modifier.rb +29 -38
  113. data/lib/rubocop/cop/layout/empty_lines_around_arguments.rb +13 -9
  114. data/lib/rubocop/cop/layout/empty_lines_around_attribute_accessor.rb +118 -0
  115. data/lib/rubocop/cop/layout/empty_lines_around_begin_body.rb +2 -5
  116. data/lib/rubocop/cop/layout/empty_lines_around_block_body.rb +2 -5
  117. data/lib/rubocop/cop/layout/empty_lines_around_class_body.rb +2 -5
  118. data/lib/rubocop/cop/layout/empty_lines_around_exception_handling_keywords.rb +4 -14
  119. data/lib/rubocop/cop/layout/empty_lines_around_method_body.rb +2 -5
  120. data/lib/rubocop/cop/layout/empty_lines_around_module_body.rb +2 -5
  121. data/lib/rubocop/cop/layout/end_alignment.rb +24 -23
  122. data/lib/rubocop/cop/layout/end_of_line.rb +8 -8
  123. data/lib/rubocop/cop/layout/extra_spacing.rb +23 -42
  124. data/lib/rubocop/cop/layout/first_argument_indentation.rb +40 -13
  125. data/lib/rubocop/cop/layout/first_array_element_indentation.rb +13 -13
  126. data/lib/rubocop/cop/layout/first_array_element_line_break.rb +4 -8
  127. data/lib/rubocop/cop/layout/first_hash_element_indentation.rb +36 -20
  128. data/lib/rubocop/cop/layout/first_hash_element_line_break.rb +3 -7
  129. data/lib/rubocop/cop/layout/first_method_argument_line_break.rb +6 -13
  130. data/lib/rubocop/cop/layout/first_method_parameter_line_break.rb +3 -7
  131. data/lib/rubocop/cop/layout/first_parameter_indentation.rb +9 -8
  132. data/lib/rubocop/cop/layout/hash_alignment.rb +76 -57
  133. data/lib/rubocop/cop/layout/heredoc_argument_closing_parenthesis.rb +45 -29
  134. data/lib/rubocop/cop/layout/heredoc_indentation.rb +32 -116
  135. data/lib/rubocop/cop/layout/indentation_consistency.rb +9 -6
  136. data/lib/rubocop/cop/layout/indentation_style.rb +25 -32
  137. data/lib/rubocop/cop/layout/indentation_width.rb +34 -15
  138. data/lib/rubocop/cop/layout/initial_indentation.rb +7 -11
  139. data/lib/rubocop/cop/layout/leading_comment_space.rb +12 -10
  140. data/lib/rubocop/cop/layout/leading_empty_lines.rb +6 -11
  141. data/lib/rubocop/cop/layout/line_end_string_concatenation_indentation.rb +122 -0
  142. data/lib/rubocop/cop/layout/line_length.rb +37 -47
  143. data/lib/rubocop/cop/layout/multiline_array_brace_layout.rb +8 -11
  144. data/lib/rubocop/cop/layout/multiline_array_line_breaks.rb +3 -7
  145. data/lib/rubocop/cop/layout/multiline_assignment_layout.rb +38 -16
  146. data/lib/rubocop/cop/layout/multiline_block_layout.rb +41 -37
  147. data/lib/rubocop/cop/layout/multiline_hash_brace_layout.rb +8 -11
  148. data/lib/rubocop/cop/layout/multiline_hash_key_line_breaks.rb +3 -7
  149. data/lib/rubocop/cop/layout/multiline_method_argument_line_breaks.rb +6 -13
  150. data/lib/rubocop/cop/layout/multiline_method_call_brace_layout.rb +8 -11
  151. data/lib/rubocop/cop/layout/multiline_method_call_indentation.rb +29 -18
  152. data/lib/rubocop/cop/layout/multiline_method_definition_brace_layout.rb +8 -11
  153. data/lib/rubocop/cop/layout/multiline_operation_indentation.rb +26 -12
  154. data/lib/rubocop/cop/layout/parameter_alignment.rb +8 -7
  155. data/lib/rubocop/cop/layout/redundant_line_break.rb +139 -0
  156. data/lib/rubocop/cop/layout/rescue_ensure_alignment.rb +37 -30
  157. data/lib/rubocop/cop/layout/single_line_block_chain.rb +53 -0
  158. data/lib/rubocop/cop/layout/space_after_colon.rb +10 -8
  159. data/lib/rubocop/cop/layout/space_after_comma.rb +2 -5
  160. data/lib/rubocop/cop/layout/space_after_method_name.rb +7 -10
  161. data/lib/rubocop/cop/layout/space_after_not.rb +9 -11
  162. data/lib/rubocop/cop/layout/space_after_semicolon.rb +2 -5
  163. data/lib/rubocop/cop/layout/space_around_block_parameters.rb +45 -52
  164. data/lib/rubocop/cop/layout/space_around_equals_in_parameter_default.rb +19 -23
  165. data/lib/rubocop/cop/layout/space_around_keyword.rb +50 -26
  166. data/lib/rubocop/cop/layout/space_around_method_call_operator.rb +34 -69
  167. data/lib/rubocop/cop/layout/space_around_operators.rb +51 -25
  168. data/lib/rubocop/cop/layout/space_before_block_braces.rb +39 -23
  169. data/lib/rubocop/cop/layout/space_before_brackets.rb +65 -0
  170. data/lib/rubocop/cop/layout/space_before_comma.rb +3 -5
  171. data/lib/rubocop/cop/layout/space_before_comment.rb +8 -9
  172. data/lib/rubocop/cop/layout/space_before_first_arg.rb +9 -15
  173. data/lib/rubocop/cop/layout/space_before_semicolon.rb +2 -5
  174. data/lib/rubocop/cop/layout/space_in_lambda_literal.rb +11 -21
  175. data/lib/rubocop/cop/layout/space_inside_array_literal_brackets.rb +30 -39
  176. data/lib/rubocop/cop/layout/space_inside_array_percent_literal.rb +5 -15
  177. data/lib/rubocop/cop/layout/space_inside_block_braces.rb +32 -37
  178. data/lib/rubocop/cop/layout/space_inside_hash_literal_braces.rb +22 -41
  179. data/lib/rubocop/cop/layout/space_inside_parens.rb +39 -22
  180. data/lib/rubocop/cop/layout/space_inside_percent_literal_delimiters.rb +5 -10
  181. data/lib/rubocop/cop/layout/space_inside_range_literal.rb +8 -17
  182. data/lib/rubocop/cop/layout/space_inside_reference_brackets.rb +18 -29
  183. data/lib/rubocop/cop/layout/space_inside_string_interpolation.rb +12 -13
  184. data/lib/rubocop/cop/layout/trailing_empty_lines.rb +10 -15
  185. data/lib/rubocop/cop/layout/trailing_whitespace.rb +42 -18
  186. data/lib/rubocop/cop/legacy/corrections_proxy.rb +43 -0
  187. data/lib/rubocop/cop/legacy/corrector.rb +27 -0
  188. data/lib/rubocop/cop/lint/ambiguous_assignment.rb +54 -0
  189. data/lib/rubocop/cop/lint/ambiguous_block_association.rb +21 -9
  190. data/lib/rubocop/cop/lint/ambiguous_operator.rb +53 -5
  191. data/lib/rubocop/cop/lint/ambiguous_regexp_literal.rb +36 -6
  192. data/lib/rubocop/cop/lint/assignment_in_condition.rb +2 -2
  193. data/lib/rubocop/cop/lint/big_decimal_new.rb +10 -10
  194. data/lib/rubocop/cop/lint/binary_operator_with_identical_operands.rb +55 -0
  195. data/lib/rubocop/cop/lint/boolean_symbol.rb +21 -13
  196. data/lib/rubocop/cop/lint/circular_argument_reference.rb +1 -1
  197. data/lib/rubocop/cop/lint/constant_definition_in_block.rb +100 -0
  198. data/lib/rubocop/cop/lint/constant_resolution.rb +89 -0
  199. data/lib/rubocop/cop/lint/debugger.rb +61 -21
  200. data/lib/rubocop/cop/lint/deprecated_class_methods.rb +86 -47
  201. data/lib/rubocop/cop/lint/deprecated_constants.rb +80 -0
  202. data/lib/rubocop/cop/lint/deprecated_open_ssl_constant.rb +148 -0
  203. data/lib/rubocop/cop/lint/disjunctive_assignment_in_constructor.rb +8 -2
  204. data/lib/rubocop/cop/lint/duplicate_branch.rb +155 -0
  205. data/lib/rubocop/cop/lint/duplicate_case_condition.rb +3 -13
  206. data/lib/rubocop/cop/lint/duplicate_elsif_condition.rb +39 -0
  207. data/lib/rubocop/cop/lint/duplicate_hash_key.rb +2 -4
  208. data/lib/rubocop/cop/lint/duplicate_methods.rb +12 -16
  209. data/lib/rubocop/cop/lint/duplicate_regexp_character_class_element.rb +77 -0
  210. data/lib/rubocop/cop/lint/duplicate_require.rb +47 -0
  211. data/lib/rubocop/cop/lint/duplicate_rescue_exception.rb +47 -0
  212. data/lib/rubocop/cop/lint/each_with_object_argument.rb +3 -1
  213. data/lib/rubocop/cop/lint/else_layout.rb +29 -5
  214. data/lib/rubocop/cop/lint/empty_block.rb +98 -0
  215. data/lib/rubocop/cop/lint/empty_class.rb +93 -0
  216. data/lib/rubocop/cop/lint/empty_conditional_body.rb +67 -0
  217. data/lib/rubocop/cop/lint/empty_ensure.rb +5 -7
  218. data/lib/rubocop/cop/lint/empty_expression.rb +2 -2
  219. data/lib/rubocop/cop/lint/empty_file.rb +48 -0
  220. data/lib/rubocop/cop/lint/empty_in_pattern.rb +62 -0
  221. data/lib/rubocop/cop/lint/empty_interpolation.rb +4 -7
  222. data/lib/rubocop/cop/lint/empty_when.rb +31 -8
  223. data/lib/rubocop/cop/lint/ensure_return.rb +29 -16
  224. data/lib/rubocop/cop/lint/erb_new_arguments.rb +18 -20
  225. data/lib/rubocop/cop/lint/flip_flop.rb +9 -3
  226. data/lib/rubocop/cop/lint/float_comparison.rb +93 -0
  227. data/lib/rubocop/cop/lint/float_out_of_range.rb +2 -3
  228. data/lib/rubocop/cop/lint/format_parameter_mismatch.rb +45 -10
  229. data/lib/rubocop/cop/lint/hash_compare_by_identity.rb +38 -0
  230. data/lib/rubocop/cop/lint/heredoc_method_call_position.rb +14 -16
  231. data/lib/rubocop/cop/lint/identity_comparison.rb +51 -0
  232. data/lib/rubocop/cop/lint/implicit_string_concatenation.rb +6 -6
  233. data/lib/rubocop/cop/lint/ineffective_access_modifier.rb +14 -20
  234. data/lib/rubocop/cop/lint/inherit_exception.rb +14 -9
  235. data/lib/rubocop/cop/lint/interpolation_check.rb +20 -7
  236. data/lib/rubocop/cop/lint/lambda_without_literal_block.rb +44 -0
  237. data/lib/rubocop/cop/lint/literal_as_condition.rb +37 -16
  238. data/lib/rubocop/cop/lint/literal_in_interpolation.rb +44 -15
  239. data/lib/rubocop/cop/lint/loop.rb +25 -5
  240. data/lib/rubocop/cop/lint/missing_cop_enable_directive.rb +35 -23
  241. data/lib/rubocop/cop/lint/missing_super.rb +101 -0
  242. data/lib/rubocop/cop/lint/mixed_regexp_capture_types.rb +36 -0
  243. data/lib/rubocop/cop/lint/multiple_comparison.rb +14 -14
  244. data/lib/rubocop/cop/lint/nested_method_definition.rb +19 -23
  245. data/lib/rubocop/cop/lint/nested_percent_literal.rb +18 -6
  246. data/lib/rubocop/cop/lint/next_without_accumulator.rb +2 -1
  247. data/lib/rubocop/cop/lint/no_return_in_begin_end_blocks.rb +58 -0
  248. data/lib/rubocop/cop/lint/non_deterministic_require_order.rb +95 -15
  249. data/lib/rubocop/cop/lint/non_local_exit_from_iterator.rb +12 -9
  250. data/lib/rubocop/cop/lint/number_conversion.rb +97 -23
  251. data/lib/rubocop/cop/lint/numbered_parameter_assignment.rb +47 -0
  252. data/lib/rubocop/cop/lint/or_assignment_to_constant.rb +39 -0
  253. data/lib/rubocop/cop/lint/ordered_magic_comments.rb +12 -15
  254. data/lib/rubocop/cop/lint/out_of_range_regexp_ref.rb +96 -0
  255. data/lib/rubocop/cop/lint/parentheses_as_grouped_expression.rb +31 -12
  256. data/lib/rubocop/cop/lint/percent_string_array.rb +6 -11
  257. data/lib/rubocop/cop/lint/percent_symbol_array.rb +13 -14
  258. data/lib/rubocop/cop/lint/raise_exception.rb +19 -7
  259. data/lib/rubocop/cop/lint/rand_one.rb +5 -4
  260. data/lib/rubocop/cop/lint/redundant_cop_disable_directive.rb +142 -115
  261. data/lib/rubocop/cop/lint/redundant_cop_enable_directive.rb +44 -30
  262. data/lib/rubocop/cop/lint/redundant_dir_glob_sort.rb +50 -0
  263. data/lib/rubocop/cop/lint/redundant_require_statement.rb +9 -10
  264. data/lib/rubocop/cop/lint/redundant_safe_navigation.rb +77 -0
  265. data/lib/rubocop/cop/lint/redundant_splat_expansion.rb +72 -35
  266. data/lib/rubocop/cop/lint/redundant_string_coercion.rb +8 -15
  267. data/lib/rubocop/cop/lint/redundant_with_index.rb +13 -18
  268. data/lib/rubocop/cop/lint/redundant_with_object.rb +13 -18
  269. data/lib/rubocop/cop/lint/regexp_as_condition.rb +4 -2
  270. data/lib/rubocop/cop/lint/require_parentheses.rb +4 -6
  271. data/lib/rubocop/cop/lint/rescue_exception.rb +3 -4
  272. data/lib/rubocop/cop/lint/rescue_type.rb +10 -16
  273. data/lib/rubocop/cop/lint/return_in_void_context.rb +3 -6
  274. data/lib/rubocop/cop/lint/safe_navigation_chain.rb +5 -8
  275. data/lib/rubocop/cop/lint/safe_navigation_consistency.rb +15 -17
  276. data/lib/rubocop/cop/lint/safe_navigation_with_empty.rb +12 -4
  277. data/lib/rubocop/cop/lint/script_permission.rb +10 -7
  278. data/lib/rubocop/cop/lint/self_assignment.rb +78 -0
  279. data/lib/rubocop/cop/lint/send_with_mixin_argument.rb +11 -19
  280. data/lib/rubocop/cop/lint/shadowed_argument.rb +8 -14
  281. data/lib/rubocop/cop/lint/shadowed_exception.rb +18 -30
  282. data/lib/rubocop/cop/lint/shadowing_outer_local_variable.rb +21 -7
  283. data/lib/rubocop/cop/lint/struct_new_override.rb +4 -3
  284. data/lib/rubocop/cop/lint/suppressed_exception.rb +53 -6
  285. data/lib/rubocop/cop/lint/symbol_conversion.rb +178 -0
  286. data/lib/rubocop/cop/lint/syntax.rb +11 -30
  287. data/lib/rubocop/cop/lint/to_enum_arguments.rb +89 -0
  288. data/lib/rubocop/cop/lint/to_json.rb +21 -13
  289. data/lib/rubocop/cop/lint/top_level_return_with_argument.rb +34 -0
  290. data/lib/rubocop/cop/lint/trailing_comma_in_attribute_declaration.rb +55 -0
  291. data/lib/rubocop/cop/lint/triple_quotes.rb +71 -0
  292. data/lib/rubocop/cop/lint/underscore_prefixed_variable_name.rb +5 -7
  293. data/lib/rubocop/cop/lint/unexpected_block_arity.rb +85 -0
  294. data/lib/rubocop/cop/lint/unified_integer.rb +5 -6
  295. data/lib/rubocop/cop/lint/unmodified_reduce_accumulator.rb +204 -0
  296. data/lib/rubocop/cop/lint/unreachable_code.rb +5 -7
  297. data/lib/rubocop/cop/lint/unreachable_loop.rb +196 -0
  298. data/lib/rubocop/cop/lint/unused_block_argument.rb +18 -11
  299. data/lib/rubocop/cop/lint/unused_method_argument.rb +11 -6
  300. data/lib/rubocop/cop/lint/uri_escape_unescape.rb +5 -2
  301. data/lib/rubocop/cop/lint/uri_regexp.rb +12 -47
  302. data/lib/rubocop/cop/lint/useless_access_modifier.rb +38 -22
  303. data/lib/rubocop/cop/lint/useless_assignment.rb +10 -14
  304. data/lib/rubocop/cop/lint/useless_else_without_rescue.rb +7 -11
  305. data/lib/rubocop/cop/lint/useless_method_definition.rb +68 -0
  306. data/lib/rubocop/cop/lint/useless_setter_call.rb +12 -10
  307. data/lib/rubocop/cop/lint/useless_times.rb +109 -0
  308. data/lib/rubocop/cop/lint/void.rb +8 -19
  309. data/lib/rubocop/cop/message_annotator.rb +5 -4
  310. data/lib/rubocop/cop/metrics/abc_size.rb +26 -2
  311. data/lib/rubocop/cop/metrics/block_length.rb +40 -10
  312. data/lib/rubocop/cop/metrics/block_nesting.rb +5 -10
  313. data/lib/rubocop/cop/metrics/class_length.rb +40 -11
  314. data/lib/rubocop/cop/metrics/cyclomatic_complexity.rb +38 -6
  315. data/lib/rubocop/cop/metrics/method_length.rb +32 -4
  316. data/lib/rubocop/cop/metrics/module_length.rb +29 -9
  317. data/lib/rubocop/cop/metrics/parameter_lists.rb +74 -11
  318. data/lib/rubocop/cop/metrics/perceived_complexity.rb +7 -9
  319. data/lib/rubocop/cop/metrics/utils/abc_size_calculator.rb +76 -15
  320. data/lib/rubocop/cop/metrics/utils/code_length_calculator.rb +160 -0
  321. data/lib/rubocop/cop/metrics/utils/iterating_block.rb +61 -0
  322. data/lib/rubocop/cop/metrics/utils/repeated_attribute_discount.rb +143 -0
  323. data/lib/rubocop/cop/metrics/utils/repeated_csend_discount.rb +42 -0
  324. data/lib/rubocop/cop/migration/department_name.rb +25 -29
  325. data/lib/rubocop/cop/mixin/alignment.rb +18 -11
  326. data/lib/rubocop/cop/mixin/allowed_identifiers.rb +18 -0
  327. data/lib/rubocop/cop/mixin/allowed_methods.rb +21 -0
  328. data/lib/rubocop/cop/mixin/annotation_comment.rb +5 -0
  329. data/lib/rubocop/cop/mixin/array_min_size.rb +2 -4
  330. data/lib/rubocop/cop/mixin/auto_corrector.rb +12 -0
  331. data/lib/rubocop/cop/mixin/check_line_breakable.rb +51 -18
  332. data/lib/rubocop/cop/mixin/code_length.rb +29 -8
  333. data/lib/rubocop/cop/mixin/comments_help.rb +42 -0
  334. data/lib/rubocop/cop/mixin/configurable_enforced_style.rb +3 -5
  335. data/lib/rubocop/cop/mixin/configurable_formatting.rb +4 -11
  336. data/lib/rubocop/cop/mixin/configurable_max.rb +1 -0
  337. data/lib/rubocop/cop/mixin/configurable_naming.rb +2 -2
  338. data/lib/rubocop/cop/mixin/configurable_numbering.rb +4 -3
  339. data/lib/rubocop/cop/mixin/def_node.rb +3 -5
  340. data/lib/rubocop/cop/mixin/documentation_comment.rb +4 -7
  341. data/lib/rubocop/cop/mixin/empty_lines_around_body.rb +14 -14
  342. data/lib/rubocop/cop/mixin/empty_parameter.rb +2 -1
  343. data/lib/rubocop/cop/mixin/end_keyword_alignment.rb +11 -2
  344. data/lib/rubocop/cop/mixin/enforce_superclass.rb +16 -8
  345. data/lib/rubocop/cop/mixin/first_element_line_break.rb +3 -3
  346. data/lib/rubocop/cop/mixin/frozen_string_literal.rb +14 -5
  347. data/lib/rubocop/cop/mixin/gem_declaration.rb +13 -0
  348. data/lib/rubocop/cop/mixin/hash_alignment_styles.rb +17 -9
  349. data/lib/rubocop/cop/mixin/hash_transform_method.rb +48 -31
  350. data/lib/rubocop/cop/mixin/ignored_methods.rb +36 -3
  351. data/lib/rubocop/cop/mixin/ignored_pattern.rb +1 -1
  352. data/lib/rubocop/cop/mixin/interpolation.rb +1 -3
  353. data/lib/rubocop/cop/mixin/line_length_help.rb +17 -15
  354. data/lib/rubocop/cop/mixin/match_range.rb +2 -5
  355. data/lib/rubocop/cop/mixin/method_complexity.rb +21 -6
  356. data/lib/rubocop/cop/mixin/method_preference.rb +1 -2
  357. data/lib/rubocop/cop/mixin/multiline_element_indentation.rb +4 -3
  358. data/lib/rubocop/cop/mixin/multiline_element_line_breaks.rb +1 -1
  359. data/lib/rubocop/cop/mixin/multiline_expression_indentation.rb +13 -42
  360. data/lib/rubocop/cop/mixin/multiline_literal_brace_layout.rb +14 -14
  361. data/lib/rubocop/cop/mixin/negative_conditional.rb +6 -4
  362. data/lib/rubocop/cop/mixin/nil_methods.rb +3 -5
  363. data/lib/rubocop/cop/mixin/ordered_gem_node.rb +7 -5
  364. data/lib/rubocop/cop/mixin/parentheses.rb +1 -2
  365. data/lib/rubocop/cop/mixin/percent_array.rb +14 -9
  366. data/lib/rubocop/cop/mixin/percent_literal.rb +0 -6
  367. data/lib/rubocop/cop/mixin/preceding_following_alignment.rb +6 -12
  368. data/lib/rubocop/cop/mixin/preferred_delimiters.rb +6 -9
  369. data/lib/rubocop/cop/mixin/range_help.rb +24 -13
  370. data/lib/rubocop/cop/mixin/rational_literal.rb +1 -0
  371. data/lib/rubocop/cop/mixin/rescue_node.rb +13 -7
  372. data/lib/rubocop/cop/mixin/safe_assignment.rb +6 -2
  373. data/lib/rubocop/cop/mixin/space_after_punctuation.rb +6 -7
  374. data/lib/rubocop/cop/mixin/space_before_punctuation.rb +5 -5
  375. data/lib/rubocop/cop/mixin/statement_modifier.rb +45 -23
  376. data/lib/rubocop/cop/mixin/string_help.rb +4 -1
  377. data/lib/rubocop/cop/mixin/string_literals_help.rb +3 -5
  378. data/lib/rubocop/cop/mixin/surrounding_space.rb +15 -31
  379. data/lib/rubocop/cop/mixin/symbol_help.rb +13 -0
  380. data/lib/rubocop/cop/mixin/target_ruby_version.rb +5 -1
  381. data/lib/rubocop/cop/mixin/trailing_body.rb +1 -2
  382. data/lib/rubocop/cop/mixin/trailing_comma.rb +12 -17
  383. data/lib/rubocop/cop/mixin/uncommunicative_name.rb +25 -32
  384. data/lib/rubocop/cop/mixin/unused_argument.rb +5 -9
  385. data/lib/rubocop/cop/mixin/visibility_help.rb +37 -0
  386. data/lib/rubocop/cop/naming/accessor_method_name.rb +19 -3
  387. data/lib/rubocop/cop/naming/ascii_identifiers.rb +29 -8
  388. data/lib/rubocop/cop/naming/binary_operator_parameter_name.rb +17 -7
  389. data/lib/rubocop/cop/naming/block_parameter_name.rb +1 -1
  390. data/lib/rubocop/cop/naming/class_and_module_camel_case.rb +13 -3
  391. data/lib/rubocop/cop/naming/constant_name.rb +4 -2
  392. data/lib/rubocop/cop/naming/file_name.rb +36 -34
  393. data/lib/rubocop/cop/naming/heredoc_delimiter_case.rb +12 -6
  394. data/lib/rubocop/cop/naming/heredoc_delimiter_naming.rb +3 -3
  395. data/lib/rubocop/cop/naming/inclusive_language.rb +249 -0
  396. data/lib/rubocop/cop/naming/memoized_instance_variable_name.rb +134 -26
  397. data/lib/rubocop/cop/naming/method_name.rb +6 -8
  398. data/lib/rubocop/cop/naming/method_parameter_name.rb +2 -2
  399. data/lib/rubocop/cop/naming/predicate_name.rb +10 -13
  400. data/lib/rubocop/cop/naming/rescued_exceptions_variable_name.rb +59 -15
  401. data/lib/rubocop/cop/naming/variable_name.rb +3 -1
  402. data/lib/rubocop/cop/naming/variable_number.rb +94 -9
  403. data/lib/rubocop/cop/offense.rb +35 -12
  404. data/lib/rubocop/cop/registry.rb +87 -23
  405. data/lib/rubocop/cop/security/eval.rb +4 -2
  406. data/lib/rubocop/cop/security/json_load.rb +8 -8
  407. data/lib/rubocop/cop/security/marshal_load.rb +4 -4
  408. data/lib/rubocop/cop/security/open.rb +15 -11
  409. data/lib/rubocop/cop/security/yaml_load.rb +8 -6
  410. data/lib/rubocop/cop/severity.rb +4 -14
  411. data/lib/rubocop/cop/style/access_modifier_declarations.rb +15 -11
  412. data/lib/rubocop/cop/style/accessor_grouping.rb +150 -0
  413. data/lib/rubocop/cop/style/alias.rb +46 -45
  414. data/lib/rubocop/cop/style/and_or.rb +25 -17
  415. data/lib/rubocop/cop/style/arguments_forwarding.rb +143 -0
  416. data/lib/rubocop/cop/style/array_coercion.rb +69 -0
  417. data/lib/rubocop/cop/style/array_join.rb +9 -9
  418. data/lib/rubocop/cop/style/ascii_comments.rb +6 -7
  419. data/lib/rubocop/cop/style/attr.rb +15 -15
  420. data/lib/rubocop/cop/style/auto_resource_cleanup.rb +9 -12
  421. data/lib/rubocop/cop/style/bare_percent_literals.rb +12 -14
  422. data/lib/rubocop/cop/style/begin_block.rb +2 -2
  423. data/lib/rubocop/cop/style/bisected_attr_accessor.rb +125 -0
  424. data/lib/rubocop/cop/style/bisected_attr_accessor/macro.rb +60 -0
  425. data/lib/rubocop/cop/style/block_comments.rb +14 -18
  426. data/lib/rubocop/cop/style/block_delimiters.rb +41 -34
  427. data/lib/rubocop/cop/style/case_equality.rb +34 -6
  428. data/lib/rubocop/cop/style/case_like_if.rb +258 -0
  429. data/lib/rubocop/cop/style/character_literal.rb +12 -15
  430. data/lib/rubocop/cop/style/class_and_module_children.rb +57 -24
  431. data/lib/rubocop/cop/style/class_check.rb +6 -11
  432. data/lib/rubocop/cop/style/class_equality_comparison.rb +67 -0
  433. data/lib/rubocop/cop/style/class_methods.rb +8 -14
  434. data/lib/rubocop/cop/style/class_methods_definitions.rb +157 -0
  435. data/lib/rubocop/cop/style/class_vars.rb +23 -7
  436. data/lib/rubocop/cop/style/collection_compact.rb +91 -0
  437. data/lib/rubocop/cop/style/collection_methods.rb +22 -15
  438. data/lib/rubocop/cop/style/colon_method_call.rb +7 -9
  439. data/lib/rubocop/cop/style/colon_method_definition.rb +6 -6
  440. data/lib/rubocop/cop/style/combinable_loops.rb +92 -0
  441. data/lib/rubocop/cop/style/command_literal.rb +22 -28
  442. data/lib/rubocop/cop/style/comment_annotation.rb +73 -26
  443. data/lib/rubocop/cop/style/commented_keyword.rb +34 -21
  444. data/lib/rubocop/cop/style/conditional_assignment.rb +71 -87
  445. data/lib/rubocop/cop/style/constant_visibility.rb +31 -2
  446. data/lib/rubocop/cop/style/copyright.rb +20 -23
  447. data/lib/rubocop/cop/style/date_time.rb +16 -5
  448. data/lib/rubocop/cop/style/def_with_parentheses.rb +9 -12
  449. data/lib/rubocop/cop/style/dir.rb +11 -12
  450. data/lib/rubocop/cop/style/disable_cops_within_source_code_directive.rb +51 -13
  451. data/lib/rubocop/cop/style/document_dynamic_eval_definition.rb +169 -0
  452. data/lib/rubocop/cop/style/documentation.rb +50 -14
  453. data/lib/rubocop/cop/style/documentation_method.rb +2 -1
  454. data/lib/rubocop/cop/style/double_cop_disable_directive.rb +7 -16
  455. data/lib/rubocop/cop/style/double_negation.rb +50 -6
  456. data/lib/rubocop/cop/style/each_for_simple_loop.rb +7 -10
  457. data/lib/rubocop/cop/style/each_with_object.rb +17 -19
  458. data/lib/rubocop/cop/style/empty_block_parameter.rb +9 -10
  459. data/lib/rubocop/cop/style/empty_case_condition.rb +22 -26
  460. data/lib/rubocop/cop/style/empty_else.rb +14 -22
  461. data/lib/rubocop/cop/style/empty_lambda_parameter.rb +9 -10
  462. data/lib/rubocop/cop/style/empty_literal.rb +46 -31
  463. data/lib/rubocop/cop/style/empty_method.rb +12 -23
  464. data/lib/rubocop/cop/style/encoding.rb +6 -10
  465. data/lib/rubocop/cop/style/end_block.rb +5 -8
  466. data/lib/rubocop/cop/style/endless_method.rb +101 -0
  467. data/lib/rubocop/cop/style/eval_with_location.rb +143 -54
  468. data/lib/rubocop/cop/style/even_odd.rb +9 -11
  469. data/lib/rubocop/cop/style/expand_path_arguments.rb +25 -23
  470. data/lib/rubocop/cop/style/explicit_block_argument.rb +114 -0
  471. data/lib/rubocop/cop/style/exponential_notation.rb +15 -18
  472. data/lib/rubocop/cop/style/float_division.rb +60 -11
  473. data/lib/rubocop/cop/style/for.rb +7 -13
  474. data/lib/rubocop/cop/style/format_string.rb +28 -22
  475. data/lib/rubocop/cop/style/format_string_token.rb +78 -22
  476. data/lib/rubocop/cop/style/frozen_string_literal_comment.rb +24 -51
  477. data/lib/rubocop/cop/style/global_std_stream.rb +66 -0
  478. data/lib/rubocop/cop/style/global_vars.rb +2 -2
  479. data/lib/rubocop/cop/style/guard_clause.rb +32 -13
  480. data/lib/rubocop/cop/style/hash_as_last_array_item.rb +88 -0
  481. data/lib/rubocop/cop/style/hash_conversion.rb +133 -0
  482. data/lib/rubocop/cop/style/hash_each_methods.rb +26 -12
  483. data/lib/rubocop/cop/style/hash_except.rb +96 -0
  484. data/lib/rubocop/cop/style/hash_like_case.rb +77 -0
  485. data/lib/rubocop/cop/style/hash_syntax.rb +48 -41
  486. data/lib/rubocop/cop/style/hash_transform_keys.rb +23 -11
  487. data/lib/rubocop/cop/style/hash_transform_values.rb +22 -10
  488. data/lib/rubocop/cop/style/identical_conditional_branches.rb +64 -11
  489. data/lib/rubocop/cop/style/if_inside_else.rb +50 -2
  490. data/lib/rubocop/cop/style/if_unless_modifier.rb +58 -49
  491. data/lib/rubocop/cop/style/if_unless_modifier_of_if_unless.rb +11 -3
  492. data/lib/rubocop/cop/style/if_with_boolean_literal_branches.rb +122 -0
  493. data/lib/rubocop/cop/style/if_with_semicolon.rb +51 -3
  494. data/lib/rubocop/cop/style/implicit_runtime_error.rb +3 -1
  495. data/lib/rubocop/cop/style/in_pattern_then.rb +56 -0
  496. data/lib/rubocop/cop/style/infinite_loop.rb +27 -26
  497. data/lib/rubocop/cop/style/inline_comment.rb +4 -4
  498. data/lib/rubocop/cop/style/inverse_methods.rb +28 -40
  499. data/lib/rubocop/cop/style/ip_addresses.rb +3 -4
  500. data/lib/rubocop/cop/style/keyword_parameters_order.rb +75 -0
  501. data/lib/rubocop/cop/style/lambda.rb +9 -16
  502. data/lib/rubocop/cop/style/lambda_call.rb +18 -35
  503. data/lib/rubocop/cop/style/line_end_concatenation.rb +21 -25
  504. data/lib/rubocop/cop/style/method_call_with_args_parentheses.rb +62 -13
  505. data/lib/rubocop/cop/style/method_call_with_args_parentheses/omit_parentheses.rb +53 -32
  506. data/lib/rubocop/cop/style/method_call_with_args_parentheses/require_parentheses.rb +8 -18
  507. data/lib/rubocop/cop/style/method_call_without_args_parentheses.rb +19 -12
  508. data/lib/rubocop/cop/style/method_called_on_do_end_block.rb +14 -7
  509. data/lib/rubocop/cop/style/method_def_parentheses.rb +18 -24
  510. data/lib/rubocop/cop/style/min_max.rb +10 -14
  511. data/lib/rubocop/cop/style/missing_else.rb +13 -25
  512. data/lib/rubocop/cop/style/missing_respond_to_missing.rb +11 -5
  513. data/lib/rubocop/cop/style/mixin_grouping.rb +26 -39
  514. data/lib/rubocop/cop/style/mixin_usage.rb +12 -30
  515. data/lib/rubocop/cop/style/module_function.rb +18 -19
  516. data/lib/rubocop/cop/style/multiline_block_chain.rb +13 -5
  517. data/lib/rubocop/cop/style/multiline_if_modifier.rb +3 -10
  518. data/lib/rubocop/cop/style/multiline_if_then.rb +5 -11
  519. data/lib/rubocop/cop/style/multiline_in_pattern_then.rb +62 -0
  520. data/lib/rubocop/cop/style/multiline_memoization.rb +15 -13
  521. data/lib/rubocop/cop/style/multiline_method_signature.rb +33 -3
  522. data/lib/rubocop/cop/style/multiline_ternary_operator.rb +32 -11
  523. data/lib/rubocop/cop/style/multiline_when_then.rb +25 -18
  524. data/lib/rubocop/cop/style/multiple_comparison.rb +77 -12
  525. data/lib/rubocop/cop/style/mutable_constant.rb +45 -37
  526. data/lib/rubocop/cop/style/negated_if.rb +10 -11
  527. data/lib/rubocop/cop/style/negated_if_else_condition.rb +128 -0
  528. data/lib/rubocop/cop/style/negated_unless.rb +10 -11
  529. data/lib/rubocop/cop/style/negated_while.rb +7 -15
  530. data/lib/rubocop/cop/style/nested_modifier.rb +10 -17
  531. data/lib/rubocop/cop/style/nested_parenthesized_calls.rb +20 -17
  532. data/lib/rubocop/cop/style/nested_ternary_operator.rb +30 -4
  533. data/lib/rubocop/cop/style/next.rb +16 -25
  534. data/lib/rubocop/cop/style/nil_comparison.rb +19 -11
  535. data/lib/rubocop/cop/style/nil_lambda.rb +70 -0
  536. data/lib/rubocop/cop/style/non_nil_check.rb +56 -34
  537. data/lib/rubocop/cop/style/not.rb +20 -26
  538. data/lib/rubocop/cop/style/numeric_literal_prefix.rb +6 -11
  539. data/lib/rubocop/cop/style/numeric_literals.rb +19 -27
  540. data/lib/rubocop/cop/style/numeric_predicate.rb +15 -23
  541. data/lib/rubocop/cop/style/one_line_conditional.rb +73 -28
  542. data/lib/rubocop/cop/style/option_hash.rb +3 -4
  543. data/lib/rubocop/cop/style/optional_arguments.rb +4 -7
  544. data/lib/rubocop/cop/style/optional_boolean_parameter.rb +53 -0
  545. data/lib/rubocop/cop/style/or_assignment.rb +11 -10
  546. data/lib/rubocop/cop/style/parallel_assignment.rb +27 -24
  547. data/lib/rubocop/cop/style/parentheses_around_condition.rb +7 -6
  548. data/lib/rubocop/cop/style/percent_literal_delimiters.rb +16 -24
  549. data/lib/rubocop/cop/style/percent_q_literals.rb +9 -12
  550. data/lib/rubocop/cop/style/perl_backrefs.rb +84 -16
  551. data/lib/rubocop/cop/style/preferred_hash_methods.rb +12 -18
  552. data/lib/rubocop/cop/style/proc.rb +8 -8
  553. data/lib/rubocop/cop/style/quoted_symbols.rb +110 -0
  554. data/lib/rubocop/cop/style/raise_args.rb +41 -37
  555. data/lib/rubocop/cop/style/random_with_offset.rb +30 -35
  556. data/lib/rubocop/cop/style/redundant_argument.rb +85 -0
  557. data/lib/rubocop/cop/style/redundant_assignment.rb +106 -0
  558. data/lib/rubocop/cop/style/redundant_begin.rb +79 -13
  559. data/lib/rubocop/cop/style/redundant_capital_w.rb +7 -11
  560. data/lib/rubocop/cop/style/redundant_condition.rb +28 -15
  561. data/lib/rubocop/cop/style/redundant_conditional.rb +13 -14
  562. data/lib/rubocop/cop/style/redundant_exception.rb +21 -16
  563. data/lib/rubocop/cop/style/redundant_fetch_block.rb +115 -0
  564. data/lib/rubocop/cop/style/redundant_file_extension_in_require.rb +52 -0
  565. data/lib/rubocop/cop/style/redundant_freeze.rb +16 -14
  566. data/lib/rubocop/cop/style/redundant_interpolation.rb +32 -27
  567. data/lib/rubocop/cop/style/redundant_parentheses.rb +51 -38
  568. data/lib/rubocop/cop/style/redundant_percent_q.rb +13 -16
  569. data/lib/rubocop/cop/style/redundant_regexp_character_class.rb +104 -0
  570. data/lib/rubocop/cop/style/redundant_regexp_escape.rb +118 -0
  571. data/lib/rubocop/cop/style/redundant_return.rb +24 -22
  572. data/lib/rubocop/cop/style/redundant_self.rb +46 -26
  573. data/lib/rubocop/cop/style/redundant_self_assignment.rb +118 -0
  574. data/lib/rubocop/cop/style/redundant_sort.rb +30 -35
  575. data/lib/rubocop/cop/style/redundant_sort_by.rb +6 -9
  576. data/lib/rubocop/cop/style/regexp_literal.rb +24 -30
  577. data/lib/rubocop/cop/style/rescue_modifier.rb +39 -12
  578. data/lib/rubocop/cop/style/rescue_standard_error.rb +25 -23
  579. data/lib/rubocop/cop/style/return_nil.rb +12 -7
  580. data/lib/rubocop/cop/style/safe_navigation.rb +44 -39
  581. data/lib/rubocop/cop/style/sample.rb +14 -15
  582. data/lib/rubocop/cop/style/self_assignment.rb +26 -22
  583. data/lib/rubocop/cop/style/semicolon.rb +10 -10
  584. data/lib/rubocop/cop/style/send.rb +5 -7
  585. data/lib/rubocop/cop/style/signal_exception.rb +32 -27
  586. data/lib/rubocop/cop/style/single_argument_dig.rb +55 -0
  587. data/lib/rubocop/cop/style/single_line_block_params.rb +34 -12
  588. data/lib/rubocop/cop/style/single_line_methods.rb +81 -19
  589. data/lib/rubocop/cop/style/slicing_with_range.rb +38 -0
  590. data/lib/rubocop/cop/style/sole_nested_conditional.rb +176 -0
  591. data/lib/rubocop/cop/style/special_global_vars.rb +21 -54
  592. data/lib/rubocop/cop/style/stabby_lambda_parentheses.rb +18 -22
  593. data/lib/rubocop/cop/style/static_class.rb +97 -0
  594. data/lib/rubocop/cop/style/stderr_puts.rb +9 -13
  595. data/lib/rubocop/cop/style/string_chars.rb +39 -0
  596. data/lib/rubocop/cop/style/string_concatenation.rb +169 -0
  597. data/lib/rubocop/cop/style/string_hash_keys.rb +8 -7
  598. data/lib/rubocop/cop/style/string_literals.rb +19 -15
  599. data/lib/rubocop/cop/style/string_literals_in_interpolation.rb +5 -3
  600. data/lib/rubocop/cop/style/string_methods.rb +7 -17
  601. data/lib/rubocop/cop/style/strip.rb +10 -14
  602. data/lib/rubocop/cop/style/struct_inheritance.rb +33 -4
  603. data/lib/rubocop/cop/style/swap_values.rb +108 -0
  604. data/lib/rubocop/cop/style/symbol_array.rb +11 -22
  605. data/lib/rubocop/cop/style/symbol_literal.rb +4 -8
  606. data/lib/rubocop/cop/style/symbol_proc.rb +50 -32
  607. data/lib/rubocop/cop/style/ternary_parentheses.rb +29 -33
  608. data/lib/rubocop/cop/style/top_level_method_definition.rb +83 -0
  609. data/lib/rubocop/cop/style/trailing_body_on_class.rb +3 -6
  610. data/lib/rubocop/cop/style/trailing_body_on_method_definition.rb +10 -9
  611. data/lib/rubocop/cop/style/trailing_body_on_module.rb +3 -6
  612. data/lib/rubocop/cop/style/trailing_comma_in_arguments.rb +5 -8
  613. data/lib/rubocop/cop/style/trailing_comma_in_array_literal.rb +5 -8
  614. data/lib/rubocop/cop/style/trailing_comma_in_block_args.rb +22 -24
  615. data/lib/rubocop/cop/style/trailing_comma_in_hash_literal.rb +5 -8
  616. data/lib/rubocop/cop/style/trailing_method_end_statement.rb +12 -38
  617. data/lib/rubocop/cop/style/trailing_underscore_variable.rb +16 -31
  618. data/lib/rubocop/cop/style/trivial_accessors.rb +101 -40
  619. data/lib/rubocop/cop/style/unless_else.rb +7 -11
  620. data/lib/rubocop/cop/style/unless_logical_operators.rb +105 -0
  621. data/lib/rubocop/cop/style/unpack_first.rb +7 -9
  622. data/lib/rubocop/cop/style/variable_interpolation.rb +8 -11
  623. data/lib/rubocop/cop/style/when_then.rb +7 -7
  624. data/lib/rubocop/cop/style/while_until_do.rb +6 -16
  625. data/lib/rubocop/cop/style/while_until_modifier.rb +16 -24
  626. data/lib/rubocop/cop/style/word_array.rb +6 -25
  627. data/lib/rubocop/cop/style/yoda_condition.rb +17 -18
  628. data/lib/rubocop/cop/style/zero_length_predicate.rb +25 -23
  629. data/lib/rubocop/cop/team.rb +147 -84
  630. data/lib/rubocop/cop/util.rb +43 -27
  631. data/lib/rubocop/cop/utils/format_string.rb +22 -9
  632. data/lib/rubocop/cop/variable_force.rb +11 -26
  633. data/lib/rubocop/cop/variable_force/assignment.rb +2 -2
  634. data/lib/rubocop/cop/variable_force/branch.rb +18 -9
  635. data/lib/rubocop/cop/variable_force/reference.rb +1 -3
  636. data/lib/rubocop/cop/variable_force/scope.rb +6 -9
  637. data/lib/rubocop/cop/variable_force/variable.rb +9 -12
  638. data/lib/rubocop/cop/variable_force/variable_table.rb +1 -1
  639. data/lib/rubocop/cops_documentation_generator.rb +270 -0
  640. data/lib/rubocop/core_ext/string.rb +2 -2
  641. data/lib/rubocop/directive_comment.rb +144 -0
  642. data/lib/rubocop/error.rb +1 -0
  643. data/lib/rubocop/ext/processed_source.rb +18 -0
  644. data/lib/rubocop/ext/regexp_node.rb +87 -0
  645. data/lib/rubocop/ext/regexp_parser.rb +92 -0
  646. data/lib/rubocop/file_finder.rb +12 -13
  647. data/lib/rubocop/formatter/auto_gen_config_formatter.rb +2 -1
  648. data/lib/rubocop/formatter/base_formatter.rb +0 -4
  649. data/lib/rubocop/formatter/clang_style_formatter.rb +4 -2
  650. data/lib/rubocop/formatter/disabled_config_formatter.rb +39 -30
  651. data/lib/rubocop/formatter/emacs_style_formatter.rb +2 -0
  652. data/lib/rubocop/formatter/formatter_set.rb +5 -5
  653. data/lib/rubocop/formatter/git_hub_actions_formatter.rb +44 -0
  654. data/lib/rubocop/formatter/html_formatter.rb +6 -10
  655. data/lib/rubocop/formatter/json_formatter.rb +1 -5
  656. data/lib/rubocop/formatter/junit_formatter.rb +34 -15
  657. data/lib/rubocop/formatter/offense_count_formatter.rb +2 -2
  658. data/lib/rubocop/formatter/progress_formatter.rb +3 -4
  659. data/lib/rubocop/formatter/quiet_formatter.rb +1 -1
  660. data/lib/rubocop/formatter/simple_text_formatter.rb +40 -7
  661. data/lib/rubocop/formatter/tap_formatter.rb +6 -2
  662. data/lib/rubocop/formatter/worst_offenders_formatter.rb +2 -2
  663. data/lib/rubocop/lockfile.rb +40 -0
  664. data/lib/rubocop/magic_comment.rb +33 -4
  665. data/lib/rubocop/name_similarity.rb +18 -10
  666. data/lib/rubocop/options.rb +126 -91
  667. data/lib/rubocop/path_util.rb +20 -22
  668. data/lib/rubocop/platform.rb +1 -1
  669. data/lib/rubocop/rake_task.rb +12 -11
  670. data/lib/rubocop/remote_config.rb +15 -11
  671. data/lib/rubocop/result_cache.rb +50 -31
  672. data/lib/rubocop/rspec/cop_helper.rb +11 -35
  673. data/lib/rubocop/rspec/expect_offense.rb +128 -39
  674. data/lib/rubocop/rspec/shared_contexts.rb +78 -32
  675. data/lib/rubocop/runner.rb +111 -74
  676. data/lib/rubocop/string_interpreter.rb +3 -0
  677. data/lib/rubocop/target_finder.rb +58 -48
  678. data/lib/rubocop/target_ruby.rb +126 -13
  679. data/lib/rubocop/util.rb +16 -0
  680. data/lib/rubocop/version.rb +71 -7
  681. data/lib/rubocop/yaml_duplication_checker.rb +1 -0
  682. metadata +189 -91
  683. data/bin/console +0 -10
  684. data/bin/setup +0 -7
  685. data/lib/rubocop/ast/builder.rb +0 -85
  686. data/lib/rubocop/ast/node.rb +0 -637
  687. data/lib/rubocop/ast/node/alias_node.rb +0 -24
  688. data/lib/rubocop/ast/node/and_node.rb +0 -29
  689. data/lib/rubocop/ast/node/args_node.rb +0 -29
  690. data/lib/rubocop/ast/node/array_node.rb +0 -70
  691. data/lib/rubocop/ast/node/block_node.rb +0 -121
  692. data/lib/rubocop/ast/node/break_node.rb +0 -17
  693. data/lib/rubocop/ast/node/case_match_node.rb +0 -56
  694. data/lib/rubocop/ast/node/case_node.rb +0 -56
  695. data/lib/rubocop/ast/node/class_node.rb +0 -31
  696. data/lib/rubocop/ast/node/def_node.rb +0 -82
  697. data/lib/rubocop/ast/node/defined_node.rb +0 -17
  698. data/lib/rubocop/ast/node/ensure_node.rb +0 -17
  699. data/lib/rubocop/ast/node/float_node.rb +0 -12
  700. data/lib/rubocop/ast/node/for_node.rb +0 -53
  701. data/lib/rubocop/ast/node/forward_args_node.rb +0 -18
  702. data/lib/rubocop/ast/node/hash_node.rb +0 -109
  703. data/lib/rubocop/ast/node/if_node.rb +0 -175
  704. data/lib/rubocop/ast/node/int_node.rb +0 -12
  705. data/lib/rubocop/ast/node/keyword_splat_node.rb +0 -45
  706. data/lib/rubocop/ast/node/mixin/basic_literal_node.rb +0 -16
  707. data/lib/rubocop/ast/node/mixin/binary_operator_node.rb +0 -43
  708. data/lib/rubocop/ast/node/mixin/collection_node.rb +0 -15
  709. data/lib/rubocop/ast/node/mixin/conditional_node.rb +0 -45
  710. data/lib/rubocop/ast/node/mixin/hash_element_node.rb +0 -125
  711. data/lib/rubocop/ast/node/mixin/method_dispatch_node.rb +0 -269
  712. data/lib/rubocop/ast/node/mixin/method_identifier_predicates.rb +0 -114
  713. data/lib/rubocop/ast/node/mixin/modifier_node.rb +0 -17
  714. data/lib/rubocop/ast/node/mixin/numeric_node.rb +0 -21
  715. data/lib/rubocop/ast/node/mixin/parameterized_node.rb +0 -61
  716. data/lib/rubocop/ast/node/mixin/predicate_operator_node.rb +0 -35
  717. data/lib/rubocop/ast/node/module_node.rb +0 -24
  718. data/lib/rubocop/ast/node/or_node.rb +0 -29
  719. data/lib/rubocop/ast/node/pair_node.rb +0 -63
  720. data/lib/rubocop/ast/node/range_node.rb +0 -18
  721. data/lib/rubocop/ast/node/regexp_node.rb +0 -33
  722. data/lib/rubocop/ast/node/resbody_node.rb +0 -24
  723. data/lib/rubocop/ast/node/retry_node.rb +0 -17
  724. data/lib/rubocop/ast/node/return_node.rb +0 -24
  725. data/lib/rubocop/ast/node/self_class_node.rb +0 -24
  726. data/lib/rubocop/ast/node/send_node.rb +0 -13
  727. data/lib/rubocop/ast/node/str_node.rb +0 -16
  728. data/lib/rubocop/ast/node/super_node.rb +0 -21
  729. data/lib/rubocop/ast/node/symbol_node.rb +0 -12
  730. data/lib/rubocop/ast/node/until_node.rb +0 -35
  731. data/lib/rubocop/ast/node/when_node.rb +0 -53
  732. data/lib/rubocop/ast/node/while_node.rb +0 -35
  733. data/lib/rubocop/ast/node/yield_node.rb +0 -21
  734. data/lib/rubocop/ast/sexp.rb +0 -16
  735. data/lib/rubocop/ast/traversal.rb +0 -202
  736. data/lib/rubocop/cop/lint/useless_comparison.rb +0 -28
  737. data/lib/rubocop/cop/mixin/classish_length.rb +0 -37
  738. data/lib/rubocop/cop/mixin/parser_diagnostic.rb +0 -37
  739. data/lib/rubocop/cop/mixin/too_many_lines.rb +0 -35
  740. data/lib/rubocop/cop/style/method_missing_super.rb +0 -34
  741. data/lib/rubocop/node_pattern.rb +0 -887
  742. data/lib/rubocop/processed_source.rb +0 -213
  743. data/lib/rubocop/string_util.rb +0 -14
  744. data/lib/rubocop/token.rb +0 -114
data/bin/console DELETED
@@ -1,10 +0,0 @@
1
- #!/usr/bin/env ruby
2
- # frozen_string_literal: true
3
-
4
- require 'bundler/setup'
5
- require 'pry'
6
- require 'rubocop'
7
-
8
- ARGV.clear
9
-
10
- RuboCop.pry
data/bin/setup DELETED
@@ -1,7 +0,0 @@
1
- #!/usr/bin/env bash
2
-
3
- set -euo pipefail
4
- IFS=$'\n\t'
5
- set -vx
6
-
7
- bundle install
@@ -1,85 +0,0 @@
1
- # frozen_string_literal: true
2
-
3
- module RuboCop
4
- module AST
5
- # `RuboCop::AST::Builder` is an AST builder that is utilized to let `Parser`
6
- # generate ASTs with {RuboCop::AST::Node}.
7
- #
8
- # @example
9
- # buffer = Parser::Source::Buffer.new('(string)')
10
- # buffer.source = 'puts :foo'
11
- #
12
- # builder = RuboCop::AST::Builder.new
13
- # require 'parser/ruby25'
14
- # parser = Parser::Ruby25.new(builder)
15
- # root_node = parser.parse(buffer)
16
- class Builder < Parser::Builders::Default
17
- NODE_MAP = {
18
- and: AndNode,
19
- alias: AliasNode,
20
- args: ArgsNode,
21
- array: ArrayNode,
22
- block: BlockNode,
23
- numblock: BlockNode,
24
- break: BreakNode,
25
- case_match: CaseMatchNode,
26
- case: CaseNode,
27
- class: ClassNode,
28
- def: DefNode,
29
- defined?: DefinedNode,
30
- defs: DefNode,
31
- ensure: EnsureNode,
32
- for: ForNode,
33
- forward_args: ForwardArgsNode,
34
- float: FloatNode,
35
- hash: HashNode,
36
- if: IfNode,
37
- int: IntNode,
38
- irange: RangeNode,
39
- erange: RangeNode,
40
- kwsplat: KeywordSplatNode,
41
- module: ModuleNode,
42
- or: OrNode,
43
- pair: PairNode,
44
- regexp: RegexpNode,
45
- resbody: ResbodyNode,
46
- retry: RetryNode,
47
- return: ReturnNode,
48
- csend: SendNode,
49
- send: SendNode,
50
- str: StrNode,
51
- dstr: StrNode,
52
- xstr: StrNode,
53
- sclass: SelfClassNode,
54
- super: SuperNode,
55
- zsuper: SuperNode,
56
- sym: SymbolNode,
57
- until: UntilNode,
58
- until_post: UntilNode,
59
- when: WhenNode,
60
- while: WhileNode,
61
- while_post: WhileNode,
62
- yield: YieldNode
63
- }.freeze
64
-
65
- # Generates {Node} from the given information.
66
- #
67
- # @return [Node] the generated node
68
- def n(type, children, source_map)
69
- node_klass(type).new(type, children, location: source_map)
70
- end
71
-
72
- # TODO: Figure out what to do about literal encoding handling...
73
- # More details here https://github.com/whitequark/parser/issues/283
74
- def string_value(token)
75
- value(token)
76
- end
77
-
78
- private
79
-
80
- def node_klass(type)
81
- NODE_MAP[type] || Node
82
- end
83
- end
84
- end
85
- end
@@ -1,637 +0,0 @@
1
- # frozen_string_literal: true
2
-
3
- module RuboCop
4
- module AST
5
- # `RuboCop::AST::Node` is a subclass of `Parser::AST::Node`. It provides
6
- # access to parent nodes and an object-oriented way to traverse an AST with
7
- # the power of `Enumerable`.
8
- #
9
- # It has predicate methods for every node type, like this:
10
- #
11
- # @example
12
- # node.send_type? # Equivalent to: `node.type == :send`
13
- # node.op_asgn_type? # Equivalent to: `node.type == :op_asgn`
14
- #
15
- # # Non-word characters (other than a-zA-Z0-9_) in type names are omitted.
16
- # node.defined_type? # Equivalent to: `node.type == :defined?`
17
- #
18
- # # Find the first lvar node under the receiver node.
19
- # lvar_node = node.each_descendant.find(&:lvar_type?)
20
- #
21
- class Node < Parser::AST::Node # rubocop:disable Metrics/ClassLength
22
- include RuboCop::AST::Sexp
23
- extend NodePattern::Macros
24
-
25
- # <=> isn't included here, because it doesn't return a boolean.
26
- COMPARISON_OPERATORS = %i[== === != <= >= > <].freeze
27
-
28
- TRUTHY_LITERALS = %i[str dstr xstr int float sym dsym array
29
- hash regexp true irange erange complex
30
- rational regopt].freeze
31
- FALSEY_LITERALS = %i[false nil].freeze
32
- LITERALS = (TRUTHY_LITERALS + FALSEY_LITERALS).freeze
33
- COMPOSITE_LITERALS = %i[dstr xstr dsym array hash irange
34
- erange regexp].freeze
35
- BASIC_LITERALS = (LITERALS - COMPOSITE_LITERALS).freeze
36
- MUTABLE_LITERALS = %i[str dstr xstr array hash
37
- regexp irange erange].freeze
38
- IMMUTABLE_LITERALS = (LITERALS - MUTABLE_LITERALS).freeze
39
-
40
- EQUALS_ASSIGNMENTS = %i[lvasgn ivasgn cvasgn gvasgn
41
- casgn masgn].freeze
42
- SHORTHAND_ASSIGNMENTS = %i[op_asgn or_asgn and_asgn].freeze
43
- ASSIGNMENTS = (EQUALS_ASSIGNMENTS + SHORTHAND_ASSIGNMENTS).freeze
44
-
45
- BASIC_CONDITIONALS = %i[if while until].freeze
46
- CONDITIONALS = [*BASIC_CONDITIONALS, :case].freeze
47
- VARIABLES = %i[ivar gvar cvar lvar].freeze
48
- REFERENCES = %i[nth_ref back_ref].freeze
49
- KEYWORDS = %i[alias and break case class def defs defined?
50
- kwbegin do else ensure for if module next
51
- not or postexe redo rescue retry return self
52
- super zsuper then undef until when while
53
- yield].freeze
54
- OPERATOR_KEYWORDS = %i[and or].freeze
55
- SPECIAL_KEYWORDS = %w[__FILE__ __LINE__ __ENCODING__].freeze
56
-
57
- # @see https://www.rubydoc.info/gems/ast/AST/Node:initialize
58
- def initialize(type, children = [], properties = {})
59
- @mutable_attributes = {}
60
-
61
- # ::AST::Node#initialize freezes itself.
62
- super
63
-
64
- # #parent= may be invoked multiple times for a node because there are
65
- # pending nodes while constructing AST and they are replaced later.
66
- # For example, `lvar` and `send` type nodes are initially created as an
67
- # `ident` type node and fixed to the appropriate type later.
68
- # So, the #parent attribute needs to be mutable.
69
- each_child_node do |child_node|
70
- child_node.parent = self unless child_node.complete?
71
- end
72
- end
73
-
74
- Parser::Meta::NODE_TYPES.each do |node_type|
75
- method_name = "#{node_type.to_s.gsub(/\W/, '')}_type?"
76
- define_method(method_name) do
77
- type == node_type
78
- end
79
- end
80
-
81
- # Returns the parent node, or `nil` if the receiver is a root node.
82
- #
83
- # @return [Node, nil] the parent node or `nil`
84
- def parent
85
- @mutable_attributes[:parent]
86
- end
87
-
88
- def parent=(node)
89
- @mutable_attributes[:parent] = node
90
- end
91
-
92
- def complete!
93
- @mutable_attributes.freeze
94
- each_child_node(&:complete!)
95
- end
96
-
97
- def complete?
98
- @mutable_attributes.frozen?
99
- end
100
-
101
- protected :parent=
102
-
103
- # Override `AST::Node#updated` so that `AST::Processor` does not try to
104
- # mutate our ASTs. Since we keep references from children to parents and
105
- # not just the other way around, we cannot update an AST and share
106
- # identical subtrees. Rather, the entire AST must be copied any time any
107
- # part of it is changed.
108
- def updated(type = nil, children = nil, properties = {})
109
- properties[:location] ||= @location
110
- klass = RuboCop::AST::Builder::NODE_MAP[type || @type] || Node
111
- klass.new(type || @type, children || @children, properties)
112
- end
113
-
114
- # Returns the index of the receiver node in its siblings. (Sibling index
115
- # uses zero based numbering.)
116
- #
117
- # @return [Integer] the index of the receiver node in its siblings
118
- def sibling_index
119
- parent&.children&.index { |sibling| sibling.equal?(self) }
120
- end
121
-
122
- # Common destructuring method. This can be used to normalize
123
- # destructuring for different variations of the node.
124
- # Some node types override this with their own custom
125
- # destructuring method.
126
- #
127
- # @return [Array<Node>] the different parts of the ndde
128
- def node_parts
129
- to_a
130
- end
131
-
132
- # Calls the given block for each ancestor node from parent to root.
133
- # If no block is given, an `Enumerator` is returned.
134
- #
135
- # @overload each_ancestor
136
- # Yield all nodes.
137
- # @overload each_ancestor(type)
138
- # Yield only nodes matching the type.
139
- # @param [Symbol] type a node type
140
- # @overload each_ancestor(type_a, type_b, ...)
141
- # Yield only nodes matching any of the types.
142
- # @param [Symbol] type_a a node type
143
- # @param [Symbol] type_b a node type
144
- # @yieldparam [Node] node each ancestor node
145
- # @return [self] if a block is given
146
- # @return [Enumerator] if no block is given
147
- def each_ancestor(*types, &block)
148
- return to_enum(__method__, *types) unless block_given?
149
-
150
- visit_ancestors(types, &block)
151
-
152
- self
153
- end
154
-
155
- # Returns an array of ancestor nodes.
156
- # This is a shorthand for `node.each_ancestor.to_a`.
157
- #
158
- # @return [Array<Node>] an array of ancestor nodes
159
- def ancestors
160
- each_ancestor.to_a
161
- end
162
-
163
- # Calls the given block for each child node.
164
- # If no block is given, an `Enumerator` is returned.
165
- #
166
- # Note that this is different from `node.children.each { |child| ... }`
167
- # which yields all children including non-node elements.
168
- #
169
- # @overload each_child_node
170
- # Yield all nodes.
171
- # @overload each_child_node(type)
172
- # Yield only nodes matching the type.
173
- # @param [Symbol] type a node type
174
- # @overload each_child_node(type_a, type_b, ...)
175
- # Yield only nodes matching any of the types.
176
- # @param [Symbol] type_a a node type
177
- # @param [Symbol] type_b a node type
178
- # @yieldparam [Node] node each child node
179
- # @return [self] if a block is given
180
- # @return [Enumerator] if no block is given
181
- def each_child_node(*types)
182
- return to_enum(__method__, *types) unless block_given?
183
-
184
- children.each do |child|
185
- next unless child.is_a?(Node)
186
-
187
- yield child if types.empty? || types.include?(child.type)
188
- end
189
-
190
- self
191
- end
192
-
193
- # Returns an array of child nodes.
194
- # This is a shorthand for `node.each_child_node.to_a`.
195
- #
196
- # @return [Array<Node>] an array of child nodes
197
- def child_nodes
198
- each_child_node.to_a
199
- end
200
-
201
- # Calls the given block for each descendant node with depth first order.
202
- # If no block is given, an `Enumerator` is returned.
203
- #
204
- # @overload each_descendant
205
- # Yield all nodes.
206
- # @overload each_descendant(type)
207
- # Yield only nodes matching the type.
208
- # @param [Symbol] type a node type
209
- # @overload each_descendant(type_a, type_b, ...)
210
- # Yield only nodes matching any of the types.
211
- # @param [Symbol] type_a a node type
212
- # @param [Symbol] type_b a node type
213
- # @yieldparam [Node] node each descendant node
214
- # @return [self] if a block is given
215
- # @return [Enumerator] if no block is given
216
- def each_descendant(*types, &block)
217
- return to_enum(__method__, *types) unless block_given?
218
-
219
- visit_descendants(types, &block)
220
-
221
- self
222
- end
223
-
224
- # Returns an array of descendant nodes.
225
- # This is a shorthand for `node.each_descendant.to_a`.
226
- #
227
- # @return [Array<Node>] an array of descendant nodes
228
- def descendants
229
- each_descendant.to_a
230
- end
231
-
232
- # Calls the given block for the receiver and each descendant node in
233
- # depth-first order.
234
- # If no block is given, an `Enumerator` is returned.
235
- #
236
- # This method would be useful when you treat the receiver node as the root
237
- # of a tree and want to iterate over all nodes in the tree.
238
- #
239
- # @overload each_node
240
- # Yield all nodes.
241
- # @overload each_node(type)
242
- # Yield only nodes matching the type.
243
- # @param [Symbol] type a node type
244
- # @overload each_node(type_a, type_b, ...)
245
- # Yield only nodes matching any of the types.
246
- # @param [Symbol] type_a a node type
247
- # @param [Symbol] type_b a node type
248
- # @yieldparam [Node] node each node
249
- # @return [self] if a block is given
250
- # @return [Enumerator] if no block is given
251
- def each_node(*types, &block)
252
- return to_enum(__method__, *types) unless block_given?
253
-
254
- yield self if types.empty? || types.include?(type)
255
-
256
- visit_descendants(types, &block)
257
-
258
- self
259
- end
260
-
261
- def source
262
- loc.expression.source
263
- end
264
-
265
- def source_range
266
- loc.expression
267
- end
268
-
269
- def first_line
270
- loc.line
271
- end
272
-
273
- def last_line
274
- loc.last_line
275
- end
276
-
277
- def line_count
278
- return 0 unless source_range
279
-
280
- source_range.last_line - source_range.first_line + 1
281
- end
282
-
283
- def nonempty_line_count
284
- source.lines.grep(/\S/).size
285
- end
286
-
287
- def source_length
288
- source_range ? source_range.size : 0
289
- end
290
-
291
- ## Destructuring
292
-
293
- def_node_matcher :receiver, <<~PATTERN
294
- {(send $_ ...) ({block numblock} (send $_ ...) ...)}
295
- PATTERN
296
-
297
- def_node_matcher :str_content, '(str $_)'
298
-
299
- def const_name
300
- return unless const_type?
301
-
302
- namespace, name = *self
303
- if namespace && !namespace.cbase_type?
304
- "#{namespace.const_name}::#{name}"
305
- else
306
- name.to_s
307
- end
308
- end
309
-
310
- def_node_matcher :defined_module0, <<~PATTERN
311
- {(class (const $_ $_) ...)
312
- (module (const $_ $_) ...)
313
- (casgn $_ $_ (send (const nil? {:Class :Module}) :new ...))
314
- (casgn $_ $_ (block (send (const nil? {:Class :Module}) :new ...) ...))}
315
- PATTERN
316
-
317
- private :defined_module0
318
-
319
- def defined_module
320
- namespace, name = *defined_module0
321
- s(:const, namespace, name) if name
322
- end
323
-
324
- def defined_module_name
325
- (const = defined_module) && const.const_name
326
- end
327
-
328
- ## Searching the AST
329
-
330
- def parent_module_name
331
- # what class or module is this method/constant/etc definition in?
332
- # returns nil if answer cannot be determined
333
- ancestors = each_ancestor(:class, :module, :sclass, :casgn, :block)
334
- result = ancestors.map do |ancestor|
335
- parent_module_name_part(ancestor) { |full_name| return full_name }
336
- end.compact.reverse.join('::')
337
- result.empty? ? 'Object' : result
338
- end
339
-
340
- ## Predicates
341
-
342
- def multiline?
343
- line_count > 1
344
- end
345
-
346
- def single_line?
347
- line_count == 1
348
- end
349
-
350
- def empty_source?
351
- source_length.zero?
352
- end
353
-
354
- # Some cops treat the shovel operator as a kind of assignment.
355
- def_node_matcher :assignment_or_similar?, <<~PATTERN
356
- {assignment? (send _recv :<< ...)}
357
- PATTERN
358
-
359
- def literal?
360
- LITERALS.include?(type)
361
- end
362
-
363
- def basic_literal?
364
- BASIC_LITERALS.include?(type)
365
- end
366
-
367
- def truthy_literal?
368
- TRUTHY_LITERALS.include?(type)
369
- end
370
-
371
- def falsey_literal?
372
- FALSEY_LITERALS.include?(type)
373
- end
374
-
375
- def mutable_literal?
376
- MUTABLE_LITERALS.include?(type)
377
- end
378
-
379
- def immutable_literal?
380
- IMMUTABLE_LITERALS.include?(type)
381
- end
382
-
383
- %i[literal basic_literal].each do |kind|
384
- recursive_kind = :"recursive_#{kind}?"
385
- kind_filter = :"#{kind}?"
386
- define_method(recursive_kind) do
387
- case type
388
- when :send
389
- [*COMPARISON_OPERATORS, :!, :<=>].include?(method_name) &&
390
- receiver.send(recursive_kind) &&
391
- arguments.all?(&recursive_kind)
392
- when :begin, :pair, *OPERATOR_KEYWORDS, *COMPOSITE_LITERALS
393
- children.compact.all?(&recursive_kind)
394
- else
395
- send(kind_filter)
396
- end
397
- end
398
- end
399
-
400
- def variable?
401
- VARIABLES.include?(type)
402
- end
403
-
404
- def reference?
405
- REFERENCES.include?(type)
406
- end
407
-
408
- def equals_asgn?
409
- EQUALS_ASSIGNMENTS.include?(type)
410
- end
411
-
412
- def shorthand_asgn?
413
- SHORTHAND_ASSIGNMENTS.include?(type)
414
- end
415
-
416
- def assignment?
417
- ASSIGNMENTS.include?(type)
418
- end
419
-
420
- def basic_conditional?
421
- BASIC_CONDITIONALS.include?(type)
422
- end
423
-
424
- def conditional?
425
- CONDITIONALS.include?(type)
426
- end
427
-
428
- def keyword?
429
- return true if special_keyword? || send_type? && prefix_not?
430
- return false unless KEYWORDS.include?(type)
431
-
432
- !OPERATOR_KEYWORDS.include?(type) || loc.operator.is?(type.to_s)
433
- end
434
-
435
- def special_keyword?
436
- SPECIAL_KEYWORDS.include?(source)
437
- end
438
-
439
- def operator_keyword?
440
- OPERATOR_KEYWORDS.include?(type)
441
- end
442
-
443
- def parenthesized_call?
444
- loc.respond_to?(:begin) && loc.begin && loc.begin.is?('(')
445
- end
446
-
447
- def call_type?
448
- send_type? || csend_type?
449
- end
450
-
451
- def chained?
452
- parent&.call_type? && eql?(parent.receiver)
453
- end
454
-
455
- def argument?
456
- parent&.send_type? && parent.arguments.include?(self)
457
- end
458
-
459
- def boolean_type?
460
- true_type? || false_type?
461
- end
462
-
463
- def numeric_type?
464
- int_type? || float_type?
465
- end
466
-
467
- def range_type?
468
- irange_type? || erange_type?
469
- end
470
-
471
- def guard_clause?
472
- node = and_type? || or_type? ? rhs : self
473
-
474
- node.match_guard_clause?
475
- end
476
-
477
- def_node_matcher :match_guard_clause?, <<~PATTERN
478
- [${(send nil? {:raise :fail} ...) return break next} single_line?]
479
- PATTERN
480
-
481
- def_node_matcher :proc?, <<~PATTERN
482
- {(block (send nil? :proc) ...)
483
- (block (send (const nil? :Proc) :new) ...)
484
- (send (const nil? :Proc) :new)}
485
- PATTERN
486
-
487
- def_node_matcher :lambda?, '({block numblock} (send nil? :lambda) ...)'
488
- def_node_matcher :lambda_or_proc?, '{lambda? proc?}'
489
-
490
- def_node_matcher :class_constructor?, <<~PATTERN
491
- { (send (const nil? {:Class :Module}) :new ...)
492
- (block (send (const nil? {:Class :Module}) :new ...) ...)}
493
- PATTERN
494
-
495
- # Some expressions are evaluated for their value, some for their side
496
- # effects, and some for both
497
- # If we know that an expression is useful only for its side effects, that
498
- # means we can transform it in ways which preserve the side effects, but
499
- # change the return value
500
- # So, does the return value of this node matter? If we changed it to
501
- # `(...; nil)`, might that affect anything?
502
- #
503
- # rubocop:disable Metrics/MethodLength, Metrics/CyclomaticComplexity
504
- def value_used?
505
- # Be conservative and return true if we're not sure.
506
- return false if parent.nil?
507
-
508
- case parent.type
509
- when :array, :defined?, :dstr, :dsym, :eflipflop, :erange, :float,
510
- :hash, :iflipflop, :irange, :not, :pair, :regexp, :str, :sym,
511
- :when, :xstr
512
- parent.value_used?
513
- when :begin, :kwbegin
514
- begin_value_used?
515
- when :for
516
- for_value_used?
517
- when :case, :if
518
- case_if_value_used?
519
- when :while, :until, :while_post, :until_post
520
- while_until_value_used?
521
- else
522
- true
523
- end
524
- end
525
- # rubocop:enable Metrics/MethodLength, Metrics/CyclomaticComplexity
526
-
527
- # Some expressions are evaluated for their value, some for their side
528
- # effects, and some for both.
529
- # If we know that expressions are useful only for their return values,
530
- # and have no side effects, that means we can reorder them, change the
531
- # number of times they are evaluated, or replace them with other
532
- # expressions which are equivalent in value.
533
- # So, is evaluation of this node free of side effects?
534
- #
535
- def pure?
536
- # Be conservative and return false if we're not sure
537
- case type
538
- when :__FILE__, :__LINE__, :const, :cvar, :defined?, :false, :float,
539
- :gvar, :int, :ivar, :lvar, :nil, :str, :sym, :true, :regopt
540
- true
541
- when :and, :array, :begin, :case, :dstr, :dsym, :eflipflop, :ensure,
542
- :erange, :for, :hash, :if, :iflipflop, :irange, :kwbegin, :not,
543
- :or, :pair, :regexp, :until, :until_post, :when, :while,
544
- :while_post
545
- child_nodes.all?(&:pure?)
546
- else
547
- false
548
- end
549
- end
550
-
551
- protected
552
-
553
- def visit_descendants(types, &block)
554
- each_child_node do |child|
555
- yield child if types.empty? || types.include?(child.type)
556
- child.visit_descendants(types, &block)
557
- end
558
- end
559
-
560
- private
561
-
562
- def visit_ancestors(types)
563
- last_node = self
564
-
565
- while (current_node = last_node.parent)
566
- yield current_node if types.empty? ||
567
- types.include?(current_node.type)
568
- last_node = current_node
569
- end
570
- end
571
-
572
- def begin_value_used?
573
- # the last child node determines the value of the parent
574
- sibling_index == parent.children.size - 1 ? parent.value_used? : false
575
- end
576
-
577
- def for_value_used?
578
- # `for var in enum; body; end`
579
- # (for <var> <enum> <body>)
580
- sibling_index == 2 ? parent.value_used? : true
581
- end
582
-
583
- def case_if_value_used?
584
- # (case <condition> <when...>)
585
- # (if <condition> <truebranch> <falsebranch>)
586
- sibling_index.zero? ? true : parent.value_used?
587
- end
588
-
589
- def while_until_value_used?
590
- # (while <condition> <body>) -> always evaluates to `nil`
591
- sibling_index.zero?
592
- end
593
-
594
- def parent_module_name_part(node)
595
- case node.type
596
- when :class, :module, :casgn
597
- # TODO: if constant name has cbase (leading ::), then we don't need
598
- # to keep traversing up through nested classes/modules
599
- node.defined_module_name
600
- when :sclass
601
- yield parent_module_name_for_sclass(node)
602
- else # block
603
- parent_module_name_for_block(node) { yield nil }
604
- end
605
- end
606
-
607
- def parent_module_name_for_sclass(sclass_node)
608
- # TODO: look for constant definition and see if it is nested
609
- # inside a class or module
610
- subject = sclass_node.children[0]
611
-
612
- if subject.const_type?
613
- "#<Class:#{subject.const_name}>"
614
- elsif subject.self_type?
615
- "#<Class:#{sclass_node.parent_module_name}>"
616
- end
617
- end
618
-
619
- def parent_module_name_for_block(ancestor)
620
- if ancestor.method?(:class_eval)
621
- # `class_eval` with no receiver applies to whatever module or class
622
- # we are currently in
623
- return unless (receiver = ancestor.receiver)
624
-
625
- yield unless receiver.const_type?
626
- receiver.const_name
627
- elsif !new_class_or_module_block?(ancestor)
628
- yield
629
- end
630
- end
631
-
632
- def_node_matcher :new_class_or_module_block?, <<~PATTERN
633
- ^(casgn _ _ (block (send (const _ {:Class :Module}) :new) ...))
634
- PATTERN
635
- end
636
- end
637
- end