rubocop 0.8.0 → 0.8.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8c61251297391f7ee7286eb0e4482e975a42122f
-  data.tar.gz: 4375f2e36ceaa75510f7e4cdece56d3f1e22700f
+  metadata.gz: 9d32a48395898e975b6e30a1e0c135d327b637d5
+  data.tar.gz: 95923132f5031a94cea48306ba714e3510dd1f7a
 SHA512:
-  metadata.gz: 9a6ed60555b7fbc888b9a68190c79bb525ece1e3623e1025fe833016e13b635b947b0cf49fab267ab4bf886bb0c8438bea130011a8c9dd8efa3e6e863b218b8f
-  data.tar.gz: 2f4161c9a52973931d695f900045b46b55e56d62debac661ab25308b031e383906cf33b107f8cf8f6701dba4c251cf9bac7ae49f32550aaca278bae7d556d688
+  metadata.gz: 5c1d467dc759961b51256357d3e3ba49d1476cb1dc2ed8c69d4b755092e19b20c78746595fc0e532fee545646e36061fbaec8f5a597374be0085fc4dee600f1c
+  data.tar.gz: 51e01dbff570f1ffa8394a64cb7e2193f6717fad24fc5e6ce57468cb99c1385f8a8efc48433fbd25914dd6694bb978fca4edeed418e78738b7970a8536569972

data/CHANGELOG.md

@@ -6,9 +6,29 @@
 
 ### Changes
 
+### Bug fixes
+
+## 0.8.1 (05/30/2013)
+
+### New features
+
+* New cop `Proc` tracks uses of `Proc.new`
+
+### Changes
+
+* Renamed `NewLambdaLiteral` to `Lambda`.
+* Aligned the `Lambda` cop more closely to the style guide - it now
+  allows the use of `lambda` for multi-line blocks.
+
 ### Bugs fixed
 
-## 0.8.0 (05/28/2012)
+* [#210](https://github.com/bbatsov/rubocop/issues/210) - fix a false positive for double quotes in regexp literals
+* [#211](https://github.com/bbatsov/rubocop/issues/211) - fix a false positive for `initialize` method looking like a trivial writer
+* [#215](https://github.com/bbatsov/rubocop/issues/215) - Fixed a lot of modifier `if/unless/while/until` issues
+* [#213](https://github.com/bbatsov/rubocop/issues/213) - Make sure even disabled cops get their configuration set
+* [#214](https://github.com/bbatsov/rubocop/issues/214) - Fix SpaceInsideHashLiteralBraces to handle string interpolation right
+
+## 0.8.0 (05/28/2013)
 
 ### Changes
 

data/config/enabled.yml

@@ -153,8 +153,12 @@ FavorUntilOverNegatedWhile:
 SpaceAroundEqualsInParameterDefault:
   Enabled: true
 
-# Use the new lambda literal syntax.
-NewLambdaLiteral:
+# Use the new lambda literal syntax for single-line blocks.
+Lambda:
+  Enabled: true
+
+# Use proc instead of Proc.new.
+Proc:
   Enabled: true
 
 # Don't use parentheses around the condition of an if/unless/while.

data/lib/rubocop.rb

@@ -35,7 +35,8 @@ require 'rubocop/cop/and_or'
 require 'rubocop/cop/when_then'
 require 'rubocop/cop/favor_modifier'
 require 'rubocop/cop/favor_unless_over_negated_if'
-require 'rubocop/cop/new_lambda_literal'
+require 'rubocop/cop/lambda'
+require 'rubocop/cop/proc'
 require 'rubocop/cop/parentheses_around_condition'
 require 'rubocop/cop/method_and_variable_snake_case'
 require 'rubocop/cop/class_and_module_camel_case'

data/lib/rubocop/cli.rb

@@ -91,9 +91,9 @@ module Rubocop
 
       @cops.each do |cop_class|
         cop_name = cop_class.cop_name
+        cop_class.config = config.for_cop(cop_name)
         if config.cop_enabled?(cop_name)
           cop = setup_cop(cop_class,
-                          config.for_cop(cop_name),
                           disabled_lines)
           if !@options[:only] || @options[:only] == cop_name
             begin
@@ -110,8 +110,7 @@ module Rubocop
       end
     end
 
-    def setup_cop(cop_class, cop_config, disabled_lines)
-      cop_class.config = cop_config
+    def setup_cop(cop_class, disabled_lines)
       cop = cop_class.new
       cop.debug = @options[:debug]
       cop.disabled_lines = disabled_lines[cop_class.cop_name]

data/lib/rubocop/cop/and_or.rb

@@ -8,6 +8,20 @@ module Rubocop
       OPS = { 'and' => '&&', 'or' => '||' }
 
       def on_and(node)
+        process_logical_op(node)
+
+        super
+      end
+
+      def on_or(node)
+        process_logical_op(node)
+
+        super
+      end
+
+      private
+
+      def process_logical_op(node)
         op = node.loc.operator.source
         op_type = node.type.to_s
 
@@ -16,11 +30,7 @@ module Rubocop
                       node.loc.operator.line,
                       sprintf(MSG, OPS[op], op))
         end
-
-        super
       end
-
-      alias_method :on_or, :on_and
     end
   end
 end

data/lib/rubocop/cop/cop.rb

@@ -54,6 +54,9 @@ module Rubocop
       def on_comment(comment)
       end
 
+      def ignore_node(node)
+      end
+
       def add_offence(severity, line_number, message)
         unless @disabled_lines && @disabled_lines.include?(line_number)
           message = debug ? "#{name}: #{message}" : message

data/lib/rubocop/cop/empty_literal.rb

@@ -25,23 +25,25 @@ module Rubocop
       #   (const nil :String) :new)
       STR_NODE = s(:send, s(:const, nil, :String), :new)
 
-      def inspect(source, tokens, ast, comments)
-        on_node(:send, ast, :block) do |node|
-          if node == ARRAY_NODE
-            add_offence(:convention,
-                        node.loc.line,
-                        ARR_MSG)
-          elsif node == HASH_NODE
-            add_offence(:convention,
-                        node.loc.line,
-                        HASH_MSG)
-          elsif node == STR_NODE
-            add_offence(:convention,
-                        node.loc.line,
-                        STR_MSG)
-          end
+      def on_send(node)
+        case node
+        when ARRAY_NODE
+          add_offence(:convention,
+                      node.loc.line,
+                      ARR_MSG)
+        when HASH_NODE
+          add_offence(:convention,
+                      node.loc.line,
+                      HASH_MSG)
+        when STR_NODE
+          add_offence(:convention,
+                      node.loc.line,
+                      STR_MSG)
         end
       end
+
+      # TODO Check block contents as well
+      alias_method :on_block, :ignore_node
     end
   end
 end

data/lib/rubocop/cop/favor_modifier.rb

@@ -7,11 +7,13 @@ module Rubocop
       def check(sexp)
         # discard if/then/else
         return false if sexp.loc.respond_to?(:else) && sexp.loc.else
+        # discard modifier while/until
+        return false if [:while, :until].include?(sexp.type) && !sexp.loc.end
 
-        if %w(if while).include?(sexp.loc.keyword.source)
-          cond, body = *sexp
-        else
-          cond, _else, body = *sexp
+        case sexp.loc.keyword.source
+        when 'if'     then cond, body, _else = *sexp
+        when 'unless' then cond, _else, body = *sexp
+        else               cond, body = *sexp
         end
 
         if length(sexp) > 3
@@ -20,7 +22,7 @@ module Rubocop
           cond_length = sexp.loc.keyword.size + cond.loc.expression.size + 1
           body_length = body_length(body)
 
-          (cond_length + body_length) <= LineLength.max
+          body_length > 0 && (cond_length + body_length) <= LineLength.max
         end
       end
 
@@ -29,7 +31,7 @@ module Rubocop
       end
 
       def body_length(body)
-        if body
+        if body && body.loc.expression
           body.loc.expression.column + body.loc.expression.size
         else
           0

data/lib/rubocop/cop/lambda.rb

@@ -0,0 +1,42 @@
+# encoding: utf-8
+
+module Rubocop
+  module Cop
+    class Lambda < Cop
+      SINGLE_MSG = 'Use the new lambda literal syntax ->(params) {...}.'
+      MULTI_MSG = 'Use the lambda method for multi-line lambdas.'
+
+      TARGET = s(:send, nil, :lambda)
+
+      def on_block(node)
+        # We're looking for
+        # (block
+        #   (send nil :lambda)
+        #   ...)
+        block_method, = *node
+
+        if block_method == TARGET
+          selector = block_method.loc.selector.source
+          lambda_length = lambda_length(node)
+
+          if selector != '->' && lambda_length == 0
+            add_offence(:convention, block_method.loc.line, SINGLE_MSG)
+          elsif selector == '->' && lambda_length > 0
+            add_offence(:convention, block_method.loc.line, MULTI_MSG)
+          end
+        end
+
+        super
+      end
+
+      private
+
+      def lambda_length(block_node)
+        start_line = block_node.loc.begin.line
+        end_line = block_node.loc.end.line
+
+        end_line - start_line
+      end
+    end
+  end
+end

data/lib/rubocop/cop/line_continuation.rb

@@ -7,7 +7,7 @@ module Rubocop
 
       def inspect(source, tokens, ast, comments)
         source.each_with_index do |line, index|
-          add_offence(:convention, index, MSG) if line =~ /.*\\\z/
+          add_offence(:convention, index + 1, MSG) if line =~ /.*\\\z/
         end
       end
     end

data/lib/rubocop/cop/parentheses_around_condition.rb

@@ -6,17 +6,33 @@ module Rubocop
       MSG = "Don't use parentheses around the condition of an " +
         'if/unless/while/until, unless the condition contains an assignment.'
 
-      def inspect(source, tokens, ast, comments)
-        on_node([:if, :while, :until], ast) do |node|
-          cond, _body = *node
+      def on_if(node)
+        process_control_op(node)
 
-          cond_source = cond.loc.expression.source
+        super
+      end
+
+      def on_while(node)
+        process_control_op(node)
+
+        super
+      end
+
+      def on_until(node)
+        process_control_op(node)
+
+        super
+      end
+
+      private
+
+      def process_control_op(node)
+        cond, _body = *node
+
+        cond_source = cond.loc.expression.source
 
-          if cond_source.start_with?('(') && cond_source.end_with?(')')
-            add_offence(:convetion,
-                        cond.loc.line,
-                        MSG)
-          end
+        if cond_source.start_with?('(') && cond_source.end_with?(')')
+          add_offence(:convetion, cond.loc.line, MSG)
         end
       end
     end

data/lib/rubocop/cop/proc.rb

@@ -0,0 +1,26 @@
+# encoding: utf-8
+
+module Rubocop
+  module Cop
+    class Proc < Cop
+      MSG = 'Use proc instead of Proc.new.'
+
+      TARGET = s(:send, s(:const, nil, :Proc), :new)
+
+      def on_block(node)
+        # We're looking for
+        # (block
+        #   (send
+        #     (const nil :Proc) :new)
+        #   ...)
+        block_method, = *node
+
+        if block_method == TARGET
+          add_offence(:convention, block_method.loc.line, MSG)
+        end
+
+        super
+      end
+    end
+  end
+end

data/lib/rubocop/cop/rescue_modifier.rb

@@ -5,13 +5,11 @@ module Rubocop
     class RescueModifier < Cop
       MSG = 'Avoid using rescue in its modifier form.'
 
-      def inspect(source, tokens, ast, comments)
-        on_node(:rescue, ast, :begin) do |s|
-          add_offence(:convention,
-                      s.loc.line,
-                      MSG)
-        end
+      def on_rescue(node)
+        add_offence(:convention, node.loc.line, MSG)
       end
+
+      alias_method :on_begin, :ignore_node
     end
   end
 end

data/lib/rubocop/cop/string_literals.rb

@@ -6,17 +6,20 @@ module Rubocop
       MSG = "Prefer single-quoted strings when you don't need " +
         'string interpolation or special symbols.'
 
-      def inspect(source, tokens, ast, comments)
-        on_node(:str, ast, :dstr) do |s|
-          text = s.to_a[0]
+      def on_str(node)
+        text, = *node
 
-          if text !~ /['\n\t\r]/ && s.loc.expression.source[0] == '"'
-            add_offence(:convention,
-                        s.loc.line,
-                        MSG)
-          end
+        # Constants like __FILE__ and __DIR__ are created as strings,
+        # but don't respond to begin.
+        return unless node.loc.respond_to?(:begin)
+
+        if text !~ /['\n\t\r]/ && node.loc.begin.source == '"'
+          add_offence(:convention, node.loc.line, MSG)
         end
       end
+
+      alias_method :on_dstr, :ignore_node
+      alias_method :on_regexp, :ignore_node
     end
   end
 end

data/lib/rubocop/cop/surrounding_space.rb

@@ -246,8 +246,10 @@ module Rubocop
         on_node(:hash, sexp) do |hash|
           b_ix = index_of_first_token(hash, tokens)
           e_ix = index_of_last_token(hash, tokens)
-          check(tokens[b_ix], tokens[b_ix + 1])
-          check(tokens[e_ix - 1], tokens[e_ix])
+          if tokens[b_ix].type == :tLBRACE # Hash literal with braces?
+            check(tokens[b_ix], tokens[b_ix + 1])
+            check(tokens[e_ix - 1], tokens[e_ix])
+          end
         end
       end
 

data/lib/rubocop/cop/trivial_accessors.rb

@@ -6,12 +6,12 @@ module Rubocop
       MSG = 'Use attr_%s to define trivial %s methods.'
 
       def on_def(node)
-        _, args, body = *node
+        method_name, args, body = *node
 
         kind = if body.type == :ivar
                  'reader'
                elsif args.children.size == 1 && body.type == :ivasgn &&
-                   body.children[1].type == :lvar
+                   body.children[1].type == :lvar && method_name != :initialize
                  'writer'
                end
         if kind

data/lib/rubocop/version.rb

@@ -2,6 +2,6 @@
 
 module Rubocop
   module Version
-    STRING = '0.8.0'
+    STRING = '0.8.1'
   end
 end

data/rubocop.gemspec

@@ -28,7 +28,7 @@ Gem::Specification.new do |s|
   s.summary = 'Automatic Ruby code style checking tool.'
 
   s.add_runtime_dependency('rainbow', '>= 1.1.4')
-  s.add_runtime_dependency('parser', '~> 2.0.0.beta2')
+  s.add_runtime_dependency('parser', ['>= 2.0.0.beta1', '<= 2.0.0'])
   s.add_development_dependency('rake', '~> 10.0')
   s.add_development_dependency('rspec', '~> 2.13')
   s.add_development_dependency('yard', '~> 0.8')

data/spec/rubocop/cli_spec.rb

@@ -257,6 +257,28 @@ module Rubocop
          ''].join("\n"))
     end
 
+    it 'works when a cop that others depend on is disabled' do
+      create_file('example1.rb', ['if a',
+                                  '  b',
+                                  'end'])
+      create_file('rubocop.yml', [
+        'Encoding:',
+        '  Enabled: false',
+        '',
+        'LineLength:',
+        '  Enabled: false'
+      ])
+      result = cli.run(['-c', 'rubocop.yml', 'example1.rb'])
+      expect($stdout.string).to eq(
+        ['== example1.rb ==',
+         'C:  1: Favor modifier if/unless usage when you have a single-line ' +
+         'body. Another good alternative is the usage of control flow &&/||.',
+         '',
+         '1 file inspected, 1 offence detected',
+         ''].join("\n"))
+      expect(result).to eq(1)
+    end
+
     it 'can be configured with project config to disable a certain error' do
       create_file('example_src/example1.rb', 'puts 0 ')
       create_file('example_src/.rubocop.yml', [

data/spec/rubocop/cops/favor_modifier_spec.rb

@@ -4,52 +4,53 @@ require 'spec_helper'
 
 module Rubocop
   module Cop
-    describe FavorModifier, broken: true do
-      let(:if_until) { IfUnlessModifier.new }
+    describe FavorModifier do
+      let(:if_unless) { IfUnlessModifier.new }
       let(:while_until) { WhileUntilModifier.new }
       before { LineLength.config = { 'Max' => 79 } }
 
-      it 'registers an offence for multiline if that fits on one line' do
+      it 'registers an offence for multiline if that fits on one line',
+          broken: true do
         # This if statement fits exactly on one line if written as a modifier.
-        inspect_source(if_until,
+        inspect_source(if_unless,
                        ['if a_condition_that_is_just_short_enough',
                         '  some_long_metod_name(followed_by_args)',
                         'end'])
-        expect(if_until.offences.map(&:message)).to eq(
+        expect(if_unless.offences.map(&:message)).to eq(
           ['Favor modifier if/unless usage when you have a single-line body.' +
-           ' Another good alternative is the usage of control flow and/or.'])
+           ' Another good alternative is the usage of control flow &&/||.'])
       end
 
       it "accepts multiline if that doesn't fit on one line" do
-        check_too_long(if_until, 'if')
+        check_too_long(if_unless, 'if')
       end
 
       it 'accepts multiline if whose body is more than one line' do
-        check_short_multiline(if_until, 'if')
+        check_short_multiline(if_unless, 'if')
       end
 
       it 'registers an offence for multiline unless that fits on one line' do
-        inspect_source(if_until, ['unless a',
+        inspect_source(if_unless, ['unless a',
                                   '  b',
                                   'end'])
-        expect(if_until.offences.map(&:message)).to eq(
+        expect(if_unless.offences.map(&:message)).to eq(
           ['Favor modifier if/unless usage when you have a single-line body.' +
-           ' Another good alternative is the usage of control flow and/or.'])
+           ' Another good alternative is the usage of control flow &&/||.'])
       end
 
       it 'accepts code with EOL comment since user might want to keep it' do
         pending
-        inspect_source(if_until, ['unless a',
+        inspect_source(if_unless, ['unless a',
                                   '  b # A comment',
                                   'end'])
-        expect(if_until.offences.map(&:message)).to be_empty
+        expect(if_unless.offences.map(&:message)).to be_empty
       end
 
       it 'accepts if-else-end' do
-        inspect_source(if_until,
+        inspect_source(if_unless,
                        ['if args.last.is_a? Hash then args.pop else ' +
                         'Hash.new end'])
-        expect(if_until.offences.map(&:message)).to be_empty
+        expect(if_unless.offences.map(&:message)).to be_empty
       end
 
       it "accepts multiline unless that doesn't fit on one line" do
@@ -84,6 +85,29 @@ module Rubocop
         check_short_multiline(while_until, 'until')
       end
 
+      it 'accepts an empty condition' do
+        check_empty(if_unless, 'if')
+        check_empty(if_unless, 'unless')
+        check_empty(while_until, 'while')
+        check_empty(while_until, 'until')
+      end
+
+      it 'accepts modifier while' do
+        inspect_source(while_until, ['ala while bala'])
+        expect(while_until.offences).to be_empty
+      end
+
+      it 'accepts modifier until' do
+        inspect_source(while_until, ['ala until bala'])
+        expect(while_until.offences).to be_empty
+      end
+
+      def check_empty(cop, keyword)
+        inspect_source(cop, ["#{keyword} cond",
+                             'end'])
+        expect(cop.offences).to be_empty
+      end
+
       def check_really_short(cop, keyword)
         inspect_source(cop, ["#{keyword} a",
                              '  b',

data/spec/rubocop/cops/lambda_spec.rb

@@ -0,0 +1,43 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+module Rubocop
+  module Cop
+    describe Lambda do
+      let(:lambda) { Lambda.new }
+
+      it 'registers an offence for an old single-line lambda call' do
+        inspect_source(lambda, ['f = lambda { |x| x }'])
+        expect(lambda.offences.size).to eq(1)
+        expect(lambda.messages).to eq([Lambda::SINGLE_MSG])
+      end
+
+      it 'accepts the new lambda literal with single-line body' do
+        inspect_source(lambda, ['lambda = ->(x) { x }',
+                                   'lambda.(1)'])
+        expect(lambda.offences).to be_empty
+      end
+
+      it 'registers an offence for a new multi-line lambda call' do
+        inspect_source(lambda, ['f = ->(x) do',
+                                        '  x',
+                                        'end'])
+        expect(lambda.offences.size).to eq(1)
+        expect(lambda.messages).to eq([Lambda::MULTI_MSG])
+      end
+
+      it 'accepts the old lambda syntax with multi-line body' do
+        inspect_source(lambda, ['l = lambda do |x|',
+                                        '  x',
+                                        'end'])
+        expect(lambda.offences).to be_empty
+      end
+
+      it 'accepts the lambda call outside of block' do
+        inspect_source(lambda, ['l = lambda.test'])
+        expect(lambda.offences).to be_empty
+      end
+    end
+  end
+end

data/spec/rubocop/cops/proc_spec.rb

@@ -0,0 +1,26 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+module Rubocop
+  module Cop
+    describe Proc do
+      let(:proc) { Proc.new }
+
+      it 'registers an offence for a Proc.new call' do
+        inspect_source(proc, ['f = Proc.new { |x| puts x }'])
+        expect(proc.offences.size).to eq(1)
+      end
+
+      it 'accepts the proc method' do
+        inspect_source(proc, ['f = proc { |x| puts x }'])
+        expect(proc.offences).to be_empty
+      end
+
+      it 'accepts the Proc.new call outside of block' do
+        inspect_source(proc, ['p = Proc.new'])
+        expect(proc.offences).to be_empty
+      end
+    end
+  end
+end

data/spec/rubocop/cops/space_inside_hash_literal_braces_spec.rb

@@ -74,6 +74,13 @@ module Rubocop
         inspect_source(sihlb, ['x(a: b.c)'])
         expect(sihlb.offences).to be_empty
       end
+
+      it 'can handle interpolation in a braceless hash literal' do
+        # A tricky special case where the closing brace of the
+        # interpolation risks getting confused for a hash literal brace.
+        inspect_source(sihlb, ['f(get: "#{x}")'])
+        expect(sihlb.offences).to be_empty
+      end
     end
   end
 end

data/spec/rubocop/cops/string_literals_spec.rb

@@ -9,9 +9,7 @@ module Rubocop
 
       it 'registers an offence for double quotes when single quotes suffice' do
         inspect_source(sl, ['s = "abc"'])
-        expect(sl.offences.map(&:message)).to eq(
-          ["Prefer single-quoted strings when you don't need string " +
-           'interpolation or special symbols.'])
+        expect(sl.offences.size).to eq(1)
       end
 
       it 'accepts double quotes when they are needed' do
@@ -22,7 +20,12 @@ module Rubocop
                'e = "#$test"',
                'f = "#@@test"']
         inspect_source(sl, src)
-        expect(sl.offences.map(&:message)).to be_empty
+        expect(sl.offences).to be_empty
+      end
+
+      it 'accepts double quotes at the start of regexp literals' do
+        inspect_source(sl, ['s = /"((?:[^\\"]|\\.)*)"/'])
+        expect(sl.offences).to be_empty
       end
 
       it 'accepts double quotes with some other special symbols' do
@@ -31,7 +34,7 @@ module Rubocop
         # http://www.ruby-doc.org/docs/ProgrammingRuby/html/language.html
         src = ['g = "\xf9"']
         inspect_source(sl, src)
-        expect(sl.offences.map(&:message)).to be_empty
+        expect(sl.offences).to be_empty
       end
 
       it 'can handle double quotes within embedded expression' do
@@ -39,9 +42,17 @@ module Rubocop
         pending do
           src = ['"#{"A"}"']
           inspect_source(sl, src)
-          expect(sl.offences.map(&:message)).to be_empty
+          expect(sl.offences).to be_empty
         end
       end
+
+      it 'can handle a built-in constant parsed as string' do
+        # Parser will produce str nodes for constants such as __FILE__.
+        src = ['if __FILE__ == $PROGRAM_NAME',
+               'end']
+        inspect_source(sl, src)
+        expect(sl.offences).to be_empty
+      end
     end
   end
 end

data/spec/rubocop/cops/trivial_accessors_spec.rb

@@ -324,6 +324,14 @@ module Rubocop
         expect(trivial_accessors_finder.offences).to be_empty
       end
 
-    end # describe TrivialAccessors
-  end # Cop
-end # Rubocop
+      it 'accepts an initialize method looking like a writer' do
+        inspect_source(trivial_accessors_finder,
+                       [' def initialize(value)',
+                        '   @top = value',
+                        ' end'])
+        expect(trivial_accessors_finder.offences).to be_empty
+      end
+
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -32,7 +32,7 @@ module ExitCodeMatchers
       rescue SystemExit => e
         actual = e.status
       end
-      actual and actual == code
+      actual && actual == code
     end
     failure_message_for_should do |block|
       "expected block to call exit(#{code}) but exit" +

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop
 version: !ruby/object:Gem::Version
-  version: 0.8.0
+  version: 0.8.1
 platform: ruby
 authors:
 - Bozhidar Batsov
@@ -28,16 +28,22 @@ dependencies:
   name: parser
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: 2.0.0.beta1
+    - - <=
       - !ruby/object:Gem::Version
-        version: 2.0.0.beta2
+        version: 2.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: 2.0.0.beta1
+    - - <=
       - !ruby/object:Gem::Version
-        version: 2.0.0.beta2
+        version: 2.0.0
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -173,13 +179,13 @@ files:
 - lib/rubocop/cop/handle_exceptions.rb
 - lib/rubocop/cop/hash_syntax.rb
 - lib/rubocop/cop/if_then_else.rb
+- lib/rubocop/cop/lambda.rb
 - lib/rubocop/cop/leading_comment_space.rb
 - lib/rubocop/cop/line_continuation.rb
 - lib/rubocop/cop/line_length.rb
 - lib/rubocop/cop/loop.rb
 - lib/rubocop/cop/method_and_variable_snake_case.rb
 - lib/rubocop/cop/method_length.rb
-- lib/rubocop/cop/new_lambda_literal.rb
 - lib/rubocop/cop/not.rb
 - lib/rubocop/cop/numeric_literals.rb
 - lib/rubocop/cop/offence.rb
@@ -187,6 +193,7 @@ files:
 - lib/rubocop/cop/parameter_lists.rb
 - lib/rubocop/cop/parentheses_around_condition.rb
 - lib/rubocop/cop/percent_r.rb
+- lib/rubocop/cop/proc.rb
 - lib/rubocop/cop/reduce_arguments.rb
 - lib/rubocop/cop/rescue_exception.rb
 - lib/rubocop/cop/rescue_modifier.rb
@@ -255,6 +262,7 @@ files:
 - spec/rubocop/cops/handle_exceptions_spec.rb
 - spec/rubocop/cops/hash_syntax_spec.rb
 - spec/rubocop/cops/if_with_semicolon_spec.rb
+- spec/rubocop/cops/lambda_spec.rb
 - spec/rubocop/cops/leading_comment_space_spec.rb
 - spec/rubocop/cops/line_continuation_spec.rb
 - spec/rubocop/cops/line_length_spec.rb
@@ -262,7 +270,6 @@ files:
 - spec/rubocop/cops/method_and_variable_snake_case_spec.rb
 - spec/rubocop/cops/method_length_spec.rb
 - spec/rubocop/cops/multiline_if_then_spec.rb
-- spec/rubocop/cops/new_lambda_literal_spec.rb
 - spec/rubocop/cops/not_spec.rb
 - spec/rubocop/cops/numeric_literals_spec.rb
 - spec/rubocop/cops/offence_spec.rb
@@ -271,6 +278,7 @@ files:
 - spec/rubocop/cops/parameter_lists_spec.rb
 - spec/rubocop/cops/parentheses_around_condition_spec.rb
 - spec/rubocop/cops/percent_r_spec.rb
+- spec/rubocop/cops/proc_spec.rb
 - spec/rubocop/cops/reduce_arguments_spec.rb
 - spec/rubocop/cops/rescue_exception_spec.rb
 - spec/rubocop/cops/rescue_modifier_spec.rb
@@ -370,6 +378,7 @@ test_files:
 - spec/rubocop/cops/handle_exceptions_spec.rb
 - spec/rubocop/cops/hash_syntax_spec.rb
 - spec/rubocop/cops/if_with_semicolon_spec.rb
+- spec/rubocop/cops/lambda_spec.rb
 - spec/rubocop/cops/leading_comment_space_spec.rb
 - spec/rubocop/cops/line_continuation_spec.rb
 - spec/rubocop/cops/line_length_spec.rb
@@ -377,7 +386,6 @@ test_files:
 - spec/rubocop/cops/method_and_variable_snake_case_spec.rb
 - spec/rubocop/cops/method_length_spec.rb
 - spec/rubocop/cops/multiline_if_then_spec.rb
-- spec/rubocop/cops/new_lambda_literal_spec.rb
 - spec/rubocop/cops/not_spec.rb
 - spec/rubocop/cops/numeric_literals_spec.rb
 - spec/rubocop/cops/offence_spec.rb
@@ -386,6 +394,7 @@ test_files:
 - spec/rubocop/cops/parameter_lists_spec.rb
 - spec/rubocop/cops/parentheses_around_condition_spec.rb
 - spec/rubocop/cops/percent_r_spec.rb
+- spec/rubocop/cops/proc_spec.rb
 - spec/rubocop/cops/reduce_arguments_spec.rb
 - spec/rubocop/cops/rescue_exception_spec.rb
 - spec/rubocop/cops/rescue_modifier_spec.rb

data/lib/rubocop/cop/new_lambda_literal.rb

@@ -1,19 +0,0 @@
-# encoding: utf-8
-
-module Rubocop
-  module Cop
-    class NewLambdaLiteral < Cop
-      MSG = 'Use the new lambda literal syntax ->(params) {...}.'
-
-      TARGET = s(:send, nil, :lambda)
-
-      def on_send(node)
-        if node == TARGET && node.loc.selector.source != '->'
-          add_offence(:convention, node.loc.line, MSG)
-        end
-
-        super
-      end
-    end
-  end
-end

data/spec/rubocop/cops/new_lambda_literal_spec.rb

@@ -1,22 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-module Rubocop
-  module Cop
-    describe NewLambdaLiteral do
-      let(:lambda_literal) { NewLambdaLiteral.new }
-
-      it 'registers an offence for an old lambda call' do
-        inspect_source(lambda_literal, ['f = lambda { |x| x }'])
-        expect(lambda_literal.offences.size).to eq(1)
-      end
-
-      it 'accepts the new lambda literal' do
-        inspect_source(lambda_literal, ['lambda = ->(x) { x }',
-                                   'lambda.(1)'])
-        expect(lambda_literal.offences).to be_empty
-      end
-    end
-  end
-end