rubocop 0.79.0 → 0.83.0

data/lib/rubocop/processed_source.rb

@@ -163,7 +163,7 @@ module RuboCop
         ast, comments, tokens = parser.tokenize(@buffer)
 
         ast.respond_to?(:complete!) && ast.complete!
-      rescue Parser::SyntaxError # rubocop:disable Lint/SuppressedException
+      rescue Parser::SyntaxError
         # All errors are in diagnostics. No need to handle exception.
       end
 
@@ -175,9 +175,6 @@ module RuboCop
     # rubocop:disable Metrics/MethodLength
     def parser_class(ruby_version)
       case ruby_version
-      when 2.3
-        require 'parser/ruby23'
-        Parser::Ruby23
       when 2.4
         require 'parser/ruby24'
         Parser::Ruby24

data/lib/rubocop/rspec/cop_helper.rb

@@ -6,7 +6,7 @@ require 'tempfile'
 module CopHelper
   extend RSpec::SharedContext
 
-  let(:ruby_version) { 2.3 }
+  let(:ruby_version) { 2.4 }
   let(:rails_version) { false }
 
   def inspect_source_file(source)

data/lib/rubocop/rspec/expect_offense.rb

@@ -153,7 +153,7 @@ module RuboCop
           annotations = []
 
           annotated_source.each_line do |source_line|
-            if source_line =~ ANNOTATION_PATTERN
+            if ANNOTATION_PATTERN.match?(source_line)
               annotations << [source.size, source_line]
             else
               source << source_line

data/lib/rubocop/rspec/shared_contexts.rb

@@ -74,10 +74,6 @@ RSpec.shared_context 'mock console output' do
   end
 end
 
-RSpec.shared_context 'ruby 2.3', :ruby23 do
-  let(:ruby_version) { 2.3 }
-end
-
 RSpec.shared_context 'ruby 2.4', :ruby24 do
   let(:ruby_version) { 2.4 }
 end

data/lib/rubocop/runner.rb

@@ -61,7 +61,12 @@ module RuboCop
 
     def find_target_files(paths)
       target_finder = TargetFinder.new(@config_store, @options)
-      target_files = target_finder.find(paths)
+      mode = if @options[:only_recognized_file_types]
+               :only_recognized_file_types
+             else
+               :all_file_types
+             end
+      target_files = target_finder.find(paths, mode)
       target_files.each(&:freeze).freeze
     end
 
@@ -314,7 +319,7 @@ module RuboCop
 
         cop_classes.reject! { |c| c.match?(@options[:except]) }
 
-        Cop::Registry.new(cop_classes)
+        Cop::Registry.new(cop_classes, @options)
       end
     end
 

data/lib/rubocop/target_finder.rb

@@ -27,7 +27,7 @@ module RuboCop
     # (if any). If args is empty, recursively find all Ruby source
     # files under the current directory
     # @return [Array] array of file paths
-    def find(args)
+    def find(args, mode)
       return target_files_in_dir if args.empty?
 
       files = []
@@ -36,7 +36,7 @@ module RuboCop
         files += if File.directory?(arg)
                    target_files_in_dir(arg.chomp(File::SEPARATOR))
                  else
-                   process_explicit_path(arg)
+                   process_explicit_path(arg, mode)
                  end
       end
 
@@ -169,10 +169,12 @@ module RuboCop
       ruby_file?(file) || configured_include?(file)
     end
 
-    def process_explicit_path(path)
+    def process_explicit_path(path, mode)
       files = path.include?('*') ? Dir[path] : [path]
 
-      files.select! { |file| included_file?(file) }
+      if mode == :only_recognized_file_types || force_exclusion?
+        files.select! { |file| included_file?(file) }
+      end
 
       return files unless force_exclusion?
 

data/lib/rubocop/target_ruby.rb

@@ -3,11 +3,11 @@
 module RuboCop
   # The kind of Ruby that code inspected by RuboCop is written in.
   class TargetRuby
-    KNOWN_RUBIES = [2.3, 2.4, 2.5, 2.6, 2.7].freeze
+    KNOWN_RUBIES = [2.4, 2.5, 2.6, 2.7].freeze
     DEFAULT_VERSION = KNOWN_RUBIES.first
 
     OBSOLETE_RUBIES = {
-      1.9 => '0.50', 2.0 => '0.50', 2.1 => '0.58', 2.2 => '0.69'
+      1.9 => '0.50', 2.0 => '0.50', 2.1 => '0.58', 2.2 => '0.69', 2.3 => '0.82'
     }.freeze
     private_constant :KNOWN_RUBIES, :OBSOLETE_RUBIES
 

data/lib/rubocop/version.rb

@@ -3,7 +3,7 @@
 module RuboCop
   # This module holds the RuboCop version information.
   module Version
-    STRING = '0.79.0'
+    STRING = '0.83.0'
 
     MSG = '%<version>s (using Parser %<parser_version>s, running on ' \
           '%<ruby_engine>s %<ruby_version>s %<ruby_platform>s)'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop
 version: !ruby/object:Gem::Version
-  version: 0.79.0
+  version: 0.83.0
 platform: ruby
 authors:
 - Bozhidar Batsov
@@ -10,22 +10,8 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-01-06 00:00:00.000000000 Z
+date: 2020-05-11 00:00:00.000000000 Z
 dependencies:
-- !ruby/object:Gem::Dependency
-  name: jaro_winkler
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 1.5.1
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 1.5.1
 - !ruby/object:Gem::Dependency
   name: parallel
   requirement: !ruby/object:Gem::Requirement
@@ -74,6 +60,20 @@ dependencies:
     - - "<"
       - !ruby/object:Gem::Version
         version: '4.0'
+- !ruby/object:Gem::Dependency
+  name: rexml
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: ruby-progressbar
   requirement: !ruby/object:Gem::Requirement
@@ -97,7 +97,7 @@ dependencies:
         version: 1.4.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: '1.7'
+        version: '2.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -107,7 +107,7 @@ dependencies:
         version: 1.4.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: '1.7'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -156,6 +156,7 @@ files:
 - lib/rubocop/ast/node/array_node.rb
 - lib/rubocop/ast/node/block_node.rb
 - lib/rubocop/ast/node/break_node.rb
+- lib/rubocop/ast/node/case_match_node.rb
 - lib/rubocop/ast/node/case_node.rb
 - lib/rubocop/ast/node/class_node.rb
 - lib/rubocop/ast/node/def_node.rb
@@ -278,6 +279,7 @@ files:
 - lib/rubocop/cop/layout/empty_lines.rb
 - lib/rubocop/cop/layout/empty_lines_around_access_modifier.rb
 - lib/rubocop/cop/layout/empty_lines_around_arguments.rb
+- lib/rubocop/cop/layout/empty_lines_around_attribute_accessor.rb
 - lib/rubocop/cop/layout/empty_lines_around_begin_body.rb
 - lib/rubocop/cop/layout/empty_lines_around_block_body.rb
 - lib/rubocop/cop/layout/empty_lines_around_class_body.rb
@@ -299,6 +301,7 @@ files:
 - lib/rubocop/cop/layout/heredoc_argument_closing_parenthesis.rb
 - lib/rubocop/cop/layout/heredoc_indentation.rb
 - lib/rubocop/cop/layout/indentation_consistency.rb
+- lib/rubocop/cop/layout/indentation_style.rb
 - lib/rubocop/cop/layout/indentation_width.rb
 - lib/rubocop/cop/layout/initial_indentation.rb
 - lib/rubocop/cop/layout/leading_comment_space.rb
@@ -325,6 +328,7 @@ files:
 - lib/rubocop/cop/layout/space_around_block_parameters.rb
 - lib/rubocop/cop/layout/space_around_equals_in_parameter_default.rb
 - lib/rubocop/cop/layout/space_around_keyword.rb
+- lib/rubocop/cop/layout/space_around_method_call_operator.rb
 - lib/rubocop/cop/layout/space_around_operators.rb
 - lib/rubocop/cop/layout/space_before_block_braces.rb
 - lib/rubocop/cop/layout/space_before_comma.rb
@@ -341,7 +345,6 @@ files:
 - lib/rubocop/cop/layout/space_inside_range_literal.rb
 - lib/rubocop/cop/layout/space_inside_reference_brackets.rb
 - lib/rubocop/cop/layout/space_inside_string_interpolation.rb
-- lib/rubocop/cop/layout/tab.rb
 - lib/rubocop/cop/layout/trailing_empty_lines.rb
 - lib/rubocop/cop/layout/trailing_whitespace.rb
 - lib/rubocop/cop/lint/ambiguous_block_association.rb
@@ -363,7 +366,6 @@ files:
 - lib/rubocop/cop/lint/empty_expression.rb
 - lib/rubocop/cop/lint/empty_interpolation.rb
 - lib/rubocop/cop/lint/empty_when.rb
-- lib/rubocop/cop/lint/end_in_method.rb
 - lib/rubocop/cop/lint/ensure_return.rb
 - lib/rubocop/cop/lint/erb_new_arguments.rb
 - lib/rubocop/cop/lint/flip_flop.rb
@@ -389,6 +391,7 @@ files:
 - lib/rubocop/cop/lint/parentheses_as_grouped_expression.rb
 - lib/rubocop/cop/lint/percent_string_array.rb
 - lib/rubocop/cop/lint/percent_symbol_array.rb
+- lib/rubocop/cop/lint/raise_exception.rb
 - lib/rubocop/cop/lint/rand_one.rb
 - lib/rubocop/cop/lint/redundant_cop_disable_directive.rb
 - lib/rubocop/cop/lint/redundant_cop_enable_directive.rb
@@ -410,6 +413,7 @@ files:
 - lib/rubocop/cop/lint/shadowed_argument.rb
 - lib/rubocop/cop/lint/shadowed_exception.rb
 - lib/rubocop/cop/lint/shadowing_outer_local_variable.rb
+- lib/rubocop/cop/lint/struct_new_override.rb
 - lib/rubocop/cop/lint/suppressed_exception.rb
 - lib/rubocop/cop/lint/syntax.rb
 - lib/rubocop/cop/lint/to_json.rb
@@ -461,6 +465,7 @@ files:
 - lib/rubocop/cop/mixin/first_element_line_break.rb
 - lib/rubocop/cop/mixin/frozen_string_literal.rb
 - lib/rubocop/cop/mixin/hash_alignment_styles.rb
+- lib/rubocop/cop/mixin/hash_transform_method.rb
 - lib/rubocop/cop/mixin/heredoc.rb
 - lib/rubocop/cop/mixin/ignored_methods.rb
 - lib/rubocop/cop/mixin/ignored_pattern.rb
@@ -536,7 +541,6 @@ files:
 - lib/rubocop/cop/style/begin_block.rb
 - lib/rubocop/cop/style/block_comments.rb
 - lib/rubocop/cop/style/block_delimiters.rb
-- lib/rubocop/cop/style/braces_around_hash_parameters.rb
 - lib/rubocop/cop/style/case_equality.rb
 - lib/rubocop/cop/style/character_literal.rb
 - lib/rubocop/cop/style/class_and_module_children.rb
@@ -555,6 +559,7 @@ files:
 - lib/rubocop/cop/style/date_time.rb
 - lib/rubocop/cop/style/def_with_parentheses.rb
 - lib/rubocop/cop/style/dir.rb
+- lib/rubocop/cop/style/disable_cops_within_source_code_directive.rb
 - lib/rubocop/cop/style/documentation.rb
 - lib/rubocop/cop/style/documentation_method.rb
 - lib/rubocop/cop/style/double_cop_disable_directive.rb
@@ -572,6 +577,7 @@ files:
 - lib/rubocop/cop/style/eval_with_location.rb
 - lib/rubocop/cop/style/even_odd.rb
 - lib/rubocop/cop/style/expand_path_arguments.rb
+- lib/rubocop/cop/style/exponential_notation.rb
 - lib/rubocop/cop/style/float_division.rb
 - lib/rubocop/cop/style/for.rb
 - lib/rubocop/cop/style/format_string.rb
@@ -579,7 +585,10 @@ files:
 - lib/rubocop/cop/style/frozen_string_literal_comment.rb
 - lib/rubocop/cop/style/global_vars.rb
 - lib/rubocop/cop/style/guard_clause.rb
+- lib/rubocop/cop/style/hash_each_methods.rb
 - lib/rubocop/cop/style/hash_syntax.rb
+- lib/rubocop/cop/style/hash_transform_keys.rb
+- lib/rubocop/cop/style/hash_transform_values.rb
 - lib/rubocop/cop/style/identical_conditional_branches.rb
 - lib/rubocop/cop/style/if_inside_else.rb
 - lib/rubocop/cop/style/if_unless_modifier.rb
@@ -666,6 +675,7 @@ files:
 - lib/rubocop/cop/style/signal_exception.rb
 - lib/rubocop/cop/style/single_line_block_params.rb
 - lib/rubocop/cop/style/single_line_methods.rb
+- lib/rubocop/cop/style/slicing_with_range.rb
 - lib/rubocop/cop/style/special_global_vars.rb
 - lib/rubocop/cop/style/stabby_lambda_parentheses.rb
 - lib/rubocop/cop/style/stderr_puts.rb
@@ -684,6 +694,7 @@ files:
 - lib/rubocop/cop/style/trailing_body_on_module.rb
 - lib/rubocop/cop/style/trailing_comma_in_arguments.rb
 - lib/rubocop/cop/style/trailing_comma_in_array_literal.rb
+- lib/rubocop/cop/style/trailing_comma_in_block_args.rb
 - lib/rubocop/cop/style/trailing_comma_in_hash_literal.rb
 - lib/rubocop/cop/style/trailing_method_end_statement.rb
 - lib/rubocop/cop/style/trailing_underscore_variable.rb
@@ -716,13 +727,13 @@ files:
 - lib/rubocop/formatter/clang_style_formatter.rb
 - lib/rubocop/formatter/colorizable.rb
 - lib/rubocop/formatter/disabled_config_formatter.rb
-- lib/rubocop/formatter/disabled_lines_formatter.rb
 - lib/rubocop/formatter/emacs_style_formatter.rb
 - lib/rubocop/formatter/file_list_formatter.rb
 - lib/rubocop/formatter/formatter_set.rb
 - lib/rubocop/formatter/fuubar_style_formatter.rb
 - lib/rubocop/formatter/html_formatter.rb
 - lib/rubocop/formatter/json_formatter.rb
+- lib/rubocop/formatter/junit_formatter.rb
 - lib/rubocop/formatter/offense_count_formatter.rb
 - lib/rubocop/formatter/pacman_formatter.rb
 - lib/rubocop/formatter/progress_formatter.rb
@@ -748,7 +759,6 @@ files:
 - lib/rubocop/rspec/support.rb
 - lib/rubocop/runner.rb
 - lib/rubocop/string_interpreter.rb
-- lib/rubocop/string_util.rb
 - lib/rubocop/target_finder.rb
 - lib/rubocop/target_ruby.rb
 - lib/rubocop/token.rb
@@ -772,14 +782,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.3.0
+      version: 2.4.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: Automatic Ruby code style checking tool.

data/lib/rubocop/cop/lint/end_in_method.rb

@@ -1,40 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    module Lint
-      # This cop checks for END blocks in method definitions.
-      #
-      # @example
-      #
-      #   # bad
-      #
-      #   def some_method
-      #     END { do_something }
-      #   end
-      #
-      # @example
-      #
-      #   # good
-      #
-      #   def some_method
-      #     at_exit { do_something }
-      #   end
-      #
-      # @example
-      #
-      #   # good
-      #
-      #   # outside defs
-      #   END { do_something }
-      class EndInMethod < Cop
-        MSG = '`END` found in method definition. Use `at_exit` instead.'
-
-        def on_postexe(node)
-          inside_of_method = node.each_ancestor(:def, :defs).count.nonzero?
-          add_offense(node, location: :keyword) if inside_of_method
-        end
-      end
-    end
-  end
-end

data/lib/rubocop/cop/style/braces_around_hash_parameters.rb

@@ -1,209 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    module Style
-      # This cop checks for braces around the last parameter in a method call
-      # if the last parameter is a hash.
-      # It supports `braces`, `no_braces` and `context_dependent` styles.
-      #
-      # @example EnforcedStyle: braces
-      #   # The `braces` style enforces braces around all method
-      #   # parameters that are hashes.
-      #
-      #   # bad
-      #   some_method(x, y, a: 1, b: 2)
-      #
-      #   # good
-      #   some_method(x, y, {a: 1, b: 2})
-      #
-      # @example EnforcedStyle: no_braces (default)
-      #   # The `no_braces` style checks that the last parameter doesn't
-      #   # have braces around it.
-      #
-      #   # bad
-      #   some_method(x, y, {a: 1, b: 2})
-      #
-      #   # good
-      #   some_method(x, y, a: 1, b: 2)
-      #
-      # @example EnforcedStyle: context_dependent
-      #   # The `context_dependent` style checks that the last parameter
-      #   # doesn't have braces around it, but requires braces if the
-      #   # second to last parameter is also a hash literal.
-      #
-      #   # bad
-      #   some_method(x, y, {a: 1, b: 2})
-      #   some_method(x, y, {a: 1, b: 2}, a: 1, b: 2)
-      #
-      #   # good
-      #   some_method(x, y, a: 1, b: 2)
-      #   some_method(x, y, {a: 1, b: 2}, {a: 1, b: 2})
-      class BracesAroundHashParameters < Cop
-        include ConfigurableEnforcedStyle
-        include RangeHelp
-
-        MSG = '%<type>s curly braces around a hash parameter.'
-
-        def on_send(node)
-          return if node.assignment_method? || node.operator_method?
-
-          return unless node.arguments? && node.last_argument.hash_type? &&
-                        !node.last_argument.empty?
-
-          check(node.last_argument, node.arguments)
-        end
-        alias on_csend on_send
-
-        def autocorrect(send_node)
-          hash_node = send_node.last_argument
-
-          lambda do |corrector|
-            if hash_node.braces?
-              remove_braces_with_whitespace(corrector,
-                                            hash_node,
-                                            extra_space(hash_node))
-            else
-              add_braces(corrector, hash_node)
-            end
-          end
-        end
-
-        private
-
-        def check(arg, args)
-          case style
-          when :braces
-            check_braces(arg)
-          when :no_braces
-            check_no_braces(arg)
-          when :context_dependent
-            check_context_dependent(arg, args)
-          end
-        end
-
-        def check_braces(arg)
-          add_arg_offense(arg, :missing) unless arg.braces?
-        end
-
-        def check_no_braces(arg)
-          return unless arg.braces? && !braces_needed_for_semantics?(arg)
-
-          add_arg_offense(arg, :redundant)
-        end
-
-        def check_context_dependent(arg, args)
-          braces_around_second_from_end = args.size > 1 && args[-2].hash_type?
-
-          if arg.braces?
-            unless braces_around_second_from_end ||
-                   braces_needed_for_semantics?(arg)
-              add_arg_offense(arg, :redundant)
-            end
-          elsif braces_around_second_from_end
-            add_arg_offense(arg, :missing)
-          end
-        end
-
-        # Returns true if there's block inside the braces of the given hash arg
-        # and that block uses do..end. The reason for wanting to check this is
-        # that the do..end could bind to a different method invocation if the
-        # hash braces were removed.
-        def braces_needed_for_semantics?(arg)
-          arg.each_pair do |_key, value|
-            return true if value.block_type? && !value.braces?
-          end
-          false
-        end
-
-        def add_arg_offense(arg, type)
-          add_offense(arg.parent, location: arg.source_range,
-                                  message: format(MSG,
-                                                  type: type.to_s.capitalize))
-        end
-
-        def extra_space(hash_node)
-          {
-            newlines: extra_left_space?(hash_node) &&
-              extra_right_space?(hash_node),
-            left: extra_left_space?(hash_node),
-            right: extra_right_space?(hash_node)
-          }
-        end
-
-        def extra_left_space?(hash_node)
-          @extra_left_space ||= begin
-            top_line = hash_node.source_range.source_line
-            top_line.delete(' ') == '{'
-          end
-        end
-
-        def extra_right_space?(hash_node)
-          @extra_right_space ||= begin
-            bottom_line_number = hash_node.source_range.last_line
-            bottom_line = processed_source.lines[bottom_line_number - 1]
-            bottom_line.delete(' ') == '}'
-          end
-        end
-
-        def remove_braces_with_whitespace(corrector, node, space)
-          loc = node.loc
-
-          if node.multiline?
-            remove_braces_with_range(corrector,
-                                     left_whole_line_range(loc.begin),
-                                     right_whole_line_range(loc.end))
-          else
-            remove_braces_with_range(corrector,
-                                     left_brace_and_space(loc.begin, space),
-                                     right_brace_and_space(loc.end, space))
-          end
-        end
-
-        def remove_braces_with_range(corrector, left_range, right_range)
-          corrector.remove(left_range)
-          corrector.remove(right_range)
-        end
-
-        def left_whole_line_range(loc_begin)
-          if range_by_whole_lines(loc_begin).source.strip == '{'
-            range_by_whole_lines(loc_begin, include_final_newline: true)
-          else
-            loc_begin
-          end
-        end
-
-        def right_whole_line_range(loc_end)
-          if range_by_whole_lines(loc_end).source.strip =~ /\A}\s*,?\z/
-            range_by_whole_lines(loc_end, include_final_newline: true)
-          else
-            loc_end
-          end
-        end
-
-        def left_brace_and_space(loc_begin, space)
-          range_with_surrounding_space(range: loc_begin,
-                                       side: :right,
-                                       newlines: space[:newlines],
-                                       whitespace: space[:left])
-        end
-
-        def right_brace_and_space(loc_end, space)
-          brace_and_space =
-            range_with_surrounding_space(
-              range: loc_end,
-              side: :left,
-              newlines: space[:newlines],
-              whitespace: space[:right]
-            )
-          range_with_surrounding_comma(brace_and_space, :left)
-        end
-
-        def add_braces(corrector, node)
-          corrector.insert_before(node.source_range, '{')
-          corrector.insert_after(node.source_range, '}')
-        end
-      end
-    end
-  end
-end