rubocop 0.78.0 → 1.13.0

data/lib/rubocop/cop/layout/tab.rb

@@ -1,75 +0,0 @@
-# frozen_string_literal: true
-
-require 'set'
-
-module RuboCop
-  module Cop
-    module Layout
-      # This cop checks for tabs inside the source code.
-      #
-      # @example
-      #   # bad
-      #   # This example uses a tab to indent bar.
-      #   def foo
-      #     bar
-      #   end
-      #
-      #   # good
-      #   # This example uses spaces to indent bar.
-      #   def foo
-      #     bar
-      #   end
-      #
-      class Tab < Cop
-        include Alignment
-        include RangeHelp
-
-        MSG = 'Tab detected.'
-
-        def investigate(processed_source)
-          str_ranges = string_literal_ranges(processed_source.ast)
-
-          processed_source.lines.each.with_index(1) do |line, lineno|
-            match = line.match(/\t+/)
-            next unless match
-
-            range = source_range(processed_source.buffer,
-                                 lineno,
-                                 match.begin(0)...match.end(0))
-            next if in_string_literal?(str_ranges, range)
-
-            add_offense(range, location: range)
-          end
-        end
-
-        def autocorrect(range)
-          lambda do |corrector|
-            spaces = ' ' * configured_indentation_width
-            corrector.replace(range, range.source.gsub(/\t/, spaces))
-          end
-        end
-
-        private
-
-        def in_string_literal?(ranges, tabs_range)
-          ranges.any? { |range| range.contains?(tabs_range) }
-        end
-
-        def string_literal_ranges(ast)
-          # which lines start inside a string literal?
-          return [] if ast.nil?
-
-          ast.each_node(:str, :dstr).each_with_object(Set.new) do |str, ranges|
-            loc = str.location
-
-            if str.heredoc?
-              ranges << loc.heredoc_body
-            elsif loc.respond_to?(:begin) && loc.begin
-              ranges << loc.expression
-            end
-          end
-        end
-      end
-    end
-  end
-end

data/lib/rubocop/cop/lint/end_in_method.rb

@@ -1,40 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    module Lint
-      # This cop checks for END blocks in method definitions.
-      #
-      # @example
-      #
-      #   # bad
-      #
-      #   def some_method
-      #     END { do_something }
-      #   end
-      #
-      # @example
-      #
-      #   # good
-      #
-      #   def some_method
-      #     at_exit { do_something }
-      #   end
-      #
-      # @example
-      #
-      #   # good
-      #
-      #   # outside defs
-      #   END { do_something }
-      class EndInMethod < Cop
-        MSG = '`END` found in method definition. Use `at_exit` instead.'
-
-        def on_postexe(node)
-          inside_of_method = node.each_ancestor(:def, :defs).count.nonzero?
-          add_offense(node, location: :keyword) if inside_of_method
-        end
-      end
-    end
-  end
-end

data/lib/rubocop/cop/lint/useless_comparison.rb

@@ -1,28 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    module Lint
-      # This cop checks for comparison of something with itself.
-      #
-      # @example
-      #
-      #   # bad
-      #
-      #   x.top >= x.top
-      class UselessComparison < Cop
-        MSG = 'Comparison of something with itself detected.'
-        OPS = %w[== === != < > <= >= <=>].freeze
-
-        def_node_matcher :useless_comparison?,
-                         "(send $_match {:#{OPS.join(' :')}} $_match)"
-
-        def on_send(node)
-          return unless useless_comparison?(node)
-
-          add_offense(node, location: :selector)
-        end
-      end
-    end
-  end
-end

data/lib/rubocop/cop/mixin/classish_length.rb

@@ -1,37 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    # Common functionality for checking length of classes and modules.
-    module ClassishLength
-      include CodeLength
-
-      private
-
-      def code_length(node)
-        body_line_numbers = line_range(node).to_a[1...-1]
-
-        target_line_numbers = body_line_numbers -
-                              line_numbers_of_inner_nodes(node, :module, :class)
-
-        target_line_numbers.reduce(0) do |length, line_number|
-          source_line = processed_source[line_number]
-          next length if irrelevant_line(source_line)
-
-          length + 1
-        end
-      end
-
-      def line_numbers_of_inner_nodes(node, *types)
-        line_numbers = Set.new
-
-        node.each_descendant(*types) do |inner_node|
-          line_range = line_range(inner_node)
-          line_numbers.merge(line_range)
-        end
-
-        line_numbers.to_a
-      end
-    end
-  end
-end

data/lib/rubocop/cop/mixin/parser_diagnostic.rb

@@ -1,37 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    # Common functionality for cops which processes Parser's diagnostics.
-    # This mixin requires its user class to define `#relevant_diagnostic?`.
-    #
-    #     def relevant_diagnostic?(diagnostic)
-    #       diagnostic.reason == :my_interested_diagnostic_type
-    #     end
-    #
-    # If you want to use an alternative offense message rather than the one in
-    # Parser's diagnostic, define `#alternative_message`.
-    #
-    #     def alternative_message(diagnostic)
-    #       'My custom message'
-    #     end
-    module ParserDiagnostic
-      def investigate(processed_source)
-        processed_source.diagnostics.each do |d|
-          next unless relevant_diagnostic?(d)
-
-          message = if respond_to?(:alternative_message, true)
-                      alternative_message(d)
-                    else
-                      d.message.capitalize
-                    end
-
-          add_offense(nil,
-                      location: d.location,
-                      message: message,
-                      severity: d.level)
-        end
-      end
-    end
-  end
-end

data/lib/rubocop/cop/mixin/too_many_lines.rb

@@ -1,35 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    # Common functionality for checking for too many lines.
-    module TooManyLines
-      include ConfigurableMax
-      include CodeLength
-
-      MSG = '%<label>s has too many lines. [%<length>d/%<max>d]'
-
-      private
-
-      def message(length, max_length)
-        format(MSG, label: cop_label, length: length, max: max_length)
-      end
-
-      def code_length(node)
-        body = extract_body(node)
-        lines = body&.source&.lines || []
-
-        lines.count { |line| !irrelevant_line(line) }
-      end
-
-      def extract_body(node)
-        case node.type
-        when :block, :def, :defs
-          node.body
-        else
-          node
-        end
-      end
-    end
-  end
-end

data/lib/rubocop/cop/style/braces_around_hash_parameters.rb

@@ -1,209 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    module Style
-      # This cop checks for braces around the last parameter in a method call
-      # if the last parameter is a hash.
-      # It supports `braces`, `no_braces` and `context_dependent` styles.
-      #
-      # @example EnforcedStyle: braces
-      #   # The `braces` style enforces braces around all method
-      #   # parameters that are hashes.
-      #
-      #   # bad
-      #   some_method(x, y, a: 1, b: 2)
-      #
-      #   # good
-      #   some_method(x, y, {a: 1, b: 2})
-      #
-      # @example EnforcedStyle: no_braces (default)
-      #   # The `no_braces` style checks that the last parameter doesn't
-      #   # have braces around it.
-      #
-      #   # bad
-      #   some_method(x, y, {a: 1, b: 2})
-      #
-      #   # good
-      #   some_method(x, y, a: 1, b: 2)
-      #
-      # @example EnforcedStyle: context_dependent
-      #   # The `context_dependent` style checks that the last parameter
-      #   # doesn't have braces around it, but requires braces if the
-      #   # second to last parameter is also a hash literal.
-      #
-      #   # bad
-      #   some_method(x, y, {a: 1, b: 2})
-      #   some_method(x, y, {a: 1, b: 2}, a: 1, b: 2)
-      #
-      #   # good
-      #   some_method(x, y, a: 1, b: 2)
-      #   some_method(x, y, {a: 1, b: 2}, {a: 1, b: 2})
-      class BracesAroundHashParameters < Cop
-        include ConfigurableEnforcedStyle
-        include RangeHelp
-
-        MSG = '%<type>s curly braces around a hash parameter.'
-
-        def on_send(node)
-          return if node.assignment_method? || node.operator_method?
-
-          return unless node.arguments? && node.last_argument.hash_type? &&
-                        !node.last_argument.empty?
-
-          check(node.last_argument, node.arguments)
-        end
-        alias on_csend on_send
-
-        def autocorrect(send_node)
-          hash_node = send_node.last_argument
-
-          lambda do |corrector|
-            if hash_node.braces?
-              remove_braces_with_whitespace(corrector,
-                                            hash_node,
-                                            extra_space(hash_node))
-            else
-              add_braces(corrector, hash_node)
-            end
-          end
-        end
-
-        private
-
-        def check(arg, args)
-          case style
-          when :braces
-            check_braces(arg)
-          when :no_braces
-            check_no_braces(arg)
-          when :context_dependent
-            check_context_dependent(arg, args)
-          end
-        end
-
-        def check_braces(arg)
-          add_arg_offense(arg, :missing) unless arg.braces?
-        end
-
-        def check_no_braces(arg)
-          return unless arg.braces? && !braces_needed_for_semantics?(arg)
-
-          add_arg_offense(arg, :redundant)
-        end
-
-        def check_context_dependent(arg, args)
-          braces_around_second_from_end = args.size > 1 && args[-2].hash_type?
-
-          if arg.braces?
-            unless braces_around_second_from_end ||
-                   braces_needed_for_semantics?(arg)
-              add_arg_offense(arg, :redundant)
-            end
-          elsif braces_around_second_from_end
-            add_arg_offense(arg, :missing)
-          end
-        end
-
-        # Returns true if there's block inside the braces of the given hash arg
-        # and that block uses do..end. The reason for wanting to check this is
-        # that the do..end could bind to a different method invocation if the
-        # hash braces were removed.
-        def braces_needed_for_semantics?(arg)
-          arg.each_pair do |_key, value|
-            return true if value.block_type? && !value.braces?
-          end
-          false
-        end
-
-        def add_arg_offense(arg, type)
-          add_offense(arg.parent, location: arg.source_range,
-                                  message: format(MSG,
-                                                  type: type.to_s.capitalize))
-        end
-
-        def extra_space(hash_node)
-          {
-            newlines: extra_left_space?(hash_node) &&
-              extra_right_space?(hash_node),
-            left: extra_left_space?(hash_node),
-            right: extra_right_space?(hash_node)
-          }
-        end
-
-        def extra_left_space?(hash_node)
-          @extra_left_space ||= begin
-            top_line = hash_node.source_range.source_line
-            top_line.delete(' ') == '{'
-          end
-        end
-
-        def extra_right_space?(hash_node)
-          @extra_right_space ||= begin
-            bottom_line_number = hash_node.source_range.last_line
-            bottom_line = processed_source.lines[bottom_line_number - 1]
-            bottom_line.delete(' ') == '}'
-          end
-        end
-
-        def remove_braces_with_whitespace(corrector, node, space)
-          loc = node.loc
-
-          if node.multiline?
-            remove_braces_with_range(corrector,
-                                     left_whole_line_range(loc.begin),
-                                     right_whole_line_range(loc.end))
-          else
-            remove_braces_with_range(corrector,
-                                     left_brace_and_space(loc.begin, space),
-                                     right_brace_and_space(loc.end, space))
-          end
-        end
-
-        def remove_braces_with_range(corrector, left_range, right_range)
-          corrector.remove(left_range)
-          corrector.remove(right_range)
-        end
-
-        def left_whole_line_range(loc_begin)
-          if range_by_whole_lines(loc_begin).source.strip == '{'
-            range_by_whole_lines(loc_begin, include_final_newline: true)
-          else
-            loc_begin
-          end
-        end
-
-        def right_whole_line_range(loc_end)
-          if range_by_whole_lines(loc_end).source.strip =~ /\A}\s*,?\z/
-            range_by_whole_lines(loc_end, include_final_newline: true)
-          else
-            loc_end
-          end
-        end
-
-        def left_brace_and_space(loc_begin, space)
-          range_with_surrounding_space(range: loc_begin,
-                                       side: :right,
-                                       newlines: space[:newlines],
-                                       whitespace: space[:left])
-        end
-
-        def right_brace_and_space(loc_end, space)
-          brace_and_space =
-            range_with_surrounding_space(
-              range: loc_end,
-              side: :left,
-              newlines: space[:newlines],
-              whitespace: space[:right]
-            )
-          range_with_surrounding_comma(brace_and_space, :left)
-        end
-
-        def add_braces(corrector, node)
-          corrector.insert_before(node.source_range, '{')
-          corrector.insert_after(node.source_range, '}')
-        end
-      end
-    end
-  end
-end