rubocop 0.78.0 → 0.82.0

data/lib/rubocop.rb

@@ -37,12 +37,14 @@ require_relative 'rubocop/ast/node/args_node'
 require_relative 'rubocop/ast/node/array_node'
 require_relative 'rubocop/ast/node/block_node'
 require_relative 'rubocop/ast/node/break_node'
+require_relative 'rubocop/ast/node/case_match_node'
 require_relative 'rubocop/ast/node/case_node'
 require_relative 'rubocop/ast/node/class_node'
 require_relative 'rubocop/ast/node/def_node'
 require_relative 'rubocop/ast/node/defined_node'
 require_relative 'rubocop/ast/node/ensure_node'
 require_relative 'rubocop/ast/node/for_node'
+require_relative 'rubocop/ast/node/forward_args_node'
 require_relative 'rubocop/ast/node/float_node'
 require_relative 'rubocop/ast/node/hash_node'
 require_relative 'rubocop/ast/node/if_node'
@@ -119,6 +121,7 @@ require_relative 'rubocop/cop/mixin/enforce_superclass'
 require_relative 'rubocop/cop/mixin/first_element_line_break'
 require_relative 'rubocop/cop/mixin/frozen_string_literal'
 require_relative 'rubocop/cop/mixin/hash_alignment_styles'
+require_relative 'rubocop/cop/mixin/hash_transform_method'
 require_relative 'rubocop/cop/mixin/ignored_pattern'
 require_relative 'rubocop/cop/mixin/ignored_methods'
 require_relative 'rubocop/cop/mixin/integer_node'
@@ -232,6 +235,7 @@ require_relative 'rubocop/cop/layout/hash_alignment'
 require_relative 'rubocop/cop/layout/heredoc_argument_closing_parenthesis'
 require_relative 'rubocop/cop/layout/heredoc_indentation'
 require_relative 'rubocop/cop/layout/indentation_consistency'
+require_relative 'rubocop/cop/layout/indentation_style'
 require_relative 'rubocop/cop/layout/indentation_width'
 require_relative 'rubocop/cop/layout/initial_indentation'
 require_relative 'rubocop/cop/layout/leading_comment_space'
@@ -258,6 +262,7 @@ require_relative 'rubocop/cop/layout/space_after_semicolon'
 require_relative 'rubocop/cop/layout/space_around_block_parameters'
 require_relative 'rubocop/cop/layout/space_around_equals_in_parameter_default'
 require_relative 'rubocop/cop/layout/space_around_keyword'
+require_relative 'rubocop/cop/layout/space_around_method_call_operator'
 require_relative 'rubocop/cop/layout/space_around_operators'
 require_relative 'rubocop/cop/layout/space_before_block_braces'
 require_relative 'rubocop/cop/layout/space_before_comma'
@@ -274,7 +279,6 @@ require_relative 'rubocop/cop/layout/space_inside_percent_literal_delimiters'
 require_relative 'rubocop/cop/layout/space_inside_range_literal'
 require_relative 'rubocop/cop/layout/space_inside_reference_brackets'
 require_relative 'rubocop/cop/layout/space_inside_string_interpolation'
-require_relative 'rubocop/cop/layout/tab'
 require_relative 'rubocop/cop/layout/trailing_empty_lines'
 require_relative 'rubocop/cop/layout/trailing_whitespace'
 
@@ -297,7 +301,6 @@ require_relative 'rubocop/cop/lint/empty_ensure'
 require_relative 'rubocop/cop/lint/empty_expression'
 require_relative 'rubocop/cop/lint/empty_interpolation'
 require_relative 'rubocop/cop/lint/empty_when'
-require_relative 'rubocop/cop/lint/end_in_method'
 require_relative 'rubocop/cop/lint/ensure_return'
 require_relative 'rubocop/cop/lint/erb_new_arguments'
 require_relative 'rubocop/cop/lint/flip_flop'
@@ -323,6 +326,7 @@ require_relative 'rubocop/cop/lint/ordered_magic_comments'
 require_relative 'rubocop/cop/lint/parentheses_as_grouped_expression'
 require_relative 'rubocop/cop/lint/percent_string_array'
 require_relative 'rubocop/cop/lint/percent_symbol_array'
+require_relative 'rubocop/cop/lint/raise_exception'
 require_relative 'rubocop/cop/lint/rand_one'
 require_relative 'rubocop/cop/lint/redundant_cop_disable_directive'
 require_relative 'rubocop/cop/lint/redundant_cop_enable_directive'
@@ -344,6 +348,7 @@ require_relative 'rubocop/cop/lint/send_with_mixin_argument'
 require_relative 'rubocop/cop/lint/shadowed_argument'
 require_relative 'rubocop/cop/lint/shadowed_exception'
 require_relative 'rubocop/cop/lint/shadowing_outer_local_variable'
+require_relative 'rubocop/cop/lint/struct_new_override'
 require_relative 'rubocop/cop/lint/suppressed_exception'
 require_relative 'rubocop/cop/lint/syntax'
 require_relative 'rubocop/cop/lint/to_json'
@@ -401,7 +406,6 @@ require_relative 'rubocop/cop/style/bare_percent_literals'
 require_relative 'rubocop/cop/style/begin_block'
 require_relative 'rubocop/cop/style/block_comments'
 require_relative 'rubocop/cop/style/block_delimiters'
-require_relative 'rubocop/cop/style/braces_around_hash_parameters'
 require_relative 'rubocop/cop/style/case_equality'
 require_relative 'rubocop/cop/style/character_literal'
 require_relative 'rubocop/cop/style/class_and_module_children'
@@ -420,6 +424,7 @@ require_relative 'rubocop/cop/style/copyright'
 require_relative 'rubocop/cop/style/date_time'
 require_relative 'rubocop/cop/style/def_with_parentheses'
 require_relative 'rubocop/cop/style/dir'
+require_relative 'rubocop/cop/style/disable_cops_within_source_code_directive'
 require_relative 'rubocop/cop/style/documentation_method'
 require_relative 'rubocop/cop/style/documentation'
 require_relative 'rubocop/cop/style/double_cop_disable_directive'
@@ -437,6 +442,7 @@ require_relative 'rubocop/cop/style/end_block'
 require_relative 'rubocop/cop/style/eval_with_location'
 require_relative 'rubocop/cop/style/even_odd'
 require_relative 'rubocop/cop/style/expand_path_arguments'
+require_relative 'rubocop/cop/style/exponential_notation'
 require_relative 'rubocop/cop/style/float_division'
 require_relative 'rubocop/cop/style/for'
 require_relative 'rubocop/cop/style/format_string'
@@ -444,7 +450,10 @@ require_relative 'rubocop/cop/style/format_string_token'
 require_relative 'rubocop/cop/style/frozen_string_literal_comment'
 require_relative 'rubocop/cop/style/global_vars'
 require_relative 'rubocop/cop/style/guard_clause'
+require_relative 'rubocop/cop/style/hash_each_methods'
 require_relative 'rubocop/cop/style/hash_syntax'
+require_relative 'rubocop/cop/style/hash_transform_keys'
+require_relative 'rubocop/cop/style/hash_transform_values'
 require_relative 'rubocop/cop/style/identical_conditional_branches'
 require_relative 'rubocop/cop/style/if_inside_else'
 require_relative 'rubocop/cop/style/if_unless_modifier'
@@ -459,7 +468,11 @@ require_relative 'rubocop/cop/style/lambda'
 require_relative 'rubocop/cop/style/lambda_call'
 require_relative 'rubocop/cop/style/line_end_concatenation'
 require_relative 'rubocop/cop/style/method_call_without_args_parentheses'
+# rubocop:disable Layout/LineLength
 require_relative 'rubocop/cop/style/method_call_with_args_parentheses'
+require_relative 'rubocop/cop/style/method_call_with_args_parentheses/omit_parentheses'
+require_relative 'rubocop/cop/style/method_call_with_args_parentheses/require_parentheses'
+# rubocop:enable Layout/LineLength
 require_relative 'rubocop/cop/style/method_called_on_do_end_block'
 require_relative 'rubocop/cop/style/method_def_parentheses'
 require_relative 'rubocop/cop/style/method_missing_super'
@@ -547,6 +560,7 @@ require_relative 'rubocop/cop/style/trailing_body_on_method_definition'
 require_relative 'rubocop/cop/style/trailing_body_on_module'
 require_relative 'rubocop/cop/style/trailing_comma_in_arguments'
 require_relative 'rubocop/cop/style/trailing_comma_in_array_literal'
+require_relative 'rubocop/cop/style/trailing_comma_in_block_args'
 require_relative 'rubocop/cop/style/trailing_comma_in_hash_literal'
 require_relative 'rubocop/cop/style/trailing_method_end_statement'
 require_relative 'rubocop/cop/style/trailing_underscore_variable'
@@ -574,12 +588,12 @@ require_relative 'rubocop/formatter/simple_text_formatter'
 # relies on simple text
 require_relative 'rubocop/formatter/clang_style_formatter'
 require_relative 'rubocop/formatter/disabled_config_formatter'
-require_relative 'rubocop/formatter/disabled_lines_formatter'
 require_relative 'rubocop/formatter/emacs_style_formatter'
 require_relative 'rubocop/formatter/file_list_formatter'
 require_relative 'rubocop/formatter/fuubar_style_formatter'
 require_relative 'rubocop/formatter/html_formatter'
 require_relative 'rubocop/formatter/json_formatter'
+require_relative 'rubocop/formatter/junit_formatter'
 require_relative 'rubocop/formatter/offense_count_formatter'
 require_relative 'rubocop/formatter/progress_formatter'
 require_relative 'rubocop/formatter/quiet_formatter'
@@ -616,4 +630,5 @@ require_relative 'rubocop/cli/command/show_cops'
 require_relative 'rubocop/cli/command/version'
 require_relative 'rubocop/options'
 require_relative 'rubocop/remote_config'
+require_relative 'rubocop/target_ruby'
 require_relative 'rubocop/yaml_duplication_checker'

data/lib/rubocop/ast/builder.rb

@@ -15,48 +15,51 @@ module RuboCop
     #   root_node = parser.parse(buffer)
     class Builder < Parser::Builders::Default
       NODE_MAP = {
-        and:        AndNode,
-        alias:      AliasNode,
-        args:       ArgsNode,
-        array:      ArrayNode,
-        block:      BlockNode,
-        break:      BreakNode,
-        case:       CaseNode,
-        class:      ClassNode,
-        def:        DefNode,
-        defined?:   DefinedNode,
-        defs:       DefNode,
-        ensure:     EnsureNode,
-        for:        ForNode,
-        float:      FloatNode,
-        hash:       HashNode,
-        if:         IfNode,
-        int:        IntNode,
-        irange:     RangeNode,
-        erange:     RangeNode,
-        kwsplat:    KeywordSplatNode,
-        module:     ModuleNode,
-        or:         OrNode,
-        pair:       PairNode,
-        regexp:     RegexpNode,
-        resbody:    ResbodyNode,
-        retry:      RetryNode,
-        return:     ReturnNode,
-        csend:      SendNode,
-        send:       SendNode,
-        str:        StrNode,
-        dstr:       StrNode,
-        xstr:       StrNode,
-        sclass:     SelfClassNode,
-        super:      SuperNode,
-        zsuper:     SuperNode,
-        sym:        SymbolNode,
-        until:      UntilNode,
-        until_post: UntilNode,
-        when:       WhenNode,
-        while:      WhileNode,
-        while_post: WhileNode,
-        yield:      YieldNode
+        and:          AndNode,
+        alias:        AliasNode,
+        args:         ArgsNode,
+        array:        ArrayNode,
+        block:        BlockNode,
+        numblock:     BlockNode,
+        break:        BreakNode,
+        case_match:   CaseMatchNode,
+        case:         CaseNode,
+        class:        ClassNode,
+        def:          DefNode,
+        defined?:     DefinedNode,
+        defs:         DefNode,
+        ensure:       EnsureNode,
+        for:          ForNode,
+        forward_args: ForwardArgsNode,
+        float:        FloatNode,
+        hash:         HashNode,
+        if:           IfNode,
+        int:          IntNode,
+        irange:       RangeNode,
+        erange:       RangeNode,
+        kwsplat:      KeywordSplatNode,
+        module:       ModuleNode,
+        or:           OrNode,
+        pair:         PairNode,
+        regexp:       RegexpNode,
+        resbody:      ResbodyNode,
+        retry:        RetryNode,
+        return:       ReturnNode,
+        csend:        SendNode,
+        send:         SendNode,
+        str:          StrNode,
+        dstr:         StrNode,
+        xstr:         StrNode,
+        sclass:       SelfClassNode,
+        super:        SuperNode,
+        zsuper:       SuperNode,
+        sym:          SymbolNode,
+        until:        UntilNode,
+        until_post:   UntilNode,
+        when:         WhenNode,
+        while:        WhileNode,
+        while_post:   WhileNode,
+        yield:        YieldNode
       }.freeze
 
       # Generates {Node} from the given information.

data/lib/rubocop/ast/node.rb

@@ -98,7 +98,7 @@ module RuboCop
         @mutable_attributes.frozen?
       end
 
-      protected :parent= # rubocop:disable Style/AccessModifierDeclarations
+      protected :parent=
 
       # Override `AST::Node#updated` so that `AST::Processor` does not try to
       # mutate our ASTs. Since we keep references from children to parents and
@@ -116,7 +116,7 @@ module RuboCop
       #
       # @return [Integer] the index of the receiver node in its siblings
       def sibling_index
-        parent.children.index { |sibling| sibling.equal?(self) }
+        parent&.children&.index { |sibling| sibling.equal?(self) }
       end
 
       # Common destructuring method. This can be used to normalize
@@ -141,9 +141,6 @@ module RuboCop
       #   Yield only nodes matching any of the types.
       #   @param [Symbol] type_a a node type
       #   @param [Symbol] type_b a node type
-      # @overload each_ancestor(types)
-      #   Yield only nodes matching any of types in the array.
-      #   @param [Array<Symbol>] types an array containing node types
       # @yieldparam [Node] node each ancestor node
       # @return [self] if a block is given
       # @return [Enumerator] if no block is given
@@ -178,9 +175,6 @@ module RuboCop
       #   Yield only nodes matching any of the types.
       #   @param [Symbol] type_a a node type
       #   @param [Symbol] type_b a node type
-      # @overload each_child_node(types)
-      #   Yield only nodes matching any of types in the array.
-      #   @param [Array<Symbol>] types an array containing node types
       # @yieldparam [Node] node each child node
       # @return [self] if a block is given
       # @return [Enumerator] if no block is given
@@ -216,9 +210,6 @@ module RuboCop
       #   Yield only nodes matching any of the types.
       #   @param [Symbol] type_a a node type
       #   @param [Symbol] type_b a node type
-      # @overload each_descendant(types)
-      #   Yield only nodes matching any of types in the array.
-      #   @param [Array<Symbol>] types an array containing node types
       # @yieldparam [Node] node each descendant node
       # @return [self] if a block is given
       # @return [Enumerator] if no block is given
@@ -254,9 +245,6 @@ module RuboCop
       #   Yield only nodes matching any of the types.
       #   @param [Symbol] type_a a node type
       #   @param [Symbol] type_b a node type
-      # @overload each_node(types)
-      #   Yield only nodes matching any of types in the array.
-      #   @param [Array<Symbol>] types an array containing node types
       # @yieldparam [Node] node each node
       # @return [self] if a block is given
       # @return [Enumerator] if no block is given
@@ -303,7 +291,7 @@ module RuboCop
       ## Destructuring
 
       def_node_matcher :receiver, <<~PATTERN
-        {(send $_ ...) (block (send $_ ...) ...)}
+        {(send $_ ...) ({block numblock} (send $_ ...) ...)}
       PATTERN
 
       def_node_matcher :str_content, '(str $_)'
@@ -325,9 +313,8 @@ module RuboCop
          (casgn $_ $_        (send (const nil? {:Class :Module}) :new ...))
          (casgn $_ $_ (block (send (const nil? {:Class :Module}) :new ...) ...))}
       PATTERN
-      # rubocop:disable Style/AccessModifierDeclarations
+
       private :defined_module0
-      # rubocop:enable Style/AccessModifierDeclarations
 
       def defined_module
         namespace, name = *defined_module0
@@ -481,7 +468,13 @@ module RuboCop
         irange_type? || erange_type?
       end
 
-      def_node_matcher :guard_clause?, <<~PATTERN
+      def guard_clause?
+        node = and_type? || or_type? ? rhs : self
+
+        node.match_guard_clause?
+      end
+
+      def_node_matcher :match_guard_clause?, <<~PATTERN
         [${(send nil? {:raise :fail} ...) return break next} single_line?]
       PATTERN
 
@@ -491,7 +484,7 @@ module RuboCop
          (send (const nil? :Proc) :new)}
       PATTERN
 
-      def_node_matcher :lambda?, '(block (send nil? :lambda) ...)'
+      def_node_matcher :lambda?, '({block numblock} (send nil? :lambda) ...)'
       def_node_matcher :lambda_or_proc?, '{lambda? proc?}'
 
       def_node_matcher :class_constructor?, <<~PATTERN

data/lib/rubocop/ast/node/array_node.rb

@@ -18,6 +18,19 @@ module RuboCop
         each_child_node.to_a
       end
 
+      # Calls the given block for all values in the `array` literal.
+      #
+      # @yieldparam [Node] node each node
+      # @return [self] if a block is given
+      # @return [Enumerator] if no block is given
+      def each_value(&block)
+        return to_enum(__method__) unless block_given?
+
+        values.each(&block)
+
+        self
+      end
+
       # Checks whether the `array` literal is delimited by square brackets.
       #
       # @return [Boolean] whether the array is enclosed in square brackets

data/lib/rubocop/ast/node/block_node.rb

@@ -24,7 +24,11 @@ module RuboCop
       #
       # @return [Array<Node>]
       def arguments
-        node_parts[1]
+        if numblock_type?
+          [] # Numbered parameters have no block arguments.
+        else
+          node_parts[1]
+        end
       end
 
       # The body of this block.

data/lib/rubocop/ast/node/case_match_node.rb

@@ -0,0 +1,56 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module AST
+    # A node extension for `case_match` nodes. This will be used in place of
+    # a plain node when the builder constructs the AST, making its methods
+    # available to all `case_match` nodes within RuboCop.
+    class CaseMatchNode < Node
+      include ConditionalNode
+
+      # Returns the keyword of the `case` statement as a string.
+      #
+      # @return [String] the keyword of the `case` statement
+      def keyword
+        'case'
+      end
+
+      # Calls the given block for each `in_pattern` node in the `in` statement.
+      # If no block is given, an `Enumerator` is returned.
+      #
+      # @return [self] if a block is given
+      # @return [Enumerator] if no block is given
+      def each_in_pattern
+        return in_pattern_branches.to_enum(__method__) unless block_given?
+
+        in_pattern_branches.each do |condition|
+          yield condition
+        end
+
+        self
+      end
+
+      # Returns an array of all the when branches in the `case` statement.
+      #
+      # @return [Array<Node>] an array of `in_pattern` nodes
+      def in_pattern_branches
+        node_parts[1...-1]
+      end
+
+      # Returns the else branch of the `case` statement, if any.
+      #
+      # @return [Node] the else branch node of the `case` statement
+      # @return [nil] if the case statement does not have an else branch.
+      def else_branch
+        node_parts[-1]
+      end
+
+      # Checks whether this case statement has an `else` branch.
+      #
+      # @return [Boolean] whether the `case` statement has an `else` branch
+      def else?
+        !loc.else.nil?
+      end
+    end
+  end
+end

data/lib/rubocop/ast/node/def_node.rb

@@ -16,6 +16,17 @@ module RuboCop
         method?(:initialize) || assignment_method?
       end
 
+      # Checks whether this method definition node forwards its arguments
+      # as per the feature added in Ruby 2.7.
+      #
+      # @note This is written in a way that may support lead arguments
+      #       which are rumored to be added in a later version of Ruby.
+      #
+      # @return [Boolean] whether the `def` node uses argument forwarding
+      def argument_forwarding?
+        arguments.any?(&:forward_args_type?)
+      end
+
       # The name of the defined method as a symbol.
       #
       # @return [Symbol] the name of the defined method

data/lib/rubocop/ast/node/forward_args_node.rb

@@ -0,0 +1,18 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module AST
+    # A node extension for `forward-args` nodes. This will be used in place
+    # of a plain node when the builder constructs the AST, making its methods
+    # available to all `forward-args` nodes within RuboCop.
+    class ForwardArgsNode < Node
+      include CollectionNode
+
+      # Node wraps itself in an array to be compatible with other
+      # enumerable argument types.
+      def to_a
+        [self]
+      end
+    end
+  end
+end