rubocop 0.70.0 → 0.72.0

data/lib/rubocop/cop/rails/active_record_override.rb

@@ -1,82 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    module Rails
-      # Checks for overriding built-in Active Record methods instead of using
-      # callbacks.
-      #
-      # @example
-      #   # bad
-      #   class Book < ApplicationRecord
-      #     def save
-      #       self.title = title.upcase!
-      #       super
-      #     end
-      #   end
-      #
-      #   # good
-      #   class Book < ApplicationRecord
-      #     before_save :upcase_title
-      #
-      #     def upcase_title
-      #       self.title = title.upcase!
-      #     end
-      #   end
-      #
-      class ActiveRecordOverride < Cop
-        MSG =
-          'Use %<prefer>s callbacks instead of overriding the Active Record ' \
-          'method `%<bad>s`.'
-        BAD_METHODS = %i[create destroy save update].freeze
-        ACTIVE_RECORD_CLASSES = %w[ApplicationRecord ActiveModel::Base
-                                   ActiveRecord::Base].freeze
-
-        def on_def(node)
-          return unless BAD_METHODS.include?(node.method_name)
-
-          parent_class_name = find_parent_class_name(node)
-          return unless active_model?(parent_class_name)
-
-          return unless node.descendants.any?(&:zsuper_type?)
-
-          add_offense(node, message: message(node.method_name))
-        end
-
-        private
-
-        def active_model?(parent_class_name)
-          ACTIVE_RECORD_CLASSES.include?(parent_class_name)
-        end
-
-        def callback_names(method_name)
-          names = %w[before_ around_ after_].map do |prefix|
-            "`#{prefix}#{method_name}`"
-          end
-
-          names[-1] = "or #{names.last}"
-
-          names.join(', ')
-        end
-
-        def message(method_name)
-          format(MSG, prefer: callback_names(method_name), bad: method_name)
-        end
-
-        def find_parent_class_name(node)
-          return nil unless node
-
-          if node.class_type?
-            parent_class_name = node.node_parts[1]
-
-            return nil if parent_class_name.nil?
-
-            return parent_class_name.source
-          end
-
-          find_parent_class_name(node.parent)
-        end
-      end
-    end
-  end
-end

data/lib/rubocop/cop/rails/active_support_aliases.rb

@@ -1,69 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    module Rails
-      # This cop checks that ActiveSupport aliases to core ruby methods
-      # are not used.
-      #
-      # @example
-      #   # good
-      #   'some_string'.start_with?('prefix')
-      #   'some_string'.end_with?('suffix')
-      #   [1, 2, 'a'] << 'b'
-      #   [1, 2, 'a'].unshift('b')
-      #
-      #   # bad
-      #   'some_string'.starts_with?('prefix')
-      #   'some_string'.ends_with?('suffix')
-      #   [1, 2, 'a'].append('b')
-      #   [1, 2, 'a'].prepend('b')
-      #
-      class ActiveSupportAliases < Cop
-        MSG = 'Use `%<prefer>s` instead of `%<current>s`.'
-
-        ALIASES = {
-          starts_with?: {
-            original: :start_with?, matcher: '(send str :starts_with? _)'
-          },
-          ends_with?: {
-            original: :end_with?, matcher: '(send str :ends_with? _)'
-          },
-          append: { original: :<<, matcher: '(send array :append _)' },
-          prepend: { original: :unshift, matcher: '(send array :prepend _)' }
-        }.freeze
-
-        ALIASES.each do |aliased_method, options|
-          def_node_matcher aliased_method, options[:matcher]
-        end
-
-        def on_send(node)
-          ALIASES.each_key do |aliased_method|
-            register_offense(node, aliased_method) if
-              public_send(aliased_method, node)
-          end
-        end
-
-        def autocorrect(node)
-          return false if append(node)
-
-          lambda do |corrector|
-            method_name = node.loc.selector.source
-            replacement = ALIASES[method_name.to_sym][:original]
-            corrector.replace(node.loc.selector, replacement.to_s)
-          end
-        end
-
-        private
-
-        def register_offense(node, method_name)
-          add_offense(
-            node,
-            message: format(MSG, prefer: ALIASES[method_name][:original],
-                                 current: method_name)
-          )
-        end
-      end
-    end
-  end
-end

data/lib/rubocop/cop/rails/application_job.rb

@@ -1,40 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    module Rails
-      # This cop checks that jobs subclass ApplicationJob with Rails 5.0.
-      #
-      # @example
-      #
-      #  # good
-      #  class Rails5Job < ApplicationJob
-      #    # ...
-      #  end
-      #
-      #  # bad
-      #  class Rails4Job < ActiveJob::Base
-      #    # ...
-      #  end
-      class ApplicationJob < Cop
-        extend TargetRailsVersion
-
-        minimum_target_rails_version 5.0
-
-        MSG = 'Jobs should subclass `ApplicationJob`.'
-        SUPERCLASS = 'ApplicationJob'
-        BASE_PATTERN = '(const (const nil? :ActiveJob) :Base)'
-
-        # rubocop:disable Layout/ClassStructure
-        include RuboCop::Cop::EnforceSuperclass
-        # rubocop:enable Layout/ClassStructure
-
-        def autocorrect(node)
-          lambda do |corrector|
-            corrector.replace(node.source_range, self.class::SUPERCLASS)
-          end
-        end
-      end
-    end
-  end
-end

data/lib/rubocop/cop/rails/application_record.rb

@@ -1,40 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    module Rails
-      # This cop checks that models subclass ApplicationRecord with Rails 5.0.
-      #
-      # @example
-      #
-      #  # good
-      #  class Rails5Model < ApplicationRecord
-      #    # ...
-      #  end
-      #
-      #  # bad
-      #  class Rails4Model < ActiveRecord::Base
-      #    # ...
-      #  end
-      class ApplicationRecord < Cop
-        extend TargetRailsVersion
-
-        minimum_target_rails_version 5.0
-
-        MSG = 'Models should subclass `ApplicationRecord`.'
-        SUPERCLASS = 'ApplicationRecord'
-        BASE_PATTERN = '(const (const nil? :ActiveRecord) :Base)'
-
-        # rubocop:disable Layout/ClassStructure
-        include RuboCop::Cop::EnforceSuperclass
-        # rubocop:enable Layout/ClassStructure
-
-        def autocorrect(node)
-          lambda do |corrector|
-            corrector.replace(node.source_range, self.class::SUPERCLASS)
-          end
-        end
-      end
-    end
-  end
-end

data/lib/rubocop/cop/rails/assert_not.rb

@@ -1,44 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    module Rails
-      #
-      # Use `assert_not` instead of `assert !`.
-      #
-      # @example
-      #   # bad
-      #   assert !x
-      #
-      #   # good
-      #   assert_not x
-      #
-      class AssertNot < RuboCop::Cop::Cop
-        MSG = 'Prefer `assert_not` over `assert !`.'
-
-        def_node_matcher :offensive?, '(send nil? :assert (send ... :!) ...)'
-
-        def on_send(node)
-          add_offense(node) if offensive?(node)
-        end
-
-        def autocorrect(node)
-          expression = node.loc.expression
-
-          lambda do |corrector|
-            corrector.replace(
-              expression,
-              corrected_source(expression.source)
-            )
-          end
-        end
-
-        private
-
-        def corrected_source(source)
-          source.gsub(/^assert(\(| ) *! */, 'assert_not\\1')
-        end
-      end
-    end
-  end
-end

data/lib/rubocop/cop/rails/belongs_to.rb

@@ -1,102 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    module Rails
-      # This cop looks for belongs_to associations where we control whether the
-      # association is required via the deprecated `required` option instead.
-      #
-      # Since Rails 5, belongs_to associations are required by default and this
-      # can be controlled through the use of `optional: true`.
-      #
-      # From the release notes:
-      #
-      #     belongs_to will now trigger a validation error by default if the
-      #     association is not present. You can turn this off on a
-      #     per-association basis with optional: true. Also deprecate required
-      #     option in favor of optional for belongs_to. (Pull Request)
-      #
-      # In the case that the developer is doing `required: false`, we
-      # definitely want to autocorrect to `optional: true`.
-      #
-      # However, without knowing whether they've set overridden the default
-      # value of `config.active_record.belongs_to_required_by_default`, we
-      # can't say whether it's safe to remove `required: true` or whether we
-      # should replace it with `optional: false` (or, similarly, remove a
-      # superfluous `optional: false`). Therefore, in the cases we're using
-      # `required: true`, we'll simply invert it to `optional: false` and the
-      # user can remove depending on their defaults.
-      #
-      # @example
-      #   # bad
-      #   class Post < ApplicationRecord
-      #     belongs_to :blog, required: false
-      #   end
-      #
-      #   # good
-      #   class Post < ApplicationRecord
-      #     belongs_to :blog, optional: true
-      #   end
-      #
-      #   # bad
-      #   class Post < ApplicationRecord
-      #     belongs_to :blog, required: true
-      #   end
-      #
-      #   # good
-      #   class Post < ApplicationRecord
-      #     belongs_to :blog, optional: false
-      #   end
-      #
-      # @see https://guides.rubyonrails.org/5_0_release_notes.html
-      # @see https://github.com/rails/rails/pull/18937
-      class BelongsTo < Cop
-        extend TargetRailsVersion
-
-        minimum_target_rails_version 5.0
-
-        SUPERFLOUS_REQUIRE_FALSE_MSG =
-          'You specified `required: false`, in Rails > 5.0 the required ' \
-          'option is deprecated and you want to use `optional: true`.'
-
-        SUPERFLOUS_REQUIRE_TRUE_MSG =
-          'You specified `required: true`, in Rails > 5.0 the required ' \
-          'option is deprecated and you want to use `optional: false`. ' \
-          'In most configurations, this is the default and you can omit ' \
-          'this option altogether'
-
-        def_node_matcher :match_belongs_to_with_options, <<-PATTERN
-          (send _ :belongs_to _
-            (hash <$(pair (sym :required) ${true false}) ...>)
-          )
-        PATTERN
-
-        def on_send(node)
-          match_belongs_to_with_options(node) do |_option_node, option_value|
-            message =
-              if option_value.true_type?
-                SUPERFLOUS_REQUIRE_TRUE_MSG
-              elsif option_value.false_type?
-                SUPERFLOUS_REQUIRE_FALSE_MSG
-              end
-
-            add_offense(node, message: message, location: :selector)
-          end
-        end
-
-        def autocorrect(node)
-          option_node, option_value = match_belongs_to_with_options(node)
-          return unless option_node
-
-          lambda do |corrector|
-            if option_value.true_type?
-              corrector.replace(option_node.loc.expression, 'optional: false')
-            elsif option_value.false_type?
-              corrector.replace(option_node.loc.expression, 'optional: true')
-            end
-          end
-        end
-      end
-    end
-  end
-end

data/lib/rubocop/cop/rails/blank.rb

@@ -1,164 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    module Rails
-      # This cop checks for code that can be written with simpler conditionals
-      # using `Object#blank?` defined by Active Support.
-      #
-      # Interaction with `Style/UnlessElse`:
-      # The configuration of `NotPresent` will not produce an offense in the
-      # context of `unless else` if `Style/UnlessElse` is inabled. This is
-      # to prevent interference between the auto-correction of the two cops.
-      #
-      # @example NilOrEmpty: true (default)
-      #   # Converts usages of `nil? || empty?` to `blank?`
-      #
-      #   # bad
-      #   foo.nil? || foo.empty?
-      #   foo == nil || foo.empty?
-      #
-      #   # good
-      #   foo.blank?
-      #
-      # @example NotPresent: true (default)
-      #   # Converts usages of `!present?` to `blank?`
-      #
-      #   # bad
-      #   !foo.present?
-      #
-      #   # good
-      #   foo.blank?
-      #
-      # @example UnlessPresent: true (default)
-      #   # Converts usages of `unless present?` to `if blank?`
-      #
-      #   # bad
-      #   something unless foo.present?
-      #
-      #   # good
-      #   something if foo.blank?
-      #
-      #   # bad
-      #   unless foo.present?
-      #     something
-      #   end
-      #
-      #   # good
-      #   if foo.blank?
-      #     something
-      #   end
-      #
-      #   # good
-      #   def blank?
-      #     !present?
-      #   end
-      class Blank < Cop
-        MSG_NIL_OR_EMPTY = 'Use `%<prefer>s` instead of `%<current>s`.'
-        MSG_NOT_PRESENT = 'Use `%<prefer>s` instead of `%<current>s`.'
-        MSG_UNLESS_PRESENT = 'Use `if %<prefer>s` instead of ' \
-                             '`%<current>s`.'
-
-        # `(send nil $_)` is not actually a valid match for an offense. Nodes
-        # that have a single method call on the left hand side
-        # (`bar || foo.empty?`) will blow up when checking
-        # `(send (:nil) :== $_)`.
-        def_node_matcher :nil_or_empty?, <<-PATTERN
-          (or
-              {
-                (send $_ :!)
-                (send $_ :nil?)
-                (send $_ :== nil)
-                (send nil :== $_)
-              }
-              {
-                (send $_ :empty?)
-                (send (send (send $_ :empty?) :!) :!)
-              }
-          )
-        PATTERN
-
-        def_node_matcher :not_present?, '(send (send $_ :present?) :!)'
-
-        def_node_matcher :defining_blank?, '(def :blank? (args) ...)'
-
-        def_node_matcher :unless_present?, <<-PATTERN
-          (:if $(send $_ :present?) {nil? (...)} ...)
-        PATTERN
-
-        def on_send(node)
-          return unless cop_config['NotPresent']
-
-          not_present?(node) do |receiver|
-            # accepts !present? if its in the body of a `blank?` method
-            next if defining_blank?(node.parent)
-
-            add_offense(node,
-                        message: format(MSG_NOT_PRESENT,
-                                        prefer: replacement(receiver),
-                                        current: node.source))
-          end
-        end
-
-        def on_or(node)
-          return unless cop_config['NilOrEmpty']
-
-          nil_or_empty?(node) do |var1, var2|
-            return unless var1 == var2
-
-            add_offense(node,
-                        message: format(MSG_NIL_OR_EMPTY,
-                                        prefer: replacement(var1),
-                                        current: node.source))
-          end
-        end
-
-        def on_if(node)
-          return unless cop_config['UnlessPresent']
-          return unless node.unless?
-          return if node.else? && config.for_cop('Style/UnlessElse')['Enabled']
-
-          unless_present?(node) do |method_call, receiver|
-            range = unless_condition(node, method_call)
-
-            add_offense(node,
-                        location: range,
-                        message: format(MSG_UNLESS_PRESENT,
-                                        prefer: replacement(receiver),
-                                        current: range.source))
-          end
-        end
-
-        def autocorrect(node)
-          lambda do |corrector|
-            method_call, variable1 = unless_present?(node)
-
-            if method_call
-              corrector.replace(node.loc.keyword, 'if')
-              range = method_call.loc.expression
-            else
-              variable1, _variable2 = nil_or_empty?(node) || not_present?(node)
-              range = node.loc.expression
-            end
-
-            corrector.replace(range, replacement(variable1))
-          end
-        end
-
-        private
-
-        def unless_condition(node, method_call)
-          if node.modifier_form?
-            node.loc.keyword.join(node.loc.expression.end)
-          else
-            node.loc.expression.begin.join(method_call.loc.expression)
-          end
-        end
-
-        def replacement(node)
-          node.respond_to?(:source) ? "#{node.source}.blank?" : 'blank?'
-        end
-      end
-    end
-  end
-end