rubocop 0.7.2 → 0.8.0

data/spec/rubocop/cops/and_or_spec.rb

@@ -0,0 +1,37 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+module Rubocop
+  module Cop
+    describe AndOr do
+      let(:amp) { AndOr.new }
+
+      it 'registers an offence for OR' do
+        inspect_source(amp,
+                       ['test if a or b'])
+        expect(amp.offences.size).to eq(1)
+        expect(amp.messages).to eq(['Use || instead of or.'])
+      end
+
+      it 'registers an offence for AND' do
+        inspect_source(amp,
+                       ['test if a and b'])
+        expect(amp.offences.size).to eq(1)
+        expect(amp.messages).to eq(['Use && instead of and.'])
+      end
+
+      it 'accepts ||' do
+        inspect_source(amp,
+                       ['test if a || b'])
+        expect(amp.offences).to be_empty
+      end
+
+      it 'accepts &&' do
+        inspect_source(amp,
+                       ['test if a && b'])
+        expect(amp.offences).to be_empty
+      end
+    end
+  end
+end

data/spec/rubocop/cops/ascii_comments_spec.rb

@@ -9,16 +9,15 @@ module Rubocop
 
       it 'registers an offence for a comment with non-ascii chars' do
         inspect_source(ascii,
-                       'file.rb',
-                       ['# 这是什么？'])
+                       ['# encoding: utf-8',
+                        '# 这是什么？'])
         expect(ascii.offences.size).to eq(1)
         expect(ascii.offences.map(&:message))
-          .to eq([AsciiComments::ERROR_MESSAGE])
+          .to eq([AsciiComments::MSG])
       end
 
       it 'accepts comments with only ascii chars' do
         inspect_source(ascii,
-                       'file.rb',
                        ['# AZaz1@$%~,;*_`|'])
         expect(ascii.offences).to be_empty
       end

data/spec/rubocop/cops/ascii_identifiers_spec.rb

@@ -9,16 +9,15 @@ module Rubocop
 
       it 'registers an offence for a variable name with non-ascii chars' do
         inspect_source(ascii,
-                       'file.rb',
-                       ['älg = 1'])
+                       ['# encoding: utf-8',
+                        'älg = 1'])
         expect(ascii.offences.size).to eq(1)
         expect(ascii.offences.map(&:message))
-          .to eq([AsciiIdentifiers::ERROR_MESSAGE])
+          .to eq([AsciiIdentifiers::MSG])
       end
 
       it 'accepts identifiers with only ascii chars' do
         inspect_source(ascii,
-                       'file.rb',
                        ['x.empty?'])
         expect(ascii.offences).to be_empty
       end

data/spec/rubocop/cops/avoid_class_vars_spec.rb

@@ -7,14 +7,19 @@ module Rubocop
     describe AvoidClassVars do
       let(:acv) { AvoidClassVars.new }
 
-      it 'registers an offence for class variables' do
+      it 'registers an offence for class variable declaration' do
         inspect_source(acv,
-                       'file.rb',
                        ['class TestClass; @@test = 10; end'])
         expect(acv.offences.size).to eq(1)
         expect(acv.offences.map(&:message))
           .to eq(['Replace class var @@test with a class instance var.'])
       end
+
+      it 'does not register an offence for class variable usage' do
+        inspect_source(acv,
+                       ['@@test.test(20)'])
+        expect(acv.offences).to be_empty
+      end
     end
   end
 end

data/spec/rubocop/cops/avoid_for_spec.rb

@@ -9,7 +9,6 @@ module Rubocop
 
       it 'registers an offence for for' do
         inspect_source(af,
-                       'file.rb',
                        ['def func',
                         '  for n in [1, 2, 3] do',
                         '    puts n',
@@ -17,19 +16,17 @@ module Rubocop
                         'end'])
         expect(af.offences.size).to eq(1)
         expect(af.offences.map(&:message))
-          .to eq([AvoidFor::ERROR_MESSAGE])
+          .to eq([AvoidFor::MSG])
       end
 
       it 'does not register an offence for :for' do
         inspect_source(af,
-                       'file.rb',
                        ['[:for, :ala, :bala]'])
         expect(af.offences).to be_empty
       end
 
       it 'does not register an offence for def for' do
         inspect_source(af,
-                       'file.rb',
                        ['def for; end'])
         expect(af.offences).to be_empty
       end

data/spec/rubocop/cops/{avoid_global_vars.rb → avoid_global_vars_spec.rb}

@@ -8,23 +8,23 @@ module Rubocop
       let(:ap) { AvoidGlobalVars.new }
 
       it 'registers an offence for $custom' do
-        inspect_source(ap, 'file.rb', ['puts $custom'])
+        inspect_source(ap, ['puts $custom'])
         expect(ap.offences.size).to eq(1)
       end
 
       it 'does not register an offence for $"' do
-        inspect_source(ap, 'file.rb', ['puts $"'])
+        inspect_source(ap, ['puts $"'])
 
         expect(ap.offences).to be_empty
       end
 
       it 'does not register an offence for $ORS' do
-        inspect_source(ap, 'file.rb', ['puts $0'])
+        inspect_source(ap, ['puts $0'])
         expect(ap.offences).to be_empty
       end
 
       it 'does not register an offence for backrefs like $1' do
-        inspect_source(ap, 'file.rb', ['puts $1'])
+        inspect_source(ap, ['puts $1'])
         expect(ap.offences).to be_empty
       end
     end

data/spec/rubocop/cops/avoid_perl_backrefs_spec.rb

@@ -8,7 +8,7 @@ module Rubocop
       let(:ap) { AvoidPerlBackrefs.new }
 
       it 'registers an offence for $1' do
-        inspect_source(ap, 'file.rb', ['puts $1'])
+        inspect_source(ap, ['puts $1'])
         expect(ap.offences.size).to eq(1)
         expect(ap.offences.map(&:message))
           .to eq(['Prefer the use of MatchData over $1.'])

data/spec/rubocop/cops/avoid_perlisms_spec.rb

@@ -8,35 +8,35 @@ module Rubocop
       let(:ap) { AvoidPerlisms.new }
 
       it 'registers an offence for $:' do
-        inspect_source(ap, 'file.rb', ['puts $:'])
+        inspect_source(ap, ['puts $:'])
         expect(ap.offences.size).to eq(1)
         expect(ap.offences.map(&:message))
           .to eq(['Prefer $LOAD_PATH over $:.'])
       end
 
       it 'registers an offence for $"' do
-        inspect_source(ap, 'file.rb', ['puts $"'])
+        inspect_source(ap, ['puts $"'])
         expect(ap.offences.size).to eq(1)
         expect(ap.offences.map(&:message))
           .to eq(['Prefer $LOADED_FEATURES over $".'])
       end
 
       it 'registers an offence for $0' do
-        inspect_source(ap, 'file.rb', ['puts $0'])
+        inspect_source(ap, ['puts $0'])
         expect(ap.offences.size).to eq(1)
         expect(ap.offences.map(&:message))
           .to eq(['Prefer $PROGRAM_NAME over $0.'])
       end
 
       it 'registers an offence for $$' do
-        inspect_source(ap, 'file.rb', ['puts $$'])
+        inspect_source(ap, ['puts $$'])
         expect(ap.offences.size).to eq(1)
         expect(ap.offences.map(&:message))
           .to eq(['Prefer $PID or $PROCESS_ID from English library over $$.'])
       end
 
       it 'does not register an offence for backrefs like $1' do
-        inspect_source(ap, 'file.rb', ['puts $1'])
+        inspect_source(ap, ['puts $1'])
         expect(ap.offences).to be_empty
       end
     end

data/spec/rubocop/cops/block_comments_spec.rb

@@ -9,18 +9,14 @@ module Rubocop
 
       it 'registers an offence for block comments' do
         inspect_source(block,
-                       'file.rb',
                        ['=begin',
                         'comment',
                         '=end'])
         expect(block.offences.size).to eq(1)
-        expect(block.offences.map(&:message))
-          .to eq([BlockComments::ERROR_MESSAGE])
       end
 
       it 'accepts regular comments' do
         inspect_source(block,
-                       'file.rb',
                        ['# comment'])
         expect(block.offences).to be_empty
       end

data/spec/rubocop/cops/blocks_spec.rb

@@ -0,0 +1,33 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+module Rubocop
+  module Cop
+    describe Blocks do
+      let(:blocks) { Blocks.new }
+
+      it 'registers an offence for a multiline block with braces' do
+        inspect_source(blocks, ['each { |x|',
+                                '}'])
+        expect(blocks.messages).to eq([Blocks::MULTI_LINE_MSG])
+      end
+
+      it 'accepts a multiline block with do-end' do
+        inspect_source(blocks, ['each do |x|',
+                                'end'])
+        expect(blocks.offences.map(&:message)).to be_empty
+      end
+
+      it 'registers an offence for a single line block with do-end' do
+        inspect_source(blocks, ['each do |x| end'])
+        expect(blocks.messages).to eq([Blocks::SINGLE_LINE_MSG])
+      end
+
+      it 'accepts a single line block with braces' do
+        inspect_source(blocks, ['each { |x| }'])
+        expect(blocks.offences.map(&:message)).to be_empty
+      end
+    end
+  end
+end

data/spec/rubocop/cops/case_indentation_spec.rb

@@ -14,7 +14,7 @@ module Rubocop
                   '         when 1 then return',
                   '        end',
                   'end']
-        inspect_source(ind, 'file.rb', source)
+        inspect_source(ind, source)
         expect(ind.offences.map(&:message)).to eq(
           ['Indent when as deep as case.'] * 2)
       end
@@ -32,7 +32,7 @@ module Rubocop
                   'when 2 then encoding',
                   'end',
                   '']
-        inspect_source(ind, 'file.rb', source)
+        inspect_source(ind, source)
         expect(ind.offences).to be_empty
       end
 
@@ -42,7 +42,7 @@ module Rubocop
                   'when 0',
                   'end',
                   '']
-        inspect_source(ind, 'file.rb', source)
+        inspect_source(ind, source)
         expect(ind.offences.map(&:message)).to be_empty
       end
 
@@ -55,7 +55,7 @@ module Rubocop
                   '  MethodCallNode',
                   'end',
                   '']
-        inspect_source(ind, 'file.rb', source)
+        inspect_source(ind, source)
         expect(ind.offences.map(&:message)).to be_empty
       end
 
@@ -78,7 +78,7 @@ module Rubocop
                   'when Array',
                   'end',
                   '']
-        inspect_source(ind, 'file.rb', source)
+        inspect_source(ind, source)
         expect(ind.offences.map(&:message)).to be_empty
       end
     end

data/spec/rubocop/cops/class_and_module_camel_case_spec.rb

@@ -8,26 +8,36 @@ module Rubocop
       let(:camel_case) { ClassAndModuleCamelCase.new }
 
       it 'registers an offence for underscore in class and module name' do
-        inspect_source(camel_case, 'file.rb',
+        inspect_source(camel_case,
                        ['class My_Class',
                         'end',
                         '',
                         'module My_Module',
                         'end',
                        ])
-        expect(camel_case.offences.map(&:message)).to eq(
-          ['Use CamelCase for classes and modules.'] * 2)
+        expect(camel_case.offences.size).to eq(2)
+      end
+
+      it 'is not fooled by qualified names' do
+        inspect_source(camel_case,
+                       ['class Top::My_Class',
+                        'end',
+                        '',
+                        'module My_Module::Ala',
+                        'end',
+                       ])
+        expect(camel_case.offences.size).to eq(2)
       end
 
       it 'accepts CamelCase names' do
-        inspect_source(camel_case, 'file.rb',
+        inspect_source(camel_case,
                        ['class MyClass',
                         'end',
                         '',
                         'module Mine',
                         'end',
                        ])
-        expect(camel_case.offences.map(&:message)).to be_empty
+        expect(camel_case.offences).to be_empty
       end
     end
   end

data/spec/rubocop/cops/class_methods_spec.rb

@@ -8,7 +8,7 @@ module Rubocop
       let(:cm) { ClassMethods.new }
 
       it 'registers an offence for methods using a class name' do
-        inspect_source(cm, 'file.rb',
+        inspect_source(cm,
                        ['class Test',
                         '  def Test.some_method',
                         '    do_something',
@@ -18,7 +18,7 @@ module Rubocop
       end
 
       it 'registers an offence for methods using a module name' do
-        inspect_source(cm, 'file.rb',
+        inspect_source(cm,
                        ['module Test',
                         '  def Test.some_method',
                         '    do_something',
@@ -28,7 +28,7 @@ module Rubocop
       end
 
       it 'does not register an offence for methods using self' do
-        inspect_source(cm, 'file.rb',
+        inspect_source(cm,
                        ['module Test',
                         '  def self.some_method',
                         '    do_something',
@@ -38,7 +38,7 @@ module Rubocop
       end
 
       it 'does not register an offence outside class/module bodies' do
-        inspect_source(cm, 'file.rb',
+        inspect_source(cm,
                        ['def self.some_method',
                         '  do_something',
                         'end'])

data/spec/rubocop/cops/collection_methods_spec.rb

@@ -8,32 +8,37 @@ module Rubocop
       let(:cm) { CollectionMethods.new }
 
       it 'registers an offence for collect' do
-        inspect_source(cm, 'file.rb', ['[1, 2, 3].collect { |e| e + 1 }'])
+        inspect_source(cm, ['[1, 2, 3].collect { |e| e + 1 }'])
         expect(cm.offences.size).to eq(1)
         expect(cm.offences.map(&:message))
           .to eq(['Prefer map over collect.'])
       end
 
       it 'registers an offence for inject' do
-        inspect_source(cm, 'file.rb', ['[1, 2, 3].inject { |e| e + 1 }'])
+        inspect_source(cm, ['[1, 2, 3].inject { |e| e + 1 }'])
         expect(cm.offences.size).to eq(1)
         expect(cm.offences.map(&:message))
           .to eq(['Prefer reduce over inject.'])
       end
 
       it 'registers an offence for detect' do
-        inspect_source(cm, 'file.rb', ['[1, 2, 3].detect { |e| e + 1 }'])
+        inspect_source(cm, ['[1, 2, 3].detect { |e| e + 1 }'])
         expect(cm.offences.size).to eq(1)
         expect(cm.offences.map(&:message))
           .to eq(['Prefer find over detect.'])
       end
 
       it 'registers an offence for find_all' do
-        inspect_source(cm, 'file.rb', ['[1, 2, 3].find_all { |e| e + 1 }'])
+        inspect_source(cm, ['[1, 2, 3].find_all { |e| e + 1 }'])
         expect(cm.offences.size).to eq(1)
         expect(cm.offences.map(&:message))
           .to eq(['Prefer select over find_all.'])
       end
+
+      it 'ignores find_all without an explicit receiver' do
+        inspect_source(cm, ['find_all { |e| e + 1 }'])
+        expect(cm.offences).to be_empty
+      end
     end
   end
 end

data/spec/rubocop/cops/colon_method_call_spec.rb

@@ -9,39 +9,45 @@ module Rubocop
 
       it 'registers an offence for instance method call' do
         inspect_source(smc,
-                       'file.rb',
                        ['test::method_name'])
         expect(smc.offences.size).to eq(1)
       end
 
       it 'registers an offence for instance method call with arg' do
         inspect_source(smc,
-                       'file.rb',
                        ['test::method_name(arg)'])
         expect(smc.offences.size).to eq(1)
       end
 
       it 'registers an offence for class method call' do
         inspect_source(smc,
-                       'file.rb',
                        ['Class::method_name'])
         expect(smc.offences.size).to eq(1)
       end
 
       it 'registers an offence for class method call with arg' do
         inspect_source(smc,
-                       'file.rb',
                        ['Class::method_name(arg, arg2)'])
         expect(smc.offences.size).to eq(1)
       end
 
       it 'does not register an offence for constant access' do
         inspect_source(smc,
-                       'file.rb',
                        ['Tip::Top::SOME_CONST'])
         expect(smc.offences).to be_empty
       end
 
+      it 'does not register an offence for nested class' do
+        inspect_source(smc,
+                       ['Tip::Top.some_method'])
+        expect(smc.offences).to be_empty
+      end
+
+      it 'does not register an offence for op methods' do
+        inspect_source(smc,
+                       ['Tip::Top.some_method[3]'])
+        expect(smc.offences).to be_empty
+      end
     end
   end
 end