rubocop 0.67.2 → 0.68.0

data/lib/rubocop/options.rb

@@ -117,6 +117,8 @@ module RuboCop
       option(opts, '--no-auto-gen-timestamp') do
         @options[:no_auto_gen_timestamp] = true
       end
+
+      option(opts, '--init')
     end
 
     def add_formatting_options(opts)
@@ -435,7 +437,8 @@ module RuboCop
       parallel: ['Use available CPUs to execute inspection in',
                  'parallel.'],
       stdin: ['Pipe source from STDIN, using FILE in offense',
-              'reports. This is useful for editor integration.']
+              'reports. This is useful for editor integration.'],
+      init: 'Generate a .rubocop.yml file in the current directory.'
     }.freeze
   end
 end

data/lib/rubocop/rspec/shared_contexts.rb

@@ -7,6 +7,7 @@ RSpec.shared_context 'isolated environment', :isolated_environment do
   around do |example|
     Dir.mktmpdir do |tmpdir|
       original_home = ENV['HOME']
+      original_xdg_config_home = ENV['XDG_CONFIG_HOME']
 
       # Make sure to expand all symlinks in the path first. Otherwise we may
       # get mismatched pathnames when loading config files later on.
@@ -19,6 +20,7 @@ RSpec.shared_context 'isolated environment', :isolated_environment do
         virtual_home = File.expand_path(File.join(tmpdir, 'home'))
         Dir.mkdir(virtual_home)
         ENV['HOME'] = virtual_home
+        ENV.delete('XDG_CONFIG_HOME')
 
         working_dir = File.join(tmpdir, 'work')
         Dir.mkdir(working_dir)
@@ -28,6 +30,7 @@ RSpec.shared_context 'isolated environment', :isolated_environment do
         end
       ensure
         ENV['HOME'] = original_home
+        ENV['XDG_CONFIG_HOME'] = original_xdg_config_home
 
         RuboCop::FileFinder.root_level = nil
       end

data/lib/rubocop/version.rb

@@ -3,7 +3,7 @@
 module RuboCop
   # This module holds the RuboCop version information.
   module Version
-    STRING = '0.67.2'.freeze
+    STRING = '0.68.0'.freeze
 
     MSG = '%<version>s (using Parser %<parser_version>s, running on ' \
           '%<ruby_engine>s %<ruby_version>s %<ruby_platform>s)'.freeze

data/lib/rubocop/yaml_duplication_checker.rb

@@ -5,7 +5,7 @@ module RuboCop
   module YAMLDuplicationChecker
     def self.check(yaml_string, filename, &on_duplicated)
       # Specify filename to display helpful message when it raises an error.
-      tree = YAML.parse(yaml_string, filename: filename)
+      tree = YAML.parse(yaml_string, filename)
       return unless tree
 
       traverse(tree, &on_duplicated)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop
 version: !ruby/object:Gem::Version
-  version: 0.67.2
+  version: 0.68.0
 platform: ruby
 authors:
 - Bozhidar Batsov
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-04-05 00:00:00.000000000 Z
+date: 2019-04-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: jaro_winkler
@@ -60,20 +60,6 @@ dependencies:
     - - "!="
       - !ruby/object:Gem::Version
         version: 2.5.1.1
-- !ruby/object:Gem::Dependency
-  name: psych
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 3.1.0
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 3.1.0
 - !ruby/object:Gem::Dependency
   name: rainbow
   requirement: !ruby/object:Gem::Requirement
@@ -134,7 +120,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.3.0
+        version: 1.15.0
     - - "<"
       - !ruby/object:Gem::Version
         version: '3.0'
@@ -144,7 +130,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.3.0
+        version: 1.15.0
     - - "<"
       - !ruby/object:Gem::Version
         version: '3.0'
@@ -184,12 +170,14 @@ files:
 - lib/rubocop.rb
 - lib/rubocop/ast/builder.rb
 - lib/rubocop/ast/node.rb
+- lib/rubocop/ast/node/alias_node.rb
 - lib/rubocop/ast/node/and_node.rb
 - lib/rubocop/ast/node/args_node.rb
 - lib/rubocop/ast/node/array_node.rb
 - lib/rubocop/ast/node/block_node.rb
 - lib/rubocop/ast/node/break_node.rb
 - lib/rubocop/ast/node/case_node.rb
+- lib/rubocop/ast/node/class_node.rb
 - lib/rubocop/ast/node/def_node.rb
 - lib/rubocop/ast/node/defined_node.rb
 - lib/rubocop/ast/node/ensure_node.rb
@@ -207,12 +195,14 @@ files:
 - lib/rubocop/ast/node/mixin/modifier_node.rb
 - lib/rubocop/ast/node/mixin/parameterized_node.rb
 - lib/rubocop/ast/node/mixin/predicate_operator_node.rb
+- lib/rubocop/ast/node/module_node.rb
 - lib/rubocop/ast/node/or_node.rb
 - lib/rubocop/ast/node/pair_node.rb
 - lib/rubocop/ast/node/range_node.rb
 - lib/rubocop/ast/node/regexp_node.rb
 - lib/rubocop/ast/node/resbody_node.rb
 - lib/rubocop/ast/node/retry_node.rb
+- lib/rubocop/ast/node/self_class_node.rb
 - lib/rubocop/ast/node/send_node.rb
 - lib/rubocop/ast/node/str_node.rb
 - lib/rubocop/ast/node/super_node.rb
@@ -270,6 +260,7 @@ files:
 - lib/rubocop/cop/internal_affairs/redundant_message_argument.rb
 - lib/rubocop/cop/internal_affairs/useless_message_assertion.rb
 - lib/rubocop/cop/layout/access_modifier_indentation.rb
+- lib/rubocop/cop/layout/align_arguments.rb
 - lib/rubocop/cop/layout/align_array.rb
 - lib/rubocop/cop/layout/align_hash.rb
 - lib/rubocop/cop/layout/align_parameters.rb
@@ -304,10 +295,12 @@ files:
 - lib/rubocop/cop/layout/first_hash_element_line_break.rb
 - lib/rubocop/cop/layout/first_method_argument_line_break.rb
 - lib/rubocop/cop/layout/first_method_parameter_line_break.rb
-- lib/rubocop/cop/layout/first_parameter_indentation.rb
-- lib/rubocop/cop/layout/indent_array.rb
+- lib/rubocop/cop/layout/heredoc_argument_closing_parenthesis.rb
 - lib/rubocop/cop/layout/indent_assignment.rb
-- lib/rubocop/cop/layout/indent_hash.rb
+- lib/rubocop/cop/layout/indent_first_argument.rb
+- lib/rubocop/cop/layout/indent_first_array_element.rb
+- lib/rubocop/cop/layout/indent_first_hash_element.rb
+- lib/rubocop/cop/layout/indent_first_parameter.rb
 - lib/rubocop/cop/layout/indent_heredoc.rb
 - lib/rubocop/cop/layout/indentation_consistency.rb
 - lib/rubocop/cop/layout/indentation_width.rb
@@ -379,6 +372,7 @@ files:
 - lib/rubocop/cop/lint/float_out_of_range.rb
 - lib/rubocop/cop/lint/format_parameter_mismatch.rb
 - lib/rubocop/cop/lint/handle_exceptions.rb
+- lib/rubocop/cop/lint/heredoc_method_call_position.rb
 - lib/rubocop/cop/lint/implicit_string_concatenation.rb
 - lib/rubocop/cop/lint/ineffective_access_modifier.rb
 - lib/rubocop/cop/lint/inherit_exception.rb
@@ -446,10 +440,10 @@ files:
 - lib/rubocop/cop/metrics/utils/abc_size_calculator.rb
 - lib/rubocop/cop/mixin/alignment.rb
 - lib/rubocop/cop/mixin/annotation_comment.rb
-- lib/rubocop/cop/mixin/array_hash_indentation.rb
 - lib/rubocop/cop/mixin/array_min_size.rb
 - lib/rubocop/cop/mixin/array_syntax.rb
 - lib/rubocop/cop/mixin/check_assignment.rb
+- lib/rubocop/cop/mixin/check_line_breakable.rb
 - lib/rubocop/cop/mixin/classish_length.rb
 - lib/rubocop/cop/mixin/code_length.rb
 - lib/rubocop/cop/mixin/configurable_enforced_style.rb
@@ -475,6 +469,7 @@ files:
 - lib/rubocop/cop/mixin/method_complexity.rb
 - lib/rubocop/cop/mixin/method_preference.rb
 - lib/rubocop/cop/mixin/min_body_length.rb
+- lib/rubocop/cop/mixin/multiline_element_indentation.rb
 - lib/rubocop/cop/mixin/multiline_element_line_breaks.rb
 - lib/rubocop/cop/mixin/multiline_expression_indentation.rb
 - lib/rubocop/cop/mixin/multiline_literal_brace_layout.rb
@@ -522,31 +517,6 @@ files:
 - lib/rubocop/cop/naming/variable_name.rb
 - lib/rubocop/cop/naming/variable_number.rb
 - lib/rubocop/cop/offense.rb
-- lib/rubocop/cop/performance/caller.rb
-- lib/rubocop/cop/performance/case_when_splat.rb
-- lib/rubocop/cop/performance/casecmp.rb
-- lib/rubocop/cop/performance/chain_array_allocation.rb
-- lib/rubocop/cop/performance/compare_with_block.rb
-- lib/rubocop/cop/performance/count.rb
-- lib/rubocop/cop/performance/detect.rb
-- lib/rubocop/cop/performance/double_start_end_with.rb
-- lib/rubocop/cop/performance/end_with.rb
-- lib/rubocop/cop/performance/fixed_size.rb
-- lib/rubocop/cop/performance/flat_map.rb
-- lib/rubocop/cop/performance/inefficient_hash_search.rb
-- lib/rubocop/cop/performance/open_struct.rb
-- lib/rubocop/cop/performance/range_include.rb
-- lib/rubocop/cop/performance/redundant_block_call.rb
-- lib/rubocop/cop/performance/redundant_match.rb
-- lib/rubocop/cop/performance/redundant_merge.rb
-- lib/rubocop/cop/performance/regexp_match.rb
-- lib/rubocop/cop/performance/reverse_each.rb
-- lib/rubocop/cop/performance/size.rb
-- lib/rubocop/cop/performance/start_with.rb
-- lib/rubocop/cop/performance/string_replacement.rb
-- lib/rubocop/cop/performance/times_map.rb
-- lib/rubocop/cop/performance/unfreeze_string.rb
-- lib/rubocop/cop/performance/uri_default_parser.rb
 - lib/rubocop/cop/rails/action_filter.rb
 - lib/rubocop/cop/rails/active_record_aliases.rb
 - lib/rubocop/cop/rails/active_record_override.rb
@@ -841,15 +811,21 @@ post_install_message: |
 
   Put this in your Gemfile.
 
-    gem 'rubocop-performance'
+  ```rb
+  gem 'rubocop-performance'
+  ```
 
   And then execute:
 
-    $ bundle install
+  ```sh
+  $ bundle install
+  ```
 
   Put this into your .rubocop.yml.
 
-    require: rubocop-performance
+  ```yaml
+  require: rubocop-performance
+  ```
 
   More information: https://github.com/rubocop-hq/rubocop-performance
 rdoc_options: []

data/lib/rubocop/cop/performance/caller.rb

@@ -1,69 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    module Performance
-      # This cop identifies places where `caller[n]`
-      # can be replaced by `caller(n..n).first`.
-      #
-      # @example
-      #   # bad
-      #   caller[1]
-      #   caller.first
-      #   caller_locations[1]
-      #   caller_locations.first
-      #
-      #   # good
-      #   caller(2..2).first
-      #   caller(1..1).first
-      #   caller_locations(2..2).first
-      #   caller_locations(1..1).first
-      class Caller < Cop
-        MSG_BRACE = 'Use `%<method>s(%<n>d..%<n>d).first`' \
-                    ' instead of `%<method>s[%<m>d]`.'.freeze
-        MSG_FIRST = 'Use `%<method>s(%<n>d..%<n>d).first`' \
-                    ' instead of `%<method>s.first`.'.freeze
-
-        def_node_matcher :slow_caller?, <<-PATTERN
-          {
-            (send nil? {:caller :caller_locations})
-            (send nil? {:caller :caller_locations} int)
-          }
-        PATTERN
-
-        def_node_matcher :caller_with_scope_method?, <<-PATTERN
-          {
-            (send #slow_caller? :first)
-            (send #slow_caller? :[] int)
-          }
-        PATTERN
-
-        def on_send(node)
-          return unless caller_with_scope_method?(node)
-
-          add_offense(node)
-        end
-
-        private
-
-        def message(node)
-          method_name = node.receiver.method_name
-          caller_arg = node.receiver.first_argument
-          n = caller_arg ? int_value(caller_arg) : 1
-
-          if node.method_name == :[]
-            m = int_value(node.first_argument)
-            n += m
-            format(MSG_BRACE, n: n, m: m, method: method_name)
-          else
-            format(MSG_FIRST, n: n, method: method_name)
-          end
-        end
-
-        def int_value(node)
-          node.children[0]
-        end
-      end
-    end
-  end
-end

data/lib/rubocop/cop/performance/case_when_splat.rb

@@ -1,177 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    module Performance
-      # Reordering `when` conditions with a splat to the end
-      # of the `when` branches can improve performance.
-      #
-      # Ruby has to allocate memory for the splat expansion every time
-      # that the `case` `when` statement is run. Since Ruby does not support
-      # fall through inside of `case` `when`, like some other languages do,
-      # the order of the `when` branches should not matter. By placing any
-      # splat expansions at the end of the list of `when` branches we will
-      # reduce the number of times that memory has to be allocated for
-      # the expansion. The exception to this is if multiple of your `when`
-      # conditions can be true for any given condition. A likely scenario for
-      # this defining a higher level when condition to override a condition
-      # that is inside of the splat expansion.
-      #
-      # This is not a guaranteed performance improvement. If the data being
-      # processed by the `case` condition is normalized in a manner that favors
-      # hitting a condition in the splat expansion, it is possible that
-      # moving the splat condition to the end will use more memory,
-      # and run slightly slower.
-      #
-      # @example
-      #   # bad
-      #   case foo
-      #   when *condition
-      #     bar
-      #   when baz
-      #     foobar
-      #   end
-      #
-      #   case foo
-      #   when *[1, 2, 3, 4]
-      #     bar
-      #   when 5
-      #     baz
-      #   end
-      #
-      #   # good
-      #   case foo
-      #   when baz
-      #     foobar
-      #   when *condition
-      #     bar
-      #   end
-      #
-      #   case foo
-      #   when 1, 2, 3, 4
-      #     bar
-      #   when 5
-      #     baz
-      #   end
-      class CaseWhenSplat < Cop
-        include Alignment
-        include RangeHelp
-
-        MSG = 'Reordering `when` conditions with a splat to the end ' \
-          'of the `when` branches can improve performance.'.freeze
-        ARRAY_MSG = 'Pass the contents of array literals ' \
-          'directly to `when` conditions.'.freeze
-
-        def on_case(case_node)
-          when_conditions = case_node.when_branches.flat_map(&:conditions)
-
-          splat_offenses(when_conditions).reverse_each do |condition|
-            range = condition.parent.loc.keyword.join(condition.source_range)
-            variable, = *condition
-            message = variable.array_type? ? ARRAY_MSG : MSG
-            add_offense(condition.parent, location: range, message: message)
-          end
-        end
-
-        def autocorrect(when_node)
-          lambda do |corrector|
-            if needs_reorder?(when_node)
-              reorder_condition(corrector, when_node)
-            else
-              inline_fix_branch(corrector, when_node)
-            end
-          end
-        end
-
-        private
-
-        def replacement(conditions)
-          reordered = conditions.partition(&:splat_type?).reverse
-          reordered.flatten.map(&:source).join(', ')
-        end
-
-        def inline_fix_branch(corrector, when_node)
-          conditions = when_node.conditions
-          range = range_between(conditions[0].loc.expression.begin_pos,
-                                conditions[-1].loc.expression.end_pos)
-
-          corrector.replace(range, replacement(conditions))
-        end
-
-        def reorder_condition(corrector, when_node)
-          when_branches = when_node.parent.when_branches
-
-          return if when_branches.one?
-
-          corrector.remove(when_branch_range(when_node))
-          corrector.insert_after(when_branches.last.source_range,
-                                 reordering_correction(when_node))
-        end
-
-        def reordering_correction(when_node)
-          new_condition = replacement(when_node.conditions)
-
-          if same_line?(when_node, when_node.body)
-            new_condition_with_then(when_node, new_condition)
-          else
-            new_branch_without_then(when_node, new_condition)
-          end
-        end
-
-        def when_branch_range(when_node)
-          next_branch =
-            when_node.parent.when_branches[when_node.branch_index + 1]
-
-          range_between(when_node.source_range.begin_pos,
-                        next_branch.source_range.begin_pos)
-        end
-
-        def new_condition_with_then(node, new_condition)
-          "\n#{indent_for(node)}when " \
-          "#{new_condition} then #{node.body.source}"
-        end
-
-        def new_branch_without_then(node, new_condition)
-          "\n#{indent_for(node)}when #{new_condition}" \
-          "\n#{indent_for(node.body)}#{node.body.source}"
-        end
-
-        def indent_for(node)
-          ' ' * node.loc.column
-        end
-
-        def splat_offenses(when_conditions)
-          found_non_splat = false
-
-          offenses = when_conditions.reverse.map do |condition|
-            found_non_splat ||= non_splat?(condition)
-
-            next if non_splat?(condition)
-
-            condition if found_non_splat
-          end
-
-          offenses.compact
-        end
-
-        def non_splat?(condition)
-          variable, = *condition
-
-          (condition.splat_type? && variable.array_type?) ||
-            !condition.splat_type?
-        end
-
-        def needs_reorder?(when_node)
-          following_branches =
-            when_node.parent.when_branches[(when_node.branch_index + 1)..-1]
-
-          following_branches.any? do |when_branch|
-            when_branch.conditions.any? do |condition|
-              non_splat?(condition)
-            end
-          end
-        end
-      end
-    end
-  end
-end