rubocop 0.66.0 → 1.25.1
Sign up to get free protection for your applications and to get access to all the features.
- checksums.yaml +4 -4
- data/LICENSE.txt +1 -1
- data/README.md +70 -43
- data/assets/output.html.erb +1 -1
- data/config/default.yml +1936 -1212
- data/config/obsoletion.yml +200 -0
- data/exe/rubocop +2 -4
- data/lib/rubocop/ast_aliases.rb +8 -0
- data/lib/rubocop/cached_data.rb +6 -6
- data/lib/rubocop/cli/command/auto_genenerate_config.rb +132 -0
- data/lib/rubocop/cli/command/base.rb +35 -0
- data/lib/rubocop/cli/command/execute_runner.rb +100 -0
- data/lib/rubocop/cli/command/init_dotfile.rb +44 -0
- data/lib/rubocop/cli/command/show_cops.rb +74 -0
- data/lib/rubocop/cli/command/show_docs_url.rb +48 -0
- data/lib/rubocop/cli/command/suggest_extensions.rb +81 -0
- data/lib/rubocop/cli/command/version.rb +18 -0
- data/lib/rubocop/cli/command.rb +22 -0
- data/lib/rubocop/cli/environment.rb +22 -0
- data/lib/rubocop/cli.rb +45 -200
- data/lib/rubocop/comment_config.rb +56 -99
- data/lib/rubocop/config.rb +92 -510
- data/lib/rubocop/config_loader.rb +150 -85
- data/lib/rubocop/config_loader_resolver.rb +129 -46
- data/lib/rubocop/config_obsoletion/changed_enforced_styles.rb +33 -0
- data/lib/rubocop/config_obsoletion/changed_parameter.rb +21 -0
- data/lib/rubocop/config_obsoletion/cop_rule.rb +33 -0
- data/lib/rubocop/config_obsoletion/extracted_cop.rb +44 -0
- data/lib/rubocop/config_obsoletion/parameter_rule.rb +44 -0
- data/lib/rubocop/config_obsoletion/removed_cop.rb +41 -0
- data/lib/rubocop/config_obsoletion/renamed_cop.rb +34 -0
- data/lib/rubocop/config_obsoletion/rule.rb +41 -0
- data/lib/rubocop/config_obsoletion/split_cop.rb +27 -0
- data/lib/rubocop/config_obsoletion.rb +103 -0
- data/lib/rubocop/config_regeneration.rb +33 -0
- data/lib/rubocop/config_store.rb +31 -7
- data/lib/rubocop/config_validator.rb +255 -0
- data/lib/rubocop/cop/autocorrect_logic.rb +78 -6
- data/lib/rubocop/cop/badge.rb +16 -32
- data/lib/rubocop/cop/base.rb +450 -0
- data/lib/rubocop/cop/bundler/duplicated_gem.rb +31 -7
- data/lib/rubocop/cop/bundler/gem_comment.rb +122 -15
- data/lib/rubocop/cop/bundler/gem_filename.rb +103 -0
- data/lib/rubocop/cop/bundler/gem_version.rb +133 -0
- data/lib/rubocop/cop/bundler/insecure_protocol_source.rb +47 -30
- data/lib/rubocop/cop/bundler/ordered_gems.rb +7 -18
- data/lib/rubocop/cop/commissioner.rb +103 -53
- data/lib/rubocop/cop/cop.rb +93 -191
- data/lib/rubocop/cop/corrector.rb +68 -122
- data/lib/rubocop/cop/correctors/alignment_corrector.rb +48 -32
- data/lib/rubocop/cop/correctors/condition_corrector.rb +3 -6
- data/lib/rubocop/cop/correctors/each_to_for_corrector.rb +4 -6
- data/lib/rubocop/cop/correctors/empty_line_corrector.rb +9 -10
- data/lib/rubocop/cop/correctors/for_to_each_corrector.rb +2 -3
- data/lib/rubocop/cop/correctors/if_then_corrector.rb +55 -0
- data/lib/rubocop/cop/correctors/lambda_literal_to_method_corrector.rb +11 -11
- data/lib/rubocop/cop/correctors/line_break_corrector.rb +9 -12
- data/lib/rubocop/cop/correctors/multiline_literal_brace_corrector.rb +37 -8
- data/lib/rubocop/cop/correctors/ordered_gem_corrector.rb +11 -12
- data/lib/rubocop/cop/correctors/parentheses_corrector.rb +6 -9
- data/lib/rubocop/cop/correctors/percent_literal_corrector.rb +11 -22
- data/lib/rubocop/cop/correctors/punctuation_corrector.rb +8 -10
- data/lib/rubocop/cop/correctors/require_library_corrector.rb +23 -0
- data/lib/rubocop/cop/correctors/space_corrector.rb +2 -5
- data/lib/rubocop/cop/correctors/string_literal_corrector.rb +6 -8
- data/lib/rubocop/cop/correctors/unused_arg_corrector.rb +17 -8
- data/lib/rubocop/cop/documentation.rb +39 -0
- data/lib/rubocop/cop/exclude_limit.rb +26 -0
- data/lib/rubocop/cop/force.rb +2 -1
- data/lib/rubocop/cop/gemspec/date_assignment.rb +49 -0
- data/lib/rubocop/cop/gemspec/duplicated_assignment.rb +8 -16
- data/lib/rubocop/cop/gemspec/ordered_dependencies.rb +8 -22
- data/lib/rubocop/cop/gemspec/require_mfa.rb +144 -0
- data/lib/rubocop/cop/gemspec/required_ruby_version.rb +74 -32
- data/lib/rubocop/cop/gemspec/ruby_version_globals_usage.rb +50 -0
- data/lib/rubocop/cop/generator/configuration_injector.rb +15 -11
- data/lib/rubocop/cop/generator/require_file_injector.rb +3 -6
- data/lib/rubocop/cop/generator.rb +43 -41
- data/lib/rubocop/cop/ignored_node.rb +1 -3
- data/lib/rubocop/cop/internal_affairs/empty_line_between_expect_offense_and_correction.rb +68 -0
- data/lib/rubocop/cop/internal_affairs/example_description.rb +92 -0
- data/lib/rubocop/cop/internal_affairs/inherit_deprecated_cop_class.rb +34 -0
- data/lib/rubocop/cop/internal_affairs/location_line_equality_comparison.rb +60 -0
- data/lib/rubocop/cop/internal_affairs/method_name_equal.rb +50 -0
- data/lib/rubocop/cop/internal_affairs/node_destructuring.rb +15 -17
- data/lib/rubocop/cop/internal_affairs/node_matcher_directive.rb +151 -0
- data/lib/rubocop/cop/internal_affairs/node_type_predicate.rb +13 -16
- data/lib/rubocop/cop/internal_affairs/offense_location_keyword.rb +14 -12
- data/lib/rubocop/cop/internal_affairs/redundant_described_class_as_subject.rb +62 -0
- data/lib/rubocop/cop/internal_affairs/redundant_let_rubocop_config_new.rb +65 -0
- data/lib/rubocop/cop/internal_affairs/redundant_location_argument.rb +15 -23
- data/lib/rubocop/cop/internal_affairs/redundant_message_argument.rb +14 -11
- data/lib/rubocop/cop/internal_affairs/redundant_method_dispatch_node.rb +47 -0
- data/lib/rubocop/cop/internal_affairs/style_detected_api_use.rb +148 -0
- data/lib/rubocop/cop/internal_affairs/undefined_config.rb +73 -0
- data/lib/rubocop/cop/internal_affairs/useless_message_assertion.rb +9 -9
- data/lib/rubocop/cop/internal_affairs.rb +12 -1
- data/lib/rubocop/cop/layout/access_modifier_indentation.rb +20 -29
- data/lib/rubocop/cop/layout/argument_alignment.rb +137 -0
- data/lib/rubocop/cop/layout/array_alignment.rb +84 -0
- data/lib/rubocop/cop/layout/{indent_assignment.rb → assignment_indentation.rb} +17 -7
- data/lib/rubocop/cop/layout/begin_end_alignment.rb +74 -0
- data/lib/rubocop/cop/layout/block_alignment.rb +43 -51
- data/lib/rubocop/cop/layout/block_end_newline.rb +9 -12
- data/lib/rubocop/cop/layout/case_indentation.rb +72 -30
- data/lib/rubocop/cop/layout/class_structure.rb +67 -78
- data/lib/rubocop/cop/layout/closing_heredoc_indentation.rb +8 -10
- data/lib/rubocop/cop/layout/closing_parenthesis_indentation.rb +28 -34
- data/lib/rubocop/cop/layout/comment_indentation.rb +61 -39
- data/lib/rubocop/cop/layout/condition_position.rb +17 -9
- data/lib/rubocop/cop/layout/def_end_alignment.rb +10 -11
- data/lib/rubocop/cop/layout/dot_position.rb +64 -26
- data/lib/rubocop/cop/layout/else_alignment.rb +30 -8
- data/lib/rubocop/cop/layout/empty_comment.rb +34 -43
- data/lib/rubocop/cop/layout/empty_line_after_guard_clause.rb +74 -35
- data/lib/rubocop/cop/layout/empty_line_after_magic_comment.rb +16 -16
- data/lib/rubocop/cop/layout/empty_line_after_multiline_condition.rb +136 -0
- data/lib/rubocop/cop/layout/empty_line_between_defs.rb +161 -39
- data/lib/rubocop/cop/layout/empty_lines.rb +8 -13
- data/lib/rubocop/cop/layout/empty_lines_around_access_modifier.rb +98 -38
- data/lib/rubocop/cop/layout/empty_lines_around_arguments.rb +14 -10
- data/lib/rubocop/cop/layout/empty_lines_around_attribute_accessor.rb +118 -0
- data/lib/rubocop/cop/layout/empty_lines_around_begin_body.rb +3 -6
- data/lib/rubocop/cop/layout/empty_lines_around_block_body.rb +5 -6
- data/lib/rubocop/cop/layout/empty_lines_around_class_body.rb +8 -14
- data/lib/rubocop/cop/layout/empty_lines_around_exception_handling_keywords.rb +16 -19
- data/lib/rubocop/cop/layout/empty_lines_around_method_body.rb +3 -6
- data/lib/rubocop/cop/layout/empty_lines_around_module_body.rb +4 -8
- data/lib/rubocop/cop/layout/end_alignment.rb +25 -24
- data/lib/rubocop/cop/layout/end_of_line.rb +18 -13
- data/lib/rubocop/cop/layout/extra_spacing.rb +39 -103
- data/lib/rubocop/cop/layout/first_argument_indentation.rb +276 -0
- data/lib/rubocop/cop/layout/{indent_array.rb → first_array_element_indentation.rb} +30 -24
- data/lib/rubocop/cop/layout/first_array_element_line_break.rb +4 -8
- data/lib/rubocop/cop/layout/{indent_hash.rb → first_hash_element_indentation.rb} +42 -26
- data/lib/rubocop/cop/layout/first_hash_element_line_break.rb +3 -7
- data/lib/rubocop/cop/layout/first_method_argument_line_break.rb +7 -13
- data/lib/rubocop/cop/layout/first_method_parameter_line_break.rb +3 -7
- data/lib/rubocop/cop/layout/first_parameter_indentation.rb +53 -196
- data/lib/rubocop/cop/layout/{align_hash.rb → hash_alignment.rb} +139 -60
- data/lib/rubocop/cop/layout/heredoc_argument_closing_parenthesis.rb +305 -0
- data/lib/rubocop/cop/layout/heredoc_indentation.rb +165 -0
- data/lib/rubocop/cop/layout/indentation_consistency.rb +23 -19
- data/lib/rubocop/cop/layout/indentation_style.rb +110 -0
- data/lib/rubocop/cop/layout/indentation_width.rb +66 -47
- data/lib/rubocop/cop/layout/initial_indentation.rb +8 -12
- data/lib/rubocop/cop/layout/leading_comment_space.rb +74 -13
- data/lib/rubocop/cop/layout/{leading_blank_lines.rb → leading_empty_lines.rb} +7 -12
- data/lib/rubocop/cop/layout/line_end_string_concatenation_indentation.rb +141 -0
- data/lib/rubocop/cop/layout/line_length.rb +269 -0
- data/lib/rubocop/cop/layout/multiline_array_brace_layout.rb +8 -11
- data/lib/rubocop/cop/layout/multiline_array_line_breaks.rb +35 -0
- data/lib/rubocop/cop/layout/multiline_assignment_layout.rb +40 -18
- data/lib/rubocop/cop/layout/multiline_block_layout.rb +68 -33
- data/lib/rubocop/cop/layout/multiline_hash_brace_layout.rb +8 -15
- data/lib/rubocop/cop/layout/multiline_hash_key_line_breaks.rb +46 -0
- data/lib/rubocop/cop/layout/multiline_method_argument_line_breaks.rb +50 -0
- data/lib/rubocop/cop/layout/multiline_method_call_brace_layout.rb +8 -11
- data/lib/rubocop/cop/layout/multiline_method_call_indentation.rb +34 -25
- data/lib/rubocop/cop/layout/multiline_method_definition_brace_layout.rb +8 -11
- data/lib/rubocop/cop/layout/multiline_operation_indentation.rb +26 -12
- data/lib/rubocop/cop/layout/parameter_alignment.rb +119 -0
- data/lib/rubocop/cop/layout/redundant_line_break.rb +140 -0
- data/lib/rubocop/cop/layout/rescue_ensure_alignment.rb +75 -39
- data/lib/rubocop/cop/layout/single_line_block_chain.rb +64 -0
- data/lib/rubocop/cop/layout/space_after_colon.rb +12 -10
- data/lib/rubocop/cop/layout/space_after_comma.rb +2 -5
- data/lib/rubocop/cop/layout/space_after_method_name.rb +8 -11
- data/lib/rubocop/cop/layout/space_after_not.rb +11 -12
- data/lib/rubocop/cop/layout/space_after_semicolon.rb +2 -5
- data/lib/rubocop/cop/layout/space_around_block_parameters.rb +50 -53
- data/lib/rubocop/cop/layout/space_around_equals_in_parameter_default.rb +21 -24
- data/lib/rubocop/cop/layout/space_around_keyword.rb +69 -33
- data/lib/rubocop/cop/layout/space_around_method_call_operator.rb +98 -0
- data/lib/rubocop/cop/layout/space_around_operators.rb +148 -53
- data/lib/rubocop/cop/layout/space_before_block_braces.rb +55 -22
- data/lib/rubocop/cop/layout/space_before_brackets.rb +66 -0
- data/lib/rubocop/cop/layout/space_before_comma.rb +3 -5
- data/lib/rubocop/cop/layout/space_before_comment.rb +11 -12
- data/lib/rubocop/cop/layout/space_before_first_arg.rb +21 -15
- data/lib/rubocop/cop/layout/space_before_semicolon.rb +2 -5
- data/lib/rubocop/cop/layout/space_in_lambda_literal.rb +23 -39
- data/lib/rubocop/cop/layout/space_inside_array_literal_brackets.rb +39 -45
- data/lib/rubocop/cop/layout/space_inside_array_percent_literal.rb +6 -16
- data/lib/rubocop/cop/layout/space_inside_block_braces.rb +53 -39
- data/lib/rubocop/cop/layout/space_inside_hash_literal_braces.rb +23 -49
- data/lib/rubocop/cop/layout/space_inside_parens.rb +96 -33
- data/lib/rubocop/cop/layout/space_inside_percent_literal_delimiters.rb +6 -11
- data/lib/rubocop/cop/layout/space_inside_range_literal.rb +10 -19
- data/lib/rubocop/cop/layout/space_inside_reference_brackets.rb +20 -32
- data/lib/rubocop/cop/layout/space_inside_string_interpolation.rb +25 -42
- data/lib/rubocop/cop/layout/{trailing_blank_lines.rb → trailing_empty_lines.rb} +11 -16
- data/lib/rubocop/cop/layout/trailing_whitespace.rb +79 -16
- data/lib/rubocop/cop/legacy/corrections_proxy.rb +43 -0
- data/lib/rubocop/cop/legacy/corrector.rb +27 -0
- data/lib/rubocop/cop/lint/ambiguous_assignment.rb +54 -0
- data/lib/rubocop/cop/lint/ambiguous_block_association.rb +22 -10
- data/lib/rubocop/cop/lint/ambiguous_operator.rb +59 -11
- data/lib/rubocop/cop/lint/ambiguous_operator_precedence.rb +111 -0
- data/lib/rubocop/cop/lint/ambiguous_range.rb +105 -0
- data/lib/rubocop/cop/lint/ambiguous_regexp_literal.rb +44 -7
- data/lib/rubocop/cop/lint/assignment_in_condition.rb +28 -13
- data/lib/rubocop/cop/lint/big_decimal_new.rb +12 -12
- data/lib/rubocop/cop/lint/binary_operator_with_identical_operands.rb +68 -0
- data/lib/rubocop/cop/lint/boolean_symbol.rb +29 -4
- data/lib/rubocop/cop/lint/circular_argument_reference.rb +2 -2
- data/lib/rubocop/cop/lint/constant_definition_in_block.rb +100 -0
- data/lib/rubocop/cop/lint/constant_resolution.rb +89 -0
- data/lib/rubocop/cop/lint/debugger.rb +61 -25
- data/lib/rubocop/cop/lint/deprecated_class_methods.rb +98 -47
- data/lib/rubocop/cop/lint/deprecated_constants.rb +81 -0
- data/lib/rubocop/cop/lint/deprecated_open_ssl_constant.rb +154 -0
- data/lib/rubocop/cop/lint/disjunctive_assignment_in_constructor.rb +34 -5
- data/lib/rubocop/cop/lint/duplicate_branch.rb +155 -0
- data/lib/rubocop/cop/lint/duplicate_case_condition.rb +4 -14
- data/lib/rubocop/cop/lint/duplicate_elsif_condition.rb +39 -0
- data/lib/rubocop/cop/lint/{duplicated_key.rb → duplicate_hash_key.rb} +3 -5
- data/lib/rubocop/cop/lint/duplicate_methods.rb +28 -31
- data/lib/rubocop/cop/lint/duplicate_regexp_character_class_element.rb +77 -0
- data/lib/rubocop/cop/lint/duplicate_require.rb +47 -0
- data/lib/rubocop/cop/lint/duplicate_rescue_exception.rb +47 -0
- data/lib/rubocop/cop/lint/each_with_object_argument.rb +6 -4
- data/lib/rubocop/cop/lint/else_layout.rb +38 -10
- data/lib/rubocop/cop/lint/empty_block.rb +98 -0
- data/lib/rubocop/cop/lint/empty_class.rb +93 -0
- data/lib/rubocop/cop/lint/empty_conditional_body.rb +67 -0
- data/lib/rubocop/cop/lint/empty_ensure.rb +6 -8
- data/lib/rubocop/cop/lint/empty_expression.rb +3 -3
- data/lib/rubocop/cop/lint/empty_file.rb +48 -0
- data/lib/rubocop/cop/lint/empty_in_pattern.rb +62 -0
- data/lib/rubocop/cop/lint/empty_interpolation.rb +8 -11
- data/lib/rubocop/cop/lint/empty_when.rb +32 -9
- data/lib/rubocop/cop/lint/ensure_return.rb +30 -17
- data/lib/rubocop/cop/lint/erb_new_arguments.rb +65 -10
- data/lib/rubocop/cop/lint/flip_flop.rb +10 -4
- data/lib/rubocop/cop/lint/float_comparison.rb +93 -0
- data/lib/rubocop/cop/lint/float_out_of_range.rb +3 -4
- data/lib/rubocop/cop/lint/format_parameter_mismatch.rb +63 -59
- data/lib/rubocop/cop/lint/hash_compare_by_identity.rb +47 -0
- data/lib/rubocop/cop/lint/heredoc_method_call_position.rb +154 -0
- data/lib/rubocop/cop/lint/identity_comparison.rb +51 -0
- data/lib/rubocop/cop/lint/implicit_string_concatenation.rb +12 -12
- data/lib/rubocop/cop/lint/incompatible_io_select_with_fiber_scheduler.rb +72 -0
- data/lib/rubocop/cop/lint/ineffective_access_modifier.rb +18 -24
- data/lib/rubocop/cop/lint/inherit_exception.rb +33 -8
- data/lib/rubocop/cop/lint/interpolation_check.rb +26 -8
- data/lib/rubocop/cop/lint/lambda_without_literal_block.rb +44 -0
- data/lib/rubocop/cop/lint/literal_as_condition.rb +38 -17
- data/lib/rubocop/cop/lint/literal_in_interpolation.rb +65 -20
- data/lib/rubocop/cop/lint/loop.rb +32 -9
- data/lib/rubocop/cop/lint/missing_cop_enable_directive.rb +36 -24
- data/lib/rubocop/cop/lint/missing_super.rb +101 -0
- data/lib/rubocop/cop/lint/mixed_regexp_capture_types.rb +36 -0
- data/lib/rubocop/cop/lint/multiple_comparison.rb +48 -0
- data/lib/rubocop/cop/lint/nested_method_definition.rb +24 -28
- data/lib/rubocop/cop/lint/nested_percent_literal.rb +18 -6
- data/lib/rubocop/cop/lint/next_without_accumulator.rb +4 -3
- data/lib/rubocop/cop/lint/no_return_in_begin_end_blocks.rb +58 -0
- data/lib/rubocop/cop/lint/non_deterministic_require_order.rb +173 -0
- data/lib/rubocop/cop/lint/non_local_exit_from_iterator.rb +17 -16
- data/lib/rubocop/cop/lint/number_conversion.rb +122 -12
- data/lib/rubocop/cop/lint/numbered_parameter_assignment.rb +47 -0
- data/lib/rubocop/cop/lint/or_assignment_to_constant.rb +41 -0
- data/lib/rubocop/cop/lint/ordered_magic_comments.rb +12 -15
- data/lib/rubocop/cop/lint/out_of_range_regexp_ref.rb +113 -0
- data/lib/rubocop/cop/lint/parentheses_as_grouped_expression.rb +36 -14
- data/lib/rubocop/cop/lint/percent_string_array.rb +17 -12
- data/lib/rubocop/cop/lint/percent_symbol_array.rb +13 -14
- data/lib/rubocop/cop/lint/raise_exception.rb +91 -0
- data/lib/rubocop/cop/lint/rand_one.rb +6 -5
- data/lib/rubocop/cop/lint/redundant_cop_disable_directive.rb +290 -0
- data/lib/rubocop/cop/lint/redundant_cop_enable_directive.rb +133 -0
- data/lib/rubocop/cop/lint/redundant_dir_glob_sort.rb +50 -0
- data/lib/rubocop/cop/lint/{unneeded_require_statement.rb → redundant_require_statement.rb} +11 -12
- data/lib/rubocop/cop/lint/redundant_safe_navigation.rb +78 -0
- data/lib/rubocop/cop/lint/{unneeded_splat_expansion.rb → redundant_splat_expansion.rb} +88 -46
- data/lib/rubocop/cop/lint/{string_conversion_in_interpolation.rb → redundant_string_coercion.rb} +14 -21
- data/lib/rubocop/cop/lint/redundant_with_index.rb +17 -22
- data/lib/rubocop/cop/lint/redundant_with_object.rb +17 -22
- data/lib/rubocop/cop/lint/regexp_as_condition.rb +5 -3
- data/lib/rubocop/cop/lint/require_parentheses.rb +4 -6
- data/lib/rubocop/cop/lint/require_relative_self_path.rb +50 -0
- data/lib/rubocop/cop/lint/rescue_exception.rb +3 -4
- data/lib/rubocop/cop/lint/rescue_type.rb +11 -17
- data/lib/rubocop/cop/lint/return_in_void_context.rb +5 -8
- data/lib/rubocop/cop/lint/safe_navigation_chain.rb +13 -20
- data/lib/rubocop/cop/lint/safe_navigation_consistency.rb +16 -18
- data/lib/rubocop/cop/lint/safe_navigation_with_empty.rb +13 -5
- data/lib/rubocop/cop/lint/script_permission.rb +12 -9
- data/lib/rubocop/cop/lint/self_assignment.rb +78 -0
- data/lib/rubocop/cop/lint/send_with_mixin_argument.rb +83 -0
- data/lib/rubocop/cop/lint/shadowed_argument.rb +9 -15
- data/lib/rubocop/cop/lint/shadowed_exception.rb +19 -31
- data/lib/rubocop/cop/lint/shadowing_outer_local_variable.rb +22 -8
- data/lib/rubocop/cop/lint/struct_new_override.rb +59 -0
- data/lib/rubocop/cop/lint/suppressed_exception.rb +132 -0
- data/lib/rubocop/cop/lint/symbol_conversion.rb +178 -0
- data/lib/rubocop/cop/lint/syntax.rb +11 -30
- data/lib/rubocop/cop/lint/to_enum_arguments.rb +89 -0
- data/lib/rubocop/cop/lint/to_json.rb +25 -14
- data/lib/rubocop/cop/lint/top_level_return_with_argument.rb +34 -0
- data/lib/rubocop/cop/lint/trailing_comma_in_attribute_declaration.rb +55 -0
- data/lib/rubocop/cop/lint/triple_quotes.rb +71 -0
- data/lib/rubocop/cop/lint/underscore_prefixed_variable_name.rb +31 -13
- data/lib/rubocop/cop/lint/unexpected_block_arity.rb +90 -0
- data/lib/rubocop/cop/lint/unified_integer.rb +7 -8
- data/lib/rubocop/cop/lint/unmodified_reduce_accumulator.rb +204 -0
- data/lib/rubocop/cop/lint/unreachable_code.rb +7 -9
- data/lib/rubocop/cop/lint/unreachable_loop.rb +196 -0
- data/lib/rubocop/cop/lint/unused_block_argument.rb +40 -17
- data/lib/rubocop/cop/lint/unused_method_argument.rb +65 -17
- data/lib/rubocop/cop/lint/uri_escape_unescape.rb +7 -4
- data/lib/rubocop/cop/lint/uri_regexp.rb +12 -47
- data/lib/rubocop/cop/lint/useless_access_modifier.rb +101 -51
- data/lib/rubocop/cop/lint/useless_assignment.rb +13 -21
- data/lib/rubocop/cop/lint/useless_else_without_rescue.rb +10 -11
- data/lib/rubocop/cop/lint/useless_method_definition.rb +69 -0
- data/lib/rubocop/cop/lint/useless_ruby2_keywords.rb +117 -0
- data/lib/rubocop/cop/lint/useless_setter_call.rb +21 -13
- data/lib/rubocop/cop/lint/useless_times.rb +110 -0
- data/lib/rubocop/cop/lint/void.rb +20 -50
- data/lib/rubocop/cop/message_annotator.rb +21 -10
- data/lib/rubocop/cop/metrics/abc_size.rb +33 -3
- data/lib/rubocop/cop/metrics/block_length.rb +43 -12
- data/lib/rubocop/cop/metrics/block_nesting.rb +5 -10
- data/lib/rubocop/cop/metrics/class_length.rb +40 -11
- data/lib/rubocop/cop/metrics/cyclomatic_complexity.rb +29 -6
- data/lib/rubocop/cop/metrics/method_length.rb +35 -6
- data/lib/rubocop/cop/metrics/module_length.rb +30 -10
- data/lib/rubocop/cop/metrics/parameter_lists.rb +79 -13
- data/lib/rubocop/cop/metrics/perceived_complexity.rb +8 -11
- data/lib/rubocop/cop/metrics/utils/abc_size_calculator.rb +96 -18
- data/lib/rubocop/cop/metrics/utils/code_length_calculator.rb +160 -0
- data/lib/rubocop/cop/metrics/utils/iterating_block.rb +61 -0
- data/lib/rubocop/cop/metrics/utils/repeated_attribute_discount.rb +143 -0
- data/lib/rubocop/cop/metrics/utils/repeated_csend_discount.rb +42 -0
- data/lib/rubocop/cop/migration/department_name.rb +81 -0
- data/lib/rubocop/cop/mixin/alignment.rb +20 -13
- data/lib/rubocop/cop/mixin/allowed_identifiers.rb +18 -0
- data/lib/rubocop/cop/mixin/allowed_methods.rb +21 -0
- data/lib/rubocop/cop/mixin/annotation_comment.rb +57 -29
- data/lib/rubocop/cop/mixin/array_min_size.rb +2 -4
- data/lib/rubocop/cop/mixin/auto_corrector.rb +12 -0
- data/lib/rubocop/cop/mixin/check_assignment.rb +1 -1
- data/lib/rubocop/cop/mixin/check_line_breakable.rb +223 -0
- data/lib/rubocop/cop/mixin/code_length.rb +30 -9
- data/lib/rubocop/cop/mixin/comments_help.rb +42 -0
- data/lib/rubocop/cop/mixin/configurable_enforced_style.rb +7 -5
- data/lib/rubocop/cop/mixin/configurable_formatting.rb +4 -11
- data/lib/rubocop/cop/mixin/configurable_max.rb +1 -0
- data/lib/rubocop/cop/mixin/configurable_naming.rb +2 -2
- data/lib/rubocop/cop/mixin/configurable_numbering.rb +4 -3
- data/lib/rubocop/cop/mixin/def_node.rb +4 -6
- data/lib/rubocop/cop/mixin/documentation_comment.rb +9 -11
- data/lib/rubocop/cop/mixin/empty_lines_around_body.rb +15 -15
- data/lib/rubocop/cop/mixin/empty_parameter.rb +3 -2
- data/lib/rubocop/cop/mixin/end_keyword_alignment.rb +18 -5
- data/lib/rubocop/cop/mixin/enforce_superclass.rb +24 -11
- data/lib/rubocop/cop/mixin/first_element_line_break.rb +3 -3
- data/lib/rubocop/cop/mixin/frozen_string_literal.rb +43 -13
- data/lib/rubocop/cop/mixin/gem_declaration.rb +13 -0
- data/lib/rubocop/cop/mixin/gemspec_help.rb +30 -0
- data/lib/rubocop/cop/mixin/{hash_alignment.rb → hash_alignment_styles.rb} +25 -12
- data/lib/rubocop/cop/mixin/hash_shorthand_syntax.rb +82 -0
- data/lib/rubocop/cop/mixin/hash_transform_method.rb +188 -0
- data/lib/rubocop/cop/mixin/heredoc.rb +5 -0
- data/lib/rubocop/cop/mixin/ignored_methods.rb +36 -3
- data/lib/rubocop/cop/mixin/ignored_pattern.rb +1 -1
- data/lib/rubocop/cop/mixin/interpolation.rb +25 -0
- data/lib/rubocop/cop/mixin/line_length_help.rb +90 -0
- data/lib/rubocop/cop/mixin/match_range.rb +2 -5
- data/lib/rubocop/cop/mixin/method_complexity.rb +29 -8
- data/lib/rubocop/cop/mixin/method_preference.rb +1 -2
- data/lib/rubocop/cop/mixin/min_body_length.rb +1 -1
- data/lib/rubocop/cop/mixin/{array_hash_indentation.rb → multiline_element_indentation.rb} +8 -6
- data/lib/rubocop/cop/mixin/multiline_element_line_breaks.rb +33 -0
- data/lib/rubocop/cop/mixin/multiline_expression_indentation.rb +18 -47
- data/lib/rubocop/cop/mixin/multiline_literal_brace_layout.rb +15 -15
- data/lib/rubocop/cop/mixin/negative_conditional.rb +6 -4
- data/lib/rubocop/cop/mixin/nil_methods.rb +4 -6
- data/lib/rubocop/cop/mixin/ordered_gem_node.rb +16 -6
- data/lib/rubocop/cop/mixin/parentheses.rb +1 -2
- data/lib/rubocop/cop/mixin/percent_array.rb +31 -15
- data/lib/rubocop/cop/mixin/percent_literal.rb +0 -6
- data/lib/rubocop/cop/mixin/preceding_following_alignment.rb +94 -5
- data/lib/rubocop/cop/mixin/preferred_delimiters.rb +6 -9
- data/lib/rubocop/cop/mixin/range_help.rb +25 -14
- data/lib/rubocop/cop/mixin/rational_literal.rb +19 -0
- data/lib/rubocop/cop/mixin/require_library.rb +59 -0
- data/lib/rubocop/cop/mixin/rescue_node.rb +13 -8
- data/lib/rubocop/cop/mixin/safe_assignment.rb +6 -2
- data/lib/rubocop/cop/mixin/space_after_punctuation.rb +7 -8
- data/lib/rubocop/cop/mixin/space_before_punctuation.rb +8 -8
- data/lib/rubocop/cop/mixin/statement_modifier.rb +49 -23
- data/lib/rubocop/cop/mixin/string_help.rb +4 -1
- data/lib/rubocop/cop/mixin/string_literals_help.rb +3 -5
- data/lib/rubocop/cop/mixin/surrounding_space.rb +22 -36
- data/lib/rubocop/cop/mixin/symbol_help.rb +13 -0
- data/lib/rubocop/cop/mixin/target_ruby_version.rb +5 -1
- data/lib/rubocop/cop/mixin/trailing_body.rb +2 -3
- data/lib/rubocop/cop/mixin/trailing_comma.rb +27 -34
- data/lib/rubocop/cop/mixin/uncommunicative_name.rb +31 -33
- data/lib/rubocop/cop/mixin/unused_argument.rb +5 -9
- data/lib/rubocop/cop/mixin/visibility_help.rb +37 -0
- data/lib/rubocop/cop/naming/accessor_method_name.rb +21 -5
- data/lib/rubocop/cop/naming/ascii_identifiers.rb +29 -11
- data/lib/rubocop/cop/naming/binary_operator_parameter_name.rb +18 -8
- data/lib/rubocop/cop/naming/block_forwarding.rb +121 -0
- data/lib/rubocop/cop/naming/{uncommunicative_block_param_name.rb → block_parameter_name.rb} +4 -4
- data/lib/rubocop/cop/naming/class_and_module_camel_case.rb +14 -4
- data/lib/rubocop/cop/naming/constant_name.rb +12 -9
- data/lib/rubocop/cop/naming/file_name.rb +81 -39
- data/lib/rubocop/cop/naming/heredoc_delimiter_case.rb +13 -7
- data/lib/rubocop/cop/naming/heredoc_delimiter_naming.rb +9 -9
- data/lib/rubocop/cop/naming/inclusive_language.rb +266 -0
- data/lib/rubocop/cop/naming/memoized_instance_variable_name.rb +136 -27
- data/lib/rubocop/cop/naming/method_name.rb +42 -3
- data/lib/rubocop/cop/naming/{uncommunicative_method_param_name.rb → method_parameter_name.rb} +4 -4
- data/lib/rubocop/cop/naming/predicate_name.rb +14 -17
- data/lib/rubocop/cop/naming/rescued_exceptions_variable_name.rb +163 -0
- data/lib/rubocop/cop/naming/variable_name.rb +5 -2
- data/lib/rubocop/cop/naming/variable_number.rb +94 -9
- data/lib/rubocop/cop/offense.rb +64 -19
- data/lib/rubocop/cop/registry.rb +122 -25
- data/lib/rubocop/cop/security/eval.rb +6 -4
- data/lib/rubocop/cop/security/io_methods.rb +49 -0
- data/lib/rubocop/cop/security/json_load.rb +18 -17
- data/lib/rubocop/cop/security/marshal_load.rb +6 -6
- data/lib/rubocop/cop/security/open.rb +30 -12
- data/lib/rubocop/cop/security/yaml_load.rb +14 -8
- data/lib/rubocop/cop/severity.rb +4 -14
- data/lib/rubocop/cop/style/access_modifier_declarations.rb +37 -12
- data/lib/rubocop/cop/style/accessor_grouping.rb +150 -0
- data/lib/rubocop/cop/style/alias.rb +52 -45
- data/lib/rubocop/cop/style/and_or.rb +36 -24
- data/lib/rubocop/cop/style/arguments_forwarding.rb +154 -0
- data/lib/rubocop/cop/style/array_coercion.rb +87 -0
- data/lib/rubocop/cop/style/array_join.rb +10 -10
- data/lib/rubocop/cop/style/ascii_comments.rb +7 -11
- data/lib/rubocop/cop/style/attr.rb +22 -14
- data/lib/rubocop/cop/style/auto_resource_cleanup.rb +10 -13
- data/lib/rubocop/cop/style/bare_percent_literals.rb +13 -15
- data/lib/rubocop/cop/style/begin_block.rb +3 -3
- data/lib/rubocop/cop/style/bisected_attr_accessor/macro.rb +60 -0
- data/lib/rubocop/cop/style/bisected_attr_accessor.rb +125 -0
- data/lib/rubocop/cop/style/block_comments.rb +24 -20
- data/lib/rubocop/cop/style/block_delimiters.rb +145 -30
- data/lib/rubocop/cop/style/case_equality.rb +54 -6
- data/lib/rubocop/cop/style/case_like_if.rb +263 -0
- data/lib/rubocop/cop/style/character_literal.rb +20 -16
- data/lib/rubocop/cop/style/class_and_module_children.rb +84 -44
- data/lib/rubocop/cop/style/class_check.rb +7 -12
- data/lib/rubocop/cop/style/class_equality_comparison.rb +67 -0
- data/lib/rubocop/cop/style/class_methods.rb +16 -30
- data/lib/rubocop/cop/style/class_methods_definitions.rb +157 -0
- data/lib/rubocop/cop/style/class_vars.rb +23 -7
- data/lib/rubocop/cop/style/collection_compact.rb +111 -0
- data/lib/rubocop/cop/style/collection_methods.rb +32 -21
- data/lib/rubocop/cop/style/colon_method_call.rb +9 -11
- data/lib/rubocop/cop/style/colon_method_definition.rb +7 -7
- data/lib/rubocop/cop/style/combinable_loops.rb +93 -0
- data/lib/rubocop/cop/style/command_literal.rb +24 -30
- data/lib/rubocop/cop/style/comment_annotation.rb +68 -35
- data/lib/rubocop/cop/style/commented_keyword.rb +39 -34
- data/lib/rubocop/cop/style/conditional_assignment.rb +123 -155
- data/lib/rubocop/cop/style/constant_visibility.rb +46 -6
- data/lib/rubocop/cop/style/copyright.rb +28 -27
- data/lib/rubocop/cop/style/date_time.rb +26 -10
- data/lib/rubocop/cop/style/def_with_parentheses.rb +9 -12
- data/lib/rubocop/cop/style/dir.rb +12 -13
- data/lib/rubocop/cop/style/disable_cops_within_source_code_directive.rb +87 -0
- data/lib/rubocop/cop/style/document_dynamic_eval_definition.rb +169 -0
- data/lib/rubocop/cop/style/documentation.rb +113 -28
- data/lib/rubocop/cop/style/documentation_method.rb +48 -3
- data/lib/rubocop/cop/style/double_cop_disable_directive.rb +46 -0
- data/lib/rubocop/cop/style/double_negation.rb +76 -11
- data/lib/rubocop/cop/style/each_for_simple_loop.rb +8 -11
- data/lib/rubocop/cop/style/each_with_object.rb +21 -23
- data/lib/rubocop/cop/style/empty_block_parameter.rb +10 -11
- data/lib/rubocop/cop/style/empty_case_condition.rb +33 -27
- data/lib/rubocop/cop/style/empty_else.rb +16 -24
- data/lib/rubocop/cop/style/empty_lambda_parameter.rb +10 -11
- data/lib/rubocop/cop/style/empty_literal.rb +48 -33
- data/lib/rubocop/cop/style/empty_method.rb +15 -26
- data/lib/rubocop/cop/style/encoding.rb +30 -23
- data/lib/rubocop/cop/style/end_block.rb +7 -4
- data/lib/rubocop/cop/style/endless_method.rb +101 -0
- data/lib/rubocop/cop/style/eval_with_location.rb +146 -57
- data/lib/rubocop/cop/style/even_odd.rb +12 -14
- data/lib/rubocop/cop/style/expand_path_arguments.rb +34 -32
- data/lib/rubocop/cop/style/explicit_block_argument.rb +149 -0
- data/lib/rubocop/cop/style/exponential_notation.rb +116 -0
- data/lib/rubocop/cop/style/file_read.rb +112 -0
- data/lib/rubocop/cop/style/file_write.rb +124 -0
- data/lib/rubocop/cop/style/float_division.rb +151 -0
- data/lib/rubocop/cop/style/for.rb +9 -15
- data/lib/rubocop/cop/style/format_string.rb +58 -48
- data/lib/rubocop/cop/style/format_string_token.rb +85 -77
- data/lib/rubocop/cop/style/frozen_string_literal_comment.rb +118 -83
- data/lib/rubocop/cop/style/global_std_stream.rb +70 -0
- data/lib/rubocop/cop/style/global_vars.rb +3 -3
- data/lib/rubocop/cop/style/guard_clause.rb +65 -16
- data/lib/rubocop/cop/style/hash_as_last_array_item.rb +99 -0
- data/lib/rubocop/cop/style/hash_conversion.rb +134 -0
- data/lib/rubocop/cop/style/hash_each_methods.rb +108 -0
- data/lib/rubocop/cop/style/hash_except.rb +97 -0
- data/lib/rubocop/cop/style/hash_like_case.rb +77 -0
- data/lib/rubocop/cop/style/hash_syntax.rb +91 -50
- data/lib/rubocop/cop/style/hash_transform_keys.rb +90 -0
- data/lib/rubocop/cop/style/hash_transform_values.rb +90 -0
- data/lib/rubocop/cop/style/identical_conditional_branches.rb +92 -12
- data/lib/rubocop/cop/style/if_inside_else.rb +109 -4
- data/lib/rubocop/cop/style/if_unless_modifier.rb +148 -41
- data/lib/rubocop/cop/style/if_unless_modifier_of_if_unless.rb +12 -4
- data/lib/rubocop/cop/style/if_with_boolean_literal_branches.rb +136 -0
- data/lib/rubocop/cop/style/if_with_semicolon.rb +52 -4
- data/lib/rubocop/cop/style/implicit_runtime_error.rb +4 -2
- data/lib/rubocop/cop/style/in_pattern_then.rb +56 -0
- data/lib/rubocop/cop/style/infinite_loop.rb +33 -30
- data/lib/rubocop/cop/style/inline_comment.rb +5 -5
- data/lib/rubocop/cop/style/inverse_methods.rb +71 -46
- data/lib/rubocop/cop/style/ip_addresses.rb +8 -9
- data/lib/rubocop/cop/style/keyword_parameters_order.rb +75 -0
- data/lib/rubocop/cop/style/lambda.rb +21 -25
- data/lib/rubocop/cop/style/lambda_call.rb +18 -35
- data/lib/rubocop/cop/style/line_end_concatenation.rb +50 -37
- data/lib/rubocop/cop/style/map_to_hash.rb +68 -0
- data/lib/rubocop/cop/style/method_call_with_args_parentheses/omit_parentheses.rb +210 -0
- data/lib/rubocop/cop/style/method_call_with_args_parentheses/require_parentheses.rb +44 -0
- data/lib/rubocop/cop/style/method_call_with_args_parentheses.rb +95 -222
- data/lib/rubocop/cop/style/method_call_without_args_parentheses.rb +19 -12
- data/lib/rubocop/cop/style/method_called_on_do_end_block.rb +15 -8
- data/lib/rubocop/cop/style/method_def_parentheses.rb +42 -27
- data/lib/rubocop/cop/style/min_max.rb +12 -16
- data/lib/rubocop/cop/style/missing_else.rb +21 -26
- data/lib/rubocop/cop/style/missing_respond_to_missing.rb +11 -5
- data/lib/rubocop/cop/style/mixin_grouping.rb +34 -49
- data/lib/rubocop/cop/style/mixin_usage.rb +15 -23
- data/lib/rubocop/cop/style/module_function.rb +76 -33
- data/lib/rubocop/cop/style/multiline_block_chain.rb +15 -7
- data/lib/rubocop/cop/style/multiline_if_modifier.rb +5 -12
- data/lib/rubocop/cop/style/multiline_if_then.rb +6 -12
- data/lib/rubocop/cop/style/multiline_in_pattern_then.rb +62 -0
- data/lib/rubocop/cop/style/multiline_memoization.rb +16 -14
- data/lib/rubocop/cop/style/multiline_method_signature.rb +34 -4
- data/lib/rubocop/cop/style/multiline_ternary_operator.rb +32 -11
- data/lib/rubocop/cop/style/multiline_when_then.rb +66 -0
- data/lib/rubocop/cop/style/multiple_comparison.rb +77 -12
- data/lib/rubocop/cop/style/mutable_constant.rb +120 -47
- data/lib/rubocop/cop/style/negated_if.rb +11 -12
- data/lib/rubocop/cop/style/negated_if_else_condition.rb +128 -0
- data/lib/rubocop/cop/style/negated_unless.rb +88 -0
- data/lib/rubocop/cop/style/negated_while.rb +7 -15
- data/lib/rubocop/cop/style/nested_modifier.rb +34 -23
- data/lib/rubocop/cop/style/nested_parenthesized_calls.rb +26 -23
- data/lib/rubocop/cop/style/nested_ternary_operator.rb +30 -4
- data/lib/rubocop/cop/style/next.rb +42 -51
- data/lib/rubocop/cop/style/nil_comparison.rb +21 -13
- data/lib/rubocop/cop/style/nil_lambda.rb +70 -0
- data/lib/rubocop/cop/style/non_nil_check.rb +76 -42
- data/lib/rubocop/cop/style/not.rb +23 -29
- data/lib/rubocop/cop/style/numbered_parameters.rb +46 -0
- data/lib/rubocop/cop/style/numbered_parameters_limit.rb +50 -0
- data/lib/rubocop/cop/style/numeric_literal_prefix.rb +11 -16
- data/lib/rubocop/cop/style/numeric_literals.rb +36 -32
- data/lib/rubocop/cop/style/numeric_predicate.rb +27 -37
- data/lib/rubocop/cop/style/one_line_conditional.rb +61 -34
- data/lib/rubocop/cop/style/open_struct_use.rb +69 -0
- data/lib/rubocop/cop/style/option_hash.rb +8 -9
- data/lib/rubocop/cop/style/optional_arguments.rb +8 -10
- data/lib/rubocop/cop/style/optional_boolean_parameter.rb +63 -0
- data/lib/rubocop/cop/style/or_assignment.rb +23 -16
- data/lib/rubocop/cop/style/parallel_assignment.rb +30 -27
- data/lib/rubocop/cop/style/parentheses_around_condition.rb +34 -9
- data/lib/rubocop/cop/style/percent_literal_delimiters.rb +22 -30
- data/lib/rubocop/cop/style/percent_q_literals.rb +12 -15
- data/lib/rubocop/cop/style/perl_backrefs.rb +84 -16
- data/lib/rubocop/cop/style/preferred_hash_methods.rb +22 -23
- data/lib/rubocop/cop/style/proc.rb +9 -9
- data/lib/rubocop/cop/style/quoted_symbols.rb +124 -0
- data/lib/rubocop/cop/style/raise_args.rb +41 -37
- data/lib/rubocop/cop/style/random_with_offset.rb +70 -78
- data/lib/rubocop/cop/style/redundant_argument.rb +95 -0
- data/lib/rubocop/cop/style/redundant_assignment.rb +106 -0
- data/lib/rubocop/cop/style/redundant_begin.rb +101 -14
- data/lib/rubocop/cop/style/{unneeded_capital_w.rb → redundant_capital_w.rb} +7 -11
- data/lib/rubocop/cop/style/redundant_condition.rb +136 -0
- data/lib/rubocop/cop/style/redundant_conditional.rb +16 -17
- data/lib/rubocop/cop/style/redundant_exception.rb +25 -20
- data/lib/rubocop/cop/style/redundant_fetch_block.rb +119 -0
- data/lib/rubocop/cop/style/redundant_file_extension_in_require.rb +61 -0
- data/lib/rubocop/cop/style/redundant_freeze.rb +17 -15
- data/lib/rubocop/cop/style/redundant_interpolation.rb +117 -0
- data/lib/rubocop/cop/style/redundant_parentheses.rb +71 -49
- data/lib/rubocop/cop/style/{unneeded_percent_q.rb → redundant_percent_q.rb} +22 -26
- data/lib/rubocop/cop/style/redundant_regexp_character_class.rb +108 -0
- data/lib/rubocop/cop/style/redundant_regexp_escape.rb +118 -0
- data/lib/rubocop/cop/style/redundant_return.rb +64 -62
- data/lib/rubocop/cop/style/redundant_self.rb +71 -24
- data/lib/rubocop/cop/style/redundant_self_assignment.rb +119 -0
- data/lib/rubocop/cop/style/redundant_self_assignment_branch.rb +83 -0
- data/lib/rubocop/cop/{performance/unneeded_sort.rb → style/redundant_sort.rb} +67 -39
- data/lib/rubocop/cop/{performance → style}/redundant_sort_by.rb +9 -12
- data/lib/rubocop/cop/style/regexp_literal.rb +27 -33
- data/lib/rubocop/cop/style/rescue_modifier.rb +64 -13
- data/lib/rubocop/cop/style/rescue_standard_error.rb +27 -25
- data/lib/rubocop/cop/style/return_nil.rb +17 -11
- data/lib/rubocop/cop/style/safe_navigation.rb +78 -44
- data/lib/rubocop/cop/{performance → style}/sample.rb +22 -22
- data/lib/rubocop/cop/style/select_by_regexp.rb +139 -0
- data/lib/rubocop/cop/style/self_assignment.rb +27 -23
- data/lib/rubocop/cop/style/semicolon.rb +50 -31
- data/lib/rubocop/cop/style/send.rb +5 -7
- data/lib/rubocop/cop/style/signal_exception.rb +33 -28
- data/lib/rubocop/cop/style/single_argument_dig.rb +60 -0
- data/lib/rubocop/cop/style/single_line_block_params.rb +38 -14
- data/lib/rubocop/cop/style/single_line_methods.rb +90 -21
- data/lib/rubocop/cop/style/slicing_with_range.rb +51 -0
- data/lib/rubocop/cop/style/sole_nested_conditional.rb +182 -0
- data/lib/rubocop/cop/style/special_global_vars.rb +52 -62
- data/lib/rubocop/cop/style/stabby_lambda_parentheses.rb +19 -26
- data/lib/rubocop/cop/style/static_class.rb +97 -0
- data/lib/rubocop/cop/style/stderr_puts.rb +15 -14
- data/lib/rubocop/cop/style/string_chars.rb +41 -0
- data/lib/rubocop/cop/style/string_concatenation.rb +173 -0
- data/lib/rubocop/cop/style/string_hash_keys.rb +16 -10
- data/lib/rubocop/cop/style/string_literals.rb +20 -16
- data/lib/rubocop/cop/style/string_literals_in_interpolation.rb +5 -3
- data/lib/rubocop/cop/style/string_methods.rb +8 -18
- data/lib/rubocop/cop/style/strip.rb +42 -0
- data/lib/rubocop/cop/style/struct_inheritance.rb +49 -9
- data/lib/rubocop/cop/style/swap_values.rb +112 -0
- data/lib/rubocop/cop/style/symbol_array.rb +15 -26
- data/lib/rubocop/cop/style/symbol_literal.rb +6 -10
- data/lib/rubocop/cop/style/symbol_proc.rb +81 -57
- data/lib/rubocop/cop/style/ternary_parentheses.rb +77 -39
- data/lib/rubocop/cop/style/top_level_method_definition.rb +83 -0
- data/lib/rubocop/cop/style/trailing_body_on_class.rb +4 -7
- data/lib/rubocop/cop/style/trailing_body_on_method_definition.rb +10 -9
- data/lib/rubocop/cop/style/trailing_body_on_module.rb +4 -7
- data/lib/rubocop/cop/style/trailing_comma_in_arguments.rb +39 -25
- data/lib/rubocop/cop/style/trailing_comma_in_array_literal.rb +43 -5
- data/lib/rubocop/cop/style/trailing_comma_in_block_args.rb +105 -0
- data/lib/rubocop/cop/style/trailing_comma_in_hash_literal.rb +46 -5
- data/lib/rubocop/cop/style/trailing_method_end_statement.rb +12 -40
- data/lib/rubocop/cop/style/trailing_underscore_variable.rb +24 -33
- data/lib/rubocop/cop/style/trivial_accessors.rb +105 -44
- data/lib/rubocop/cop/style/unless_else.rb +8 -13
- data/lib/rubocop/cop/style/unless_logical_operators.rb +105 -0
- data/lib/rubocop/cop/style/unpack_first.rb +7 -13
- data/lib/rubocop/cop/style/variable_interpolation.rb +12 -25
- data/lib/rubocop/cop/style/when_then.rb +7 -7
- data/lib/rubocop/cop/style/while_until_do.rb +7 -17
- data/lib/rubocop/cop/style/while_until_modifier.rb +17 -25
- data/lib/rubocop/cop/style/word_array.rb +27 -28
- data/lib/rubocop/cop/style/yoda_condition.rb +63 -31
- data/lib/rubocop/cop/style/zero_length_predicate.rb +38 -30
- data/lib/rubocop/cop/team.rb +160 -91
- data/lib/rubocop/cop/util.rb +71 -33
- data/lib/rubocop/cop/utils/format_string.rb +133 -0
- data/lib/rubocop/cop/variable_force/assignment.rb +2 -2
- data/lib/rubocop/cop/variable_force/branch.rb +18 -9
- data/lib/rubocop/cop/variable_force/reference.rb +1 -3
- data/lib/rubocop/cop/variable_force/scope.rb +9 -12
- data/lib/rubocop/cop/variable_force/variable.rb +22 -12
- data/lib/rubocop/cop/variable_force/variable_table.rb +2 -2
- data/lib/rubocop/cop/variable_force.rb +22 -32
- data/lib/rubocop/cops_documentation_generator.rb +282 -0
- data/lib/rubocop/core_ext/string.rb +2 -26
- data/lib/rubocop/directive_comment.rb +144 -0
- data/lib/rubocop/error.rb +24 -0
- data/lib/rubocop/ext/processed_source.rb +18 -0
- data/lib/rubocop/ext/regexp_node.rb +87 -0
- data/lib/rubocop/ext/regexp_parser.rb +92 -0
- data/lib/rubocop/file_finder.rb +12 -18
- data/lib/rubocop/formatter/auto_gen_config_formatter.rb +2 -1
- data/lib/rubocop/formatter/base_formatter.rb +0 -4
- data/lib/rubocop/formatter/clang_style_formatter.rb +13 -8
- data/lib/rubocop/formatter/disabled_config_formatter.rb +55 -27
- data/lib/rubocop/formatter/emacs_style_formatter.rb +24 -9
- data/lib/rubocop/formatter/file_list_formatter.rb +1 -1
- data/lib/rubocop/formatter/formatter_set.rb +20 -19
- data/lib/rubocop/formatter/fuubar_style_formatter.rb +1 -1
- data/lib/rubocop/formatter/git_hub_actions_formatter.rb +44 -0
- data/lib/rubocop/formatter/html_formatter.rb +16 -17
- data/lib/rubocop/formatter/json_formatter.rb +20 -20
- data/lib/rubocop/formatter/junit_formatter.rb +93 -0
- data/lib/rubocop/formatter/offense_count_formatter.rb +2 -2
- data/lib/rubocop/formatter/pacman_formatter.rb +80 -0
- data/lib/rubocop/formatter/progress_formatter.rb +4 -5
- data/lib/rubocop/formatter/quiet_formatter.rb +1 -1
- data/lib/rubocop/formatter/simple_text_formatter.rb +61 -16
- data/lib/rubocop/formatter/tap_formatter.rb +23 -8
- data/lib/rubocop/formatter/worst_offenders_formatter.rb +2 -2
- data/lib/rubocop/lockfile.rb +40 -0
- data/lib/rubocop/magic_comment.rb +80 -18
- data/lib/rubocop/name_similarity.rb +18 -10
- data/lib/rubocop/options.rb +301 -222
- data/lib/rubocop/path_util.rb +20 -22
- data/lib/rubocop/platform.rb +1 -1
- data/lib/rubocop/rake_task.rb +14 -12
- data/lib/rubocop/remote_config.rb +18 -14
- data/lib/rubocop/result_cache.rb +71 -36
- data/lib/rubocop/rspec/cop_helper.rb +11 -36
- data/lib/rubocop/rspec/expect_offense.rb +139 -43
- data/lib/rubocop/rspec/parallel_formatter.rb +90 -0
- data/lib/rubocop/rspec/shared_contexts.rb +86 -45
- data/lib/rubocop/rspec/support.rb +1 -1
- data/lib/rubocop/runner.rb +147 -85
- data/lib/rubocop/string_interpreter.rb +10 -7
- data/lib/rubocop/target_finder.rb +72 -53
- data/lib/rubocop/target_ruby.rb +264 -0
- data/lib/rubocop/util.rb +16 -0
- data/lib/rubocop/version.rb +71 -7
- data/lib/rubocop/yaml_duplication_checker.rb +10 -3
- data/lib/rubocop.rb +241 -169
- metadata +301 -216
- data/bin/console +0 -9
- data/bin/setup +0 -7
- data/lib/rubocop/ast/builder.rb +0 -75
- data/lib/rubocop/ast/node/and_node.rb +0 -29
- data/lib/rubocop/ast/node/args_node.rb +0 -29
- data/lib/rubocop/ast/node/array_node.rb +0 -57
- data/lib/rubocop/ast/node/block_node.rb +0 -115
- data/lib/rubocop/ast/node/break_node.rb +0 -17
- data/lib/rubocop/ast/node/case_node.rb +0 -56
- data/lib/rubocop/ast/node/def_node.rb +0 -71
- data/lib/rubocop/ast/node/defined_node.rb +0 -17
- data/lib/rubocop/ast/node/ensure_node.rb +0 -17
- data/lib/rubocop/ast/node/for_node.rb +0 -53
- data/lib/rubocop/ast/node/hash_node.rb +0 -109
- data/lib/rubocop/ast/node/if_node.rb +0 -175
- data/lib/rubocop/ast/node/keyword_splat_node.rb +0 -45
- data/lib/rubocop/ast/node/mixin/basic_literal_node.rb +0 -16
- data/lib/rubocop/ast/node/mixin/binary_operator_node.rb +0 -43
- data/lib/rubocop/ast/node/mixin/collection_node.rb +0 -15
- data/lib/rubocop/ast/node/mixin/conditional_node.rb +0 -45
- data/lib/rubocop/ast/node/mixin/hash_element_node.rb +0 -125
- data/lib/rubocop/ast/node/mixin/method_dispatch_node.rb +0 -251
- data/lib/rubocop/ast/node/mixin/method_identifier_predicates.rb +0 -114
- data/lib/rubocop/ast/node/mixin/modifier_node.rb +0 -17
- data/lib/rubocop/ast/node/mixin/parameterized_node.rb +0 -61
- data/lib/rubocop/ast/node/mixin/predicate_operator_node.rb +0 -35
- data/lib/rubocop/ast/node/or_node.rb +0 -29
- data/lib/rubocop/ast/node/pair_node.rb +0 -63
- data/lib/rubocop/ast/node/range_node.rb +0 -11
- data/lib/rubocop/ast/node/regexp_node.rb +0 -35
- data/lib/rubocop/ast/node/resbody_node.rb +0 -17
- data/lib/rubocop/ast/node/retry_node.rb +0 -17
- data/lib/rubocop/ast/node/send_node.rb +0 -13
- data/lib/rubocop/ast/node/str_node.rb +0 -16
- data/lib/rubocop/ast/node/super_node.rb +0 -21
- data/lib/rubocop/ast/node/symbol_node.rb +0 -12
- data/lib/rubocop/ast/node/until_node.rb +0 -35
- data/lib/rubocop/ast/node/when_node.rb +0 -53
- data/lib/rubocop/ast/node/while_node.rb +0 -35
- data/lib/rubocop/ast/node/yield_node.rb +0 -21
- data/lib/rubocop/ast/node.rb +0 -642
- data/lib/rubocop/ast/sexp.rb +0 -16
- data/lib/rubocop/ast/traversal.rb +0 -183
- data/lib/rubocop/cop/layout/align_array.rb +0 -39
- data/lib/rubocop/cop/layout/align_parameters.rb +0 -94
- data/lib/rubocop/cop/layout/indent_heredoc.rb +0 -294
- data/lib/rubocop/cop/layout/tab.rb +0 -87
- data/lib/rubocop/cop/lint/end_in_method.rb +0 -40
- data/lib/rubocop/cop/lint/handle_exceptions.rb +0 -56
- data/lib/rubocop/cop/lint/multiple_compare.rb +0 -48
- data/lib/rubocop/cop/lint/unneeded_cop_disable_directive.rb +0 -263
- data/lib/rubocop/cop/lint/unneeded_cop_enable_directive.rb +0 -116
- data/lib/rubocop/cop/lint/useless_comparison.rb +0 -28
- data/lib/rubocop/cop/metrics/line_length.rb +0 -204
- data/lib/rubocop/cop/mixin/classish_length.rb +0 -37
- data/lib/rubocop/cop/mixin/parser_diagnostic.rb +0 -37
- data/lib/rubocop/cop/mixin/safe_mode.rb +0 -22
- data/lib/rubocop/cop/mixin/target_rails_version.rb +0 -16
- data/lib/rubocop/cop/mixin/too_many_lines.rb +0 -39
- data/lib/rubocop/cop/performance/caller.rb +0 -69
- data/lib/rubocop/cop/performance/case_when_splat.rb +0 -177
- data/lib/rubocop/cop/performance/casecmp.rb +0 -108
- data/lib/rubocop/cop/performance/chain_array_allocation.rb +0 -78
- data/lib/rubocop/cop/performance/compare_with_block.rb +0 -122
- data/lib/rubocop/cop/performance/count.rb +0 -102
- data/lib/rubocop/cop/performance/detect.rb +0 -110
- data/lib/rubocop/cop/performance/double_start_end_with.rb +0 -94
- data/lib/rubocop/cop/performance/end_with.rb +0 -56
- data/lib/rubocop/cop/performance/fixed_size.rb +0 -97
- data/lib/rubocop/cop/performance/flat_map.rb +0 -78
- data/lib/rubocop/cop/performance/inefficient_hash_search.rb +0 -99
- data/lib/rubocop/cop/performance/lstrip_rstrip.rb +0 -46
- data/lib/rubocop/cop/performance/open_struct.rb +0 -46
- data/lib/rubocop/cop/performance/range_include.rb +0 -50
- data/lib/rubocop/cop/performance/redundant_block_call.rb +0 -93
- data/lib/rubocop/cop/performance/redundant_match.rb +0 -56
- data/lib/rubocop/cop/performance/redundant_merge.rb +0 -183
- data/lib/rubocop/cop/performance/regexp_match.rb +0 -265
- data/lib/rubocop/cop/performance/reverse_each.rb +0 -42
- data/lib/rubocop/cop/performance/size.rb +0 -77
- data/lib/rubocop/cop/performance/start_with.rb +0 -59
- data/lib/rubocop/cop/performance/string_replacement.rb +0 -173
- data/lib/rubocop/cop/performance/times_map.rb +0 -71
- data/lib/rubocop/cop/performance/unfreeze_string.rb +0 -50
- data/lib/rubocop/cop/performance/uri_default_parser.rb +0 -47
- data/lib/rubocop/cop/rails/action_filter.rb +0 -117
- data/lib/rubocop/cop/rails/active_record_aliases.rb +0 -48
- data/lib/rubocop/cop/rails/active_support_aliases.rb +0 -69
- data/lib/rubocop/cop/rails/application_job.rb +0 -40
- data/lib/rubocop/cop/rails/application_record.rb +0 -40
- data/lib/rubocop/cop/rails/assert_not.rb +0 -44
- data/lib/rubocop/cop/rails/belongs_to.rb +0 -120
- data/lib/rubocop/cop/rails/blank.rb +0 -158
- data/lib/rubocop/cop/rails/bulk_change_table.rb +0 -289
- data/lib/rubocop/cop/rails/create_table_with_timestamps.rb +0 -91
- data/lib/rubocop/cop/rails/date.rb +0 -156
- data/lib/rubocop/cop/rails/delegate.rb +0 -135
- data/lib/rubocop/cop/rails/delegate_allow_blank.rb +0 -51
- data/lib/rubocop/cop/rails/dynamic_find_by.rb +0 -91
- data/lib/rubocop/cop/rails/enum_uniqueness.rb +0 -45
- data/lib/rubocop/cop/rails/environment_comparison.rb +0 -66
- data/lib/rubocop/cop/rails/exit.rb +0 -67
- data/lib/rubocop/cop/rails/file_path.rb +0 -108
- data/lib/rubocop/cop/rails/find_by.rb +0 -55
- data/lib/rubocop/cop/rails/find_each.rb +0 -52
- data/lib/rubocop/cop/rails/has_and_belongs_to_many.rb +0 -25
- data/lib/rubocop/cop/rails/has_many_or_has_one_dependent.rb +0 -106
- data/lib/rubocop/cop/rails/http_positional_arguments.rb +0 -117
- data/lib/rubocop/cop/rails/http_status.rb +0 -186
- data/lib/rubocop/cop/rails/ignored_skip_action_filter_option.rb +0 -94
- data/lib/rubocop/cop/rails/inverse_of.rb +0 -246
- data/lib/rubocop/cop/rails/lexically_scoped_action_filter.rb +0 -149
- data/lib/rubocop/cop/rails/link_to_blank.rb +0 -90
- data/lib/rubocop/cop/rails/not_null_column.rb +0 -67
- data/lib/rubocop/cop/rails/output.rb +0 -49
- data/lib/rubocop/cop/rails/output_safety.rb +0 -99
- data/lib/rubocop/cop/rails/pluralization_grammar.rb +0 -107
- data/lib/rubocop/cop/rails/presence.rb +0 -124
- data/lib/rubocop/cop/rails/present.rb +0 -149
- data/lib/rubocop/cop/rails/read_write_attribute.rb +0 -74
- data/lib/rubocop/cop/rails/redundant_receiver_in_with_options.rb +0 -135
- data/lib/rubocop/cop/rails/reflection_class_name.rb +0 -38
- data/lib/rubocop/cop/rails/refute_methods.rb +0 -76
- data/lib/rubocop/cop/rails/relative_date_constant.rb +0 -93
- data/lib/rubocop/cop/rails/request_referer.rb +0 -56
- data/lib/rubocop/cop/rails/reversible_migration.rb +0 -286
- data/lib/rubocop/cop/rails/safe_navigation.rb +0 -91
- data/lib/rubocop/cop/rails/save_bang.rb +0 -316
- data/lib/rubocop/cop/rails/scope_args.rb +0 -29
- data/lib/rubocop/cop/rails/skips_model_validations.rb +0 -88
- data/lib/rubocop/cop/rails/time_zone.rb +0 -231
- data/lib/rubocop/cop/rails/uniq_before_pluck.rb +0 -105
- data/lib/rubocop/cop/rails/unknown_env.rb +0 -63
- data/lib/rubocop/cop/rails/validation.rb +0 -106
- data/lib/rubocop/cop/style/braces_around_hash_parameters.rb +0 -190
- data/lib/rubocop/cop/style/method_missing_super.rb +0 -34
- data/lib/rubocop/cop/style/unneeded_condition.rb +0 -112
- data/lib/rubocop/cop/style/unneeded_interpolation.rb +0 -98
- data/lib/rubocop/formatter/disabled_lines_formatter.rb +0 -57
- data/lib/rubocop/node_pattern.rb +0 -584
- data/lib/rubocop/processed_source.rb +0 -210
- data/lib/rubocop/rspec/shared_examples.rb +0 -59
- data/lib/rubocop/string_util.rb +0 -14
- data/lib/rubocop/token.rb +0 -114
data/lib/rubocop/ast/node.rb
DELETED
@@ -1,642 +0,0 @@
|
|
1
|
-
# frozen_string_literal: true
|
2
|
-
|
3
|
-
module RuboCop
|
4
|
-
module AST
|
5
|
-
# `RuboCop::AST::Node` is a subclass of `Parser::AST::Node`. It provides
|
6
|
-
# access to parent nodes and an object-oriented way to traverse an AST with
|
7
|
-
# the power of `Enumerable`.
|
8
|
-
#
|
9
|
-
# It has predicate methods for every node type, like this:
|
10
|
-
#
|
11
|
-
# @example
|
12
|
-
# node.send_type? # Equivalent to: `node.type == :send`
|
13
|
-
# node.op_asgn_type? # Equivalent to: `node.type == :op_asgn`
|
14
|
-
#
|
15
|
-
# # Non-word characters (other than a-zA-Z0-9_) in type names are omitted.
|
16
|
-
# node.defined_type? # Equivalent to: `node.type == :defined?`
|
17
|
-
#
|
18
|
-
# # Find the first lvar node under the receiver node.
|
19
|
-
# lvar_node = node.each_descendant.find(&:lvar_type?)
|
20
|
-
#
|
21
|
-
class Node < Parser::AST::Node # rubocop:disable Metrics/ClassLength
|
22
|
-
include RuboCop::AST::Sexp
|
23
|
-
extend NodePattern::Macros
|
24
|
-
|
25
|
-
# <=> isn't included here, because it doesn't return a boolean.
|
26
|
-
COMPARISON_OPERATORS = %i[== === != <= >= > <].freeze
|
27
|
-
|
28
|
-
TRUTHY_LITERALS = %i[str dstr xstr int float sym dsym array
|
29
|
-
hash regexp true irange erange complex
|
30
|
-
rational regopt].freeze
|
31
|
-
FALSEY_LITERALS = %i[false nil].freeze
|
32
|
-
LITERALS = (TRUTHY_LITERALS + FALSEY_LITERALS).freeze
|
33
|
-
COMPOSITE_LITERALS = %i[dstr xstr dsym array hash irange
|
34
|
-
erange regexp].freeze
|
35
|
-
BASIC_LITERALS = (LITERALS - COMPOSITE_LITERALS).freeze
|
36
|
-
MUTABLE_LITERALS = %i[str dstr xstr array hash
|
37
|
-
regexp irange erange].freeze
|
38
|
-
IMMUTABLE_LITERALS = (LITERALS - MUTABLE_LITERALS).freeze
|
39
|
-
|
40
|
-
EQUALS_ASSIGNMENTS = %i[lvasgn ivasgn cvasgn gvasgn
|
41
|
-
casgn masgn].freeze
|
42
|
-
SHORTHAND_ASSIGNMENTS = %i[op_asgn or_asgn and_asgn].freeze
|
43
|
-
ASSIGNMENTS = (EQUALS_ASSIGNMENTS + SHORTHAND_ASSIGNMENTS).freeze
|
44
|
-
|
45
|
-
BASIC_CONDITIONALS = %i[if while until].freeze
|
46
|
-
CONDITIONALS = [*BASIC_CONDITIONALS, :case].freeze
|
47
|
-
VARIABLES = %i[ivar gvar cvar lvar].freeze
|
48
|
-
REFERENCES = %i[nth_ref back_ref].freeze
|
49
|
-
KEYWORDS = %i[alias and break case class def defs defined?
|
50
|
-
kwbegin do else ensure for if module next
|
51
|
-
not or postexe redo rescue retry return self
|
52
|
-
super zsuper then undef until when while
|
53
|
-
yield].freeze
|
54
|
-
OPERATOR_KEYWORDS = %i[and or].freeze
|
55
|
-
SPECIAL_KEYWORDS = %w[__FILE__ __LINE__ __ENCODING__].freeze
|
56
|
-
|
57
|
-
# @see https://www.rubydoc.info/gems/ast/AST/Node:initialize
|
58
|
-
def initialize(type, children = [], properties = {})
|
59
|
-
@mutable_attributes = {}
|
60
|
-
|
61
|
-
# ::AST::Node#initialize freezes itself.
|
62
|
-
super
|
63
|
-
|
64
|
-
# #parent= may be invoked multiple times for a node because there are
|
65
|
-
# pending nodes while constructing AST and they are replaced later.
|
66
|
-
# For example, `lvar` and `send` type nodes are initially created as an
|
67
|
-
# `ident` type node and fixed to the appropriate type later.
|
68
|
-
# So, the #parent attribute needs to be mutable.
|
69
|
-
each_child_node do |child_node|
|
70
|
-
child_node.parent = self unless child_node.complete?
|
71
|
-
end
|
72
|
-
end
|
73
|
-
|
74
|
-
Parser::Meta::NODE_TYPES.each do |node_type|
|
75
|
-
method_name = "#{node_type.to_s.gsub(/\W/, '')}_type?"
|
76
|
-
define_method(method_name) do
|
77
|
-
type == node_type
|
78
|
-
end
|
79
|
-
end
|
80
|
-
|
81
|
-
# Returns the parent node, or `nil` if the receiver is a root node.
|
82
|
-
#
|
83
|
-
# @return [Node, nil] the parent node or `nil`
|
84
|
-
def parent
|
85
|
-
@mutable_attributes[:parent]
|
86
|
-
end
|
87
|
-
|
88
|
-
def parent=(node)
|
89
|
-
@mutable_attributes[:parent] = node
|
90
|
-
end
|
91
|
-
|
92
|
-
def complete!
|
93
|
-
@mutable_attributes.freeze
|
94
|
-
each_child_node(&:complete!)
|
95
|
-
end
|
96
|
-
|
97
|
-
def complete?
|
98
|
-
@mutable_attributes.frozen?
|
99
|
-
end
|
100
|
-
|
101
|
-
protected :parent= # rubocop:disable Style/AccessModifierDeclarations
|
102
|
-
|
103
|
-
# Override `AST::Node#updated` so that `AST::Processor` does not try to
|
104
|
-
# mutate our ASTs. Since we keep references from children to parents and
|
105
|
-
# not just the other way around, we cannot update an AST and share
|
106
|
-
# identical subtrees. Rather, the entire AST must be copied any time any
|
107
|
-
# part of it is changed.
|
108
|
-
def updated(type = nil, children = nil, properties = {})
|
109
|
-
properties[:location] ||= @location
|
110
|
-
klass = RuboCop::AST::Builder::NODE_MAP[type || @type] || Node
|
111
|
-
klass.new(type || @type, children || @children, properties)
|
112
|
-
end
|
113
|
-
|
114
|
-
# Returns the index of the receiver node in its siblings. (Sibling index
|
115
|
-
# uses zero based numbering.)
|
116
|
-
#
|
117
|
-
# @return [Integer] the index of the receiver node in its siblings
|
118
|
-
def sibling_index
|
119
|
-
parent.children.index { |sibling| sibling.equal?(self) }
|
120
|
-
end
|
121
|
-
|
122
|
-
# Common destructuring method. This can be used to normalize
|
123
|
-
# destructuring for different variations of the node.
|
124
|
-
# Some node types override this with their own custom
|
125
|
-
# destructuring method.
|
126
|
-
#
|
127
|
-
# @return [Array<Node>] the different parts of the ndde
|
128
|
-
def node_parts
|
129
|
-
to_a
|
130
|
-
end
|
131
|
-
|
132
|
-
# Calls the given block for each ancestor node from parent to root.
|
133
|
-
# If no block is given, an `Enumerator` is returned.
|
134
|
-
#
|
135
|
-
# @overload each_ancestor
|
136
|
-
# Yield all nodes.
|
137
|
-
# @overload each_ancestor(type)
|
138
|
-
# Yield only nodes matching the type.
|
139
|
-
# @param [Symbol] type a node type
|
140
|
-
# @overload each_ancestor(type_a, type_b, ...)
|
141
|
-
# Yield only nodes matching any of the types.
|
142
|
-
# @param [Symbol] type_a a node type
|
143
|
-
# @param [Symbol] type_b a node type
|
144
|
-
# @overload each_ancestor(types)
|
145
|
-
# Yield only nodes matching any of types in the array.
|
146
|
-
# @param [Array<Symbol>] types an array containing node types
|
147
|
-
# @yieldparam [Node] node each ancestor node
|
148
|
-
# @return [self] if a block is given
|
149
|
-
# @return [Enumerator] if no block is given
|
150
|
-
def each_ancestor(*types, &block)
|
151
|
-
return to_enum(__method__, *types) unless block_given?
|
152
|
-
|
153
|
-
visit_ancestors(types, &block)
|
154
|
-
|
155
|
-
self
|
156
|
-
end
|
157
|
-
|
158
|
-
# Returns an array of ancestor nodes.
|
159
|
-
# This is a shorthand for `node.each_ancestor.to_a`.
|
160
|
-
#
|
161
|
-
# @return [Array<Node>] an array of ancestor nodes
|
162
|
-
def ancestors
|
163
|
-
each_ancestor.to_a
|
164
|
-
end
|
165
|
-
|
166
|
-
# Calls the given block for each child node.
|
167
|
-
# If no block is given, an `Enumerator` is returned.
|
168
|
-
#
|
169
|
-
# Note that this is different from `node.children.each { |child| ... }`
|
170
|
-
# which yields all children including non-node elements.
|
171
|
-
#
|
172
|
-
# @overload each_child_node
|
173
|
-
# Yield all nodes.
|
174
|
-
# @overload each_child_node(type)
|
175
|
-
# Yield only nodes matching the type.
|
176
|
-
# @param [Symbol] type a node type
|
177
|
-
# @overload each_child_node(type_a, type_b, ...)
|
178
|
-
# Yield only nodes matching any of the types.
|
179
|
-
# @param [Symbol] type_a a node type
|
180
|
-
# @param [Symbol] type_b a node type
|
181
|
-
# @overload each_child_node(types)
|
182
|
-
# Yield only nodes matching any of types in the array.
|
183
|
-
# @param [Array<Symbol>] types an array containing node types
|
184
|
-
# @yieldparam [Node] node each child node
|
185
|
-
# @return [self] if a block is given
|
186
|
-
# @return [Enumerator] if no block is given
|
187
|
-
def each_child_node(*types)
|
188
|
-
return to_enum(__method__, *types) unless block_given?
|
189
|
-
|
190
|
-
children.each do |child|
|
191
|
-
next unless child.is_a?(Node)
|
192
|
-
|
193
|
-
yield child if types.empty? || types.include?(child.type)
|
194
|
-
end
|
195
|
-
|
196
|
-
self
|
197
|
-
end
|
198
|
-
|
199
|
-
# Returns an array of child nodes.
|
200
|
-
# This is a shorthand for `node.each_child_node.to_a`.
|
201
|
-
#
|
202
|
-
# @return [Array<Node>] an array of child nodes
|
203
|
-
def child_nodes
|
204
|
-
each_child_node.to_a
|
205
|
-
end
|
206
|
-
|
207
|
-
# Calls the given block for each descendant node with depth first order.
|
208
|
-
# If no block is given, an `Enumerator` is returned.
|
209
|
-
#
|
210
|
-
# @overload each_descendant
|
211
|
-
# Yield all nodes.
|
212
|
-
# @overload each_descendant(type)
|
213
|
-
# Yield only nodes matching the type.
|
214
|
-
# @param [Symbol] type a node type
|
215
|
-
# @overload each_descendant(type_a, type_b, ...)
|
216
|
-
# Yield only nodes matching any of the types.
|
217
|
-
# @param [Symbol] type_a a node type
|
218
|
-
# @param [Symbol] type_b a node type
|
219
|
-
# @overload each_descendant(types)
|
220
|
-
# Yield only nodes matching any of types in the array.
|
221
|
-
# @param [Array<Symbol>] types an array containing node types
|
222
|
-
# @yieldparam [Node] node each descendant node
|
223
|
-
# @return [self] if a block is given
|
224
|
-
# @return [Enumerator] if no block is given
|
225
|
-
def each_descendant(*types, &block)
|
226
|
-
return to_enum(__method__, *types) unless block_given?
|
227
|
-
|
228
|
-
visit_descendants(types, &block)
|
229
|
-
|
230
|
-
self
|
231
|
-
end
|
232
|
-
|
233
|
-
# Returns an array of descendant nodes.
|
234
|
-
# This is a shorthand for `node.each_descendant.to_a`.
|
235
|
-
#
|
236
|
-
# @return [Array<Node>] an array of descendant nodes
|
237
|
-
def descendants
|
238
|
-
each_descendant.to_a
|
239
|
-
end
|
240
|
-
|
241
|
-
# Calls the given block for the receiver and each descendant node in
|
242
|
-
# depth-first order.
|
243
|
-
# If no block is given, an `Enumerator` is returned.
|
244
|
-
#
|
245
|
-
# This method would be useful when you treat the receiver node as the root
|
246
|
-
# of a tree and want to iterate over all nodes in the tree.
|
247
|
-
#
|
248
|
-
# @overload each_node
|
249
|
-
# Yield all nodes.
|
250
|
-
# @overload each_node(type)
|
251
|
-
# Yield only nodes matching the type.
|
252
|
-
# @param [Symbol] type a node type
|
253
|
-
# @overload each_node(type_a, type_b, ...)
|
254
|
-
# Yield only nodes matching any of the types.
|
255
|
-
# @param [Symbol] type_a a node type
|
256
|
-
# @param [Symbol] type_b a node type
|
257
|
-
# @overload each_node(types)
|
258
|
-
# Yield only nodes matching any of types in the array.
|
259
|
-
# @param [Array<Symbol>] types an array containing node types
|
260
|
-
# @yieldparam [Node] node each node
|
261
|
-
# @return [self] if a block is given
|
262
|
-
# @return [Enumerator] if no block is given
|
263
|
-
def each_node(*types, &block)
|
264
|
-
return to_enum(__method__, *types) unless block_given?
|
265
|
-
|
266
|
-
yield self if types.empty? || types.include?(type)
|
267
|
-
|
268
|
-
visit_descendants(types, &block)
|
269
|
-
|
270
|
-
self
|
271
|
-
end
|
272
|
-
|
273
|
-
def source
|
274
|
-
loc.expression.source
|
275
|
-
end
|
276
|
-
|
277
|
-
def source_range
|
278
|
-
loc.expression
|
279
|
-
end
|
280
|
-
|
281
|
-
def first_line
|
282
|
-
loc.line
|
283
|
-
end
|
284
|
-
|
285
|
-
def last_line
|
286
|
-
loc.last_line
|
287
|
-
end
|
288
|
-
|
289
|
-
def line_count
|
290
|
-
return 0 unless source_range
|
291
|
-
|
292
|
-
source_range.last_line - source_range.first_line + 1
|
293
|
-
end
|
294
|
-
|
295
|
-
def nonempty_line_count
|
296
|
-
source.lines.grep(/\S/).size
|
297
|
-
end
|
298
|
-
|
299
|
-
def source_length
|
300
|
-
source_range ? source_range.size : 0
|
301
|
-
end
|
302
|
-
|
303
|
-
## Destructuring
|
304
|
-
|
305
|
-
def_node_matcher :receiver, <<-PATTERN
|
306
|
-
{(send $_ ...) (block (send $_ ...) ...)}
|
307
|
-
PATTERN
|
308
|
-
|
309
|
-
# Note: for masgn, #asgn_rhs will be an array node
|
310
|
-
def_node_matcher :asgn_rhs, '[assignment? (... $_)]'
|
311
|
-
def_node_matcher :str_content, '(str $_)'
|
312
|
-
|
313
|
-
def const_name
|
314
|
-
return unless const_type?
|
315
|
-
|
316
|
-
namespace, name = *self
|
317
|
-
if namespace && !namespace.cbase_type?
|
318
|
-
"#{namespace.const_name}::#{name}"
|
319
|
-
else
|
320
|
-
name.to_s
|
321
|
-
end
|
322
|
-
end
|
323
|
-
|
324
|
-
def_node_matcher :defined_module0, <<-PATTERN
|
325
|
-
{(class (const $_ $_) ...)
|
326
|
-
(module (const $_ $_) ...)
|
327
|
-
(casgn $_ $_ (send (const nil? {:Class :Module}) :new ...))
|
328
|
-
(casgn $_ $_ (block (send (const nil? {:Class :Module}) :new ...) ...))}
|
329
|
-
PATTERN
|
330
|
-
# rubocop:disable Style/AccessModifierDeclarations
|
331
|
-
private :defined_module0
|
332
|
-
# rubocop:enable Style/AccessModifierDeclarations
|
333
|
-
|
334
|
-
def defined_module
|
335
|
-
namespace, name = *defined_module0
|
336
|
-
s(:const, namespace, name) if name
|
337
|
-
end
|
338
|
-
|
339
|
-
def defined_module_name
|
340
|
-
(const = defined_module) && const.const_name
|
341
|
-
end
|
342
|
-
|
343
|
-
## Searching the AST
|
344
|
-
|
345
|
-
def parent_module_name
|
346
|
-
# what class or module is this method/constant/etc definition in?
|
347
|
-
# returns nil if answer cannot be determined
|
348
|
-
ancestors = each_ancestor(:class, :module, :sclass, :casgn, :block)
|
349
|
-
result = ancestors.map do |ancestor|
|
350
|
-
parent_module_name_part(ancestor) { |full_name| return full_name }
|
351
|
-
end.compact.reverse.join('::')
|
352
|
-
result.empty? ? 'Object' : result
|
353
|
-
end
|
354
|
-
|
355
|
-
## Predicates
|
356
|
-
|
357
|
-
def multiline?
|
358
|
-
line_count > 1
|
359
|
-
end
|
360
|
-
|
361
|
-
def single_line?
|
362
|
-
line_count == 1
|
363
|
-
end
|
364
|
-
|
365
|
-
def empty_source?
|
366
|
-
source_length.zero?
|
367
|
-
end
|
368
|
-
|
369
|
-
# Some cops treat the shovel operator as a kind of assignment.
|
370
|
-
def_node_matcher :assignment_or_similar?, <<-PATTERN
|
371
|
-
{assignment? (send _recv :<< ...)}
|
372
|
-
PATTERN
|
373
|
-
|
374
|
-
def literal?
|
375
|
-
LITERALS.include?(type)
|
376
|
-
end
|
377
|
-
|
378
|
-
def basic_literal?
|
379
|
-
BASIC_LITERALS.include?(type)
|
380
|
-
end
|
381
|
-
|
382
|
-
def truthy_literal?
|
383
|
-
TRUTHY_LITERALS.include?(type)
|
384
|
-
end
|
385
|
-
|
386
|
-
def falsey_literal?
|
387
|
-
FALSEY_LITERALS.include?(type)
|
388
|
-
end
|
389
|
-
|
390
|
-
def mutable_literal?
|
391
|
-
MUTABLE_LITERALS.include?(type)
|
392
|
-
end
|
393
|
-
|
394
|
-
def immutable_literal?
|
395
|
-
IMMUTABLE_LITERALS.include?(type)
|
396
|
-
end
|
397
|
-
|
398
|
-
%i[literal basic_literal].each do |kind|
|
399
|
-
recursive_kind = :"recursive_#{kind}?"
|
400
|
-
kind_filter = :"#{kind}?"
|
401
|
-
define_method(recursive_kind) do
|
402
|
-
case type
|
403
|
-
when :send
|
404
|
-
[*COMPARISON_OPERATORS, :!, :<=>].include?(method_name) &&
|
405
|
-
receiver.send(recursive_kind) &&
|
406
|
-
arguments.all?(&recursive_kind)
|
407
|
-
when :begin, :pair, *OPERATOR_KEYWORDS, *COMPOSITE_LITERALS
|
408
|
-
children.all?(&recursive_kind)
|
409
|
-
else
|
410
|
-
send(kind_filter)
|
411
|
-
end
|
412
|
-
end
|
413
|
-
end
|
414
|
-
|
415
|
-
def variable?
|
416
|
-
VARIABLES.include?(type)
|
417
|
-
end
|
418
|
-
|
419
|
-
def reference?
|
420
|
-
REFERENCES.include?(type)
|
421
|
-
end
|
422
|
-
|
423
|
-
def equals_asgn?
|
424
|
-
EQUALS_ASSIGNMENTS.include?(type)
|
425
|
-
end
|
426
|
-
|
427
|
-
def shorthand_asgn?
|
428
|
-
SHORTHAND_ASSIGNMENTS.include?(type)
|
429
|
-
end
|
430
|
-
|
431
|
-
def assignment?
|
432
|
-
ASSIGNMENTS.include?(type)
|
433
|
-
end
|
434
|
-
|
435
|
-
def basic_conditional?
|
436
|
-
BASIC_CONDITIONALS.include?(type)
|
437
|
-
end
|
438
|
-
|
439
|
-
def conditional?
|
440
|
-
CONDITIONALS.include?(type)
|
441
|
-
end
|
442
|
-
|
443
|
-
def keyword?
|
444
|
-
return true if special_keyword? || send_type? && prefix_not?
|
445
|
-
return false unless KEYWORDS.include?(type)
|
446
|
-
|
447
|
-
!OPERATOR_KEYWORDS.include?(type) || loc.operator.is?(type.to_s)
|
448
|
-
end
|
449
|
-
|
450
|
-
def special_keyword?
|
451
|
-
SPECIAL_KEYWORDS.include?(source)
|
452
|
-
end
|
453
|
-
|
454
|
-
def operator_keyword?
|
455
|
-
OPERATOR_KEYWORDS.include?(type)
|
456
|
-
end
|
457
|
-
|
458
|
-
def parenthesized_call?
|
459
|
-
loc.respond_to?(:begin) && loc.begin && loc.begin.is?('(')
|
460
|
-
end
|
461
|
-
|
462
|
-
def chained?
|
463
|
-
parent && parent.send_type? && eql?(parent.receiver)
|
464
|
-
end
|
465
|
-
|
466
|
-
def argument?
|
467
|
-
parent && parent.send_type? && parent.arguments.include?(self)
|
468
|
-
end
|
469
|
-
|
470
|
-
def numeric_type?
|
471
|
-
int_type? || float_type?
|
472
|
-
end
|
473
|
-
|
474
|
-
def range_type?
|
475
|
-
irange_type? || erange_type?
|
476
|
-
end
|
477
|
-
|
478
|
-
def_node_matcher :guard_clause?, <<-PATTERN
|
479
|
-
[{(send nil? {:raise :fail} ...) return break next} single_line?]
|
480
|
-
PATTERN
|
481
|
-
|
482
|
-
def_node_matcher :proc?, <<-PATTERN
|
483
|
-
{(block (send nil? :proc) ...)
|
484
|
-
(block (send (const nil? :Proc) :new) ...)
|
485
|
-
(send (const nil? :Proc) :new)}
|
486
|
-
PATTERN
|
487
|
-
|
488
|
-
def_node_matcher :lambda?, '(block (send nil? :lambda) ...)'
|
489
|
-
def_node_matcher :lambda_or_proc?, '{lambda? proc?}'
|
490
|
-
|
491
|
-
def_node_matcher :class_constructor?, <<-PATTERN
|
492
|
-
{ (send (const nil? {:Class :Module}) :new ...)
|
493
|
-
(block (send (const nil? {:Class :Module}) :new ...) ...)}
|
494
|
-
PATTERN
|
495
|
-
|
496
|
-
def_node_matcher :module_definition?, <<-PATTERN
|
497
|
-
{class module (casgn _ _ class_constructor?)}
|
498
|
-
PATTERN
|
499
|
-
|
500
|
-
# Some expressions are evaluated for their value, some for their side
|
501
|
-
# effects, and some for both
|
502
|
-
# If we know that an expression is useful only for its side effects, that
|
503
|
-
# means we can transform it in ways which preserve the side effects, but
|
504
|
-
# change the return value
|
505
|
-
# So, does the return value of this node matter? If we changed it to
|
506
|
-
# `(...; nil)`, might that affect anything?
|
507
|
-
#
|
508
|
-
# rubocop:disable Metrics/MethodLength, Metrics/CyclomaticComplexity
|
509
|
-
def value_used?
|
510
|
-
# Be conservative and return true if we're not sure.
|
511
|
-
return false if parent.nil?
|
512
|
-
|
513
|
-
case parent.type
|
514
|
-
when :array, :defined?, :dstr, :dsym, :eflipflop, :erange, :float,
|
515
|
-
:hash, :iflipflop, :irange, :not, :pair, :regexp, :str, :sym,
|
516
|
-
:when, :xstr
|
517
|
-
parent.value_used?
|
518
|
-
when :begin, :kwbegin
|
519
|
-
begin_value_used?
|
520
|
-
when :for
|
521
|
-
for_value_used?
|
522
|
-
when :case, :if
|
523
|
-
case_if_value_used?
|
524
|
-
when :while, :until, :while_post, :until_post
|
525
|
-
while_until_value_used?
|
526
|
-
else
|
527
|
-
true
|
528
|
-
end
|
529
|
-
end
|
530
|
-
# rubocop:enable Metrics/MethodLength, Metrics/CyclomaticComplexity
|
531
|
-
|
532
|
-
# Some expressions are evaluated for their value, some for their side
|
533
|
-
# effects, and some for both.
|
534
|
-
# If we know that expressions are useful only for their return values,
|
535
|
-
# and have no side effects, that means we can reorder them, change the
|
536
|
-
# number of times they are evaluated, or replace them with other
|
537
|
-
# expressions which are equivalent in value.
|
538
|
-
# So, is evaluation of this node free of side effects?
|
539
|
-
#
|
540
|
-
def pure?
|
541
|
-
# Be conservative and return false if we're not sure
|
542
|
-
case type
|
543
|
-
when :__FILE__, :__LINE__, :const, :cvar, :defined?, :false, :float,
|
544
|
-
:gvar, :int, :ivar, :lvar, :nil, :str, :sym, :true, :regopt
|
545
|
-
true
|
546
|
-
when :and, :array, :begin, :case, :dstr, :dsym, :eflipflop, :ensure,
|
547
|
-
:erange, :for, :hash, :if, :iflipflop, :irange, :kwbegin, :not,
|
548
|
-
:or, :pair, :regexp, :until, :until_post, :when, :while,
|
549
|
-
:while_post
|
550
|
-
child_nodes.all?(&:pure?)
|
551
|
-
else
|
552
|
-
false
|
553
|
-
end
|
554
|
-
end
|
555
|
-
|
556
|
-
protected
|
557
|
-
|
558
|
-
def visit_descendants(types, &block)
|
559
|
-
each_child_node do |child|
|
560
|
-
yield child if types.empty? || types.include?(child.type)
|
561
|
-
child.visit_descendants(types, &block)
|
562
|
-
end
|
563
|
-
end
|
564
|
-
|
565
|
-
private
|
566
|
-
|
567
|
-
def visit_ancestors(types)
|
568
|
-
last_node = self
|
569
|
-
|
570
|
-
while (current_node = last_node.parent)
|
571
|
-
yield current_node if types.empty? ||
|
572
|
-
types.include?(current_node.type)
|
573
|
-
last_node = current_node
|
574
|
-
end
|
575
|
-
end
|
576
|
-
|
577
|
-
def begin_value_used?
|
578
|
-
# the last child node determines the value of the parent
|
579
|
-
sibling_index == parent.children.size - 1 ? parent.value_used? : false
|
580
|
-
end
|
581
|
-
|
582
|
-
def for_value_used?
|
583
|
-
# `for var in enum; body; end`
|
584
|
-
# (for <var> <enum> <body>)
|
585
|
-
sibling_index == 2 ? parent.value_used? : true
|
586
|
-
end
|
587
|
-
|
588
|
-
def case_if_value_used?
|
589
|
-
# (case <condition> <when...>)
|
590
|
-
# (if <condition> <truebranch> <falsebranch>)
|
591
|
-
sibling_index.zero? ? true : parent.value_used?
|
592
|
-
end
|
593
|
-
|
594
|
-
def while_until_value_used?
|
595
|
-
# (while <condition> <body>) -> always evaluates to `nil`
|
596
|
-
sibling_index.zero?
|
597
|
-
end
|
598
|
-
|
599
|
-
def parent_module_name_part(node)
|
600
|
-
case node.type
|
601
|
-
when :class, :module, :casgn
|
602
|
-
# TODO: if constant name has cbase (leading ::), then we don't need
|
603
|
-
# to keep traversing up through nested classes/modules
|
604
|
-
node.defined_module_name
|
605
|
-
when :sclass
|
606
|
-
yield parent_module_name_for_sclass(node)
|
607
|
-
else # block
|
608
|
-
parent_module_name_for_block(node) { yield nil }
|
609
|
-
end
|
610
|
-
end
|
611
|
-
|
612
|
-
def parent_module_name_for_sclass(sclass_node)
|
613
|
-
# TODO: look for constant definition and see if it is nested
|
614
|
-
# inside a class or module
|
615
|
-
subject = sclass_node.children[0]
|
616
|
-
|
617
|
-
if subject.const_type?
|
618
|
-
"#<Class:#{subject.const_name}>"
|
619
|
-
elsif subject.self_type?
|
620
|
-
"#<Class:#{sclass_node.parent_module_name}>"
|
621
|
-
end
|
622
|
-
end
|
623
|
-
|
624
|
-
def parent_module_name_for_block(ancestor)
|
625
|
-
if ancestor.method_name == :class_eval
|
626
|
-
# `class_eval` with no receiver applies to whatever module or class
|
627
|
-
# we are currently in
|
628
|
-
return unless (receiver = ancestor.receiver)
|
629
|
-
|
630
|
-
yield unless receiver.const_type?
|
631
|
-
receiver.const_name
|
632
|
-
elsif !new_class_or_module_block?(ancestor)
|
633
|
-
yield
|
634
|
-
end
|
635
|
-
end
|
636
|
-
|
637
|
-
def_node_matcher :new_class_or_module_block?, <<-PATTERN
|
638
|
-
^(casgn _ _ (block (send (const _ {:Class :Module}) :new) ...))
|
639
|
-
PATTERN
|
640
|
-
end
|
641
|
-
end
|
642
|
-
end
|
data/lib/rubocop/ast/sexp.rb
DELETED
@@ -1,16 +0,0 @@
|
|
1
|
-
# frozen_string_literal: true
|
2
|
-
|
3
|
-
module RuboCop
|
4
|
-
module AST
|
5
|
-
# This module provides a shorthand method to create a {Node} like
|
6
|
-
# `Parser::AST::Sexp`.
|
7
|
-
#
|
8
|
-
# @see https://www.rubydoc.info/gems/ast/AST/Sexp
|
9
|
-
module Sexp
|
10
|
-
# Creates a {Node} with type `type` and children `children`.
|
11
|
-
def s(type, *children)
|
12
|
-
Node.new(type, children)
|
13
|
-
end
|
14
|
-
end
|
15
|
-
end
|
16
|
-
end
|