rubocop 0.63.1 → 0.64.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 403ba108281ac77da6c733ad24b88350e4b4a3055ad36b6059d7784cbf4df56e
-  data.tar.gz: 86ebf007930c2de6e2f5eddbd0a6fba6e99ce9a7645f6407fdd4554a4e3c632c
+  metadata.gz: 6c744e17f8f6d38daae30955f4198b9d34856917a7f3ec60b143b2cec3047aff
+  data.tar.gz: 9eb2f51c58eda0558444895d38fa246d21b6a055aadc4d901a320dca2f4ce4eb
 SHA512:
-  metadata.gz: 65c260a9df4e731b52ed42e5412d100e71199d5b75e6dac98adaf097020b351019c3fabedd99f2c34465d414eba0439680aeb7799ece4321c63918b4ac2e46e9
-  data.tar.gz: 5bfe411917f9d371b3ce33464297b5aa7840959dccf1275553545601af6b5228a7e770e3993663b98d5880f91f18dfdb94cf55cfa697af923e63c3b9fb3bcd8f
+  metadata.gz: c2d2beac27d36a4ef480f55c4125ddab230e1b208b45c90f59b3435f83eaa87f969ef0228bd959a7c25c3a91763bb941a9a778da5f6c9c925f0c9c698a631ef6
+  data.tar.gz: 597c8b8c1454fd8e3734ed545a5d148353d1b8860232ac3eed9b633c15f17fb2399f12874c7ec13191bdcd57709ff12653877080982f900426ff2452c6421a41

data/README.md

@@ -53,7 +53,7 @@ haven't reached version 1.0 yet). To prevent an unwanted RuboCop update you
 might want to use a conservative version locking in your `Gemfile`:
 
 ```rb
-gem 'rubocop', '~> 0.63.1', require: false
+gem 'rubocop', '~> 0.64.0', require: false
 ```
 
 ## Quickstart

data/config/default.yml

@@ -2493,6 +2493,11 @@ Rails/RedundantReceiverInWithOptions:
   Enabled: true
   VersionAdded: '0.52'
 
+Rails/ReflectionClassName:
+  Description: 'Use a string for `class_name` option value in the definition of a reflection.'
+  Enabled: true
+  VersionAdded: '0.64'
+
 Rails/RefuteMethods:
   Description: 'Use `assert_not` methods instead of `refute` methods.'
   Enabled: true
@@ -3374,7 +3379,9 @@ Style/LineEndConcatenation:
                  Use \ instead of + or << to concatenate two string literals at
                  line end.
   Enabled: true
+  SafeAutoCorrect: false
   VersionAdded: '0.18'
+  VersionChanged: '0.64'
 
 Style/MethodCallWithArgsParentheses:
   Description: 'Use parentheses for method calls with arguments.'
@@ -3386,6 +3393,7 @@ Style/MethodCallWithArgsParentheses:
   IgnoredMethods: []
   AllowParenthesesInMultilineCall: false
   AllowParenthesesInChaining: false
+  AllowParenthesesInCamelCaseMethod: false
   EnforcedStyle: require_parentheses
   SupportedStyles:
     - require_parentheses
@@ -4088,8 +4096,9 @@ Style/SymbolLiteral:
 Style/SymbolProc:
   Description: 'Use symbols as procs instead of blocks when possible.'
   Enabled: true
+  SafeAutoCorrect: false
   VersionAdded: '0.26'
-  VersionChanged: '0.40'
+  VersionChanged: '0.64'
   # A list of method names to be ignored by the check.
   # The names should be fairly unique, otherwise you'll end up ignoring lots of code.
   IgnoredMethods:

data/lib/rubocop.rb

@@ -592,6 +592,7 @@ require_relative 'rubocop/cop/rails/presence'
 require_relative 'rubocop/cop/rails/present'
 require_relative 'rubocop/cop/rails/read_write_attribute'
 require_relative 'rubocop/cop/rails/redundant_receiver_in_with_options'
+require_relative 'rubocop/cop/rails/reflection_class_name'
 require_relative 'rubocop/cop/rails/refute_methods'
 require_relative 'rubocop/cop/rails/relative_date_constant'
 require_relative 'rubocop/cop/rails/request_referer'

data/lib/rubocop/cop/generator/configuration_injector.rb

@@ -45,14 +45,15 @@ module RuboCop
 
         def find_target_line
           configuration_entries.find.with_index do |line, index|
-            next if comment?(line)
+            next unless cop_name_line?(line)
 
-            break index if badge.to_s < line
+            return index if badge.to_s < line
           end
+          configuration_entries.size - 1
         end
 
-        def comment?(yaml)
-          yaml =~ /^[\s#]/
+        def cop_name_line?(yaml)
+          yaml !~ /^[\s#]/
         end
       end
     end

data/lib/rubocop/cop/layout/align_parameters.rb

@@ -42,6 +42,7 @@ module RuboCop
 
           check_alignment(node.arguments, base_column(node, node.arguments))
         end
+        alias on_csend on_send
         alias on_def  on_send
         alias on_defs on_send
 
@@ -52,7 +53,11 @@ module RuboCop
         private
 
         def message(node)
-          type = node && node.parent.send_type? ? 'call' : 'definition'
+          type = if node && (node.parent.send_type? || node.parent.csend_type?)
+                   'call'
+                 else
+                   'definition'
+                 end
           msg = fixed_indentation? ? FIXED_INDENT_MSG : ALIGN_PARAMS_MSG
 
           format(msg, type: type)

data/lib/rubocop/cop/layout/closing_heredoc_indentation.rb

@@ -74,10 +74,6 @@ module RuboCop
           indent_level(heredoc_opening(node))
         end
 
-        def empty_heredoc?(node)
-          node.loc.heredoc_body.source.empty? || !contents_indentation(node)
-        end
-
         def argument_indentation_correct?(node)
           return unless node.argument? || node.chained?
 
@@ -86,14 +82,6 @@ module RuboCop
           ) == closing_indentation(node)
         end
 
-        def contents_indentation(node)
-          source_lines = node.loc.heredoc_body.source.split("\n")
-
-          source_lines.reject(&:empty?).map do |line|
-            indent_level(line)
-          end.min
-        end
-
         def closing_indentation(node)
           indent_level(heredoc_closing(node))
         end

data/lib/rubocop/cop/layout/closing_parenthesis_indentation.rb

@@ -78,6 +78,7 @@ module RuboCop
         def on_send(node)
           check(node, node.arguments)
         end
+        alias on_csend on_send
 
         def on_begin(node)
           check(node, node.children)
@@ -142,15 +143,16 @@ module RuboCop
         end
 
         def expected_column(left_paren, elements)
-          if !line_break_after_left_paren?(left_paren, elements) &&
-             all_elements_aligned?(elements)
-            left_paren.column
-          else
+          if line_break_after_left_paren?(left_paren, elements)
             source_indent = processed_source
-                            .line_indentation(last_argument_line(elements))
+                            .line_indentation(first_argument_line(elements))
             new_indent    = source_indent - indentation_width
 
             new_indent < 0 ? 0 : new_indent
+          elsif all_elements_aligned?(elements)
+            left_paren.column
+          else
+            processed_source.line_indentation(first_argument_line(elements))
           end
         end
 
@@ -161,9 +163,9 @@ module RuboCop
             .count == 1
         end
 
-        def last_argument_line(elements)
+        def first_argument_line(elements)
           elements
-            .last
+            .first
             .loc
             .first_line
         end

data/lib/rubocop/cop/layout/dot_position.rb

@@ -26,7 +26,7 @@ module RuboCop
         include ConfigurableEnforcedStyle
 
         def on_send(node)
-          return unless node.dot?
+          return unless node.dot? || ampersand_dot?(node)
 
           if proper_dot_position?(node)
             correct_style_detected
@@ -34,23 +34,26 @@ module RuboCop
             add_offense(node, location: :dot) { opposite_style_detected }
           end
         end
+        alias on_csend on_send
 
         def autocorrect(node)
           lambda do |corrector|
+            dot = node.loc.dot.source
             corrector.remove(node.loc.dot)
             case style
             when :leading
-              corrector.insert_before(selector_range(node), '.')
+              corrector.insert_before(selector_range(node), dot)
             when :trailing
-              corrector.insert_after(node.receiver.source_range, '.')
+              corrector.insert_after(node.receiver.source_range, dot)
             end
           end
         end
 
         private
 
-        def message(_node)
-          'Place the . on the ' +
+        def message(node)
+          dot = node.loc.dot.source
+          "Place the #{dot} on the " +
             case style
             when :leading
               'next line, together with the method name.'
@@ -92,6 +95,10 @@ module RuboCop
           # l.(1) has no selector, so we use the opening parenthesis instead
           node.loc.selector || node.loc.begin
         end
+
+        def ampersand_dot?(node)
+          node.loc.respond_to?(:dot) && node.loc.dot && node.loc.dot.is?('&.')
+        end
       end
     end
   end

data/lib/rubocop/cop/layout/empty_lines_around_arguments.rb

@@ -48,6 +48,7 @@ module RuboCop
 
           extra_lines(node) { |range| add_offense(node, location: range) }
         end
+        alias on_csend on_send
 
         def autocorrect(node)
           lambda do |corrector|

data/lib/rubocop/cop/layout/first_method_argument_line_break.rb

@@ -43,6 +43,7 @@ module RuboCop
 
           check_method_line_break(node, args)
         end
+        alias on_csend on_send
 
         def autocorrect(node)
           EmptyLineCorrector.insert_before(node)

data/lib/rubocop/cop/layout/first_parameter_indentation.rb

@@ -154,6 +154,7 @@ module RuboCop
 
           check_alignment([node.first_argument], indent)
         end
+        alias on_csend on_send
 
         def autocorrect(node)
           AlignmentCorrector.correct(processed_source, node, column_delta)

data/lib/rubocop/cop/layout/indent_array.rb

@@ -96,6 +96,7 @@ module RuboCop
             check(array_node, left_parenthesis)
           end
         end
+        alias on_csend on_send
 
         def autocorrect(node)
           AlignmentCorrector.correct(processed_source, node, @column_delta)

data/lib/rubocop/cop/layout/indent_hash.rb

@@ -94,6 +94,7 @@ module RuboCop
             check(hash_node, left_parenthesis)
           end
         end
+        alias on_csend on_send
 
         def autocorrect(node)
           AlignmentCorrector.correct(processed_source, node, @column_delta)

data/lib/rubocop/cop/layout/indentation_width.rb

@@ -119,6 +119,7 @@ module RuboCop
           check_indentation(base.source_range, body)
           ignore_node(node.first_argument)
         end
+        alias on_csend on_send
 
         def on_def(node)
           return if ignored_node?(node)

data/lib/rubocop/cop/layout/rescue_ensure_alignment.rb

@@ -30,7 +30,6 @@ module RuboCop
         ANCESTOR_TYPES = %i[kwbegin def defs class module].freeze
         RUBY_2_5_ANCESTOR_TYPES = (ANCESTOR_TYPES + %i[block]).freeze
         ANCESTOR_TYPES_WITH_ACCESS_MODIFIERS = %i[def defs].freeze
-        ASSIGNMENT_TYPES = %i[lvasgn].freeze
 
         def on_resbody(node)
           check(node) unless modifier?(node)
@@ -141,8 +140,7 @@ module RuboCop
         def assignment_node(node)
           assignment_node = node.ancestors.first
           return nil unless
-            assignment_node &&
-            ASSIGNMENT_TYPES.include?(assignment_node.type)
+            assignment_node && assignment_node.assignment?
 
           assignment_node
         end

data/lib/rubocop/cop/layout/space_before_first_arg.rb

@@ -40,6 +40,7 @@ module RuboCop
 
           add_offense(space, location: space) if space.length != 1
         end
+        alias on_csend on_send
 
         def autocorrect(range)
           ->(corrector) { corrector.replace(range, ' ') }

data/lib/rubocop/cop/lint/ambiguous_block_association.rb

@@ -37,6 +37,7 @@ module RuboCop
 
           add_offense(node)
         end
+        alias on_csend on_send
 
         private
 

data/lib/rubocop/cop/lint/disjunctive_assignment_in_constructor.rb

@@ -31,13 +31,13 @@ module RuboCop
 
         private
 
+        # @param [DefNode] node a constructor definition
         def check(node)
           return unless node.method_name == :initialize
 
           check_body(node.body)
         end
 
-        # @param [DefNode] node a constructor definition
         def check_body(body)
           return if body.nil?
 

data/lib/rubocop/cop/lint/each_with_object_argument.rb

@@ -24,7 +24,9 @@ module RuboCop
       class EachWithObjectArgument < Cop
         MSG = 'The argument to each_with_object can not be immutable.'.freeze
 
-        def_node_matcher :each_with_object?, '(send _ :each_with_object $_)'
+        def_node_matcher :each_with_object?, <<-PATTERN
+          ({send csend} _ :each_with_object $_)
+        PATTERN
 
         def on_send(node)
           each_with_object?(node) do |arg|
@@ -33,6 +35,7 @@ module RuboCop
             add_offense(node)
           end
         end
+        alias on_csend on_send
       end
     end
   end

data/lib/rubocop/cop/lint/parentheses_as_grouped_expression.rb

@@ -35,6 +35,7 @@ module RuboCop
 
           add_offense(nil, location: range)
         end
+        alias on_csend on_send
 
         private
 
@@ -50,7 +51,7 @@ module RuboCop
           # Escape question mark if any.
           method_regexp = Regexp.escape(node.method_name)
 
-          match = without_receiver.match(/^\s*\.?\s*#{method_regexp}(\s+)\(/)
+          match = without_receiver.match(/^\s*&?\.?\s*#{method_regexp}(\s+)\(/)
           match ? match.captures[0].length : 0
         end
 

data/lib/rubocop/cop/lint/require_parentheses.rb

@@ -42,6 +42,7 @@ module RuboCop
             check_predicate(node.last_argument, node)
           end
         end
+        alias on_csend on_send
 
         private
 

data/lib/rubocop/cop/mixin/check_assignment.rb

@@ -31,7 +31,7 @@ module RuboCop
           _scope, _lhs, rhs = *node
         elsif node.op_asgn_type?
           _lhs, _op, rhs = *node
-        elsif node.send_type?
+        elsif node.send_type? || node.csend_type?
           rhs = node.last_argument
         elsif node.assignment?
           _lhs, rhs = *node

data/lib/rubocop/cop/mixin/end_keyword_alignment.rb

@@ -54,12 +54,9 @@ module RuboCop
       end
 
       def variable_alignment?(whole_expression, rhs, end_alignment_style)
-        case end_alignment_style
-        when :variable
-          !line_break_before_keyword?(whole_expression, rhs)
-        when :start_of_line
-          true
-        end
+        return if end_alignment_style == :keyword
+
+        !line_break_before_keyword?(whole_expression, rhs)
       end
 
       def line_break_before_keyword?(whole_expression, rhs)

data/lib/rubocop/cop/mixin/trailing_comma.rb

@@ -17,11 +17,13 @@ module RuboCop
       end
 
       def check(node, items, kind, begin_pos, end_pos)
-        return if heredoc?(items.last)
-
         after_last_item = range_between(begin_pos, end_pos)
 
-        comma_offset = after_last_item.source =~ /,/
+        # If there is any heredoc in items, then match the comma succeeding
+        # any whitespace (except newlines), otherwise allow for newlines
+        comma_regex = any_heredoc?(items) ? /\A[^\S\n]*,/ : /\A\s*,/
+        comma_offset = after_last_item.source =~ comma_regex &&
+                       after_last_item.source.index(',')
 
         if comma_offset && !inside_comment?(after_last_item, comma_offset)
           check_comma(node, kind, after_last_item.begin_pos + comma_offset)
@@ -167,6 +169,10 @@ module RuboCop
         false
       end
 
+      def any_heredoc?(items)
+        items.any? { |item| heredoc?(item) }
+      end
+
       def heredoc?(node)
         return false unless node.is_a?(RuboCop::AST::Node)
         return true if node.loc.respond_to?(:heredoc_body)

data/lib/rubocop/cop/naming/memoized_instance_variable_name.rb

@@ -132,9 +132,7 @@ module RuboCop
           variable = ivar_assign.children.first
           variable_name = variable.to_s.sub('@', '')
 
-          return false unless valid_leading_underscore?(variable_name)
-
-          variable_name.sub(/\A_/, '') == method_name.sub(/\A_/, '')
+          variable_name_candidates(method_name).include?(variable_name)
         end
 
         def message(variable)
@@ -152,14 +150,19 @@ module RuboCop
           style == :required ? "_#{suggestion}" : suggestion
         end
 
-        def valid_leading_underscore?(variable_name)
+        def variable_name_candidates(method_name)
+          no_underscore = method_name.sub(/\A_/, '')
+          with_underscore = "_#{method_name}"
           case style
           when :required
-            variable_name.start_with?('_')
+            [with_underscore,
+             method_name.start_with?('_') ? method_name : nil].compact
           when :disallowed
-            !variable_name.start_with?('_')
+            [method_name, no_underscore]
+          when :optional
+            [method_name, with_underscore, no_underscore]
           else
-            true
+            raise 'Unreachable'
           end
         end
       end

data/lib/rubocop/cop/performance/chain_array_allocation.rb

@@ -47,8 +47,9 @@ module RuboCop
         HAS_MUTATION_ALTERNATIVE = ':collect :compact :flatten :map :reject '\
                                    ':reverse :rotate :select :shuffle :sort '\
                                    ':uniq '.freeze
-        MSG = 'Use `%<method>s...%<second_method>s!` instead of `%<method>s' \
-              '...%<second_method>s`.'.freeze
+        MSG = 'Use unchained `%<method>s!` and `%<second_method>s!` '\
+              '(followed by `return array` if required) instead of chaining '\
+              '`%<method>s...%<second_method>s`.'.freeze
 
         def_node_matcher :flat_map_candidate?, <<-PATTERN
           {

data/lib/rubocop/cop/rails/active_record_aliases.rb

@@ -32,6 +32,8 @@ module RuboCop
           end
         end
 
+        alias on_csend on_send
+
         def autocorrect(node)
           lambda do |corrector|
             corrector.replace(

data/lib/rubocop/cop/rails/belongs_to.rb

@@ -19,7 +19,7 @@ module RuboCop
       # In the case that the developer is doing `required: false`, we
       # definitely want to autocorrect to `optional: true`.
       #
-      # However, without knowing whether they've set overriden the default
+      # However, without knowing whether they've set overridden the default
       # value of `config.active_record.belongs_to_required_by_default`, we
       # can't say whether it's safe to remove `required: true` or whether we
       # should replace it with `optional: false` (or, similarly, remove a

data/lib/rubocop/cop/rails/date.rb

@@ -79,6 +79,7 @@ module RuboCop
           add_offense(node, location: :selector,
                             message: format(MSG_SEND, method: node.method_name))
         end
+        alias on_csend on_send
 
         private
 

data/lib/rubocop/cop/rails/dynamic_find_by.rb

@@ -42,6 +42,7 @@ module RuboCop
                       message: format(MSG, static_name: static_name,
                                            method: node.method_name))
         end
+        alias on_csend on_send
 
         def autocorrect(node)
           keywords = column_keywords(node.method_name)

data/lib/rubocop/cop/rails/find_by.rb

@@ -20,7 +20,7 @@ module RuboCop
         TARGET_SELECTORS = %i[first take].freeze
 
         def_node_matcher :where_first?, <<-PATTERN
-          (send (send _ :where ...) {:first :take})
+          (send ({send csend} _ :where ...) {:first :take})
         PATTERN
 
         def on_send(node)
@@ -32,6 +32,7 @@ module RuboCop
           add_offense(node, location: range,
                             message: format(MSG, method: node.method_name))
         end
+        alias on_csend on_send
 
         def autocorrect(node)
           # Don't autocorrect where(...).first, because it can return different

data/lib/rubocop/cop/rails/link_to_blank.rb

@@ -74,7 +74,9 @@ module RuboCop
         def add_rel(send_node, offence_node, corrector)
           quote_style = offence_node.children.last.source[0]
           new_rel_exp = ", rel: #{quote_style}noopener#{quote_style}"
-          corrector.insert_after(send_node.loc.expression, new_rel_exp)
+          range = send_node.arguments.last.source_range
+
+          corrector.insert_after(range, new_rel_exp)
         end
 
         def contains_noopener?(str)

data/lib/rubocop/cop/rails/reflection_class_name.rb

@@ -0,0 +1,38 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Rails
+      # This cop checks if the value of the option `class_name`, in
+      # the definition of a reflection is a string.
+      #
+      # @example
+      #   # bad
+      #   has_many :accounts, class_name: Account
+      #   has_many :accounts, class_name: Account.name
+      #
+      #   # good
+      #   has_many :accounts, class_name: 'Account'
+      class ReflectionClassName < Cop
+        MSG = 'Use a string has value for a class_name.'.freeze
+
+        def_node_matcher :association_with_options?, <<-PATTERN
+          (send nil? {:has_many :has_one :belongs_to} _ (hash $...))
+        PATTERN
+
+        def_node_search :reflection_class_name, <<-PATTERN
+          (pair (sym :class_name) !str)
+        PATTERN
+
+        def on_send(node)
+          return unless association_with_options?(node)
+
+          reflection_class_name = reflection_class_name(node).first
+          return unless reflection_class_name
+
+          add_offense(node, location: reflection_class_name.loc.expression)
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/rails/save_bang.rb

@@ -146,6 +146,7 @@ module RuboCop
 
           add_offense_for_node(node)
         end
+        alias on_csend on_send
 
         def autocorrect(node)
           save_loc = node.loc.selector

data/lib/rubocop/cop/rails/skips_model_validations.rb

@@ -67,6 +67,7 @@ module RuboCop
 
           add_offense(node, location: :selector)
         end
+        alias on_csend on_send
 
         private
 

data/lib/rubocop/cop/rails/validation.rb

@@ -57,6 +57,9 @@ module RuboCop
         end
 
         def autocorrect(node)
+          last_argument = node.arguments.last
+          return if !last_argument.literal? && !last_argument.splat_type?
+
           lambda do |corrector|
             corrector.replace(node.loc.selector, 'validates')
             correct_validate_type(corrector, node)
@@ -75,12 +78,14 @@ module RuboCop
         end
 
         def correct_validate_type(corrector, node)
-          options = node.arguments.find { |arg| !arg.sym_type? }
+          last_argument = node.arguments.last
           validate_type = node.method_name.to_s.split('_')[1]
 
-          if options
-            corrector.replace(options.loc.expression,
-                              "#{validate_type}: #{braced_options(options)}")
+          if last_argument.hash_type?
+            corrector.replace(
+              last_argument.loc.expression,
+              "#{validate_type}: #{braced_options(last_argument)}"
+            )
           else
             corrector.insert_after(node.loc.expression,
                                    ", #{validate_type}: true")

data/lib/rubocop/cop/style/braces_around_hash_parameters.rb

@@ -53,6 +53,7 @@ module RuboCop
 
           check(node.last_argument, node.arguments)
         end
+        alias on_csend on_send
 
         # We let AutocorrectUnlessChangingAST#autocorrect work with the send
         # node, because that context is needed. When parsing the code to see if

data/lib/rubocop/cop/style/commented_keyword.rb

@@ -6,8 +6,8 @@ module RuboCop
       # This cop checks for comments put on the same line as some keywords.
       # These keywords are: `begin`, `class`, `def`, `end`, `module`.
       #
-      # Note that some comments (such as `:nodoc:` and `rubocop:disable`) are
-      # allowed.
+      # Note that some comments (`:nodoc:`, `:yields:, and `rubocop:disable`)
+      # are allowed.
       #
       # @example
       #   # bad
@@ -59,7 +59,7 @@ module RuboCop
         private
 
         KEYWORDS = %w[begin class def end module].freeze
-        ALLOWED_COMMENTS = %w[:nodoc: rubocop:disable].freeze
+        ALLOWED_COMMENTS = %w[:nodoc: :yields: rubocop:disable].freeze
 
         def offensive?(line)
           line = line.lstrip

data/lib/rubocop/cop/style/empty_literal.rb

@@ -67,10 +67,13 @@ module RuboCop
         end
 
         def first_argument_unparenthesized?(node)
-          return false unless node.parent && node.parent.send_type?
+          parent = node.parent
+          unless parent && %i[send super zsuper].include?(parent.type)
+            return false
+          end
 
-          _receiver, _method_name, *args = *node.parent
-          node.object_id == args.first.object_id && !parentheses?(node.parent)
+          node.object_id == parent.arguments.first.object_id &&
+            !parentheses?(node.parent)
         end
 
         def replacement_range(node)
@@ -79,7 +82,7 @@ module RuboCop
             # `some_method {}` is not same as `some_method Hash.new`
             # because the braces are interpreted as a block. We will have
             # to rewrite the arguments to wrap them in parenthesis.
-            _receiver, _method_name, *args = *node.parent
+            args = node.parent.arguments
 
             range_between(args[0].loc.expression.begin_pos - 1,
                           args[-1].loc.expression.end_pos)
@@ -107,7 +110,7 @@ module RuboCop
               # `some_method {}` is not same as `some_method Hash.new`
               # because the braces are interpreted as a block. We will have
               # to rewrite the arguments to wrap them in parenthesis.
-              _receiver, _method_name, *args = *node.parent
+              args = node.parent.arguments
               "(#{args[1..-1].map(&:source).unshift('{}').join(', ')})"
             else
               '{}'

data/lib/rubocop/cop/style/method_call_with_args_parentheses.rb

@@ -10,7 +10,7 @@ module RuboCop
       # Additional methods can be added to the `IgnoredMethods` list. This
       # option is valid only in the default style.
       #
-      # In the alternative style (omit_parentheses), there are two additional
+      # In the alternative style (omit_parentheses), there are three additional
       # options.
       #
       # 1. `AllowParenthesesInChaining` is `false` by default. Setting it to
@@ -21,6 +21,12 @@ module RuboCop
       #     to `true` allows the presence of parentheses in multi-line method
       #     calls.
       #
+      # 3. `AllowParenthesesInCamelCaseMethod` is `false` by default. This
+      #     allows the presence of parentheses when calling a method whose name
+      #     begins with a capital letter and which has no arguments. Setting it
+      #     to `true` allows the presence of parentheses in such a method call
+      #     even with arguments.
+      #
       # @example EnforcedStyle: require_parentheses (default)
       #
       #
@@ -106,6 +112,22 @@ module RuboCop
       #
       #   # good
       #   foo().bar 1
+      #
+      #   # AllowParenthesesInCamelCaseMethod: false (default)
+      #
+      #   # bad
+      #   Array(1)
+      #
+      #   # good
+      #   Array 1
+      #
+      #   # AllowParenthesesInCamelCaseMethod: true
+      #
+      #   # good
+      #   Array(1)
+      #
+      #   # good
+      #   Array 1
       class MethodCallWithArgsParentheses < Cop
         include ConfigurableEnforcedStyle
         include IgnoredMethods
@@ -120,6 +142,7 @@ module RuboCop
             add_offense_for_omit_parentheses(node)
           end
         end
+        alias on_csend on_send
         alias on_super on_send
         alias on_yield on_send
 
@@ -155,7 +178,7 @@ module RuboCop
           return unless node.parenthesized?
           return if node.implicit_call?
           return if super_call_without_arguments?(node)
-          return if camel_case_method_call_without_arguments?(node)
+          return if allowed_camel_case_method_call?(node)
           return if legitimate_call_with_parentheses?(node)
 
           add_offense(node, location: node.loc.begin.join(node.loc.end))
@@ -221,8 +244,10 @@ module RuboCop
           node.super_type? && node.arguments.none?
         end
 
-        def camel_case_method_call_without_arguments?(node)
-          node.camel_case_method? && node.arguments.none?
+        def allowed_camel_case_method_call?(node)
+          node.camel_case_method? &&
+            (node.arguments.none? ||
+             cop_config['AllowParenthesesInCamelCaseMethod'])
         end
 
         def legitimate_call_with_parentheses?(node)
@@ -264,13 +289,14 @@ module RuboCop
         end
 
         def call_with_braced_block?(node)
-          node.send_type? && node.block_node && node.block_node.braces?
+          (node.send_type? || node.super_type?) &&
+            node.block_node && node.block_node.braces?
         end
 
         def call_as_argument_or_chain?(node)
           node.parent &&
             (node.parent.send_type? && !assigned_before?(node.parent, node) ||
-             node.parent.csend_type?)
+             node.parent.csend_type? || node.parent.super_type?)
         end
 
         def hash_literal_in_arguments?(node)

data/lib/rubocop/cop/style/method_called_on_do_end_block.rb

@@ -39,6 +39,7 @@ module RuboCop
 
           add_offense(nil, location: range)
         end
+        alias on_csend on_send
       end
     end
   end

data/lib/rubocop/cop/style/nested_parenthesized_calls.rb

@@ -20,7 +20,7 @@ module RuboCop
         def on_send(node)
           return unless node.parenthesized?
 
-          node.each_child_node(:send) do |nested|
+          node.each_child_node(:send, :csend) do |nested|
             next if allowed_omission?(nested)
 
             add_offense(nested,
@@ -28,6 +28,7 @@ module RuboCop
                         message: format(MSG, source: nested.source))
           end
         end
+        alias on_csend on_send
 
         def autocorrect(nested)
           first_arg = nested.first_argument.source_range

data/lib/rubocop/cop/style/one_line_conditional.rb

@@ -67,6 +67,8 @@ module RuboCop
         end
 
         def expr_replacement(node)
+          return 'nil' if node.nil?
+
           requires_parentheses?(node) ? "(#{node.source})" : node.source
         end
 

data/lib/rubocop/cop/style/preferred_hash_methods.rb

@@ -41,6 +41,7 @@ module RuboCop
 
           add_offense(node, location: :selector)
         end
+        alias on_csend on_send
 
         def autocorrect(node)
           lambda do |corrector|

data/lib/rubocop/cop/style/send.rb

@@ -17,13 +17,14 @@ module RuboCop
         MSG = 'Prefer `Object#__send__` or `Object#public_send` to ' \
               '`send`.'.freeze
 
-        def_node_matcher :sending?, '(send _ :send ...)'
+        def_node_matcher :sending?, '({send csend} _ :send ...)'
 
         def on_send(node)
           return unless sending?(node) && node.arguments?
 
           add_offense(node, location: :selector)
         end
+        alias on_csend on_send
       end
     end
   end

data/lib/rubocop/cop/style/string_methods.rb

@@ -24,6 +24,7 @@ module RuboCop
 
           add_offense(node, location: :selector)
         end
+        alias on_csend on_send
 
         def autocorrect(node)
           lambda do |corrector|

data/lib/rubocop/cop/style/trailing_comma_in_arguments.rb

@@ -59,6 +59,7 @@ module RuboCop
                 node.last_argument.source_range.end_pos,
                 node.source_range.end_pos)
         end
+        alias on_csend on_send
 
         def autocorrect(range)
           PunctuationCorrector.swap_comma(range)

data/lib/rubocop/cop/style/unneeded_condition.rb

@@ -96,8 +96,9 @@ module RuboCop
         end
 
         def make_ternary_form(node)
-          ternary_form = [node.if_branch.source,
-                          else_source(node.else_branch)].join(' || ')
+          _condition, if_branch, else_branch = *node
+          ternary_form = [if_branch.source,
+                          else_source(else_branch)].join(' || ')
 
           if node.parent && node.parent.send_type?
             "(#{ternary_form})"

data/lib/rubocop/cop/style/yoda_condition.rb

@@ -97,11 +97,6 @@ module RuboCop
             !noncommutative_operator?(node)
         end
 
-        def both_literals?(node)
-          lhs, _operator, rhs = *node
-          lhs.literal? && rhs.literal?
-        end
-
         def valid_yoda?(node)
           lhs, _operator, rhs = *node
 

data/lib/rubocop/platform.rb

@@ -5,7 +5,7 @@ module RuboCop
   # on.
   module Platform
     def self.windows?
-      RUBY_PLATFORM =~ /cygwin|mswin|mingw|bccwin|wince|emx/
+      RbConfig::CONFIG['host_os'] =~ /cygwin|mswin|mingw|bccwin|wince|emx/
     end
   end
 end

data/lib/rubocop/version.rb

@@ -3,7 +3,7 @@
 module RuboCop
   # This module holds the RuboCop version information.
   module Version
-    STRING = '0.63.1'.freeze
+    STRING = '0.64.0'.freeze
 
     MSG = '%<version>s (using Parser %<parser_version>s, running on ' \
           '%<ruby_engine>s %<ruby_version>s %<ruby_platform>s)'.freeze

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop
 version: !ruby/object:Gem::Version
-  version: 0.63.1
+  version: 0.64.0
 platform: ruby
 authors:
 - Bozhidar Batsov
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-01-22 00:00:00.000000000 Z
+date: 2019-02-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: jaro_winkler
@@ -572,6 +572,7 @@ files:
 - lib/rubocop/cop/rails/present.rb
 - lib/rubocop/cop/rails/read_write_attribute.rb
 - lib/rubocop/cop/rails/redundant_receiver_in_with_options.rb
+- lib/rubocop/cop/rails/reflection_class_name.rb
 - lib/rubocop/cop/rails/refute_methods.rb
 - lib/rubocop/cop/rails/relative_date_constant.rb
 - lib/rubocop/cop/rails/request_referer.rb