rubocop 0.59.0 → 0.59.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3604f5385c9cdb9a48c56e4b02e873b1f03adc3c
-  data.tar.gz: '039e08df8dc0c3fa47b0a035e650dbdc52068527'
+  metadata.gz: c194b5622ecc91385098a2b68a32fefb80dfe3c1
+  data.tar.gz: 6b77f223ef06685ee4af7543faed16456c38d7cb
 SHA512:
-  metadata.gz: 0c6b9b6cce39cf4f4977f691a58b43362249e537e798ecb52d639147b8a92df7b32b6aa8553258b66f7093638c0afc11427390ea71cb90c872dbc8510d14359f
-  data.tar.gz: 2f529fb7c60a2ffc733582edec86c1f66059a41e23a0835adf4d3f05593e6e49d0b061d91d06e4e968e7d5c544505e6781a71bfbe20234262eaa080091d86ffe
+  metadata.gz: 14a31079c85a1f77781219df27ffaeb0756ef006ca737c92a4690ff50f3cff68e407520b3d389bb03cdba4853eddcb07fa375955478547d4bfd219f8dc1e84dc
+  data.tar.gz: cee68c85b7430c9fb32e11206d9e8b8b1f87dd3cc29b0a878daf62b91e26cbd54793e4ead915b4894e1082c5f6d7dcd8584bf5f0a96e4123df32009ca11ff438

data/README.md

@@ -1,5 +1,4 @@
 [![Gem Version](https://badge.fury.io/rb/rubocop.svg)](http://badge.fury.io/rb/rubocop)
-[![Travis Status](https://travis-ci.org/rubocop-hq/rubocop.svg?branch=master)](https://travis-ci.org/rubocop-hq/rubocop)
 [![CircleCI Status](https://circleci.com/gh/rubocop-hq/rubocop/tree/master.svg?style=svg)](https://circleci.com/gh/rubocop-hq/rubocop/tree/master)
 [![AppVeyor Status](https://ci.appveyor.com/api/projects/status/sj3ye7n5690d0nvg?svg=true)](https://ci.appveyor.com/project/bbatsov/rubocop)
 [![Coverage Status](https://img.shields.io/codeclimate/coverage/github/bbatsov/rubocop.svg)](https://codeclimate.com/github/bbatsov/rubocop)
@@ -54,7 +53,7 @@ haven't reached version 1.0 yet). To prevent an unwanted RuboCop update you
 might want to use a conservative version locking in your `Gemfile`:
 
 ```rb
-gem 'rubocop', '~> 0.59.0', require: false
+gem 'rubocop', '~> 0.59.1', require: false
 ```
 
 ## Quickstart

data/lib/rubocop/ast/node/mixin/method_dispatch_node.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module AST
     # Common functionality for nodes that are a kind of method dispatch:
-    # `send`, `csend`, `super`, `zsuper`, `yield`
+    # `send`, `csend`, `super`, `zsuper`, `yield`, `defined?`
     module MethodDispatchNode
       extend NodePattern::Macros
       include MethodIdentifierPredicates
@@ -163,6 +163,25 @@ module RuboCop
           [self, *each_descendant(:send)].any?(&:adjacent_def_modifier?)
       end
 
+      # Checks whether this is a lambda. Some versions of parser parses
+      # non-literal lambdas as a method send.
+      #
+      # @return [Boolean] whether this method is a lambda
+      def lambda?
+        block_literal? && command?(:lambda)
+      end
+
+      # Checks whether this is a lambda literal (stabby lambda.)
+      #
+      # @example
+      #
+      #   -> (foo) { bar }
+      #
+      # @return [Boolean] whether this method is a lambda literal
+      def lambda_literal?
+        block_literal? && loc.expression && loc.expression.source == '->'
+      end
+
       private
 
       def_node_matcher :macro_scope?, <<-PATTERN

data/lib/rubocop/ast/node/send_node.rb

@@ -8,21 +8,6 @@ module RuboCop
     class SendNode < Node
       include ParameterizedNode
       include MethodDispatchNode
-
-      # Checks whether this is a lambda. Some versions of parser parses
-      # non-literal lambdas as a method send.
-      #
-      # @return [Boolean] whether this method is a lambda
-      def lambda?
-        block_literal? && method?(:lambda)
-      end
-
-      # Checks whether this is a stabby lambda. e.g. `-> () {}`
-      #
-      # @return [Boolean] whether this method is a stabby lambda
-      def stabby_lambda?
-        loc.selector && loc.selector.source == '->'
-      end
     end
   end
 end

data/lib/rubocop/config.rb

@@ -383,6 +383,11 @@ module RuboCop
     end
 
     def allowed_camel_case_file?(file)
+      # Gemspecs are allowed to have dashes because that fits with bundler best
+      # practices in the case when the gem is nested under a namespace (e.g.,
+      # `bundler-console` conveys `Bundler::Console`).
+      return true if File.extname(file) == '.gemspec'
+
       file_to_include?(file) do |pattern, relative_path, absolute_path|
         pattern.to_s =~ /[A-Z]/ &&
           (match_path?(pattern, relative_path) ||

data/lib/rubocop/cop/layout/empty_line_after_guard_clause.rb

@@ -47,7 +47,10 @@ module RuboCop
           if last_argument_is_heredoc?(node)
             heredoc_node = last_argument(node)
 
-            num_of_heredoc_lines = heredoc_node.children.size
+            heredoc_body = heredoc_node.loc.heredoc_body
+            num_of_heredoc_lines =
+              heredoc_body.last_line - heredoc_body.first_line
+
             line = node.last_line + num_of_heredoc_lines + END_OF_HEREDOC_LINE
 
             return if next_line_empty?(line)
@@ -62,7 +65,12 @@ module RuboCop
 
         def autocorrect(node)
           lambda do |corrector|
-            node_range = range_by_whole_lines(node.source_range)
+            node_range = if node.respond_to?(:heredoc?) && node.heredoc?
+                           range_by_whole_lines(node.loc.heredoc_body)
+                         else
+                           range_by_whole_lines(node.source_range)
+                         end
+
             corrector.insert_after(node_range, "\n")
           end
         end
@@ -106,19 +114,17 @@ module RuboCop
         end
 
         def last_argument_is_heredoc?(node)
-          last_children = node.children.last
+          last_children = node.if_branch
 
           return false unless last_children && last_children.send_type?
 
           last_argument = last_argument(node)
 
-          last_argument &&
-            (last_argument.str_type? || last_argument.dstr_type?) &&
-            last_argument.heredoc?
+          last_argument.respond_to?(:heredoc?) && last_argument.heredoc?
         end
 
         def last_argument(node)
-          node.children.last.last_argument
+          node.if_branch.children.last
         end
       end
     end

data/lib/rubocop/cop/lint/unreachable_code.rb

@@ -56,7 +56,7 @@ module RuboCop
             return next break retry redo
             (send
              {nil? (const {nil? cbase} :Kernel)}
-             {:raise :fail :throw}
+             {:raise :fail :throw :exit :exit! :abort}
              ...)
           }
         PATTERN

data/lib/rubocop/cop/naming/binary_operator_parameter_name.rb

@@ -18,7 +18,7 @@ module RuboCop
               'name its argument `other`.'.freeze
 
         OP_LIKE_METHODS = %i[eql? equal?].freeze
-        BLACKLISTED = %i[+@ -@ [] []= << `].freeze
+        BLACKLISTED = %i[+@ -@ [] []= << === `].freeze
 
         def_node_matcher :op_method_candidate?, <<-PATTERN
           (def [#op_method? $_] (args $(arg [!:other !:_other])) _)

data/lib/rubocop/cop/naming/file_name.rb

@@ -9,6 +9,11 @@ module RuboCop
       # names. Ruby scripts (i.e. source files with a shebang in the
       # first line) are ignored.
       #
+      # The cop also ignores `.gemspec` files, because Bundler
+      # recommends using dashes to separate namespaces in nested gems
+      # (i.e. `bundler-console` becomes `Bundler::Console`). As such, the
+      # gemspec is supposed to be named `bundler-console.gemspec`.
+      #
       # @example
       #   # bad
       #   lib/layoutManager.rb
@@ -91,7 +96,11 @@ module RuboCop
         end
 
         def filename_good?(basename)
+          basename = basename.sub(/^\./, '')
           basename = basename.sub(/\.[^\.]+$/, '')
+          # special handling for Action Pack Variants file names like
+          # some_file.xlsx+mobile.axlsx
+          basename = basename.sub('+', '_')
           basename =~ (regex || SNAKE_CASE)
         end
 
@@ -164,7 +173,7 @@ module RuboCop
           # To convert a pathname to a Ruby namespace, we need a starting point
           # But RC can be run from any working directory, and can check any path
           # We can't assume that the working directory, or any other, is the
-          # "starting point" to build a namespace
+          # "starting point" to build a namespace.
           start = %w[lib spec test src]
           start_index = nil
 

data/lib/rubocop/cop/rails/find_each.rb

@@ -39,7 +39,7 @@ module RuboCop
         private
 
         def method_chain(node)
-          [*node.ancestors, node].map(&:method_name)
+          [*node.descendants.select(&:send_type?), node].map(&:method_name)
         end
 
         def ignored_by_find_each?(relation_method)

data/lib/rubocop/cop/style/empty_block_parameter.rb

@@ -29,7 +29,7 @@ module RuboCop
 
         def on_block(node)
           send_node = node.send_node
-          check(node) unless send_node.send_type? && send_node.stabby_lambda?
+          check(node) unless send_node.send_type? && send_node.lambda_literal?
         end
 
         def autocorrect(node)

data/lib/rubocop/cop/style/empty_case_condition.rb

@@ -67,9 +67,8 @@ module RuboCop
         private
 
         def correct_case_when(corrector, case_node, when_nodes)
-          case_range = case_node.loc.keyword.join(when_nodes.first.loc.keyword)
-
-          corrector.replace(case_range, 'if')
+          remove_case_node(corrector, case_node)
+          corrector.replace(when_nodes.first.loc.keyword, 'if')
 
           when_nodes[1..-1].each do |when_node|
             corrector.replace(when_node.loc.keyword, 'elsif')
@@ -88,6 +87,14 @@ module RuboCop
             corrector.replace(range, conditions.map(&:source).join(' || '))
           end
         end
+
+        def remove_case_node(corrector, case_node)
+          range = range_by_whole_lines(
+            case_node.loc.keyword, include_final_newline: true
+          )
+
+          corrector.remove(range)
+        end
       end
     end
   end

data/lib/rubocop/cop/style/empty_lambda_parameter.rb

@@ -26,7 +26,7 @@ module RuboCop
           send_node = node.send_node
           return unless send_node.send_type?
 
-          check(node) if node.send_node.stabby_lambda?
+          check(node) if node.send_node.lambda_literal?
         end
 
         def autocorrect(node)

data/lib/rubocop/cop/style/multiline_method_signature.rb

@@ -22,6 +22,7 @@ module RuboCop
         MSG = 'Avoid multi-line method signatures.'.freeze
 
         def on_def(node)
+          return unless node.arguments?
           return if opening_line(node) == closing_line(node)
           return if correction_exceeds_max_line_length?(node)
 
@@ -36,11 +37,7 @@ module RuboCop
         end
 
         def closing_line(node)
-          if node.arguments?
-            node.arguments.last_line
-          else
-            node.first_line
-          end
+          node.arguments.last_line
         end
 
         def correction_exceeds_max_line_length?(node)
@@ -52,8 +49,7 @@ module RuboCop
         end
 
         def definition_width(node)
-          node.loc.expression.source.squeeze.length -
-            node.loc.end.source.length
+          node.source_range.begin.join(node.arguments.source_range.end).length
         end
 
         def max_line_length

data/lib/rubocop/cop/style/redundant_begin.rb

@@ -65,7 +65,7 @@ module RuboCop
         def on_block(node)
           return if target_ruby_version < 2.5
 
-          return if node.send_node.stabby_lambda?
+          return if node.send_node.lambda_literal?
           return if node.braces?
 
           check(node)

data/lib/rubocop/cop/style/stabby_lambda_parentheses.rb

@@ -30,7 +30,7 @@ module RuboCop
           return unless redundant_parentheses?(node) ||
                         missing_parentheses?(node)
 
-          add_offense(node.parent.arguments)
+          add_offense(node.block_node.arguments)
         end
 
         def autocorrect(node)
@@ -57,7 +57,7 @@ module RuboCop
 
         def missing_parentheses_corrector(node)
           lambda do |corrector|
-            args_loc = node.parent.arguments.source_range
+            args_loc = node.loc.expression
 
             corrector.insert_before(args_loc, '(')
             corrector.insert_after(args_loc, ')')
@@ -66,7 +66,7 @@ module RuboCop
 
         def unwanted_parentheses_corrector(node)
           lambda do |corrector|
-            args_loc = node.parent.arguments.loc
+            args_loc = node.loc
 
             corrector.replace(args_loc.begin, '')
             corrector.remove(args_loc.end)
@@ -74,11 +74,11 @@ module RuboCop
         end
 
         def stabby_lambda_with_args?(node)
-          node.stabby_lambda? && node.parent.arguments?
+          node.lambda_literal? && node.block_node.arguments?
         end
 
         def parentheses?(node)
-          node.parent.arguments.loc.begin
+          node.block_node.arguments.loc.begin
         end
       end
     end

data/lib/rubocop/version.rb

@@ -3,7 +3,7 @@
 module RuboCop
   # This module holds the RuboCop version information.
   module Version
-    STRING = '0.59.0'.freeze
+    STRING = '0.59.1'.freeze
 
     MSG = '%<version>s (using Parser %<parser_version>s, running on ' \
           '%<ruby_engine>s %<ruby_version>s %<ruby_platform>s)'.freeze

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop
 version: !ruby/object:Gem::Version
-  version: 0.59.0
+  version: 0.59.1
 platform: ruby
 authors:
 - Bozhidar Batsov
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-09-09 00:00:00.000000000 Z
+date: 2018-09-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: jaro_winkler