rubocop 0.58.2 → 0.59.0

data/lib/rubocop/path_util.rb

@@ -36,12 +36,14 @@ module RuboCop
     def match_path?(pattern, path)
       case pattern
       when String
-        File.fnmatch?(pattern, path, File::FNM_PATHNAME | File::FNM_EXTGLOB)
+        File.fnmatch?(pattern, path, File::FNM_PATHNAME | File::FNM_EXTGLOB) ||
+          hidden_file_in_not_hidden_dir?(pattern, path)
       when Regexp
         begin
           path =~ pattern
         rescue ArgumentError => e
           return false if e.message.start_with?('invalid byte sequence')
+
           raise e
         end
       end
@@ -59,5 +61,18 @@ module RuboCop
     def self.reset_pwd
       @pwd = nil
     end
+
+    def hidden_file_in_not_hidden_dir?(pattern, path)
+      File.fnmatch?(
+        pattern, path,
+        File::FNM_PATHNAME | File::FNM_EXTGLOB | File::FNM_DOTMATCH
+      ) && File.basename(path).start_with?('.') && !hidden_dir?(path)
+    end
+
+    def hidden_dir?(path)
+      File.dirname(path).split(File::SEPARATOR).any? do |dir|
+        dir.start_with?('.')
+      end
+    end
   end
 end

data/lib/rubocop/processed_source.rb

@@ -46,6 +46,7 @@ module RuboCop
 
     def ast_with_comments
       return if !ast || !comments
+
       @ast_with_comments ||= Parser::Source::Comment.associate(ast, comments)
     end
 
@@ -58,6 +59,7 @@ module RuboCop
         result = []
         all_lines.each_with_index do |line, ix|
           break if ix >= last_token_line && line == '__END__'
+
           result << line
         end
         result
@@ -70,6 +72,7 @@ module RuboCop
 
     def valid_syntax?
       return false if @parser_error
+
       @diagnostics.none? { |d| %i[error fatal].include?(d.level) }
     end
 
@@ -112,6 +115,7 @@ module RuboCop
 
     def start_with?(string)
       return false if self[0].nil?
+
       self[0].start_with?(string)
     end
 

data/lib/rubocop/remote_config.rb

@@ -21,6 +21,7 @@ module RuboCop
       request do |response|
         next if response.is_a?(Net::HTTPNotModified)
         next if response.is_a?(SocketError)
+
         File.open cache_path, 'w' do |io|
           io.write response.body
         end
@@ -60,7 +61,11 @@ module RuboCop
       when Net::HTTPRedirection
         request(URI.parse(response['location']), limit - 1, &block)
       else
-        response.error!
+        begin
+          response.error!
+        rescue StandardError => e
+          raise e, "#{e.message} while downloading remote config file #{uri}"
+        end
       end
     end
 

data/lib/rubocop/result_cache.rb

@@ -18,6 +18,7 @@ module RuboCop
     # there's parallel execution and the cache is shared.
     def self.cleanup(config_store, verbose, cache_root = nil)
       return if inhibit_cleanup # OPTIMIZE: For faster testing
+
       cache_root ||= cache_root(config_store)
       return unless File.exist?(cache_root)
 

data/lib/rubocop/rspec/cop_helper.rb

@@ -15,19 +15,15 @@ module CopHelper
   end
 
   def inspect_source(source, file = nil)
-    if source.is_a?(Array) && source.size == 1
-      raise "Don't use an array for a single line of code: #{source}"
-    end
     RuboCop::Formatter::DisabledConfigFormatter.config_to_allow_offenses = {}
     RuboCop::Formatter::DisabledConfigFormatter.detected_styles = {}
     processed_source = parse_source(source, file)
     raise 'Error parsing example code' unless processed_source.valid_syntax?
+
     _investigate(cop, processed_source)
   end
 
   def parse_source(source, file = nil)
-    source = source.join($RS) if source.is_a?(Array)
-
     if file && file.respond_to?(:write)
       file.write(source)
       file.rewind
@@ -56,6 +52,7 @@ module CopHelper
       cop.instance_variable_set(:@corrections, [])
       new_source = autocorrect_source(source, file)
       return new_source if new_source == source
+
       source = new_source
     end
   end
@@ -63,6 +60,7 @@ module CopHelper
   def _investigate(cop, processed_source)
     forces = RuboCop::Cop::Force.all.each_with_object([]) do |klass, instances|
       next unless cop.join_force?(klass)
+
       instances << klass.new([cop])
     end
 

data/lib/rubocop/rspec/shared_examples.rb

@@ -2,13 +2,6 @@
 
 # `cop` and `source` must be declared with #let.
 
-shared_examples_for 'accepts' do
-  it 'accepts' do
-    inspect_source(source)
-    expect(cop.offenses).to be_empty
-  end
-end
-
 shared_examples_for 'misaligned' do |annotated_source, used_style|
   config_to_allow_offenses = if used_style
                                { 'EnforcedStyleAlignWith' => used_style.to_s }
@@ -42,8 +35,7 @@ shared_examples_for 'aligned' do |alignment_base, arg, end_kw, name|
   name ||= alignment_base
   name = name.gsub(/\n/, ' <newline>')
   it "accepts matching #{name} ... end" do
-    inspect_source(["#{alignment_base} #{arg}",
-                    end_kw])
+    inspect_source("#{alignment_base} #{arg}\n#{end_kw}")
     expect(cop.offenses).to be_empty
   end
 end

data/lib/rubocop/runner.rb

@@ -80,6 +80,7 @@ module RuboCop
 
         if offenses.any? { |o| considered_failure?(o) }
           break false if @options[:fail_fast]
+
           next false
         end
 
@@ -98,6 +99,9 @@ module RuboCop
       file_started(file)
 
       offenses = file_offenses(file)
+      if @options[:display_only_fail_level_offenses]
+        offenses = offenses.select { |o| considered_failure?(o) }
+      end
       formatter_set.file_finished(file, offenses)
       offenses
     rescue InfiniteCorrectionLoop => e

data/lib/rubocop/target_finder.rb

@@ -74,6 +74,7 @@ module RuboCop
     def to_inspect?(file, hidden_files, base_dir_config)
       return false if base_dir_config.file_to_exclude?(file)
       return true if !hidden_files.include?(file) && ruby_file?(file)
+
       base_dir_config.file_to_include?(file)
     end
 
@@ -141,6 +142,7 @@ module RuboCop
 
     def ruby_executable?(file)
       return false unless File.extname(file).empty? && File.exist?(file)
+
       first_line = File.open(file, &:readline)
       !(first_line =~ /#!.*(#{ruby_interpreters(file).join('|')})/).nil?
     rescue EOFError, ArgumentError => e

data/lib/rubocop/version.rb

@@ -3,7 +3,7 @@
 module RuboCop
   # This module holds the RuboCop version information.
   module Version
-    STRING = '0.58.2'.freeze
+    STRING = '0.59.0'.freeze
 
     MSG = '%<version>s (using Parser %<parser_version>s, running on ' \
           '%<ruby_engine>s %<ruby_version>s %<ruby_platform>s)'.freeze

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop
 version: !ruby/object:Gem::Version
-  version: 0.58.2
+  version: 0.59.0
 platform: ruby
 authors:
 - Bozhidar Batsov
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-07-23 00:00:00.000000000 Z
+date: 2018-09-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: jaro_winkler
@@ -186,6 +186,7 @@ files:
 - lib/rubocop/ast/node/block_node.rb
 - lib/rubocop/ast/node/case_node.rb
 - lib/rubocop/ast/node/def_node.rb
+- lib/rubocop/ast/node/defined_node.rb
 - lib/rubocop/ast/node/ensure_node.rb
 - lib/rubocop/ast/node/for_node.rb
 - lib/rubocop/ast/node/hash_node.rb
@@ -225,6 +226,7 @@ files:
 - lib/rubocop/cop/autocorrect_logic.rb
 - lib/rubocop/cop/badge.rb
 - lib/rubocop/cop/bundler/duplicated_gem.rb
+- lib/rubocop/cop/bundler/gem_comment.rb
 - lib/rubocop/cop/bundler/insecure_protocol_source.rb
 - lib/rubocop/cop/bundler/ordered_gems.rb
 - lib/rubocop/cop/commissioner.rb
@@ -446,6 +448,7 @@ files:
 - lib/rubocop/cop/mixin/frozen_string_literal.rb
 - lib/rubocop/cop/mixin/hash_alignment.rb
 - lib/rubocop/cop/mixin/heredoc.rb
+- lib/rubocop/cop/mixin/ignored_methods.rb
 - lib/rubocop/cop/mixin/ignored_pattern.rb
 - lib/rubocop/cop/mixin/integer_node.rb
 - lib/rubocop/cop/mixin/match_range.rb
@@ -499,6 +502,7 @@ files:
 - lib/rubocop/cop/performance/caller.rb
 - lib/rubocop/cop/performance/case_when_splat.rb
 - lib/rubocop/cop/performance/casecmp.rb
+- lib/rubocop/cop/performance/chain_array_allocation.rb
 - lib/rubocop/cop/performance/compare_with_block.rb
 - lib/rubocop/cop/performance/count.rb
 - lib/rubocop/cop/performance/detect.rb
@@ -656,6 +660,7 @@ files:
 - lib/rubocop/cop/style/multiline_if_modifier.rb
 - lib/rubocop/cop/style/multiline_if_then.rb
 - lib/rubocop/cop/style/multiline_memoization.rb
+- lib/rubocop/cop/style/multiline_method_signature.rb
 - lib/rubocop/cop/style/multiline_ternary_operator.rb
 - lib/rubocop/cop/style/multiple_comparison.rb
 - lib/rubocop/cop/style/mutable_constant.rb