rubocop 0.52.1 → 0.53.0

data/lib/rubocop.rb

@@ -16,6 +16,7 @@ require 'unicode/display_width'
 require_relative 'rubocop/version'
 
 require_relative 'rubocop/path_util'
+require_relative 'rubocop/file_finder'
 require_relative 'rubocop/platform'
 require_relative 'rubocop/string_util'
 require_relative 'rubocop/name_similarity'
@@ -101,7 +102,8 @@ require_relative 'rubocop/cop/mixin/configurable_numbering'
 require_relative 'rubocop/cop/mixin/def_node'
 require_relative 'rubocop/cop/mixin/documentation_comment'
 require_relative 'rubocop/cop/mixin/duplication'
-require_relative 'rubocop/cop/mixin/empty_lines_around_body'
+require_relative 'rubocop/cop/mixin/range_help'
+require_relative 'rubocop/cop/mixin/empty_lines_around_body' # relies on range
 require_relative 'rubocop/cop/mixin/empty_parameter'
 require_relative 'rubocop/cop/mixin/end_keyword_alignment'
 require_relative 'rubocop/cop/mixin/enforce_superclass'
@@ -118,6 +120,7 @@ require_relative 'rubocop/cop/mixin/multiline_expression_indentation'
 require_relative 'rubocop/cop/mixin/multiline_literal_brace_layout'
 require_relative 'rubocop/cop/mixin/negative_conditional'
 require_relative 'rubocop/cop/mixin/heredoc'
+require_relative 'rubocop/cop/mixin/nil_methods'
 require_relative 'rubocop/cop/mixin/on_normal_if_unless'
 require_relative 'rubocop/cop/mixin/ordered_gem_node'
 require_relative 'rubocop/cop/mixin/parentheses'
@@ -137,12 +140,15 @@ require_relative 'rubocop/cop/mixin/string_literals_help'
 require_relative 'rubocop/cop/mixin/target_ruby_version'
 require_relative 'rubocop/cop/mixin/target_rails_version'
 require_relative 'rubocop/cop/mixin/too_many_lines'
+require_relative 'rubocop/cop/mixin/trailing_body'
 require_relative 'rubocop/cop/mixin/trailing_comma'
+require_relative 'rubocop/cop/mixin/uncommunicative_name'
 require_relative 'rubocop/cop/mixin/unused_argument'
 
 require_relative 'rubocop/cop/correctors/alignment_corrector'
 require_relative 'rubocop/cop/correctors/condition_corrector'
 require_relative 'rubocop/cop/correctors/empty_line_corrector'
+require_relative 'rubocop/cop/correctors/line_break_corrector'
 require_relative 'rubocop/cop/correctors/multiline_literal_brace_corrector'
 require_relative 'rubocop/cop/correctors/ordered_gem_corrector'
 require_relative 'rubocop/cop/correctors/parentheses_corrector'
@@ -163,13 +169,17 @@ require_relative 'rubocop/cop/layout/access_modifier_indentation'
 require_relative 'rubocop/cop/layout/align_array'
 require_relative 'rubocop/cop/layout/align_hash'
 require_relative 'rubocop/cop/layout/align_parameters'
+require_relative 'rubocop/cop/layout/block_alignment'
 require_relative 'rubocop/cop/layout/block_end_newline'
 require_relative 'rubocop/cop/layout/case_indentation'
 require_relative 'rubocop/cop/layout/class_structure'
 require_relative 'rubocop/cop/layout/closing_parenthesis_indentation'
 require_relative 'rubocop/cop/layout/comment_indentation'
+require_relative 'rubocop/cop/layout/condition_position'
+require_relative 'rubocop/cop/layout/def_end_alignment'
 require_relative 'rubocop/cop/layout/dot_position'
 require_relative 'rubocop/cop/layout/else_alignment'
+require_relative 'rubocop/cop/layout/empty_comment'
 require_relative 'rubocop/cop/layout/empty_line_after_magic_comment'
 require_relative 'rubocop/cop/layout/empty_line_between_defs'
 require_relative 'rubocop/cop/layout/empty_lines_around_access_modifier'
@@ -181,6 +191,7 @@ require_relative 'rubocop/cop/layout/empty_lines_around_exception_handling_keywo
 require_relative 'rubocop/cop/layout/empty_lines_around_method_body'
 require_relative 'rubocop/cop/layout/empty_lines_around_module_body'
 require_relative 'rubocop/cop/layout/empty_lines'
+require_relative 'rubocop/cop/layout/end_alignment'
 require_relative 'rubocop/cop/layout/end_of_line'
 require_relative 'rubocop/cop/layout/extra_spacing'
 require_relative 'rubocop/cop/layout/first_array_element_line_break'
@@ -237,12 +248,10 @@ require_relative 'rubocop/cop/lint/ambiguous_block_association'
 require_relative 'rubocop/cop/lint/ambiguous_operator'
 require_relative 'rubocop/cop/lint/ambiguous_regexp_literal'
 require_relative 'rubocop/cop/lint/assignment_in_condition'
-require_relative 'rubocop/cop/lint/block_alignment'
+require_relative 'rubocop/cop/lint/big_decimal_new'
 require_relative 'rubocop/cop/lint/boolean_symbol'
 require_relative 'rubocop/cop/lint/circular_argument_reference'
-require_relative 'rubocop/cop/lint/condition_position'
 require_relative 'rubocop/cop/lint/debugger'
-require_relative 'rubocop/cop/lint/def_end_alignment'
 require_relative 'rubocop/cop/lint/deprecated_class_methods'
 require_relative 'rubocop/cop/lint/duplicate_case_condition'
 require_relative 'rubocop/cop/lint/duplicate_methods'
@@ -253,7 +262,6 @@ require_relative 'rubocop/cop/lint/empty_ensure'
 require_relative 'rubocop/cop/lint/empty_expression'
 require_relative 'rubocop/cop/lint/empty_interpolation'
 require_relative 'rubocop/cop/lint/empty_when'
-require_relative 'rubocop/cop/lint/end_alignment'
 require_relative 'rubocop/cop/lint/end_in_method'
 require_relative 'rubocop/cop/lint/ensure_return'
 require_relative 'rubocop/cop/lint/float_out_of_range'
@@ -272,6 +280,8 @@ require_relative 'rubocop/cop/lint/nested_method_definition'
 require_relative 'rubocop/cop/lint/nested_percent_literal'
 require_relative 'rubocop/cop/lint/next_without_accumulator'
 require_relative 'rubocop/cop/lint/non_local_exit_from_iterator'
+require_relative 'rubocop/cop/lint/number_conversion'
+require_relative 'rubocop/cop/lint/ordered_magic_comments'
 require_relative 'rubocop/cop/lint/parentheses_as_grouped_expression'
 require_relative 'rubocop/cop/lint/percent_string_array'
 require_relative 'rubocop/cop/lint/percent_symbol_array'
@@ -292,7 +302,8 @@ require_relative 'rubocop/cop/lint/string_conversion_in_interpolation'
 require_relative 'rubocop/cop/lint/syntax'
 require_relative 'rubocop/cop/lint/underscore_prefixed_variable_name'
 require_relative 'rubocop/cop/lint/unified_integer'
-require_relative 'rubocop/cop/lint/unneeded_disable'
+require_relative 'rubocop/cop/lint/unneeded_cop_disable_directive'
+require_relative 'rubocop/cop/lint/unneeded_cop_enable_directive'
 require_relative 'rubocop/cop/lint/unneeded_require_statement'
 require_relative 'rubocop/cop/lint/unneeded_splat_expansion'
 require_relative 'rubocop/cop/lint/unreachable_code'
@@ -326,9 +337,12 @@ require_relative 'rubocop/cop/naming/constant_name'
 require_relative 'rubocop/cop/naming/file_name'
 require_relative 'rubocop/cop/naming/heredoc_delimiter_case'
 require_relative 'rubocop/cop/naming/heredoc_delimiter_naming'
+require_relative 'rubocop/cop/naming/memoized_instance_variable_name'
 require_relative 'rubocop/cop/naming/method_name'
 require_relative 'rubocop/cop/naming/binary_operator_parameter_name'
 require_relative 'rubocop/cop/naming/predicate_name'
+require_relative 'rubocop/cop/naming/uncommunicative_block_param_name'
+require_relative 'rubocop/cop/naming/uncommunicative_method_param_name'
 require_relative 'rubocop/cop/naming/variable_name'
 require_relative 'rubocop/cop/naming/variable_number'
 
@@ -341,7 +355,6 @@ require_relative 'rubocop/cop/performance/double_start_end_with'
 require_relative 'rubocop/cop/performance/end_with'
 require_relative 'rubocop/cop/performance/fixed_size'
 require_relative 'rubocop/cop/performance/flat_map'
-require_relative 'rubocop/cop/performance/hash_each_methods'
 require_relative 'rubocop/cop/performance/lstrip_rstrip'
 require_relative 'rubocop/cop/performance/range_include'
 require_relative 'rubocop/cop/performance/redundant_block_call'
@@ -396,12 +409,14 @@ require_relative 'rubocop/cop/style/empty_block_parameter'
 require_relative 'rubocop/cop/style/empty_case_condition'
 require_relative 'rubocop/cop/style/empty_else'
 require_relative 'rubocop/cop/style/empty_lambda_parameter'
+require_relative 'rubocop/cop/style/empty_line_after_guard_clause'
 require_relative 'rubocop/cop/style/empty_literal'
 require_relative 'rubocop/cop/style/empty_method'
 require_relative 'rubocop/cop/style/encoding'
 require_relative 'rubocop/cop/style/end_block'
 require_relative 'rubocop/cop/style/eval_with_location'
 require_relative 'rubocop/cop/style/even_odd'
+require_relative 'rubocop/cop/style/expand_path_arguments'
 require_relative 'rubocop/cop/style/flip_flop'
 require_relative 'rubocop/cop/style/for'
 require_relative 'rubocop/cop/style/format_string'
@@ -494,9 +509,12 @@ require_relative 'rubocop/cop/style/symbol_array'
 require_relative 'rubocop/cop/style/symbol_literal'
 require_relative 'rubocop/cop/style/symbol_proc'
 require_relative 'rubocop/cop/style/ternary_parentheses'
+require_relative 'rubocop/cop/style/trailing_body_on_class'
 require_relative 'rubocop/cop/style/trailing_body_on_method_definition'
+require_relative 'rubocop/cop/style/trailing_body_on_module'
 require_relative 'rubocop/cop/style/trailing_comma_in_arguments'
-require_relative 'rubocop/cop/style/trailing_comma_in_literal'
+require_relative 'rubocop/cop/style/trailing_comma_in_array_literal'
+require_relative 'rubocop/cop/style/trailing_comma_in_hash_literal'
 require_relative 'rubocop/cop/style/trailing_method_end_statement'
 require_relative 'rubocop/cop/style/trailing_underscore_variable'
 require_relative 'rubocop/cop/style/trivial_accessors'
@@ -513,6 +531,7 @@ require_relative 'rubocop/cop/style/yoda_condition'
 require_relative 'rubocop/cop/style/zero_length_predicate'
 
 require_relative 'rubocop/cop/rails/action_filter'
+require_relative 'rubocop/cop/rails/active_record_aliases'
 require_relative 'rubocop/cop/rails/active_support_aliases'
 require_relative 'rubocop/cop/rails/application_job'
 require_relative 'rubocop/cop/rails/application_record'
@@ -556,6 +575,7 @@ require_relative 'rubocop/cop/rails/validation'
 require_relative 'rubocop/cop/security/eval'
 require_relative 'rubocop/cop/security/json_load'
 require_relative 'rubocop/cop/security/marshal_load'
+require_relative 'rubocop/cop/security/open'
 require_relative 'rubocop/cop/security/yaml_load'
 
 require_relative 'rubocop/cop/team'

data/lib/rubocop/ast/builder.rb

@@ -2,41 +2,49 @@
 
 module RuboCop
   module AST
-    # `RuboCop::Builder` is an AST builder that is utilized to let `Parser`
+    # `RuboCop::AST::Builder` is an AST builder that is utilized to let `Parser`
     # generate ASTs with {RuboCop::AST::Node}.
     #
     # @example
     #   buffer = Parser::Source::Buffer.new('(string)')
     #   buffer.source = 'puts :foo'
     #
-    #   builder = RuboCop::Builder.new
-    #   parser = Parser::CurrentRuby.new(builder)
+    #   builder = RuboCop::AST::Builder.new
+    #   require 'parser/ruby25'
+    #   parser = Parser::Ruby25.new(builder)
     #   root_node = parser.parse(buffer)
     class Builder < Parser::Builders::Default
       NODE_MAP = {
-        AndNode          => [:and],
-        ArgsNode         => [:args],
-        ArrayNode        => [:array],
-        BlockNode        => [:block],
-        CaseNode         => [:case],
-        DefNode          => %i[def defs],
-        EnsureNode       => [:ensure],
-        ForNode          => [:for],
-        HashNode         => [:hash],
-        IfNode           => [:if],
-        KeywordSplatNode => [:kwsplat],
-        OrNode           => [:or],
-        PairNode         => [:pair],
-        RegexpNode       => [:regexp],
-        ResbodyNode      => [:resbody],
-        SendNode         => %i[csend send],
-        StrNode          => %i[str dstr xstr],
-        SuperNode        => %i[super zsuper],
-        SymbolNode       => [:sym],
-        UntilNode        => %i[until until_post],
-        WhenNode         => [:when],
-        WhileNode        => %i[while while_post],
-        YieldNode        => [:yield]
+        and:        AndNode,
+        args:       ArgsNode,
+        array:      ArrayNode,
+        block:      BlockNode,
+        case:       CaseNode,
+        def:        DefNode,
+        defs:       DefNode,
+        ensure:     EnsureNode,
+        for:        ForNode,
+        hash:       HashNode,
+        if:         IfNode,
+        kwsplat:    KeywordSplatNode,
+        or:         OrNode,
+        pair:       PairNode,
+        regexp:     RegexpNode,
+        resbody:    ResbodyNode,
+        csend:      SendNode,
+        send:       SendNode,
+        str:        StrNode,
+        dstr:       StrNode,
+        xstr:       StrNode,
+        super:      SuperNode,
+        zsuper:     SuperNode,
+        sym:        SymbolNode,
+        until:      UntilNode,
+        until_post: UntilNode,
+        when:       WhenNode,
+        while:      WhileNode,
+        while_post: WhileNode,
+        yield:      YieldNode
       }.freeze
 
       # Generates {Node} from the given information.
@@ -55,17 +63,7 @@ module RuboCop
       private
 
       def node_klass(type)
-        node_map[type] || Node
-      end
-
-      # Take the human readable constant and generate a hash map where each
-      # (mapped) node type is a key with its constant as the value.
-      def node_map
-        @node_map ||= begin
-          NODE_MAP.each_pair.each_with_object({}) do |(klass, types), map|
-            types.each { |type| map[type] = klass }
-          end
-        end
+        NODE_MAP[type] || Node
       end
     end
   end

data/lib/rubocop/ast/node.rb

@@ -100,7 +100,8 @@ module RuboCop
       # part of it is changed.
       def updated(type = nil, children = nil, properties = {})
         properties[:location] ||= @location
-        self.class.new(type || @type, children || @children, properties)
+        klass = RuboCop::AST::Builder::NODE_MAP[type || @type] || Node
+        klass.new(type || @type, children || @children, properties)
       end
 
       # Returns the index of the receiver node in its siblings. (Sibling index
@@ -111,6 +112,16 @@ module RuboCop
         parent.children.index { |sibling| sibling.equal?(self) }
       end
 
+      # Common destructuring method. This can be used to normalize
+      # destructuring for different variations of the node.
+      # Some node types override this with their own custom
+      # destructuring method.
+      #
+      # @return [Array<Node>] the different parts of the ndde
+      def node_parts
+        to_a
+      end
+
       # Calls the given block for each ancestor node from parent to root.
       # If no block is given, an `Enumerator` is returned.
       #
@@ -453,6 +464,10 @@ module RuboCop
           source_range.begin_pos != loc.selector.begin_pos
       end
 
+      def parenthesized_call?
+        loc.begin && loc.begin.is?('(')
+      end
+
       def chained?
         return false unless argument?
 

data/lib/rubocop/ast/node/and_node.rb

@@ -24,14 +24,6 @@ module RuboCop
       def inverse_operator
         logical_operator? ? LOGICAL_OR : SEMANTIC_OR
       end
-
-      # Custom destructuring method. This can be used to normalize
-      # destructuring for different variations of the node.
-      #
-      # @return [Array<Node>] the different parts of the `and` predicate
-      def node_parts
-        to_a
-      end
     end
   end
 end

data/lib/rubocop/ast/node/block_node.rb

@@ -9,7 +9,7 @@ module RuboCop
     # A `block` node is essentially a method send with a block. Parser nests
     # the `send` node inside the `block` node.
     class BlockNode < Node
-      VOID_CONTEXT_METHODS = %i[each].freeze
+      VOID_CONTEXT_METHODS = %i[each tap].freeze
 
       # The `send` node associated with this block.
       #
@@ -103,14 +103,6 @@ module RuboCop
       def void_context?
         VOID_CONTEXT_METHODS.include?(send_node.method_name)
       end
-
-      # Custom destructuring method. This can be used to normalize
-      # destructuring for different variations of the node.
-      #
-      # @return [Array] the different parts of the `block` node
-      def node_parts
-        to_a
-      end
     end
   end
 end

data/lib/rubocop/ast/node/case_node.rb

@@ -51,14 +51,6 @@ module RuboCop
       def else?
         loc.else
       end
-
-      # Custom destructuring method. This can be used to normalize
-      # destructuring for different variations of the node.
-      #
-      # @return [Array<Node>] the different parts of the `case` statement
-      def node_parts
-        to_a
-      end
     end
   end
 end

data/lib/rubocop/ast/node/ensure_node.rb

@@ -12,14 +12,6 @@ module RuboCop
       def body
         node_parts[1]
       end
-
-      # Custom destructuring method. This can be used to normalize
-      # destructuring for different variations of the node.
-      #
-      # @return [Array<Node>] the different parts of the `ensure` statement
-      def node_parts
-        to_a
-      end
     end
   end
 end

data/lib/rubocop/ast/node/for_node.rb

@@ -48,14 +48,6 @@ module RuboCop
       def body
         node_parts[2]
       end
-
-      # Custom destructuring method. This can be used to normalize
-      # destructuring for different variations of the node.
-      #
-      # @return [Array<Node>] the different parts of the `until` statement
-      def node_parts
-        to_a
-      end
     end
   end
 end

data/lib/rubocop/ast/node/or_node.rb

@@ -24,14 +24,6 @@ module RuboCop
       def inverse_operator
         logical_operator? ? LOGICAL_AND : SEMANTIC_AND
       end
-
-      # Custom destructuring method. This can be used to normalize
-      # destructuring for different variations of the node.
-      #
-      # @return [Array<Node>] the different parts of the `or` predicate
-      def node_parts
-        to_a
-      end
     end
   end
 end

data/lib/rubocop/ast/node/pair_node.rb

@@ -51,14 +51,6 @@ module RuboCop
           hash_rocket? ? COLON : HASH_ROCKET
         end
       end
-
-      # Custom destructuring method. This is used to normalize the branches
-      # for `pair` and `kwsplat` nodes, to add duck typing to `hash` elements.
-      #
-      # @return [Array<Node>] the different parts of the `pair`
-      def node_parts
-        to_a
-      end
     end
   end
 end

data/lib/rubocop/ast/node/resbody_node.rb

@@ -12,14 +12,6 @@ module RuboCop
       def body
         node_parts[2]
       end
-
-      # Custom destructuring method. This can be used to normalize
-      # destructuring for different variations of the node.
-      #
-      # @return [Array<Node>] the different parts of the `resbody` statement
-      def node_parts
-        to_a
-      end
     end
   end
 end

data/lib/rubocop/ast/node/send_node.rb

@@ -10,14 +10,6 @@ module RuboCop
       include MethodDispatchNode
       ARROW = '->'.freeze
 
-      # Custom destructuring method. This can be used to normalize
-      # destructuring for different variations of the node.
-      #
-      # @return [Array] the different parts of the `send` node
-      def node_parts
-        to_a
-      end
-
       # Checks whether this is a negation method, i.e. `!` or keyword `not`.
       #
       # @return [Boolean] whether this method is a negation method