rubocop 0.48.1 → 1.16.0
Sign up to get free protection for your applications and to get access to all the features.
- checksums.yaml +5 -5
- data/LICENSE.txt +1 -1
- data/README.md +84 -50
- data/assets/output.html.erb +1 -1
- data/config/default.yml +4311 -902
- data/config/obsoletion.yml +200 -0
- data/exe/rubocop +15 -0
- data/lib/rubocop.rb +679 -481
- data/lib/rubocop/ast_aliases.rb +8 -0
- data/lib/rubocop/cached_data.rb +5 -10
- data/lib/rubocop/cli.rb +73 -129
- data/lib/rubocop/cli/command.rb +22 -0
- data/lib/rubocop/cli/command/auto_genenerate_config.rb +132 -0
- data/lib/rubocop/cli/command/base.rb +35 -0
- data/lib/rubocop/cli/command/execute_runner.rb +100 -0
- data/lib/rubocop/cli/command/init_dotfile.rb +44 -0
- data/lib/rubocop/cli/command/show_cops.rb +74 -0
- data/lib/rubocop/cli/command/suggest_extensions.rb +81 -0
- data/lib/rubocop/cli/command/version.rb +18 -0
- data/lib/rubocop/cli/environment.rb +22 -0
- data/lib/rubocop/comment_config.rb +80 -78
- data/lib/rubocop/config.rb +124 -259
- data/lib/rubocop/config_loader.rb +182 -133
- data/lib/rubocop/config_loader_resolver.rb +237 -14
- data/lib/rubocop/config_obsoletion.rb +103 -0
- data/lib/rubocop/config_obsoletion/changed_enforced_styles.rb +33 -0
- data/lib/rubocop/config_obsoletion/changed_parameter.rb +21 -0
- data/lib/rubocop/config_obsoletion/cop_rule.rb +33 -0
- data/lib/rubocop/config_obsoletion/extracted_cop.rb +44 -0
- data/lib/rubocop/config_obsoletion/parameter_rule.rb +44 -0
- data/lib/rubocop/config_obsoletion/removed_cop.rb +41 -0
- data/lib/rubocop/config_obsoletion/renamed_cop.rb +34 -0
- data/lib/rubocop/config_obsoletion/rule.rb +41 -0
- data/lib/rubocop/config_obsoletion/split_cop.rb +27 -0
- data/lib/rubocop/config_regeneration.rb +33 -0
- data/lib/rubocop/config_store.rb +31 -7
- data/lib/rubocop/config_validator.rb +234 -0
- data/lib/rubocop/cop/autocorrect_logic.rb +83 -4
- data/lib/rubocop/cop/badge.rb +16 -32
- data/lib/rubocop/cop/base.rb +450 -0
- data/lib/rubocop/cop/bundler/duplicated_gem.rb +44 -16
- data/lib/rubocop/cop/bundler/gem_comment.rb +171 -0
- data/lib/rubocop/cop/bundler/gem_version.rb +99 -0
- data/lib/rubocop/cop/bundler/insecure_protocol_source.rb +62 -0
- data/lib/rubocop/cop/bundler/ordered_gems.rb +18 -60
- data/lib/rubocop/cop/commissioner.rb +119 -68
- data/lib/rubocop/cop/cop.rb +93 -169
- data/lib/rubocop/cop/corrector.rb +81 -98
- data/lib/rubocop/cop/correctors/alignment_corrector.rb +136 -0
- data/lib/rubocop/cop/correctors/condition_corrector.rb +25 -0
- data/lib/rubocop/cop/correctors/each_to_for_corrector.rb +51 -0
- data/lib/rubocop/cop/correctors/empty_line_corrector.rb +25 -0
- data/lib/rubocop/cop/correctors/for_to_each_corrector.rb +72 -0
- data/lib/rubocop/cop/correctors/lambda_literal_to_method_corrector.rb +136 -0
- data/lib/rubocop/cop/correctors/line_break_corrector.rb +58 -0
- data/lib/rubocop/cop/correctors/multiline_literal_brace_corrector.rb +97 -0
- data/lib/rubocop/cop/correctors/ordered_gem_corrector.rb +42 -0
- data/lib/rubocop/cop/correctors/parentheses_corrector.rb +28 -0
- data/lib/rubocop/cop/correctors/percent_literal_corrector.rb +106 -0
- data/lib/rubocop/cop/correctors/punctuation_corrector.rb +27 -0
- data/lib/rubocop/cop/correctors/space_corrector.rb +46 -0
- data/lib/rubocop/cop/correctors/string_literal_corrector.rb +23 -0
- data/lib/rubocop/cop/correctors/unused_arg_corrector.rb +40 -0
- data/lib/rubocop/cop/documentation.rb +22 -0
- data/lib/rubocop/cop/exclude_limit.rb +26 -0
- data/lib/rubocop/cop/force.rb +3 -1
- data/lib/rubocop/cop/gemspec/date_assignment.rb +57 -0
- data/lib/rubocop/cop/gemspec/duplicated_assignment.rb +105 -0
- data/lib/rubocop/cop/gemspec/ordered_dependencies.rb +102 -0
- data/lib/rubocop/cop/gemspec/required_ruby_version.rb +113 -0
- data/lib/rubocop/cop/gemspec/ruby_version_globals_usage.rb +57 -0
- data/lib/rubocop/cop/generator.rb +212 -0
- data/lib/rubocop/cop/generator/configuration_injector.rb +65 -0
- data/lib/rubocop/cop/generator/require_file_injector.rb +75 -0
- data/lib/rubocop/cop/ignored_node.rb +1 -3
- data/lib/rubocop/cop/internal_affairs.rb +15 -0
- data/lib/rubocop/cop/internal_affairs/empty_line_between_expect_offense_and_correction.rb +68 -0
- data/lib/rubocop/cop/internal_affairs/example_description.rb +92 -0
- data/lib/rubocop/cop/internal_affairs/method_name_equal.rb +50 -0
- data/lib/rubocop/cop/internal_affairs/node_destructuring.rb +44 -0
- data/lib/rubocop/cop/internal_affairs/node_matcher_directive.rb +151 -0
- data/lib/rubocop/cop/internal_affairs/node_type_predicate.rb +41 -0
- data/lib/rubocop/cop/internal_affairs/offense_location_keyword.rb +56 -0
- data/lib/rubocop/cop/internal_affairs/redundant_described_class_as_subject.rb +62 -0
- data/lib/rubocop/cop/internal_affairs/redundant_let_rubocop_config_new.rb +65 -0
- data/lib/rubocop/cop/internal_affairs/redundant_location_argument.rb +53 -0
- data/lib/rubocop/cop/internal_affairs/redundant_message_argument.rb +76 -0
- data/lib/rubocop/cop/internal_affairs/style_detected_api_use.rb +148 -0
- data/lib/rubocop/cop/internal_affairs/useless_message_assertion.rb +52 -0
- data/lib/rubocop/cop/layout/access_modifier_indentation.rb +100 -0
- data/lib/rubocop/cop/layout/argument_alignment.rb +110 -0
- data/lib/rubocop/cop/layout/array_alignment.rb +84 -0
- data/lib/rubocop/cop/{style/indent_assignment.rb → layout/assignment_indentation.rb} +21 -7
- data/lib/rubocop/cop/layout/begin_end_alignment.rb +74 -0
- data/lib/rubocop/cop/{lint → layout}/block_alignment.rb +67 -60
- data/lib/rubocop/cop/layout/block_end_newline.rb +60 -0
- data/lib/rubocop/cop/layout/case_indentation.rb +203 -0
- data/lib/rubocop/cop/layout/class_structure.rb +324 -0
- data/lib/rubocop/cop/layout/closing_heredoc_indentation.rb +124 -0
- data/lib/rubocop/cop/layout/closing_parenthesis_indentation.rb +191 -0
- data/lib/rubocop/cop/layout/comment_indentation.rb +137 -0
- data/lib/rubocop/cop/{lint → layout}/condition_position.rb +20 -8
- data/lib/rubocop/cop/{lint → layout}/def_end_alignment.rb +19 -24
- data/lib/rubocop/cop/{style → layout}/dot_position.rb +47 -27
- data/lib/rubocop/cop/layout/else_alignment.rb +156 -0
- data/lib/rubocop/cop/layout/empty_comment.rb +151 -0
- data/lib/rubocop/cop/layout/empty_line_after_guard_clause.rb +174 -0
- data/lib/rubocop/cop/{style → layout}/empty_line_after_magic_comment.rb +18 -17
- data/lib/rubocop/cop/layout/empty_line_after_multiline_condition.rb +136 -0
- data/lib/rubocop/cop/layout/empty_line_between_defs.rb +252 -0
- data/lib/rubocop/cop/{style → layout}/empty_lines.rb +26 -15
- data/lib/rubocop/cop/layout/empty_lines_around_access_modifier.rb +206 -0
- data/lib/rubocop/cop/layout/empty_lines_around_arguments.rb +103 -0
- data/lib/rubocop/cop/layout/empty_lines_around_attribute_accessor.rb +118 -0
- data/lib/rubocop/cop/{style → layout}/empty_lines_around_begin_body.rb +7 -7
- data/lib/rubocop/cop/layout/empty_lines_around_block_body.rb +38 -0
- data/lib/rubocop/cop/layout/empty_lines_around_class_body.rb +85 -0
- data/lib/rubocop/cop/{style → layout}/empty_lines_around_exception_handling_keywords.rb +16 -17
- data/lib/rubocop/cop/{style → layout}/empty_lines_around_method_body.rb +10 -9
- data/lib/rubocop/cop/layout/empty_lines_around_module_body.rb +59 -0
- data/lib/rubocop/cop/{lint → layout}/end_alignment.rb +59 -33
- data/lib/rubocop/cop/layout/end_of_line.rb +92 -0
- data/lib/rubocop/cop/layout/extra_spacing.rb +182 -0
- data/lib/rubocop/cop/layout/first_argument_indentation.rb +276 -0
- data/lib/rubocop/cop/layout/first_array_element_indentation.rb +173 -0
- data/lib/rubocop/cop/{style → layout}/first_array_element_line_break.rb +5 -5
- data/lib/rubocop/cop/layout/first_hash_element_indentation.rb +200 -0
- data/lib/rubocop/cop/{style → layout}/first_hash_element_line_break.rb +4 -4
- data/lib/rubocop/cop/{style → layout}/first_method_argument_line_break.rb +9 -10
- data/lib/rubocop/cop/{style → layout}/first_method_parameter_line_break.rb +7 -7
- data/lib/rubocop/cop/layout/first_parameter_indentation.rb +101 -0
- data/lib/rubocop/cop/layout/hash_alignment.rb +382 -0
- data/lib/rubocop/cop/layout/heredoc_argument_closing_parenthesis.rb +305 -0
- data/lib/rubocop/cop/layout/heredoc_indentation.rb +172 -0
- data/lib/rubocop/cop/layout/indentation_consistency.rb +205 -0
- data/lib/rubocop/cop/layout/indentation_style.rb +110 -0
- data/lib/rubocop/cop/{style → layout}/indentation_width.rb +138 -66
- data/lib/rubocop/cop/layout/initial_indentation.rb +55 -0
- data/lib/rubocop/cop/layout/leading_comment_space.rb +121 -0
- data/lib/rubocop/cop/layout/leading_empty_lines.rb +48 -0
- data/lib/rubocop/cop/layout/line_length.rb +267 -0
- data/lib/rubocop/cop/layout/multiline_array_brace_layout.rb +115 -0
- data/lib/rubocop/cop/layout/multiline_array_line_breaks.rb +35 -0
- data/lib/rubocop/cop/layout/multiline_assignment_layout.rb +117 -0
- data/lib/rubocop/cop/layout/multiline_block_layout.rb +159 -0
- data/lib/rubocop/cop/{style → layout}/multiline_hash_brace_layout.rb +53 -19
- data/lib/rubocop/cop/layout/multiline_hash_key_line_breaks.rb +46 -0
- data/lib/rubocop/cop/layout/multiline_method_argument_line_breaks.rb +47 -0
- data/lib/rubocop/cop/{style → layout}/multiline_method_call_brace_layout.rb +69 -35
- data/lib/rubocop/cop/{style → layout}/multiline_method_call_indentation.rb +57 -41
- data/lib/rubocop/cop/{style → layout}/multiline_method_definition_brace_layout.rb +84 -38
- data/lib/rubocop/cop/{style → layout}/multiline_operation_indentation.rb +51 -11
- data/lib/rubocop/cop/layout/parameter_alignment.rb +119 -0
- data/lib/rubocop/cop/layout/redundant_line_break.rb +137 -0
- data/lib/rubocop/cop/layout/rescue_ensure_alignment.rb +198 -0
- data/lib/rubocop/cop/layout/single_line_block_chain.rb +53 -0
- data/lib/rubocop/cop/{style → layout}/space_after_colon.rb +19 -10
- data/lib/rubocop/cop/layout/space_after_comma.rb +32 -0
- data/lib/rubocop/cop/layout/space_after_method_name.rb +39 -0
- data/lib/rubocop/cop/{style → layout}/space_after_not.rb +14 -14
- data/lib/rubocop/cop/{style → layout}/space_after_semicolon.rb +12 -4
- data/lib/rubocop/cop/layout/space_around_block_parameters.rb +162 -0
- data/lib/rubocop/cop/layout/space_around_equals_in_parameter_default.rb +88 -0
- data/lib/rubocop/cop/{style → layout}/space_around_keyword.rb +69 -37
- data/lib/rubocop/cop/layout/space_around_method_call_operator.rb +98 -0
- data/lib/rubocop/cop/layout/space_around_operators.rb +241 -0
- data/lib/rubocop/cop/layout/space_before_block_braces.rb +152 -0
- data/lib/rubocop/cop/layout/space_before_brackets.rb +65 -0
- data/lib/rubocop/cop/layout/space_before_comma.rb +29 -0
- data/lib/rubocop/cop/layout/space_before_comment.rb +34 -0
- data/lib/rubocop/cop/{style → layout}/space_before_first_arg.rb +24 -17
- data/lib/rubocop/cop/layout/space_before_semicolon.rb +24 -0
- data/lib/rubocop/cop/layout/space_in_lambda_literal.rb +72 -0
- data/lib/rubocop/cop/layout/space_inside_array_literal_brackets.rb +222 -0
- data/lib/rubocop/cop/{style → layout}/space_inside_array_percent_literal.rb +10 -20
- data/lib/rubocop/cop/layout/space_inside_block_braces.rb +243 -0
- data/lib/rubocop/cop/layout/space_inside_hash_literal_braces.rb +181 -0
- data/lib/rubocop/cop/layout/space_inside_parens.rb +130 -0
- data/lib/rubocop/cop/{style → layout}/space_inside_percent_literal_delimiters.rb +16 -20
- data/lib/rubocop/cop/{style → layout}/space_inside_range_literal.rb +8 -17
- data/lib/rubocop/cop/layout/space_inside_reference_brackets.rb +139 -0
- data/lib/rubocop/cop/layout/space_inside_string_interpolation.rb +64 -0
- data/lib/rubocop/cop/layout/trailing_empty_lines.rb +108 -0
- data/lib/rubocop/cop/layout/trailing_whitespace.rb +101 -0
- data/lib/rubocop/cop/legacy/corrections_proxy.rb +43 -0
- data/lib/rubocop/cop/legacy/corrector.rb +27 -0
- data/lib/rubocop/cop/lint/ambiguous_assignment.rb +54 -0
- data/lib/rubocop/cop/lint/ambiguous_block_association.rb +30 -22
- data/lib/rubocop/cop/lint/ambiguous_operator.rb +57 -9
- data/lib/rubocop/cop/lint/ambiguous_regexp_literal.rb +37 -7
- data/lib/rubocop/cop/lint/assignment_in_condition.rb +40 -23
- data/lib/rubocop/cop/lint/big_decimal_new.rb +44 -0
- data/lib/rubocop/cop/lint/binary_operator_with_identical_operands.rb +55 -0
- data/lib/rubocop/cop/lint/boolean_symbol.rb +58 -0
- data/lib/rubocop/cop/lint/circular_argument_reference.rb +5 -16
- data/lib/rubocop/cop/lint/constant_definition_in_block.rb +100 -0
- data/lib/rubocop/cop/lint/constant_resolution.rb +89 -0
- data/lib/rubocop/cop/lint/debugger.rb +63 -33
- data/lib/rubocop/cop/lint/deprecated_class_methods.rb +101 -41
- data/lib/rubocop/cop/lint/deprecated_constants.rb +80 -0
- data/lib/rubocop/cop/lint/deprecated_open_ssl_constant.rb +148 -0
- data/lib/rubocop/cop/lint/disjunctive_assignment_in_constructor.rb +87 -0
- data/lib/rubocop/cop/lint/duplicate_branch.rb +154 -0
- data/lib/rubocop/cop/lint/duplicate_case_condition.rb +4 -14
- data/lib/rubocop/cop/lint/duplicate_elsif_condition.rb +39 -0
- data/lib/rubocop/cop/lint/{duplicated_key.rb → duplicate_hash_key.rb} +3 -5
- data/lib/rubocop/cop/lint/duplicate_methods.rb +108 -24
- data/lib/rubocop/cop/lint/duplicate_regexp_character_class_element.rb +77 -0
- data/lib/rubocop/cop/lint/duplicate_require.rb +47 -0
- data/lib/rubocop/cop/lint/duplicate_rescue_exception.rb +47 -0
- data/lib/rubocop/cop/lint/each_with_object_argument.rb +9 -4
- data/lib/rubocop/cop/lint/else_layout.rb +33 -8
- data/lib/rubocop/cop/lint/empty_block.rb +98 -0
- data/lib/rubocop/cop/lint/empty_class.rb +93 -0
- data/lib/rubocop/cop/lint/empty_conditional_body.rb +67 -0
- data/lib/rubocop/cop/lint/empty_ensure.rb +6 -8
- data/lib/rubocop/cop/lint/empty_expression.rb +3 -3
- data/lib/rubocop/cop/lint/empty_file.rb +48 -0
- data/lib/rubocop/cop/lint/empty_in_pattern.rb +62 -0
- data/lib/rubocop/cop/lint/empty_interpolation.rb +8 -11
- data/lib/rubocop/cop/lint/empty_when.rb +32 -9
- data/lib/rubocop/cop/lint/ensure_return.rb +31 -15
- data/lib/rubocop/cop/lint/erb_new_arguments.rb +162 -0
- data/lib/rubocop/cop/lint/flip_flop.rb +38 -0
- data/lib/rubocop/cop/lint/float_comparison.rb +93 -0
- data/lib/rubocop/cop/lint/float_out_of_range.rb +6 -7
- data/lib/rubocop/cop/lint/format_parameter_mismatch.rb +93 -81
- data/lib/rubocop/cop/lint/hash_compare_by_identity.rb +38 -0
- data/lib/rubocop/cop/lint/heredoc_method_call_position.rb +154 -0
- data/lib/rubocop/cop/lint/identity_comparison.rb +51 -0
- data/lib/rubocop/cop/lint/implicit_string_concatenation.rb +27 -21
- data/lib/rubocop/cop/lint/ineffective_access_modifier.rb +44 -66
- data/lib/rubocop/cop/lint/inherit_exception.rb +43 -21
- data/lib/rubocop/cop/lint/interpolation_check.rb +53 -0
- data/lib/rubocop/cop/lint/lambda_without_literal_block.rb +44 -0
- data/lib/rubocop/cop/lint/{literal_in_condition.rb → literal_as_condition.rb} +48 -28
- data/lib/rubocop/cop/lint/literal_in_interpolation.rb +71 -20
- data/lib/rubocop/cop/lint/loop.rb +31 -9
- data/lib/rubocop/cop/lint/missing_cop_enable_directive.rb +81 -0
- data/lib/rubocop/cop/lint/missing_super.rb +101 -0
- data/lib/rubocop/cop/lint/mixed_regexp_capture_types.rb +36 -0
- data/lib/rubocop/cop/lint/multiple_comparison.rb +48 -0
- data/lib/rubocop/cop/lint/nested_method_definition.rb +23 -28
- data/lib/rubocop/cop/lint/nested_percent_literal.rb +63 -0
- data/lib/rubocop/cop/lint/next_without_accumulator.rb +5 -4
- data/lib/rubocop/cop/lint/no_return_in_begin_end_blocks.rb +58 -0
- data/lib/rubocop/cop/lint/non_deterministic_require_order.rb +169 -0
- data/lib/rubocop/cop/lint/non_local_exit_from_iterator.rb +20 -19
- data/lib/rubocop/cop/lint/number_conversion.rb +155 -0
- data/lib/rubocop/cop/lint/numbered_parameter_assignment.rb +47 -0
- data/lib/rubocop/cop/lint/or_assignment_to_constant.rb +39 -0
- data/lib/rubocop/cop/lint/ordered_magic_comments.rb +83 -0
- data/lib/rubocop/cop/lint/out_of_range_regexp_ref.rb +96 -0
- data/lib/rubocop/cop/lint/parentheses_as_grouped_expression.rb +40 -17
- data/lib/rubocop/cop/lint/percent_string_array.rb +18 -34
- data/lib/rubocop/cop/lint/percent_symbol_array.rb +19 -17
- data/lib/rubocop/cop/lint/raise_exception.rb +87 -0
- data/lib/rubocop/cop/lint/rand_one.rb +13 -6
- data/lib/rubocop/cop/lint/redundant_cop_disable_directive.rb +262 -0
- data/lib/rubocop/cop/lint/redundant_cop_enable_directive.rb +128 -0
- data/lib/rubocop/cop/lint/redundant_dir_glob_sort.rb +50 -0
- data/lib/rubocop/cop/lint/redundant_require_statement.rb +49 -0
- data/lib/rubocop/cop/lint/redundant_safe_navigation.rb +77 -0
- data/lib/rubocop/cop/lint/redundant_splat_expansion.rb +209 -0
- data/lib/rubocop/cop/lint/redundant_string_coercion.rb +52 -0
- data/lib/rubocop/cop/lint/redundant_with_index.rb +77 -0
- data/lib/rubocop/cop/lint/redundant_with_object.rb +78 -0
- data/lib/rubocop/cop/lint/regexp_as_condition.rb +31 -0
- data/lib/rubocop/cop/lint/require_parentheses.rb +11 -8
- data/lib/rubocop/cop/lint/rescue_exception.rb +5 -5
- data/lib/rubocop/cop/lint/rescue_type.rb +88 -0
- data/lib/rubocop/cop/lint/return_in_void_context.rb +71 -0
- data/lib/rubocop/cop/lint/safe_navigation_chain.rb +22 -30
- data/lib/rubocop/cop/lint/safe_navigation_consistency.rb +92 -0
- data/lib/rubocop/cop/lint/safe_navigation_with_empty.rb +46 -0
- data/lib/rubocop/cop/lint/script_permission.rb +73 -0
- data/lib/rubocop/cop/lint/self_assignment.rb +78 -0
- data/lib/rubocop/cop/lint/send_with_mixin_argument.rb +83 -0
- data/lib/rubocop/cop/lint/shadowed_argument.rb +176 -0
- data/lib/rubocop/cop/lint/shadowed_exception.rb +77 -43
- data/lib/rubocop/cop/lint/shadowing_outer_local_variable.rb +24 -10
- data/lib/rubocop/cop/lint/struct_new_override.rb +59 -0
- data/lib/rubocop/cop/lint/suppressed_exception.rb +132 -0
- data/lib/rubocop/cop/lint/symbol_conversion.rb +178 -0
- data/lib/rubocop/cop/lint/syntax.rb +17 -32
- data/lib/rubocop/cop/lint/to_enum_arguments.rb +89 -0
- data/lib/rubocop/cop/lint/to_json.rb +49 -0
- data/lib/rubocop/cop/lint/top_level_return_with_argument.rb +34 -0
- data/lib/rubocop/cop/lint/trailing_comma_in_attribute_declaration.rb +55 -0
- data/lib/rubocop/cop/lint/triple_quotes.rb +71 -0
- data/lib/rubocop/cop/lint/underscore_prefixed_variable_name.rb +31 -13
- data/lib/rubocop/cop/lint/unexpected_block_arity.rb +85 -0
- data/lib/rubocop/cop/lint/unified_integer.rb +10 -10
- data/lib/rubocop/cop/lint/unmodified_reduce_accumulator.rb +204 -0
- data/lib/rubocop/cop/lint/unreachable_code.rb +57 -12
- data/lib/rubocop/cop/lint/unreachable_loop.rb +196 -0
- data/lib/rubocop/cop/lint/unused_block_argument.rb +41 -14
- data/lib/rubocop/cop/lint/unused_method_argument.rb +70 -14
- data/lib/rubocop/cop/lint/uri_escape_unescape.rb +79 -0
- data/lib/rubocop/cop/lint/uri_regexp.rb +38 -0
- data/lib/rubocop/cop/lint/useless_access_modifier.rb +120 -59
- data/lib/rubocop/cop/lint/useless_assignment.rb +13 -20
- data/lib/rubocop/cop/lint/useless_else_without_rescue.rb +10 -11
- data/lib/rubocop/cop/lint/useless_method_definition.rb +68 -0
- data/lib/rubocop/cop/lint/useless_setter_call.rb +30 -22
- data/lib/rubocop/cop/lint/useless_times.rb +109 -0
- data/lib/rubocop/cop/lint/void.rb +82 -50
- data/lib/rubocop/cop/message_annotator.rb +48 -24
- data/lib/rubocop/cop/metrics/abc_size.rb +29 -20
- data/lib/rubocop/cop/metrics/block_length.rb +54 -6
- data/lib/rubocop/cop/metrics/block_nesting.rb +7 -11
- data/lib/rubocop/cop/metrics/class_length.rb +44 -3
- data/lib/rubocop/cop/metrics/cyclomatic_complexity.rb +38 -5
- data/lib/rubocop/cop/metrics/method_length.rb +43 -6
- data/lib/rubocop/cop/metrics/module_length.rb +35 -3
- data/lib/rubocop/cop/metrics/parameter_lists.rb +80 -8
- data/lib/rubocop/cop/metrics/perceived_complexity.rb +8 -10
- data/lib/rubocop/cop/metrics/utils/abc_size_calculator.rb +145 -0
- data/lib/rubocop/cop/metrics/utils/code_length_calculator.rb +160 -0
- data/lib/rubocop/cop/metrics/utils/iterating_block.rb +61 -0
- data/lib/rubocop/cop/metrics/utils/repeated_attribute_discount.rb +143 -0
- data/lib/rubocop/cop/metrics/utils/repeated_csend_discount.rb +42 -0
- data/lib/rubocop/cop/migration/department_name.rb +79 -0
- data/lib/rubocop/cop/mixin/alignment.rb +81 -0
- data/lib/rubocop/cop/mixin/allowed_identifiers.rb +18 -0
- data/lib/rubocop/cop/mixin/allowed_methods.rb +21 -0
- data/lib/rubocop/cop/mixin/annotation_comment.rb +6 -0
- data/lib/rubocop/cop/mixin/array_min_size.rb +57 -0
- data/lib/rubocop/cop/mixin/array_syntax.rb +3 -1
- data/lib/rubocop/cop/mixin/auto_corrector.rb +12 -0
- data/lib/rubocop/cop/mixin/check_assignment.rb +13 -9
- data/lib/rubocop/cop/mixin/check_line_breakable.rb +214 -0
- data/lib/rubocop/cop/mixin/code_length.rb +33 -6
- data/lib/rubocop/cop/mixin/comments_help.rb +42 -0
- data/lib/rubocop/cop/mixin/configurable_enforced_style.rb +20 -18
- data/lib/rubocop/cop/mixin/configurable_formatting.rb +5 -13
- data/lib/rubocop/cop/mixin/configurable_max.rb +7 -2
- data/lib/rubocop/cop/mixin/configurable_naming.rb +2 -2
- data/lib/rubocop/cop/mixin/configurable_numbering.rb +4 -3
- data/lib/rubocop/cop/mixin/def_node.rb +12 -8
- data/lib/rubocop/cop/mixin/documentation_comment.rb +13 -10
- data/lib/rubocop/cop/mixin/empty_lines_around_body.rb +45 -34
- data/lib/rubocop/cop/mixin/empty_parameter.rb +25 -0
- data/lib/rubocop/cop/mixin/end_keyword_alignment.rb +29 -33
- data/lib/rubocop/cop/mixin/enforce_superclass.rb +38 -0
- data/lib/rubocop/cop/mixin/first_element_line_break.rb +17 -12
- data/lib/rubocop/cop/mixin/frozen_string_literal.rb +35 -10
- data/lib/rubocop/cop/mixin/gem_declaration.rb +13 -0
- data/lib/rubocop/cop/mixin/{hash_alignment.rb → hash_alignment_styles.rb} +55 -16
- data/lib/rubocop/cop/mixin/hash_transform_method.rb +183 -0
- data/lib/rubocop/cop/mixin/heredoc.rb +32 -0
- data/lib/rubocop/cop/mixin/ignored_methods.rb +52 -0
- data/lib/rubocop/cop/mixin/ignored_pattern.rb +3 -1
- data/lib/rubocop/cop/mixin/integer_node.rb +3 -1
- data/lib/rubocop/cop/mixin/interpolation.rb +25 -0
- data/lib/rubocop/cop/mixin/line_length_help.rb +90 -0
- data/lib/rubocop/cop/mixin/match_range.rb +6 -5
- data/lib/rubocop/cop/mixin/method_complexity.rb +58 -11
- data/lib/rubocop/cop/mixin/method_preference.rb +1 -1
- data/lib/rubocop/cop/mixin/min_body_length.rb +3 -1
- data/lib/rubocop/cop/mixin/{array_hash_indentation.rb → multiline_element_indentation.rb} +11 -6
- data/lib/rubocop/cop/mixin/multiline_element_line_breaks.rb +33 -0
- data/lib/rubocop/cop/mixin/multiline_expression_indentation.rb +108 -61
- data/lib/rubocop/cop/mixin/multiline_literal_brace_layout.rb +31 -42
- data/lib/rubocop/cop/mixin/negative_conditional.rb +9 -18
- data/lib/rubocop/cop/mixin/nil_methods.rb +23 -0
- data/lib/rubocop/cop/mixin/ordered_gem_node.rb +58 -0
- data/lib/rubocop/cop/mixin/parentheses.rb +3 -9
- data/lib/rubocop/cop/mixin/percent_array.rb +57 -0
- data/lib/rubocop/cop/mixin/percent_literal.rb +3 -71
- data/lib/rubocop/cop/mixin/preceding_following_alignment.rb +95 -9
- data/lib/rubocop/cop/mixin/preferred_delimiters.rb +50 -0
- data/lib/rubocop/cop/mixin/range_help.rb +128 -0
- data/lib/rubocop/cop/mixin/rational_literal.rb +19 -0
- data/lib/rubocop/cop/mixin/rescue_node.rb +15 -8
- data/lib/rubocop/cop/mixin/safe_assignment.rb +9 -2
- data/lib/rubocop/cop/mixin/space_after_punctuation.rb +15 -16
- data/lib/rubocop/cop/mixin/space_before_punctuation.rb +19 -18
- data/lib/rubocop/cop/mixin/statement_modifier.rb +50 -25
- data/lib/rubocop/cop/mixin/string_help.rb +6 -1
- data/lib/rubocop/cop/mixin/string_literals_help.rb +5 -17
- data/lib/rubocop/cop/mixin/surrounding_space.rb +113 -23
- data/lib/rubocop/cop/mixin/symbol_help.rb +13 -0
- data/lib/rubocop/cop/mixin/target_ruby_version.rb +5 -1
- data/lib/rubocop/cop/mixin/trailing_body.rb +25 -0
- data/lib/rubocop/cop/mixin/trailing_comma.rb +100 -52
- data/lib/rubocop/cop/mixin/uncommunicative_name.rb +104 -0
- data/lib/rubocop/cop/mixin/unused_argument.rb +6 -19
- data/lib/rubocop/cop/mixin/visibility_help.rb +37 -0
- data/lib/rubocop/cop/naming/accessor_method_name.rb +71 -0
- data/lib/rubocop/cop/naming/ascii_identifiers.rb +93 -0
- data/lib/rubocop/cop/naming/binary_operator_parameter_name.rb +53 -0
- data/lib/rubocop/cop/naming/block_parameter_name.rb +49 -0
- data/lib/rubocop/cop/naming/class_and_module_camel_case.rb +43 -0
- data/lib/rubocop/cop/naming/constant_name.rb +84 -0
- data/lib/rubocop/cop/{style → naming}/file_name.rb +79 -48
- data/lib/rubocop/cop/naming/heredoc_delimiter_case.rb +68 -0
- data/lib/rubocop/cop/naming/heredoc_delimiter_naming.rb +55 -0
- data/lib/rubocop/cop/naming/memoized_instance_variable_name.rb +279 -0
- data/lib/rubocop/cop/naming/method_name.rb +81 -0
- data/lib/rubocop/cop/naming/method_parameter_name.rb +58 -0
- data/lib/rubocop/cop/naming/predicate_name.rb +105 -0
- data/lib/rubocop/cop/naming/rescued_exceptions_variable_name.rb +156 -0
- data/lib/rubocop/cop/naming/variable_name.rb +54 -0
- data/lib/rubocop/cop/naming/variable_number.rb +146 -0
- data/lib/rubocop/cop/offense.rb +74 -23
- data/lib/rubocop/cop/registry.rb +140 -23
- data/lib/rubocop/cop/security/eval.rb +14 -5
- data/lib/rubocop/cop/security/json_load.rb +14 -12
- data/lib/rubocop/cop/security/marshal_load.rb +9 -7
- data/lib/rubocop/cop/security/open.rb +75 -0
- data/lib/rubocop/cop/security/yaml_load.rb +12 -10
- data/lib/rubocop/cop/severity.rb +5 -14
- data/lib/rubocop/cop/style/access_modifier_declarations.rb +136 -0
- data/lib/rubocop/cop/style/accessor_grouping.rb +150 -0
- data/lib/rubocop/cop/style/alias.rb +86 -57
- data/lib/rubocop/cop/style/and_or.rb +81 -53
- data/lib/rubocop/cop/style/arguments_forwarding.rb +143 -0
- data/lib/rubocop/cop/style/array_coercion.rb +69 -0
- data/lib/rubocop/cop/style/array_join.rb +19 -10
- data/lib/rubocop/cop/style/ascii_comments.rb +31 -9
- data/lib/rubocop/cop/style/attr.rb +33 -13
- data/lib/rubocop/cop/style/auto_resource_cleanup.rb +19 -13
- data/lib/rubocop/cop/style/bare_percent_literals.rb +31 -12
- data/lib/rubocop/cop/style/begin_block.rb +9 -3
- data/lib/rubocop/cop/style/bisected_attr_accessor.rb +125 -0
- data/lib/rubocop/cop/style/bisected_attr_accessor/macro.rb +60 -0
- data/lib/rubocop/cop/style/block_comments.rb +40 -20
- data/lib/rubocop/cop/style/block_delimiters.rb +213 -59
- data/lib/rubocop/cop/style/case_equality.rb +67 -4
- data/lib/rubocop/cop/style/case_like_if.rb +258 -0
- data/lib/rubocop/cop/style/character_literal.rb +22 -15
- data/lib/rubocop/cop/style/class_and_module_children.rb +118 -17
- data/lib/rubocop/cop/style/class_check.rb +31 -17
- data/lib/rubocop/cop/style/class_equality_comparison.rb +67 -0
- data/lib/rubocop/cop/style/class_methods.rb +18 -31
- data/lib/rubocop/cop/style/class_methods_definitions.rb +157 -0
- data/lib/rubocop/cop/style/class_vars.rb +48 -7
- data/lib/rubocop/cop/style/collection_compact.rb +91 -0
- data/lib/rubocop/cop/style/collection_methods.rb +52 -17
- data/lib/rubocop/cop/style/colon_method_call.rb +26 -13
- data/lib/rubocop/cop/style/colon_method_definition.rb +37 -0
- data/lib/rubocop/cop/style/combinable_loops.rb +92 -0
- data/lib/rubocop/cop/style/command_literal.rb +104 -42
- data/lib/rubocop/cop/style/comment_annotation.rb +62 -24
- data/lib/rubocop/cop/style/commented_keyword.rb +86 -0
- data/lib/rubocop/cop/style/conditional_assignment.rb +143 -182
- data/lib/rubocop/cop/style/constant_visibility.rb +106 -0
- data/lib/rubocop/cop/style/copyright.rb +42 -35
- data/lib/rubocop/cop/style/date_time.rb +88 -0
- data/lib/rubocop/cop/style/def_with_parentheses.rb +36 -13
- data/lib/rubocop/cop/style/dir.rb +47 -0
- data/lib/rubocop/cop/style/disable_cops_within_source_code_directive.rb +87 -0
- data/lib/rubocop/cop/style/document_dynamic_eval_definition.rb +169 -0
- data/lib/rubocop/cop/style/documentation.rb +114 -22
- data/lib/rubocop/cop/style/documentation_method.rb +56 -10
- data/lib/rubocop/cop/style/double_cop_disable_directive.rb +52 -0
- data/lib/rubocop/cop/style/double_negation.rb +52 -8
- data/lib/rubocop/cop/style/each_for_simple_loop.rb +16 -18
- data/lib/rubocop/cop/style/each_with_object.rb +34 -17
- data/lib/rubocop/cop/style/empty_block_parameter.rb +47 -0
- data/lib/rubocop/cop/style/empty_case_condition.rb +32 -13
- data/lib/rubocop/cop/style/empty_else.rb +56 -27
- data/lib/rubocop/cop/style/empty_lambda_parameter.rb +44 -0
- data/lib/rubocop/cop/style/empty_literal.rb +63 -33
- data/lib/rubocop/cop/style/empty_method.rb +37 -35
- data/lib/rubocop/cop/style/encoding.rb +20 -60
- data/lib/rubocop/cop/style/end_block.rb +15 -4
- data/lib/rubocop/cop/style/endless_method.rb +101 -0
- data/lib/rubocop/cop/style/eval_with_location.rb +237 -0
- data/lib/rubocop/cop/style/even_odd.rb +16 -16
- data/lib/rubocop/cop/style/expand_path_arguments.rb +196 -0
- data/lib/rubocop/cop/style/explicit_block_argument.rb +114 -0
- data/lib/rubocop/cop/style/exponential_notation.rb +116 -0
- data/lib/rubocop/cop/style/float_division.rb +143 -0
- data/lib/rubocop/cop/style/for.rb +49 -17
- data/lib/rubocop/cop/style/format_string.rb +97 -10
- data/lib/rubocop/cop/style/format_string_token.rb +177 -0
- data/lib/rubocop/cop/style/frozen_string_literal_comment.rb +155 -47
- data/lib/rubocop/cop/style/global_std_stream.rb +66 -0
- data/lib/rubocop/cop/style/global_vars.rb +16 -6
- data/lib/rubocop/cop/style/guard_clause.rb +69 -18
- data/lib/rubocop/cop/style/hash_as_last_array_item.rb +88 -0
- data/lib/rubocop/cop/style/hash_conversion.rb +133 -0
- data/lib/rubocop/cop/style/hash_each_methods.rb +103 -0
- data/lib/rubocop/cop/style/hash_except.rb +96 -0
- data/lib/rubocop/cop/style/hash_like_case.rb +77 -0
- data/lib/rubocop/cop/style/hash_syntax.rb +99 -94
- data/lib/rubocop/cop/style/hash_transform_keys.rb +95 -0
- data/lib/rubocop/cop/style/hash_transform_values.rb +92 -0
- data/lib/rubocop/cop/style/identical_conditional_branches.rb +53 -29
- data/lib/rubocop/cop/style/if_inside_else.rb +101 -11
- data/lib/rubocop/cop/style/if_unless_modifier.rb +162 -44
- data/lib/rubocop/cop/style/if_unless_modifier_of_if_unless.rb +13 -4
- data/lib/rubocop/cop/style/if_with_boolean_literal_branches.rb +122 -0
- data/lib/rubocop/cop/style/if_with_semicolon.rb +62 -4
- data/lib/rubocop/cop/style/implicit_runtime_error.rb +10 -7
- data/lib/rubocop/cop/style/in_pattern_then.rb +56 -0
- data/lib/rubocop/cop/style/infinite_loop.rb +65 -27
- data/lib/rubocop/cop/style/inline_comment.rb +7 -5
- data/lib/rubocop/cop/style/inverse_methods.rb +99 -44
- data/lib/rubocop/cop/style/ip_addresses.rb +75 -0
- data/lib/rubocop/cop/style/keyword_parameters_order.rb +75 -0
- data/lib/rubocop/cop/style/lambda.rb +26 -110
- data/lib/rubocop/cop/style/lambda_call.rb +29 -19
- data/lib/rubocop/cop/style/line_end_concatenation.rb +40 -34
- data/lib/rubocop/cop/style/method_call_with_args_parentheses.rb +185 -52
- data/lib/rubocop/cop/style/method_call_with_args_parentheses/omit_parentheses.rb +189 -0
- data/lib/rubocop/cop/style/method_call_with_args_parentheses/require_parentheses.rb +44 -0
- data/lib/rubocop/cop/style/method_call_without_args_parentheses.rb +27 -18
- data/lib/rubocop/cop/style/method_called_on_do_end_block.rb +19 -10
- data/lib/rubocop/cop/style/method_def_parentheses.rb +122 -45
- data/lib/rubocop/cop/style/min_max.rb +64 -0
- data/lib/rubocop/cop/style/missing_else.rb +88 -20
- data/lib/rubocop/cop/style/missing_respond_to_missing.rb +52 -0
- data/lib/rubocop/cop/style/mixin_grouping.rb +66 -28
- data/lib/rubocop/cop/style/mixin_usage.rb +72 -0
- data/lib/rubocop/cop/style/module_function.rb +111 -26
- data/lib/rubocop/cop/style/multiline_block_chain.rb +21 -15
- data/lib/rubocop/cop/style/multiline_if_modifier.rb +8 -11
- data/lib/rubocop/cop/style/multiline_if_then.rb +14 -17
- data/lib/rubocop/cop/style/multiline_in_pattern_then.rb +62 -0
- data/lib/rubocop/cop/style/multiline_memoization.rb +44 -25
- data/lib/rubocop/cop/style/multiline_method_signature.rb +91 -0
- data/lib/rubocop/cop/style/multiline_ternary_operator.rb +45 -5
- data/lib/rubocop/cop/style/multiline_when_then.rb +75 -0
- data/lib/rubocop/cop/style/multiple_comparison.rb +157 -0
- data/lib/rubocop/cop/style/mutable_constant.rb +132 -18
- data/lib/rubocop/cop/style/negated_if.rb +33 -38
- data/lib/rubocop/cop/style/negated_if_else_condition.rb +128 -0
- data/lib/rubocop/cop/style/negated_unless.rb +88 -0
- data/lib/rubocop/cop/style/negated_while.rb +25 -17
- data/lib/rubocop/cop/style/nested_modifier.rb +36 -23
- data/lib/rubocop/cop/style/nested_parenthesized_calls.rb +38 -29
- data/lib/rubocop/cop/style/nested_ternary_operator.rb +41 -4
- data/lib/rubocop/cop/style/next.rb +77 -67
- data/lib/rubocop/cop/style/nil_comparison.rb +62 -14
- data/lib/rubocop/cop/style/nil_lambda.rb +70 -0
- data/lib/rubocop/cop/style/non_nil_check.rb +100 -63
- data/lib/rubocop/cop/style/not.rb +38 -31
- data/lib/rubocop/cop/style/numeric_literal_prefix.rb +47 -25
- data/lib/rubocop/cop/style/numeric_literals.rb +40 -35
- data/lib/rubocop/cop/style/numeric_predicate.rb +33 -43
- data/lib/rubocop/cop/style/one_line_conditional.rb +100 -28
- data/lib/rubocop/cop/style/option_hash.rb +21 -25
- data/lib/rubocop/cop/style/optional_arguments.rb +4 -11
- data/lib/rubocop/cop/style/optional_boolean_parameter.rb +53 -0
- data/lib/rubocop/cop/style/or_assignment.rb +97 -0
- data/lib/rubocop/cop/style/parallel_assignment.rb +42 -48
- data/lib/rubocop/cop/style/parentheses_around_condition.rb +76 -14
- data/lib/rubocop/cop/style/percent_literal_delimiters.rb +42 -23
- data/lib/rubocop/cop/style/percent_q_literals.rb +31 -13
- data/lib/rubocop/cop/style/perl_backrefs.rb +91 -16
- data/lib/rubocop/cop/style/preferred_hash_methods.rb +15 -24
- data/lib/rubocop/cop/style/proc.rb +18 -10
- data/lib/rubocop/cop/style/quoted_symbols.rb +105 -0
- data/lib/rubocop/cop/style/raise_args.rb +53 -46
- data/lib/rubocop/cop/style/random_with_offset.rb +153 -0
- data/lib/rubocop/cop/style/redundant_argument.rb +85 -0
- data/lib/rubocop/cop/style/redundant_assignment.rb +106 -0
- data/lib/rubocop/cop/style/redundant_begin.rb +119 -9
- data/lib/rubocop/cop/style/{unneeded_capital_w.rb → redundant_capital_w.rb} +17 -11
- data/lib/rubocop/cop/style/redundant_condition.rb +137 -0
- data/lib/rubocop/cop/style/redundant_conditional.rb +96 -0
- data/lib/rubocop/cop/style/redundant_exception.rb +28 -18
- data/lib/rubocop/cop/style/redundant_fetch_block.rb +115 -0
- data/lib/rubocop/cop/style/redundant_file_extension_in_require.rb +52 -0
- data/lib/rubocop/cop/style/redundant_freeze.rb +37 -13
- data/lib/rubocop/cop/style/redundant_interpolation.rb +103 -0
- data/lib/rubocop/cop/style/redundant_parentheses.rb +99 -54
- data/lib/rubocop/cop/style/{unneeded_percent_q.rb → redundant_percent_q.rb} +39 -26
- data/lib/rubocop/cop/style/redundant_regexp_character_class.rb +104 -0
- data/lib/rubocop/cop/style/redundant_regexp_escape.rb +118 -0
- data/lib/rubocop/cop/style/redundant_return.rb +109 -59
- data/lib/rubocop/cop/style/redundant_self.rb +75 -50
- data/lib/rubocop/cop/style/redundant_self_assignment.rb +118 -0
- data/lib/rubocop/cop/style/redundant_sort.rb +160 -0
- data/lib/rubocop/cop/{performance → style}/redundant_sort_by.rb +15 -13
- data/lib/rubocop/cop/style/regexp_literal.rb +142 -43
- data/lib/rubocop/cop/style/rescue_modifier.rb +77 -14
- data/lib/rubocop/cop/style/rescue_standard_error.rb +126 -0
- data/lib/rubocop/cop/style/return_nil.rb +94 -0
- data/lib/rubocop/cop/style/safe_navigation.rb +193 -58
- data/lib/rubocop/cop/{performance → style}/sample.rb +29 -26
- data/lib/rubocop/cop/style/self_assignment.rb +24 -16
- data/lib/rubocop/cop/style/semicolon.rb +48 -17
- data/lib/rubocop/cop/style/send.rb +15 -7
- data/lib/rubocop/cop/style/signal_exception.rb +134 -27
- data/lib/rubocop/cop/style/single_argument_dig.rb +55 -0
- data/lib/rubocop/cop/style/single_line_block_params.rb +72 -23
- data/lib/rubocop/cop/style/single_line_methods.rb +95 -37
- data/lib/rubocop/cop/style/slicing_with_range.rb +38 -0
- data/lib/rubocop/cop/style/sole_nested_conditional.rb +176 -0
- data/lib/rubocop/cop/style/special_global_vars.rb +80 -58
- data/lib/rubocop/cop/style/stabby_lambda_parentheses.rb +35 -69
- data/lib/rubocop/cop/style/static_class.rb +97 -0
- data/lib/rubocop/cop/style/stderr_puts.rb +57 -0
- data/lib/rubocop/cop/style/string_chars.rb +39 -0
- data/lib/rubocop/cop/style/string_concatenation.rb +142 -0
- data/lib/rubocop/cop/style/string_hash_keys.rb +51 -0
- data/lib/rubocop/cop/style/string_literals.rb +44 -13
- data/lib/rubocop/cop/style/string_literals_in_interpolation.rb +24 -3
- data/lib/rubocop/cop/style/string_methods.rb +17 -15
- data/lib/rubocop/cop/{performance/lstrip_rstrip.rb → style/strip.rb} +18 -17
- data/lib/rubocop/cop/style/struct_inheritance.rb +45 -9
- data/lib/rubocop/cop/style/swap_values.rb +108 -0
- data/lib/rubocop/cop/style/symbol_array.rb +56 -46
- data/lib/rubocop/cop/style/symbol_literal.rb +6 -10
- data/lib/rubocop/cop/style/symbol_proc.rb +63 -78
- data/lib/rubocop/cop/style/ternary_parentheses.rb +95 -77
- data/lib/rubocop/cop/style/top_level_method_definition.rb +83 -0
- data/lib/rubocop/cop/style/trailing_body_on_class.rb +40 -0
- data/lib/rubocop/cop/style/trailing_body_on_method_definition.rb +55 -0
- data/lib/rubocop/cop/style/trailing_body_on_module.rb +40 -0
- data/lib/rubocop/cop/style/trailing_comma_in_arguments.rb +69 -27
- data/lib/rubocop/cop/style/trailing_comma_in_array_literal.rb +96 -0
- data/lib/rubocop/cop/style/trailing_comma_in_block_args.rb +86 -0
- data/lib/rubocop/cop/style/trailing_comma_in_hash_literal.rb +97 -0
- data/lib/rubocop/cop/style/trailing_method_end_statement.rb +65 -0
- data/lib/rubocop/cop/style/trailing_underscore_variable.rb +79 -40
- data/lib/rubocop/cop/style/trivial_accessors.rb +158 -82
- data/lib/rubocop/cop/style/unless_else.rb +25 -13
- data/lib/rubocop/cop/style/unless_logical_operators.rb +105 -0
- data/lib/rubocop/cop/style/unpack_first.rb +59 -0
- data/lib/rubocop/cop/style/variable_interpolation.rb +26 -25
- data/lib/rubocop/cop/style/when_then.rb +20 -7
- data/lib/rubocop/cop/style/while_until_do.rb +31 -18
- data/lib/rubocop/cop/style/while_until_modifier.rb +36 -24
- data/lib/rubocop/cop/style/word_array.rb +40 -91
- data/lib/rubocop/cop/style/yoda_condition.rb +155 -0
- data/lib/rubocop/cop/style/zero_length_predicate.rb +60 -31
- data/lib/rubocop/cop/team.rb +171 -105
- data/lib/rubocop/cop/util.rb +44 -194
- data/lib/rubocop/cop/utils/format_string.rb +133 -0
- data/lib/rubocop/cop/variable_force.rb +47 -51
- data/lib/rubocop/cop/variable_force/assignment.rb +10 -4
- data/lib/rubocop/cop/variable_force/branch.rb +22 -9
- data/lib/rubocop/cop/variable_force/branchable.rb +2 -0
- data/lib/rubocop/cop/variable_force/reference.rb +1 -3
- data/lib/rubocop/cop/variable_force/scope.rb +13 -14
- data/lib/rubocop/cop/variable_force/variable.rb +25 -14
- data/lib/rubocop/cop/variable_force/variable_table.rb +4 -3
- data/lib/rubocop/cops_documentation_generator.rb +270 -0
- data/lib/rubocop/core_ext/string.rb +23 -0
- data/lib/rubocop/directive_comment.rb +96 -0
- data/lib/rubocop/error.rb +24 -0
- data/lib/rubocop/ext/processed_source.rb +18 -0
- data/lib/rubocop/ext/regexp_node.rb +87 -0
- data/lib/rubocop/ext/regexp_parser.rb +92 -0
- data/lib/rubocop/file_finder.rb +41 -0
- data/lib/rubocop/formatter/auto_gen_config_formatter.rb +17 -0
- data/lib/rubocop/formatter/base_formatter.rb +3 -7
- data/lib/rubocop/formatter/clang_style_formatter.rb +13 -8
- data/lib/rubocop/formatter/disabled_config_formatter.rb +110 -58
- data/lib/rubocop/formatter/emacs_style_formatter.rb +24 -9
- data/lib/rubocop/formatter/file_list_formatter.rb +2 -1
- data/lib/rubocop/formatter/formatter_set.rb +20 -16
- data/lib/rubocop/formatter/fuubar_style_formatter.rb +2 -2
- data/lib/rubocop/formatter/git_hub_actions_formatter.rb +44 -0
- data/lib/rubocop/formatter/html_formatter.rb +18 -15
- data/lib/rubocop/formatter/json_formatter.rb +17 -14
- data/lib/rubocop/formatter/junit_formatter.rb +93 -0
- data/lib/rubocop/formatter/offense_count_formatter.rb +21 -2
- data/lib/rubocop/formatter/pacman_formatter.rb +80 -0
- data/lib/rubocop/formatter/progress_formatter.rb +4 -5
- data/lib/rubocop/formatter/quiet_formatter.rb +13 -0
- data/lib/rubocop/formatter/simple_text_formatter.rb +61 -26
- data/lib/rubocop/formatter/tap_formatter.rb +86 -0
- data/lib/rubocop/formatter/worst_offenders_formatter.rb +4 -2
- data/lib/rubocop/lockfile.rb +40 -0
- data/lib/rubocop/magic_comment.rb +45 -12
- data/lib/rubocop/name_similarity.rb +18 -10
- data/lib/rubocop/options.rb +311 -140
- data/lib/rubocop/path_util.rb +57 -5
- data/lib/rubocop/platform.rb +1 -1
- data/lib/rubocop/rake_task.rb +27 -32
- data/lib/rubocop/remote_config.rb +32 -8
- data/lib/rubocop/result_cache.rb +89 -39
- data/lib/rubocop/rspec/cop_helper.rb +18 -46
- data/lib/rubocop/rspec/expect_offense.rb +329 -0
- data/lib/rubocop/rspec/host_environment_simulation_helper.rb +1 -5
- data/lib/rubocop/rspec/shared_contexts.rb +92 -53
- data/lib/rubocop/rspec/support.rb +9 -4
- data/lib/rubocop/runner.rb +174 -86
- data/lib/rubocop/string_interpreter.rb +11 -8
- data/lib/rubocop/target_finder.rb +102 -93
- data/lib/rubocop/target_ruby.rb +264 -0
- data/lib/rubocop/util.rb +16 -0
- data/lib/rubocop/version.rb +71 -5
- data/lib/rubocop/yaml_duplication_checker.rb +40 -0
- metadata +495 -233
- data/bin/rubocop +0 -17
- data/config/disabled.yml +0 -119
- data/config/enabled.yml +0 -1713
- data/lib/rubocop/ast/builder.rb +0 -64
- data/lib/rubocop/ast/node.rb +0 -610
- data/lib/rubocop/ast/node/and_node.rb +0 -37
- data/lib/rubocop/ast/node/array_node.rb +0 -48
- data/lib/rubocop/ast/node/case_node.rb +0 -64
- data/lib/rubocop/ast/node/ensure_node.rb +0 -25
- data/lib/rubocop/ast/node/for_node.rb +0 -53
- data/lib/rubocop/ast/node/hash_node.rb +0 -109
- data/lib/rubocop/ast/node/if_node.rb +0 -138
- data/lib/rubocop/ast/node/keyword_splat_node.rb +0 -45
- data/lib/rubocop/ast/node/mixin/binary_operator_node.rb +0 -23
- data/lib/rubocop/ast/node/mixin/conditional_node.rb +0 -45
- data/lib/rubocop/ast/node/mixin/hash_element_node.rb +0 -125
- data/lib/rubocop/ast/node/mixin/modifier_node.rb +0 -17
- data/lib/rubocop/ast/node/mixin/predicate_operator_node.rb +0 -35
- data/lib/rubocop/ast/node/or_node.rb +0 -37
- data/lib/rubocop/ast/node/pair_node.rb +0 -64
- data/lib/rubocop/ast/node/resbody_node.rb +0 -25
- data/lib/rubocop/ast/node/send_node.rb +0 -195
- data/lib/rubocop/ast/node/until_node.rb +0 -43
- data/lib/rubocop/ast/node/when_node.rb +0 -61
- data/lib/rubocop/ast/node/while_node.rb +0 -43
- data/lib/rubocop/ast/sexp.rb +0 -16
- data/lib/rubocop/ast/traversal.rb +0 -171
- data/lib/rubocop/cop/lint/end_in_method.rb +0 -40
- data/lib/rubocop/cop/lint/handle_exceptions.rb +0 -56
- data/lib/rubocop/cop/lint/invalid_character_literal.rb +0 -41
- data/lib/rubocop/cop/lint/multiple_compare.rb +0 -48
- data/lib/rubocop/cop/lint/string_conversion_in_interpolation.rb +0 -58
- data/lib/rubocop/cop/lint/unneeded_disable.rb +0 -231
- data/lib/rubocop/cop/lint/unneeded_splat_expansion.rb +0 -141
- data/lib/rubocop/cop/lint/useless_comparison.rb +0 -28
- data/lib/rubocop/cop/metrics/line_length.rb +0 -168
- data/lib/rubocop/cop/mixin/access_modifier_node.rb +0 -41
- data/lib/rubocop/cop/mixin/autocorrect_alignment.rb +0 -149
- data/lib/rubocop/cop/mixin/classish_length.rb +0 -36
- data/lib/rubocop/cop/mixin/on_method_def.rb +0 -44
- data/lib/rubocop/cop/mixin/parser_diagnostic.rb +0 -34
- data/lib/rubocop/cop/mixin/safe_mode.rb +0 -22
- data/lib/rubocop/cop/mixin/space_inside.rb +0 -76
- data/lib/rubocop/cop/mixin/target_rails_version.rb +0 -16
- data/lib/rubocop/cop/mixin/too_many_lines.rb +0 -39
- data/lib/rubocop/cop/performance/case_when_splat.rb +0 -176
- data/lib/rubocop/cop/performance/casecmp.rb +0 -107
- data/lib/rubocop/cop/performance/compare_with_block.rb +0 -61
- data/lib/rubocop/cop/performance/count.rb +0 -98
- data/lib/rubocop/cop/performance/detect.rb +0 -107
- data/lib/rubocop/cop/performance/double_start_end_with.rb +0 -102
- data/lib/rubocop/cop/performance/end_with.rb +0 -55
- data/lib/rubocop/cop/performance/fixed_size.rb +0 -56
- data/lib/rubocop/cop/performance/flat_map.rb +0 -73
- data/lib/rubocop/cop/performance/hash_each_methods.rb +0 -84
- data/lib/rubocop/cop/performance/range_include.rb +0 -41
- data/lib/rubocop/cop/performance/redundant_block_call.rb +0 -93
- data/lib/rubocop/cop/performance/redundant_match.rb +0 -55
- data/lib/rubocop/cop/performance/redundant_merge.rb +0 -149
- data/lib/rubocop/cop/performance/regexp_match.rb +0 -215
- data/lib/rubocop/cop/performance/reverse_each.rb +0 -40
- data/lib/rubocop/cop/performance/size.rb +0 -71
- data/lib/rubocop/cop/performance/start_with.rb +0 -58
- data/lib/rubocop/cop/performance/string_replacement.rb +0 -170
- data/lib/rubocop/cop/performance/times_map.rb +0 -61
- data/lib/rubocop/cop/rails/action_filter.rb +0 -96
- data/lib/rubocop/cop/rails/active_support_aliases.rb +0 -68
- data/lib/rubocop/cop/rails/blank.rb +0 -132
- data/lib/rubocop/cop/rails/date.rb +0 -127
- data/lib/rubocop/cop/rails/delegate.rb +0 -106
- data/lib/rubocop/cop/rails/delegate_allow_blank.rb +0 -51
- data/lib/rubocop/cop/rails/dynamic_find_by.rb +0 -81
- data/lib/rubocop/cop/rails/enum_uniqueness.rb +0 -43
- data/lib/rubocop/cop/rails/exit.rb +0 -61
- data/lib/rubocop/cop/rails/file_path.rb +0 -75
- data/lib/rubocop/cop/rails/find_by.rb +0 -51
- data/lib/rubocop/cop/rails/find_each.rb +0 -47
- data/lib/rubocop/cop/rails/has_and_belongs_to_many.rb +0 -18
- data/lib/rubocop/cop/rails/http_positional_arguments.rb +0 -106
- data/lib/rubocop/cop/rails/not_null_column.rb +0 -67
- data/lib/rubocop/cop/rails/output.rb +0 -23
- data/lib/rubocop/cop/rails/output_safety.rb +0 -54
- data/lib/rubocop/cop/rails/pluralization_grammar.rb +0 -106
- data/lib/rubocop/cop/rails/present.rb +0 -137
- data/lib/rubocop/cop/rails/read_write_attribute.rb +0 -65
- data/lib/rubocop/cop/rails/relative_date_constant.rb +0 -57
- data/lib/rubocop/cop/rails/request_referer.rb +0 -56
- data/lib/rubocop/cop/rails/reversible_migration.rb +0 -216
- data/lib/rubocop/cop/rails/safe_navigation.rb +0 -91
- data/lib/rubocop/cop/rails/save_bang.rb +0 -155
- data/lib/rubocop/cop/rails/scope_args.rb +0 -29
- data/lib/rubocop/cop/rails/skips_model_validations.rb +0 -63
- data/lib/rubocop/cop/rails/time_zone.rb +0 -197
- data/lib/rubocop/cop/rails/uniq_before_pluck.rb +0 -93
- data/lib/rubocop/cop/rails/validation.rb +0 -64
- data/lib/rubocop/cop/style/access_modifier_indentation.rb +0 -80
- data/lib/rubocop/cop/style/accessor_method_name.rb +0 -45
- data/lib/rubocop/cop/style/align_array.rb +0 -20
- data/lib/rubocop/cop/style/align_hash.rb +0 -235
- data/lib/rubocop/cop/style/align_parameters.rb +0 -69
- data/lib/rubocop/cop/style/ascii_identifiers.rb +0 -36
- data/lib/rubocop/cop/style/block_end_newline.rb +0 -56
- data/lib/rubocop/cop/style/braces_around_hash_parameters.rb +0 -138
- data/lib/rubocop/cop/style/case_indentation.rb +0 -100
- data/lib/rubocop/cop/style/class_and_module_camel_case.rb +0 -29
- data/lib/rubocop/cop/style/closing_parenthesis_indentation.rb +0 -88
- data/lib/rubocop/cop/style/comment_indentation.rb +0 -71
- data/lib/rubocop/cop/style/constant_name.rb +0 -29
- data/lib/rubocop/cop/style/else_alignment.rb +0 -105
- data/lib/rubocop/cop/style/empty_line_between_defs.rb +0 -143
- data/lib/rubocop/cop/style/empty_lines_around_access_modifier.rb +0 -95
- data/lib/rubocop/cop/style/empty_lines_around_block_body.rb +0 -41
- data/lib/rubocop/cop/style/empty_lines_around_class_body.rb +0 -39
- data/lib/rubocop/cop/style/empty_lines_around_module_body.rb +0 -44
- data/lib/rubocop/cop/style/end_of_line.rb +0 -52
- data/lib/rubocop/cop/style/extra_spacing.rb +0 -237
- data/lib/rubocop/cop/style/first_parameter_indentation.rb +0 -109
- data/lib/rubocop/cop/style/flip_flop.rb +0 -20
- data/lib/rubocop/cop/style/indent_array.rb +0 -114
- data/lib/rubocop/cop/style/indent_hash.rb +0 -134
- data/lib/rubocop/cop/style/indent_heredoc.rb +0 -173
- data/lib/rubocop/cop/style/indentation_consistency.rb +0 -51
- data/lib/rubocop/cop/style/initial_indentation.rb +0 -42
- data/lib/rubocop/cop/style/leading_comment_space.rb +0 -43
- data/lib/rubocop/cop/style/method_missing.rb +0 -81
- data/lib/rubocop/cop/style/method_name.rb +0 -28
- data/lib/rubocop/cop/style/multiline_array_brace_layout.rb +0 -81
- data/lib/rubocop/cop/style/multiline_assignment_layout.rb +0 -88
- data/lib/rubocop/cop/style/multiline_block_layout.rb +0 -134
- data/lib/rubocop/cop/style/op_method.rb +0 -41
- data/lib/rubocop/cop/style/predicate_name.rb +0 -67
- data/lib/rubocop/cop/style/rescue_ensure_alignment.rb +0 -86
- data/lib/rubocop/cop/style/space_after_comma.rb +0 -21
- data/lib/rubocop/cop/style/space_after_method_name.rb +0 -37
- data/lib/rubocop/cop/style/space_around_block_parameters.rb +0 -109
- data/lib/rubocop/cop/style/space_around_equals_in_parameter_default.rb +0 -68
- data/lib/rubocop/cop/style/space_around_operators.rb +0 -142
- data/lib/rubocop/cop/style/space_before_block_braces.rb +0 -54
- data/lib/rubocop/cop/style/space_before_comma.rb +0 -16
- data/lib/rubocop/cop/style/space_before_comment.rb +0 -27
- data/lib/rubocop/cop/style/space_before_semicolon.rb +0 -16
- data/lib/rubocop/cop/style/space_in_lambda_literal.rb +0 -87
- data/lib/rubocop/cop/style/space_inside_block_braces.rb +0 -158
- data/lib/rubocop/cop/style/space_inside_brackets.rb +0 -20
- data/lib/rubocop/cop/style/space_inside_hash_literal_braces.rb +0 -150
- data/lib/rubocop/cop/style/space_inside_parens.rb +0 -16
- data/lib/rubocop/cop/style/space_inside_string_interpolation.rb +0 -65
- data/lib/rubocop/cop/style/tab.rb +0 -57
- data/lib/rubocop/cop/style/trailing_blank_lines.rb +0 -78
- data/lib/rubocop/cop/style/trailing_comma_in_literal.rb +0 -56
- data/lib/rubocop/cop/style/trailing_whitespace.rb +0 -28
- data/lib/rubocop/cop/style/unneeded_interpolation.rb +0 -98
- data/lib/rubocop/cop/style/variable_name.rb +0 -39
- data/lib/rubocop/cop/style/variable_number.rb +0 -78
- data/lib/rubocop/formatter/disabled_lines_formatter.rb +0 -57
- data/lib/rubocop/node_pattern.rb +0 -543
- data/lib/rubocop/processed_source.rb +0 -151
- data/lib/rubocop/rspec/shared_examples.rb +0 -100
- data/lib/rubocop/string_util.rb +0 -156
- data/lib/rubocop/token.rb +0 -25
@@ -0,0 +1,97 @@
|
|
1
|
+
# frozen_string_literal: true
|
2
|
+
|
3
|
+
module RuboCop
|
4
|
+
module Cop
|
5
|
+
module Style
|
6
|
+
# This cop checks for potential usage of the `||=` operator.
|
7
|
+
#
|
8
|
+
# @example
|
9
|
+
# # bad
|
10
|
+
# name = name ? name : 'Bozhidar'
|
11
|
+
#
|
12
|
+
# # bad
|
13
|
+
# name = if name
|
14
|
+
# name
|
15
|
+
# else
|
16
|
+
# 'Bozhidar'
|
17
|
+
# end
|
18
|
+
#
|
19
|
+
# # bad
|
20
|
+
# unless name
|
21
|
+
# name = 'Bozhidar'
|
22
|
+
# end
|
23
|
+
#
|
24
|
+
# # bad
|
25
|
+
# name = 'Bozhidar' unless name
|
26
|
+
#
|
27
|
+
# # good - set name to 'Bozhidar', only if it's nil or false
|
28
|
+
# name ||= 'Bozhidar'
|
29
|
+
class OrAssignment < Base
|
30
|
+
extend AutoCorrector
|
31
|
+
|
32
|
+
MSG = 'Use the double pipe equals operator `||=` instead.'
|
33
|
+
|
34
|
+
# @!method ternary_assignment?(node)
|
35
|
+
def_node_matcher :ternary_assignment?, <<~PATTERN
|
36
|
+
({lvasgn ivasgn cvasgn gvasgn} _var
|
37
|
+
(if
|
38
|
+
({lvar ivar cvar gvar} _var)
|
39
|
+
({lvar ivar cvar gvar} _var)
|
40
|
+
$_))
|
41
|
+
PATTERN
|
42
|
+
|
43
|
+
# @!method unless_assignment?(node)
|
44
|
+
def_node_matcher :unless_assignment?, <<~PATTERN
|
45
|
+
(if
|
46
|
+
({lvar ivar cvar gvar} _var) nil?
|
47
|
+
({lvasgn ivasgn cvasgn gvasgn} _var
|
48
|
+
_))
|
49
|
+
PATTERN
|
50
|
+
|
51
|
+
def on_if(node)
|
52
|
+
return unless unless_assignment?(node)
|
53
|
+
|
54
|
+
add_offense(node) { |corrector| autocorrect(corrector, node) }
|
55
|
+
end
|
56
|
+
|
57
|
+
def on_lvasgn(node)
|
58
|
+
return unless (else_branch = ternary_assignment?(node))
|
59
|
+
return if else_branch.if_type?
|
60
|
+
|
61
|
+
add_offense(node) { |corrector| autocorrect(corrector, node) }
|
62
|
+
end
|
63
|
+
|
64
|
+
alias on_ivasgn on_lvasgn
|
65
|
+
alias on_cvasgn on_lvasgn
|
66
|
+
alias on_gvasgn on_lvasgn
|
67
|
+
|
68
|
+
private
|
69
|
+
|
70
|
+
def autocorrect(corrector, node)
|
71
|
+
if ternary_assignment?(node)
|
72
|
+
variable, default = take_variable_and_default_from_ternary(node)
|
73
|
+
else
|
74
|
+
variable, default = take_variable_and_default_from_unless(node)
|
75
|
+
end
|
76
|
+
|
77
|
+
corrector.replace(node, "#{variable} ||= #{default.source}")
|
78
|
+
end
|
79
|
+
|
80
|
+
def take_variable_and_default_from_ternary(node)
|
81
|
+
variable, if_statement = *node
|
82
|
+
[variable, if_statement.else_branch]
|
83
|
+
end
|
84
|
+
|
85
|
+
def take_variable_and_default_from_unless(node)
|
86
|
+
if node.if_branch
|
87
|
+
variable, default = *node.if_branch
|
88
|
+
else
|
89
|
+
variable, default = *node.else_branch
|
90
|
+
end
|
91
|
+
|
92
|
+
[variable, default]
|
93
|
+
end
|
94
|
+
end
|
95
|
+
end
|
96
|
+
end
|
97
|
+
end
|
@@ -22,24 +22,35 @@ module RuboCop
|
|
22
22
|
# a = 1
|
23
23
|
# b = 2
|
24
24
|
# c = 3
|
25
|
-
class ParallelAssignment <
|
25
|
+
class ParallelAssignment < Base
|
26
26
|
include RescueNode
|
27
|
+
extend AutoCorrector
|
27
28
|
|
28
|
-
MSG = 'Do not use parallel assignment.'
|
29
|
+
MSG = 'Do not use parallel assignment.'
|
29
30
|
|
30
31
|
def on_masgn(node)
|
31
32
|
lhs, rhs = *node
|
32
33
|
lhs_elements = *lhs
|
33
|
-
rhs_elements =
|
34
|
+
rhs_elements = Array(rhs).compact # edge case for one constant
|
34
35
|
|
35
36
|
return if allowed_lhs?(lhs) || allowed_rhs?(rhs) ||
|
36
37
|
allowed_masign?(lhs_elements, rhs_elements)
|
37
38
|
|
38
|
-
add_offense(node,
|
39
|
+
add_offense(node) { |corrector| autocorrect(corrector, node) }
|
39
40
|
end
|
40
41
|
|
41
42
|
private
|
42
43
|
|
44
|
+
def autocorrect(corrector, node)
|
45
|
+
left, right = *node
|
46
|
+
left_elements = *left
|
47
|
+
right_elements = Array(right).compact
|
48
|
+
order = find_valid_order(left_elements, right_elements)
|
49
|
+
correction = assignment_corrector(node, order)
|
50
|
+
|
51
|
+
corrector.replace(correction.correction_range, correction.correction)
|
52
|
+
end
|
53
|
+
|
43
54
|
def allowed_masign?(lhs_elements, rhs_elements)
|
44
55
|
lhs_elements.size != rhs_elements.size ||
|
45
56
|
!find_valid_order(lhs_elements,
|
@@ -56,31 +67,16 @@ module RuboCop
|
|
56
67
|
|
57
68
|
def allowed_rhs?(node)
|
58
69
|
# Edge case for one constant
|
59
|
-
elements =
|
70
|
+
elements = Array(node).compact
|
60
71
|
|
61
72
|
# Account for edge case of `Constant::CONSTANT`
|
62
|
-
!node.array_type? ||
|
63
|
-
return_of_method_call?(node) ||
|
64
|
-
elements.any?(&:splat_type?)
|
73
|
+
!node.array_type? || return_of_method_call?(node) || elements.any?(&:splat_type?)
|
65
74
|
end
|
66
75
|
|
67
76
|
def return_of_method_call?(node)
|
68
77
|
node.block_type? || node.send_type?
|
69
78
|
end
|
70
79
|
|
71
|
-
def autocorrect(node)
|
72
|
-
lambda do |corrector|
|
73
|
-
left, right = *node
|
74
|
-
left_elements = *left
|
75
|
-
right_elements = [*right].compact
|
76
|
-
order = find_valid_order(left_elements, right_elements)
|
77
|
-
correction = assignment_corrector(node, order)
|
78
|
-
|
79
|
-
corrector.replace(correction.correction_range,
|
80
|
-
correction.correction)
|
81
|
-
end
|
82
|
-
end
|
83
|
-
|
84
80
|
def assignment_corrector(node, order)
|
85
81
|
_assignment, modifier = *node.parent
|
86
82
|
if modifier_statement?(node.parent)
|
@@ -115,7 +111,8 @@ module RuboCop
|
|
115
111
|
end
|
116
112
|
end
|
117
113
|
|
118
|
-
|
114
|
+
# @!method implicit_self_getter?(node)
|
115
|
+
def_node_matcher :implicit_self_getter?, '(send nil? $_)'
|
119
116
|
|
120
117
|
# Helper class necessitated by silly design of TSort prior to Ruby 2.1
|
121
118
|
# Newer versions have a better API, but that doesn't help us
|
@@ -123,16 +120,21 @@ module RuboCop
|
|
123
120
|
include TSort
|
124
121
|
extend RuboCop::NodePattern::Macros
|
125
122
|
|
123
|
+
# @!method var_name(node)
|
126
124
|
def_node_matcher :var_name, '{(casgn _ $_) (_ $_)}'
|
125
|
+
|
126
|
+
# @!method uses_var?(node)
|
127
127
|
def_node_search :uses_var?, '{({lvar ivar cvar gvar} %) (const _ %)}'
|
128
|
+
|
129
|
+
# @!method matching_calls(node, receiver, method_name)
|
128
130
|
def_node_search :matching_calls, '(send %1 %2 $...)'
|
129
131
|
|
130
132
|
def initialize(assignments)
|
131
133
|
@assignments = assignments
|
132
134
|
end
|
133
135
|
|
134
|
-
def tsort_each_node
|
135
|
-
@assignments.each
|
136
|
+
def tsort_each_node(&block)
|
137
|
+
@assignments.each(&block)
|
136
138
|
end
|
137
139
|
|
138
140
|
def tsort_each_child(assignment)
|
@@ -142,20 +144,26 @@ module RuboCop
|
|
142
144
|
|
143
145
|
@assignments.each do |other|
|
144
146
|
_other_lhs, other_rhs = *other
|
145
|
-
|
146
|
-
|
147
|
-
|
148
|
-
|
147
|
+
|
148
|
+
next unless dependency?(my_lhs, other_rhs)
|
149
|
+
|
150
|
+
yield other
|
149
151
|
end
|
150
152
|
end
|
151
153
|
|
154
|
+
def dependency?(lhs, rhs)
|
155
|
+
uses_var?(rhs, var_name(lhs)) ||
|
156
|
+
lhs.send_type? && lhs.assignment_method? && accesses?(rhs, lhs)
|
157
|
+
end
|
158
|
+
|
152
159
|
# `lhs` is an assignment method call like `obj.attr=` or `ary[idx]=`.
|
153
160
|
# Does `rhs` access the same value which is assigned by `lhs`?
|
154
161
|
def accesses?(rhs, lhs)
|
155
162
|
if lhs.method?(:[]=)
|
156
|
-
|
157
|
-
|
158
|
-
|
163
|
+
# FIXME: Workaround `rubocop:disable` comment for JRuby.
|
164
|
+
# rubocop:disable Performance/RedundantEqualityComparisonBlock
|
165
|
+
matching_calls(rhs, lhs.receiver, :[]).any? { |args| args == lhs.arguments }
|
166
|
+
# rubocop:enable Performance/RedundantEqualityComparisonBlock
|
159
167
|
else
|
160
168
|
access_method = lhs.method_name.to_s.chop.to_sym
|
161
169
|
matching_calls(rhs, lhs.receiver, access_method).any?
|
@@ -164,26 +172,12 @@ module RuboCop
|
|
164
172
|
end
|
165
173
|
|
166
174
|
def modifier_statement?(node)
|
167
|
-
node &&
|
168
|
-
((node.if_type? && node.modifier_form?) ||
|
169
|
-
((node.while_type? || node.until_type?) && modifier_while?(node)))
|
170
|
-
end
|
171
|
-
|
172
|
-
def modifier_while?(node)
|
173
|
-
node.loc.respond_to?(:keyword) &&
|
174
|
-
%w[while until].include?(node.loc.keyword.source) &&
|
175
|
-
node.modifier_form?
|
176
|
-
end
|
177
|
-
|
178
|
-
def rescue_modifier_old?(node)
|
179
|
-
node && node.rescue_type? &&
|
180
|
-
(node.parent.nil? || !(node.parent.kwbegin_type? ||
|
181
|
-
node.parent.ensure_type?))
|
175
|
+
node && %i[if while until].include?(node.type) && node.modifier_form?
|
182
176
|
end
|
183
177
|
|
184
178
|
# An internal class for correcting parallel assignment
|
185
179
|
class GenericCorrector
|
186
|
-
include
|
180
|
+
include Alignment
|
187
181
|
|
188
182
|
attr_reader :config, :node
|
189
183
|
|
@@ -238,7 +232,7 @@ module RuboCop
|
|
238
232
|
# If the parallel assignment uses a rescue modifier and it is the
|
239
233
|
# only contents of a method, then we want to make use of the
|
240
234
|
# implicit begin
|
241
|
-
if node.parent.parent
|
235
|
+
if node.parent.parent&.def_type?
|
242
236
|
super + def_correction(rescue_result)
|
243
237
|
else
|
244
238
|
begin_correction(rescue_result)
|
@@ -5,9 +5,58 @@ module RuboCop
|
|
5
5
|
module Style
|
6
6
|
# This cop checks for the presence of superfluous parentheses around the
|
7
7
|
# condition of if/unless/while/until.
|
8
|
-
|
8
|
+
#
|
9
|
+
# `AllowSafeAssignment` option for safe assignment.
|
10
|
+
# By safe assignment we mean putting parentheses around
|
11
|
+
# an assignment to indicate "I know I'm using an assignment
|
12
|
+
# as a condition. It's not a mistake."
|
13
|
+
#
|
14
|
+
# @example
|
15
|
+
# # bad
|
16
|
+
# x += 1 while (x < 10)
|
17
|
+
# foo unless (bar || baz)
|
18
|
+
#
|
19
|
+
# if (x > 10)
|
20
|
+
# elsif (x < 3)
|
21
|
+
# end
|
22
|
+
#
|
23
|
+
# # good
|
24
|
+
# x += 1 while x < 10
|
25
|
+
# foo unless bar || baz
|
26
|
+
#
|
27
|
+
# if x > 10
|
28
|
+
# elsif x < 3
|
29
|
+
# end
|
30
|
+
#
|
31
|
+
# @example AllowSafeAssignment: true (default)
|
32
|
+
# # good
|
33
|
+
# foo unless (bar = baz)
|
34
|
+
#
|
35
|
+
# @example AllowSafeAssignment: false
|
36
|
+
# # bad
|
37
|
+
# foo unless (bar = baz)
|
38
|
+
#
|
39
|
+
# @example AllowInMultilineConditions: false (default)
|
40
|
+
# # bad
|
41
|
+
# if (x > 10 &&
|
42
|
+
# y > 10)
|
43
|
+
# end
|
44
|
+
#
|
45
|
+
# # good
|
46
|
+
# if x > 10 &&
|
47
|
+
# y > 10
|
48
|
+
# end
|
49
|
+
#
|
50
|
+
# @example AllowInMultilineConditions: true
|
51
|
+
# # good
|
52
|
+
# if (x > 10 &&
|
53
|
+
# y > 10)
|
54
|
+
# end
|
55
|
+
#
|
56
|
+
class ParenthesesAroundCondition < Base
|
9
57
|
include SafeAssignment
|
10
58
|
include Parentheses
|
59
|
+
extend AutoCorrector
|
11
60
|
|
12
61
|
def on_if(node)
|
13
62
|
return if node.ternary?
|
@@ -18,38 +67,51 @@ module RuboCop
|
|
18
67
|
def on_while(node)
|
19
68
|
process_control_op(node)
|
20
69
|
end
|
21
|
-
|
22
|
-
def on_until(node)
|
23
|
-
process_control_op(node)
|
24
|
-
end
|
70
|
+
alias on_until on_while
|
25
71
|
|
26
72
|
private
|
27
73
|
|
74
|
+
# @!method control_op_condition(node)
|
75
|
+
def_node_matcher :control_op_condition, <<~PATTERN
|
76
|
+
(begin $_ ...)
|
77
|
+
PATTERN
|
78
|
+
|
28
79
|
def process_control_op(node)
|
29
80
|
cond = node.condition
|
30
81
|
|
31
|
-
|
32
|
-
|
33
|
-
|
34
|
-
return if parens_required?(node.children.first)
|
35
|
-
return if safe_assignment?(cond) && safe_assignment_allowed?
|
82
|
+
control_op_condition(cond) do |first_child|
|
83
|
+
return if modifier_op?(first_child)
|
84
|
+
return if parens_allowed?(cond)
|
36
85
|
|
37
|
-
|
86
|
+
message = message(cond)
|
87
|
+
add_offense(cond, message: message) do |corrector|
|
88
|
+
ParenthesesCorrector.correct(corrector, cond)
|
89
|
+
end
|
90
|
+
end
|
38
91
|
end
|
39
92
|
|
40
93
|
def modifier_op?(node)
|
41
94
|
return false if node.if_type? && node.ternary?
|
42
95
|
return true if node.rescue_type?
|
43
96
|
|
44
|
-
|
45
|
-
node.modifier_form?
|
97
|
+
node.basic_conditional? && node.modifier_form?
|
46
98
|
end
|
47
99
|
|
48
100
|
def message(node)
|
49
|
-
kw = node.keyword
|
101
|
+
kw = node.parent.keyword
|
50
102
|
article = kw == 'while' ? 'a' : 'an'
|
51
103
|
"Don't use parentheses around the condition of #{article} `#{kw}`."
|
52
104
|
end
|
105
|
+
|
106
|
+
def parens_allowed?(node)
|
107
|
+
parens_required?(node) ||
|
108
|
+
(safe_assignment?(node) && safe_assignment_allowed?) ||
|
109
|
+
(node.multiline? && allow_multiline_conditions?)
|
110
|
+
end
|
111
|
+
|
112
|
+
def allow_multiline_conditions?
|
113
|
+
cop_config['AllowInMultilineConditions']
|
114
|
+
end
|
53
115
|
end
|
54
116
|
end
|
55
117
|
end
|
@@ -12,8 +12,8 @@ module RuboCop
|
|
12
12
|
# @example
|
13
13
|
# # Style/PercentLiteralDelimiters:
|
14
14
|
# # PreferredDelimiters:
|
15
|
-
# # default: []
|
16
|
-
# # %i:
|
15
|
+
# # default: '[]'
|
16
|
+
# # '%i': '()'
|
17
17
|
#
|
18
18
|
# # good
|
19
19
|
# %w[alpha beta] + %i(gamma delta)
|
@@ -23,8 +23,9 @@ module RuboCop
|
|
23
23
|
#
|
24
24
|
# # bad
|
25
25
|
# %I(alpha beta)
|
26
|
-
class PercentLiteralDelimiters <
|
26
|
+
class PercentLiteralDelimiters < Base
|
27
27
|
include PercentLiteral
|
28
|
+
extend AutoCorrector
|
28
29
|
|
29
30
|
def on_array(node)
|
30
31
|
process(node, '%w', '%W', '%i', '%I')
|
@@ -47,33 +48,31 @@ module RuboCop
|
|
47
48
|
process(node, '%x')
|
48
49
|
end
|
49
50
|
|
50
|
-
def message(node)
|
51
|
-
type = type(node)
|
52
|
-
delimiters = preferred_delimiters_for(type)
|
53
|
-
|
54
|
-
"`#{type}`-literals should be delimited by " \
|
55
|
-
"`#{delimiters[0]}` and `#{delimiters[1]}`."
|
56
|
-
end
|
57
|
-
|
58
51
|
private
|
59
52
|
|
60
|
-
def
|
53
|
+
def on_percent_literal(node)
|
61
54
|
type = type(node)
|
55
|
+
return if uses_preferred_delimiter?(node, type) ||
|
56
|
+
contains_preferred_delimiter?(node, type) ||
|
57
|
+
include_same_character_as_used_for_delimiter?(node, type)
|
62
58
|
|
63
|
-
|
59
|
+
add_offense(node, message: message(type)) do |corrector|
|
60
|
+
opening_delimiter, closing_delimiter = preferred_delimiters_for(type)
|
64
61
|
|
65
|
-
lambda do |corrector|
|
66
62
|
corrector.replace(node.loc.begin, "#{type}#{opening_delimiter}")
|
67
63
|
corrector.replace(node.loc.end, closing_delimiter)
|
68
64
|
end
|
69
65
|
end
|
70
66
|
|
71
|
-
def
|
72
|
-
|
73
|
-
|
74
|
-
|
67
|
+
def message(type)
|
68
|
+
delimiters = preferred_delimiters_for(type)
|
69
|
+
|
70
|
+
"`#{type}`-literals should be delimited by " \
|
71
|
+
"`#{delimiters[0]}` and `#{delimiters[1]}`."
|
72
|
+
end
|
75
73
|
|
76
|
-
|
74
|
+
def preferred_delimiters_for(type)
|
75
|
+
PreferredDelimiters.new(type, @config, nil).delimiters
|
77
76
|
end
|
78
77
|
|
79
78
|
def uses_preferred_delimiter?(node, type)
|
@@ -81,19 +80,39 @@ module RuboCop
|
|
81
80
|
end
|
82
81
|
|
83
82
|
def contains_preferred_delimiter?(node, type)
|
84
|
-
|
83
|
+
contains_delimiter?(node, preferred_delimiters_for(type))
|
84
|
+
end
|
85
|
+
|
86
|
+
def include_same_character_as_used_for_delimiter?(node, type)
|
87
|
+
return false unless %w[%w %i].include?(type)
|
88
|
+
|
89
|
+
used_delimiters = matchpairs(begin_source(node)[-1])
|
90
|
+
contains_delimiter?(node, used_delimiters)
|
91
|
+
end
|
92
|
+
|
93
|
+
def contains_delimiter?(node, delimiters)
|
94
|
+
delimiters_regexp = Regexp.union(delimiters)
|
85
95
|
node
|
86
96
|
.children.map { |n| string_source(n) }.compact
|
87
|
-
.any? { |s|
|
97
|
+
.any? { |s| delimiters_regexp.match?(s) }
|
88
98
|
end
|
89
99
|
|
90
100
|
def string_source(node)
|
91
101
|
if node.is_a?(String)
|
92
|
-
node
|
93
|
-
elsif node.respond_to?(:type) && node.str_type?
|
102
|
+
node.scrub
|
103
|
+
elsif node.respond_to?(:type) && (node.str_type? || node.sym_type?)
|
94
104
|
node.source
|
95
105
|
end
|
96
106
|
end
|
107
|
+
|
108
|
+
def matchpairs(begin_delimiter)
|
109
|
+
{
|
110
|
+
'(' => %w[( )],
|
111
|
+
'[' => %w[[ ]],
|
112
|
+
'{' => %w[{ }],
|
113
|
+
'<' => %w[< >]
|
114
|
+
}.fetch(begin_delimiter, [begin_delimiter])
|
115
|
+
end
|
97
116
|
end
|
98
117
|
end
|
99
118
|
end
|