rubocop 0.48.1 → 0.49.0

data/lib/rubocop.rb

@@ -26,9 +26,12 @@ require 'rubocop/ast/node/mixin/binary_operator_node'
 require 'rubocop/ast/node/mixin/conditional_node'
 require 'rubocop/ast/node/mixin/hash_element_node'
 require 'rubocop/ast/node/mixin/modifier_node'
+require 'rubocop/ast/node/mixin/parameterized_node'
 require 'rubocop/ast/node/mixin/predicate_operator_node'
 require 'rubocop/ast/node/and_node'
+require 'rubocop/ast/node/args_node'
 require 'rubocop/ast/node/array_node'
+require 'rubocop/ast/node/block_node'
 require 'rubocop/ast/node/case_node'
 require 'rubocop/ast/node/ensure_node'
 require 'rubocop/ast/node/for_node'
@@ -39,6 +42,7 @@ require 'rubocop/ast/node/or_node'
 require 'rubocop/ast/node/pair_node'
 require 'rubocop/ast/node/resbody_node'
 require 'rubocop/ast/node/send_node'
+require 'rubocop/ast/node/super_node'
 require 'rubocop/ast/node/until_node'
 require 'rubocop/ast/node/when_node'
 require 'rubocop/ast/node/while_node'
@@ -72,6 +76,7 @@ require 'rubocop/cop/variable_force/variable_table'
 require 'rubocop/cop/mixin/access_modifier_node'
 require 'rubocop/cop/mixin/annotation_comment'
 require 'rubocop/cop/mixin/array_hash_indentation'
+require 'rubocop/cop/mixin/array_min_size'
 require 'rubocop/cop/mixin/array_syntax'
 require 'rubocop/cop/mixin/autocorrect_alignment'
 require 'rubocop/cop/mixin/check_assignment'
@@ -87,6 +92,7 @@ require 'rubocop/cop/mixin/documentation_comment'
 require 'rubocop/cop/mixin/duplication'
 require 'rubocop/cop/mixin/empty_lines_around_body'
 require 'rubocop/cop/mixin/end_keyword_alignment'
+require 'rubocop/cop/mixin/enforce_superclass'
 require 'rubocop/cop/mixin/first_element_line_break'
 require 'rubocop/cop/mixin/frozen_string_literal'
 require 'rubocop/cop/mixin/hash_alignment'
@@ -124,6 +130,77 @@ require 'rubocop/cop/mixin/unused_argument'
 require 'rubocop/cop/bundler/duplicated_gem'
 require 'rubocop/cop/bundler/ordered_gems'
 
+require 'rubocop/cop/layout/access_modifier_indentation'
+require 'rubocop/cop/layout/align_array'
+require 'rubocop/cop/layout/align_hash'
+require 'rubocop/cop/layout/align_parameters'
+require 'rubocop/cop/layout/block_end_newline'
+require 'rubocop/cop/layout/case_indentation'
+require 'rubocop/cop/layout/closing_parenthesis_indentation'
+require 'rubocop/cop/layout/comment_indentation'
+require 'rubocop/cop/layout/dot_position'
+require 'rubocop/cop/layout/else_alignment'
+require 'rubocop/cop/layout/empty_line_after_magic_comment'
+require 'rubocop/cop/layout/empty_line_between_defs'
+require 'rubocop/cop/layout/empty_lines_around_access_modifier'
+require 'rubocop/cop/layout/empty_lines_around_begin_body'
+require 'rubocop/cop/layout/empty_lines_around_block_body'
+require 'rubocop/cop/layout/empty_lines_around_class_body'
+require 'rubocop/cop/layout/empty_lines_around_exception_handling_keywords'
+require 'rubocop/cop/layout/empty_lines_around_method_body'
+require 'rubocop/cop/layout/empty_lines_around_module_body'
+require 'rubocop/cop/layout/empty_lines'
+require 'rubocop/cop/layout/end_of_line'
+require 'rubocop/cop/layout/extra_spacing'
+require 'rubocop/cop/layout/first_array_element_line_break'
+require 'rubocop/cop/layout/first_hash_element_line_break'
+require 'rubocop/cop/layout/first_method_argument_line_break'
+require 'rubocop/cop/layout/first_method_parameter_line_break'
+require 'rubocop/cop/layout/first_parameter_indentation'
+require 'rubocop/cop/layout/indent_array'
+require 'rubocop/cop/layout/indent_assignment'
+require 'rubocop/cop/layout/indentation_consistency'
+require 'rubocop/cop/layout/indentation_width'
+require 'rubocop/cop/layout/indent_hash'
+require 'rubocop/cop/layout/indent_heredoc'
+require 'rubocop/cop/layout/initial_indentation'
+require 'rubocop/cop/layout/leading_comment_space'
+require 'rubocop/cop/layout/multiline_array_brace_layout'
+require 'rubocop/cop/layout/multiline_assignment_layout'
+require 'rubocop/cop/layout/multiline_block_layout'
+require 'rubocop/cop/layout/multiline_hash_brace_layout'
+require 'rubocop/cop/layout/multiline_method_call_brace_layout'
+require 'rubocop/cop/layout/multiline_method_call_indentation'
+require 'rubocop/cop/layout/multiline_method_definition_brace_layout'
+require 'rubocop/cop/layout/multiline_operation_indentation'
+require 'rubocop/cop/layout/rescue_ensure_alignment'
+require 'rubocop/cop/layout/space_after_colon'
+require 'rubocop/cop/layout/space_after_comma'
+require 'rubocop/cop/layout/space_after_method_name'
+require 'rubocop/cop/layout/space_after_not'
+require 'rubocop/cop/layout/space_after_semicolon'
+require 'rubocop/cop/layout/space_around_block_parameters'
+require 'rubocop/cop/layout/space_around_equals_in_parameter_default'
+require 'rubocop/cop/layout/space_around_keyword'
+require 'rubocop/cop/layout/space_around_operators'
+require 'rubocop/cop/layout/space_before_block_braces'
+require 'rubocop/cop/layout/space_before_comma'
+require 'rubocop/cop/layout/space_before_comment'
+require 'rubocop/cop/layout/space_before_first_arg'
+require 'rubocop/cop/layout/space_before_semicolon'
+require 'rubocop/cop/layout/space_in_lambda_literal'
+require 'rubocop/cop/layout/space_inside_array_percent_literal'
+require 'rubocop/cop/layout/space_inside_block_braces'
+require 'rubocop/cop/layout/space_inside_brackets'
+require 'rubocop/cop/layout/space_inside_hash_literal_braces'
+require 'rubocop/cop/layout/space_inside_parens'
+require 'rubocop/cop/layout/space_inside_percent_literal_delimiters'
+require 'rubocop/cop/layout/space_inside_range_literal'
+require 'rubocop/cop/layout/space_inside_string_interpolation'
+require 'rubocop/cop/layout/tab'
+require 'rubocop/cop/layout/trailing_blank_lines'
+require 'rubocop/cop/layout/trailing_whitespace'
+
 require 'rubocop/cop/lint/ambiguous_block_association'
 require 'rubocop/cop/lint/ambiguous_operator'
 require 'rubocop/cop/lint/ambiguous_regexp_literal'
@@ -166,7 +243,9 @@ require 'rubocop/cop/lint/percent_symbol_array'
 require 'rubocop/cop/lint/rand_one'
 require 'rubocop/cop/lint/require_parentheses'
 require 'rubocop/cop/lint/rescue_exception'
+require 'rubocop/cop/lint/rescue_type'
 require 'rubocop/cop/lint/safe_navigation_chain'
+require 'rubocop/cop/lint/script_permission'
 require 'rubocop/cop/lint/shadowed_exception'
 require 'rubocop/cop/lint/shadowing_outer_local_variable'
 require 'rubocop/cop/lint/string_conversion_in_interpolation'
@@ -196,6 +275,7 @@ require 'rubocop/cop/metrics/module_length'
 require 'rubocop/cop/metrics/parameter_lists'
 require 'rubocop/cop/metrics/perceived_complexity'
 
+require 'rubocop/cop/performance/caller'
 require 'rubocop/cop/performance/case_when_splat'
 require 'rubocop/cop/performance/casecmp'
 require 'rubocop/cop/performance/count'
@@ -220,12 +300,8 @@ require 'rubocop/cop/performance/start_with'
 require 'rubocop/cop/performance/string_replacement'
 require 'rubocop/cop/performance/times_map'
 
-require 'rubocop/cop/style/access_modifier_indentation'
 require 'rubocop/cop/style/accessor_method_name'
 require 'rubocop/cop/style/alias'
-require 'rubocop/cop/style/align_array'
-require 'rubocop/cop/style/align_hash'
-require 'rubocop/cop/style/align_parameters'
 require 'rubocop/cop/style/and_or'
 require 'rubocop/cop/style/array_join'
 require 'rubocop/cop/style/ascii_comments'
@@ -236,22 +312,18 @@ require 'rubocop/cop/style/bare_percent_literals'
 require 'rubocop/cop/style/begin_block'
 require 'rubocop/cop/style/block_comments'
 require 'rubocop/cop/style/block_delimiters'
-require 'rubocop/cop/style/block_end_newline'
 require 'rubocop/cop/style/braces_around_hash_parameters'
 require 'rubocop/cop/style/case_equality'
-require 'rubocop/cop/style/case_indentation'
 require 'rubocop/cop/style/character_literal'
 require 'rubocop/cop/style/class_and_module_camel_case'
 require 'rubocop/cop/style/class_and_module_children'
 require 'rubocop/cop/style/class_check'
 require 'rubocop/cop/style/class_methods'
 require 'rubocop/cop/style/class_vars'
-require 'rubocop/cop/style/closing_parenthesis_indentation'
 require 'rubocop/cop/style/collection_methods'
 require 'rubocop/cop/style/colon_method_call'
 require 'rubocop/cop/style/command_literal'
 require 'rubocop/cop/style/comment_annotation'
-require 'rubocop/cop/style/comment_indentation'
 require 'rubocop/cop/style/conditional_assignment'
 require 'rubocop/cop/style/constant_name'
 require 'rubocop/cop/style/copyright'
@@ -259,39 +331,21 @@ require 'rubocop/cop/style/def_with_parentheses'
 require 'rubocop/cop/style/preferred_hash_methods'
 require 'rubocop/cop/style/documentation_method'
 require 'rubocop/cop/style/documentation'
-require 'rubocop/cop/style/dot_position'
 require 'rubocop/cop/style/double_negation'
 require 'rubocop/cop/style/each_for_simple_loop'
 require 'rubocop/cop/style/each_with_object'
-require 'rubocop/cop/style/else_alignment'
 require 'rubocop/cop/style/empty_case_condition'
 require 'rubocop/cop/style/empty_else'
-require 'rubocop/cop/style/empty_line_after_magic_comment'
-require 'rubocop/cop/style/empty_line_between_defs'
-require 'rubocop/cop/style/empty_lines'
-require 'rubocop/cop/style/empty_lines_around_access_modifier'
-require 'rubocop/cop/style/empty_lines_around_begin_body'
-require 'rubocop/cop/style/empty_lines_around_block_body'
-require 'rubocop/cop/style/empty_lines_around_class_body'
-require 'rubocop/cop/style/empty_lines_around_exception_handling_keywords'
-require 'rubocop/cop/style/empty_lines_around_method_body'
-require 'rubocop/cop/style/empty_lines_around_module_body'
 require 'rubocop/cop/style/empty_literal'
 require 'rubocop/cop/style/empty_method'
 require 'rubocop/cop/style/encoding'
 require 'rubocop/cop/style/end_block'
-require 'rubocop/cop/style/end_of_line'
 require 'rubocop/cop/style/even_odd'
-require 'rubocop/cop/style/extra_spacing'
 require 'rubocop/cop/style/file_name'
-require 'rubocop/cop/style/first_array_element_line_break'
-require 'rubocop/cop/style/first_hash_element_line_break'
-require 'rubocop/cop/style/first_method_argument_line_break'
-require 'rubocop/cop/style/first_method_parameter_line_break'
-require 'rubocop/cop/style/first_parameter_indentation'
 require 'rubocop/cop/style/flip_flop'
 require 'rubocop/cop/style/for'
 require 'rubocop/cop/style/format_string'
+require 'rubocop/cop/style/format_string_token'
 require 'rubocop/cop/style/frozen_string_literal_comment'
 require 'rubocop/cop/style/global_vars'
 require 'rubocop/cop/style/guard_clause'
@@ -302,19 +356,11 @@ require 'rubocop/cop/style/if_unless_modifier'
 require 'rubocop/cop/style/if_unless_modifier_of_if_unless'
 require 'rubocop/cop/style/if_with_semicolon'
 require 'rubocop/cop/style/implicit_runtime_error'
-require 'rubocop/cop/style/indent_array'
-require 'rubocop/cop/style/indent_assignment'
-require 'rubocop/cop/style/indent_hash'
-require 'rubocop/cop/style/indent_heredoc'
-require 'rubocop/cop/style/indentation_consistency'
-require 'rubocop/cop/style/indentation_width'
 require 'rubocop/cop/style/infinite_loop'
 require 'rubocop/cop/style/inverse_methods'
-require 'rubocop/cop/style/initial_indentation'
 require 'rubocop/cop/style/inline_comment'
 require 'rubocop/cop/style/lambda'
 require 'rubocop/cop/style/lambda_call'
-require 'rubocop/cop/style/leading_comment_space'
 require 'rubocop/cop/style/line_end_concatenation'
 require 'rubocop/cop/style/method_call_without_args_parentheses'
 require 'rubocop/cop/style/method_call_with_args_parentheses'
@@ -325,19 +371,12 @@ require 'rubocop/cop/style/method_missing'
 require 'rubocop/cop/style/missing_else'
 require 'rubocop/cop/style/mixin_grouping'
 require 'rubocop/cop/style/module_function'
-require 'rubocop/cop/style/multiline_array_brace_layout'
-require 'rubocop/cop/style/multiline_assignment_layout'
 require 'rubocop/cop/style/multiline_block_chain'
-require 'rubocop/cop/style/multiline_block_layout'
-require 'rubocop/cop/style/multiline_hash_brace_layout'
 require 'rubocop/cop/style/multiline_if_then'
 require 'rubocop/cop/style/multiline_if_modifier'
 require 'rubocop/cop/style/multiline_memoization'
-require 'rubocop/cop/style/multiline_method_call_brace_layout'
-require 'rubocop/cop/style/multiline_method_call_indentation'
-require 'rubocop/cop/style/multiline_method_definition_brace_layout'
-require 'rubocop/cop/style/multiline_operation_indentation'
 require 'rubocop/cop/style/multiline_ternary_operator'
+require 'rubocop/cop/style/multiple_comparison'
 require 'rubocop/cop/style/mutable_constant'
 require 'rubocop/cop/style/negated_if'
 require 'rubocop/cop/style/negated_while'
@@ -370,7 +409,6 @@ require 'rubocop/cop/style/redundant_parentheses'
 require 'rubocop/cop/style/redundant_return'
 require 'rubocop/cop/style/redundant_self'
 require 'rubocop/cop/style/regexp_literal'
-require 'rubocop/cop/style/rescue_ensure_alignment'
 require 'rubocop/cop/style/rescue_modifier'
 require 'rubocop/cop/style/safe_navigation'
 require 'rubocop/cop/style/self_assignment'
@@ -379,29 +417,6 @@ require 'rubocop/cop/style/send'
 require 'rubocop/cop/style/signal_exception'
 require 'rubocop/cop/style/single_line_block_params'
 require 'rubocop/cop/style/single_line_methods'
-require 'rubocop/cop/style/space_after_colon'
-require 'rubocop/cop/style/space_after_comma'
-require 'rubocop/cop/style/space_after_method_name'
-require 'rubocop/cop/style/space_after_not'
-require 'rubocop/cop/style/space_after_semicolon'
-require 'rubocop/cop/style/space_around_block_parameters'
-require 'rubocop/cop/style/space_around_equals_in_parameter_default'
-require 'rubocop/cop/style/space_around_keyword'
-require 'rubocop/cop/style/space_around_operators'
-require 'rubocop/cop/style/space_before_block_braces'
-require 'rubocop/cop/style/space_before_comma'
-require 'rubocop/cop/style/space_before_comment'
-require 'rubocop/cop/style/space_before_first_arg'
-require 'rubocop/cop/style/space_before_semicolon'
-require 'rubocop/cop/style/space_in_lambda_literal'
-require 'rubocop/cop/style/space_inside_array_percent_literal'
-require 'rubocop/cop/style/space_inside_block_braces'
-require 'rubocop/cop/style/space_inside_brackets'
-require 'rubocop/cop/style/space_inside_hash_literal_braces'
-require 'rubocop/cop/style/space_inside_parens'
-require 'rubocop/cop/style/space_inside_percent_literal_delimiters'
-require 'rubocop/cop/style/space_inside_range_literal'
-require 'rubocop/cop/style/space_inside_string_interpolation'
 require 'rubocop/cop/style/special_global_vars'
 require 'rubocop/cop/style/stabby_lambda_parentheses'
 require 'rubocop/cop/style/string_literals'
@@ -411,13 +426,10 @@ require 'rubocop/cop/style/struct_inheritance'
 require 'rubocop/cop/style/symbol_array'
 require 'rubocop/cop/style/symbol_literal'
 require 'rubocop/cop/style/symbol_proc'
-require 'rubocop/cop/style/tab'
 require 'rubocop/cop/style/ternary_parentheses'
-require 'rubocop/cop/style/trailing_blank_lines'
 require 'rubocop/cop/style/trailing_comma_in_arguments'
 require 'rubocop/cop/style/trailing_comma_in_literal'
 require 'rubocop/cop/style/trailing_underscore_variable'
-require 'rubocop/cop/style/trailing_whitespace'
 require 'rubocop/cop/style/trivial_accessors'
 require 'rubocop/cop/style/unless_else'
 require 'rubocop/cop/style/unneeded_capital_w'
@@ -430,10 +442,13 @@ require 'rubocop/cop/style/when_then'
 require 'rubocop/cop/style/while_until_do'
 require 'rubocop/cop/style/while_until_modifier'
 require 'rubocop/cop/style/word_array'
+require 'rubocop/cop/style/yoda_condition'
 require 'rubocop/cop/style/zero_length_predicate'
 
 require 'rubocop/cop/rails/action_filter'
 require 'rubocop/cop/rails/active_support_aliases'
+require 'rubocop/cop/rails/application_job'
+require 'rubocop/cop/rails/application_record'
 require 'rubocop/cop/rails/blank'
 require 'rubocop/cop/rails/date'
 require 'rubocop/cop/rails/dynamic_find_by'

data/lib/rubocop/ast/builder.rb

@@ -15,7 +15,9 @@ module RuboCop
     class Builder < Parser::Builders::Default
       NODE_MAP = {
         AndNode          => [:and],
+        ArgsNode         => [:args],
         ArrayNode        => [:array],
+        BlockNode        => [:block],
         CaseNode         => [:case],
         EnsureNode       => [:ensure],
         ForNode          => [:for],
@@ -25,7 +27,8 @@ module RuboCop
         OrNode           => [:or],
         PairNode         => [:pair],
         ResbodyNode      => [:resbody],
-        SendNode         => [:send],
+        SendNode         => %i[csend send],
+        SuperNode        => %i[super zsuper],
         UntilNode        => %i[until until_post],
         WhenNode         => [:when],
         WhileNode        => %i[while while_post]

data/lib/rubocop/ast/node.rb

@@ -52,8 +52,8 @@ module RuboCop
                 "#{compiler.emit_param_list});" \
                 "#{compiler.emit_method_code};end"
 
-          file, lineno = *caller.first.split(':')
-          class_eval(src, file, lineno.to_i)
+          location = caller_locations(1, 1).first
+          class_eval(src, location.path, location.lineno)
         end
       end
 

data/lib/rubocop/ast/node/and_node.rb

@@ -30,7 +30,7 @@ module RuboCop
       #
       # @return [Array<Node>] the different parts of the `and` predicate
       def node_parts
-        [*self]
+        to_a
       end
     end
   end

data/lib/rubocop/ast/node/args_node.rb

@@ -0,0 +1,24 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module AST
+    # A node extension for `args` nodes. This will be used in place of a plain
+    # node when the builder constructs the AST, making its methods available
+    # to all `args` nodes within RuboCop.
+    class ArgsNode < Node
+      # Whether this `args` node has any arguments.
+      #
+      # @return [Boolean] whether this `args` node has any arguments
+      def empty?
+        to_a.empty?
+      end
+
+      # The number of arguments in this `args` node.
+      #
+      # @return [Integer] the number of arguments in this `args` node
+      def size
+        to_a.size
+      end
+    end
+  end
+end

data/lib/rubocop/ast/node/block_node.rb

@@ -0,0 +1,107 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module AST
+    # A node extension for `block` nodes. This will be used in place of a plain
+    # node when the builder constructs the AST, making its methods available
+    # to all `send` nodes within RuboCop.
+    #
+    # A `block` node is essentially a method send with a block. Parser nests
+    # the `send` node inside the `block` node.
+    class BlockNode < Node
+      # The `send` node associated with this block.
+      #
+      # @return [SendNode] the `send` node associated with the `block` node
+      def send_node
+        node_parts[0]
+      end
+
+      # The arguments of this block.
+      #
+      # @return [Array<Node>]
+      def arguments
+        node_parts[1]
+      end
+
+      # The body of this block.
+      #
+      # @return [Node, nil] the body of the `block` node or `nil`
+      def body
+        node_parts[2]
+      end
+
+      # Checks whether this block takes any arguments.
+      #
+      # @return [Boolean] whether this `block` node takes any arguments
+      def arguments?
+        !arguments.empty?
+      end
+
+      # Checks whether the `block` literal is delimited by curly braces.
+      #
+      # @return [Boolean] whether the `block` literal is enclosed in braces
+      def braces?
+        loc.end && loc.end.is?('}')
+      end
+
+      # Checks whether the `block` literal is delimited by `do`-`end` keywords.
+      #
+      # @return [Boolean] whether the `block` literal is enclosed in `do`-`end`
+      def keywords?
+        loc.end && loc.end.is?('end')
+      end
+
+      # The delimiters for this `block` literal.
+      #
+      # @return [Array<String>] the delimiters for the `block` literal
+      def delimiters
+        [loc.begin.source, loc.end.source].freeze
+      end
+
+      # The opening delimiter for this `block` literal.
+      #
+      # @return [String] the opening delimiter for the `block` literal
+      def opening_delimiter
+        delimiters.first
+      end
+
+      # The closing delimiter for this `block` literal.
+      #
+      # @return [String] the closing delimiter for the `block` literal
+      def closing_delimiter
+        delimiters.last
+      end
+
+      # Checks whether this is a single line block. This is overridden here
+      # because the general version in `Node` does not work for `block` nodes.
+      #
+      # @return [Boolean] whether the `block` literal is on a single line
+      def single_line?
+        loc.begin.line == loc.end.line
+      end
+
+      # Checks whether this is a multiline block. This is overridden here
+      # because the general version in `Node` does not work for `block` nodes.
+      #
+      # @return [Boolean] whether the `block` literal is on a several lines
+      def multiline?
+        !single_line?
+      end
+
+      # Checks whether this `block` literal belongs to a lambda.
+      #
+      # @return [Boolean] whether the `block` literal belongs to a lambda
+      def lambda?
+        send_node.method?(:lambda)
+      end
+
+      # Custom destructuring method. This can be used to normalize
+      # destructuring for different variations of the node.
+      #
+      # @return [Array] the different parts of the `block` node
+      def node_parts
+        to_a
+      end
+    end
+  end
+end