rubocop 0.47.1 → 0.48.0

data/config/disabled.yml

@@ -114,11 +114,6 @@ Style/StringMethods:
   Description: 'Checks if configured preferred methods are used over non-preferred.'
   Enabled: false
 
-Style/SymbolArray:
-  Description: 'Use %i or %I for arrays of symbols.'
-  StyleGuide: '#percent-i'
-  Enabled: false
-
 Style/SingleLineBlockParams:
   Description: 'Enforces the names of some block params.'
   Enabled: false

data/config/enabled.yml

@@ -217,26 +217,42 @@ Style/EmptyLineBetweenDefs:
 
 Style/EmptyLines:
   Description: "Don't use several empty lines in a row."
+  StyleGuide: '#two-or-more-empty-lines'
   Enabled: true
 
 Style/EmptyLinesAroundAccessModifier:
   Description: "Keep blank lines around access modifiers."
+  StyleGuide: '#empty-lines-around-access-modifier'
+  Enabled: true
+
+Style/EmptyLinesAroundBeginBody:
+  Description: "Keeps track of empty lines around begin-end bodies."
+  StyleGuide: '#empty-lines-around-bodies'
   Enabled: true
 
 Style/EmptyLinesAroundBlockBody:
   Description: "Keeps track of empty lines around block bodies."
+  StyleGuide: '#empty-lines-around-bodies'
   Enabled: true
 
 Style/EmptyLinesAroundClassBody:
   Description: "Keeps track of empty lines around class bodies."
+  StyleGuide: '#empty-lines-around-bodies'
+  Enabled: true
+
+Style/EmptyLinesAroundExceptionHandlingKeywords:
+  Description: "Keeps track of empty lines around exception handling keywords."
+  StyleGuide: '#empty-lines-around-bodies'
   Enabled: true
 
 Style/EmptyLinesAroundModuleBody:
   Description: "Keeps track of empty lines around module bodies."
+  StyleGuide: '#empty-lines-around-bodies'
   Enabled: true
 
 Style/EmptyLinesAroundMethodBody:
   Description: "Keeps track of empty lines around method bodies."
+  StyleGuide: '#empty-lines-around-bodies'
   Enabled: true
 
 Style/EmptyLiteral:
@@ -374,11 +390,22 @@ Style/IndentHash:
   Description: 'Checks the indentation of the first key in a hash literal.'
   Enabled: true
 
+Style/IndentHeredoc:
+  Description: 'This cops checks the indentation of the here document bodies.'
+  StyleGuide: '#squiggly-heredocs'
+  Enabled: true
+
 Style/InfiniteLoop:
   Description: 'Use Kernel#loop for infinite loops.'
   StyleGuide: '#infinite-loop'
   Enabled: true
 
+Style/InverseMethods:
+  Description: >-
+                 Use the inverse method instead of `!.method`
+                 if an inverse method is defined.
+  Enabled: true
+
 Style/Lambda:
   Description: 'Use the new lambda literal syntax for single-line blocks.'
   StyleGuide: '#lambda-multi-line'
@@ -426,6 +453,11 @@ Style/MethodMissing:
   StyleGuide: '#no-method-missing'
   Enabled: true
 
+Style/MixinGrouping:
+  Description: 'Checks for grouping of mixins in `class` and `module` bodies.'
+  StyleGuide: '#mixin-grouping'
+  Enabled: true
+
 Style/ModuleFunction:
   Description: 'Checks for usage of `extend self` in modules.'
   StyleGuide: '#module-function'
@@ -533,6 +565,11 @@ Style/NestedTernaryOperator:
   StyleGuide: '#no-nested-ternary'
   Enabled: true
 
+Style/EmptyLineAfterMagicComment:
+  Description: 'Add a newline after magic comments to separate them from code.'
+  StyleGuide: '#separate-magic-comments-from-code'
+  Enabled: true
+
 Style/Next:
   Description: 'Use `next` to skip iteration instead of a condition at the end.'
   StyleGuide: '#no-nested-conditionals'
@@ -855,6 +892,11 @@ Style/StructInheritance:
   StyleGuide: '#no-extend-struct-new'
   Enabled: true
 
+Style/SymbolArray:
+  Description: 'Use %i or %I for arrays of symbols.'
+  StyleGuide: '#percent-i'
+  Enabled: true
+
 Style/SymbolLiteral:
   Description: 'Use plain symbols instead of string symbols when possible.'
   Enabled: true
@@ -966,7 +1008,7 @@ Style/ZeroLengthPredicate:
   Description: 'Use #empty? when testing for objects of length 0.'
   Enabled: true
 
-#################### Metrics ################################
+#################### Metrics ###############################
 
 Metrics/AbcSize:
   Description: >-
@@ -1019,9 +1061,16 @@ Metrics/PerceivedComplexity:
                  human reader.
   Enabled: true
 
-#################### Lint ################################
+#################### Lint ##################################
 ### Warnings
 
+Lint/AmbiguousBlockAssociation:
+  Description: >-
+                 Checks for ambiguous block association with method when param passed without
+                 parentheses.
+  StyleGuide: '#syntax'
+  Enabled: true
+
 Lint/AmbiguousOperator:
   Description: >-
                  Checks for ambiguous operators in the first argument of a
@@ -1090,6 +1139,7 @@ Lint/ElseLayout:
 Lint/EmptyEnsure:
   Description: 'Checks for empty ensure block.'
   Enabled: true
+  AutoCorrect: false
 
 Lint/EmptyExpression:
   Description: 'Checks for empty expressions.'
@@ -1302,7 +1352,7 @@ Lint/Void:
   Description: 'Possible use of operator/literal/variable in void context.'
   Enabled: true
 
-##################### Performance #############################
+#################### Performance ###########################
 
 Performance/Casecmp:
   Description: >-
@@ -1410,7 +1460,9 @@ Performance/RedundantSortBy:
   Enabled: true
 
 Performance/RegexpMatch:
-  Description: 'Use `match?` instead of `Regexp#match`, `String#match`, `Symbol#match`, `Regexp#===` or `=~` when `MatchData` is not used.'
+  Description: >-
+                  Use `match?` instead of `Regexp#match`, `String#match`, `Symbol#match`,
+                  `Regexp#===`, or `=~` when `MatchData` is not used.
   Enabled: true
 
 Performance/ReverseEach:
@@ -1457,12 +1509,29 @@ Performance/TimesMap:
   Description: 'Checks for .times.map calls.'
   Enabled: true
 
-##################### Rails ##################################
+#################### Rails #################################
 
 Rails/ActionFilter:
   Description: 'Enforces consistent use of action filter methods.'
   Enabled: true
 
+Rails/ActiveSupportAliases:
+  Description: >-
+                  Avoid ActiveSupport aliases of standard ruby methods:
+                  `String#starts_with?`, `String#ends_with?`,
+                  `Array#append`, `Array#prepend`.
+  Enabled: true
+
+Rails/Blank:
+  Description: 'Enforce using `blank?` and `present?`.'
+  Enabled: true
+  # Convert checks for `nil` or `empty?` to `blank?`
+  NilOrEmpty: true
+  # Convert usages of not `present?` to `blank?`
+  NotPresent: true
+  # Convert usages of `unless` `present?` to `if` `blank?`
+  UnlessPresent: true
+
 Rails/Date:
   Description: >-
                   Checks the correct usage of date aware methods,
@@ -1535,6 +1604,16 @@ Rails/PluralizationGrammar:
   Description: 'Checks for incorrect grammar when using methods like `3.day.ago`.'
   Enabled: true
 
+Rails/Present:
+  Description: 'Enforce using `blank?` and `present?`.'
+  Enabled: true
+  NotNilAndNotEmpty: true
+  # Convert checks for not `nil` and not `empty?` to `present?`
+  NotBlank: true
+  # Convert usages of not `blank?` to `present?`
+  UnlessBlank: true
+  # Convert usages of `unless` `blank?` to `if` `present?`
+
 Rails/ReadWriteAttribute:
   Description: >-
                  Checks for read_attribute(:attr) and
@@ -1542,6 +1621,10 @@ Rails/ReadWriteAttribute:
   StyleGuide: 'https://github.com/bbatsov/rails-style-guide#read-attribute'
   Enabled: true
 
+Rails/RelativeDateConstant:
+  Description: 'Do not assign relative date to constants.'
+  Enabled: true
+
 Rails/RequestReferer:
   Description: 'Use consistent syntax for request.referer.'
   Enabled: true
@@ -1581,6 +1664,8 @@ Rails/Validation:
   Description: 'Use validates :attribute, hash of validations.'
   Enabled: true
 
+#################### Security ##############################
+
 Security/Eval:
   Description: 'The use of eval represents a serious security risk.'
   Enabled: true
@@ -1609,7 +1694,7 @@ Security/YAMLLoad:
   Reference: 'https://ruby-doc.org/stdlib-2.3.3/libdoc/yaml/rdoc/YAML.html#module-YAML-label-Security'
   Enabled: true
 
-##################### Bundler #############################
+#################### Bundler ###############################
 
 Bundler/DuplicatedGem:
   Description: 'Checks for duplicate gem entries in Gemfile.'
@@ -1620,8 +1705,7 @@ Bundler/DuplicatedGem:
 
 Bundler/OrderedGems:
   Description: >-
-                 Sort alphabetically gems appearing within a contiguous set
-                 of lines in the Gemfile
+                 Gems within groups in the Gemfile should be alphabetically sorted.
   Enabled: true
   Include:
     - '**/Gemfile'

data/lib/rubocop.rb

@@ -15,22 +15,30 @@ require 'unicode/display_width'
 require 'rubocop/version'
 
 require 'rubocop/path_util'
+require 'rubocop/platform'
 require 'rubocop/string_util'
 require 'rubocop/name_similarity'
 require 'rubocop/node_pattern'
 require 'rubocop/string_interpreter'
 require 'rubocop/ast/sexp'
 require 'rubocop/ast/node'
+require 'rubocop/ast/node/mixin/binary_operator_node'
 require 'rubocop/ast/node/mixin/conditional_node'
 require 'rubocop/ast/node/mixin/hash_element_node'
 require 'rubocop/ast/node/mixin/modifier_node'
+require 'rubocop/ast/node/mixin/predicate_operator_node'
+require 'rubocop/ast/node/and_node'
 require 'rubocop/ast/node/array_node'
 require 'rubocop/ast/node/case_node'
+require 'rubocop/ast/node/ensure_node'
 require 'rubocop/ast/node/for_node'
 require 'rubocop/ast/node/hash_node'
 require 'rubocop/ast/node/if_node'
 require 'rubocop/ast/node/keyword_splat_node'
+require 'rubocop/ast/node/or_node'
 require 'rubocop/ast/node/pair_node'
+require 'rubocop/ast/node/resbody_node'
+require 'rubocop/ast/node/send_node'
 require 'rubocop/ast/node/until_node'
 require 'rubocop/ast/node/when_node'
 require 'rubocop/ast/node/while_node'
@@ -53,7 +61,8 @@ require 'rubocop/cop/force'
 require 'rubocop/cop/severity'
 
 require 'rubocop/cop/variable_force'
-require 'rubocop/cop/variable_force/locatable'
+require 'rubocop/cop/variable_force/branch'
+require 'rubocop/cop/variable_force/branchable'
 require 'rubocop/cop/variable_force/variable'
 require 'rubocop/cop/variable_force/assignment'
 require 'rubocop/cop/variable_force/reference'
@@ -81,6 +90,7 @@ require 'rubocop/cop/mixin/end_keyword_alignment'
 require 'rubocop/cop/mixin/first_element_line_break'
 require 'rubocop/cop/mixin/frozen_string_literal'
 require 'rubocop/cop/mixin/hash_alignment'
+require 'rubocop/cop/mixin/ignored_pattern'
 require 'rubocop/cop/mixin/integer_node'
 require 'rubocop/cop/mixin/on_method_def'
 require 'rubocop/cop/mixin/match_range'
@@ -95,6 +105,7 @@ require 'rubocop/cop/mixin/parentheses'
 require 'rubocop/cop/mixin/parser_diagnostic'
 require 'rubocop/cop/mixin/percent_literal'
 require 'rubocop/cop/mixin/preceding_following_alignment'
+require 'rubocop/cop/mixin/rescue_node'
 require 'rubocop/cop/mixin/safe_assignment'
 require 'rubocop/cop/mixin/safe_mode'
 require 'rubocop/cop/mixin/space_after_punctuation'
@@ -105,6 +116,7 @@ require 'rubocop/cop/mixin/statement_modifier'
 require 'rubocop/cop/mixin/string_help'
 require 'rubocop/cop/mixin/string_literals_help'
 require 'rubocop/cop/mixin/target_ruby_version'
+require 'rubocop/cop/mixin/target_rails_version'
 require 'rubocop/cop/mixin/too_many_lines'
 require 'rubocop/cop/mixin/trailing_comma'
 require 'rubocop/cop/mixin/unused_argument'
@@ -112,6 +124,7 @@ require 'rubocop/cop/mixin/unused_argument'
 require 'rubocop/cop/bundler/duplicated_gem'
 require 'rubocop/cop/bundler/ordered_gems'
 
+require 'rubocop/cop/lint/ambiguous_block_association'
 require 'rubocop/cop/lint/ambiguous_operator'
 require 'rubocop/cop/lint/ambiguous_regexp_literal'
 require 'rubocop/cop/lint/assignment_in_condition'
@@ -253,11 +266,14 @@ require 'rubocop/cop/style/each_with_object'
 require 'rubocop/cop/style/else_alignment'
 require 'rubocop/cop/style/empty_case_condition'
 require 'rubocop/cop/style/empty_else'
+require 'rubocop/cop/style/empty_line_after_magic_comment'
 require 'rubocop/cop/style/empty_line_between_defs'
 require 'rubocop/cop/style/empty_lines'
 require 'rubocop/cop/style/empty_lines_around_access_modifier'
+require 'rubocop/cop/style/empty_lines_around_begin_body'
 require 'rubocop/cop/style/empty_lines_around_block_body'
 require 'rubocop/cop/style/empty_lines_around_class_body'
+require 'rubocop/cop/style/empty_lines_around_exception_handling_keywords'
 require 'rubocop/cop/style/empty_lines_around_method_body'
 require 'rubocop/cop/style/empty_lines_around_module_body'
 require 'rubocop/cop/style/empty_literal'
@@ -289,9 +305,11 @@ require 'rubocop/cop/style/implicit_runtime_error'
 require 'rubocop/cop/style/indent_array'
 require 'rubocop/cop/style/indent_assignment'
 require 'rubocop/cop/style/indent_hash'
+require 'rubocop/cop/style/indent_heredoc'
 require 'rubocop/cop/style/indentation_consistency'
 require 'rubocop/cop/style/indentation_width'
 require 'rubocop/cop/style/infinite_loop'
+require 'rubocop/cop/style/inverse_methods'
 require 'rubocop/cop/style/initial_indentation'
 require 'rubocop/cop/style/inline_comment'
 require 'rubocop/cop/style/lambda'
@@ -305,6 +323,7 @@ require 'rubocop/cop/style/method_def_parentheses'
 require 'rubocop/cop/style/method_name'
 require 'rubocop/cop/style/method_missing'
 require 'rubocop/cop/style/missing_else'
+require 'rubocop/cop/style/mixin_grouping'
 require 'rubocop/cop/style/module_function'
 require 'rubocop/cop/style/multiline_array_brace_layout'
 require 'rubocop/cop/style/multiline_assignment_layout'
@@ -414,6 +433,8 @@ require 'rubocop/cop/style/word_array'
 require 'rubocop/cop/style/zero_length_predicate'
 
 require 'rubocop/cop/rails/action_filter'
+require 'rubocop/cop/rails/active_support_aliases'
+require 'rubocop/cop/rails/blank'
 require 'rubocop/cop/rails/date'
 require 'rubocop/cop/rails/dynamic_find_by'
 require 'rubocop/cop/rails/delegate'
@@ -429,9 +450,11 @@ require 'rubocop/cop/rails/not_null_column'
 require 'rubocop/cop/rails/output_safety'
 require 'rubocop/cop/rails/output'
 require 'rubocop/cop/rails/pluralization_grammar'
+require 'rubocop/cop/rails/present'
 require 'rubocop/cop/rails/read_write_attribute'
 require 'rubocop/cop/rails/request_referer'
 require 'rubocop/cop/rails/reversible_migration'
+require 'rubocop/cop/rails/relative_date_constant'
 require 'rubocop/cop/rails/safe_navigation'
 require 'rubocop/cop/rails/save_bang'
 require 'rubocop/cop/rails/scope_args'

data/lib/rubocop/ast/builder.rb

@@ -14,16 +14,21 @@ module RuboCop
     #   root_node = parser.parse(buffer)
     class Builder < Parser::Builders::Default
       NODE_MAP = {
+        AndNode          => [:and],
         ArrayNode        => [:array],
         CaseNode         => [:case],
+        EnsureNode       => [:ensure],
         ForNode          => [:for],
         HashNode         => [:hash],
         IfNode           => [:if],
         KeywordSplatNode => [:kwsplat],
+        OrNode           => [:or],
         PairNode         => [:pair],
-        UntilNode        => [:until, :until_post],
+        ResbodyNode      => [:resbody],
+        SendNode         => [:send],
+        UntilNode        => %i(until until_post),
         WhenNode         => [:when],
-        WhileNode        => [:while, :while_post]
+        WhileNode        => %i(while while_post)
       }.freeze
 
       # Generates {Node} from the given information.

data/lib/rubocop/ast/node.rb

@@ -21,27 +21,27 @@ module RuboCop
     class Node < Parser::AST::Node # rubocop:disable Metrics/ClassLength
       include RuboCop::AST::Sexp
 
-      COMPARISON_OPERATORS = [:!, :==, :===, :!=, :<=, :>=, :>, :<, :<=>].freeze
+      COMPARISON_OPERATORS = %i(! == === != <= >= > < <=>).freeze
 
-      TRUTHY_LITERALS = [:str, :dstr, :xstr, :int, :float, :sym, :dsym, :array,
-                         :hash, :regexp, :true, :irange, :erange, :complex,
-                         :rational, :regopt].freeze
-      FALSEY_LITERALS = [:false, :nil].freeze
+      TRUTHY_LITERALS = %i(str dstr xstr int float sym dsym array
+                           hash regexp true irange erange complex
+                           rational regopt).freeze
+      FALSEY_LITERALS = %i(false nil).freeze
       LITERALS = (TRUTHY_LITERALS + FALSEY_LITERALS).freeze
-      COMPOSITE_LITERALS = [:dstr, :xstr, :dsym, :array, :hash, :irange,
-                            :erange, :regexp].freeze
+      COMPOSITE_LITERALS = %i(dstr xstr dsym array hash irange
+                              erange regexp).freeze
       BASIC_LITERALS = (LITERALS - COMPOSITE_LITERALS).freeze
-      MUTABLE_LITERALS = [:str, :dstr, :xstr, :array, :hash].freeze
+      MUTABLE_LITERALS = %i(str dstr xstr array hash).freeze
       IMMUTABLE_LITERALS = (LITERALS - MUTABLE_LITERALS).freeze
 
-      VARIABLES = [:ivar, :gvar, :cvar, :lvar].freeze
-      REFERENCES = [:nth_ref, :back_ref].freeze
-      KEYWORDS = [:alias, :and, :break, :case, :class, :def, :defs, :defined?,
-                  :kwbegin, :do, :else, :ensure, :for, :if, :module, :next,
-                  :not, :or, :postexe, :redo, :rescue, :retry, :return, :self,
-                  :super, :zsuper, :then, :undef, :until, :when, :while,
-                  :yield].freeze
-      OPERATOR_KEYWORDS = [:and, :or].freeze
+      VARIABLES = %i(ivar gvar cvar lvar).freeze
+      REFERENCES = %i(nth_ref back_ref).freeze
+      KEYWORDS = %i(alias and break case class def defs defined?
+                    kwbegin do else ensure for if module next
+                    not or postexe redo rescue retry return self
+                    super zsuper then undef until when while
+                    yield).freeze
+      OPERATOR_KEYWORDS = %i(and or).freeze
       SPECIAL_KEYWORDS = %w(__FILE__ __LINE__ __ENCODING__).freeze
 
       # def_matcher can be used to define a pattern-matching method on Node
@@ -110,7 +110,7 @@ module RuboCop
       # part of it is changed.
       def updated(type = nil, children = nil, properties = {})
         properties[:location] ||= @location
-        Node.new(type || @type, children || @children, properties)
+        self.class.new(type || @type, children || @children, properties)
       end
 
       # Returns the index of the receiver node in its siblings. (Sibling index
@@ -361,7 +361,7 @@ module RuboCop
         IMMUTABLE_LITERALS.include?(type)
       end
 
-      [:literal, :basic_literal].each do |kind|
+      %i(literal basic_literal).each do |kind|
         recursive_kind = :"recursive_#{kind}?"
         kind_filter = :"#{kind}?"
         define_method(recursive_kind) do
@@ -398,6 +398,10 @@ module RuboCop
         SPECIAL_KEYWORDS.include?(source)
       end
 
+      def operator_keyword?
+        OPERATOR_KEYWORDS.include?(type)
+      end
+
       def keyword_not?
         _receiver, method_name, *args = *self
         args.empty? && method_name == :! && loc.selector.is?('not'.freeze)
@@ -439,8 +443,7 @@ module RuboCop
         [{(send nil {:raise :fail} ...) return break next} single_line?]
       PATTERN
 
-      def_matcher :command?, '(send nil %1 ...)'
-      def_matcher :lambda?,  '(block (send nil :lambda) ...)'
+      def_matcher :lambda?, '(block (send nil :lambda) ...)'
       def_matcher :proc?, <<-PATTERN
         {(block (send nil :proc) ...)
          (block (send (const nil :Proc) :new) ...)