rubocop 0.45.0 → 0.46.0

data/lib/rubocop/formatter/fuubar_style_formatter.rb

@@ -11,6 +11,12 @@ module RuboCop
     class FuubarStyleFormatter < ClangStyleFormatter
       RESET_SEQUENCE = "\e[0m".freeze
 
+      def initialize(*)
+        @severest_offense = nil
+
+        super
+      end
+
       def started(target_files)
         super
 

data/lib/rubocop/node_pattern.rb

@@ -97,7 +97,7 @@ module RuboCop
     # @private
     # Builds Ruby code which implements a pattern
     class Compiler
-      RSYM    = %r{:(?:[\w+@_*/?!<>=~|%^-]+|\[\]=?)}
+      RSYM    = %r{:(?:[\w+@*/?!<>=~|%^-]+|\[\]=?)}
       ID_CHAR = /[a-zA-Z_]/
       META    = /\(|\)|\{|\}|\[|\]|\$\.\.\.|\$|!|\^|\.\.\./
       NUMBER  = /-?\d+(?:\.\d+)?/
@@ -178,7 +178,7 @@ module RuboCop
       end
 
       def compile_seq_terms(tokens, cur_node)
-        terms, size =
+        ret, size =
           compile_seq_terms_with_size(tokens, cur_node) do |token, terms, index|
             case token
             when '...'.freeze
@@ -188,7 +188,7 @@ module RuboCop
             end
           end
 
-        terms << "(#{cur_node}.children.size == #{size})"
+        ret << "(#{cur_node}.children.size == #{size})"
       end
 
       def compile_seq_terms_with_size(tokens, cur_node)
@@ -334,7 +334,8 @@ module RuboCop
           "(#{cur_node}#{'.type' if seq_head} == temp#{@unify[name]})"
         else
           n = @unify[name] = next_temp_value
-          "(temp#{n} = #{cur_node}#{'.type' if seq_head}; true)"
+          # double assign to temp#{n} to avoid "assigned but unused variable"
+          "(temp#{n} = temp#{n} = #{cur_node}#{'.type' if seq_head}; true)"
         end
       end
 
@@ -444,7 +445,8 @@ module RuboCop
 
       def with_temp_node(cur_node)
         with_temp_variable do |temp_var|
-          yield "#{temp_var} = #{cur_node}", temp_var
+          # double assign to temp#{n} to avoid "assigned but unused variable"
+          yield "#{temp_var} = #{temp_var} = #{cur_node}", temp_var
         end
       end
 

data/lib/rubocop/processed_source.rb

@@ -31,6 +31,7 @@ module RuboCop
       @path = path
       @diagnostics = []
       @ruby_version = ruby_version
+      @parser_error = nil
 
       parse(source, ruby_version)
     end

data/lib/rubocop/rspec/cop_helper.rb

@@ -12,6 +12,10 @@ module CopHelper
     Tempfile.open('tmp') { |f| inspect_source(cop, source, f) }
   end
 
+  def inspect_gemfile(cop, source)
+    inspect_source(cop, source, 'Gemfile')
+  end
+
   def inspect_source(cop, source, file = nil)
     if source.is_a?(Array) && source.size == 1
       raise "Don't use an array for a single line of code: #{source}"

data/lib/rubocop/rspec/host_environment_simulation_helper.rb

@@ -10,7 +10,7 @@ module HostEnvironmentSimulatorHelper
       pid = ::Process.fork do
         # Need to write coverage result under different name
         if defined?(SimpleCov)
-          SimpleCov.command_name "rspec_#{Process.pid}"
+          SimpleCov.coverage_dir "coverage/ignored_results_#{Process.pid}"
           SimpleCov.pid = Process.pid
         end
 

data/lib/rubocop/version.rb

@@ -3,7 +3,7 @@
 module RuboCop
   # This module holds the RuboCop version information.
   module Version
-    STRING = '0.45.0'.freeze
+    STRING = '0.46.0'.freeze
 
     MSG = '%s (using Parser %s, running on %s %s %s)'.freeze
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop
 version: !ruby/object:Gem::Version
-  version: 0.45.0
+  version: 0.46.0
 platform: ruby
 authors:
 - Bozhidar Batsov
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-10-31 00:00:00.000000000 Z
+date: 2016-11-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rainbow
@@ -146,6 +146,8 @@ files:
 - lib/rubocop/config_loader_resolver.rb
 - lib/rubocop/config_store.rb
 - lib/rubocop/cop/autocorrect_logic.rb
+- lib/rubocop/cop/bundler/duplicated_gem.rb
+- lib/rubocop/cop/bundler/ordered_gems.rb
 - lib/rubocop/cop/commissioner.rb
 - lib/rubocop/cop/cop.rb
 - lib/rubocop/cop/corrector.rb
@@ -268,6 +270,7 @@ files:
 - lib/rubocop/cop/offense.rb
 - lib/rubocop/cop/performance/case_when_splat.rb
 - lib/rubocop/cop/performance/casecmp.rb
+- lib/rubocop/cop/performance/compare_with_block.rb
 - lib/rubocop/cop/performance/count.rb
 - lib/rubocop/cop/performance/detect.rb
 - lib/rubocop/cop/performance/double_start_end_with.rb
@@ -284,7 +287,6 @@ files:
 - lib/rubocop/cop/performance/reverse_each.rb
 - lib/rubocop/cop/performance/sample.rb
 - lib/rubocop/cop/performance/size.rb
-- lib/rubocop/cop/performance/sort_with_block.rb
 - lib/rubocop/cop/performance/start_with.rb
 - lib/rubocop/cop/performance/string_replacement.rb
 - lib/rubocop/cop/performance/times_map.rb
@@ -293,6 +295,7 @@ files:
 - lib/rubocop/cop/rails/delegate.rb
 - lib/rubocop/cop/rails/delegate_allow_blank.rb
 - lib/rubocop/cop/rails/dynamic_find_by.rb
+- lib/rubocop/cop/rails/enum_uniqueness.rb
 - lib/rubocop/cop/rails/exit.rb
 - lib/rubocop/cop/rails/find_by.rb
 - lib/rubocop/cop/rails/find_each.rb
@@ -365,6 +368,7 @@ files:
 - lib/rubocop/cop/style/empty_lines_around_method_body.rb
 - lib/rubocop/cop/style/empty_lines_around_module_body.rb
 - lib/rubocop/cop/style/empty_literal.rb
+- lib/rubocop/cop/style/empty_method.rb
 - lib/rubocop/cop/style/encoding.rb
 - lib/rubocop/cop/style/end_block.rb
 - lib/rubocop/cop/style/end_of_line.rb

data/lib/rubocop/cop/performance/sort_with_block.rb

@@ -1,53 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    module Performance
-      # This cop identifies places where `sort { |a, b| a.foo <=> b.foo }`
-      # can be replaced by `sort_by(&:foo)`.
-      #
-      # @example
-      #   @bad
-      #   array.sort { |a, b| a.foo <=> b.foo }
-      #
-      #   @good
-      #   array.sort_by(&:foo)
-      #   array.sort_by { |v| v.foo }
-      #   array.sort_by do |var|
-      #     var.foo
-      #   end
-      class SortWithBlock < Cop
-        MSG = 'Use `sort_by(&:%s)` instead of ' \
-              '`sort { |%s, %s| %s.%s <=> %s.%s }`.'.freeze
-
-        def_node_matcher :sort, <<-END
-          (block $(send _ :sort) (args (arg $_a) (arg $_b)) (send (send (lvar _a) $_m) :<=> (send (lvar _b) $_m)))
-        END
-
-        def on_block(node)
-          sort(node) do |send, var_a, var_b, method|
-            range = sort_range(send, node)
-            add_offense(node, range,
-                        format(MSG, method, var_a, var_b,
-                               var_a, method, var_b, method))
-          end
-        end
-
-        def autocorrect(node)
-          send, = *node
-
-          lambda do |corrector|
-            method = node.children.last.children.last.children.last
-            corrector.replace(sort_range(send, node), "sort_by(&:#{method})")
-          end
-        end
-
-        private
-
-        def sort_range(send, node)
-          range_between(send.loc.selector.begin_pos, node.loc.end.end_pos)
-        end
-      end
-    end
-  end
-end