rubocop 0.41.2 → 0.42.0

data/lib/rubocop/node_pattern.rb

@@ -134,6 +134,7 @@ module RuboCop
         fail_due_to('unbalanced pattern') unless tokens.empty?
       end
 
+      # rubocop:disable Metrics/MethodLength, Metrics/AbcSize
       def compile_expr(tokens, cur_node, seq_head)
         # read a single pattern-matching expression from the token stream,
         # return Ruby code which performs the corresponding matching operation
@@ -160,6 +161,7 @@ module RuboCop
         else fail_due_to("invalid token #{token.inspect}")
         end
       end
+      # rubocop:enable Metrics/MethodLength, Metrics/AbcSize
 
       def compile_seq(tokens, cur_node, seq_head)
         fail_due_to('empty parentheses') if tokens.first == ')'

data/lib/rubocop/processed_source.rb

@@ -120,6 +120,9 @@ module RuboCop
       when 2.3
         require 'parser/ruby23'
         Parser::Ruby23
+      when 2.4
+        require 'parser/ruby24'
+        Parser::Ruby24
       else
         raise ArgumentError, "Unknown Ruby version: #{ruby_version.inspect}"
       end

data/lib/rubocop/rake_task.rb

@@ -47,7 +47,7 @@ module RuboCop
       cli = CLI.new
       puts 'Running RuboCop...' if verbose
       result = cli.run(options)
-      abort('RuboCop failed!') if result != 0 && fail_on_error
+      abort('RuboCop failed!') if result.nonzero? && fail_on_error
     end
 
     def full_options

data/lib/rubocop/rspec/shared_contexts.rb

@@ -73,3 +73,7 @@ end
 shared_context 'ruby 2.3', :ruby23 do
   let(:ruby_version) { 2.3 }
 end
+
+shared_context 'ruby 2.4', :ruby24 do
+  let(:ruby_version) { 2.4 }
+end

data/lib/rubocop/runner.rb

@@ -79,21 +79,32 @@ module RuboCop
       puts "Scanning #{file}" if @options[:debug]
       file_started(file)
 
+      offenses = file_offenses(file)
+      formatter_set.file_finished(file, offenses)
+      offenses
+    rescue InfiniteCorrectionLoop => e
+      formatter_set.file_finished(file, e.offenses.compact.sort.freeze)
+      raise
+    end
+
+    def file_offenses(file)
+      file_offense_cache(file) do
+        source = get_processed_source(file)
+        source, offenses = do_inspection_loop(file, source)
+        add_unneeded_disables(file, offenses.compact.sort, source)
+      end
+    end
+
+    def file_offense_cache(file)
       cache = ResultCache.new(file, @options, @config_store) if cached_run?
       if cache && cache.valid?
         offenses = cache.load
       else
-        source = get_processed_source(file)
-        source, offenses = do_inspection_loop(file, source)
-        offenses = add_unneeded_disables(file, offenses.compact.sort, source)
+        offenses = yield
         save_in_cache(cache, offenses)
       end
 
-      formatter_set.file_finished(file, offenses)
       offenses
-    rescue InfiniteCorrectionLoop => e
-      formatter_set.file_finished(file, e.offenses.compact.sort.freeze)
-      raise
     end
 
     def add_unneeded_disables(file, offenses, source)

data/lib/rubocop/string_util.rb

@@ -55,12 +55,9 @@ module RuboCop
         common_chars_of_shorter = Array.new(shorter.size)
         common_chars_of_longer = Array.new(longer.size)
 
-        # In Ruby 1.9 String#chars returns Enumerator rather than Array.
-        longer_chars = longer.each_char.to_a
-
         shorter.each_char.with_index do |shorter_char, shorter_index|
           matching_index_range(shorter_index).each do |longer_index|
-            longer_char = longer_chars[longer_index]
+            longer_char = longer.chars[longer_index]
 
             next unless shorter_char == longer_char
 
@@ -68,7 +65,7 @@ module RuboCop
             common_chars_of_longer[longer_index] = longer_char
 
             # Mark the matching character as already used
-            longer_chars[longer_index] = nil
+            longer.chars[longer_index] = nil
 
             break
           end

data/lib/rubocop/version.rb

@@ -4,7 +4,7 @@
 module RuboCop
   # This module holds the RuboCop version information.
   module Version
-    STRING = '0.41.2'.freeze
+    STRING = '0.42.0'.freeze
 
     MSG = '%s (using Parser %s, running on %s %s %s)'.freeze
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop
 version: !ruby/object:Gem::Version
-  version: 0.41.2
+  version: 0.42.0
 platform: ruby
 authors:
 - Bozhidar Batsov
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-07-07 00:00:00.000000000 Z
+date: 2016-07-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rainbow
@@ -290,6 +290,7 @@ files:
 - lib/rubocop/cop/rails/pluralization_grammar.rb
 - lib/rubocop/cop/rails/read_write_attribute.rb
 - lib/rubocop/cop/rails/request_referer.rb
+- lib/rubocop/cop/rails/save_bang.rb
 - lib/rubocop/cop/rails/scope_args.rb
 - lib/rubocop/cop/rails/time_zone.rb
 - lib/rubocop/cop/rails/uniq_before_pluck.rb
@@ -386,6 +387,7 @@ files:
 - lib/rubocop/cop/style/method_call_parentheses.rb
 - lib/rubocop/cop/style/method_called_on_do_end_block.rb
 - lib/rubocop/cop/style/method_def_parentheses.rb
+- lib/rubocop/cop/style/method_missing.rb
 - lib/rubocop/cop/style/method_name.rb
 - lib/rubocop/cop/style/missing_else.rb
 - lib/rubocop/cop/style/module_function.rb
@@ -412,6 +414,7 @@ files:
 - lib/rubocop/cop/style/not.rb
 - lib/rubocop/cop/style/numeric_literal_prefix.rb
 - lib/rubocop/cop/style/numeric_literals.rb
+- lib/rubocop/cop/style/numeric_predicate.rb
 - lib/rubocop/cop/style/one_line_conditional.rb
 - lib/rubocop/cop/style/op_method.rb
 - lib/rubocop/cop/style/option_hash.rb
@@ -472,6 +475,7 @@ files:
 - lib/rubocop/cop/style/symbol_literal.rb
 - lib/rubocop/cop/style/symbol_proc.rb
 - lib/rubocop/cop/style/tab.rb
+- lib/rubocop/cop/style/ternary_parentheses.rb
 - lib/rubocop/cop/style/trailing_blank_lines.rb
 - lib/rubocop/cop/style/trailing_comma_in_arguments.rb
 - lib/rubocop/cop/style/trailing_comma_in_literal.rb
@@ -547,7 +551,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 1.9.3
+      version: 2.0.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="