rubocop 0.40.0 → 0.41.0

data/config/default.yml

@@ -25,6 +25,8 @@ AllCops:
     - '**/Berksfile'
     - '**/Cheffile'
     - '**/Vagabondfile'
+    - '**/Fastfile'
+    - '**/*Fastfile'
   Exclude:
     - 'vendor/**/*'
   # Default formatter will be used if no -f/--format option is given.
@@ -63,6 +65,14 @@ AllCops:
   # which is "/tmp" on Unix-like systems, but could be something else on other
   # systems.
   CacheRootDirectory: /tmp
+  # The default cache root directory is /tmp, which on most systems is
+  # writable by any system user. This means that it is possible for a
+  # malicious user to anticipate the location of Rubocop's cache directory,
+  # and create a symlink in its place that could cause Rubocop to overwrite
+  # unintended files, or read malicious input. If you are certain that your
+  # cache location is secure from this kind of attack, and wish to use a
+  # symlinked cache location, set this value to "true".
+  AllowSymlinksInCacheRootDirectory: false
   # What version of the Ruby interpreter is the inspected code intended to
   # run on? (If there is more than one, set this to the lowest version.)
   TargetRubyVersion: 2.0
@@ -165,6 +175,9 @@ Style/AlignParameters:
   SupportedStyles:
     - with_first_parameter
     - with_fixed_indentation
+  # By default, the indentation width from Style/IndentationWidth is used
+  # But it can be overridden by setting this parameter
+  IndentationWidth: ~
 
 Style/AndOr:
   # Whether `and` and `or` are banned only in conditionals (conditionals)
@@ -519,8 +532,10 @@ Style/HashSyntax:
     - ruby19
     - ruby19_no_mixed_keys
     - hash_rockets
-# Force hashes that have a symbol value to use hash rockets
+  # Force hashes that have a symbol value to use hash rockets
   UseHashRocketsWithSymbolValues: false
+  # Do not suggest { a?: 1 } over { :a? => 1 } in ruby19 style
+  PreferHashRocketsForNonAlnumEndingSymbols: false
 
 Style/IfUnlessModifier:
   MaxLineLength: 80
@@ -638,6 +653,12 @@ Style/MethodName:
     - snake_case
     - camelCase
 
+Style/ModuleFunction:
+  EnforcedStyle: module_function
+  SupportedStyles:
+    - module_function
+    - extend_self
+
 Style/MultilineArrayBraceLayout:
   EnforcedStyle: symmetrical
   SupportedStyles:
@@ -691,6 +712,7 @@ Style/MultilineMethodCallIndentation:
   SupportedStyles:
     - aligned
     - indented
+    - indented_relative_to_receiver
   # By default, the indentation width from Style/IndentationWidth is used
   # But it can be overridden by setting this parameter
   IndentationWidth: ~
@@ -717,6 +739,12 @@ Style/MultilineOperationIndentation:
 Style/NumericLiterals:
   MinDigits: 5
 
+Style/NumericLiteralPrefix:
+  EnforcedOctalStyle: zero_with_o
+  SupportedOctalStyles:
+    - zero_with_o
+    - zero_only
+
 Style/OptionHash:
   # A list of parameter names that will be flagged by this cop.
   SuspiciousParamNames:
@@ -898,6 +926,9 @@ Style/SpaceInsideHashLiteralBraces:
   SupportedStyles:
     - space
     - no_space
+    # 'compact' normally requires a space inside hash braces, with the exception
+    # that successive left braces or right braces are collapsed together
+    - compact
 
 Style/SpaceInsideStringInterpolation:
   EnforcedStyle: no_space
@@ -1101,19 +1132,23 @@ Lint/DefEndAlignment:
     - def
   AutoCorrect: false
 
+Lint/InheritException:
+  # The default base class in favour of `Exception`.
+  EnforcedStyle: runtime_error
+  SupportedStyles:
+    - runtime_error
+    - standard_error
+
 # Checks for unused block arguments
 Lint/UnusedBlockArgument:
   IgnoreEmptyBlocks: true
+  AllowUnusedKeywordArguments: false
 
 # Checks for unused method arguments.
 Lint/UnusedMethodArgument:
   AllowUnusedKeywordArguments: false
   IgnoreEmptyMethods: true
 
-# Checks for unused block arguments.
-Lint/UnusedBlockArgument:
-  AllowUnusedKeywordArguments: false
-
 ##################### Performance ############################
 
 Performance/RedundantMerge:
@@ -1141,6 +1176,14 @@ Rails/Date:
     - strict
     - flexible
 
+Rails/Exit:
+  Include:
+    - app/**/*.rb
+    - config/**/*.rb
+    - lib/**/*.rb
+  Exclude:
+    - lib/**/*.rake
+
 Rails/FindBy:
   Include:
     - app/models/**/*.rb
@@ -1164,6 +1207,12 @@ Rails/ReadWriteAttribute:
   Include:
     - app/models/**/*.rb
 
+Rails/RequestReferer:
+  EnforcedStyle: referer
+  SupportedStyles:
+    - referer
+    - referrer
+
 Rails/ScopeArgs:
   Include:
     - app/models/**/*.rb
@@ -1176,6 +1225,13 @@ Rails/TimeZone:
     - strict
     - flexible
 
+Rails/UniqBeforePluck:
+  EnforcementMode: conservative
+  SupportedModes:
+    - conservative
+    - aggressive
+  AutoCorrect: false
+
 Rails/Validation:
   Include:
     - app/models/**/*.rb

data/config/disabled.yml

@@ -47,6 +47,12 @@ Style/FirstMethodParameterLineBreak:
                  multi-line method parameter definition.
   Enabled: false
 
+Style/ImplicitRuntimeError:
+  Description: >-
+                 Use `raise` or `fail` with an explicit exception class and
+                 message, rather than just a message.
+  Enabled: false
+
 Style/InlineComment:
   Description: 'Avoid inline comments.'
   Enabled: false

data/config/enabled.yml

@@ -7,6 +7,7 @@ Style/AccessModifierIndentation:
 
 Style/AccessorMethodName:
   Description: Check the naming of accessor methods for get_/set_.
+  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#accessor_mutator_method_names'
   Enabled: true
 
 Style/Alias:
@@ -170,8 +171,8 @@ Style/DefWithParentheses:
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#method-parens'
   Enabled: true
 
-Style/DeprecatedHashMethods:
-  Description: 'Checks for use of deprecated Hash methods.'
+Style/PreferredHashMethods:
+  Description: 'Checks use of `has_key?` and `has_value?` Hash methods.'
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#hash-key'
   Enabled: true
 
@@ -192,6 +193,12 @@ Style/DoubleNegation:
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-bang-bang'
   Enabled: true
 
+Style/EachForSimpleLoop:
+  Description: >-
+                 Use `Integer#times` for a simple loop which iterates a fixed
+                 number of times.
+  Enabled: true
+
 Style/EachWithObject:
   Description: 'Prefer `each_with_object` over `inject` or `reduce`.'
   Enabled: true
@@ -535,6 +542,11 @@ Style/NumericLiterals:
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#underscores-in-numerics'
   Enabled: true
 
+Style/NumericLiteralPrefix:
+  Description: 'Use smallcase prefixes for numeric literals.'
+  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#numeric-literal-prefixes'
+  Enabled: true
+
 Style/OneLineConditional:
   Description: >-
                  Favor the ternary operator(?:) over
@@ -748,6 +760,14 @@ Style/SpaceAroundOperators:
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#spaces-operators'
   Enabled: true
 
+Style/SpaceInsideArrayPercentLiteral:
+  Description: 'No unnecessary additional spaces between elements in %i/%w literals.'
+  Enabled: true
+
+Style/SpaceInsidePercentLiteralDelimiters:
+  Description: 'No unnecessary spaces inside delimiters of %i/%w/%x literals.'
+  Enabled: true
+
 Style/SpaceInsideBrackets:
   Description: 'No spaces after [ or before ].'
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-spaces-braces'
@@ -819,7 +839,7 @@ Style/TrailingBlankLines:
 
 Style/TrailingCommaInArguments:
   Description: 'Checks for trailing comma in argument lists.'
-  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-trailing-array-commas'
+  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-trailing-params-comma'
   Enabled: true
 
 Style/TrailingCommaInLiteral:
@@ -1067,6 +1087,10 @@ Lint/IneffectiveAccessModifier:
                  the visibility of a class method, which does not work.
   Enabled: true
 
+Lint/InheritException:
+  Description: 'Avoid inheriting from the `Exception` class.'
+  Enabled: true
+
 Lint/InvalidCharacterLiteral:
   Description: >-
                  Checks for invalid character literals with a non-escaped
@@ -1110,6 +1134,16 @@ Lint/ParenthesesAsGroupedExpression:
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#parens-no-spaces'
   Enabled: true
 
+Lint/PercentStringArray:
+  Description: >-
+                 Checks for unwanted commas and quotes in %w/%W literals.
+  Enabled: true
+
+Lint/PercentSymbolArray:
+  Description: >-
+                 Checks for unwanted commas and colons in %i/%I literals.
+  Enabled: true
+
 Lint/RandOne:
   Description: >-
                  Checks for `rand(1)` calls. Such calls always return `0`
@@ -1127,6 +1161,12 @@ Lint/RescueException:
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-blind-rescues'
   Enabled: true
 
+Lint/ShadowedException:
+  Description: >-
+                  Avoid rescuing a higher level exception
+                  before a lower level exception.
+  Enabled: true
+
 Lint/ShadowingOuterLocalVariable:
   Description: >-
                  Do not use the same name as outer local variable
@@ -1270,6 +1310,10 @@ Performance/LstripRstrip:
   Description: 'Use `strip` instead of `lstrip.rstrip`.'
   Enabled: true
 
+Performance/PushSplat:
+  Description: 'Use `concat` instead of `push(*)`.'
+  Enabled: true
+
 Performance/RangeInclude:
   Description: 'Use `Range#cover?` instead of `Range#include?`.'
   Reference: 'https://github.com/JuanitoFatas/fast-ruby#cover-vs-include-code'
@@ -1347,6 +1391,13 @@ Rails/Delegate:
   Description: 'Prefer delegate method for delegations.'
   Enabled: true
 
+Rails/Exit:
+  Description: >-
+                  Favor `fail`, `break`, `return`, etc. over `exit` in
+                  application or library code outside of Rake files to avoid
+                  exits during unit testing or running in production.
+  Enabled: true
+
 Rails/FindBy:
   Description: 'Prefer find_by over where.first.'
   Enabled: true
@@ -1363,6 +1414,10 @@ Rails/Output:
   Description: 'Checks for calls to puts, print, etc.'
   Enabled: true
 
+Rails/OutputSafety:
+  Description: 'The use of `html_safe` or `raw` may be a security risk.'
+  Enabled: true
+
 Rails/PluralizationGrammar:
   Description: 'Checks for incorrect grammar when using methods like `3.day.ago`.'
   Enabled: true
@@ -1373,6 +1428,10 @@ Rails/ReadWriteAttribute:
                  write_attribute(:attr, val).
   Enabled: true
 
+Rails/RequestReferer:
+  Description: 'Use consistent syntax for request.referer.'
+  Enabled: true
+
 Rails/ScopeArgs:
   Description: 'Checks the arguments of ActiveRecord scopes.'
   Enabled: true
@@ -1384,7 +1443,7 @@ Rails/TimeZone:
   Enabled: true
 
 Rails/UniqBeforePluck:
-  Description: 'Prefer the use of uniq before pluck.'
+  Description: 'Prefer the use of uniq or distinct before pluck.'
   Enabled: true
 
 Rails/Validation:

data/lib/rubocop.rb

@@ -19,6 +19,7 @@ require 'rubocop/path_util'
 require 'rubocop/string_util'
 require 'rubocop/name_similarity'
 require 'rubocop/node_pattern'
+require 'rubocop/string_interpreter'
 require 'rubocop/ast_node/sexp'
 require 'rubocop/ast_node'
 require 'rubocop/ast_node/builder'
@@ -61,7 +62,9 @@ require 'rubocop/cop/mixin/first_element_line_break'
 require 'rubocop/cop/mixin/frozen_string_literal'
 require 'rubocop/cop/mixin/hash_node'
 require 'rubocop/cop/mixin/if_node'
+require 'rubocop/cop/mixin/integer_node'
 require 'rubocop/cop/mixin/on_method_def'
+require 'rubocop/cop/mixin/match_range'
 require 'rubocop/cop/mixin/method_complexity' # relies on on_method_def
 require 'rubocop/cop/mixin/method_preference'
 require 'rubocop/cop/mixin/min_body_length'
@@ -107,6 +110,7 @@ require 'rubocop/cop/lint/float_out_of_range'
 require 'rubocop/cop/lint/format_parameter_mismatch'
 require 'rubocop/cop/lint/handle_exceptions'
 require 'rubocop/cop/lint/implicit_string_concatenation'
+require 'rubocop/cop/lint/inherit_exception'
 require 'rubocop/cop/lint/ineffective_access_modifier'
 require 'rubocop/cop/lint/invalid_character_literal'
 require 'rubocop/cop/lint/literal_in_condition'
@@ -116,9 +120,12 @@ require 'rubocop/cop/lint/nested_method_definition'
 require 'rubocop/cop/lint/next_without_accumulator'
 require 'rubocop/cop/lint/non_local_exit_from_iterator'
 require 'rubocop/cop/lint/parentheses_as_grouped_expression'
+require 'rubocop/cop/lint/percent_string_array'
+require 'rubocop/cop/lint/percent_symbol_array'
 require 'rubocop/cop/lint/rand_one'
 require 'rubocop/cop/lint/require_parentheses'
 require 'rubocop/cop/lint/rescue_exception'
+require 'rubocop/cop/lint/shadowed_exception'
 require 'rubocop/cop/lint/shadowing_outer_local_variable'
 require 'rubocop/cop/lint/string_conversion_in_interpolation'
 require 'rubocop/cop/lint/syntax'
@@ -155,6 +162,7 @@ require 'rubocop/cop/performance/fixed_size'
 require 'rubocop/cop/performance/flat_map'
 require 'rubocop/cop/performance/hash_each'
 require 'rubocop/cop/performance/lstrip_rstrip'
+require 'rubocop/cop/performance/push_splat'
 require 'rubocop/cop/performance/range_include'
 require 'rubocop/cop/performance/redundant_block_call'
 require 'rubocop/cop/performance/redundant_match'
@@ -203,10 +211,11 @@ require 'rubocop/cop/style/conditional_assignment'
 require 'rubocop/cop/style/constant_name'
 require 'rubocop/cop/style/copyright'
 require 'rubocop/cop/style/def_with_parentheses'
-require 'rubocop/cop/style/deprecated_hash_methods'
+require 'rubocop/cop/style/preferred_hash_methods'
 require 'rubocop/cop/style/documentation'
 require 'rubocop/cop/style/dot_position'
 require 'rubocop/cop/style/double_negation'
+require 'rubocop/cop/style/each_for_simple_loop'
 require 'rubocop/cop/style/each_with_object'
 require 'rubocop/cop/style/else_alignment'
 require 'rubocop/cop/style/empty_case_condition'
@@ -242,6 +251,7 @@ require 'rubocop/cop/style/if_inside_else'
 require 'rubocop/cop/style/if_unless_modifier'
 require 'rubocop/cop/style/if_unless_modifier_of_if_unless'
 require 'rubocop/cop/style/if_with_semicolon'
+require 'rubocop/cop/style/implicit_runtime_error'
 require 'rubocop/cop/style/indent_array'
 require 'rubocop/cop/style/indent_assignment'
 require 'rubocop/cop/style/indent_hash'
@@ -282,6 +292,7 @@ require 'rubocop/cop/style/nil_comparison'
 require 'rubocop/cop/style/non_nil_check'
 require 'rubocop/cop/style/not'
 require 'rubocop/cop/style/numeric_literals'
+require 'rubocop/cop/style/numeric_literal_prefix'
 require 'rubocop/cop/style/one_line_conditional'
 require 'rubocop/cop/style/op_method'
 require 'rubocop/cop/style/option_hash'
@@ -323,10 +334,12 @@ require 'rubocop/cop/style/space_before_comma'
 require 'rubocop/cop/style/space_before_comment'
 require 'rubocop/cop/style/space_before_first_arg'
 require 'rubocop/cop/style/space_before_semicolon'
+require 'rubocop/cop/style/space_inside_array_percent_literal'
 require 'rubocop/cop/style/space_inside_block_braces'
 require 'rubocop/cop/style/space_inside_brackets'
 require 'rubocop/cop/style/space_inside_hash_literal_braces'
 require 'rubocop/cop/style/space_inside_parens'
+require 'rubocop/cop/style/space_inside_percent_literal_delimiters'
 require 'rubocop/cop/style/space_inside_range_literal'
 require 'rubocop/cop/style/space_inside_string_interpolation'
 require 'rubocop/cop/style/special_global_vars'
@@ -360,12 +373,15 @@ require 'rubocop/cop/style/zero_length_predicate'
 require 'rubocop/cop/rails/action_filter'
 require 'rubocop/cop/rails/date'
 require 'rubocop/cop/rails/delegate'
+require 'rubocop/cop/rails/exit'
 require 'rubocop/cop/rails/find_by'
 require 'rubocop/cop/rails/find_each'
 require 'rubocop/cop/rails/has_and_belongs_to_many'
+require 'rubocop/cop/rails/output_safety'
 require 'rubocop/cop/rails/output'
 require 'rubocop/cop/rails/pluralization_grammar'
 require 'rubocop/cop/rails/read_write_attribute'
+require 'rubocop/cop/rails/request_referer'
 require 'rubocop/cop/rails/scope_args'
 require 'rubocop/cop/rails/time_zone'
 require 'rubocop/cop/rails/uniq_before_pluck'

data/lib/rubocop/ast_node.rb

@@ -323,55 +323,17 @@ module RuboCop
       # returns nil if answer cannot be determined
       ancestors = each_ancestor(:class, :module, :sclass, :casgn, :block)
       result    = ancestors.map do |ancestor|
-        case ancestor.type
-        when :class, :module, :casgn
-          # TODO: if constant name has cbase (leading ::), then we don't need
-          # to keep traversing up through nested classes/modules
-          ancestor.defined_module_name
-        when :sclass
-          return parent_module_name_for_sclass(ancestor)
-        else # block
-          if ancestor.method_name == :class_eval
-            # `class_eval` with no receiver applies to whatever module or class
-            # we are currently in
-            next unless (receiver = ancestor.receiver)
-            return nil unless receiver.const_type?
-            receiver.const_name
-          elsif new_class_or_module_block?(ancestor)
-            # we will catch this in the `casgn` branch above
-            next
-          else
-            return nil
-          end
-        end
+        parent_module_name_part(ancestor) { |full_name| return full_name }
       end.compact.reverse.join('::')
       result.empty? ? 'Object' : result
     end
 
-    def parent_module_name_for_sclass(sclass_node)
-      # TODO: look for constant definition and see if it is nested
-      # inside a class or module
-      subject = sclass_node.children[0]
-
-      if subject.const_type?
-        "#<Class:#{subject.const_name}>"
-      elsif subject.self_type?
-        "#<Class:#{sclass_node.parent_module_name}>"
-      end
-    end
-
-    def new_class_or_module_block?(block_node)
-      receiver = block_node.receiver
+    ## Predicates
 
-      block_node.method_name == :new &&
-        receiver && receiver.const_type? &&
-        (receiver.const_name == 'Class' || receiver.const_name == 'Module') &&
-        block_node.parent &&
-        block_node.parent.casgn_type?
+    def modifier_form?
+      loc.respond_to?(:end) && loc.end.nil?
     end
 
-    ## Predicates
-
     def multiline?
       expr = loc.expression
       expr && (expr.first_line != expr.last_line)
@@ -456,6 +418,11 @@ module RuboCop
       args.empty? && method_name == :! && loc.selector.is?('not'.freeze)
     end
 
+    def keyword_bang?
+      _receiver, method_name, *args = *self
+      args.empty? && method_name == :! && loc.selector.is?('!'.freeze)
+    end
+
     def unary_operation?
       return false unless loc.respond_to?(:selector) && loc.selector
       Cop::Util.operator?(loc.selector.source.to_sym) &&
@@ -604,5 +571,52 @@ module RuboCop
       # (while <condition> <body>) -> always evaluates to `nil`
       sibling_index == 0
     end
+
+    def parent_module_name_part(node)
+      case node.type
+      when :class, :module, :casgn
+        # TODO: if constant name has cbase (leading ::), then we don't need
+        # to keep traversing up through nested classes/modules
+        node.defined_module_name
+      when :sclass
+        yield parent_module_name_for_sclass(node)
+      else # block
+        parent_module_name_for_block(node) { yield nil }
+      end
+    end
+
+    def parent_module_name_for_sclass(sclass_node)
+      # TODO: look for constant definition and see if it is nested
+      # inside a class or module
+      subject = sclass_node.children[0]
+
+      if subject.const_type?
+        "#<Class:#{subject.const_name}>"
+      elsif subject.self_type?
+        "#<Class:#{sclass_node.parent_module_name}>"
+      end
+    end
+
+    def parent_module_name_for_block(ancestor)
+      if ancestor.method_name == :class_eval
+        # `class_eval` with no receiver applies to whatever module or class
+        # we are currently in
+        return unless (receiver = ancestor.receiver)
+        yield unless receiver.const_type?
+        receiver.const_name
+      elsif !new_class_or_module_block?(ancestor)
+        yield
+      end
+    end
+
+    def new_class_or_module_block?(block_node)
+      receiver = block_node.receiver
+
+      block_node.method_name == :new &&
+        receiver && receiver.const_type? &&
+        (receiver.const_name == 'Class' || receiver.const_name == 'Module') &&
+        block_node.parent &&
+        block_node.parent.casgn_type?
+    end
   end
 end