rubocop 0.4.1 → 0.4.2

data/.rubocop.yml

@@ -177,4 +177,8 @@ AvoidPerlisms:
 
 # Avoid Perl-style regex back references.
 AvoidPerlBackrefs:
+  Enabled: true
+
+# Avoid the use of class variables.
+AvoidClassVars:
   Enabled: true

data/VERSION

@@ -1 +1 @@
-0.4.1
+0.4.2

data/lib/rubocop.rb

@@ -41,6 +41,7 @@ require 'rubocop/cop/collection_methods'
 require 'rubocop/cop/avoid_for'
 require 'rubocop/cop/avoid_perlisms'
 require 'rubocop/cop/avoid_perl_backrefs'
+require 'rubocop/cop/avoid_class_vars'
 
 require 'rubocop/report/report'
 require 'rubocop/report/plain_text'

data/lib/rubocop/cop/avoid_class_vars.rb

@@ -0,0 +1,20 @@
+# encoding: utf-8
+
+module Rubocop
+  module Cop
+    class AvoidClassVars < Cop
+      def inspect(file, source, tokens, sexp)
+        each(:@cvar, sexp) do |s|
+          class_var = s[1]
+          lineno = s[2].lineno
+
+          add_offence(
+            :convention,
+            lineno,
+            "Replace class var #{class_var} with a class instance var."
+          )
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/version.rb

@@ -1,5 +1,5 @@
 # encoding: utf-8
 
 module Rubocop
-  VERSION = '0.3.2'
+  VERSION = '0.4.2'
 end

data/rubocop.gemspec

@@ -5,7 +5,7 @@
 
 Gem::Specification.new do |s|
   s.name = "rubocop"
-  s.version = "0.4.1"
+  s.version = "0.4.2"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Bozhidar Batsov"]
@@ -34,6 +34,7 @@ Gem::Specification.new do |s|
     "lib/rubocop/cli.rb",
     "lib/rubocop/cop/align_parameters.rb",
     "lib/rubocop/cop/ampersands_pipes_vs_and_or.rb",
+    "lib/rubocop/cop/avoid_class_vars.rb",
     "lib/rubocop/cop/avoid_for.rb",
     "lib/rubocop/cop/avoid_perl_backrefs.rb",
     "lib/rubocop/cop/avoid_perlisms.rb",
@@ -75,6 +76,7 @@ Gem::Specification.new do |s|
     "spec/rubocop/cli_spec.rb",
     "spec/rubocop/cops/align_parameters_spec.rb",
     "spec/rubocop/cops/ampersands_pipes_vs_and_or_spec.rb",
+    "spec/rubocop/cops/avoid_class_vars_spec.rb",
     "spec/rubocop/cops/avoid_for_spec.rb",
     "spec/rubocop/cops/avoid_perl_backrefs_spec.rb",
     "spec/rubocop/cops/avoid_perlisms_spec.rb",

data/spec/rubocop/cops/avoid_class_vars_spec.rb

@@ -0,0 +1,20 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+module Rubocop
+  module Cop
+    describe AvoidClassVars do
+      let(:acv) { AvoidClassVars.new }
+
+      it 'registers an offence for class variables' do
+        inspect_source(acv,
+                       'file.rb',
+                       ['class TestClass; @@test = 10; end'])
+        expect(acv.offences.size).to eq(1)
+        expect(acv.offences.map(&:message))
+          .to eq(['Replace class var @@test with a class instance var.'])
+      end
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop
 version: !ruby/object:Gem::Version
-  version: 0.4.1
+  version: 0.4.2
   prerelease: 
 platform: ruby
 authors:
@@ -149,6 +149,7 @@ files:
 - lib/rubocop/cli.rb
 - lib/rubocop/cop/align_parameters.rb
 - lib/rubocop/cop/ampersands_pipes_vs_and_or.rb
+- lib/rubocop/cop/avoid_class_vars.rb
 - lib/rubocop/cop/avoid_for.rb
 - lib/rubocop/cop/avoid_perl_backrefs.rb
 - lib/rubocop/cop/avoid_perlisms.rb
@@ -190,6 +191,7 @@ files:
 - spec/rubocop/cli_spec.rb
 - spec/rubocop/cops/align_parameters_spec.rb
 - spec/rubocop/cops/ampersands_pipes_vs_and_or_spec.rb
+- spec/rubocop/cops/avoid_class_vars_spec.rb
 - spec/rubocop/cops/avoid_for_spec.rb
 - spec/rubocop/cops/avoid_perl_backrefs_spec.rb
 - spec/rubocop/cops/avoid_perlisms_spec.rb
@@ -252,7 +254,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -395662942126839838
+      hash: 3258861329978794858
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements: