rubocop 0.35.1 → 0.36.0
Sign up to get free protection for your applications and to get access to all the features.
Potentially problematic release.
This version of rubocop might be problematic. Click here for more details.
- checksums.yaml +4 -4
- data/CHANGELOG.md +164 -0
- data/LICENSE.txt +1 -1
- data/README.md +72 -21
- data/bin/rubocop +1 -0
- data/config/default.yml +167 -18
- data/config/disabled.yml +19 -6
- data/config/enabled.yml +159 -14
- data/lib/rubocop.rb +67 -26
- data/lib/rubocop/ast_node.rb +488 -14
- data/lib/rubocop/ast_node/builder.rb +24 -0
- data/lib/rubocop/ast_node/sexp.rb +13 -0
- data/lib/rubocop/cached_data.rb +58 -0
- data/lib/rubocop/cli.rb +47 -10
- data/lib/rubocop/comment_config.rb +9 -2
- data/lib/rubocop/config.rb +99 -31
- data/lib/rubocop/config_loader.rb +23 -14
- data/lib/rubocop/config_store.rb +1 -0
- data/lib/rubocop/cop/autocorrect_logic.rb +2 -1
- data/lib/rubocop/cop/commissioner.rb +3 -5
- data/lib/rubocop/cop/cop.rb +23 -17
- data/lib/rubocop/cop/corrector.rb +25 -0
- data/lib/rubocop/cop/force.rb +1 -0
- data/lib/rubocop/cop/ignored_node.rb +3 -2
- data/lib/rubocop/cop/lint/ambiguous_operator.rb +2 -1
- data/lib/rubocop/cop/lint/ambiguous_regexp_literal.rb +2 -1
- data/lib/rubocop/cop/lint/assignment_in_condition.rb +4 -3
- data/lib/rubocop/cop/lint/block_alignment.rb +29 -91
- data/lib/rubocop/cop/lint/circular_argument_reference.rb +2 -1
- data/lib/rubocop/cop/lint/condition_position.rb +2 -1
- data/lib/rubocop/cop/lint/debugger.rb +29 -12
- data/lib/rubocop/cop/lint/def_end_alignment.rb +16 -18
- data/lib/rubocop/cop/lint/deprecated_class_methods.rb +6 -6
- data/lib/rubocop/cop/lint/duplicate_methods.rb +98 -74
- data/lib/rubocop/cop/lint/duplicated_key.rb +3 -2
- data/lib/rubocop/cop/lint/each_with_object_argument.rb +3 -2
- data/lib/rubocop/cop/lint/else_layout.rb +2 -1
- data/lib/rubocop/cop/lint/empty_ensure.rb +2 -1
- data/lib/rubocop/cop/lint/empty_interpolation.rb +2 -1
- data/lib/rubocop/cop/lint/end_alignment.rb +77 -39
- data/lib/rubocop/cop/lint/end_in_method.rb +2 -1
- data/lib/rubocop/cop/lint/ensure_return.rb +2 -1
- data/lib/rubocop/cop/lint/eval.rb +2 -1
- data/lib/rubocop/cop/lint/float_out_of_range.rb +31 -0
- data/lib/rubocop/cop/lint/format_parameter_mismatch.rb +14 -30
- data/lib/rubocop/cop/lint/handle_exceptions.rb +2 -1
- data/lib/rubocop/cop/lint/implicit_string_concatenation.rb +85 -0
- data/lib/rubocop/cop/lint/ineffective_access_modifier.rb +120 -0
- data/lib/rubocop/cop/lint/invalid_character_literal.rb +3 -1
- data/lib/rubocop/cop/lint/literal_in_condition.rb +6 -9
- data/lib/rubocop/cop/lint/literal_in_interpolation.rb +6 -9
- data/lib/rubocop/cop/lint/loop.rb +2 -1
- data/lib/rubocop/cop/lint/nested_method_definition.rb +19 -3
- data/lib/rubocop/cop/lint/next_without_accumulator.rb +38 -0
- data/lib/rubocop/cop/lint/non_local_exit_from_iterator.rb +5 -8
- data/lib/rubocop/cop/lint/parentheses_as_grouped_expression.rb +8 -6
- data/lib/rubocop/cop/lint/rand_one.rb +36 -0
- data/lib/rubocop/cop/lint/require_parentheses.rb +6 -5
- data/lib/rubocop/cop/lint/rescue_exception.rb +3 -2
- data/lib/rubocop/cop/lint/shadowing_outer_local_variable.rb +2 -1
- data/lib/rubocop/cop/lint/string_conversion_in_interpolation.rb +6 -4
- data/lib/rubocop/cop/lint/syntax.rb +9 -5
- data/lib/rubocop/cop/lint/underscore_prefixed_variable_name.rb +3 -2
- data/lib/rubocop/cop/lint/unneeded_disable.rb +121 -18
- data/lib/rubocop/cop/lint/unreachable_code.rb +5 -4
- data/lib/rubocop/cop/lint/unused_block_argument.rb +9 -7
- data/lib/rubocop/cop/lint/unused_method_argument.rb +2 -1
- data/lib/rubocop/cop/lint/useless_access_modifier.rb +56 -29
- data/lib/rubocop/cop/lint/useless_assignment.rb +4 -16
- data/lib/rubocop/cop/lint/useless_comparison.rb +3 -2
- data/lib/rubocop/cop/lint/useless_else_without_rescue.rb +2 -1
- data/lib/rubocop/cop/lint/useless_setter_call.rb +14 -20
- data/lib/rubocop/cop/lint/void.rb +10 -11
- data/lib/rubocop/cop/metrics/abc_size.rb +3 -1
- data/lib/rubocop/cop/metrics/block_nesting.rb +2 -1
- data/lib/rubocop/cop/metrics/class_length.rb +1 -0
- data/lib/rubocop/cop/metrics/cyclomatic_complexity.rb +4 -2
- data/lib/rubocop/cop/metrics/line_length.rb +35 -13
- data/lib/rubocop/cop/metrics/method_length.rb +2 -1
- data/lib/rubocop/cop/metrics/module_length.rb +1 -0
- data/lib/rubocop/cop/metrics/parameter_lists.rb +2 -1
- data/lib/rubocop/cop/metrics/perceived_complexity.rb +4 -2
- data/lib/rubocop/cop/mixin/access_modifier_node.rb +3 -10
- data/lib/rubocop/cop/mixin/annotation_comment.rb +1 -0
- data/lib/rubocop/cop/mixin/array_hash_indentation.rb +80 -0
- data/lib/rubocop/cop/mixin/array_syntax.rb +2 -1
- data/lib/rubocop/cop/mixin/autocorrect_alignment.rb +14 -20
- data/lib/rubocop/cop/mixin/autocorrect_unless_changing_ast.rb +5 -4
- data/lib/rubocop/cop/mixin/check_assignment.rb +20 -15
- data/lib/rubocop/cop/mixin/classish_length.rb +1 -0
- data/lib/rubocop/cop/mixin/code_length.rb +1 -0
- data/lib/rubocop/cop/mixin/configurable_enforced_style.rb +17 -15
- data/lib/rubocop/cop/mixin/configurable_max.rb +1 -0
- data/lib/rubocop/cop/mixin/configurable_naming.rb +4 -0
- data/lib/rubocop/cop/mixin/empty_lines_around_body.rb +9 -4
- data/lib/rubocop/cop/mixin/end_keyword_alignment.rb +24 -16
- data/lib/rubocop/cop/mixin/first_element_line_break.rb +3 -2
- data/lib/rubocop/cop/mixin/hash_node.rb +15 -0
- data/lib/rubocop/cop/mixin/if_node.rb +1 -0
- data/lib/rubocop/cop/mixin/method_complexity.rb +1 -0
- data/lib/rubocop/cop/mixin/method_preference.rb +1 -0
- data/lib/rubocop/cop/mixin/min_body_length.rb +1 -0
- data/lib/rubocop/cop/mixin/multiline_expression_indentation.rb +177 -0
- data/lib/rubocop/cop/mixin/negative_conditional.rb +1 -0
- data/lib/rubocop/cop/mixin/on_method_def.rb +6 -5
- data/lib/rubocop/cop/mixin/on_normal_if_unless.rb +1 -0
- data/lib/rubocop/cop/mixin/parentheses.rb +22 -0
- data/lib/rubocop/cop/mixin/parser_diagnostic.rb +1 -0
- data/lib/rubocop/cop/mixin/percent_literal.rb +1 -0
- data/lib/rubocop/cop/mixin/preceding_following_alignment.rb +79 -0
- data/lib/rubocop/cop/mixin/safe_assignment.rb +1 -0
- data/lib/rubocop/cop/mixin/space_after_punctuation.rb +2 -1
- data/lib/rubocop/cop/mixin/space_before_punctuation.rb +2 -1
- data/lib/rubocop/cop/mixin/space_inside.rb +2 -1
- data/lib/rubocop/cop/mixin/statement_modifier.rb +6 -5
- data/lib/rubocop/cop/mixin/string_help.rb +2 -9
- data/lib/rubocop/cop/mixin/string_literals_help.rb +13 -7
- data/lib/rubocop/cop/mixin/surrounding_space.rb +3 -2
- data/lib/rubocop/cop/mixin/trailing_comma.rb +134 -0
- data/lib/rubocop/cop/mixin/unused_argument.rb +1 -0
- data/lib/rubocop/cop/offense.rb +19 -14
- data/lib/rubocop/cop/performance/case_when_splat.rb +8 -8
- data/lib/rubocop/cop/performance/casecmp.rb +54 -0
- data/lib/rubocop/cop/performance/count.rb +10 -9
- data/lib/rubocop/cop/performance/detect.rb +6 -5
- data/lib/rubocop/cop/performance/double_start_end_with.rb +65 -0
- data/lib/rubocop/cop/performance/end_with.rb +55 -0
- data/lib/rubocop/cop/performance/fixed_size.rb +1 -0
- data/lib/rubocop/cop/performance/flat_map.rb +9 -8
- data/lib/rubocop/cop/performance/hash_each.rb +86 -0
- data/lib/rubocop/cop/performance/lstrip_rstrip.rb +44 -0
- data/lib/rubocop/cop/performance/range_include.rb +40 -0
- data/lib/rubocop/cop/performance/redundant_block_call.rb +57 -0
- data/lib/rubocop/cop/performance/redundant_match.rb +51 -0
- data/lib/rubocop/cop/performance/redundant_merge.rb +85 -0
- data/lib/rubocop/cop/performance/redundant_sort_by.rb +45 -0
- data/lib/rubocop/cop/performance/reverse_each.rb +3 -2
- data/lib/rubocop/cop/performance/sample.rb +6 -5
- data/lib/rubocop/cop/performance/size.rb +2 -1
- data/lib/rubocop/cop/performance/start_with.rb +58 -0
- data/lib/rubocop/cop/performance/string_replacement.rb +18 -23
- data/lib/rubocop/cop/performance/times_map.rb +49 -0
- data/lib/rubocop/cop/rails/action_filter.rb +4 -3
- data/lib/rubocop/cop/rails/date.rb +5 -4
- data/lib/rubocop/cop/rails/delegate.rb +3 -2
- data/lib/rubocop/cop/rails/find_by.rb +20 -14
- data/lib/rubocop/cop/rails/find_each.rb +23 -2
- data/lib/rubocop/cop/rails/has_and_belongs_to_many.rb +3 -2
- data/lib/rubocop/cop/rails/output.rb +4 -2
- data/lib/rubocop/cop/rails/pluralization_grammar.rb +3 -2
- data/lib/rubocop/cop/rails/read_write_attribute.rb +5 -7
- data/lib/rubocop/cop/rails/scope_args.rb +3 -2
- data/lib/rubocop/cop/rails/time_zone.rb +14 -10
- data/lib/rubocop/cop/rails/validation.rb +4 -3
- data/lib/rubocop/cop/severity.rb +8 -7
- data/lib/rubocop/cop/style/access_modifier_indentation.rb +5 -4
- data/lib/rubocop/cop/style/accessor_method_name.rb +1 -0
- data/lib/rubocop/cop/style/alias.rb +84 -24
- data/lib/rubocop/cop/style/align_array.rb +2 -1
- data/lib/rubocop/cop/style/align_hash.rb +13 -14
- data/lib/rubocop/cop/style/align_parameters.rb +3 -2
- data/lib/rubocop/cop/style/and_or.rb +9 -7
- data/lib/rubocop/cop/style/array_join.rb +5 -5
- data/lib/rubocop/cop/style/ascii_comments.rb +2 -1
- data/lib/rubocop/cop/style/ascii_identifiers.rb +2 -1
- data/lib/rubocop/cop/style/attr.rb +30 -5
- data/lib/rubocop/cop/style/auto_resource_cleanup.rb +3 -3
- data/lib/rubocop/cop/style/bare_percent_literals.rb +2 -1
- data/lib/rubocop/cop/style/begin_block.rb +2 -1
- data/lib/rubocop/cop/style/block_comments.rb +2 -1
- data/lib/rubocop/cop/style/block_delimiters.rb +10 -9
- data/lib/rubocop/cop/style/block_end_newline.rb +3 -2
- data/lib/rubocop/cop/style/braces_around_hash_parameters.rb +9 -8
- data/lib/rubocop/cop/style/case_equality.rb +2 -1
- data/lib/rubocop/cop/style/case_indentation.rb +2 -1
- data/lib/rubocop/cop/style/character_literal.rb +11 -7
- data/lib/rubocop/cop/style/class_and_module_camel_case.rb +2 -1
- data/lib/rubocop/cop/style/class_and_module_children.rb +3 -2
- data/lib/rubocop/cop/style/class_check.rb +2 -1
- data/lib/rubocop/cop/style/class_methods.rb +2 -1
- data/lib/rubocop/cop/style/class_vars.rb +2 -1
- data/lib/rubocop/cop/style/closing_parenthesis_indentation.rb +3 -2
- data/lib/rubocop/cop/style/collection_methods.rb +2 -1
- data/lib/rubocop/cop/style/colon_method_call.rb +3 -2
- data/lib/rubocop/cop/style/command_literal.rb +8 -7
- data/lib/rubocop/cop/style/comment_annotation.rb +3 -2
- data/lib/rubocop/cop/style/comment_indentation.rb +4 -6
- data/lib/rubocop/cop/style/conditional_assignment.rb +362 -0
- data/lib/rubocop/cop/style/constant_name.rb +2 -1
- data/lib/rubocop/cop/style/copyright.rb +7 -6
- data/lib/rubocop/cop/style/def_with_parentheses.rb +2 -1
- data/lib/rubocop/cop/style/deprecated_hash_methods.rb +3 -2
- data/lib/rubocop/cop/style/documentation.rb +7 -11
- data/lib/rubocop/cop/style/dot_position.rb +3 -2
- data/lib/rubocop/cop/style/double_negation.rb +2 -1
- data/lib/rubocop/cop/style/each_with_object.rb +4 -3
- data/lib/rubocop/cop/style/else_alignment.rb +3 -2
- data/lib/rubocop/cop/style/empty_else.rb +4 -3
- data/lib/rubocop/cop/style/empty_line_between_defs.rb +2 -1
- data/lib/rubocop/cop/style/empty_lines.rb +10 -4
- data/lib/rubocop/cop/style/empty_lines_around_access_modifier.rb +13 -5
- data/lib/rubocop/cop/style/empty_lines_around_block_body.rb +7 -3
- data/lib/rubocop/cop/style/empty_lines_around_class_body.rb +6 -3
- data/lib/rubocop/cop/style/empty_lines_around_method_body.rb +4 -3
- data/lib/rubocop/cop/style/empty_lines_around_module_body.rb +4 -2
- data/lib/rubocop/cop/style/empty_literal.rb +20 -5
- data/lib/rubocop/cop/style/encoding.rb +8 -11
- data/lib/rubocop/cop/style/end_block.rb +3 -1
- data/lib/rubocop/cop/style/end_of_line.rb +2 -1
- data/lib/rubocop/cop/style/even_odd.rb +4 -3
- data/lib/rubocop/cop/style/extra_spacing.rb +110 -74
- data/lib/rubocop/cop/style/file_name.rb +103 -6
- data/lib/rubocop/cop/style/first_array_element_line_break.rb +3 -2
- data/lib/rubocop/cop/style/first_hash_element_line_break.rb +5 -6
- data/lib/rubocop/cop/style/first_method_argument_line_break.rb +14 -1
- data/lib/rubocop/cop/style/first_method_parameter_line_break.rb +2 -1
- data/lib/rubocop/cop/style/first_parameter_indentation.rb +6 -4
- data/lib/rubocop/cop/style/flip_flop.rb +2 -1
- data/lib/rubocop/cop/style/for.rb +2 -1
- data/lib/rubocop/cop/style/format_string.rb +1 -0
- data/lib/rubocop/cop/style/frozen_string_literal_comment.rb +89 -0
- data/lib/rubocop/cop/style/global_vars.rb +2 -1
- data/lib/rubocop/cop/style/guard_clause.rb +63 -11
- data/lib/rubocop/cop/style/hash_syntax.rb +10 -10
- data/lib/rubocop/cop/style/identical_conditional_branches.rb +93 -0
- data/lib/rubocop/cop/style/if_inside_else.rb +49 -0
- data/lib/rubocop/cop/style/if_unless_modifier.rb +6 -5
- data/lib/rubocop/cop/style/if_with_semicolon.rb +2 -1
- data/lib/rubocop/cop/style/indent_array.rb +89 -38
- data/lib/rubocop/cop/style/indent_assignment.rb +43 -0
- data/lib/rubocop/cop/style/indent_hash.rb +16 -77
- data/lib/rubocop/cop/style/indentation_consistency.rb +2 -1
- data/lib/rubocop/cop/style/indentation_width.rb +11 -11
- data/lib/rubocop/cop/style/infinite_loop.rb +5 -9
- data/lib/rubocop/cop/style/initial_indentation.rb +2 -1
- data/lib/rubocop/cop/style/inline_comment.rb +2 -1
- data/lib/rubocop/cop/style/lambda.rb +14 -11
- data/lib/rubocop/cop/style/lambda_call.rb +4 -4
- data/lib/rubocop/cop/style/leading_comment_space.rb +2 -1
- data/lib/rubocop/cop/style/line_end_concatenation.rb +3 -1
- data/lib/rubocop/cop/style/method_call_parentheses.rb +9 -1
- data/lib/rubocop/cop/style/method_called_on_do_end_block.rb +3 -2
- data/lib/rubocop/cop/style/method_def_parentheses.rb +4 -4
- data/lib/rubocop/cop/style/method_name.rb +1 -0
- data/lib/rubocop/cop/style/missing_else.rb +5 -3
- data/lib/rubocop/cop/style/module_function.rb +2 -1
- data/lib/rubocop/cop/style/multiline_array_brace_layout.rb +95 -0
- data/lib/rubocop/cop/style/multiline_assignment_layout.rb +91 -0
- data/lib/rubocop/cop/style/multiline_block_chain.rb +3 -2
- data/lib/rubocop/cop/style/multiline_block_layout.rb +11 -9
- data/lib/rubocop/cop/style/multiline_if_then.rb +1 -0
- data/lib/rubocop/cop/style/multiline_method_call_indentation.rb +137 -0
- data/lib/rubocop/cop/style/multiline_operation_indentation.rb +25 -135
- data/lib/rubocop/cop/style/multiline_ternary_operator.rb +2 -1
- data/lib/rubocop/cop/style/mutable_constant.rb +4 -5
- data/lib/rubocop/cop/style/negated_if.rb +3 -3
- data/lib/rubocop/cop/style/negated_while.rb +3 -3
- data/lib/rubocop/cop/style/nested_modifier.rb +6 -5
- data/lib/rubocop/cop/style/nested_parenthesized_calls.rb +48 -0
- data/lib/rubocop/cop/style/nested_ternary_operator.rb +2 -1
- data/lib/rubocop/cop/style/next.rb +79 -15
- data/lib/rubocop/cop/style/nil_comparison.rb +5 -5
- data/lib/rubocop/cop/style/non_nil_check.rb +5 -5
- data/lib/rubocop/cop/style/not.rb +5 -9
- data/lib/rubocop/cop/style/numeric_literals.rb +5 -4
- data/lib/rubocop/cop/style/one_line_conditional.rb +3 -2
- data/lib/rubocop/cop/style/op_method.rb +7 -4
- data/lib/rubocop/cop/style/option_hash.rb +13 -7
- data/lib/rubocop/cop/style/optional_arguments.rb +3 -2
- data/lib/rubocop/cop/style/parallel_assignment.rb +40 -16
- data/lib/rubocop/cop/style/parentheses_around_condition.rb +3 -16
- data/lib/rubocop/cop/style/percent_literal_delimiters.rb +3 -2
- data/lib/rubocop/cop/style/percent_q_literals.rb +3 -6
- data/lib/rubocop/cop/style/perl_backrefs.rb +4 -3
- data/lib/rubocop/cop/style/predicate_name.rb +1 -0
- data/lib/rubocop/cop/style/proc.rb +3 -2
- data/lib/rubocop/cop/style/raise_args.rb +2 -1
- data/lib/rubocop/cop/style/redundant_begin.rb +2 -1
- data/lib/rubocop/cop/style/redundant_exception.rb +5 -5
- data/lib/rubocop/cop/style/redundant_freeze.rb +5 -4
- data/lib/rubocop/cop/style/redundant_parentheses.rb +80 -0
- data/lib/rubocop/cop/style/redundant_return.rb +5 -4
- data/lib/rubocop/cop/style/redundant_self.rb +7 -8
- data/lib/rubocop/cop/style/regexp_literal.rb +9 -8
- data/lib/rubocop/cop/style/rescue_ensure_alignment.rb +3 -2
- data/lib/rubocop/cop/style/rescue_modifier.rb +11 -9
- data/lib/rubocop/cop/style/self_assignment.rb +4 -5
- data/lib/rubocop/cop/style/semicolon.rb +3 -2
- data/lib/rubocop/cop/style/send.rb +3 -1
- data/lib/rubocop/cop/style/signal_exception.rb +5 -3
- data/lib/rubocop/cop/style/single_line_block_params.rb +2 -1
- data/lib/rubocop/cop/style/single_line_methods.rb +7 -7
- data/lib/rubocop/cop/style/space_after_colon.rb +2 -1
- data/lib/rubocop/cop/style/space_after_comma.rb +1 -0
- data/lib/rubocop/cop/style/space_after_control_keyword.rb +5 -5
- data/lib/rubocop/cop/style/space_after_method_name.rb +3 -2
- data/lib/rubocop/cop/style/space_after_not.rb +4 -3
- data/lib/rubocop/cop/style/space_after_semicolon.rb +1 -0
- data/lib/rubocop/cop/style/space_around_block_parameters.rb +8 -7
- data/lib/rubocop/cop/style/space_around_equals_in_parameter_default.rb +1 -0
- data/lib/rubocop/cop/style/space_around_operators.rb +72 -32
- data/lib/rubocop/cop/style/space_before_block_braces.rb +2 -1
- data/lib/rubocop/cop/style/space_before_comma.rb +1 -0
- data/lib/rubocop/cop/style/space_before_comment.rb +2 -1
- data/lib/rubocop/cop/style/{single_space_before_first_arg.rb → space_before_first_arg.rb} +13 -4
- data/lib/rubocop/cop/style/space_before_modifier_keyword.rb +4 -3
- data/lib/rubocop/cop/style/space_before_semicolon.rb +1 -0
- data/lib/rubocop/cop/style/space_inside_block_braces.rb +3 -2
- data/lib/rubocop/cop/style/space_inside_brackets.rb +1 -0
- data/lib/rubocop/cop/style/space_inside_hash_literal_braces.rb +4 -1
- data/lib/rubocop/cop/style/space_inside_parens.rb +1 -0
- data/lib/rubocop/cop/style/space_inside_range_literal.rb +5 -4
- data/lib/rubocop/cop/style/space_inside_string_interpolation.rb +8 -17
- data/lib/rubocop/cop/style/special_global_vars.rb +97 -52
- data/lib/rubocop/cop/style/stabby_lambda_parentheses.rb +16 -9
- data/lib/rubocop/cop/style/string_literals.rb +41 -1
- data/lib/rubocop/cop/style/string_literals_in_interpolation.rb +2 -1
- data/lib/rubocop/cop/style/string_methods.rb +2 -1
- data/lib/rubocop/cop/style/struct_inheritance.rb +3 -2
- data/lib/rubocop/cop/style/symbol_array.rb +74 -7
- data/lib/rubocop/cop/style/symbol_literal.rb +4 -7
- data/lib/rubocop/cop/style/symbol_proc.rb +11 -7
- data/lib/rubocop/cop/style/tab.rb +25 -2
- data/lib/rubocop/cop/style/trailing_blank_lines.rb +1 -2
- data/lib/rubocop/cop/style/trailing_comma_in_arguments.rb +45 -0
- data/lib/rubocop/cop/style/trailing_comma_in_literal.rb +56 -0
- data/lib/rubocop/cop/style/trailing_underscore_variable.rb +8 -7
- data/lib/rubocop/cop/style/trailing_whitespace.rb +2 -1
- data/lib/rubocop/cop/style/trivial_accessors.rb +18 -9
- data/lib/rubocop/cop/style/unless_else.rb +2 -1
- data/lib/rubocop/cop/style/unneeded_capital_w.rb +4 -3
- data/lib/rubocop/cop/style/unneeded_interpolation.rb +87 -0
- data/lib/rubocop/cop/style/unneeded_percent_q.rb +23 -7
- data/lib/rubocop/cop/style/variable_interpolation.rb +8 -6
- data/lib/rubocop/cop/style/variable_name.rb +1 -0
- data/lib/rubocop/cop/style/when_then.rb +2 -1
- data/lib/rubocop/cop/style/while_until_do.rb +3 -2
- data/lib/rubocop/cop/style/while_until_modifier.rb +3 -4
- data/lib/rubocop/cop/style/word_array.rb +74 -51
- data/lib/rubocop/cop/team.rb +21 -15
- data/lib/rubocop/cop/util.rb +102 -69
- data/lib/rubocop/cop/variable_force.rb +2 -1
- data/lib/rubocop/cop/variable_force/assignment.rb +2 -1
- data/lib/rubocop/cop/variable_force/locatable.rb +1 -0
- data/lib/rubocop/cop/variable_force/reference.rb +1 -0
- data/lib/rubocop/cop/variable_force/scope.rb +2 -1
- data/lib/rubocop/cop/variable_force/variable.rb +2 -1
- data/lib/rubocop/cop/variable_force/variable_table.rb +2 -1
- data/lib/rubocop/error.rb +12 -0
- data/lib/rubocop/formatter/base_formatter.rb +10 -1
- data/lib/rubocop/formatter/clang_style_formatter.rb +1 -0
- data/lib/rubocop/formatter/colorizable.rb +6 -1
- data/lib/rubocop/formatter/disabled_config_formatter.rb +29 -15
- data/lib/rubocop/formatter/disabled_lines_formatter.rb +3 -1
- data/lib/rubocop/formatter/emacs_style_formatter.rb +7 -3
- data/lib/rubocop/formatter/file_list_formatter.rb +1 -0
- data/lib/rubocop/formatter/formatter_set.rb +10 -19
- data/lib/rubocop/formatter/fuubar_style_formatter.rb +2 -1
- data/lib/rubocop/formatter/html_formatter.rb +15 -14
- data/lib/rubocop/formatter/json_formatter.rb +2 -1
- data/lib/rubocop/formatter/offense_count_formatter.rb +1 -0
- data/lib/rubocop/formatter/progress_formatter.rb +3 -3
- data/lib/rubocop/formatter/simple_text_formatter.rb +50 -17
- data/lib/rubocop/formatter/text_util.rb +8 -10
- data/lib/rubocop/formatter/worst_offenders_formatter.rb +61 -0
- data/lib/rubocop/name_similarity.rb +22 -0
- data/lib/rubocop/node_pattern.rb +126 -35
- data/lib/rubocop/options.rb +28 -19
- data/lib/rubocop/path_util.rb +1 -0
- data/lib/rubocop/processed_source.rb +41 -16
- data/lib/rubocop/rake_task.rb +6 -9
- data/lib/rubocop/remote_config.rb +1 -0
- data/lib/rubocop/result_cache.rb +60 -43
- data/lib/rubocop/runner.rb +48 -45
- data/lib/rubocop/string_util.rb +1 -0
- data/lib/rubocop/target_finder.rb +2 -1
- data/lib/rubocop/token.rb +1 -0
- data/lib/rubocop/version.rb +3 -2
- data/lib/rubocop/warning.rb +1 -0
- data/relnotes/v0.36.0.md +306 -0
- data/rubocop.gemspec +3 -9
- metadata +48 -92
- data/lib/rubocop/cop/lint/space_before_first_arg.rb +0 -44
- data/lib/rubocop/cop/rails/default_scope.rb +0 -33
- data/lib/rubocop/cop/style/trailing_comma.rb +0 -182
|
@@ -1,4 +1,5 @@
|
|
|
1
1
|
# encoding: utf-8
|
|
2
|
+
# frozen_string_literal: true
|
|
2
3
|
|
|
3
4
|
module RuboCop
|
|
4
5
|
module Cop
|
|
@@ -34,7 +35,7 @@ module RuboCop
|
|
|
34
35
|
# dry_ingredients.combine
|
|
35
36
|
# end
|
|
36
37
|
class CircularArgumentReference < Cop
|
|
37
|
-
MSG = 'Circular argument reference - `%s`.'
|
|
38
|
+
MSG = 'Circular argument reference - `%s`.'.freeze
|
|
38
39
|
|
|
39
40
|
def on_kwoptarg(node)
|
|
40
41
|
check_for_circular_argument_references(*node)
|
|
@@ -1,4 +1,5 @@
|
|
|
1
1
|
# encoding: utf-8
|
|
2
|
+
# frozen_string_literal: true
|
|
2
3
|
|
|
3
4
|
module RuboCop
|
|
4
5
|
module Cop
|
|
@@ -34,7 +35,7 @@ module RuboCop
|
|
|
34
35
|
|
|
35
36
|
condition, = *node
|
|
36
37
|
return unless on_different_line?(node.loc.keyword.line,
|
|
37
|
-
condition.
|
|
38
|
+
condition.source_range.line)
|
|
38
39
|
|
|
39
40
|
add_offense(condition, :expression, message(node.loc.keyword.source))
|
|
40
41
|
end
|
|
@@ -1,26 +1,43 @@
|
|
|
1
1
|
# encoding: utf-8
|
|
2
|
+
# frozen_string_literal: true
|
|
2
3
|
|
|
3
4
|
module RuboCop
|
|
4
5
|
module Cop
|
|
5
6
|
module Lint
|
|
6
7
|
# This cop checks for calls to debugger or pry.
|
|
7
8
|
class Debugger < Cop
|
|
8
|
-
MSG = 'Remove debugger entry point `%s`.'
|
|
9
|
+
MSG = 'Remove debugger entry point `%s`.'.freeze
|
|
9
10
|
|
|
10
|
-
def_node_matcher :debugger_call?,
|
|
11
|
-
|
|
12
|
-
|
|
13
|
-
|
|
14
|
-
|
|
15
|
-
|
|
16
|
-
|
|
17
|
-
|
|
11
|
+
def_node_matcher :debugger_call?, <<-END
|
|
12
|
+
{(send nil {:debugger :byebug} ...)
|
|
13
|
+
(send (send nil :binding)
|
|
14
|
+
{:pry :remote_pry :pry_remote} ...)
|
|
15
|
+
(send (const nil :Pry) :rescue ...)
|
|
16
|
+
(send nil {:save_and_open_page
|
|
17
|
+
:save_and_open_screenshot
|
|
18
|
+
:save_screenshot} ...)}
|
|
19
|
+
END
|
|
20
|
+
|
|
21
|
+
def_node_matcher :pry_rescue?, '(send (const nil :Pry) :rescue ...)'
|
|
18
22
|
|
|
19
23
|
def on_send(node)
|
|
20
24
|
return unless debugger_call?(node)
|
|
21
|
-
add_offense(node,
|
|
22
|
-
|
|
23
|
-
|
|
25
|
+
add_offense(node, :expression, format(MSG, node.source))
|
|
26
|
+
end
|
|
27
|
+
|
|
28
|
+
def autocorrect(node)
|
|
29
|
+
lambda do |corrector|
|
|
30
|
+
if pry_rescue?(node)
|
|
31
|
+
block = node.parent
|
|
32
|
+
body = block.children[2] # (block <send> <parameters> <body>)
|
|
33
|
+
corrector.replace(block.source_range, body.source)
|
|
34
|
+
else
|
|
35
|
+
range = node.source_range
|
|
36
|
+
range = range_with_surrounding_space(range, :left, nil, false)
|
|
37
|
+
range = range_with_surrounding_space(range, :right, nil, true)
|
|
38
|
+
corrector.remove(range)
|
|
39
|
+
end
|
|
40
|
+
end
|
|
24
41
|
end
|
|
25
42
|
end
|
|
26
43
|
end
|
|
@@ -1,4 +1,5 @@
|
|
|
1
1
|
# encoding: utf-8
|
|
2
|
+
# frozen_string_literal: true
|
|
2
3
|
|
|
3
4
|
module RuboCop
|
|
4
5
|
module Cop
|
|
@@ -20,29 +21,26 @@ module RuboCop
|
|
|
20
21
|
include OnMethodDef
|
|
21
22
|
include EndKeywordAlignment
|
|
22
23
|
|
|
23
|
-
MSG = '`end` at %d, %d is not aligned with `%s` at %d, %d.'
|
|
24
|
+
MSG = '`end` at %d, %d is not aligned with `%s` at %d, %d.'.freeze
|
|
24
25
|
|
|
25
26
|
def on_method_def(node, _method_name, _args, _body)
|
|
26
|
-
|
|
27
|
+
check_end_kw_in_node(node)
|
|
27
28
|
end
|
|
28
29
|
|
|
29
30
|
def on_send(node)
|
|
30
|
-
|
|
31
|
-
|
|
32
|
-
|
|
33
|
-
|
|
34
|
-
|
|
35
|
-
|
|
36
|
-
|
|
37
|
-
|
|
38
|
-
|
|
39
|
-
|
|
40
|
-
|
|
41
|
-
|
|
42
|
-
|
|
43
|
-
check_offset(method_def, 'def', 0)
|
|
44
|
-
end
|
|
45
|
-
|
|
31
|
+
return unless modifier_and_def_on_same_line?(node)
|
|
32
|
+
_, _, method_def = *node
|
|
33
|
+
expr = node.source_range
|
|
34
|
+
|
|
35
|
+
line_start = Parser::Source::Range.new(expr.source_buffer,
|
|
36
|
+
expr.begin_pos,
|
|
37
|
+
method_def.loc.keyword.end_pos)
|
|
38
|
+
align_with = {
|
|
39
|
+
def: method_def.loc.keyword,
|
|
40
|
+
start_of_line: line_start
|
|
41
|
+
}
|
|
42
|
+
|
|
43
|
+
check_end_kw_alignment(method_def, align_with)
|
|
46
44
|
ignore_node(method_def) # Don't check the same `end` again.
|
|
47
45
|
end
|
|
48
46
|
|
|
@@ -1,4 +1,5 @@
|
|
|
1
1
|
# encoding: utf-8
|
|
2
|
+
# frozen_string_literal: true
|
|
2
3
|
|
|
3
4
|
module RuboCop
|
|
4
5
|
module Cop
|
|
@@ -9,7 +10,7 @@ module RuboCop
|
|
|
9
10
|
# This class exists to add abstraction and clean naming to the
|
|
10
11
|
# objects that are going to be operated on.
|
|
11
12
|
class DeprecatedClassMethod
|
|
12
|
-
include
|
|
13
|
+
include RuboCop::Sexp
|
|
13
14
|
|
|
14
15
|
attr_reader :class_constant, :deprecated_method, :replacement_method
|
|
15
16
|
|
|
@@ -27,11 +28,11 @@ module RuboCop
|
|
|
27
28
|
end
|
|
28
29
|
end
|
|
29
30
|
|
|
30
|
-
MSG = '`%s` is deprecated in favor of `%s`.'
|
|
31
|
+
MSG = '`%s` is deprecated in favor of `%s`.'.freeze
|
|
31
32
|
DEPRECATED_METHODS_OBJECT = [
|
|
32
33
|
DeprecatedClassMethod.new(:File, :exists?, :exist?),
|
|
33
34
|
DeprecatedClassMethod.new(:Dir, :exists?, :exist?)
|
|
34
|
-
]
|
|
35
|
+
].freeze
|
|
35
36
|
|
|
36
37
|
def on_send(node)
|
|
37
38
|
check(node) do |data|
|
|
@@ -53,14 +54,13 @@ module RuboCop
|
|
|
53
54
|
|
|
54
55
|
private
|
|
55
56
|
|
|
56
|
-
def check(node
|
|
57
|
+
def check(node)
|
|
57
58
|
receiver, method_name, *_args = *node
|
|
58
59
|
|
|
59
60
|
DEPRECATED_METHODS_OBJECT.each do |data|
|
|
60
61
|
next unless data.class_nodes.include?(receiver)
|
|
61
62
|
next unless method_name == data.deprecated_method
|
|
62
|
-
|
|
63
|
-
block.call(data)
|
|
63
|
+
yield data
|
|
64
64
|
end
|
|
65
65
|
end
|
|
66
66
|
|
|
@@ -1,103 +1,127 @@
|
|
|
1
1
|
# encoding: utf-8
|
|
2
|
+
# frozen_string_literal: true
|
|
2
3
|
|
|
3
4
|
module RuboCop
|
|
4
5
|
module Cop
|
|
5
6
|
module Lint
|
|
6
|
-
# This cop checks for
|
|
7
|
+
# This cop checks for duplicated instance (or singleton) method
|
|
8
|
+
# definitions.
|
|
7
9
|
#
|
|
8
|
-
# @example
|
|
9
|
-
#
|
|
10
|
-
#
|
|
11
|
-
#
|
|
12
|
-
# end
|
|
13
|
-
#
|
|
14
|
-
# def some_method
|
|
15
|
-
# end
|
|
10
|
+
# @example
|
|
11
|
+
# @bad
|
|
12
|
+
# def duplicated
|
|
13
|
+
# 1
|
|
16
14
|
# end
|
|
17
15
|
#
|
|
18
|
-
#
|
|
19
|
-
#
|
|
20
|
-
# module SomeClass
|
|
21
|
-
# def some_method
|
|
22
|
-
# end
|
|
23
|
-
#
|
|
24
|
-
# def some_method
|
|
25
|
-
# end
|
|
26
|
-
# end
|
|
27
|
-
#
|
|
28
|
-
# @example Duplicate class methods in class
|
|
29
|
-
#
|
|
30
|
-
# class SomeClass
|
|
31
|
-
# def self.some_method
|
|
32
|
-
# end
|
|
33
|
-
#
|
|
34
|
-
# def self.some_method
|
|
35
|
-
# end
|
|
36
|
-
# end
|
|
37
|
-
#
|
|
38
|
-
# @example Duplicate private and public methods in class
|
|
39
|
-
#
|
|
40
|
-
# class SomeClass
|
|
41
|
-
# def some_method
|
|
42
|
-
# end
|
|
43
|
-
#
|
|
44
|
-
# private def some_method
|
|
45
|
-
# end
|
|
16
|
+
# def duplicated
|
|
17
|
+
# 2
|
|
46
18
|
# end
|
|
47
19
|
class DuplicateMethods < Cop
|
|
48
|
-
MSG = '
|
|
20
|
+
MSG = 'Method `%s` is defined at both %s and %s.'.freeze
|
|
49
21
|
|
|
50
|
-
def
|
|
51
|
-
|
|
52
|
-
|
|
53
|
-
names = method_names(body)
|
|
54
|
-
check_duplicate_methods(names)
|
|
22
|
+
def initialize(config = nil, options = nil)
|
|
23
|
+
super
|
|
24
|
+
@definitions = {}
|
|
55
25
|
end
|
|
56
26
|
|
|
57
|
-
def
|
|
58
|
-
|
|
59
|
-
|
|
60
|
-
|
|
61
|
-
|
|
62
|
-
end
|
|
27
|
+
def on_def(node)
|
|
28
|
+
# if a method definition is inside an if, it is very likely
|
|
29
|
+
# that a different definition is used depending on platform, etc.
|
|
30
|
+
return if node.ancestors.any?(&:if_type?)
|
|
31
|
+
return if possible_dsl?(node)
|
|
63
32
|
|
|
64
|
-
|
|
33
|
+
return unless (scope = node.parent_module_name)
|
|
34
|
+
found_instance_method(node, scope)
|
|
35
|
+
end
|
|
65
36
|
|
|
66
|
-
def
|
|
67
|
-
|
|
68
|
-
|
|
37
|
+
def on_defs(node)
|
|
38
|
+
return if node.ancestors.any?(&:if_type?)
|
|
39
|
+
return if possible_dsl?(node)
|
|
69
40
|
|
|
70
|
-
|
|
71
|
-
|
|
72
|
-
|
|
41
|
+
receiver, name, = *node
|
|
42
|
+
if receiver.const_type?
|
|
43
|
+
_, const_name = *receiver
|
|
44
|
+
if (qualified = lookup_constant(node, const_name))
|
|
45
|
+
found_method(node, "#{qualified}.#{name}")
|
|
73
46
|
end
|
|
74
|
-
|
|
75
|
-
if node.
|
|
76
|
-
|
|
77
|
-
elsif node.defs_type?
|
|
78
|
-
_receiver, method = *node
|
|
79
|
-
method = "self.#{method}"
|
|
47
|
+
elsif receiver.self_type?
|
|
48
|
+
if (enclosing = node.parent_module_name)
|
|
49
|
+
found_method(node, "#{enclosing}.#{name}")
|
|
80
50
|
end
|
|
51
|
+
end
|
|
52
|
+
end
|
|
53
|
+
|
|
54
|
+
private
|
|
81
55
|
|
|
82
|
-
|
|
83
|
-
|
|
56
|
+
def message_for_dup(node, method_name)
|
|
57
|
+
format(MSG, method_name, @definitions[method_name],
|
|
58
|
+
source_location(node))
|
|
84
59
|
end
|
|
85
60
|
|
|
86
|
-
def
|
|
87
|
-
|
|
88
|
-
|
|
89
|
-
|
|
61
|
+
def found_instance_method(node, scope)
|
|
62
|
+
name, = *node
|
|
63
|
+
if scope =~ /\A#<Class:(.*)>\Z/
|
|
64
|
+
found_method(node, "#{Regexp.last_match(1)}.#{name}")
|
|
65
|
+
else
|
|
66
|
+
found_method(node, "#{scope}##{name}")
|
|
90
67
|
end
|
|
68
|
+
end
|
|
91
69
|
|
|
92
|
-
|
|
93
|
-
|
|
94
|
-
|
|
70
|
+
def found_method(node, method_name)
|
|
71
|
+
if @definitions.key?(method_name)
|
|
72
|
+
add_offense(node, :keyword, message_for_dup(node, method_name))
|
|
73
|
+
else
|
|
74
|
+
@definitions[method_name] = source_location(node)
|
|
75
|
+
end
|
|
76
|
+
end
|
|
77
|
+
|
|
78
|
+
def lookup_constant(node, const_name)
|
|
79
|
+
# this method is quite imperfect and can be fooled
|
|
80
|
+
# to do much better, we would need to do global analysis of the whole
|
|
81
|
+
# codebase
|
|
82
|
+
node.each_ancestor(:class, :module, :casgn) do |ancestor|
|
|
83
|
+
namespace, mod_name = *ancestor.defined_module
|
|
84
|
+
loop do
|
|
85
|
+
if mod_name == const_name
|
|
86
|
+
return qualified_name(ancestor.parent_module_name,
|
|
87
|
+
namespace,
|
|
88
|
+
mod_name)
|
|
89
|
+
end
|
|
95
90
|
|
|
96
|
-
|
|
97
|
-
|
|
98
|
-
|
|
91
|
+
break if namespace.nil?
|
|
92
|
+
namespace, mod_name = *namespace
|
|
93
|
+
end
|
|
99
94
|
end
|
|
100
95
|
end
|
|
96
|
+
|
|
97
|
+
def qualified_name(enclosing, namespace, mod_name)
|
|
98
|
+
if enclosing != 'Object'
|
|
99
|
+
if namespace
|
|
100
|
+
"#{enclosing}::#{namespace.const_name}::#{mod_name}"
|
|
101
|
+
else
|
|
102
|
+
"#{enclosing}::#{mod_name}"
|
|
103
|
+
end
|
|
104
|
+
elsif namespace
|
|
105
|
+
"#{namespace.const_name}::#{mod_name}"
|
|
106
|
+
else
|
|
107
|
+
mod_name
|
|
108
|
+
end
|
|
109
|
+
end
|
|
110
|
+
|
|
111
|
+
def possible_dsl?(node)
|
|
112
|
+
# DSL methods may evaluate a block in the context of a newly created
|
|
113
|
+
# class or module
|
|
114
|
+
# Assume that if a method definition is inside any block call which
|
|
115
|
+
# we can't identify, it could be a DSL
|
|
116
|
+
node.each_ancestor(:block).any? do |ancestor|
|
|
117
|
+
ancestor.method_name != :class_eval && !ancestor.class_constructor?
|
|
118
|
+
end
|
|
119
|
+
end
|
|
120
|
+
|
|
121
|
+
def source_location(node)
|
|
122
|
+
range = node.location.expression
|
|
123
|
+
"#{range.source_buffer.name}:#{range.line}"
|
|
124
|
+
end
|
|
101
125
|
end
|
|
102
126
|
end
|
|
103
127
|
end
|
|
@@ -1,4 +1,5 @@
|
|
|
1
1
|
# encoding: utf-8
|
|
2
|
+
# frozen_string_literal: true
|
|
2
3
|
|
|
3
4
|
module RuboCop
|
|
4
5
|
module Cop
|
|
@@ -10,9 +11,9 @@ module RuboCop
|
|
|
10
11
|
# @example
|
|
11
12
|
# hash = { food: 'apple', food: 'orange' }
|
|
12
13
|
class DuplicatedKey < Cop
|
|
13
|
-
MSG = 'Duplicated key in hash literal.'
|
|
14
|
+
MSG = 'Duplicated key in hash literal.'.freeze
|
|
14
15
|
|
|
15
|
-
LITERALS = [:sym, :str, :float, :int]
|
|
16
|
+
LITERALS = [:sym, :str, :float, :int].freeze
|
|
16
17
|
|
|
17
18
|
def on_hash(node)
|
|
18
19
|
keys = []
|
|
@@ -1,4 +1,5 @@
|
|
|
1
1
|
# encoding: utf-8
|
|
2
|
+
# frozen_string_literal: true
|
|
2
3
|
|
|
3
4
|
module RuboCop
|
|
4
5
|
module Cop
|
|
@@ -13,7 +14,7 @@ module RuboCop
|
|
|
13
14
|
#
|
|
14
15
|
# sum = numbers.each_with_object(0) { |e, a| a += e }
|
|
15
16
|
class EachWithObjectArgument < Cop
|
|
16
|
-
MSG = 'The argument to each_with_object can not be immutable.'
|
|
17
|
+
MSG = 'The argument to each_with_object can not be immutable.'.freeze
|
|
17
18
|
|
|
18
19
|
def on_send(node)
|
|
19
20
|
_receiver, method_name, *args = *node
|
|
@@ -21,7 +22,7 @@ module RuboCop
|
|
|
21
22
|
return unless args.length == 1
|
|
22
23
|
|
|
23
24
|
arg = args.first
|
|
24
|
-
add_offense(node, :expression) if arg.
|
|
25
|
+
add_offense(node, :expression) if arg.immutable_literal?
|
|
25
26
|
end
|
|
26
27
|
end
|
|
27
28
|
end
|
|
@@ -1,4 +1,5 @@
|
|
|
1
1
|
# encoding: utf-8
|
|
2
|
+
# frozen_string_literal: true
|
|
2
3
|
|
|
3
4
|
module RuboCop
|
|
4
5
|
module Cop
|
|
@@ -38,7 +39,7 @@ module RuboCop
|
|
|
38
39
|
|
|
39
40
|
first_else_expr = else_branch.children.first
|
|
40
41
|
|
|
41
|
-
if first_else_expr.
|
|
42
|
+
if first_else_expr.source_range.line == node.loc.else.line
|
|
42
43
|
add_offense(first_else_expr, :expression, message)
|
|
43
44
|
end
|
|
44
45
|
elsif node.loc.respond_to?(:keyword) &&
|
|
@@ -1,11 +1,12 @@
|
|
|
1
1
|
# encoding: utf-8
|
|
2
|
+
# frozen_string_literal: true
|
|
2
3
|
|
|
3
4
|
module RuboCop
|
|
4
5
|
module Cop
|
|
5
6
|
module Lint
|
|
6
7
|
# This cop checks for empty `ensure` blocks
|
|
7
8
|
class EmptyEnsure < Cop
|
|
8
|
-
MSG = 'Empty `ensure` block detected.'
|
|
9
|
+
MSG = 'Empty `ensure` block detected.'.freeze
|
|
9
10
|
|
|
10
11
|
def on_ensure(node)
|
|
11
12
|
_body, ensure_body = *node
|