rubocop 0.31.0 → 0.32.0

data/lib/rubocop/cop/style/single_line_methods.rb

@@ -6,6 +6,7 @@ module RuboCop
       # This cop checks for single-line method definitions.
       # It can optionally accept single-line methods with no body.
       class SingleLineMethods < Cop
+        include AutocorrectAlignment
         include OnMethodDef
 
         MSG = 'Avoid single-line method definitions.'
@@ -55,10 +56,6 @@ module RuboCop
           )
         end
 
-        def configured_indentation_width
-          config.for_cop('IndentationWidth')['Width']
-        end
-
         def move_comment(eol_comment, node, corrector)
           text = eol_comment.loc.expression.source
           corrector.insert_before(node.loc.expression,

data/lib/rubocop/cop/style/space_inside_string_interpolation.rb

@@ -0,0 +1,41 @@
+# encoding: utf-8
+
+module RuboCop
+  module Cop
+    module Style
+      # This cop checks for whitespace within string interpolations.
+      #
+      # Good:
+      #    var = "This is the #{good} example"
+      #
+      # Bad:
+      #    var = "This is the #{ bad } example"
+      #
+      class SpaceInsideStringInterpolation < Cop
+        MSG = 'Space inside string interpolation detected.'
+
+        def on_dstr(node)
+          node.children.select { |n| n.type == :begin }.each do |begin_node|
+            final_node = begin_node.children.last
+
+            interp = final_node.loc.expression
+            if range_with_surrounding_space(interp) != interp
+              add_offense(final_node, :expression)
+            end
+          end
+        end
+
+        private
+
+        def autocorrect(node)
+          lambda do |corrector|
+            corrector.replace(
+              range_with_surrounding_space(node.loc.expression),
+              node.loc.expression.source
+            )
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/style/struct_inheritance.rb

@@ -25,16 +25,17 @@ module RuboCop
         private
 
         def struct_constructor?(node)
-          if node && node.send_type?
-            receiver, method_name = *node
-
-            receiver &&
-              receiver.const_type? &&
-              receiver.children.last == :Struct &&
-              method_name == :new
-          else
-            false
-          end
+          return false unless node
+
+          send_node = node.block_type? ? node.children.first : node
+          return false unless send_node.send_type?
+
+          receiver, method_name = *send_node
+
+          receiver &&
+            receiver.const_type? &&
+            receiver.children.last == :Struct &&
+            method_name == :new
         end
       end
     end

data/lib/rubocop/cop/style/trailing_blank_lines.rb

@@ -24,6 +24,14 @@ module RuboCop
 
           return unless blank_lines != wanted_blank_lines
 
+          offense_detected(sb, wanted_blank_lines, blank_lines,
+                           whitespace_at_end)
+        end
+
+        private
+
+        def offense_detected(sb, wanted_blank_lines, blank_lines,
+                             whitespace_at_end)
           begin_pos = sb.source.length - whitespace_at_end.length
           autocorrect_range = Parser::Source::Range.new(sb, begin_pos,
                                                         sb.source.length)

data/lib/rubocop/cop/style/trailing_comma.rb

@@ -119,7 +119,7 @@ module RuboCop
         def multiline?(node)
           elements = if node.type == :send
                        _receiver, _method_name, *args = *node
-                       args
+                       args.flat_map { |a| a.type == :hash ? a.children : a }
                      else
                        node.children
                      end

data/lib/rubocop/cop/team.rb

@@ -79,7 +79,14 @@ module RuboCop
           cop.relevant_file?(buffer.name) && cop.corrections.any?
         end
         if cop_with_corrections
-          corrector = Corrector.new(buffer, cop_with_corrections.corrections)
+          corrections = cop_with_corrections.corrections
+          # Be extra careful if there are tabs in the source and just correct
+          # one offense, because inserting or removing space next to a tab has
+          # special implications, and existing ranges can't be used after such
+          # a change.
+          corrections = [corrections.first] if buffer.source =~ /\t/
+
+          corrector = Corrector.new(buffer, corrections)
           corrector.rewrite
         else
           buffer.source

data/lib/rubocop/formatter/disabled_config_formatter.rb

@@ -55,7 +55,8 @@ module RuboCop
         default_cfg = RuboCop::ConfigLoader.default_configuration[cop_name]
         return unless default_cfg
 
-        params = default_cfg.keys - %w(Description StyleGuide Enabled) -
+        params = default_cfg.keys -
+                 %w(Description StyleGuide Reference Enabled) -
                  cfg.keys
         return if params.empty?
 

data/lib/rubocop/formatter/formatter_set.rb

@@ -21,7 +21,7 @@ module RuboCop
         'disabled' => DisabledLinesFormatter
       }
 
-      FORMATTER_APIS = [:started, :file_started, :file_finished, :finished]
+      FORMATTER_APIS = [:started, :finished]
 
       FORMATTER_APIS.each do |method_name|
         define_method(method_name) do |*args|
@@ -29,6 +29,29 @@ module RuboCop
         end
       end
 
+      def file_started(file, options)
+        @cop_disabled_line_ranges ||= {}
+        @cop_disabled_line_ranges[file] = options[:cop_disabled_line_ranges]
+        @comments ||= {}
+        @comments[file] = options[:comments]
+        @excepted_cops = options[:excepted_cops] || []
+        @only_cops = options[:only_cops] || []
+        each { |f| f.file_started(file, options) }
+      end
+
+      def file_finished(file, offenses)
+        if @cop_disabled_line_ranges[file].any? &&
+           # Don't check unneeded disable if --only or --except option is
+           # given, because these options override configuration.
+           @excepted_cops.empty? && @only_cops.empty?
+          cop = Cop::Lint::UnneededDisable.new
+          cop.check(file, offenses, @cop_disabled_line_ranges, @comments)
+          offenses += cop.offenses
+        end
+        offenses = offenses.sort.reject(&:disabled?)
+        each { |f| f.file_finished(file, offenses) }
+      end
+
       def add_formatter(formatter_type, output_path = nil)
         formatter_class = case formatter_type
                           when Class

data/lib/rubocop/options.rb

@@ -104,6 +104,10 @@ module RuboCop
     end
 
     def validate_compatibility
+      if @options.key?(:only) &&
+         (@options[:only] & %w(Lint/UnneededDisable UnneededDisable)).any?
+        fail ArgumentError, 'Lint/UnneededDisable can not be used with --only.'
+      end
       return unless (incompat = @options.keys & EXITING_OPTIONS).size > 1
       fail ArgumentError, "Incompatible cli options: #{incompat.inspect}"
     end

data/lib/rubocop/processed_source.rb

@@ -13,7 +13,10 @@ module RuboCop
                 :parser_error, :raw_source
 
     def self.from_file(path)
-      new(File.read(path), path)
+      file = File.read(path)
+      new(file, path)
+    rescue
+      abort("#{Rainbow('rubocop: No such file or directory').red} -- #{path}")
     end
 
     def initialize(source, path = nil)

data/lib/rubocop/runner.rb

@@ -66,8 +66,14 @@ module RuboCop
       puts "Scanning #{file}" if @options[:debug]
 
       processed_source = ProcessedSource.from_file(file)
+      file_info = {
+        cop_disabled_line_ranges: processed_source.disabled_line_ranges,
+        comments: processed_source.comments,
+        only_cops: @options[:only],
+        excepted_cops: @options[:except]
+      }
 
-      formatter_set.file_started(file, file_info(processed_source))
+      formatter_set.file_started(file, file_info)
 
       offenses = do_inspection_loop(file, processed_source)
 
@@ -190,8 +196,11 @@ module RuboCop
 
     def considered_failure?(offense)
       # For :autocorrect level, any offense - corrected or not - is a failure.
-      @options[:fail_level] == :autocorrect ||
-        !offense.corrected? && offense.severity >= minimum_severity_to_fail
+      return true if @options[:fail_level] == :autocorrect
+
+      return false if offense.disabled?
+
+      !offense.corrected? && offense.severity >= minimum_severity_to_fail
     end
 
     def minimum_severity_to_fail
@@ -200,9 +209,5 @@ module RuboCop
         RuboCop::Cop::Severity.new(name)
       end
     end
-
-    def file_info(processed_source)
-      { cop_disabled_line_ranges: processed_source.disabled_line_ranges }
-    end
   end
 end

data/lib/rubocop/target_finder.rb

@@ -88,16 +88,16 @@ module RuboCop
     def find_files(base_dir, flags)
       wanted_toplevel_dirs = toplevel_dirs(base_dir, flags) -
                              excluded_dirs(base_dir)
-      wanted_toplevel_dirs.map! { |dir| dir.gsub(',', '\,') }
+      wanted_toplevel_dirs.map! { |dir| dir << '/**/*' }
 
       pattern = if wanted_toplevel_dirs.empty?
                   # We need this special case to avoid creating the pattern
                   # /**/* which searches the entire file system.
-                  "#{base_dir}/**/*"
+                  ["#{base_dir}/**/*"]
                 else
                   # Search the non-excluded top directories, but also add files
                   # on the top level, which would otherwise not be found.
-                  "{#{base_dir}/*,{#{wanted_toplevel_dirs.join(',')}}/**/*}"
+                  wanted_toplevel_dirs.unshift("#{base_dir}/*")
                 end
       Dir.glob(pattern, flags).select { |path| FileTest.file?(path) }
     end

data/lib/rubocop/version.rb

@@ -3,7 +3,7 @@
 module RuboCop
   # This module holds the RuboCop version information.
   module Version
-    STRING = '0.31.0'
+    STRING = '0.32.0'
 
     MSG = '%s (using Parser %s, running on %s %s %s)'
 

data/relnotes/v0.32.0.md

@@ -0,0 +1,139 @@
+### New features
+
+* Adjust behavior of `TrailingComma` cop to account for multi-line hashes nested within method calls. ([@panthomakos][])
+* [#1719](https://github.com/bbatsov/rubocop/pull/1719): Display an error and abort the program if input file can't be found. ([@matugm][])
+* New cop `SpaceInsideStringInterpolation` checks for spaces within string interpolations. ([@glasnt][])
+* New cop `NestedMethodDefinition` checks for method definitions inside other methods. ([@ojab][])
+* `LiteralInInterpolation` cop does auto-correction. ([@tmr08c][])
+* [#1865](https://github.com/bbatsov/rubocop/issues/1865): New cop `Lint/UnneededDisable` checks for `rubocop:disable` comments that can be removed. ([@jonas054][])
+* `EmptyElse` cop does auto-correction. ([@lumeet][])
+* Show reference links when displaying style guide links. ([@rrosenblum][])
+* `Debugger` cop now checks for the Capybara debug method `save_screenshot`. ([@crazydog115][])
+* [#1282](https://github.com/bbatsov/rubocop/issues/1282): `CaseIndentation` cop does auto-correction. ([@lumeet][])
+* [#1928](https://github.com/bbatsov/rubocop/issues/1928): Do auto-correction one offense at a time (rather than one cop at a time) if there are tabs in the code. ([@jonas054][])
+
+### Changes
+
+* Prefer `SpaceInsideBlockBraces` to `SpaceBeforeSemicolon` and `SpaceAfterSemicolon` to avoid an infinite loop when auto-correcting. ([@lumeet][])
+* [#1873](https://github.com/bbatsov/rubocop/issues/1873): Move `ParallelAssignment` cop from Performance to Style. ([@rrosenblum][])
+* Add `getlocal` to acceptable methods of `Rails/TimeZone`. ([@ojab][])
+* [#1851](https://github.com/bbatsov/rubocop/issues/1851), [#1948](https://github.com/bbatsov/rubocop/issues/1948): Change offense message for `ClassLength` and `ModuleLength` to match that of `MethodLength`. ([@bquorning][])
+
+### Bugs fixed
+
+* Don't count required keyword args when specifying `CountKeywordArgs: false` for `ParameterLists`. ([@sumeet][])
+* [#1879](https://github.com/bbatsov/rubocop/issues/1879): Avoid auto-correcting hash with trailing comma into invalid code in `BracesAroundHashParameters`. ([@jonas054][])
+* [#1868](https://github.com/bbatsov/rubocop/issues/1868): Do not register an offense in `Performance/Count` when `select` is called with symbols or strings as the parameters. ([@rrosenblum][])
+* `Sample` rewritten to properly handle shuffle randomness source, first/last params and non-literal ranges. ([@chastell][])
+* [#1873](https://github.com/bbatsov/rubocop/issues/1873): Modify `ParallelAssignment` to properly autocorrect when the assignment is protected by a modifier statement. ([@rrosenblum][])
+* Configure `ParallelAssignment` to work with non-standard `IndentationWidths`. ([@rrosenblum][])
+* [#1899](https://github.com/bbatsov/rubocop/issues/1899): Be careful about comments when auto-correcting in `BracesAroundHashParameters`. ([@jonas054][])
+* [#1897](https://github.com/bbatsov/rubocop/issues/1897): Don't report that semicolon separated statements can be converted to modifier form in `IfUnlessModifier` (and don't auto-correct them). ([@jonas054][])
+* [#1644](https://github.com/bbatsov/rubocop/issues/1644): Don't search the entire file system when a folder is named `,` (fix for jruby and rbx). ([@rrosenblum][])
+* [#1803](https://github.com/bbatsov/rubocop/issues/1803): Don't warn for `return` from `lambda` block in `NonLocalExitFromIterator`. ([@ypresto][])
+* [#1905](https://github.com/bbatsov/rubocop/issues/1905): Ignore sparse and trailing comments in `Style/Documentation`. ([@RGBD][])
+* [#1923](https://github.com/bbatsov/rubocop/issues/1923): Handle properly `for` without body in `Style/Next`. ([@bbatsov][])
+* [#1901](https://github.com/bbatsov/rubocop/issues/1901): Do not auto correct comments that are missing a note. ([@rrosenblum][])
+* [#1926](https://github.com/bbatsov/rubocop/issues/1926): Fix crash in `Style/AlignHash` when correcting a hash with a splat in it. ([@rrosenblum][])
+* [#1935](https://github.com/bbatsov/rubocop/issues/1935): Allow `Symbol#to_proc` blocks in Performance/Size. ([@m1foley][])
+
+[@bbatsov]: https://github.com/bbatsov
+[@jonas054]: https://github.com/jonas054
+[@yujinakayama]: https://github.com/yujinakayama
+[@dblock]: https://github.com/dblock
+[@nevir]: https://github.com/nevir
+[@daviddavis]: https://github.com/daviddavis
+[@sds]: https://github.com/sds
+[@fancyremarker]: https://github.com/fancyremarker
+[@sinisterchipmunk]: https://github.com/sinisterchipmunk
+[@vonTronje]: https://github.com/vonTronje
+[@agrimm]: https://github.com/agrimm
+[@pmenglund]: https://github.com/pmenglund
+[@chulkilee]: https://github.com/chulkilee
+[@codez]: https://github.com/codez
+[@emou]: https://github.com/emou
+[@skanev]: http://github.com/skanev
+[@claco]: http://github.com/claco
+[@rifraf]: http://github.com/rifraf
+[@scottmatthewman]: https://github.com/scottmatthewman
+[@ma2gedev]: http://github.com/ma2gedev
+[@jeremyolliver]: https://github.com/jeremyolliver
+[@hannestyden]: https://github.com/hannestyden
+[@geniou]: https://github.com/geniou
+[@jkogara]: https://github.com/jkogara
+[@tmorris-fiksu]: https://github.com/tmorris-fiksu
+[@mockdeep]: https://github.com/mockdeep
+[@hiroponz]: https://github.com/hiroponz
+[@tamird]: https://github.com/tamird
+[@fshowalter]: https://github.com/fshowalter
+[@cschramm]: https://github.com/cschramm
+[@bquorning]: https://github.com/bquorning
+[@bcobb]: https://github.com/bcobb
+[@irrationalfab]: https://github.com/irrationalfab
+[@tommeier]: https://github.com/tommeier
+[@sfeldon]: https://github.com/sfeldon
+[@biinari]: https://github.com/biinari
+[@barunio]: https://github.com/barunio
+[@molawson]: https://github.com/molawson
+[@wndhydrnt]: https://github.com/wndhydrnt
+[@ggilder]: https://github.com/ggilder
+[@salbertson]: https://github.com/salbertson
+[@camilleldn]: https://github.com/camilleldn
+[@mcls]: https://github.com/mcls
+[@yous]: https://github.com/yous
+[@vrthra]: https://github.com/vrthra
+[@SkuliOskarsson]: https://github.com/SkuliOskarsson
+[@jspanjers]: https://github.com/jspanjers
+[@sch1zo]: https://github.com/sch1zo
+[@smangelsdorf]: https://github.com/smangelsdorf
+[@mvz]: https://github.com/mvz
+[@jfelchner]: https://github.com/jfelchner
+[@janraasch]: https://github.com/janraasch
+[@jcarbo]: https://github.com/jcarbo
+[@oneamtu]: https://github.com/oneamtu
+[@toy]: https://github.com/toy
+[@Koronen]: https://github.com/Koronen
+[@blainesch]: https://github.com/blainesch
+[@marxarelli]: https://github.com/marxarelli
+[@katieschilling]: https://github.com/katieschilling
+[@kakutani]: https://github.com/kakutani
+[@rrosenblum]: https://github.com/rrosenblum
+[@mattjmcnaughton]: https://github.com/mattjmcnaughton
+[@huerlisi]: https://github.com/huerlisi
+[@volkert]: https://github.com/volkert
+[@lumeet]: https://github.com/lumeet
+[@mmozuras]: https://github.com/mmozuras
+[@d4rk5eed]: https://github.com/d4rk5eed
+[@cshaffer]: https://github.com/cshaffer
+[@eitoball]: https://github.com/eitoball
+[@iainbeeston]: https://github.com/iainbeeston
+[@pimterry]: https://github.com/pimterry
+[@palkan]: https://github.com/palkan
+[@jdoconnor]: https://github.com/jdoconnor
+[@meganemura]: https://github.com/meganemura
+[@zvkemp]: https://github.com/zvkemp
+[@vassilevsky]: https://github.com/vassilevsky
+[@gerry3]: https://github.com/gerry3
+[@ypresto]: https://github.com/ypresto
+[@clowder]: https://github.com/clowder
+[@mudge]: https://github.com/mudge
+[@mzp]: https://github.com/mzp
+[@bankair]: https://github.com/bankair
+[@crimsonknave]: https://github.com/crimsonknave
+[@renuo]: https://github.com/renuo
+[@sdeframond]: https://github.com/sdeframond
+[@til]: https://github.com/til
+[@carhartl]: https://github.com/carhartl
+[@dylandavidson]: https://github.com/dylandavidson
+[@tmr08c]: https://github.com/tmr08c
+[@hbd225]: https://github.com/hbd225
+[@l8nite]: https://github.com/l8nite
+[@sumeet]: https://github.com/sumeet
+[@ojab]: https://github.com/ojab
+[@chastell]: https://github.com/chastell
+[@glasnt]: https://github.com/glasnt
+[@crazydog115]: https://github.com/crazydog115
+[@RGBD]: https://github.com/RGBD
+[@panthomakos]: https://github.com/panthomakos
+[@matugm]: https://github.com/matugm
+[@m1foley]: https://github.com/m1foley

data/rubocop.gemspec

@@ -39,12 +39,12 @@ Gem::Specification.new do |s|
   s.summary = 'Automatic Ruby code style checking tool.'
 
   s.add_runtime_dependency('rainbow', '>= 1.99.1', '< 3.0')
-  s.add_runtime_dependency('parser', '>= 2.2.2.1', '< 3.0')
+  s.add_runtime_dependency('parser', '>= 2.2.2.5', '< 3.0')
   s.add_runtime_dependency('powerpack', '~> 0.1')
   s.add_runtime_dependency('astrolabe', '~> 1.3')
   s.add_runtime_dependency('ruby-progressbar', '~> 1.4')
   s.add_development_dependency('rake', '~> 10.1')
-  s.add_development_dependency('rspec', '~> 3.1.0')
+  s.add_development_dependency('rspec', '~> 3.2.0')
   s.add_development_dependency('yard', '~> 0.8')
   s.add_development_dependency('bundler', '~> 1.3')
   s.add_development_dependency('simplecov', '~> 0.7')

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop
 version: !ruby/object:Gem::Version
-  version: 0.31.0
+  version: 0.32.0
 platform: ruby
 authors:
 - Bozhidar Batsov
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-05 00:00:00.000000000 Z
+date: 2015-06-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rainbow
@@ -38,7 +38,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.2.2.1
+        version: 2.2.2.5
     - - "<"
       - !ruby/object:Gem::Version
         version: '3.0'
@@ -48,7 +48,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.2.2.1
+        version: 2.2.2.5
     - - "<"
       - !ruby/object:Gem::Version
         version: '3.0'
@@ -114,14 +114,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.1.0
+        version: 3.2.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.1.0
+        version: 3.2.0
 - !ruby/object:Gem::Dependency
   name: yard
   requirement: !ruby/object:Gem::Requirement
@@ -220,6 +220,7 @@ files:
 - lib/rubocop/cop/lint/literal_in_condition.rb
 - lib/rubocop/cop/lint/literal_in_interpolation.rb
 - lib/rubocop/cop/lint/loop.rb
+- lib/rubocop/cop/lint/nested_method_definition.rb
 - lib/rubocop/cop/lint/non_local_exit_from_iterator.rb
 - lib/rubocop/cop/lint/parentheses_as_grouped_expression.rb
 - lib/rubocop/cop/lint/require_parentheses.rb
@@ -229,6 +230,7 @@ files:
 - lib/rubocop/cop/lint/string_conversion_in_interpolation.rb
 - lib/rubocop/cop/lint/syntax.rb
 - lib/rubocop/cop/lint/underscore_prefixed_variable_name.rb
+- lib/rubocop/cop/lint/unneeded_disable.rb
 - lib/rubocop/cop/lint/unreachable_code.rb
 - lib/rubocop/cop/lint/unused_block_argument.rb
 - lib/rubocop/cop/lint/unused_method_argument.rb
@@ -281,7 +283,6 @@ files:
 - lib/rubocop/cop/performance/count.rb
 - lib/rubocop/cop/performance/detect.rb
 - lib/rubocop/cop/performance/flat_map.rb
-- lib/rubocop/cop/performance/parallel_assignment.rb
 - lib/rubocop/cop/performance/reverse_each.rb
 - lib/rubocop/cop/performance/sample.rb
 - lib/rubocop/cop/performance/size.rb
@@ -394,6 +395,7 @@ files:
 - lib/rubocop/cop/style/numeric_literals.rb
 - lib/rubocop/cop/style/one_line_conditional.rb
 - lib/rubocop/cop/style/op_method.rb
+- lib/rubocop/cop/style/parallel_assignment.rb
 - lib/rubocop/cop/style/parentheses_around_condition.rb
 - lib/rubocop/cop/style/percent_literal_delimiters.rb
 - lib/rubocop/cop/style/percent_q_literals.rb
@@ -432,6 +434,7 @@ files:
 - lib/rubocop/cop/style/space_inside_hash_literal_braces.rb
 - lib/rubocop/cop/style/space_inside_parens.rb
 - lib/rubocop/cop/style/space_inside_range_literal.rb
+- lib/rubocop/cop/style/space_inside_string_interpolation.rb
 - lib/rubocop/cop/style/special_global_vars.rb
 - lib/rubocop/cop/style/string_literals.rb
 - lib/rubocop/cop/style/string_literals_in_interpolation.rb
@@ -510,6 +513,7 @@ files:
 - relnotes/v0.30.0.md
 - relnotes/v0.30.1.md
 - relnotes/v0.31.0.md
+- relnotes/v0.32.0.md
 - rubocop.gemspec
 homepage: http://github.com/bbatsov/rubocop
 licenses:
@@ -531,7 +535,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: Automatic Ruby code style checking tool.