rubocop 0.30.1 → 0.31.0

data/lib/rubocop/rake_task.rb

@@ -53,8 +53,8 @@ module RuboCop
 
     def full_options
       [].tap do |result|
-        result.concat(formatters.flat_map { |f| ['--format', f] })
-        result.concat(requires.flat_map { |r| ['--require', r] })
+        result.concat(formatters.map { |f| ['--format', f] }.flatten)
+        result.concat(requires.map { |r| ['--require', r] }.flatten)
         result.concat(options)
         result.concat(patterns)
       end

data/lib/rubocop/runner.rb

@@ -140,27 +140,18 @@ module RuboCop
 
         if @options[:only]
           cop_classes.select! do |c|
-            cop_match?(c, @options[:only]) || @options[:lint] && c.lint?
+            c.match?(@options[:only]) || @options[:lint] && c.lint?
           end
         else
           filter_cop_classes(cop_classes, config)
         end
 
-        cop_classes.reject! { |c| cop_match?(c, @options[:except]) }
+        cop_classes.reject! { |c| c.match?(@options[:except]) }
 
         cop_classes
       end
     end
 
-    # Returns true if the cop name or the cop namespace matches any of the
-    # given names.
-    def cop_match?(cop, given_names)
-      return false unless given_names
-
-      given_names.include?(cop.cop_name) ||
-        given_names.include?(cop.cop_type.to_s.capitalize)
-    end
-
     def filter_cop_classes(cop_classes, config)
       # use only cops that link to a style guide if requested
       if style_guide_cops_only?(config)

data/lib/rubocop/string_util.rb

@@ -20,9 +20,11 @@ module RuboCop
 
       def initialize(a, b)
         if a.size < b.size
-          @shorter, @longer = a, b
+          @shorter = a
+          @longer = b
         else
-          @shorter, @longer = b, a
+          @shorter = b
+          @longer = a
         end
       end
 

data/lib/rubocop/token.rb

@@ -12,7 +12,9 @@ module RuboCop
     end
 
     def initialize(pos, type, text)
-      @pos, @type, @text = pos, type, text
+      @pos = pos
+      @type = type
+      @text = text
     end
 
     def to_s

data/lib/rubocop/version.rb

@@ -3,7 +3,7 @@
 module RuboCop
   # This module holds the RuboCop version information.
   module Version
-    STRING = '0.30.1'
+    STRING = '0.31.0'
 
     MSG = '%s (using Parser %s, running on %s %s %s)'
 

data/relnotes/v0.31.0.md

@@ -0,0 +1,120 @@
+### New features
+
+* `Rails/TimeZone` emits acceptable methods on a violation when `EnforcedStyle` is `:acceptable`. ([@l8nite][])
+* Recognize rackup file (config.ru) out of the box. ([@carhartl][])
+* [#1788](https://github.com/bbatsov/rubocop/pull/1788): New cop `ModuleLength` checks for overly long module definitions. ([@sdeframond][])
+* New cop `Performance/Count` to convert `Enumerable#select...size`, `Enumerable#reject...size`, `Enumerable#select...count`, `Enumerable#reject...count` `Enumerable#select...length`, and `Enumerable#reject...length` to `Enumerable#count`. ([@rrosenblum][])
+* `CommentAnnotation` cop does auto-correction. ([@dylandavidson][])
+* New cop `Style/TrailingUnderscoreVariable` to remove trailing underscore variables from mass assignment. ([@rrosenblum][])
+* [#1136](https://github.com/bbatsov/rubocop/issues/1136): New cop `Performance/ParallelAssignment` to avoid usages of unnessary parallel assignment. ([@rrosenblum][])
+* [#1278](https://github.com/bbatsov/rubocop/issues/1278): `DefEndAlignment` and `EndAlignment` cops do auto-correction. ([@lumeet][])
+* `IndentationWidth` cop follows the `AlignWith` option of the `DefEndAlignment` cop. ([@lumeet][])
+* [#1837](https://github.com/bbatsov/rubocop/issues/1837): New cop `EachWithObjectArgument` checks that `each_with_object` isn't called with an immutable object as argument. ([@jonas054][])
+* `ArrayJoin` cop does auto-correction. ([@tmr08c][])
+
+### Bugs fixed
+
+* [#1816](https://github.com/bbatsov/rubocop/issues/1816): Fix bug in `Sample` when calling `#shuffle` with something other than an element selector. ([@rrosenblum][])
+* [#1768](https://github.com/bbatsov/rubocop/pull/1768): `DefEndAlignment` recognizes preceding `private_class_method` or `public_class_method` before `def`. ([@til][])
+* [#1820](https://github.com/bbatsov/rubocop/issues/1820): Correct the logic in `AlignHash` for when to ignore a key because it's not on its own line. ([@jonas054][])
+* [#1829](https://github.com/bbatsov/rubocop/pull/1829): Fix bug in `Sample` and `FlatMap` that would cause them to report having been auto-corrected when they were not. ([@rrosenblum][])
+* [#1832](https://github.com/bbatsov/rubocop/pull/1832): Fix bug in `UnusedMethodArgument` that would cause them to report having been auto-corrected when they were not. ([@jonas054][])
+* [#1834](https://github.com/bbatsov/rubocop/issues/1834): Support only boolean values for `AutoCorrect` configuration parameter, and remove warning for unknown parameter. ([@jonas054][])
+* [#1843](https://github.com/bbatsov/rubocop/issues/1843): Fix crash in `TrailingBlankLines` when a file ends with a block comment without final newline. ([@jonas054][])
+* [#1849](https://github.com/bbatsov/rubocop/issues/1849): Fix bug where you can not have nested arrays in the Rake task configuration. ([@rrosenblum][])
+* Fix bug in `MultilineTernaryOperator` where it will not register an offense when only the false branch is on a separate line. ([@rrosenblum][])
+* Fix crash in `MultilineBlockLayout` when using new lambda literal syntax without parentheses. ([@hbd225][])
+* [#1859](https://github.com/bbatsov/rubocop/pull/1859): Fix bugs in `IfUnlessModifier` concerning comments and empty lines. ([@jonas054][])
+* Fix handling of trailing comma in `SpaceAroundBlockParameters` and `SpaceAfterComma`. ([@lumeet][])
+
+[@bbatsov]: https://github.com/bbatsov
+[@jonas054]: https://github.com/jonas054
+[@yujinakayama]: https://github.com/yujinakayama
+[@dblock]: https://github.com/dblock
+[@nevir]: https://github.com/nevir
+[@daviddavis]: https://github.com/daviddavis
+[@sds]: https://github.com/sds
+[@fancyremarker]: https://github.com/fancyremarker
+[@sinisterchipmunk]: https://github.com/sinisterchipmunk
+[@vonTronje]: https://github.com/vonTronje
+[@agrimm]: https://github.com/agrimm
+[@pmenglund]: https://github.com/pmenglund
+[@chulkilee]: https://github.com/chulkilee
+[@codez]: https://github.com/codez
+[@emou]: https://github.com/emou
+[@skanev]: http://github.com/skanev
+[@claco]: http://github.com/claco
+[@rifraf]: http://github.com/rifraf
+[@scottmatthewman]: https://github.com/scottmatthewman
+[@ma2gedev]: http://github.com/ma2gedev
+[@jeremyolliver]: https://github.com/jeremyolliver
+[@hannestyden]: https://github.com/hannestyden
+[@geniou]: https://github.com/geniou
+[@jkogara]: https://github.com/jkogara
+[@tmorris-fiksu]: https://github.com/tmorris-fiksu
+[@mockdeep]: https://github.com/mockdeep
+[@hiroponz]: https://github.com/hiroponz
+[@tamird]: https://github.com/tamird
+[@fshowalter]: https://github.com/fshowalter
+[@cschramm]: https://github.com/cschramm
+[@bquorning]: https://github.com/bquorning
+[@bcobb]: https://github.com/bcobb
+[@irrationalfab]: https://github.com/irrationalfab
+[@tommeier]: https://github.com/tommeier
+[@sfeldon]: https://github.com/sfeldon
+[@biinari]: https://github.com/biinari
+[@barunio]: https://github.com/barunio
+[@molawson]: https://github.com/molawson
+[@wndhydrnt]: https://github.com/wndhydrnt
+[@ggilder]: https://github.com/ggilder
+[@salbertson]: https://github.com/salbertson
+[@camilleldn]: https://github.com/camilleldn
+[@mcls]: https://github.com/mcls
+[@yous]: https://github.com/yous
+[@vrthra]: https://github.com/vrthra
+[@SkuliOskarsson]: https://github.com/SkuliOskarsson
+[@jspanjers]: https://github.com/jspanjers
+[@sch1zo]: https://github.com/sch1zo
+[@smangelsdorf]: https://github.com/smangelsdorf
+[@mvz]: https://github.com/mvz
+[@jfelchner]: https://github.com/jfelchner
+[@janraasch]: https://github.com/janraasch
+[@jcarbo]: https://github.com/jcarbo
+[@oneamtu]: https://github.com/oneamtu
+[@toy]: https://github.com/toy
+[@Koronen]: https://github.com/Koronen
+[@blainesch]: https://github.com/blainesch
+[@marxarelli]: https://github.com/marxarelli
+[@katieschilling]: https://github.com/katieschilling
+[@kakutani]: https://github.com/kakutani
+[@rrosenblum]: https://github.com/rrosenblum
+[@mattjmcnaughton]: https://github.com/mattjmcnaughton
+[@huerlisi]: https://github.com/huerlisi
+[@volkert]: https://github.com/volkert
+[@lumeet]: https://github.com/lumeet
+[@mmozuras]: https://github.com/mmozuras
+[@d4rk5eed]: https://github.com/d4rk5eed
+[@cshaffer]: https://github.com/cshaffer
+[@eitoball]: https://github.com/eitoball
+[@iainbeeston]: https://github.com/iainbeeston
+[@pimterry]: https://github.com/pimterry
+[@palkan]: https://github.com/palkan
+[@jdoconnor]: https://github.com/jdoconnor
+[@meganemura]: https://github.com/meganemura
+[@zvkemp]: https://github.com/zvkemp
+[@vassilevsky]: https://github.com/vassilevsky
+[@gerry3]: https://github.com/gerry3
+[@ypresto]: https://github.com/ypresto
+[@clowder]: https://github.com/clowder
+[@mudge]: https://github.com/mudge
+[@mzp]: https://github.com/mzp
+[@bankair]: https://github.com/bankair
+[@crimsonknave]: https://github.com/crimsonknave
+[@renuo]: https://github.com/renuo
+[@sdeframond]: https://github.com/sdeframond
+[@til]: https://github.com/til
+[@carhartl]: https://github.com/carhartl
+[@dylandavidson]: https://github.com/dylandavidson
+[@tmr08c]: https://github.com/tmr08c
+[@hbd225]: https://github.com/hbd225
+[@l8nite]: https://github.com/l8nite

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop
 version: !ruby/object:Gem::Version
-  version: 0.30.1
+  version: 0.31.0
 platform: ruby
 authors:
 - Bozhidar Batsov
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-04-21 00:00:00.000000000 Z
+date: 2015-05-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rainbow
@@ -207,6 +207,7 @@ files:
 - lib/rubocop/cop/lint/def_end_alignment.rb
 - lib/rubocop/cop/lint/deprecated_class_methods.rb
 - lib/rubocop/cop/lint/duplicate_methods.rb
+- lib/rubocop/cop/lint/each_with_object_argument.rb
 - lib/rubocop/cop/lint/else_layout.rb
 - lib/rubocop/cop/lint/empty_ensure.rb
 - lib/rubocop/cop/lint/empty_interpolation.rb
@@ -243,6 +244,7 @@ files:
 - lib/rubocop/cop/metrics/cyclomatic_complexity.rb
 - lib/rubocop/cop/metrics/line_length.rb
 - lib/rubocop/cop/metrics/method_length.rb
+- lib/rubocop/cop/metrics/module_length.rb
 - lib/rubocop/cop/metrics/parameter_lists.rb
 - lib/rubocop/cop/metrics/perceived_complexity.rb
 - lib/rubocop/cop/mixin/access_modifier_node.rb
@@ -251,6 +253,7 @@ files:
 - lib/rubocop/cop/mixin/autocorrect_alignment.rb
 - lib/rubocop/cop/mixin/autocorrect_unless_changing_ast.rb
 - lib/rubocop/cop/mixin/check_assignment.rb
+- lib/rubocop/cop/mixin/classish_length.rb
 - lib/rubocop/cop/mixin/code_length.rb
 - lib/rubocop/cop/mixin/configurable_enforced_style.rb
 - lib/rubocop/cop/mixin/configurable_max.rb
@@ -259,6 +262,7 @@ files:
 - lib/rubocop/cop/mixin/end_keyword_alignment.rb
 - lib/rubocop/cop/mixin/if_node.rb
 - lib/rubocop/cop/mixin/method_complexity.rb
+- lib/rubocop/cop/mixin/min_body_length.rb
 - lib/rubocop/cop/mixin/negative_conditional.rb
 - lib/rubocop/cop/mixin/on_method_def.rb
 - lib/rubocop/cop/mixin/on_normal_if_unless.rb
@@ -274,8 +278,10 @@ files:
 - lib/rubocop/cop/mixin/surrounding_space.rb
 - lib/rubocop/cop/mixin/unused_argument.rb
 - lib/rubocop/cop/offense.rb
+- lib/rubocop/cop/performance/count.rb
 - lib/rubocop/cop/performance/detect.rb
 - lib/rubocop/cop/performance/flat_map.rb
+- lib/rubocop/cop/performance/parallel_assignment.rb
 - lib/rubocop/cop/performance/reverse_each.rb
 - lib/rubocop/cop/performance/sample.rb
 - lib/rubocop/cop/performance/size.rb
@@ -436,6 +442,7 @@ files:
 - lib/rubocop/cop/style/tab.rb
 - lib/rubocop/cop/style/trailing_blank_lines.rb
 - lib/rubocop/cop/style/trailing_comma.rb
+- lib/rubocop/cop/style/trailing_underscore_variable.rb
 - lib/rubocop/cop/style/trailing_whitespace.rb
 - lib/rubocop/cop/style/trivial_accessors.rb
 - lib/rubocop/cop/style/unless_else.rb
@@ -502,6 +509,7 @@ files:
 - relnotes/v0.29.1.md
 - relnotes/v0.30.0.md
 - relnotes/v0.30.1.md
+- relnotes/v0.31.0.md
 - rubocop.gemspec
 homepage: http://github.com/bbatsov/rubocop
 licenses: