rubocop 0.25.0 → 0.26.0

data/spec/rubocop/formatter/simple_text_formatter_spec.rb

@@ -74,7 +74,9 @@ module RuboCop
           it 'handles pluralization correctly' do
             formatter.report_summary(0, 0, 0)
             expect(output.string).to eq(
-              "\n0 files inspected, no offenses detected\n")
+              ['',
+               '0 files inspected, no offenses detected',
+               ''].join("\n"))
           end
         end
 
@@ -82,7 +84,9 @@ module RuboCop
           it 'handles pluralization correctly' do
             formatter.report_summary(1, 0, 0)
             expect(output.string).to eq(
-              "\n1 file inspected, no offenses detected\n")
+              ['',
+               '1 file inspected, no offenses detected',
+               ''].join("\n"))
           end
         end
 
@@ -90,7 +94,9 @@ module RuboCop
           it 'handles pluralization correctly' do
             formatter.report_summary(1, 1, 0)
             expect(output.string).to eq(
-              "\n1 file inspected, 1 offense detected\n")
+              ['',
+               '1 file inspected, 1 offense detected',
+               ''].join("\n"))
           end
         end
 
@@ -98,7 +104,9 @@ module RuboCop
           it 'handles pluralization correctly' do
             formatter.report_summary(2, 2, 0)
             expect(output.string).to eq(
-              "\n2 files inspected, 2 offenses detected\n")
+              ['',
+               '2 files inspected, 2 offenses detected',
+               ''].join("\n"))
           end
         end
 
@@ -106,7 +114,9 @@ module RuboCop
           it 'prints about correction' do
             formatter.report_summary(1, 1, 1)
             expect(output.string).to eq(
-              "\n1 file inspected, 1 offense detected, 1 offense corrected\n")
+              ['',
+               '1 file inspected, 1 offense detected, 1 offense corrected',
+               ''].join("\n"))
           end
         end
 
@@ -114,7 +124,9 @@ module RuboCop
           it 'handles pluralization correctly' do
             formatter.report_summary(1, 1, 2)
             expect(output.string).to eq(
-              "\n1 file inspected, 1 offense detected, 2 offenses corrected\n")
+              ['',
+               '1 file inspected, 1 offense detected, 2 offenses corrected',
+               ''].join("\n"))
           end
         end
       end

data/spec/rubocop/options_spec.rb

@@ -53,6 +53,7 @@ Usage: rubocop [options] [file1, file2, ...]
                                        [fu]ubar
                                        [e]macs
                                        [j]son
+                                       [h]tml
                                        [fi]les
                                        [o]ffenses
                                        custom formatter class name

data/spec/rubocop/path_util_spec.rb

@@ -33,16 +33,18 @@ describe RuboCop::PathUtil do
         expect(subject.match_path?('dir/**', 'dir/sub/file', '.rubocop.yml'))
           .to be_truthy
         expect($stderr.string)
-          .to eq("Warning: Deprecated pattern style 'dir/**' in " \
-                 ".rubocop.yml. Change to 'dir/**/*'.\n")
+          .to eq(["Warning: Deprecated pattern style 'dir/**' in " \
+                  ".rubocop.yml. Change to 'dir/**/*'.",
+                  ''].join("\n"))
       end
 
       it 'matches strings to the basename and prints warning' do
         expect(subject.match_path?('file', 'dir/file', '.rubocop.yml'))
           .to be_truthy
         expect($stderr.string)
-          .to eq("Warning: Deprecated pattern style 'file' in .rubocop.yml. " \
-                 "Change to '**/file'.\n")
+          .to eq(["Warning: Deprecated pattern style 'file' in .rubocop.yml. " \
+                  "Change to '**/file'.",
+                  ''].join("\n"))
 
         expect(subject.match_path?('file', 'dir/files', '')).to be_falsey
         expect(subject.match_path?('dir', 'dir/file', '')).to be_falsey

data/spec/rubocop/processed_source_spec.rb

@@ -47,7 +47,7 @@ describe RuboCop::ProcessedSource do
 
   describe '#ast' do
     it 'is the root node of AST' do
-      expect(processed_source.ast).to be_a(Parser::AST::Node)
+      expect(processed_source.ast).to be_a(Astrolabe::Node)
     end
   end
 
@@ -81,6 +81,22 @@ describe RuboCop::ProcessedSource do
       end
     end
 
+    context 'when the source lacks encoding comment and is really utf-8 ' \
+            'encoded but has been read as US-ASCII' do
+      let(:source) do
+        # When files are read into RuboCop, the encoding of source code lacking
+        # an encoding comment will default to the external encoding, which
+        # could for example be US-ASCII if the LC_ALL environment variable is
+        # set to "C".
+        '号码 = 3'.force_encoding('US-ASCII')
+      end
+
+      it 'is nil' do
+        # ProcessedSource#parse sets UTF-8 as default encoding, so no error.
+        expect(processed_source.parser_error).to be_nil
+      end
+    end
+
     context 'when the source could not be parsed due to encoding error' do
       include_context 'invalid encoding source'
 

data/spec/rubocop/string_util_spec.rb

@@ -0,0 +1,46 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+module RuboCop
+  module StringUtil
+    describe Jaro do
+      {
+        %w(foo foo)       => 1.000,
+        %w(foo bar)       => 0.000,
+        %w(martha marhta) => 0.944,
+        %w(dwayne duane)  => 0.822
+      }.each do |strings, expected|
+        context "with #{strings.first.inspect} and #{strings.last.inspect}" do
+          subject(:distance) { Jaro.distance(*strings) }
+
+          it "returns #{expected}" do
+            expect(distance).to be_within(0.001).of(expected)
+          end
+        end
+      end
+    end
+
+    describe JaroWinkler do
+      # These samples are derived from Apache Lucene project.
+      # https://github.com/apache/lucene-solr/blob/lucene_solr_4_9_0/lucene/suggest/src/test/org/apache/lucene/search/spell/TestJaroWinklerDistance.java
+      {
+        %w(al al)             => 1.000,
+        %w(martha marhta)     => 0.961,
+        %w(jones johnson)     => 0.832,
+        %w(abcvwxyz cabvwxyz) => 0.958,
+        %w(dwayne duane)      => 0.840,
+        %w(dixon dicksonx)    => 0.813,
+        %w(fvie ten)          => 0.000
+      }.each do |strings, expected|
+        context "with #{strings.first.inspect} and #{strings.last.inspect}" do
+          subject(:distance) { JaroWinkler.distance(*strings) }
+
+          it "returns #{expected}" do
+            expect(distance).to be_within(0.001).of(expected)
+          end
+        end
+      end
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop
 version: !ruby/object:Gem::Version
-  version: 0.25.0
+  version: 0.26.0
 platform: ruby
 authors:
 - Bozhidar Batsov
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-08-15 00:00:00.000000000 Z
+date: 2014-09-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rainbow
@@ -66,6 +66,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 0.0.6
+- !ruby/object:Gem::Dependency
+  name: astrolabe
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.3'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.3'
 - !ruby/object:Gem::Dependency
   name: ruby-progressbar
   requirement: !ruby/object:Gem::Requirement
@@ -173,6 +187,7 @@ files:
 - LICENSE.txt
 - README.md
 - Rakefile
+- assets/output.html.erb
 - bin/rubocop
 - config/default.yml
 - config/disabled.yml
@@ -326,6 +341,7 @@ files:
 - lib/rubocop/cop/style/indent_hash.rb
 - lib/rubocop/cop/style/indentation_consistency.rb
 - lib/rubocop/cop/style/indentation_width.rb
+- lib/rubocop/cop/style/infinite_loop.rb
 - lib/rubocop/cop/style/inline_comment.rb
 - lib/rubocop/cop/style/lambda.rb
 - lib/rubocop/cop/style/lambda_call.rb
@@ -386,9 +402,11 @@ files:
 - lib/rubocop/cop/style/space_inside_brackets.rb
 - lib/rubocop/cop/style/space_inside_hash_literal_braces.rb
 - lib/rubocop/cop/style/space_inside_parens.rb
+- lib/rubocop/cop/style/space_inside_range_literal.rb
 - lib/rubocop/cop/style/special_global_vars.rb
 - lib/rubocop/cop/style/string_literals.rb
 - lib/rubocop/cop/style/symbol_array.rb
+- lib/rubocop/cop/style/symbol_proc.rb
 - lib/rubocop/cop/style/tab.rb
 - lib/rubocop/cop/style/trailing_blank_lines.rb
 - lib/rubocop/cop/style/trailing_comma.rb
@@ -422,6 +440,7 @@ files:
 - lib/rubocop/formatter/file_list_formatter.rb
 - lib/rubocop/formatter/formatter_set.rb
 - lib/rubocop/formatter/fuubar_style_formatter.rb
+- lib/rubocop/formatter/html_formatter.rb
 - lib/rubocop/formatter/json_formatter.rb
 - lib/rubocop/formatter/offense_count_formatter.rb
 - lib/rubocop/formatter/progress_formatter.rb
@@ -431,6 +450,7 @@ files:
 - lib/rubocop/processed_source.rb
 - lib/rubocop/rake_task.rb
 - lib/rubocop/runner.rb
+- lib/rubocop/string_util.rb
 - lib/rubocop/target_finder.rb
 - lib/rubocop/token.rb
 - lib/rubocop/version.rb
@@ -444,6 +464,7 @@ files:
 - relnotes/v0.24.0.md
 - relnotes/v0.24.1.md
 - relnotes/v0.25.0.md
+- relnotes/v0.26.0.md
 - rubocop.gemspec
 - spec/.rubocop.yml
 - spec/isolated_environment_spec.rb
@@ -570,6 +591,7 @@ files:
 - spec/rubocop/cop/style/indent_hash_spec.rb
 - spec/rubocop/cop/style/indentation_consistency_spec.rb
 - spec/rubocop/cop/style/indentation_width_spec.rb
+- spec/rubocop/cop/style/infinite_loop_spec.rb
 - spec/rubocop/cop/style/inline_comment_spec.rb
 - spec/rubocop/cop/style/lambda_call_spec.rb
 - spec/rubocop/cop/style/lambda_spec.rb
@@ -630,9 +652,11 @@ files:
 - spec/rubocop/cop/style/space_inside_brackets_spec.rb
 - spec/rubocop/cop/style/space_inside_hash_literal_braces_spec.rb
 - spec/rubocop/cop/style/space_inside_parens_spec.rb
+- spec/rubocop/cop/style/space_inside_range_literal_spec.rb
 - spec/rubocop/cop/style/special_global_vars_spec.rb
 - spec/rubocop/cop/style/string_literals_spec.rb
 - spec/rubocop/cop/style/symbol_array_spec.rb
+- spec/rubocop/cop/style/symbol_proc_spec.rb
 - spec/rubocop/cop/style/tab_spec.rb
 - spec/rubocop/cop/style/trailing_blank_lines_spec.rb
 - spec/rubocop/cop/style/trailing_comma_spec.rb
@@ -664,6 +688,7 @@ files:
 - spec/rubocop/formatter/file_list_formatter_spec.rb
 - spec/rubocop/formatter/formatter_set_spec.rb
 - spec/rubocop/formatter/fuubar_style_formatter_spec.rb
+- spec/rubocop/formatter/html_formatter_spec.rb
 - spec/rubocop/formatter/json_formatter_spec.rb
 - spec/rubocop/formatter/offense_count_formatter_spec.rb
 - spec/rubocop/formatter/progress_formatter_spec.rb
@@ -672,10 +697,10 @@ files:
 - spec/rubocop/path_util_spec.rb
 - spec/rubocop/processed_source_spec.rb
 - spec/rubocop/runner_spec.rb
+- spec/rubocop/string_util_spec.rb
 - spec/rubocop/target_finder_spec.rb
 - spec/rubocop/token_spec.rb
 - spec/spec_helper.rb
-- spec/support/ast_helper.rb
 - spec/support/file_helper.rb
 - spec/support/isolated_environment.rb
 - spec/support/mri_syntax_checker.rb
@@ -833,6 +858,7 @@ test_files:
 - spec/rubocop/cop/style/indent_hash_spec.rb
 - spec/rubocop/cop/style/indentation_consistency_spec.rb
 - spec/rubocop/cop/style/indentation_width_spec.rb
+- spec/rubocop/cop/style/infinite_loop_spec.rb
 - spec/rubocop/cop/style/inline_comment_spec.rb
 - spec/rubocop/cop/style/lambda_call_spec.rb
 - spec/rubocop/cop/style/lambda_spec.rb
@@ -893,9 +919,11 @@ test_files:
 - spec/rubocop/cop/style/space_inside_brackets_spec.rb
 - spec/rubocop/cop/style/space_inside_hash_literal_braces_spec.rb
 - spec/rubocop/cop/style/space_inside_parens_spec.rb
+- spec/rubocop/cop/style/space_inside_range_literal_spec.rb
 - spec/rubocop/cop/style/special_global_vars_spec.rb
 - spec/rubocop/cop/style/string_literals_spec.rb
 - spec/rubocop/cop/style/symbol_array_spec.rb
+- spec/rubocop/cop/style/symbol_proc_spec.rb
 - spec/rubocop/cop/style/tab_spec.rb
 - spec/rubocop/cop/style/trailing_blank_lines_spec.rb
 - spec/rubocop/cop/style/trailing_comma_spec.rb
@@ -927,6 +955,7 @@ test_files:
 - spec/rubocop/formatter/file_list_formatter_spec.rb
 - spec/rubocop/formatter/formatter_set_spec.rb
 - spec/rubocop/formatter/fuubar_style_formatter_spec.rb
+- spec/rubocop/formatter/html_formatter_spec.rb
 - spec/rubocop/formatter/json_formatter_spec.rb
 - spec/rubocop/formatter/offense_count_formatter_spec.rb
 - spec/rubocop/formatter/progress_formatter_spec.rb
@@ -935,10 +964,10 @@ test_files:
 - spec/rubocop/path_util_spec.rb
 - spec/rubocop/processed_source_spec.rb
 - spec/rubocop/runner_spec.rb
+- spec/rubocop/string_util_spec.rb
 - spec/rubocop/target_finder_spec.rb
 - spec/rubocop/token_spec.rb
 - spec/spec_helper.rb
-- spec/support/ast_helper.rb
 - spec/support/file_helper.rb
 - spec/support/isolated_environment.rb
 - spec/support/mri_syntax_checker.rb

data/spec/support/ast_helper.rb

@@ -1,15 +0,0 @@
-# encoding: utf-8
-
-module ASTHelper
-  def scan_node(node, options = {}, &block)
-    yield node if options[:include_origin_node]
-
-    node.children.each do |child|
-      next unless child.is_a?(Parser::AST::Node)
-      yield child
-      scan_node(child, &block)
-    end
-
-    nil
-  end
-end