rubocop 0.21.0 → 0.22.0

data/spec/rubocop/cop/style/self_assignment_spec.rb

@@ -5,7 +5,7 @@ require 'spec_helper'
 describe Rubocop::Cop::Style::SelfAssignment do
   subject(:cop) { described_class.new }
 
-  described_class::OPS.product(['x', '@x', '@@x']).each do |op, var|
+  [:+, :-, :*, :**, :/, :|, :&].product(['x', '@x', '@@x']).each do |op, var|
     it "registers an offense for non-shorthand assignment #{op} and #{var}" do
       inspect_source(cop,
                      ["#{var} = #{var} #{op} y"])

data/spec/rubocop/cop/style/space_around_operators_spec.rb

@@ -246,6 +246,7 @@ describe Rubocop::Cop::Style::SpaceAroundOperators do
 
   it 'accepts unary operators without space' do
     inspect_source(cop, ['[].map(&:size)',
+                         'a.(b)',
                          '-3',
                          'arr.collect { |e| -e }',
                          'x = +2'])

data/spec/rubocop/cop/style/space_before_comment_spec.rb

@@ -0,0 +1,34 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Rubocop::Cop::Style::SpaceBeforeComment do
+  subject(:cop) { described_class.new }
+
+  it 'registers an offense for missing space before an EOL comment' do
+    inspect_source(cop, ['a += 1# increment'])
+    expect(cop.highlights).to eq(['# increment'])
+  end
+
+  it 'accepts an EOL comment with a preceding space' do
+    inspect_source(cop, ['a += 1 # increment'])
+    expect(cop.offenses).to be_empty
+  end
+
+  it 'accepts a comment that begins a line' do
+    inspect_source(cop, ['# comment'])
+    expect(cop.offenses).to be_empty
+  end
+
+  it 'accepts a doc comment' do
+    inspect_source(cop, ['=begin',
+                         'Doc comment',
+                         '=end'])
+    expect(cop.offenses).to be_empty
+  end
+
+  it 'auto-corrects missing space' do
+    new_source = autocorrect_source(cop, 'a += 1# increment')
+    expect(new_source).to eq('a += 1 # increment')
+  end
+end

data/spec/rubocop/cop/style/unneeded_percent_x_spec.rb

@@ -0,0 +1,34 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Rubocop::Cop::Style::UnneededPercentX do
+  subject(:cop) { described_class.new }
+
+  it 'registers an offense for a %x string without backquotes' do
+    inspect_source(cop, '%x(ls)')
+    expect(cop.messages)
+      .to eq(['Do not use `%x` unless the command string contains ' \
+              'backquotes.'])
+  end
+
+  it 'accepts a %x string with backquotes' do
+    inspect_source(cop, '%x(echo `ls`)')
+    expect(cop.offenses).to be_empty
+  end
+
+  it 'accepts a `` string without inner backquotes' do
+    inspect_source(cop, '`ls`')
+    expect(cop.offenses).to be_empty
+  end
+
+  it 'accepts a `` string with inner backquotes' do
+    inspect_source(cop, '`echo \`ls\``')
+    expect(cop.offenses).to be_empty
+  end
+
+  it 'auto-corrects' do
+    new_source = autocorrect_source(cop, '%x(ls)')
+    expect(new_source).to eq('`ls`')
+  end
+end

data/spec/rubocop/cop/style/while_until_modifier_spec.rb

@@ -7,7 +7,7 @@ describe Rubocop::Cop::Style::WhileUntilModifier do
 
   subject(:cop) { described_class.new(config) }
   let(:config) do
-    hash = { 'LineLength' => { 'Max' => 79 } }
+    hash = { 'LineLength' => { 'Max' => 80 } }
     Rubocop::Config.new(hash)
   end
 
@@ -77,7 +77,7 @@ describe Rubocop::Cop::Style::WhileUntilModifier do
     let(:config) do
       hash = {
         'LineLength' => { 'Max' => 100 },
-        'WhileUntilModifier' => { 'MaxLineLength' => 79 }
+        'WhileUntilModifier' => { 'MaxLineLength' => 80 }
       }
       Rubocop::Config.new(hash)
     end

data/spec/rubocop/cop/util_spec.rb

@@ -34,14 +34,14 @@ describe Rubocop::Cop::Util do
 
     context 'when Source::Range object is passed' do
       it 'returns line range of that' do
-        line_range = Rubocop::Cop::Util.line_range(node.loc.expression)
+        line_range = described_class.line_range(node.loc.expression)
         expect(line_range).to eq(3..7)
       end
     end
 
     context 'when AST::Node object is passed' do
       it 'returns line range of the expression' do
-        line_range = Rubocop::Cop::Util.line_range(node)
+        line_range = described_class.line_range(node)
         expect(line_range).to eq(3..7)
       end
     end

data/spec/rubocop/cop/variable_force_spec.rb

@@ -5,7 +5,7 @@ require 'spec_helper'
 describe Rubocop::Cop::VariableForce do
   include AST::Sexp
 
-  subject(:force) { Rubocop::Cop::VariableForce.new([]) }
+  subject(:force) { described_class.new([]) }
 
   describe '#process_node' do
     before do

data/spec/rubocop/formatter/disabled_config_formatter_spec.rb

@@ -11,7 +11,7 @@ module Rubocop
       let(:output) do
         o = StringIO.new
         def o.path
-          'rubocop-todo.yml'
+          '.rubocop_todo.yml'
         end
         o
       end
@@ -38,9 +38,9 @@ module Rubocop
                                        '  Enabled: false',
                                        ''].join("\n"))
           expect($stdout.string)
-            .to eq(['Created rubocop-todo.yml.',
-                    'Run `rubocop --config rubocop-todo.yml`, or',
-                    'add inherit_from: rubocop-todo.yml in a .rubocop.yml ' \
+            .to eq(['Created .rubocop_todo.yml.',
+                    'Run `rubocop --config .rubocop_todo.yml`, or',
+                    'add inherit_from: .rubocop_todo.yml in a .rubocop.yml ' \
                     'file.',
                     ''].join("\n"))
         end

data/spec/rubocop/formatter/disabled_lines_formatter_spec.rb

@@ -25,7 +25,7 @@ module Rubocop
 
         context 'when no disable cop comments are detected' do
           let(:cop_disabled_line_ranges) { {} }
-          it 'shouldn\'t add to cop_disabled_line_ranges' do
+          it 'does not add to cop_disabled_line_ranges' do
             expect { file_started }.to_not(
             change { formatter.cop_disabled_line_ranges })
           end
@@ -35,7 +35,7 @@ module Rubocop
           let(:cop_disabled_line_ranges) do
             { cop_disabled_line_ranges: { 'LineLength' => [1..1] } }
           end
-          it 'should merge the changes into cop_disabled_line_ranges' do
+          it 'merges the changes into cop_disabled_line_ranges' do
             expect { file_started }.to(
             change { formatter.cop_disabled_line_ranges })
           end

data/spec/rubocop/formatter/offense_count_formatter_spec.rb

@@ -23,14 +23,14 @@ module Rubocop
 
         context 'when no offenses are detected' do
           let(:offenses) { [] }
-          it 'shouldn\'t add to offense_counts' do
+          it 'does not add to offense_counts' do
             expect { finish }.to_not change { formatter.offense_counts }
           end
         end
 
         context 'when any offenses are detected' do
           let(:offenses) { [double('offense', cop_name: 'OffendedCop')] }
-          it 'should increment the count for the cop in offense_counts' do
+          it 'increments the count for the cop in offense_counts' do
             expect { finish }.to change { formatter.offense_counts }
           end
         end

data/spec/rubocop/options_spec.rb

@@ -65,6 +65,9 @@ Usage: rubocop [options] [file1, file2, ...]
         --show-cops [COP1,COP2,...]  Shows the given cops, or all cops by
                                      default, and their configurations for the
                                      current directory.
+    -F, --fail-fast                  Inspect files in order of modification
+                                     time and stop after the first file
+                                     containing offenses.
     -d, --debug                      Display debug info.
     -D, --display-cop-names          Display cop names in offense messages.
     -R, --rails                      Run extra Rails cops.

data/spec/support/shared_context.rb

@@ -8,9 +8,7 @@ shared_context 'config', :config do
       fail '`config` must be used in `describe SomeCopClass do .. end`'
     end
 
-    unless cop_config.is_a?(Hash)
-      fail '`cop_config` must be declared with #let'
-    end
+    fail '`cop_config` must be declared with #let' unless cop_config.is_a?(Hash)
 
     cop_name = described_class.cop_name
     hash = {

data/spec/support/statement_modifier_helper.rb

@@ -19,8 +19,8 @@ module StatementModifierHelper
   def check_too_long(cop, keyword)
     # This statement is one character too long to fit.
     condition = 'a' * (40 - keyword.length)
-    body = 'b' * 36
-    expect("  #{body} #{keyword} #{condition}".length).to eq(80)
+    body = 'b' * 37
+    expect("  #{body} #{keyword} #{condition}".length).to eq(81)
 
     inspect_source(cop,
                    ["  #{keyword} #{condition}",

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop
 version: !ruby/object:Gem::Version
-  version: 0.21.0
+  version: 0.22.0
 platform: ruby
 authors:
 - Bozhidar Batsov
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-24 00:00:00.000000000 Z
+date: 2014-05-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rainbow
@@ -176,6 +176,7 @@ files:
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
+- ".rubocop_todo.yml"
 - ".travis.yml"
 - ".yardopts"
 - CHANGELOG.md
@@ -256,6 +257,7 @@ files:
 - lib/rubocop/cop/mixin/statement_modifier.rb
 - lib/rubocop/cop/mixin/string_help.rb
 - lib/rubocop/cop/mixin/surrounding_space.rb
+- lib/rubocop/cop/mixin/unused_argument.rb
 - lib/rubocop/cop/offense.rb
 - lib/rubocop/cop/rails/action_filter.rb
 - lib/rubocop/cop/rails/default_scope.rb
@@ -293,6 +295,7 @@ files:
 - lib/rubocop/cop/style/collection_methods.rb
 - lib/rubocop/cop/style/colon_method_call.rb
 - lib/rubocop/cop/style/comment_annotation.rb
+- lib/rubocop/cop/style/comment_indentation.rb
 - lib/rubocop/cop/style/constant_name.rb
 - lib/rubocop/cop/style/cyclomatic_complexity.rb
 - lib/rubocop/cop/style/def_with_parentheses.rb
@@ -300,6 +303,7 @@ files:
 - lib/rubocop/cop/style/documentation.rb
 - lib/rubocop/cop/style/dot_position.rb
 - lib/rubocop/cop/style/double_negation.rb
+- lib/rubocop/cop/style/each_with_object.rb
 - lib/rubocop/cop/style/empty_line_between_defs.rb
 - lib/rubocop/cop/style/empty_lines.rb
 - lib/rubocop/cop/style/empty_lines_around_access_modifier.rb
@@ -339,6 +343,7 @@ files:
 - lib/rubocop/cop/style/negated_if.rb
 - lib/rubocop/cop/style/negated_while.rb
 - lib/rubocop/cop/style/nested_ternary_operator.rb
+- lib/rubocop/cop/style/next.rb
 - lib/rubocop/cop/style/nil_comparison.rb
 - lib/rubocop/cop/style/non_nil_check.rb
 - lib/rubocop/cop/style/not.rb
@@ -373,6 +378,7 @@ files:
 - lib/rubocop/cop/style/space_around_equals_in_parameter_default.rb
 - lib/rubocop/cop/style/space_around_operators.rb
 - lib/rubocop/cop/style/space_before_block_braces.rb
+- lib/rubocop/cop/style/space_before_comment.rb
 - lib/rubocop/cop/style/space_before_modifier_keyword.rb
 - lib/rubocop/cop/style/space_inside_block_braces.rb
 - lib/rubocop/cop/style/space_inside_brackets.rb
@@ -388,6 +394,7 @@ files:
 - lib/rubocop/cop/style/trivial_accessors.rb
 - lib/rubocop/cop/style/unless_else.rb
 - lib/rubocop/cop/style/unneeded_capital_w.rb
+- lib/rubocop/cop/style/unneeded_percent_x.rb
 - lib/rubocop/cop/style/variable_interpolation.rb
 - lib/rubocop/cop/style/variable_name.rb
 - lib/rubocop/cop/style/when_then.rb
@@ -430,7 +437,7 @@ files:
 - relnotes/v0.20.0.md
 - relnotes/v0.20.1.md
 - relnotes/v0.21.0.md
-- rubocop-todo.yml
+- relnotes/v0.22.0.md
 - rubocop.gemspec
 - spec/.rubocop.yml
 - spec/isolated_environment_spec.rb
@@ -517,6 +524,7 @@ files:
 - spec/rubocop/cop/style/collection_methods_spec.rb
 - spec/rubocop/cop/style/colon_method_call_spec.rb
 - spec/rubocop/cop/style/comment_annotation_spec.rb
+- spec/rubocop/cop/style/comment_indentation_spec.rb
 - spec/rubocop/cop/style/constant_name_spec.rb
 - spec/rubocop/cop/style/cyclomatic_complexity_spec.rb
 - spec/rubocop/cop/style/def_with_parentheses_spec.rb
@@ -524,6 +532,7 @@ files:
 - spec/rubocop/cop/style/documentation_spec.rb
 - spec/rubocop/cop/style/dot_position_spec.rb
 - spec/rubocop/cop/style/double_negation_spec.rb
+- spec/rubocop/cop/style/each_with_object_spec.rb
 - spec/rubocop/cop/style/empty_line_between_defs_spec.rb
 - spec/rubocop/cop/style/empty_lines_around_access_modifier_spec.rb
 - spec/rubocop/cop/style/empty_lines_around_body_spec.rb
@@ -563,6 +572,7 @@ files:
 - spec/rubocop/cop/style/negated_if_spec.rb
 - spec/rubocop/cop/style/negated_while_spec.rb
 - spec/rubocop/cop/style/nested_ternary_operator_spec.rb
+- spec/rubocop/cop/style/next_spec.rb
 - spec/rubocop/cop/style/nil_comparison_spec.rb
 - spec/rubocop/cop/style/non_nil_check_spec.rb
 - spec/rubocop/cop/style/not_spec.rb
@@ -597,6 +607,7 @@ files:
 - spec/rubocop/cop/style/space_around_equals_in_parameter_default_spec.rb
 - spec/rubocop/cop/style/space_around_operators_spec.rb
 - spec/rubocop/cop/style/space_before_block_braces_spec.rb
+- spec/rubocop/cop/style/space_before_comment_spec.rb
 - spec/rubocop/cop/style/space_before_modifier_keyword_spec.rb
 - spec/rubocop/cop/style/space_inside_block_braces_spec.rb
 - spec/rubocop/cop/style/space_inside_brackets_spec.rb
@@ -612,6 +623,7 @@ files:
 - spec/rubocop/cop/style/trivial_accessors_spec.rb
 - spec/rubocop/cop/style/unless_else_spec.rb
 - spec/rubocop/cop/style/unneeded_capital_w_spec.rb
+- spec/rubocop/cop/style/unneeded_percent_x_spec.rb
 - spec/rubocop/cop/style/variable_interpolation_spec.rb
 - spec/rubocop/cop/style/variable_name_spec.rb
 - spec/rubocop/cop/style/when_then_spec.rb
@@ -764,6 +776,7 @@ test_files:
 - spec/rubocop/cop/style/collection_methods_spec.rb
 - spec/rubocop/cop/style/colon_method_call_spec.rb
 - spec/rubocop/cop/style/comment_annotation_spec.rb
+- spec/rubocop/cop/style/comment_indentation_spec.rb
 - spec/rubocop/cop/style/constant_name_spec.rb
 - spec/rubocop/cop/style/cyclomatic_complexity_spec.rb
 - spec/rubocop/cop/style/def_with_parentheses_spec.rb
@@ -771,6 +784,7 @@ test_files:
 - spec/rubocop/cop/style/documentation_spec.rb
 - spec/rubocop/cop/style/dot_position_spec.rb
 - spec/rubocop/cop/style/double_negation_spec.rb
+- spec/rubocop/cop/style/each_with_object_spec.rb
 - spec/rubocop/cop/style/empty_line_between_defs_spec.rb
 - spec/rubocop/cop/style/empty_lines_around_access_modifier_spec.rb
 - spec/rubocop/cop/style/empty_lines_around_body_spec.rb
@@ -810,6 +824,7 @@ test_files:
 - spec/rubocop/cop/style/negated_if_spec.rb
 - spec/rubocop/cop/style/negated_while_spec.rb
 - spec/rubocop/cop/style/nested_ternary_operator_spec.rb
+- spec/rubocop/cop/style/next_spec.rb
 - spec/rubocop/cop/style/nil_comparison_spec.rb
 - spec/rubocop/cop/style/non_nil_check_spec.rb
 - spec/rubocop/cop/style/not_spec.rb
@@ -844,6 +859,7 @@ test_files:
 - spec/rubocop/cop/style/space_around_equals_in_parameter_default_spec.rb
 - spec/rubocop/cop/style/space_around_operators_spec.rb
 - spec/rubocop/cop/style/space_before_block_braces_spec.rb
+- spec/rubocop/cop/style/space_before_comment_spec.rb
 - spec/rubocop/cop/style/space_before_modifier_keyword_spec.rb
 - spec/rubocop/cop/style/space_inside_block_braces_spec.rb
 - spec/rubocop/cop/style/space_inside_brackets_spec.rb
@@ -859,6 +875,7 @@ test_files:
 - spec/rubocop/cop/style/trivial_accessors_spec.rb
 - spec/rubocop/cop/style/unless_else_spec.rb
 - spec/rubocop/cop/style/unneeded_capital_w_spec.rb
+- spec/rubocop/cop/style/unneeded_percent_x_spec.rb
 - spec/rubocop/cop/style/variable_interpolation_spec.rb
 - spec/rubocop/cop/style/variable_name_spec.rb
 - spec/rubocop/cop/style/when_then_spec.rb