rubocop 0.15.0 → 0.16.0

data/lib/rubocop/cop/style/reduce_arguments.rb

@@ -1,34 +0,0 @@
-# encoding: utf-8
-
-module Rubocop
-  module Cop
-    module Style
-      # This cop checks whether the block arguments of a single-line
-      # reduce(inject) call are named *a*(for accumulator) and *e*
-      # (for element).
-      class ReduceArguments < Cop
-        MSG = 'Name reduce block arguments |a, e| (accumulator, element).'
-
-        ARGS_NODE = s(:args, s(:arg, :a), s(:arg, :e))
-
-        def on_block(node)
-          # we care only for single line blocks
-          return unless Util.block_length(node) == 0
-
-          method_node, args_node, _body_node = *node
-          receiver, method_name, _method_args = *method_node
-
-          # discard other scenarios
-          return unless receiver
-          return unless [:reduce, :inject].include?(method_name)
-
-          # discard second argument destructuring
-          _, element_node = *args_node
-          return unless element_node.type == :arg
-
-          convention(args_node, :expression) unless args_node == ARGS_NODE
-        end
-      end
-    end
-  end
-end

data/lib/rubocop/cop/style/symbol_name.rb

@@ -1,45 +0,0 @@
-# encoding: utf-8
-
-module Rubocop
-  module Cop
-    module Style
-      # This cop checks whether symbol names are snake_case.
-      # There's also an option to accept CamelCase symbol names as well.
-      # There's also an option to accept symbol names with dots as well.
-      class SymbolName < Cop
-        MSG = 'Use snake_case for symbols.'
-        SNAKE_CASE = /^[\da-z_]+[!?=]?$/
-        SNAKE_CASE_WITH_DOTS = /^[\da-z_\.]+[!?=]?$/
-        CAMEL_CASE = /^[A-Z][A-Za-z\d]*$/
-
-        def allow_camel_case?
-          cop_config['AllowCamelCase']
-        end
-
-        def allow_dots?
-          cop_config['AllowDots']
-        end
-
-        def on_send(node)
-          receiver, method_name, *args = *node
-          # Arguments to Module#private_constant are symbols referring to
-          # existing constants, so they will start with an upper case letter.
-          # We ignore these symbols.
-          if receiver.nil? && method_name == :private_constant
-            args.each { |a| ignore_node(a) }
-          end
-        end
-
-        def on_sym(node)
-          return if ignored_node?(node)
-          sym_name = node.to_a[0]
-          return unless sym_name =~ /^[a-zA-Z]/
-          return if sym_name =~ SNAKE_CASE
-          return if allow_camel_case? && sym_name =~ CAMEL_CASE
-          return if allow_dots? && sym_name =~ SNAKE_CASE_WITH_DOTS
-          convention(node, :expression)
-        end
-      end
-    end
-  end
-end

data/spec/rubocop/cop/style/def_without_parentheses_spec.rb

@@ -1,33 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe Rubocop::Cop::Style::DefWithoutParentheses do
-  subject(:cop) { described_class.new }
-
-  it 'reports an offence for def with parameters but no parens' do
-    src = ['def func a, b',
-           'end']
-    inspect_source(cop, src)
-    expect(cop.offences.size).to eq(1)
-  end
-
-  it 'reports an offence for class def with parameters but no parens' do
-    src = ['def Test.func a, b',
-           'end']
-    inspect_source(cop, src)
-    expect(cop.offences.size).to eq(1)
-  end
-
-  it 'accepts def with no args and no parens' do
-    src = ['def func',
-           'end']
-    inspect_source(cop, src)
-    expect(cop.offences).to be_empty
-  end
-
-  it 'auto-adds required parens' do
-    new_source = autocorrect_source(cop, 'def test param; end')
-    expect(new_source).to eq('def test (param); end')
-  end
-end

data/spec/rubocop/cop/style/symbol_name_spec.rb

@@ -1,138 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe Rubocop::Cop::Style::SymbolName, :config do
-  subject(:cop) { described_class.new(config) }
-  let(:cop_config) { { 'AllowCamelCase' => true } }
-
-  context 'when AllowCamelCase is true' do
-    let(:cop_config) { { 'AllowCamelCase' => true } }
-
-    it 'does not register an offence for camel case in names' do
-      inspect_source(cop,
-                     ['test = :BadIdea'])
-      expect(cop.offences).to be_empty
-    end
-  end
-
-  context 'when AllowCamelCase is false' do
-    let(:cop_config) { { 'AllowCamelCase' => false } }
-
-    it 'registers an offence for camel case in names' do
-      inspect_source(cop,
-                     ['test = :BadIdea'])
-      expect(cop.messages).to eq(
-        ['Use snake_case for symbols.'])
-    end
-  end
-
-  context 'when AllowDots is true' do
-    let(:cop_config) { { 'AllowDots' => true } }
-
-    it 'does not register an offence for dots in names' do
-      inspect_source(cop,
-                     ['test = :"bad.idea"'])
-      expect(cop.offences).to be_empty
-    end
-  end
-
-  context 'when AllowDots is false' do
-    let(:cop_config) { { 'AllowDots' => false } }
-
-    it 'registers an offence for dots in names' do
-      inspect_source(cop,
-                     ['test = :"bad.idea"'])
-      expect(cop.offences.map(&:message)).to eq(
-        ['Use snake_case for symbols.'])
-    end
-  end
-
-  it 'registers an offence for symbol used as hash label' do
-    inspect_source(cop,
-                   ['{ KEY_ONE: 1, KEY_TWO: 2 }'])
-    expect(cop.messages).to eq(
-      ['Use snake_case for symbols.'] * 2)
-  end
-
-  it 'accepts snake case in names' do
-    inspect_source(cop,
-                   ['test = :good_idea'])
-    expect(cop.offences).to be_empty
-  end
-
-  it 'accepts snake case in hash label names' do
-    inspect_source(cop,
-                   ['{ one: 1, one_more_3: 2 }'])
-    expect(cop.offences).to be_empty
-  end
-
-  it 'accepts snake case with a prefix @ in names' do
-    inspect_source(cop,
-                   ['test = :@good_idea'])
-    expect(cop.offences).to be_empty
-  end
-
-  it 'accepts snake case with ? suffix' do
-    inspect_source(cop,
-                   ['test = :good_idea?'])
-    expect(cop.offences).to be_empty
-  end
-
-  it 'accepts snake case with ! suffix' do
-    inspect_source(cop,
-                   ['test = :good_idea!'])
-    expect(cop.offences).to be_empty
-  end
-
-  it 'accepts snake case with = suffix' do
-    inspect_source(cop,
-                   ['test = :good_idea='])
-    expect(cop.offences).to be_empty
-  end
-
-  it 'accepts special cases - !, [] and **' do
-    inspect_source(cop,
-                   ['test = :**',
-                    'test = :!',
-                    'test = :[]',
-                    'test = :[]='])
-    expect(cop.offences).to be_empty
-  end
-
-  it 'accepts special cases - ==, <=>, >, <, >=, <=' do
-    inspect_source(cop,
-                   ['test = :==',
-                    'test = :<=>',
-                    'test = :>',
-                    'test = :<',
-                    'test = :>=',
-                    'test = :<='])
-    expect(cop.offences).to be_empty
-  end
-
-  it 'accepts non snake case arguments to private_constant' do
-    inspect_source(cop,
-                   ['private_constant :NORMAL_MODE, :ADMIN_MODE'])
-    expect(cop.offences).to be_empty
-  end
-
-  it 'registers an offence for non snake case symbol near ' +
-      'private_constant' do
-    inspect_source(cop,
-                   ['private_constant f(:ADMIN_MODE)'])
-    expect(cop.offences.size).to eq(1)
-  end
-
-  it 'can handle an alias of and operator without crashing' do
-    inspect_source(cop,
-                   ['alias + add'])
-    expect(cop.offences).to be_empty
-  end
-
-  it 'registers an offence for SCREAMING_symbol_name' do
-    inspect_source(cop,
-                   ['test = :BAD_IDEA'])
-    expect(cop.offences.size).to eq(1)
-  end
-end