rubocop 0.14.1 → 0.15.0

data/spec/rubocop/config_spec.rb

@@ -13,8 +13,8 @@ describe Rubocop::Config do
     # TODO: Because Config.load_file now outputs the validation warning,
     #       it is inserting text into the rspec test output here.
     #       The next 2 lines should be removed eventually.
-    before(:each) { $stdout = StringIO.new }
-    after(:each) { $stdout = STDOUT }
+    before(:each) { $stderr = StringIO.new }
+    after(:each) { $stderr = STDERR }
 
     subject(:configuration) do
       Rubocop::ConfigLoader.load_file(configuration_path)

data/spec/rubocop/cop/lint/rescue_exception_spec.rb

@@ -118,4 +118,14 @@ describe Rubocop::Cop::Lint::RescueException do
                     'end'])
     expect(cop.offences).to be_empty
   end
+
+  it 'does not crash when the namespace of a rescued class is in a local ' +
+    'variable' do
+    inspect_source(cop,
+                   ['adapter = current_adapter',
+                    'begin',
+                    'rescue adapter::ParseError',
+                    'end'])
+    expect(cop.offences).to be_empty
+  end
 end

data/spec/rubocop/cop/lint/useless_setter_call_spec.rb

@@ -84,6 +84,19 @@ describe Rubocop::Cop::Lint::UselessSetterCall do
     end
   end
 
+  context 'when a lvar does not have any object passed as argument ' +
+          'with multiple-assignment at the end of the method' do
+    it 'registers an offence' do
+      inspect_source(cop,
+                     ['def test(some_arg)',
+                      '  _first, some_lvar, _third  = do_something',
+                      '  some_lvar.attr = 5',
+                      'end'
+                     ])
+      expect(cop.offences.size).to eq(1)
+    end
+  end
+
   context 'when a lvar possibly has an object passed as argument ' +
           'by logical-operator-assignment at the end of the method' do
     it 'accepts the lvar attr assignment' do

data/spec/rubocop/cop/offence_spec.rb

@@ -107,6 +107,8 @@ describe Rubocop::Cop::Offence do
       Parser::Source::Range.new(source_buffer, begin_pos, begin_pos + 1)
     end
 
+    # We want a nice table layout, so we allow space inside empty hashes.
+    # rubocop:disable SpaceInsideHashLiteralBraces
     [
       [{                           }, {                           }, 0],
 

data/spec/rubocop/cop/rails/output_spec.rb

@@ -0,0 +1,40 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Rubocop::Cop::Rails::Output, :config do
+  subject(:cop) { described_class.new(config) }
+  let(:cop_config) { { 'Ignore' => ['^.*\.rake$'] } }
+
+  it 'should record an offence for puts statements' do
+    source = ['p "edmond dantes"',
+              'puts "sinbad"',
+              'print "abbe busoni"',
+              'pp "monte cristo"']
+    inspect_source(cop, source)
+    expect(cop.offences.size).to eq(4)
+  end
+
+  it 'should not record an offence for methods' do
+    source = ['obj.print',
+              'something.p',
+              'nothing.pp']
+    inspect_source(cop, source)
+    expect(cop.offences).to be_empty
+  end
+
+  it 'should not record an offence for comments' do
+    source = ['# print "test"',
+              '# p']
+    inspect_source(cop, source)
+    expect(cop.offences).to be_empty
+  end
+
+  it 'should ignore certain files' do
+    source = ['print 1']
+    processed_source = parse_source(source)
+    processed_source.buffer.stub(:name).and_return('/var/lib/test.rake')
+    _investigate(cop, processed_source)
+    expect(cop.offences).to be_empty
+  end
+end

data/spec/rubocop/cop/style/access_modifier_indentation_spec.rb

@@ -0,0 +1,243 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Rubocop::Cop::Style::AccessModifierIndentation, :config do
+  subject(:cop) { described_class.new(config) }
+
+  context 'when IndentDepth is set to method' do
+    let(:cop_config) { { 'EnforcedStyle' => 'indent' } }
+
+    it 'registers an offence for misaligned private' do
+      inspect_source(cop,
+                     ['class Test',
+                      '',
+                      'private',
+                      '',
+                      '  def test; end',
+                      'end'])
+      expect(cop.offences.size).to eq(1)
+      expect(cop.messages)
+        .to eq(['Indent access modifiers like private.'])
+    end
+
+    it 'registers an offence for misaligned private in module' do
+      inspect_source(cop,
+                     ['module Test',
+                      '',
+                      'private',
+                      '',
+                      '  def test; end',
+                      'end'])
+      expect(cop.offences.size).to eq(1)
+      expect(cop.messages)
+        .to eq(['Indent access modifiers like private.'])
+    end
+
+    it 'registers an offence for misaligned private in singleton class' do
+      inspect_source(cop,
+                     ['class << self',
+                      '',
+                      'private',
+                      '',
+                      '  def test; end',
+                      'end'])
+      expect(cop.offences.size).to eq(1)
+      expect(cop.messages)
+        .to eq(['Indent access modifiers like private.'])
+    end
+
+    it 'registers an offence for misaligned private in class ' +
+       'defined with Class.new' do
+      inspect_source(cop,
+                     ['Test = Class.new do',
+                      '',
+                      'private',
+                      '',
+                      '  def test; end',
+                      'end'])
+      expect(cop.offences.size).to eq(1)
+      expect(cop.messages)
+        .to eq(['Indent access modifiers like private.'])
+    end
+
+    it 'registers an offence for misaligned private in module ' +
+       'defined with Module.new' do
+      inspect_source(cop,
+                     ['Test = Module.new do',
+                      '',
+                      'private',
+                      '',
+                      '  def test; end',
+                      'end'])
+      expect(cop.offences.size).to eq(1)
+      expect(cop.messages)
+        .to eq(['Indent access modifiers like private.'])
+    end
+
+    it 'registers an offence for misaligned protected' do
+      inspect_source(cop,
+                     ['class Test',
+                      '',
+                      'protected',
+                      '',
+                      '  def test; end',
+                      'end'])
+      expect(cop.offences.size).to eq(1)
+      expect(cop.messages)
+        .to eq(['Indent access modifiers like protected.'])
+    end
+
+    it 'accepts properly indented private' do
+      inspect_source(cop,
+                     ['class Test',
+                      '',
+                      '  private',
+                      '',
+                      '  def test; end',
+                      'end'])
+      expect(cop.offences).to be_empty
+    end
+
+    it 'accepts properly indented protected' do
+      inspect_source(cop,
+                     ['class Test',
+                      '',
+                      '  protected',
+                      '',
+                      '  def test; end',
+                      'end'])
+      expect(cop.offences).to be_empty
+    end
+
+    it 'handles properly nested classes' do
+      inspect_source(cop,
+                     ['class Test',
+                      '',
+                      '  class Nested',
+                      '',
+                      '  private',
+                      '',
+                      '    def a; end',
+                      '  end',
+                      '',
+                      '  protected',
+                      '',
+                      '  def test; end',
+                      'end'])
+      expect(cop.offences.size).to eq(1)
+      expect(cop.messages)
+        .to eq(['Indent access modifiers like private.'])
+    end
+  end
+
+  context 'when IndentDepth is set to class' do
+    let(:cop_config) { { 'EnforcedStyle' => 'outdent' } }
+    let(:indent_msg) { 'Outdent access modifiers like private.' }
+    let(:blank_msg) { 'Keep a blank line before and after private.' }
+
+    it 'registers offence for private indented to method depth in a class' do
+      inspect_source(cop,
+                     ['class Test',
+                      '',
+                      '  private',
+                      '',
+                      '  def test; end',
+                      'end'])
+      expect(cop.offences.size).to eq(1)
+      expect(cop.messages).to eq([indent_msg])
+    end
+
+    it 'registers offence for private indented to method depth in a module' do
+      inspect_source(cop,
+                     ['module Test',
+                      '',
+                      '  private',
+                      '',
+                      '  def test; end',
+                      'end'])
+      expect(cop.offences.size).to eq(1)
+      expect(cop.messages).to eq([indent_msg])
+    end
+
+    it 'registers offence for private indented to method depth in singleton' +
+       'class' do
+      inspect_source(cop,
+                     ['class << self',
+                      '',
+                      '  private',
+                      '',
+                      '  def test; end',
+                      'end'])
+      expect(cop.offences.size).to eq(1)
+      expect(cop.messages).to eq([indent_msg])
+    end
+
+    it 'registers offence for private indented to method depth in class ' +
+       'defined with Class.new' do
+      inspect_source(cop,
+                     ['Test = Class.new do',
+                      '',
+                      '  private',
+                      '',
+                      '  def test; end',
+                      'end'])
+      expect(cop.offences.size).to eq(1)
+      expect(cop.messages).to eq([indent_msg])
+    end
+
+    it 'registers offence for private indented to method depth in module ' +
+       'defined with Module.new' do
+      inspect_source(cop,
+                     ['Test = Module.new do',
+                      '',
+                      '  private',
+                      '',
+                      '  def test; end',
+                      'end'])
+      expect(cop.offences.size).to eq(1)
+      expect(cop.messages).to eq([indent_msg])
+    end
+
+    it 'accepts private indented to the containing class indent level' do
+      inspect_source(cop,
+                     ['class Test',
+                      '',
+                      'private',
+                      '',
+                      '  def test; end',
+                      'end'])
+      expect(cop.offences).to be_empty
+    end
+
+    it 'accepts protected indented to the containing class indent level' do
+      inspect_source(cop,
+                     ['class Test',
+                      '',
+                      'protected',
+                      '',
+                      '  def test; end',
+                      'end'])
+      expect(cop.offences).to be_empty
+    end
+
+    it 'handles properly nested classes' do
+      inspect_source(cop,
+                     ['class Test',
+                      '',
+                      '  class Nested',
+                      '',
+                      '    private',
+                      '',
+                      '    def a; end',
+                      '  end',
+                      '',
+                      'protected',
+                      '',
+                      '  def test; end',
+                      'end'])
+      expect(cop.offences.size).to eq(1)
+      expect(cop.messages).to eq([indent_msg])
+    end
+  end
+end

data/spec/rubocop/cop/style/alias_spec.rb

@@ -38,4 +38,12 @@ describe Rubocop::Cop::Style::Alias do
                    ['alias $ala $bala'])
     expect(cop.offences).to be_empty
   end
+
+  it 'accepts alias in an instance_exec block' do
+    inspect_source(cop,
+                   ['cli.instance_exec do',
+                    '  alias :old_trap_interrupt :trap_interrupt',
+                    'end'])
+    expect(cop.offences).to be_empty
+  end
 end

data/spec/rubocop/cop/style/align_array_spec.rb

@@ -54,6 +54,18 @@ describe Rubocop::Cop::Style::AlignArray do
                               ']'].join("\n"))
   end
 
+  it 'auto-corrects array within array' do
+    original_source = ['[:l1,',
+                       '  [:l2,',
+                       '    [:l3,',
+                       '      [:l4]]]]']
+    new_source = autocorrect_source(cop, original_source)
+    expect(new_source).to eq(['[:l1,',
+                              ' [:l2,',
+                              '  [:l3,',
+                              '   [:l4]]]]'].join("\n"))
+  end
+
   it 'auto-corrects only elements that begin a line' do
     original_source = ['array = [:bar, {',
                        '         whiz: 2, bang: 3 }, option: 3]']

data/spec/rubocop/cop/style/align_hash_spec.rb

@@ -80,6 +80,11 @@ describe Rubocop::Cop::Style::AlignHash, :config do
                              '     b: 1)'])
         expect(cop.offences).to be_empty
       end
+
+      it 'accepts an empty hash' do
+        inspect_source(cop, 'h = {}')
+        expect(cop.offences).to be_empty
+      end
     end
 
     it 'auto-corrects alignment' do
@@ -126,6 +131,11 @@ describe Rubocop::Cop::Style::AlignHash, :config do
       expect(cop.offences).to be_empty
     end
 
+    it 'accepts an empty hash' do
+      inspect_source(cop, 'h = {}')
+      expect(cop.offences).to be_empty
+    end
+
     it 'registers an offence for misaligned hash values' do
       inspect_source(cop, ['hash1 = {',
                            "  'a'   =>  0,",
@@ -214,6 +224,11 @@ describe Rubocop::Cop::Style::AlignHash, :config do
       expect(cop.offences).to be_empty
     end
 
+    it 'accepts an empty hash' do
+      inspect_source(cop, 'h = {}')
+      expect(cop.offences).to be_empty
+    end
+
     it 'registers an offence for misaligned hash values' do
       inspect_source(cop, ['hash = {',
                            "    'a' =>  0,",

data/spec/rubocop/cop/style/braces_around_hash_parameters_spec.rb

@@ -71,14 +71,17 @@ describe Rubocop::Cop::Style::BracesAroundHashParameters, :config do
         expect(cop.highlights).to be_empty
       end
 
+    end
+
+    describe 'registers an offence for' do
       it 'one non-hash parameter followed by a hash parameter with braces' do
         inspect_source(cop, ['where(1, { y: 2 })'])
-        expect(cop.messages).to be_empty
-        expect(cop.highlights).to be_empty
+        expect(cop.messages).to eq([
+          'Redundant curly braces around a hash parameter.'
+        ])
+        expect(cop.highlights).to eq(['{ y: 2 }'])
       end
-    end
 
-    describe 'registers an offence for' do
       it 'one object method hash parameter with braces' do
         inspect_source(cop, ['x.func({ y: "z" })'])
         expect(cop.messages).to eq([

data/spec/rubocop/cop/style/cyclomatic_complexity_spec.rb

@@ -0,0 +1,203 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Rubocop::Cop::Style::CyclomaticComplexity, :config do
+  subject(:cop) { described_class.new(config) }
+
+  context 'when Max is 1' do
+    let(:cop_config) { { 'Max' => 1 } }
+
+    it 'accepts a method with no decision points' do
+      inspect_source(cop, ['def method_name',
+                           '  call_foo',
+                           'end'])
+      expect(cop.offences).to be_empty
+    end
+
+    it 'accepts complex code outside of methods' do
+      inspect_source(cop,
+                     ['def method_name',
+                      '  call_foo',
+                      'end',
+                      '',
+                      'if first_condition then',
+                      '  call_foo if second_condition && third_condition',
+                      '  call_bar if fourth_condition || fifth_condition',
+                      'end'])
+      expect(cop.offences).to be_empty
+    end
+
+    it 'registers an offence for an if modifier' do
+      inspect_source(cop, ['def self.method_name',
+                           '  call_foo if some_condition',
+                           'end'])
+      expect(cop.messages)
+        .to eq(['Cyclomatic complexity for method_name is too high. [2/1]'])
+      expect(cop.highlights).to eq(['def'])
+    end
+
+    it 'registers an offence for an unless modifier' do
+      inspect_source(cop, ['def method_name',
+                           '  call_foo unless some_condition',
+                           'end'])
+      expect(cop.messages)
+        .to eq(['Cyclomatic complexity for method_name is too high. [2/1]'])
+    end
+
+    it 'registers an offence for an elsif block' do
+      inspect_source(cop, ['def method_name',
+                           '  if first_condition then',
+                           '    call_foo',
+                           '  elsif second_condition then',
+                           '    call_bar',
+                           '  else',
+                           '    call_bam',
+                           '  end',
+                           'end'])
+      expect(cop.messages)
+        .to eq(['Cyclomatic complexity for method_name is too high. [3/1]'])
+    end
+
+    it 'registers an offence for a ternary operator' do
+      inspect_source(cop, ['def method_name',
+                           '  value = some_condition ? 1 : 2',
+                           'end'])
+      expect(cop.messages)
+        .to eq(['Cyclomatic complexity for method_name is too high. [2/1]'])
+    end
+
+    it 'registers an offence for a while block' do
+      inspect_source(cop, ['def method_name',
+                           '  while some_condition do',
+                           '    call_foo',
+                           '  end',
+                           'end'])
+      expect(cop.messages)
+        .to eq(['Cyclomatic complexity for method_name is too high. [2/1]'])
+    end
+
+    it 'registers an offence for an until block' do
+      inspect_source(cop, ['def method_name',
+                           '  until some_condition do',
+                           '    call_foo',
+                           '  end',
+                           'end'])
+      expect(cop.messages)
+        .to eq(['Cyclomatic complexity for method_name is too high. [2/1]'])
+    end
+
+    it 'registers an offence for a for block' do
+      inspect_source(cop, ['def method_name',
+                           '  for i in 1..2 do',
+                           '    call_method',
+                           '  end',
+                           'end'])
+      expect(cop.messages)
+        .to eq(['Cyclomatic complexity for method_name is too high. [2/1]'])
+    end
+
+    it 'registers an offence for a rescue block' do
+      inspect_source(cop, ['def method_name',
+                           '  begin',
+                           '    call_foo',
+                           '  rescue Exception',
+                           '    call_bar',
+                           '  end',
+                           'end'])
+      expect(cop.messages)
+        .to eq(['Cyclomatic complexity for method_name is too high. [2/1]'])
+    end
+
+    it 'registers an offence for a case/when block' do
+      inspect_source(cop, ['def method_name',
+                           '  case value',
+                           '  when 1',
+                           '    call_foo',
+                           '  when 2',
+                           '    call_bar',
+                           '  end',
+                           'end'])
+      expect(cop.messages)
+        .to eq(['Cyclomatic complexity for method_name is too high. [3/1]'])
+    end
+
+    it 'registers an offence for &&' do
+      inspect_source(cop, ['def method_name',
+                           '  call_foo && call_bar',
+                           'end'])
+      expect(cop.messages)
+        .to eq(['Cyclomatic complexity for method_name is too high. [2/1]'])
+    end
+
+    it 'registers an offence for and' do
+      inspect_source(cop, ['def method_name',
+                           '  call_foo and call_bar',
+                           'end'])
+      expect(cop.messages)
+        .to eq(['Cyclomatic complexity for method_name is too high. [2/1]'])
+    end
+
+    it 'registers an offence for ||' do
+      inspect_source(cop, ['def method_name',
+                           '  call_foo || call_bar',
+                           'end'])
+      expect(cop.messages)
+        .to eq(['Cyclomatic complexity for method_name is too high. [2/1]'])
+    end
+
+    it 'registers an offence for or' do
+      inspect_source(cop, ['def method_name',
+                           '  call_foo or call_bar',
+                           'end'])
+      expect(cop.messages)
+        .to eq(['Cyclomatic complexity for method_name is too high. [2/1]'])
+    end
+
+    it 'deals with nested if blocks containing && and ||' do
+      inspect_source(cop,
+                     ['def method_name',
+                      '  if first_condition then',
+                      '    call_foo if second_condition && third_condition',
+                      '    call_bar if fourth_condition || fifth_condition',
+                      '  end',
+                      'end'])
+      expect(cop.messages)
+        .to eq(['Cyclomatic complexity for method_name is too high. [6/1]'])
+    end
+
+    it 'counts only a single method' do
+      inspect_source(cop, ['def method_name_1',
+                           '  call_foo if some_condition',
+                           'end',
+                           '',
+                           'def method_name_2',
+                           '  call_foo if some_condition',
+                           'end'])
+      expect(cop.messages)
+        .to eq(['Cyclomatic complexity for method_name_1 is too high. [2/1]',
+                'Cyclomatic complexity for method_name_2 is too high. [2/1]'])
+    end
+  end
+
+  context 'when Max is 2' do
+    let(:cop_config) { { 'Max' => 2 } }
+
+    it 'counts stupid nested if and else blocks' do
+      inspect_source(cop, ['def method_name',
+                           '  if first_condition then',
+                           '    call_foo',
+                           '  else',
+                           '    if second_condition then',
+                           '      call_bar',
+                           '    else',
+                           '      call_bam if third_condition',
+                           '    end',
+                           '    call_baz if fourth_condition',
+                           '  end',
+                           'end'])
+      expect(cop.messages)
+        .to eq(['Cyclomatic complexity for method_name is too high. [5/2]'])
+    end
+  end
+end