rubocop 0.13.0 → 0.13.1

data/spec/rubocop/cop/lint/useless_comparison_spec.rb

@@ -25,6 +25,11 @@ module Rubocop
             expect(cop.offences.size).to eq(2)
           end
         end
+
+        it 'works with lambda.()' do
+          inspect_source(cop, ['a.(x) > a.(x)'])
+          expect(cop.offences.size).to eq(1)
+        end
       end
     end
   end

data/spec/rubocop/cop/lint/useless_setter_call_spec.rb

@@ -74,6 +74,47 @@ module Rubocop
           end
         end
 
+        context 'when a lvar has an object passed as argument ' +
+                'by multiple-assignment at the end of the method' do
+          it 'accepts the lvar attr assignment' do
+            inspect_source(cop,
+                           ['def test(some_arg)',
+                            '  _first, some_lvar, _third  = 1, some_arg, 3',
+                            '  some_lvar.attr = 5',
+                            'end'
+                           ])
+            expect(cop.offences).to be_empty
+          end
+        end
+
+        context 'when a lvar possibly has an object passed as argument ' +
+                'by logical-operator-assignment at the end of the method' do
+          it 'accepts the lvar attr assignment' do
+            inspect_source(cop,
+                           ['def test(some_arg)',
+                            '  some_lvar = nil',
+                            '  some_lvar ||= some_arg',
+                            '  some_lvar.attr = 5',
+                            'end'
+                           ])
+            expect(cop.offences).to be_empty
+          end
+        end
+
+        context 'when a lvar does not have any object passed as argument ' +
+                'by binary-operator-assignment at the end of the method' do
+          it 'registers an offence' do
+            inspect_source(cop,
+                           ['def test(some_arg)',
+                            '  some_lvar = some_arg',
+                            '  some_lvar += some_arg',
+                            '  some_lvar.attr = 5',
+                            'end'
+                           ])
+            expect(cop.offences.size).to eq(1)
+          end
+        end
+
         context 'when a lvar declared as an argument ' +
                 'is no longer the passed object at the end of the method' do
           it 'registers an offence for the lvar attr assignment' do

data/spec/rubocop/cop/style/final_newline_spec.rb

@@ -19,6 +19,12 @@ module Rubocop
           inspect_source(cop, source)
           expect(cop.offences).to be_empty
         end
+
+        it 'accepts an empty file' do
+          source = ['']
+          inspect_source(cop, source)
+          expect(cop.offences).to be_empty
+        end
       end
     end
   end

data/spec/rubocop/cop/style/hash_syntax_spec.rb

@@ -6,60 +6,65 @@ module Rubocop
   module Cop
     module Style
       describe HashSyntax do
-        subject(:hash_syntax) { HashSyntax.new }
+        subject(:cop) { described_class.new }
 
         it 'registers offence for hash rocket syntax when new is possible' do
-          inspect_source(hash_syntax, ['x = { :a => 0 }'])
-          expect(hash_syntax.messages).to eq(
+          inspect_source(cop, ['x = { :a => 0 }'])
+          expect(cop.messages).to eq(
             ['Ruby 1.8 hash syntax detected'])
         end
 
         it 'registers an offence for mixed syntax when new is possible' do
-          inspect_source(hash_syntax, ['x = { :a => 0, b: 1 }'])
-          expect(hash_syntax.messages).to eq(
+          inspect_source(cop, ['x = { :a => 0, b: 1 }'])
+          expect(cop.messages).to eq(
             ['Ruby 1.8 hash syntax detected'])
         end
 
         it 'registers an offence for hash rockets in method calls' do
-          inspect_source(hash_syntax, ['func(3, :a => 0)'])
-          expect(hash_syntax.messages).to eq(
+          inspect_source(cop, ['func(3, :a => 0)'])
+          expect(cop.messages).to eq(
             ['Ruby 1.8 hash syntax detected'])
         end
 
         it 'accepts hash rockets when keys have different types' do
-          inspect_source(hash_syntax, ['x = { :a => 0, "b" => 1 }'])
-          expect(hash_syntax.messages).to be_empty
+          inspect_source(cop, ['x = { :a => 0, "b" => 1 }'])
+          expect(cop.messages).to be_empty
         end
 
         it 'accepts hash rockets when keys have whitespaces in them' do
-          inspect_source(hash_syntax, ['x = { :"t o" => 0 }'])
-          expect(hash_syntax.messages).to be_empty
+          inspect_source(cop, ['x = { :"t o" => 0 }'])
+          expect(cop.messages).to be_empty
         end
 
         it 'accepts hash rockets when keys have special symbols in them' do
-          inspect_source(hash_syntax, ['x = { :"\tab" => 1 }'])
-          expect(hash_syntax.messages).to be_empty
+          inspect_source(cop, ['x = { :"\tab" => 1 }'])
+          expect(cop.messages).to be_empty
         end
 
         it 'accepts hash rockets when keys start with a digit' do
-          inspect_source(hash_syntax, ['x = { :"1" => 1 }'])
-          expect(hash_syntax.messages).to be_empty
+          inspect_source(cop, ['x = { :"1" => 1 }'])
+          expect(cop.messages).to be_empty
         end
 
         it 'registers offence when keys start with an uppercase letter' do
-          inspect_source(hash_syntax, ['x = { :A => 0 }'])
-          expect(hash_syntax.messages).to eq(
+          inspect_source(cop, ['x = { :A => 0 }'])
+          expect(cop.messages).to eq(
             ['Ruby 1.8 hash syntax detected'])
         end
 
         it 'accepts new syntax in a hash literal' do
-          inspect_source(hash_syntax, ['x = { a: 0, b: 1 }'])
-          expect(hash_syntax.messages).to be_empty
+          inspect_source(cop, ['x = { a: 0, b: 1 }'])
+          expect(cop.messages).to be_empty
         end
 
         it 'accepts new syntax in method calls' do
-          inspect_source(hash_syntax, ['func(3, a: 0)'])
-          expect(hash_syntax.messages).to be_empty
+          inspect_source(cop, ['func(3, a: 0)'])
+          expect(cop.messages).to be_empty
+        end
+
+        it 'auto-corrects old to new style' do
+          new_source = autocorrect_source(cop, '{ :a => 1, :b   =>  2}')
+          expect(new_source).to eq('{ a: 1, b: 2}')
         end
       end
     end

data/spec/rubocop/cop/style/lambda_call_spec.rb

@@ -0,0 +1,29 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+module Rubocop
+  module Cop
+    module Style
+      describe LambdaCall do
+        subject(:cop) { described_class.new }
+
+        it 'registers an offence for x.()' do
+          inspect_source(cop,
+                         ['x.(a, b)'])
+          expect(cop.offences.size).to eq(1)
+        end
+
+        it 'accepts x.call()' do
+          inspect_source(cop, ['x.call(a, b)'])
+          expect(cop.offences).to be_empty
+        end
+
+        it 'auto-corrects x.() to x.call()' do
+          new_source = autocorrect_source(cop, ['a.(x)'])
+          expect(new_source).to eq('a.call(x)')
+        end
+      end
+    end
+  end
+end

data/spec/rubocop/cop/style/nil_comparison_spec.rb

@@ -25,6 +25,11 @@ module Rubocop
                          ['x != nil'])
           expect(cop.offences.size).to eq(1)
         end
+
+        it 'works with lambda.()' do
+          inspect_source(cop, ['a.(x) == nil'])
+          expect(cop.offences.size).to eq(1)
+        end
       end
     end
   end

data/spec/rubocop/cop/style/redundant_self_spec.rb

@@ -92,6 +92,24 @@ module Rubocop
           expect(cop.offences).to be_empty
         end
 
+        it 'accepts a self receiver used to distinguish from blockarg' do
+          src = ['def requested_specs(&groups)',
+                 '  some_method(self.groups)',
+                 'end',
+                ]
+          inspect_source(cop, src)
+          expect(cop.offences).to be_empty
+        end
+
+        it 'accepts a self receiver used to distinguish from argument' do
+          src = ['def requested_specs(groups)',
+                 '  some_method(self.groups)',
+                 'end',
+                ]
+          inspect_source(cop, src)
+          expect(cop.offences).to be_empty
+        end
+
         it 'accepts a self receiver used to distinguish from local variable' do
           src = ['def requested_specs',
                  '  @requested_specs ||= begin',

data/spec/rubocop/cop/style/space_around_block_braces_spec.rb

@@ -0,0 +1,68 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+module Rubocop
+  module Cop
+    module Style
+      describe SpaceAroundBlockBraces, :config do
+        subject(:cop) { SpaceAroundBlockBraces.new(config) }
+        let(:cop_config) { { 'NoSpaceBeforeBlockParameters' => false } }
+
+        it 'accepts braces surrounded by spaces' do
+          inspect_source(cop, ['each { puts }'])
+          expect(cop.messages).to be_empty
+          expect(cop.highlights).to be_empty
+        end
+
+        it 'registers an offence for left brace without outer space' do
+          inspect_source(cop, ['each{ puts }'])
+          expect(cop.messages).to eq(["Surrounding space missing for '{'."])
+          expect(cop.highlights).to eq(['{'])
+        end
+
+        it 'registers an offence for left brace without inner space' do
+          inspect_source(cop, ['each {puts }'])
+          expect(cop.messages).to eq(["Surrounding space missing for '{'."])
+          expect(cop.highlights).to eq(['{'])
+        end
+
+        it 'registers an offence for right brace without inner space' do
+          inspect_source(cop, ['each { puts}'])
+          expect(cop.messages).to eq(["Space missing to the left of '}'."])
+          expect(cop.highlights).to eq(['}'])
+        end
+
+        context 'with passed in parameters' do
+          it 'accepts left brace with inner space' do
+            inspect_source(cop, ['each { |x| puts }'])
+            expect(cop.messages).to be_empty
+            expect(cop.highlights).to be_empty
+          end
+
+          it 'registers an offence for left brace without inner space' do
+            inspect_source(cop, ['each {|x| puts }'])
+            expect(cop.messages).to eq(["Surrounding space missing for '{'."])
+            expect(cop.highlights).to eq(['{'])
+          end
+
+          context 'space before block parameters not allowed' do
+            let(:cop_config) { { 'NoSpaceBeforeBlockParameters' => true } }
+
+            it 'registers an offence for left brace with inner space' do
+              inspect_source(cop, ['each { |x| puts }'])
+              expect(cop.messages).to eq(['Space between { and | detected.'])
+              expect(cop.highlights).to eq(['{'])
+            end
+
+            it 'accepts left brace without inner space' do
+              inspect_source(cop, ['each {|x| puts }'])
+              expect(cop.messages).to be_empty
+              expect(cop.highlights).to be_empty
+            end
+          end
+        end
+      end
+    end
+  end
+end

metadata

@@ -1,36 +1,32 @@
 --- !ruby/object:Gem::Specification
 name: rubocop
 version: !ruby/object:Gem::Version
-  version: 0.13.0
-  prerelease: 
+  version: 0.13.1
 platform: ruby
 authors:
 - Bozhidar Batsov
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-09-13 00:00:00.000000000 Z
+date: 2013-09-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rainbow
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 1.1.4
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 1.1.4
 - !ruby/object:Gem::Dependency
   name: parser
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -38,31 +34,13 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
         version: 2.0.0.pre6
-- !ruby/object:Gem::Dependency
-  name: backports
-  requirement: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: 3.3.3
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: 3.3.3
 - !ruby/object:Gem::Dependency
   name: powerpack
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -70,7 +48,6 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -78,7 +55,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -86,7 +62,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -94,7 +69,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -102,7 +76,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -110,7 +83,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: yard
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -118,7 +90,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -126,7 +97,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -134,7 +104,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -142,7 +111,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -150,13 +118,13 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
         version: '0.7'
-description: ! "    Automatic Ruby code style checking tool.\n    Aims to enforce
-  the community-driven Ruby Style Guide.\n"
+description: |2
+      Automatic Ruby code style checking tool.
+      Aims to enforce the community-driven Ruby Style Guide.
 email: bozhidar@batsov.com
 executables:
 - rubocop
@@ -181,6 +149,7 @@ files:
 - config/disabled.yml
 - config/enabled.yml
 - lib/rubocop.rb
+- lib/rubocop/backports/bsearch.rb
 - lib/rubocop/cli.rb
 - lib/rubocop/config.rb
 - lib/rubocop/config_store.rb
@@ -218,6 +187,7 @@ files:
 - lib/rubocop/cop/style/ascii_comments.rb
 - lib/rubocop/cop/style/ascii_identifiers.rb
 - lib/rubocop/cop/style/attr.rb
+- lib/rubocop/cop/style/autocorrect_alignment.rb
 - lib/rubocop/cop/style/begin_block.rb
 - lib/rubocop/cop/style/block_comments.rb
 - lib/rubocop/cop/style/block_nesting.rb
@@ -255,6 +225,7 @@ files:
 - lib/rubocop/cop/style/if_with_semicolon.rb
 - lib/rubocop/cop/style/indentation_width.rb
 - lib/rubocop/cop/style/lambda.rb
+- lib/rubocop/cop/style/lambda_call.rb
 - lib/rubocop/cop/style/leading_comment_space.rb
 - lib/rubocop/cop/style/line_length.rb
 - lib/rubocop/cop/style/method_and_variable_snake_case.rb
@@ -286,6 +257,7 @@ files:
 - lib/rubocop/cop/style/space_after_method_name.rb
 - lib/rubocop/cop/style/space_before_modifier_keyword.rb
 - lib/rubocop/cop/style/special_global_vars.rb
+- lib/rubocop/cop/style/string_help.rb
 - lib/rubocop/cop/style/string_literals.rb
 - lib/rubocop/cop/style/surrounding_space.rb
 - lib/rubocop/cop/style/symbol_array.rb
@@ -402,6 +374,7 @@ files:
 - spec/rubocop/cop/style/hash_syntax_spec.rb
 - spec/rubocop/cop/style/if_with_semicolon_spec.rb
 - spec/rubocop/cop/style/indentation_width_spec.rb
+- spec/rubocop/cop/style/lambda_call_spec.rb
 - spec/rubocop/cop/style/lambda_spec.rb
 - spec/rubocop/cop/style/leading_comment_space_spec.rb
 - spec/rubocop/cop/style/line_length_spec.rb
@@ -434,7 +407,7 @@ files:
 - spec/rubocop/cop/style/space_after_control_keyword_spec.rb
 - spec/rubocop/cop/style/space_after_method_name_spec.rb
 - spec/rubocop/cop/style/space_after_semicolon_spec.rb
-- spec/rubocop/cop/style/space_around_braces_spec.rb
+- spec/rubocop/cop/style/space_around_block_braces_spec.rb
 - spec/rubocop/cop/style/space_around_equals_in_default_parameter_spec.rb
 - spec/rubocop/cop/style/space_around_operators_spec.rb
 - spec/rubocop/cop/style/space_before_modifier_keyword_spec.rb
@@ -486,30 +459,26 @@ files:
 homepage: http://github.com/bbatsov/rubocop
 licenses:
 - MIT
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: 1.9.2
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 1613549233973798882
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.23
+rubygems_version: 2.0.3
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Automatic Ruby code style checking tool.
 test_files:
 - spec/.rubocop.yml
@@ -588,6 +557,7 @@ test_files:
 - spec/rubocop/cop/style/hash_syntax_spec.rb
 - spec/rubocop/cop/style/if_with_semicolon_spec.rb
 - spec/rubocop/cop/style/indentation_width_spec.rb
+- spec/rubocop/cop/style/lambda_call_spec.rb
 - spec/rubocop/cop/style/lambda_spec.rb
 - spec/rubocop/cop/style/leading_comment_space_spec.rb
 - spec/rubocop/cop/style/line_length_spec.rb
@@ -620,7 +590,7 @@ test_files:
 - spec/rubocop/cop/style/space_after_control_keyword_spec.rb
 - spec/rubocop/cop/style/space_after_method_name_spec.rb
 - spec/rubocop/cop/style/space_after_semicolon_spec.rb
-- spec/rubocop/cop/style/space_around_braces_spec.rb
+- spec/rubocop/cop/style/space_around_block_braces_spec.rb
 - spec/rubocop/cop/style/space_around_equals_in_default_parameter_spec.rb
 - spec/rubocop/cop/style/space_around_operators_spec.rb
 - spec/rubocop/cop/style/space_before_modifier_keyword_spec.rb