rubocop 0.10.0 → 0.11.0

data/spec/rubocop/formatter/base_formatter_spec.rb

@@ -120,7 +120,7 @@ module Rubocop
               end
 
               formatter.should_receive(:finished) do |processed_files|
-                expect(processed_files).to have(2).items
+                expect(processed_files.size).to eq(2)
               end
 
               run
@@ -170,9 +170,9 @@ module Rubocop
             .exactly(3).times do |file, offences|
               case File.basename(file)
               when '1_offence.rb'
-                expect(offences).to have(1).item
+                expect(offences.size).to eq(1)
               when '4_offences.rb'
-                expect(offences).to have(4).items
+                expect(offences.size).to eq(4)
               when 'no_offence.rb'
                 expect(offences).to be_empty
               else

data/spec/rubocop/formatter/clang_style_formatter_spec.rb

@@ -64,6 +64,25 @@ module Rubocop
                                        '^^',
                                        ''].join("\n")
         end
+
+        it 'does not display offending source line if it is blank' do
+          cop = Cop::Cop.new
+          source_buffer = Parser::Source::Buffer.new('test', 1)
+          source_buffer.source = (['     ', 'yaba']).to_a.join($RS)
+          cop.add_offence(:convention,
+                          Parser::Source::Range.new(source_buffer, 0, 2),
+                          'message 1')
+          cop.add_offence(:fatal,
+                          Parser::Source::Range.new(source_buffer, 6, 4),
+                          'message 2')
+
+          formatter.report_file('test', cop.offences)
+          expect(output.string).to eq ['test:1:1: C: message 1',
+                                       'test:2:1: F: message 2',
+                                       'yaba',
+                                       '^^^^',
+                                       ''].join("\n")
+        end
       end
     end
   end

data/spec/rubocop/formatter/disabled_config_formatter_spec.rb

@@ -0,0 +1,48 @@
+# encoding: utf-8
+
+require 'spec_helper'
+require 'stringio'
+require 'ostruct'
+
+module Rubocop
+  module Formatter
+    describe DisabledConfigFormatter do
+      let(:formatter) { DisabledConfigFormatter.new(output) }
+      let(:output) do
+        o = StringIO.new
+        def o.path
+          'rubocop-todo.yml'
+        end
+        o
+      end
+      let(:offences) do
+        [Rubocop::Cop::Offence.new(:convention, location, 'message', 'Cop1'),
+         Rubocop::Cop::Offence.new(:convention, location, 'message', 'Cop2')]
+      end
+      let(:location) { OpenStruct.new(line: 1, column: 5) }
+      before { $stdout = StringIO.new }
+
+      describe '#finished' do
+        it 'displays YAML configuration disabling all cops with offences' do
+          formatter.file_finished('test.rb', offences)
+          formatter.finished(['test.rb'])
+          expect(output.string).to eq(DisabledConfigFormatter::HEADING +
+                                      ['',
+                                       '',
+                                       'Cop1:',
+                                       '  Enabled: false',
+                                       '',
+                                       'Cop2:',
+                                       '  Enabled: false',
+                                       ''].join("\n"))
+          expect($stdout.string)
+            .to eq(['Created rubocop-todo.yml.',
+                    'Run rubocop with --config rubocop-todo.yml, or',
+                    'add inherit_from: rubocop-todo.yml in a .rubocop.yml ' +
+                    'file.',
+                    ''].join("\n"))
+        end
+      end
+    end
+  end
+end

data/spec/rubocop/formatter/formatter_set_spec.rb

@@ -33,7 +33,7 @@ module Rubocop
       describe 'add_formatter' do
         it 'adds a formatter to itself' do
           formatter_set.add_formatter('simple')
-          expect(formatter_set).to have(1).item
+          expect(formatter_set.size).to eq(1)
         end
 
         it 'adds a formatter with specified formatter type' do

data/spec/rubocop/processed_source_spec.rb

@@ -35,7 +35,7 @@ module Rubocop
       end
 
       it 'has same number of elements as line count' do
-        expect(processed_source.lines).to have(4).items
+        expect(processed_source.lines.size).to eq(4)
       end
 
       it 'contains lines as string without linefeed' do

data/spec/spec_helper.rb

@@ -12,19 +12,24 @@ if ENV['TRAVIS'] && RUBY_ENGINE == 'jruby'
   ENV['TMPDIR'] = non_world_writable_tmp_dir
 end
 
-if ENV['TRAVIS'] || ENV['COVERAGE']
-  require 'simplecov'
-
-  if ENV['TRAVIS']
-    require 'coveralls'
-    SimpleCov.formatter = Coveralls::SimpleCov::Formatter
-  end
-
-  SimpleCov.start do
-    add_filter '/spec/'
-    add_filter '/vendor/bundle/'
-  end
-end
+# Temporary disable the coverage report until Coveralls fix
+# their API or we find a way to not break the TRAVIS build
+# when Coveralls report error.
+# SimpleCov raises similar IOError - stream closed when ran
+# on Rubinius.
+# if ENV['TRAVIS'] || ENV['COVERAGE']
+  # require 'simplecov'
+
+  # if ENV['TRAVIS']
+  #   require 'coveralls'
+  #   SimpleCov.formatter = Coveralls::SimpleCov::Formatter
+  # end
+
+  # SimpleCov.start do
+    # add_filter '/spec/'
+    # add_filter '/vendor/bundle/'
+  # end
+# end
 
 $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
 $LOAD_PATH.unshift(File.dirname(__FILE__))

metadata

@@ -1,52 +1,46 @@
 --- !ruby/object:Gem::Specification
 name: rubocop
 version: !ruby/object:Gem::Version
-  version: 0.10.0
-  prerelease: 
+  version: 0.11.0
 platform: ruby
 authors:
 - Bozhidar Batsov
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-07-17 00:00:00.000000000 Z
+date: 2013-08-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rainbow
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 1.1.4
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 1.1.4
 - !ruby/object:Gem::Dependency
   name: parser
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - '='
+    - - ~>
       - !ruby/object:Gem::Version
-        version: 2.0.0.pre2
+        version: 2.0.0.pre6
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - '='
+    - - ~>
       - !ruby/object:Gem::Version
-        version: 2.0.0.pre2
+        version: 2.0.0.pre6
 - !ruby/object:Gem::Dependency
   name: backports
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -54,7 +48,6 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -62,7 +55,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: powerpack
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - '='
       - !ruby/object:Gem::Version
@@ -70,7 +62,6 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - '='
       - !ruby/object:Gem::Version
@@ -78,7 +69,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -86,7 +76,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -94,7 +83,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -102,7 +90,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -110,7 +97,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: yard
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -118,7 +104,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -126,7 +111,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -134,7 +118,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -142,7 +125,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -150,13 +132,13 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
         version: '0.7'
-description: ! "    Automatic Ruby code style checking tool.\n    Aims to enforce
-  the community-driven Ruby Style Guide.\n"
+description: |2
+      Automatic Ruby code style checking tool.
+      Aims to enforce the community-driven Ruby Style Guide.
 email: bozhidar@batsov.com
 executables:
 - rubocop
@@ -201,6 +183,8 @@ files:
 - lib/rubocop/cop/lint/shadowing_outer_local_variable.rb
 - lib/rubocop/cop/lint/unreachable_code.rb
 - lib/rubocop/cop/lint/unused_local_variable.rb
+- lib/rubocop/cop/lint/useless_assignment.rb
+- lib/rubocop/cop/lint/useless_comparison.rb
 - lib/rubocop/cop/lint/void.rb
 - lib/rubocop/cop/offence.rb
 - lib/rubocop/cop/rails/validation.rb
@@ -252,6 +236,7 @@ files:
 - lib/rubocop/cop/style/method_and_variable_snake_case.rb
 - lib/rubocop/cop/style/method_call_parentheses.rb
 - lib/rubocop/cop/style/method_length.rb
+- lib/rubocop/cop/style/module_function.rb
 - lib/rubocop/cop/style/multiline_if_then.rb
 - lib/rubocop/cop/style/not.rb
 - lib/rubocop/cop/style/numeric_literals.rb
@@ -267,6 +252,7 @@ files:
 - lib/rubocop/cop/style/regexp_literal.rb
 - lib/rubocop/cop/style/rescue_modifier.rb
 - lib/rubocop/cop/style/semicolon.rb
+- lib/rubocop/cop/style/signal_exception.rb
 - lib/rubocop/cop/style/single_line_methods.rb
 - lib/rubocop/cop/style/space_after_comma_etc.rb
 - lib/rubocop/cop/style/space_after_control_keyword.rb
@@ -287,6 +273,7 @@ files:
 - lib/rubocop/cop/variable_inspector.rb
 - lib/rubocop/formatter/base_formatter.rb
 - lib/rubocop/formatter/clang_style_formatter.rb
+- lib/rubocop/formatter/disabled_config_formatter.rb
 - lib/rubocop/formatter/emacs_style_formatter.rb
 - lib/rubocop/formatter/file_list_formatter.rb
 - lib/rubocop/formatter/formatter_set.rb
@@ -322,6 +309,8 @@ files:
 - spec/rubocop/cops/lint/shadowing_outer_local_variable_spec.rb
 - spec/rubocop/cops/lint/unreachable_code_spec.rb
 - spec/rubocop/cops/lint/unused_local_variable_spec.rb
+- spec/rubocop/cops/lint/useless_assignment_spec.rb
+- spec/rubocop/cops/lint/useless_comparison_spec.rb
 - spec/rubocop/cops/lint/void_spec.rb
 - spec/rubocop/cops/offence_spec.rb
 - spec/rubocop/cops/rails/validation_spec.rb
@@ -374,6 +363,7 @@ files:
 - spec/rubocop/cops/style/method_and_variable_snake_case_spec.rb
 - spec/rubocop/cops/style/method_call_parentheses_spec.rb
 - spec/rubocop/cops/style/method_length_spec.rb
+- spec/rubocop/cops/style/module_function_spec.rb
 - spec/rubocop/cops/style/multiline_if_then_spec.rb
 - spec/rubocop/cops/style/not_spec.rb
 - spec/rubocop/cops/style/numeric_literals_spec.rb
@@ -389,6 +379,7 @@ files:
 - spec/rubocop/cops/style/regexp_literal_spec.rb
 - spec/rubocop/cops/style/rescue_modifier_spec.rb
 - spec/rubocop/cops/style/semicolon_spec.rb
+- spec/rubocop/cops/style/signal_exception_spec.rb
 - spec/rubocop/cops/style/single_line_methods_spec.rb
 - spec/rubocop/cops/style/space_after_colon_spec.rb
 - spec/rubocop/cops/style/space_after_comma_spec.rb
@@ -415,6 +406,7 @@ files:
 - spec/rubocop/cops/variable_inspector_spec.rb
 - spec/rubocop/formatter/base_formatter_spec.rb
 - spec/rubocop/formatter/clang_style_formatter_spec.rb
+- spec/rubocop/formatter/disabled_config_formatter_spec.rb
 - spec/rubocop/formatter/emacs_style_formatter_spec.rb
 - spec/rubocop/formatter/file_list_formatter_spec.rb
 - spec/rubocop/formatter/formatter_set_spec.rb
@@ -433,30 +425,26 @@ files:
 homepage: http://github.com/bbatsov/rubocop
 licenses:
 - MIT
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: 1.9.2
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 1297865903551082262
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.23
+rubygems_version: 2.0.3
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Automatic Ruby code style checking tool.
 test_files:
 - spec/.rubocop.yml
@@ -481,6 +469,8 @@ test_files:
 - spec/rubocop/cops/lint/shadowing_outer_local_variable_spec.rb
 - spec/rubocop/cops/lint/unreachable_code_spec.rb
 - spec/rubocop/cops/lint/unused_local_variable_spec.rb
+- spec/rubocop/cops/lint/useless_assignment_spec.rb
+- spec/rubocop/cops/lint/useless_comparison_spec.rb
 - spec/rubocop/cops/lint/void_spec.rb
 - spec/rubocop/cops/offence_spec.rb
 - spec/rubocop/cops/rails/validation_spec.rb
@@ -533,6 +523,7 @@ test_files:
 - spec/rubocop/cops/style/method_and_variable_snake_case_spec.rb
 - spec/rubocop/cops/style/method_call_parentheses_spec.rb
 - spec/rubocop/cops/style/method_length_spec.rb
+- spec/rubocop/cops/style/module_function_spec.rb
 - spec/rubocop/cops/style/multiline_if_then_spec.rb
 - spec/rubocop/cops/style/not_spec.rb
 - spec/rubocop/cops/style/numeric_literals_spec.rb
@@ -548,6 +539,7 @@ test_files:
 - spec/rubocop/cops/style/regexp_literal_spec.rb
 - spec/rubocop/cops/style/rescue_modifier_spec.rb
 - spec/rubocop/cops/style/semicolon_spec.rb
+- spec/rubocop/cops/style/signal_exception_spec.rb
 - spec/rubocop/cops/style/single_line_methods_spec.rb
 - spec/rubocop/cops/style/space_after_colon_spec.rb
 - spec/rubocop/cops/style/space_after_comma_spec.rb
@@ -574,6 +566,7 @@ test_files:
 - spec/rubocop/cops/variable_inspector_spec.rb
 - spec/rubocop/formatter/base_formatter_spec.rb
 - spec/rubocop/formatter/clang_style_formatter_spec.rb
+- spec/rubocop/formatter/disabled_config_formatter_spec.rb
 - spec/rubocop/formatter/emacs_style_formatter_spec.rb
 - spec/rubocop/formatter/file_list_formatter_spec.rb
 - spec/rubocop/formatter/formatter_set_spec.rb