rubocop 0.0.0 → 0.1.0

data/spec/rubocop/cops/grammar_spec.rb

@@ -0,0 +1,24 @@
+require 'spec_helper'
+
+module Rubocop
+  module Cop
+    describe Grammar do
+      EXAMPLE = '3.times { |i| x = i }'
+      let (:grammar) { Grammar.new(Ripper.lex(EXAMPLE)) }
+
+      it "correlates token indices to grammar paths" do
+        method_block = [:program, :method_add_block]
+        grammar.correlate(Ripper.sexp(EXAMPLE)).should == {
+          0  => method_block + [:call, :@int],
+          2  => method_block + [:call, :@ident],
+          6  => method_block + [:brace_block, :block_var],
+          7  => method_block + [:brace_block, :block_var, :params, :@ident],
+          8  => method_block + [:brace_block, :block_var],
+          10 => method_block + [:brace_block, :assign, :var_field, :@ident],
+          12 => method_block + [:brace_block, :assign],
+          14 => method_block + [:brace_block, :assign, :var_ref, :@ident],
+        }
+      end
+    end
+  end
+end

data/spec/rubocop/cops/indentation_spec.rb

@@ -0,0 +1,60 @@
+require 'spec_helper'
+
+module Rubocop
+  module Cop
+    describe Indentation do
+      let (:ind) { Indentation.new }
+
+      it "registers an offence for a when clause that's deeper than case" do
+        source = ['case a',
+                  '    when 0 then return',
+                  '        case b',
+                  '         when 1 then return',
+                  '        end',
+                  'end']
+        ind.inspect_source('file.rb', source)
+        ind.offences.size.should == 2
+      end
+
+      it "accepts a when clause that's equally indented with case" do
+        source = ['y = case a',
+                  '    when 0 then break',
+                  '    when 0 then return',
+                  '      z = case b',
+                  '          when 1 then return',
+                  '          when 1 then break',
+                  '          end',
+                  '    end',
+                  'case c',
+                  'when 2 then encoding',
+                  'end',
+                  '']
+        ind.inspect_source('file.rb', source)
+        ind.offences.size.should == 0
+      end
+
+      it "doesn't get confused by strings with case in them" do
+        source = ['a = "case"',
+                  'case x',
+                  'when 0',
+                  'end',
+                  '']
+        ind.inspect_source('file.rb', source)
+        ind.offences.map(&:message).should == []
+      end
+
+      it "doesn't get confused by symbols named case or when" do
+        source = ['KEYWORDS = { :case => true, :when => true }',
+                  'case type',
+                  'when 0',
+                  '  ParameterNode',
+                  'when 1',
+                  '  MethodCallNode',
+                  'end',
+                  '']
+        ind.inspect_source('file.rb', source)
+        ind.offences.map(&:message).should == []
+      end
+    end
+  end
+end

data/spec/rubocop/cops/line_length_spec.rb

@@ -0,0 +1,20 @@
+require 'spec_helper'
+
+module Rubocop
+  module Cop
+    describe LineLength do
+      let (:ll) { LineLength.new }
+
+      it "registers an offence for a line that's 80 characters wide" do
+        ll.inspect('file.rb', ['#' * 80])
+        ll.offences.size.should == 1
+        ll.offences.first.message.should == 'Line is too long. [80/79]'
+      end
+
+      it "accepts a line that's 79 characters wide" do
+        ll.inspect('file.rb', ['#' * 79])
+        ll.offences.size.should == 0
+      end
+    end
+  end
+end

data/spec/rubocop/cops/offence_spec.rb

@@ -0,0 +1,22 @@
+require 'spec_helper'
+
+module Rubocop
+  module Cop
+    describe Offence do
+      it 'has a few required attributes' do
+        offence = Offence.new(:convention, 1, 'line', 'message')
+
+        offence.severity.should == :convention
+        offence.line_number.should == 1
+        offence.line.should == 'line'
+        offence.message.should == 'message'
+      end
+
+      it 'overrides #to_s' do
+        offence = Offence.new(:convention, 1, 'line', 'message')
+
+        offence.to_s.should == 'C:  1: message'
+      end
+    end
+  end
+end

data/spec/rubocop/cops/space_after_comma_etc_spec.rb

@@ -0,0 +1,37 @@
+require 'spec_helper'
+
+module Rubocop
+  module Cop
+    describe SpaceAfterCommaEtc do
+      let (:space) { SpaceAfterCommaEtc.new }
+
+      it 'registers an offence for block argument commas' do
+        space.inspect_source('file.rb', ['each { |s,t| }'])
+        space.offences.map(&:message).should ==
+          ['Space missing after comma.']
+      end
+
+      it 'registers an offence for colon without space after it' do
+        space.inspect_source('file.rb', ['x = w ? {a:3}:4'])
+        space.offences.map(&:message).should ==
+          ['Space missing after colon.'] * 2
+      end
+
+      it 'registers an offence for semicolon without space after it' do
+        space.inspect_source('file.rb', ['x = 1;y = 2'])
+        space.offences.map(&:message).should ==
+          ['Space missing after semicolon.']
+      end
+
+      it 'allows the colons in symbols' do
+        space.inspect_source('file.rb', ['x = :a'])
+        space.offences.map(&:message).should == []
+      end
+
+      it 'allows colons in strings' do
+        space.inspect_source('file.rb', ["str << ':'"])
+        space.offences.map(&:message).should == []
+      end
+    end
+  end
+end

data/spec/rubocop/cops/surrounding_space_spec.rb

@@ -0,0 +1,128 @@
+require 'spec_helper'
+
+module Rubocop
+  module Cop
+    describe SurroundingSpace do
+      let (:space) { SurroundingSpace.new }
+
+      it 'registers an offence for assignment without space on both sides' do
+        space.inspect_source('file.rb', ['x=0', 'y= 0', 'z =0'])
+        space.offences.size.should == 3
+        space.offences.first.message.should ==
+          "Surrounding space missing for operator '='."
+      end
+
+      it 'registers an offence for binary operators that could be unary' do
+        space.inspect_source('file.rb', ['a-3', 'x&0xff', 'z+0'])
+        space.offences.map(&:message).should ==
+          ["Surrounding space missing for operator '-'.",
+           "Surrounding space missing for operator '&'.",
+           "Surrounding space missing for operator '+'."]
+      end
+
+      it 'registers an offence for arguments to a method' do
+        space.inspect_source('file.rb', ['puts 1+2'])
+        space.offences.map(&:message).should ==
+          ["Surrounding space missing for operator '+'."]
+      end
+
+      it 'accepts parentheses in block parameter list' do
+        space.inspect_source('file.rb',
+                             ['list.inject(Tms.new) { |sum, (label, item)|',
+                              '}'])
+        space.offences.map(&:message).should == []
+      end
+
+      it 'accepts operator symbols' do
+        space.inspect_source('file.rb', ['func(:-)'])
+        space.offences.map(&:message).should == []
+      end
+
+      it 'accepts ranges' do
+        space.inspect_source('file.rb', ['a, b = (1..2), (1...3)'])
+        space.offences.map(&:message).should == []
+      end
+
+      it 'accepts scope operator' do
+        source = ['@io.class == Zlib::GzipWriter']
+        space.inspect_source('file.rb', source)
+        space.offences.map(&:message).should == []
+      end
+
+      it 'accepts ::Kernel::raise' do
+        source = ['::Kernel::raise IllegalBlockError.new']
+        space.inspect_source('file.rb', source)
+        space.offences.map(&:message).should == []
+      end
+
+      it 'accepts exclamation point negation' do
+        space.inspect_source('file.rb', ['x = !a&&!b'])
+        space.offences.map(&:message).should ==
+          ["Surrounding space missing for operator '&&'."]
+      end
+
+      it 'accepts exclamation point definition' do
+        space.inspect_source('file.rb', ['  def !',
+                                         '    !__getobj__',
+                                         '  end'])
+        space.offences.should == []
+        space.offences.map(&:message).should == []
+      end
+
+      it 'accepts a unary' do
+        space.inspect_source('file.rb',
+                             ['  def bm(label_width = 0, *labels, &blk)',
+                              '    benchmark(CAPTION, label_width, FORMAT,',
+                              '              *labels, &blk)',
+                              '  end',
+                              ''])
+        space.offences.map(&:message).should == []
+      end
+
+      it 'accepts splat operator' do
+        space.inspect_source('file.rb', ['return *list if options'])
+        space.offences.map(&:message).should == []
+      end
+
+      it 'accepts square brackets as method name' do
+        space.inspect_source('file.rb', ['def Vector.[](*array)',
+                                         'end'])
+        space.offences.map(&:message).should == []
+      end
+
+      it 'accepts def of operator' do
+        space.inspect_source('file.rb', ['def +(other); end'])
+        space.offences.map(&:message).should == []
+      end
+
+      it 'accepts an assignment with spaces' do
+        space.inspect_source('file.rb', ['x = 0'])
+        space.offences.size.should == 0
+      end
+
+      it "accepts some operators that are exceptions and don't need spaces" do
+        space.inspect_source('file.rb', ['(1..3)',
+                                         'ActionController::Base',
+                                         'each { |s, t| }'])
+        space.offences.map(&:message).should == []
+      end
+
+      it 'accepts an assignment followed by newline' do
+        space.inspect_source('file.rb', ['x =\n  0'])
+        space.offences.size.should == 0
+      end
+
+      it 'accepts unary operators without space' do
+        space.inspect_source('file.rb', ['[].map(&:size)',
+                                         '-3',
+                                         'x = +2'])
+        space.offences.map(&:message).should == []
+      end
+
+      it 'accepts square brackets called with method call syntax' do
+        space.inspect_source('file.rb', ['subject.[](0)'])
+        space.offences.map(&:message).should == []
+      end
+    end
+  end
+end

data/spec/rubocop/cops/tab_spec.rb

@@ -0,0 +1,19 @@
+require 'spec_helper'
+
+module Rubocop
+  module Cop
+    describe Tab do
+      let (:tab) { Tab.new }
+
+      it 'registers an offence for a line indented with tab' do
+        tab.inspect('file.rb', ["\tx = 0"])
+        tab.offences.size.should == 1
+      end
+
+      it 'accepts a line with tab in a string' do
+        tab.inspect('file.rb', [%Q(x = "\t")])
+        tab.offences.size.should == 0
+      end
+    end
+  end
+end

data/spec/rubocop/cops/trailing_whitespace_spec.rb

@@ -0,0 +1,25 @@
+require 'spec_helper'
+
+module Rubocop
+  module Cop
+    describe TrailingWhitespace do
+      let (:tws) { TrailingWhitespace.new }
+
+      it 'registers an offence for a line ending with space' do
+        source = ['x = 0 ']
+        tws.inspect('file.rb', source)
+        tws.offences.size.should == 1
+      end
+
+      it 'registers an offence for a line ending with tab' do
+        tws.inspect('file.rb', ["x = 0\t"])
+        tws.offences.size.should == 1
+      end
+
+      it 'accepts a line without trailing whitespace' do
+        tws.inspect('file.rb', ["x = 0\n"])
+        tws.offences.size.should == 0
+      end
+    end
+  end
+end

data/spec/rubocop/reports/emacs_style_spec.rb

@@ -0,0 +1,23 @@
+require 'spec_helper'
+require 'stringio'
+
+module Rubocop
+  module Report
+    describe EmacsStyle do
+      let (:emacs_style) { Rubocop::Report.create('test', :emacs_style) }
+
+      it 'displays parsable text' do
+        cop = Cop::Cop.new
+        cop.add_offence(:convention, 0, 'line', 'message 1')
+        cop.add_offence(:fatal,     10, 'line', 'message 2')
+
+        emacs_style << cop
+
+        s = StringIO.new
+        emacs_style.display(s)
+        s.string.should == ["test:1: C: message 1",
+                            "test:11: F: message 2\n"].join("\n")
+      end
+    end
+  end
+end

data/spec/rubocop/reports/report_spec.rb

@@ -0,0 +1,27 @@
+require 'spec_helper'
+
+module Rubocop
+  module Report
+    describe Report do
+      let (:report) { Report.new('test') }
+
+      it 'initially has 0 entries' do
+        report.entries.size.should == 0
+      end
+
+      it 'initially has nothing to report' do
+        report.empty?.should be_true
+      end
+
+      it 'keeps track of offences' do
+        cop = Cop::Cop.new
+        cop.add_offence(:convention, 0, 'line', 'message')
+
+        report << cop
+
+        report.empty?.should be_false
+        report.entries.size.should == 1
+      end
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -7,6 +7,30 @@ require 'rubocop'
 # in ./support/ and its subdirectories.
 Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each {|f| require f}
 
+module ExitCodeMatchers
+  RSpec::Matchers.define :exit_with_code do |code|
+    actual = nil
+    match do |block|
+      begin
+        block.call
+      rescue SystemExit => e
+        actual = e.status
+      end
+      actual and actual == code
+    end
+    failure_message_for_should do |block|
+      "expected block to call exit(#{code}) but exit" +
+        (actual.nil? ? " not called" : "(#{actual}) was called")
+    end
+    failure_message_for_should_not do |block|
+      "expected block not to call exit(#{code})"
+    end
+    description do
+      "expect block to call exit(#{code})"
+    end
+  end
+end
+
 RSpec.configure do |config|
-  
+  config.include(ExitCodeMatchers)
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop
 version: !ruby/object:Gem::Version
-  version: 0.0.0
+  version: 0.1.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-05-03 00:00:00.000000000 Z
+date: 2012-12-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70138309473860 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -21,10 +21,15 @@ dependencies:
         version: 2.8.0
   type: :development
   prerelease: false
-  version_requirements: *70138309473860
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 2.8.0
 - !ruby/object:Gem::Dependency
   name: yard
-  requirement: &70138309487180 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -32,10 +37,31 @@ dependencies:
         version: '0.7'
   type: :development
   prerelease: false
-  version_requirements: *70138309487180
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '0.7'
+- !ruby/object:Gem::Dependency
+  name: redcarpet
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: cucumber
-  requirement: &70138309483540 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +69,15 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70138309483540
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
-  requirement: &70138309491060 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -54,10 +85,15 @@ dependencies:
         version: 1.1.0
   type: :development
   prerelease: false
-  version_requirements: *70138309491060
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 1.1.0
 - !ruby/object:Gem::Dependency
   name: jeweler
-  requirement: &70138309505580 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -65,10 +101,15 @@ dependencies:
         version: 1.8.3
   type: :development
   prerelease: false
-  version_requirements: *70138309505580
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 1.8.3
 - !ruby/object:Gem::Dependency
   name: simplecov
-  requirement: &70138309504800 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -76,7 +117,12 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70138309504800
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Automatic Ruby code style checking tool. Aims to enforce the community-driven
   Ruby Style Guide.
 email: bozhidar@batsov.com
@@ -103,10 +149,34 @@ files:
 - lib/rubocop.rb
 - lib/rubocop/cli.rb
 - lib/rubocop/cop/cop.rb
-- lib/rubocop/cop/line_length_cop.rb
+- lib/rubocop/cop/empty_lines.rb
+- lib/rubocop/cop/encoding.rb
+- lib/rubocop/cop/grammar.rb
+- lib/rubocop/cop/indentation.rb
+- lib/rubocop/cop/line_length.rb
 - lib/rubocop/cop/offence.rb
+- lib/rubocop/cop/space_after_comma_etc.rb
+- lib/rubocop/cop/surrounding_space.rb
+- lib/rubocop/cop/tab.rb
+- lib/rubocop/cop/trailing_whitespace.rb
+- lib/rubocop/report/emacs_style.rb
+- lib/rubocop/report/plain_text.rb
+- lib/rubocop/report/report.rb
 - lib/rubocop/version.rb
-- spec/rubocop_spec.rb
+- rubocop.gemspec
+- spec/rubocop/cli_spec.rb
+- spec/rubocop/cops/cop_spec.rb
+- spec/rubocop/cops/empty_lines_spec.rb
+- spec/rubocop/cops/grammar_spec.rb
+- spec/rubocop/cops/indentation_spec.rb
+- spec/rubocop/cops/line_length_spec.rb
+- spec/rubocop/cops/offence_spec.rb
+- spec/rubocop/cops/space_after_comma_etc_spec.rb
+- spec/rubocop/cops/surrounding_space_spec.rb
+- spec/rubocop/cops/tab_spec.rb
+- spec/rubocop/cops/trailing_whitespace_spec.rb
+- spec/rubocop/reports/emacs_style_spec.rb
+- spec/rubocop/reports/report_spec.rb
 - spec/spec_helper.rb
 homepage: http://github.com/bbatsov/rubocop
 licenses:
@@ -123,7 +193,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 2147834688713714248
+      hash: 3628988712986097770
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -132,7 +202,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.15
+rubygems_version: 1.8.23
 signing_key: 
 specification_version: 3
 summary: Automatic Ruby code style checking tool.