rubocop 0.78.0

data/lib/rubocop/cop/style/redundant_conditional.rb

@@ -0,0 +1,97 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Style
+      # This cop checks for redundant returning of true/false in conditionals.
+      #
+      # @example
+      #   # bad
+      #   x == y ? true : false
+      #
+      #   # bad
+      #   if x == y
+      #     true
+      #   else
+      #     false
+      #   end
+      #
+      #   # good
+      #   x == y
+      #
+      #   # bad
+      #   x == y ? false : true
+      #
+      #   # good
+      #   x != y
+      class RedundantConditional < Cop
+        include Alignment
+
+        COMPARISON_OPERATORS = RuboCop::AST::Node::COMPARISON_OPERATORS
+
+        MSG = 'This conditional expression can just be replaced ' \
+              'by `%<msg>s`.'
+
+        def on_if(node)
+          return unless offense?(node)
+
+          add_offense(node)
+        end
+
+        def autocorrect(node)
+          lambda do |corrector|
+            corrector.replace(node.loc.expression, replacement_condition(node))
+          end
+        end
+
+        private
+
+        def message(node)
+          replacement = replacement_condition(node)
+          msg = node.elsif? ? "\n#{replacement}" : replacement
+
+          format(MSG, msg: msg)
+        end
+
+        def_node_matcher :redundant_condition?, <<~RUBY
+          (if (send _ {:#{COMPARISON_OPERATORS.join(' :')}} _) true false)
+        RUBY
+
+        def_node_matcher :redundant_condition_inverted?, <<~RUBY
+          (if (send _ {:#{COMPARISON_OPERATORS.join(' :')}} _) false true)
+        RUBY
+
+        def offense?(node)
+          return if node.modifier_form?
+
+          redundant_condition?(node) || redundant_condition_inverted?(node)
+        end
+
+        def replacement_condition(node)
+          condition = node.condition.source
+          expression = invert_expression?(node) ? "!(#{condition})" : condition
+
+          node.elsif? ? indented_else_node(expression, node) : expression
+        end
+
+        def invert_expression?(node)
+          (
+            (node.if? || node.elsif? || node.ternary?) &&
+            redundant_condition_inverted?(node)
+          ) || (
+            node.unless? &&
+            redundant_condition?(node)
+          )
+        end
+
+        def indented_else_node(expression, node)
+          "else\n#{indentation(node)}#{expression}"
+        end
+
+        def configured_indentation_width
+          super || 2
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/style/redundant_exception.rb

@@ -0,0 +1,60 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Style
+      # This cop checks for RuntimeError as the argument of raise/fail.
+      #
+      # It checks for code like this:
+      #
+      # @example
+      #   # Bad
+      #   raise RuntimeError, 'message'
+      #
+      #   # Bad
+      #   raise RuntimeError.new('message')
+      #
+      #   # Good
+      #   raise 'message'
+      class RedundantException < Cop
+        MSG_1 = 'Redundant `RuntimeError` argument can be removed.'
+        MSG_2 = 'Redundant `RuntimeError.new` call can be replaced with ' \
+                'just the message.'
+
+        def on_send(node)
+          exploded?(node) { return add_offense(node, message: MSG_1) }
+          compact?(node) { add_offense(node, message: MSG_2) }
+        end
+
+        # Switch `raise RuntimeError, 'message'` to `raise 'message'`, and
+        # `raise RuntimeError.new('message')` to `raise 'message'`.
+        def autocorrect(node) # rubocop:disable Metrics/MethodLength
+          exploded?(node) do |command, message|
+            return lambda do |corrector|
+              if node.parenthesized?
+                corrector.replace(node.source_range,
+                                  "#{command}(#{message.source})")
+              else
+                corrector.replace(node.source_range,
+                                  "#{command} #{message.source}")
+              end
+            end
+          end
+          compact?(node) do |new_call, message|
+            lambda do |corrector|
+              corrector.replace(new_call.source_range, message.source)
+            end
+          end
+        end
+
+        def_node_matcher :exploded?, <<~PATTERN
+          (send nil? ${:raise :fail} (const nil? :RuntimeError) $_)
+        PATTERN
+
+        def_node_matcher :compact?, <<~PATTERN
+          (send nil? {:raise :fail} $(send (const nil? :RuntimeError) :new $_))
+        PATTERN
+      end
+    end
+  end
+end

data/lib/rubocop/cop/style/redundant_freeze.rb

@@ -0,0 +1,67 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Style
+      # This cop check for uses of Object#freeze on immutable objects.
+      #
+      # @example
+      #   # bad
+      #   CONST = 1.freeze
+      #
+      #   # good
+      #   CONST = 1
+      class RedundantFreeze < Cop
+        include FrozenStringLiteral
+
+        MSG = 'Do not freeze immutable objects, as freezing them has no ' \
+              'effect.'
+
+        def on_send(node)
+          return unless node.receiver && node.method?(:freeze) &&
+                        (immutable_literal?(node.receiver) ||
+                         operation_produces_immutable_object?(node.receiver))
+
+          add_offense(node)
+        end
+
+        def autocorrect(node)
+          lambda do |corrector|
+            corrector.remove(node.loc.dot)
+            corrector.remove(node.loc.selector)
+          end
+        end
+
+        private
+
+        def immutable_literal?(node)
+          node = strip_parenthesis(node)
+
+          return true if node.immutable_literal?
+
+          FROZEN_STRING_LITERAL_TYPES.include?(node.type) &&
+            frozen_string_literals_enabled?
+        end
+
+        def strip_parenthesis(node)
+          if node.begin_type? && node.children.first
+            node.children.first
+          else
+            node
+          end
+        end
+
+        def_node_matcher :operation_produces_immutable_object?, <<~PATTERN
+          {
+            (begin (send {float int} {:+ :- :* :** :/ :% :<<} _))
+            (begin (send !(str _) {:+ :- :* :** :/ :%} {float int}))
+            (begin (send _ {:== :=== :!= :<= :>= :< :>} _))
+            (send (const nil? :ENV) :[] _)
+            (send _ {:count :length :size} ...)
+            (block (send _ {:count :length :size} ...) ...)
+          }
+        PATTERN
+      end
+    end
+  end
+end

data/lib/rubocop/cop/style/redundant_interpolation.rb

@@ -0,0 +1,98 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Style
+      # This cop checks for strings that are just an interpolated expression.
+      #
+      # @example
+      #
+      #   # bad
+      #   "#{@var}"
+      #
+      #   # good
+      #   @var.to_s
+      #
+      #   # good if @var is already a String
+      #   @var
+      class RedundantInterpolation < Cop
+        include PercentLiteral
+
+        MSG = 'Prefer `to_s` over string interpolation.'
+
+        def self.autocorrect_incompatible_with
+          [Style::LineEndConcatenation]
+        end
+
+        def on_dstr(node)
+          add_offense(node) if single_interpolation?(node)
+        end
+
+        def autocorrect(node)
+          embedded_node = node.children.first
+
+          if variable_interpolation?(embedded_node)
+            autocorrect_variable_interpolation(embedded_node, node)
+          elsif single_variable_interpolation?(embedded_node)
+            autocorrect_single_variable_interpolation(embedded_node, node)
+          else
+            autocorrect_other(embedded_node, node)
+          end
+        end
+
+        private
+
+        def single_interpolation?(node)
+          node.children.one? &&
+            interpolation?(node.children.first) &&
+            !implicit_concatenation?(node) &&
+            !embedded_in_percent_array?(node)
+        end
+
+        def single_variable_interpolation?(node)
+          node.children.one? && variable_interpolation?(node.children.first)
+        end
+
+        def interpolation?(node)
+          variable_interpolation?(node) || node.begin_type?
+        end
+
+        def variable_interpolation?(node)
+          node.variable? || node.reference?
+        end
+
+        def implicit_concatenation?(node)
+          node.parent&.dstr_type?
+        end
+
+        def embedded_in_percent_array?(node)
+          node.parent&.array_type? &&
+            percent_literal?(node.parent)
+        end
+
+        def autocorrect_variable_interpolation(embedded_node, node)
+          replacement = "#{embedded_node.loc.expression.source}.to_s"
+          ->(corrector) { corrector.replace(node.loc.expression, replacement) }
+        end
+
+        def autocorrect_single_variable_interpolation(embedded_node, node)
+          variable_loc = embedded_node.children.first.loc
+          replacement = "#{variable_loc.expression.source}.to_s"
+          ->(corrector) { corrector.replace(node.loc.expression, replacement) }
+        end
+
+        def autocorrect_other(embedded_node, node)
+          loc = node.loc
+          embedded_loc = embedded_node.loc
+
+          lambda do |corrector|
+            corrector.replace(loc.begin, '')
+            corrector.replace(loc.end, '')
+            corrector.replace(embedded_loc.begin, '(')
+            corrector.replace(embedded_loc.end, ').to_s')
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/style/redundant_parentheses.rb

@@ -0,0 +1,231 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Style
+      # This cop checks for redundant parentheses.
+      #
+      # @example
+      #
+      #   # bad
+      #   (x) if ((y.z).nil?)
+      #
+      #   # good
+      #   x if y.z.nil?
+      #
+      class RedundantParentheses < Cop
+        include Parentheses
+
+        def_node_matcher :square_brackets?,
+                         '(send {(send _recv _msg) str array hash} :[] ...)'
+        def_node_matcher :range_end?, '^^{irange erange}'
+        def_node_matcher :method_node_and_args, '$(call _recv _msg $...)'
+        def_node_matcher :rescue?, '{^resbody ^^resbody}'
+        def_node_matcher :arg_in_call_with_block?,
+                         '^^(block (send _ _ equal?(%0) ...) ...)'
+
+        def on_begin(node)
+          return if !parentheses?(node) || parens_allowed?(node)
+          return if node.parent && (node.parent.while_post_type? ||
+                                    node.parent.until_post_type?)
+
+          check(node)
+        end
+
+        def autocorrect(node)
+          ParenthesesCorrector.correct(node)
+        end
+
+        private
+
+        def parens_allowed?(node)
+          empty_parentheses?(node) ||
+            first_arg_begins_with_hash_literal?(node) ||
+            rescue?(node) ||
+            allowed_expression?(node)
+        end
+
+        def allowed_expression?(node)
+          allowed_ancestor?(node) ||
+            allowed_method_call?(node) ||
+            allowed_array_or_hash_element?(node) ||
+            allowed_multiple_expression?(node)
+        end
+
+        def allowed_ancestor?(node)
+          # Don't flag `break(1)`, etc
+          keyword_ancestor?(node) && parens_required?(node)
+        end
+
+        def allowed_method_call?(node)
+          # Don't flag `method (arg) { }`
+          arg_in_call_with_block?(node) && !parentheses?(node.parent)
+        end
+
+        def allowed_multiple_expression?(node)
+          return false if node.children.one?
+
+          ancestor = node.ancestors.first
+          return false unless ancestor
+
+          !ancestor.begin_type? && !ancestor.def_type? && !ancestor.block_type?
+        end
+
+        def empty_parentheses?(node)
+          # Don't flag `()`
+          node.children.empty?
+        end
+
+        def first_arg_begins_with_hash_literal?(node)
+          # Don't flag `method ({key: value})` or `method ({key: value}.method)`
+          method_chain_begins_with_hash_literal?(node.children.first) &&
+            first_argument?(node) &&
+            !parentheses?(node.parent)
+        end
+
+        def method_chain_begins_with_hash_literal?(node)
+          return false if node.nil?
+          return true if node.hash_type?
+          return false unless node.send_type?
+
+          method_chain_begins_with_hash_literal?(node.children.first)
+        end
+
+        def check(begin_node)
+          node = begin_node.children.first
+          if keyword_with_redundant_parentheses?(node)
+            return offense(begin_node, 'a keyword')
+          end
+          if disallowed_literal?(begin_node, node)
+            return offense(begin_node, 'a literal')
+          end
+          return offense(begin_node, 'a variable') if node.variable?
+          return offense(begin_node, 'a constant') if node.const_type?
+
+          check_send(begin_node, node) if node.call_type?
+        end
+
+        def check_send(begin_node, node)
+          return check_unary(begin_node, node) if node.unary_operation?
+
+          return unless method_call_with_redundant_parentheses?(node)
+          return if call_chain_starts_with_int?(begin_node, node)
+
+          offense(begin_node, 'a method call')
+        end
+
+        def check_unary(begin_node, node)
+          return if begin_node.chained?
+
+          node = node.children.first while suspect_unary?(node)
+
+          if node.send_type?
+            return unless method_call_with_redundant_parentheses?(node)
+          end
+
+          offense(begin_node, 'an unary operation')
+        end
+
+        def offense(node, msg)
+          add_offense(node, message: "Don't use parentheses around #{msg}.")
+        end
+
+        def suspect_unary?(node)
+          node.send_type? && node.unary_operation? && !node.prefix_not?
+        end
+
+        def keyword_ancestor?(node)
+          node.parent&.keyword?
+        end
+
+        def allowed_array_or_hash_element?(node)
+          # Don't flag
+          # ```
+          # { a: (1
+          #      ), }
+          # ```
+          (hash_element?(node) || array_element?(node)) &&
+            only_closing_paren_before_comma?(node)
+        end
+
+        def hash_element?(node)
+          node.parent&.pair_type?
+        end
+
+        def array_element?(node)
+          node.parent&.array_type?
+        end
+
+        def only_closing_paren_before_comma?(node)
+          source_buffer = node.source_range.source_buffer
+          line_range = source_buffer.line_range(node.loc.end.line)
+
+          line_range.source =~ /^\s*\)\s*,/
+        end
+
+        def disallowed_literal?(begin_node, node)
+          node.literal? &&
+            !node.range_type? &&
+            !raised_to_power_negative_numeric?(begin_node, node)
+        end
+
+        def raised_to_power_negative_numeric?(begin_node, node)
+          return false unless node.numeric_type?
+
+          siblings = begin_node.parent&.children
+          return false if siblings.nil?
+
+          next_sibling = siblings[begin_node.sibling_index + 1]
+          base_value = node.children.first
+
+          base_value.negative? && next_sibling == :**
+        end
+
+        def keyword_with_redundant_parentheses?(node)
+          return false unless node.keyword?
+          return true if node.special_keyword?
+
+          args = *node
+
+          if only_begin_arg?(args)
+            parentheses?(args.first)
+          else
+            args.empty? || parentheses?(node)
+          end
+        end
+
+        def method_call_with_redundant_parentheses?(node)
+          return false unless node.call_type?
+          return false if node.prefix_not?
+          return false if range_end?(node)
+
+          send_node, args = method_node_and_args(node)
+
+          args.empty? || parentheses?(send_node) || square_brackets?(send_node)
+        end
+
+        def only_begin_arg?(args)
+          args.one? && args.first.begin_type?
+        end
+
+        def first_argument?(node)
+          first_send_argument?(node) || first_super_argument?(node)
+        end
+
+        def_node_matcher :first_send_argument?, <<~PATTERN
+          ^(send _ _ equal?(%0) ...)
+        PATTERN
+
+        def_node_matcher :first_super_argument?, <<~PATTERN
+          ^(super equal?(%0) ...)
+        PATTERN
+
+        def call_chain_starts_with_int?(begin_node, send_node)
+          recv = first_part_of_call_chain(send_node)
+          recv&.int_type? && (parent = begin_node.parent) &&
+            parent.send_type? && (parent.method?(:-@) || parent.method?(:+@))
+        end
+      end
+    end
+  end
+end