rubocop 0.75.1

data/lib/rubocop/cop/style/missing_respond_to_missing.rb

@@ -0,0 +1,46 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Style
+      # This cop checks for the presence of `method_missing` without also
+      # defining `respond_to_missing?`.
+      #
+      # @example
+      #   #bad
+      #   def method_missing(name, *args)
+      #     # ...
+      #   end
+      #
+      #   #good
+      #   def respond_to_missing?(name, include_private)
+      #     # ...
+      #   end
+      #
+      #   def method_missing(name, *args)
+      #     # ...
+      #   end
+      #
+      class MissingRespondToMissing < Cop
+        MSG =
+          'When using `method_missing`, define `respond_to_missing?`.'
+
+        def on_def(node)
+          return unless node.method?(:method_missing)
+          return if implements_respond_to_missing?(node)
+
+          add_offense(node)
+        end
+        alias on_defs on_def
+
+        private
+
+        def implements_respond_to_missing?(node)
+          node.parent.each_child_node(node.type).any? do |sibling|
+            sibling.method?(:respond_to_missing?)
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/style/mixin_grouping.rb

@@ -0,0 +1,148 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Style
+      # This cop checks for grouping of mixins in `class` and `module` bodies.
+      # By default it enforces mixins to be placed in separate declarations,
+      # but it can be configured to enforce grouping them in one declaration.
+      #
+      # @example EnforcedStyle: separated (default)
+      #   # bad
+      #   class Foo
+      #     include Bar, Qox
+      #   end
+      #
+      #   # good
+      #   class Foo
+      #     include Qox
+      #     include Bar
+      #   end
+      #
+      # @example EnforcedStyle: grouped
+      #   # bad
+      #   class Foo
+      #     extend Bar
+      #     extend Qox
+      #   end
+      #
+      #   # good
+      #   class Foo
+      #     extend Qox, Bar
+      #   end
+      class MixinGrouping < Cop
+        include ConfigurableEnforcedStyle
+
+        MIXIN_METHODS = %i[extend include prepend].freeze
+        MSG = 'Put `%<mixin>s` mixins in %<suffix>s.'
+
+        def on_class(node)
+          begin_node = node.child_nodes.find(&:begin_type?) || node
+          begin_node.each_child_node(:send).select(&:macro?).each do |macro|
+            next unless MIXIN_METHODS.include?(macro.method_name)
+
+            check(macro)
+          end
+        end
+
+        alias on_module on_class
+
+        def autocorrect(node)
+          range = node.loc.expression
+          if separated_style?
+            correction = separate_mixins(node)
+          else
+            mixins = sibling_mixins(node)
+            if node == mixins.first
+              correction = group_mixins(node, mixins)
+            else
+              range = range_to_remove_for_subsequent_mixin(mixins, node)
+              correction = ''
+            end
+          end
+
+          ->(corrector) { corrector.replace(range, correction) }
+        end
+
+        private
+
+        def range_to_remove_for_subsequent_mixin(mixins, node)
+          range = node.loc.expression
+          prev_mixin = mixins.each_cons(2) { |m, n| break m if n == node }
+          between = prev_mixin.loc.expression.end
+                              .join(range.begin)
+          # if separated from previous mixin with only whitespace?
+          if between.source !~ /\S/
+            range = range.join(between) # then remove that too
+          end
+          range
+        end
+
+        def check(send_node)
+          if separated_style?
+            check_separated_style(send_node)
+          else
+            check_grouped_style(send_node)
+          end
+        end
+
+        def check_grouped_style(send_node)
+          return if sibling_mixins(send_node).size == 1
+
+          add_offense(send_node)
+        end
+
+        def check_separated_style(send_node)
+          return if send_node.arguments.one?
+
+          add_offense(send_node)
+        end
+
+        def sibling_mixins(send_node)
+          siblings = send_node.parent.each_child_node(:send)
+                              .select(&:macro?)
+
+          siblings.select do |sibling_node|
+            sibling_node.method_name == send_node.method_name
+          end
+        end
+
+        def message(send_node)
+          suffix =
+            separated_style? ? 'separate statements' : 'a single statement'
+
+          format(MSG, mixin: send_node.method_name, suffix: suffix)
+        end
+
+        def grouped_style?
+          style == :grouped
+        end
+
+        def separated_style?
+          style == :separated
+        end
+
+        def separate_mixins(node)
+          arguments = node.arguments.reverse
+          mixins = ["#{node.method_name} #{arguments.first.source}"]
+
+          arguments[1..-1].inject(mixins) do |replacement, arg|
+            replacement << "#{indent(node)}#{node.method_name} #{arg.source}"
+          end.join("\n")
+        end
+
+        def group_mixins(node, mixins)
+          mixin_names = mixins.reverse.flat_map do |mixin|
+            mixin.arguments.map(&:source)
+          end
+
+          "#{node.method_name} #{mixin_names.join(', ')}"
+        end
+
+        def indent(node)
+          ' ' * node.loc.column
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/style/mixin_usage.rb

@@ -0,0 +1,90 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Style
+      # This cop checks that `include`, `extend` and `prepend` statements appear
+      # inside classes and modules, not at the top level, so as to not affect
+      # the behavior of `Object`.
+      #
+      # @example
+      #   # bad
+      #   include M
+      #
+      #   class C
+      #   end
+      #
+      #   # bad
+      #   extend M
+      #
+      #   class C
+      #   end
+      #
+      #   # bad
+      #   prepend M
+      #
+      #   class C
+      #   end
+      #
+      #   # good
+      #   class C
+      #     include M
+      #   end
+      #
+      #   # good
+      #   class C
+      #     extend M
+      #   end
+      #
+      #   # good
+      #   class C
+      #     prepend M
+      #   end
+      class MixinUsage < Cop
+        MSG = '`%<statement>s` is used at the top level. Use inside `class` ' \
+              'or `module`.'
+
+        def_node_matcher :include_statement, <<~PATTERN
+          (send nil? ${:include :extend :prepend}
+            const)
+        PATTERN
+
+        def_node_matcher :wrapped_macro_scope?, <<~PATTERN
+          {({sclass class module block} ... ({begin if} ...))}
+        PATTERN
+
+        def on_send(node)
+          include_statement(node) do |statement|
+            return if node.argument? ||
+                      accepted_include?(node) ||
+                      belongs_to_class_or_module?(node)
+
+            add_offense(node, message: format(MSG, statement: statement))
+          end
+        end
+
+        private
+
+        def accepted_include?(node)
+          node.parent && (node.macro? || ascend_macro_scope?(node.parent))
+        end
+
+        def ascend_macro_scope?(ancestor)
+          return true if wrapped_macro_scope?(ancestor)
+
+          ancestor.parent && ascend_macro_scope?(ancestor.parent)
+        end
+
+        def belongs_to_class_or_module?(node)
+          if !node.parent
+            false
+          else
+            return true if node.parent.class_type? || node.parent.module_type?
+
+            belongs_to_class_or_module?(node.parent)
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/style/module_function.rb

@@ -0,0 +1,104 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Style
+      # This cop checks for use of `extend self` or `module_function` in a
+      # module.
+      #
+      # Supported styles are: module_function, extend_self.
+      #
+      # @example EnforcedStyle: module_function (default)
+      #   # bad
+      #   module Test
+      #     extend self
+      #     # ...
+      #   end
+      #
+      #   # good
+      #   module Test
+      #     module_function
+      #     # ...
+      #   end
+      #
+      # In case there are private methods, the cop won't be activated.
+      # Otherwise, it forces to change the flow of the default code.
+      #
+      # @example EnforcedStyle: module_function (default)
+      #   # good
+      #   module Test
+      #     extend self
+      #     # ...
+      #     private
+      #     # ...
+      #   end
+      #
+      # @example EnforcedStyle: extend_self
+      #   # bad
+      #   module Test
+      #     module_function
+      #     # ...
+      #   end
+      #
+      #   # good
+      #   module Test
+      #     extend self
+      #     # ...
+      #   end
+      #
+      # These offenses are not safe to auto-correct since there are different
+      # implications to each approach.
+      class ModuleFunction < Cop
+        include ConfigurableEnforcedStyle
+
+        MODULE_FUNCTION_MSG =
+          'Use `module_function` instead of `extend self`.'
+        EXTEND_SELF_MSG =
+          'Use `extend self` instead of `module_function`.'
+
+        def_node_matcher :module_function_node?, '(send nil? :module_function)'
+        def_node_matcher :extend_self_node?, '(send nil? :extend self)'
+        def_node_matcher :private_directive?, '(send nil? :private ...)'
+
+        def on_module(node)
+          return unless node.body&.begin_type?
+
+          each_wrong_style(node.body.children) do |child_node|
+            add_offense(child_node)
+          end
+        end
+
+        def autocorrect(node)
+          lambda do |corrector|
+            if extend_self_node?(node)
+              corrector.replace(node.source_range, 'module_function')
+            else
+              corrector.replace(node.source_range, 'extend self')
+            end
+          end
+        end
+
+        private
+
+        def each_wrong_style(nodes)
+          case style
+          when :module_function
+            private_directive = nodes.any? { |node| private_directive?(node) }
+
+            nodes.each do |node|
+              yield node if extend_self_node?(node) && !private_directive
+            end
+          when :extend_self
+            nodes.each do |node|
+              yield node if module_function_node?(node)
+            end
+          end
+        end
+
+        def message(_node)
+          style == :module_function ? MODULE_FUNCTION_MSG : EXTEND_SELF_MSG
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/style/multiline_block_chain.rb

@@ -0,0 +1,40 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Style
+      # This cop checks for chaining of a block after another block that spans
+      # multiple lines.
+      #
+      # @example
+      #
+      #   Thread.list.find_all do |t|
+      #     t.alive?
+      #   end.map do |t|
+      #     t.object_id
+      #   end
+      class MultilineBlockChain < Cop
+        include RangeHelp
+
+        MSG = 'Avoid multi-line chains of blocks.'
+
+        def on_block(node)
+          node.send_node.each_node(:send) do |send_node|
+            receiver = send_node.receiver
+
+            next unless receiver&.block_type? && receiver&.multiline?
+
+            range = range_between(receiver.loc.end.begin_pos,
+                                  node.send_node.source_range.end_pos)
+
+            add_offense(nil, location: range)
+
+            # Done. If there are more blocks in the chain, they will be
+            # found by subsequent calls to on_block.
+            break
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/style/multiline_if_modifier.rb

@@ -0,0 +1,67 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Style
+      # Checks for uses of if/unless modifiers with multiple-lines bodies.
+      #
+      # @example
+      #
+      #   # bad
+      #   {
+      #     result: 'this should not happen'
+      #   } unless cond
+      #
+      #   # good
+      #   { result: 'ok' } if cond
+      class MultilineIfModifier < Cop
+        include StatementModifier
+        include Alignment
+
+        MSG = 'Favor a normal %<keyword>s-statement over a modifier' \
+              ' clause in a multiline statement.'
+
+        def on_if(node)
+          return unless node.modifier_form? && node.body.multiline?
+
+          add_offense(node)
+        end
+
+        def autocorrect(node)
+          lambda do |corrector|
+            corrector.replace(node.source_range, to_normal_if(node))
+          end
+        end
+
+        private
+
+        def message(node)
+          format(MSG, keyword: node.keyword)
+        end
+
+        def to_normal_if(node)
+          indented_body = indented_body(node.body, node)
+          condition = "#{node.keyword} #{node.condition.source}"
+          indented_end = "#{offset(node)}end"
+
+          [condition, indented_body, indented_end].join("\n")
+        end
+
+        def configured_indentation_width
+          super || 2
+        end
+
+        def indented_body(body, node)
+          body_source = "#{offset(node)}#{body.source}"
+          body_source.each_line.map do |line|
+            if line == "\n"
+              line
+            else
+              line.sub(/^\s{#{offset(node).length}}/, indentation(node))
+            end
+          end.join
+        end
+      end
+    end
+  end
+end