rubocop-yast 0.0.5 → 0.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8f14f2792588ff28f55867a356603deeeafe6deb
-  data.tar.gz: 03433493409f9d50a333391b4e05c8782a525064
+  metadata.gz: c59e960c99f00013d3881020fe1d576e9d67ab91
+  data.tar.gz: 89d463fb18eb4d31ad00df25be33621cd4309446
 SHA512:
-  metadata.gz: 3fed38028da0bd94e103e5a5091e1723857c3c5b1995216fa175f8dc6fadaefc81f77f6182abf80a6cbe7c5e7b41fda716f44150ce6a4dc3aa2a599b7cec01f6
-  data.tar.gz: 32e08248270ec322da28aabf4ff9fa27fc8be17729b3b64d92336106e92cf946a65d3462c4634cca7467ace025eba6ffe41b593aff467af02d09f38c16bd3d8c
+  metadata.gz: f6f08655ccfef688328df7f9f245df9c963ed4a55c963ae81b40395e71befa4fca00f50c8fba339f80223689863a24d51c49ff41e923d166880555d2efb02087
+  data.tar.gz: ea903ebf6261f79f6a7e7b3646648d198ae0432b3da2e301dbc2b29a1d07e23a7c8b9ddcf849f4d3c46b221b6d0ff11ef97879952bedbde3c66e8bc4d2fb834e

data/CHANGELOG.md

@@ -0,0 +1,19 @@
+# Change Log
+
+## master (unreleased)
+
+## 0.0.6 (15/12/2014)
+
+### New Features
+
+- added `LogVariable` Cop (check for `log` variable assignment)
+
+### Changes
+
+- converted MarkDown test descriptions to Cucumber (removed our specific
+  Markdown -> RSpec renderer)
+
+### Fixed Bugs
+
+- `Ops` Cop - fixed crash when using `--auto-gen-config` option
+- `Builtins` Cop - fixed crash when parenthesis were missing aroung method argument

data/README.md

@@ -2,11 +2,11 @@ rubocop-yast
 ============
 
 [![Gem Version](https://badge.fury.io/rb/rubocop-yast.svg)](http://badge.fury.io/rb/rubocop-yast)
-[![Dependency Status](https://gemnasium.com/lslezak/rubocop-yast.svg)](https://gemnasium.com/lslezak/rubocop-yast)
-[![Travis Build](https://travis-ci.org/lslezak/rubocop-yast.svg?branch=master)](https://travis-ci.org/lslezak/rubocop-yast)
-[![Coverage Status](https://img.shields.io/coveralls/lslezak/rubocop-yast.svg)](https://coveralls.io/r/lslezak/rubocop-yast?branch=master)
-[![Code Climate](https://codeclimate.com/github/lslezak/rubocop-yast/badges/gpa.svg)](https://codeclimate.com/github/lslezak/rubocop-yast)
-[![Inline docs](http://inch-ci.org/github/lslezak/rubocop-yast.svg?branch=master)](http://inch-ci.org/github/lslezak/rubocop-yast)
+[![Dependency Status](https://gemnasium.com/yast/rubocop-yast.svg)](https://gemnasium.com/yast/rubocop-yast)
+[![Travis Build](https://travis-ci.org/yast/rubocop-yast.svg?branch=master)](https://travis-ci.org/yast/rubocop-yast)
+[![Coverage Status](https://img.shields.io/coveralls/yast/rubocop-yast.svg)](https://coveralls.io/r/yast/rubocop-yast?branch=master)
+[![Code Climate](https://codeclimate.com/github/yast/rubocop-yast/badges/gpa.svg)](https://codeclimate.com/github/yast/rubocop-yast)
+[![Inline docs](http://inch-ci.org/github/yast/rubocop-yast.svg?branch=master)](http://inch-ci.org/github/yast/rubocop-yast)
 
 
 This is a plugin for [RuboCop](https://github.com/bbatsov/rubocop)
@@ -18,8 +18,8 @@ The goal is to create a Rubocop plugin which can check for
 covert some ugly code parts introduced by the automatic code conversion done by
 [YCP Killer](https://github.com/yast/ycp-killer) (conversion from YCP to Ruby).
 
-Check [the test descriptions](spec/builtins_spec.md) to see the examples of offense
-detection and code conversion.
+Check [the RSpec tests](spec) and [the Cucumber features](features)to see
+the examples of offense detection and code conversion.
 
 *The plugin is currently in early development, always manually check the chages
 done by the plugin! It can eat your code... ;-)*
@@ -35,6 +35,9 @@ you can install it using the `gem` command:
 sudo gem install rubocop-yast
 ```
 
+You can also install the latest development version directly from the Git repository,
+see [Building a Gem](#building-a-gem) section below.
+
 Usage
 -----
 
@@ -73,8 +76,9 @@ Development
 
 ### Prerequisites
 
-For development you need some extra development gems. The best way is to install them with [Bundler](http://bundler.io/). To avoid a possible collision with system gems it is recommended
-to install the gems into a local subdirectory using
+For development you need some extra development gems. The best way is to install them with [Bundler](http://bundler.io/). To avoid a possible collision with system gems (esp. RSpec,
+Yast still uses version 2.14 while rubocop-yast uses 3.1) it is recommended
+to install the gems into a local subdirectory using:
 
 ```shell
 bundle install --path vendor/bundle
@@ -131,3 +135,4 @@ and then run:
 bundle exec rake release
 ```
 
+(Note: You need push permissions at [rubygems.org](https://rubygems.org/gems/rubocop-yast).)

data/Rakefile

@@ -10,34 +10,13 @@ rescue Bundler::BundlerError => e
   exit e.status_code
 end
 
-require "redcarpet"
-require_relative "spec/rspec_renderer"
-
-def render_markdown(renderer_class, task)
-  puts "Rendering file: #{task.name}"
-  markdown = Redcarpet::Markdown.new(renderer_class, fenced_code_blocks: true)
-
-  string = markdown.render(File.read(task.prerequisites[0]))
-  File.write(task.name, string)
-end
-
-renderer = "spec/rspec_renderer.rb"
-
-file "spec/builtins_spec.rb" => ["spec/builtins_spec.md", renderer] do |t|
-  render_markdown(RSpecRenderer, t)
-end
-
-file "spec/builtins_spec.html" => ["spec/builtins_spec.md", renderer] do |t|
-  render_markdown(Redcarpet::Render::HTML, t)
-end
-desc "Render the specification to HTML locally"
-task html: ["spec/builtins_spec.html"]
+require "cucumber/rake/task"
+Cucumber::Rake::Task.new(:features)
 
 require "rspec/core/rake_task"
 RSpec::Core::RakeTask.new(:spec)
-task spec: ["spec/builtins_spec.rb"]
 
 require "rubocop/rake_task"
 RuboCop::RakeTask.new(:rubocop)
 
-task default: [:spec, :rubocop]
+task default: [:spec, :features, :rubocop]

data/config/default.yml

@@ -6,3 +6,7 @@ Yast/Ops:
   Description: "Check for obsolete Ops.* calls"
   Enabled: true
   SafeMode: true
+
+Yast/LogVariable:
+  Description: "Check for using 'log' variable"
+  Enabled: true

data/lib/rubocop-yast.rb

@@ -8,3 +8,4 @@ RuboCop::Yast::Config.load_defaults
 require_relative "rubocop/yast/version"
 require_relative "rubocop/cop/yast/builtins"
 require_relative "rubocop/cop/yast/ops"
+require_relative "rubocop/cop/yast/log_variable"

data/lib/rubocop/cop/yast/log_variable.rb

@@ -0,0 +1,23 @@
+# encoding: utf-8
+
+require "rubocop/cop/cop"
+
+module RuboCop
+  module Cop
+    module Yast
+      # This cop checks for using log variable
+      # code like:
+      #   log = "msg"
+      # can override the included logger
+      class LogVariable < Cop
+        MSG = "Do not use `log` variable, it can conflict with the logger."
+
+        def on_lvasgn(node)
+          name, _value = *node
+
+          add_offense(node, :name, MSG) if name == :log
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/yast/ops.rb

@@ -25,7 +25,7 @@ module RuboCop
         def initialize(config = nil, options = nil)
           super(config, options)
 
-          @safe_mode = cop_config["SafeMode"]
+          @safe_mode = cop_config && cop_config["SafeMode"]
           @replaced_nodes = []
         end
 

data/lib/rubocop/yast/builtins/y2log.rb

@@ -88,6 +88,7 @@ module RuboCop
         # Add Yast::Logger include somewhere up in the tree
         def add_missing_logger(node, corrector)
           target_node = parent_node_type(node, [:class, :module])
+          target_node = target_node.children.first if target_node.begin_type?
 
           # already added or already present
           return if added_includes.include?(target_node) ||

data/lib/rubocop/yast/version.rb

@@ -3,6 +3,6 @@
 module RuboCop
   # Yast plugin settings
   module Yast
-    VERSION = "0.0.5"
+    VERSION = "0.0.6"
   end
 end

data/rubocop-yast.gemspec

@@ -31,7 +31,7 @@ Gem::Specification.new do |spec|
   spec.add_runtime_dependency("rubocop", "~> 0.27")
 
   spec.add_development_dependency("rake")
-  spec.add_development_dependency("redcarpet", "~> 3")
   spec.add_development_dependency("rspec", "~> 3.1.0")
+  spec.add_development_dependency("cucumber")
   spec.add_development_dependency("simplecov")
 end

data/spec/builtins_spec.rb

@@ -2,7 +2,7 @@
 
 require "spec_helper"
 
-describe "RuboCop-Yast" do
+describe "RuboCop::Cop::Yast::Builtins" do
   describe "Generic Tests:" do
     it "It reports y2milestone builtin as offense" do
       code = code_cleanup(<<-EOT)
@@ -13,7 +13,6 @@ describe "RuboCop-Yast" do
       inspect_source(cop, [code])
 
       expect(cop.offenses.size).to eq(1)
-      expect(cop.messages.first).to match(/Builtin call `.*` is obsolete/)
     end
 
     it "It finds builtin in explicit Yast namespace" do
@@ -25,7 +24,6 @@ describe "RuboCop-Yast" do
       inspect_source(cop, [code])
 
       expect(cop.offenses.size).to eq(1)
-      expect(cop.messages.first).to match(/Builtin call `.*` is obsolete/)
     end
 
     it "It finds builtin in explicit ::Yast namespace" do
@@ -37,7 +35,6 @@ describe "RuboCop-Yast" do
       inspect_source(cop, [code])
 
       expect(cop.offenses.size).to eq(1)
-      expect(cop.messages.first).to match(/Builtin call `.*` is obsolete/)
     end
 
     it "Builtins in the ::Builtins name space are ignored" do
@@ -89,21 +86,6 @@ describe "RuboCop-Yast" do
     end
   end
 
-  describe "Builtins.time():" do
-    it "Is trivially converted to `::Time.now.to_i`" do
-      original_code = code_cleanup(<<-EOT)
-        Builtins.time()
-      EOT
-
-      translated_code = code_cleanup(<<-EOT)
-        ::Time.now.to_i
-      EOT
-
-      cop = RuboCop::Cop::Yast::Builtins.new
-      expect(autocorrect_source(cop, original_code)).to eq(translated_code)
-    end
-  end
-
   describe "Builtins.getenv():" do
     it "With string literal parameter is translated to ENV equivalent" do
       original_code = code_cleanup(<<-EOT)
@@ -147,7 +129,7 @@ describe "RuboCop-Yast" do
     end
   end
 
-  describe "Logging:" do
+  describe "Logging - Builtins.y2debug(), ...:" do
     it "It translates `y2debug` to `log.debug`" do
       original_code = code_cleanup(<<-EOT)
         Builtins.y2debug("foo")
@@ -563,5 +545,16 @@ describe "RuboCop-Yast" do
       cop = RuboCop::Cop::Yast::Builtins.new
       expect(autocorrect_source(cop, original_code)).to eq(translated_code)
     end
+
+    it "It finds an offense with missing parenthesis around argument" do
+      code = code_cleanup(<<-EOT)
+        Builtins.y2milestone "Executing hook '\#{name}'"
+      EOT
+
+      cop = RuboCop::Cop::Yast::Builtins.new
+      inspect_source(cop, [code])
+
+      expect(cop.offenses.size).to eq(1)
+    end
   end
 end

data/spec/ops_spec.rb

@@ -95,7 +95,6 @@ describe RuboCop::Cop::Yast::Ops do
       new_source = autocorrect_source(cop, source)
       expect(new_source).to eq(source)
     end
-
   end
 
   context("In unsafe mode") do
@@ -117,5 +116,4 @@ describe RuboCop::Cop::Yast::Ops do
       expect(new_source).to eq("foo + bar")
     end
   end
-
 end

data/spec/spec_helper.rb

@@ -2,18 +2,6 @@
 
 require "simplecov"
 
-# use coveralls for on-line code coverage reporting at Travis CI
-if ENV["TRAVIS"]
-  require "coveralls"
-
-  SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[
-    SimpleCov::Formatter::HTMLFormatter,
-    Coveralls::SimpleCov::Formatter
-  ]
-end
-
-SimpleCov.minimum_coverage 95
-
 SimpleCov.start do
   # don't check code coverage in these subdirectories
   add_filter "/vendor/"
@@ -38,10 +26,4 @@ require File.join(
 
 $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), "..", "lib"))
 
-def code_cleanup(s)
-  s.split("\n").reject { |l| l =~ /^\s*$/ }.first =~ /^(\s*)/
-  return s.dup if Regexp.last_match.nil?
-  s.gsub(Regexp.new("^#{Regexp.last_match[1]}"), "")[0..-2]
-end
-
 require "rubocop-yast"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-yast
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.6
 platform: ruby
 authors:
 - Ladislav Slezák
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-12-09 00:00:00.000000000 Z
+date: 2014-12-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -39,33 +39,33 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: redcarpet
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3'
+        version: 3.1.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3'
+        version: 3.1.0
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: cucumber
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 3.1.0
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 3.1.0
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
@@ -91,6 +91,7 @@ extra_rdoc_files:
 - LICENSE
 - README.md
 files:
+- CHANGELOG.md
 - Gemfile
 - LICENSE
 - README.md
@@ -98,6 +99,7 @@ files:
 - config/default.yml
 - lib/rubocop-yast.rb
 - lib/rubocop/cop/yast/builtins.rb
+- lib/rubocop/cop/yast/log_variable.rb
 - lib/rubocop/cop/yast/ops.rb
 - lib/rubocop/yast/builtins/builtin.rb
 - lib/rubocop/yast/builtins/getenv.rb
@@ -111,11 +113,8 @@ files:
 - lib/rubocop/yast/variable_scope.rb
 - lib/rubocop/yast/version.rb
 - rubocop-yast.gemspec
-- spec/builtins_spec.md
 - spec/builtins_spec.rb
 - spec/ops_spec.rb
-- spec/rspec_code.rb
-- spec/rspec_renderer.rb
 - spec/spec_helper.rb
 homepage: http://github.com/yast/rubocop-yast
 licenses:
@@ -142,9 +141,6 @@ signing_key:
 specification_version: 4
 summary: Specific YaST Rubocop checks
 test_files:
-- spec/builtins_spec.md
 - spec/builtins_spec.rb
 - spec/ops_spec.rb
-- spec/rspec_code.rb
-- spec/rspec_renderer.rb
 - spec/spec_helper.rb

data/spec/builtins_spec.md

@@ -1,614 +0,0 @@
-Builtins Cop
-============
-
-Table Of Contents
------------------
-
-1. Description
-1. Builtins.time()
-1. Builtins.getenv()
-1. Logging
-
-Description
------------
-
-This Cop is designed to check for `Builtins` call presence. These calls were
-added by YCP Killer to ensure 100% compatibily of the translated Ruby code
-with the old YCP.
-
-But these calls should not be used in the new code, native Ruby methods should
-be used instead of these wrappers.
-
-The Cop can autocorrect some trivial or easy translatable builtins.
-
-Generic Tests
--------------
-
-It reports y2milestone builtin as offense
-
-**Offense**
-
-```ruby
-Builtins.y2milestone("foo")
-```
-
-It finds builtin in explicit Yast namespace
-
-**Offense**
-
-```ruby
-Yast::Builtins.y2milestone("foo")
-```
-
-It finds builtin in explicit ::Yast namespace
-
-**Offense**
-
-```ruby
-::Yast::Builtins.y2milestone("foo")
-```
-
-Builtins in the ::Builtins name space are ignored
-
-**Accepted**
-
-```ruby
-::Builtins.y2milestone("foo")
-```
-
-Builtins in non Yast name space are ignored
-
-**Accepted**
-
-```ruby
-Foo::Builtins.y2milestone("foo")
-```
-
-lsort(), crypt and gettext builtins are allowed
-
-**Accepted**
-
-```ruby
-Builtins.lsort(["foo"])
-Builtins.crypt("foo")
-Builtins.dgettext("domain", "foo")
-```
-
-It does not change unknown builtins
-
-**Unchanged**
-
-```ruby
-Builtins.foo()
-```
-
-
-Builtins.time()
----------------
-
-Is trivially converted to `::Time.now.to_i`
-
-**Original**
-
-```ruby
-Builtins.time()
-```
-
-**Translated**
-
-```ruby
-::Time.now.to_i
-```
-
-Builtins.getenv()
------------------
-
-With string literal parameter is translated to ENV equivalent
-
-**Original**
-
-```ruby
-Builtins.getenv("foo")
-```
-
-**Translated**
-
-```ruby
-ENV["foo"]
-```
-
-Variable as parameter is preserved.
-
-**Original**
-
-```ruby
-foo = bar
-Builtins.getenv(foo)
-```
-
-**Translated**
-
-```ruby
-foo = bar
-ENV[foo]
-```
-
-Any other statement is preserved.
-
-**Original**
-
-```ruby
-Builtins.getenv(Ops.add(foo, bar))
-```
-
-**Translated**
-
-```ruby
-ENV[Ops.add(foo, bar)]
-```
-
-Logging
---------
-
-It translates `y2debug` to `log.debug`
-
-**Original**
-
-```ruby
-Builtins.y2debug("foo")
-```
-
-**Translated**
-
-```ruby
-include Yast::Logger
-log.debug "foo"
-```
-
-It translates `y2milestone` to `log.info`
-
-**Original**
-
-```ruby
-Builtins.y2milestone("foo")
-```
-
-**Translated**
-
-```ruby
-include Yast::Logger
-log.info "foo"
-```
-
-It translates `y2warning` to `log.warn`
-
-**Original**
-
-```ruby
-Builtins.y2warning("foo")
-```
-
-**Translated**
-
-```ruby
-include Yast::Logger
-log.warn "foo"
-```
-
-It translates `y2error` to `log.error`
-
-**Original**
-
-```ruby
-Builtins.y2error("foo")
-```
-
-**Translated**
-
-```ruby
-include Yast::Logger
-log.error "foo"
-```
-
-It translates `y2security` to `log.error`
-
-**Original**
-
-```ruby
-Builtins.y2security("foo")
-```
-
-**Translated**
-
-```ruby
-include Yast::Logger
-log.error "foo"
-```
-
-It translates `y2internal` to `log.fatal`
-
-**Original**
-
-```ruby
-Builtins.y2internal("foo")
-```
-
-**Translated**
-
-```ruby
-include Yast::Logger
-log.fatal "foo"
-```
-
-It adds the include statement only once
-
-**Original**
-
-```ruby
-Builtins.y2milestone("foo")
-Builtins.y2milestone("foo")
-```
-
-**Translated**
-
-```ruby
-include Yast::Logger
-log.info \"foo\"
-log.info \"foo\"
-```
-
-It converts YCP sformat to Ruby interpolation
-
-**Original**
-
-```ruby
-Builtins.y2milestone("foo: %1", foo)
-```
-
-**Translated**
-
-```ruby
-include Yast::Logger
-log.info "foo: #{foo}"
-```
-
-It converts %% in the format string to simple %.
-
-**Original**
-
-```ruby
-Builtins.y2milestone("foo: %1%%", foo)
-```
-
-**Translated**
-
-```ruby
-include Yast::Logger
-log.info "foo: #{foo}%"
-```
-
-It replaces repeated % placeholders in the format string
-
-**Original**
-
-```ruby
-Builtins.y2warning("%1 %1", foo)
-```
-
-**Translated**
-
-```ruby
-include Yast::Logger
-log.warn "#{foo} #{foo}"
-```
-
-The % placeholders do not need to start from 1
-
-**Original**
-
-```ruby
-Builtins.y2warning("%2 %2", foo, bar)
-```
-
-**Translated**
-
-```ruby
-include Yast::Logger
-log.warn "#{bar} #{bar}"
-```
-
-The % placeholders do not need to be in ascending order
-
-**Original**
-
-```ruby
-Builtins.y2warning("%2 %1", foo, bar)
-```
-
-**Translated**
-
-```ruby
-include Yast::Logger
-log.warn "#{bar} #{foo}"
-```
-
-It keeps the original statements in interpolated string
-
-**Original**
-
-```ruby
-Builtins.y2warning("%1", foo + bar)
-```
-
-**Translated**
-
-```ruby
-include Yast::Logger
-log.warn "#{foo + bar}"
-```
-
-It converts a log with string interpolation
-
-**Original**
-
-```ruby
-Builtins.y2warning("foo: #{foo}")
-```
-
-**Translated**
-
-```ruby
-include Yast::Logger
-log.warn "foo: #{foo}"
-```
-
-It converts a log with a message variable
-
-**Original**
-
-```ruby
-msg = "message"
-Builtins.y2warning(msg)
-```
-
-**Translated**
-
-```ruby
-include Yast::Logger
-msg = "message"
-log.warn msg
-```
-
-It converts a log with function call
-
-**Original**
-
-```ruby
-Builtins.y2warning(msg)
-```
-
-**Translated**
-
-```ruby
-include Yast::Logger
-log.warn msg
-```
-
-It doesn't convert a log with extra parameters
-
-**Unchanged**
-
-```ruby
-Builtins.y2warning(msg, arg1, arg2)
-```
-
-It converts log with operator call
-
-**Original**
-
-```ruby
-Builtins.y2warning(msg1 + msg2)
-```
-
-**Translated**
-
-```ruby
-include Yast::Logger
-log.warn msg1 + msg2
-```
-
-It adds logger include to the class definition
-
-**Original**
-
-```ruby
-class Foo
-  Builtins.y2error('foo')
-end
-```
-
-**Translated**
-
-```ruby
-class Foo
-  include Yast::Logger
-
-  log.error "foo"
-end
-```
-
-It adds logger include with correct indentation
-
-**Original**
-
-```ruby
-  class Foo
-    Builtins.y2error('foo')
-  end
-```
-
-**Translated**
-
-```ruby
-  class Foo
-    include Yast::Logger
-
-    log.error "foo"
-  end
-```
-
-It does not add the logger include if already present
-
-**Original**
-
-```ruby
-class Foo
-  include Yast::Logger
-  Builtins.y2error('foo')
-end
-```
-
-**Translated**
-
-```ruby
-class Foo
-  include Yast::Logger
-  log.error "foo"
-end
-```
-
-It adds the logger include after the parent class name if present
-
-**Original**
-
-```ruby
-class Foo < Bar
-  Builtins.y2error('foo')
-end
-```
-
-**Translated**
-
-```ruby
-class Foo < Bar
-  include Yast::Logger
-
-  log.error "foo"
-end
-```
-
-It adds logger include once to a derived class in a module
-
-**Original**
-
-```ruby
-module Yast
-  class TestClass < Module
-    def test
-      Builtins.y2error("foo")
-      Builtins.y2debug("foo")
-    end
-  end
-end
-```
-
-**Translated**
-
-```ruby
-module Yast
-  class TestClass < Module
-    include Yast::Logger
-
-    def test
-      log.error "foo"
-      log.debug "foo"
-    end
-  end
-end
-```
-
-It converts the single quoted format string to double quoted
-
-**Original**
-
-```ruby
-Builtins.y2milestone('foo: %1', foo)
-```
-
-**Translated**
-
-```ruby
-include Yast::Logger
-log.info "foo: #{foo}"
-```
-
-It escapes double quotes and interpolations
-
-**Original**
-
-```ruby
-Builtins.y2milestone('"#{foo}"')
-```
-
-**Translated**
-
-```ruby
-include Yast::Logger
-log.info "\\"\\#{foo}\\""
-```
-
-It does not convert logging with backtrace
-
-**Unchanged**
-
-```ruby
-Builtins.y2milestone(-1, "foo")
-```
-
-It does not convert code with a local variable 'log'
-
-**Unchanged**
-
-```ruby
-log = 1
-Builtins.y2milestone("foo")
-```
-
-<!--
-
-Template
---------
-
-It finds an offense
-
-**Offense**
-
-```ruby
-```
-
-This code is OK
-
-**Accepted**
-
-```ruby
-```
-
-It translates.
-
-**Original**
-
-```ruby
-```
-
-**Translated**
-
-```ruby
-```
-
-It does not translate.
-
-**Unchanged**
-
-```ruby
-```
--->

data/spec/rspec_code.rb

@@ -1,47 +0,0 @@
-
-# this module provides code block generators for RSpecRenderer
-module RspecCode
-  # rubocop:disable Metrics/MethodLength
-  def generate_translation_code
-    [
-      "original_code = code_cleanup(<<-EOT)",
-      Code.indent(@original_code),
-      "EOT",
-      "",
-      "translated_code = code_cleanup(<<-EOT)",
-      Code.indent(@translated_code),
-      "EOT",
-      "",
-      "cop = RuboCop::Cop::Yast::Builtins.new",
-      "expect(autocorrect_source(cop, original_code)).to eq(translated_code)"
-    ].join("\n")
-  end
-
-  def generate_offense_code
-    [
-      "code = code_cleanup(<<-EOT)",
-      Code.indent(@offense),
-      "EOT",
-      "",
-      "cop = RuboCop::Cop::Yast::Builtins.new",
-      "inspect_source(cop, [code])",
-      "",
-      "expect(cop.offenses.size).to eq(1)",
-      "expect(cop.messages.first).to match(/Builtin call `.*` is obsolete/)"
-    ].join("\n")
-  end
-
-  def generate_accepted_code
-    [
-      "code = code_cleanup(<<-EOT)",
-      Code.indent(@accepted_code),
-      "EOT",
-      "",
-      "cop = RuboCop::Cop::Yast::Builtins.new",
-      "inspect_source(cop, [code])",
-      "",
-      "expect(cop.offenses).to be_empty"
-    ].join("\n")
-  end
-  # rubocop:enable Metrics/MethodLength
-end

data/spec/rspec_renderer.rb

@@ -1,206 +0,0 @@
-require "redcarpet"
-
-require_relative "rspec_code"
-
-# Utility functions for manipulating code.
-module Code
-  INDENT_STEP = 2
-
-  class << self
-    def join(lines)
-      lines.map { |l| "#{l}\n" }.join("")
-    end
-
-    def indent(s)
-      s.gsub(/^(?=.)/, " " * INDENT_STEP)
-    end
-  end
-end
-
-# Represents RSpec's "it" block.
-class It
-  def initialize(attrs)
-    @description = attrs[:description]
-    @code        = attrs[:code]
-    @skip        = attrs[:skip]
-  end
-
-  def render
-    [
-      "#{@skip ? "xit" : "it"} #{@description.inspect} do",
-      Code.indent(@code),
-      "end"
-    ].join("\n")
-  end
-end
-
-# Represents RSpec's "describe" block.
-class Describe
-  attr_reader :blocks
-
-  def initialize(attrs)
-    @description = attrs[:description]
-    @blocks      = attrs[:blocks]
-  end
-
-  def render
-    parts = []
-    parts << "describe #{@description.inspect} do"
-    parts << Code.indent(@blocks.map(&:render).join("\n\n")) if !blocks.empty?
-    parts << "end"
-    parts.join("\n")
-  end
-end
-
-# Renders a Markdown file to an RSpec test script
-class RSpecRenderer < Redcarpet::Render::Base
-  include RspecCode
-
-  IGNORED_HEADERS = [
-    "Table Of Contents",
-    "Description"
-  ]
-
-  def initialize
-    super
-
-    @next_block_type = :unknown
-    @describe = Describe.new(description: "RuboCop-Yast", blocks: [])
-  end
-
-  # preprocess the MarkDown input - remove comments
-  def preprocess(fulldoc)
-    # use multiline regexp pattern
-    fulldoc.gsub(/<!--.*-->/m, "")
-  end
-
-  def header(text, header_level)
-    return nil if header_level == 1 || IGNORED_HEADERS.include?(text)
-
-    if header_level > describes_depth + 1
-      raise "Missing higher level header: #{text}"
-    end
-
-    describe_at_level(header_level - 1).blocks << Describe.new(
-      description: text + ":",
-      blocks:      []
-    )
-
-    nil
-  end
-
-  def paragraph(text)
-    if text =~ /^\*\*(.*)\*\*$/
-      @next_block_type = Regexp.last_match[1].downcase.to_sym
-    else
-      first_sentence = text.split(/\.(\s+|$)/).first
-      @description = first_sentence.sub(/^RuboCop-Yast /, "").sub(/\n/, " ")
-    end
-
-    nil
-  end
-
-  # rubocop:disable Metrics/MethodLength, Metrics/CyclomaticComplexity:
-  def block_code(code, _language)
-    escaped_code = escape(code[0..-2])
-
-    case @next_block_type
-    when :original
-      @original_code = escaped_code
-    when :translated
-      @translated_code = escaped_code
-    when :unchanged
-      @original_code = @translated_code = escaped_code
-    when :offense
-      @offense = escaped_code
-    when :accepted
-      @accepted_code = escaped_code
-    else
-      raise "Invalid next code block type: #{@next_block_type}.\n#{code}"
-    end
-
-    @next_block_type = :unknown
-
-    add_translation_block if @original_code && @translated_code
-    add_offense_block if @offense
-    add_accepted_block if @accepted_code
-
-    nil
-  end
-  # rubocop:enable Metrics/MethodLength, Metrics/CyclomaticComplexity:
-
-  # escape ruby interpolation
-  def escape(code)
-    code.gsub("\#{", "\\\#{")
-  end
-
-  def doc_header
-    Code.join([
-      "# Automatically generated -- DO NOT EDIT!",
-      "",
-      "require \"spec_helper\"",
-      ""
-    ])
-  end
-
-  def doc_footer
-    "#{@describe.render}\n"
-  end
-
-  private
-
-  def describes_depth
-    describe = @describe
-    depth = 1
-    while describe.blocks.last.is_a?(Describe)
-      describe = describe.blocks.last
-      depth += 1
-    end
-    depth
-  end
-
-  def current_describe
-    describe = @describe
-    describe = describe.blocks.last while describe.blocks.last.is_a?(Describe)
-    describe
-  end
-
-  def describe_at_level(level)
-    describe = @describe
-    2.upto(level) do
-      describe = describe.blocks.last
-    end
-    describe
-  end
-
-  def add_translation_block
-    current_describe.blocks << It.new(
-      description: @description,
-      code:        generate_translation_code,
-      skip:        @description =~ /XFAIL/
-    )
-
-    @original_code   = nil
-    @translated_code = nil
-  end
-
-  def add_offense_block
-    current_describe.blocks << It.new(
-      description: @description,
-      code:        generate_offense_code,
-      skip:        @description =~ /XFAIL/
-    )
-
-    @offense = nil
-  end
-
-  def add_accepted_block
-    current_describe.blocks << It.new(
-      description: @description,
-      code:        generate_accepted_code,
-      skip:        @description =~ /XFAIL/
-    )
-
-    @accepted_code = nil
-  end
-end