rubocop-view_component 0.6.0 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: be0a1c1c9a7489ed311953b5f67c7108dbca8b1f43debef36026ec011781a549
-  data.tar.gz: 0b62b04534ab81725ab96d28c0b1931671d92944277ac7b5217f4d36d9d91f9b
+  metadata.gz: fa0434208243f306c17f51b681abdf59f6152d6afdd0014c608c5b4e08e893c2
+  data.tar.gz: e709241be864e024f8ce410b6620d62bcdd12cd090e2593b378c0169a628f1e9
 SHA512:
-  metadata.gz: 7fc23bef50c35486b422362f9e738e5347b41eaeb8171f2dfca21884dbd87542f2db1e22618c1b239a1bfd2d878b448cb208539678c37b6e622086c1ee4d2871
-  data.tar.gz: f67e8fc0ec682da84318f7078bc5eaffd4a7e9907e9d4e281a224e240e57a13b4f4ec010ef31cce3f20528b4f6fc4ce5acf538385736a837095ef21a90fcf641
+  metadata.gz: 6d0a9815a58ab3326c9366e7abb2d85cd18e1c87216c731c2fccfeba3d70eae2188856b1c619ba9be2d37c776d463d00efe4f2b7d680998e6e7679b582ab22da
+  data.tar.gz: f195f94ca71e89a4f807a8074ddac30a65462faab27dc01b18f1f58f4a29d85df5699a4dcead7a670e7f311b3fe87816cd49ae98b3813540fa2e4c0707273fc8

data/.rubocop.yml

@@ -16,6 +16,7 @@ AllCops:
     - 'verification/**/*'
     - 'script/verify'
     - 'spec/fixtures/**/*'
+    - 'gemfiles/**/*'
 
 Metrics/BlockLength:
   Exclude:

data/Appraisals

@@ -0,0 +1,5 @@
+# frozen_string_literal: true
+
+appraise "rubocop-minimum" do
+  gem "rubocop", "= 1.89.0"
+end

data/CLAUDE.md

@@ -40,8 +40,10 @@ All cops inherit from `RuboCop::Cop::Base` and are located in `lib/rubocop/cop/v
 ### Shared Modules
 
 **`ViewComponent::Base`** (`lib/rubocop/cop/view_component/base.rb`)
-- Provides `view_component_class?(node)` - Detects ViewComponent classes
-- Provides `view_component_parent?(node)` - Checks if inheriting from ViewComponent::Base, ApplicationComponent, or configured parent classes
+- Includes `RuboCop::Cop::ProjectIndexHelp` for rubydex integration
+- Provides `view_component_class?(node)` - Detects ViewComponent classes via ancestry resolution
+- Provides `view_component_parent?(node)` - Checks if inheriting from ViewComponent::Base
+- Provides `view_component_parent_class?(node)` - Checks if a class is an abstract parent (has descendants)
 - Provides `inside_view_component?(node)` - Checks if code is within a ViewComponent
 
 **`TemplateAnalyzer`** (`lib/rubocop/cop/view_component/template_analyzer.rb`)
@@ -50,16 +52,6 @@ All cops inherit from `RuboCop::Cop::Base` and are located in `lib/rubocop/cop/v
 - Handles both sibling templates (`component.html.erb`) and sidecar templates (`component/component.html.erb`)
 - Uses the `herb` gem to parse ERB and extract Ruby code
 
-### Configuration
-
-The `ViewComponent` config supports `ViewComponentParentClasses` to configure additional base classes beyond `ViewComponent::Base` and `ApplicationComponent`:
-
-```yaml
-ViewComponent:
-  ViewComponentParentClasses:
-    - MyApp::BaseComponent
-```
-
 ### Verification System
 
 The `script/verify` script downloads real component libraries, runs all ViewComponent cops, and compares results to checked-in snapshots. This catches regressions when cop behavior changes. Libraries are configured in `verification/libraries.yml`, downloaded to `verification/LIBRARY/`, and expected results stored in `spec/expected_LIBRARY_failures.yml`.

data/README.md

@@ -16,6 +16,16 @@ Add to your `.rubocop.yml`:
 require:
   - rubocop-view_component
 ```
+**Note:** From v0.7.0 onwards, this gem makes use of [rubydex](https://github.com/Shopify/rubydex) to discover which classes inherit from `ViewComponent::Base`. `UseProjectIndex` is required. Without it, cops that depend on ancestry detection will raise an error.
+
+```yaml
+AllCops:
+  UseProjectIndex: true
+```
+
+If you use a ViewComponent library such as [primer](https://github.com/primer/view_components) then you'll also need to set `ProjectIndexIncludesGems: true` so the cops can resolve ancestry chains that pass through gem classes.
+
+For more background on how RuboCop uses rubydex for cross-file analysis, see [RuboCop 1.89: Project-Wide Analysis with Rubydex](https://metaredux.com/posts/2026/08/05/rubocop-1-89.html).
 
 ## Cops
 
@@ -27,34 +37,10 @@ This gem provides several cops to enforce ViewComponent best practices:
 - **ViewComponent/PreferSlots** - Detect HTML parameters that should be slots
 - **ViewComponent/PreferComposition** - Avoid inheriting one ViewComponent from another (prefer composition)
 - **ViewComponent/TestRenderedOutput** - Encourage testing rendered output over private methods
-- **ViewComponent/MissingPreview** - Ensure every ViewComponent has a corresponding preview file (requires `PreviewPaths` configuration). Classes listed in `ViewComponentParentClasses` are automatically exempt, as abstract base classes are not rendered standalone.
+- **ViewComponent/MissingPreview** - Ensure every ViewComponent has a corresponding preview file (requires `PreviewPaths` configuration). Abstract base classes with descendants are automatically exempt.
 
 ## Optional Configuration
 
-### Base Class
-
-By default, the cops detect classes that inherit from `ViewComponent::Base` or `ApplicationComponent`. To add extra parent classes, use `inherit_mode: merge` so the defaults are preserved:
-
-```yaml
-# .rubocop.yml
-ViewComponent:
-  inherit_mode:
-    merge:
-      - ViewComponentParentClasses
-  ViewComponentParentClasses:
-    - MyApp::BaseComponent
-```
-
-To replace the defaults entirely (e.g. if your project has renamed `ApplicationComponent`), omit `inherit_mode`:
-
-```yaml
-# .rubocop.yml
-ViewComponent:
-  ViewComponentParentClasses:
-    - ViewComponent::Base
-    - MyApp::BaseComponent
-```
-
 ### Components Directory
 
 Several cops (`ComponentSuffix`, `PreferComposition`, `MissingPreview`, `TestRenderedOutput`) default to running only on files under `app/components/`. If your project uses a different path, override `Include` in your `.rubocop.yml`:

data/config/default.yml

@@ -1,7 +1,4 @@
 ViewComponent:
-  ViewComponentParentClasses:
-    - ViewComponent::Base
-    - ApplicationComponent
   ComponentNamespaces: []
 
 ViewComponent/ComponentSuffix:

data/gemfiles/rubocop_minimum.gemfile

@@ -0,0 +1,13 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "appraisal"
+gem "irb"
+gem "rake", "~> 13.4"
+gem "rspec"
+gem "rubocop", "= 1.89.0"
+gem "rubocop-rake"
+gem "rubocop-rspec"
+
+gemspec path: "../"

data/gemfiles/rubocop_minimum.gemfile.lock

@@ -0,0 +1,162 @@
+PATH
+  remote: ..
+  specs:
+    rubocop-view_component (0.6.0)
+      activesupport
+      herb
+      lint_roller (~> 1.1)
+      parser
+      rubocop (>= 1.89.0)
+      rubydex
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    activesupport (8.1.3.1)
+      base64
+      bigdecimal
+      concurrent-ruby (~> 1.0, >= 1.3.1)
+      connection_pool (>= 2.2.5)
+      drb
+      i18n (>= 1.6, < 2)
+      json
+      logger (>= 1.4.2)
+      minitest (>= 5.1)
+      securerandom (>= 0.3)
+      tzinfo (~> 2.0, >= 2.0.5)
+      uri (>= 0.13.1)
+    appraisal (2.5.0)
+      bundler
+      rake
+      thor (>= 0.14.0)
+    ast (2.4.3)
+    base64 (0.3.0)
+    bigdecimal (4.1.2)
+    concurrent-ruby (1.3.8)
+    connection_pool (3.0.2)
+    diff-lcs (1.6.2)
+    drb (2.2.3)
+    erb (6.0.7)
+    herb (0.10.3)
+    herb (0.10.3-aarch64-linux-gnu)
+    herb (0.10.3-aarch64-linux-musl)
+    herb (0.10.3-arm-linux-gnu)
+    herb (0.10.3-arm-linux-musl)
+    herb (0.10.3-arm64-darwin)
+    herb (0.10.3-x86-linux-gnu)
+    herb (0.10.3-x86-linux-musl)
+    herb (0.10.3-x86_64-darwin)
+    herb (0.10.3-x86_64-linux-gnu)
+    herb (0.10.3-x86_64-linux-musl)
+    i18n (1.15.2)
+      concurrent-ruby (~> 1.0)
+    io-console (0.9.1)
+    irb (1.18.0)
+      pp (>= 0.6.0)
+      prism (>= 1.3.0)
+      rdoc (>= 4.0.0)
+      reline (>= 0.4.2)
+    json (2.21.2)
+    language_server-protocol (3.17.0.6)
+    lint_roller (1.1.0)
+    logger (1.7.0)
+    minitest (6.0.6)
+      drb (~> 2.0)
+      prism (~> 1.5)
+    parallel (1.28.0)
+    parser (3.3.12.0)
+      ast (~> 2.4.1)
+      racc
+    pp (0.6.4)
+      prettyprint
+    prettyprint (0.2.0)
+    prism (1.9.0)
+    racc (1.8.1)
+    rainbow (3.1.1)
+    rake (13.4.2)
+    rbs (4.1.2)
+      logger
+      prism (>= 1.6.0)
+      tsort
+    rdoc (8.0.0)
+      erb
+      prism (>= 1.6.0)
+      rbs (>= 4.0.0)
+      tsort
+    regexp_parser (2.12.0)
+    reline (0.7.0)
+      io-console (~> 0.5)
+    rspec (3.13.2)
+      rspec-core (~> 3.13.0)
+      rspec-expectations (~> 3.13.0)
+      rspec-mocks (~> 3.13.0)
+    rspec-core (3.13.6)
+      rspec-support (~> 3.13.0)
+    rspec-expectations (3.13.5)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.13.0)
+    rspec-mocks (3.13.8)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.13.0)
+    rspec-support (3.13.7)
+    rubocop (1.89.0)
+      json (~> 2.3)
+      language_server-protocol (~> 3.17.0.2)
+      lint_roller (~> 1.1.0)
+      parallel (>= 1.10)
+      parser (>= 3.3.0.2)
+      rainbow (>= 2.2.2, < 4.0)
+      regexp_parser (>= 2.9.3, < 3.0)
+      rubocop-ast (>= 1.49.0, < 2.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (>= 2.4.0, < 4.0)
+    rubocop-ast (1.50.0)
+      parser (>= 3.3.7.2)
+      prism (~> 1.7)
+    rubocop-rake (0.7.1)
+      lint_roller (~> 1.1)
+      rubocop (>= 1.72.1)
+    rubocop-rspec (3.7.0)
+      lint_roller (~> 1.1)
+      rubocop (~> 1.72, >= 1.72.1)
+    ruby-progressbar (1.13.0)
+    rubydex (0.3.0)
+    rubydex (0.3.0-aarch64-linux)
+    rubydex (0.3.0-arm64-darwin)
+    rubydex (0.3.0-x86_64-darwin)
+    rubydex (0.3.0-x86_64-linux)
+    securerandom (0.4.1)
+    thor (1.5.0)
+    tsort (0.2.0)
+    tzinfo (2.0.6)
+      concurrent-ruby (~> 1.0)
+    unicode-display_width (3.2.0)
+      unicode-emoji (~> 4.1)
+    unicode-emoji (4.2.0)
+    uri (1.1.1)
+
+PLATFORMS
+  aarch64-linux-gnu
+  aarch64-linux-musl
+  arm-linux-gnu
+  arm-linux-musl
+  arm64-darwin
+  ruby
+  x86-linux-gnu
+  x86-linux-musl
+  x86_64-darwin
+  x86_64-linux-gnu
+  x86_64-linux-musl
+
+DEPENDENCIES
+  appraisal
+  irb
+  rake (~> 13.4)
+  rspec
+  rubocop (= 1.89.0)
+  rubocop-rake
+  rubocop-rspec
+  rubocop-view_component!
+
+BUNDLED WITH
+   2.7.2

data/lib/rubocop/cop/view_component/base.rb

@@ -1,35 +1,56 @@
 # frozen_string_literal: true
 
+require "rubydex"
+
 module RuboCop
   module Cop
     module ViewComponent
-      # Shared helper methods for ViewComponent cops
+      # Shared helper methods for ViewComponent cops.
+      # Requires rubydex with UseProjectIndex: true for ancestry resolution.
       module Base
-        # Check if a class node inherits from ViewComponent::Base or ApplicationComponent
+        include ProjectIndexHelp
+
+        VC_BASE = "ViewComponent::Base"
+
+        # Check if a class node inherits from ViewComponent::Base
         def view_component_class?(node)
           return false unless node&.class_type?
 
           class_source = fully_qualified_name(node)
           return true if component_namespaces.any? { |ns| class_source.start_with?(ns) }
 
+          require_project_index!
+
           parent_class = node.parent_class
           return false unless parent_class
 
           view_component_parent?(parent_class)
         end
 
-        # Check if node represents a configured parent class
+        # Check if a constant node resolves to a class with ViewComponent::Base as ancestor
         def view_component_parent?(node)
           return false unless node.const_type?
 
-          (cop_config["ViewComponentParentClasses"] || []).include?(node.source)
+          require_project_index!
+
+          declaration = resolve_constant_in_index(node)
+          return false unless declaration.respond_to?(:has_ancestor?)
+
+          declaration.name == VC_BASE || declaration.has_ancestor?(VC_BASE)
         end
 
-        # Check if a class node is itself one of the registered parent classes.
+        # Check if a class node is itself an abstract parent class
+        # (has ViewComponent::Base as ancestor and has descendants in the project)
         def view_component_parent_class?(node)
           return false unless node&.class_type?
 
-          (cop_config["ViewComponentParentClasses"] || []).include?(fully_qualified_name(node))
+          require_project_index!
+
+          declaration = resolve_constant_in_index(node.identifier)
+          return false unless declaration.respond_to?(:has_ancestor?)
+
+          declaration.has_ancestor?(VC_BASE) &&
+            declaration.descendants.any? { |d| d.name != declaration.name }
         end
 
         def fully_qualified_name(node)
@@ -51,11 +72,22 @@ module RuboCop
 
         # Check if node is within a ViewComponent class
         def inside_view_component?(node)
+          require_project_index!
+
           klass = enclosing_class(node)
           return false unless klass
 
           view_component_class?(klass)
         end
+
+        def require_project_index!
+          return if project_index
+
+          raise <<~MSG
+            ViewComponent cops require `AllCops/UseProjectIndex: true` in your .rubocop.yml
+            for ancestry-based class detection.
+          MSG
+        end
       end
     end
   end

data/lib/rubocop/cop/view_component/test_rendered_output.rb

@@ -47,6 +47,7 @@ module RuboCop
           add_offense(node)
         end
         alias on_numblock on_block
+        alias on_itblock on_block
 
         private
 

data/lib/rubocop/view_component/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module ViewComponent
-    VERSION = "0.6.0"
+    VERSION = "0.7.0"
   end
 end

data/script/verify

@@ -112,8 +112,10 @@ def add_gem_to_gemfile
 end
 
 def run_rubocop
+  FileUtils.rm_f("Gemfile.lock")
   puts "Running bundle install..."
-  system!("bundle", "install")
+  system!({ "BUNDLE_WITHOUT" => "development" }, "bundle", "install")
+  system!("bundle", "add", "rubocop")
 
   puts "Running RuboCop (ViewComponent cops only)..."
   output, status = Open3.capture2(

data/spec/expected_govuk_failures.yml

@@ -7,10 +7,12 @@ ViewComponent/ComponentSuffix:
   - 'app/components/govuk_component/notification_banner_component.rb'
   - 'app/components/govuk_component/pagination_component/adjacent_page.rb'
   - 'app/components/govuk_component/pagination_component/item.rb'
+  - 'app/components/govuk_component/panel_component.rb'
   - 'app/components/govuk_component/tab_component.rb'
 ViewComponent/PreferPrivateMethods:
   - 'app/components/govuk_component/base.rb'
   - 'app/components/govuk_component/notification_banner_component.rb'
+  - 'app/components/govuk_component/panel_component.rb'
   - 'app/components/govuk_component/service_navigation_component.rb'
   - 'app/components/govuk_component/tab_component.rb'
 ViewComponent/TestRenderedOutput:

data/spec/expected_primer_failures.yml

@@ -15,5 +15,8 @@ ViewComponent/PreferPrivateMethods:
   - 'app/components/primer/alpha/tree_view/node.rb'
   - 'app/components/primer/beta/avatar.rb'
   - 'app/components/primer/beta/nav_list.rb'
+  - 'app/components/primer/beta/nav_list/divider.rb'
+  - 'app/components/primer/beta/nav_list/group.rb'
+  - 'app/components/primer/beta/nav_list/item.rb'
 ViewComponent/TestRenderedOutput:
   - 'test/components/alpha/action_list_test.rb'

data/spec/rubocop/cop/view_component/base_spec.rb

@@ -0,0 +1,92 @@
+# frozen_string_literal: true
+
+RSpec.describe RuboCop::Cop::ViewComponent::Base do
+  let(:cop_class) { RuboCop::Cop::ViewComponent::ComponentSuffix }
+  let(:cop) { cop_class.new(RuboCop::Config.new) }
+
+  before do
+    cop.project_index = nil
+  end
+
+  describe "#view_component_class?" do
+    it "raises when project_index is not set and class is not in ComponentNamespaces" do
+      source = parse_source(<<~RUBY)
+        class Foo < ViewComponent::Base
+        end
+      RUBY
+
+      expect { cop.send(:view_component_class?, source.ast) }.to raise_error(
+        RuntimeError,
+        /UseProjectIndex/
+      )
+    end
+
+    it "does not raise when class matches a ComponentNamespace" do
+      config = RuboCop::Config.new(
+        "ViewComponent/ComponentSuffix" => {
+          "ComponentNamespaces" => ["MyApp::"]
+        }
+      )
+      cop = cop_class.new(config)
+      cop.project_index = nil
+
+      source = parse_source(<<~RUBY)
+        module MyApp
+          class Foo < ViewComponent::Base
+          end
+        end
+      RUBY
+
+      class_node = source.ast.body
+
+      expect(cop.send(:view_component_class?, class_node)).to be true
+    end
+  end
+
+  describe "#view_component_parent?" do
+    it "raises when project_index is not set" do
+      source = parse_source(<<~RUBY)
+        class Foo < ViewComponent::Base
+        end
+      RUBY
+
+      parent = source.ast.parent_class
+
+      expect { cop.send(:view_component_parent?, parent) }.to raise_error(
+        RuntimeError,
+        /UseProjectIndex/
+      )
+    end
+  end
+
+  describe "#view_component_parent_class?" do
+    it "raises when project_index is not set" do
+      source = parse_source(<<~RUBY)
+        class Foo < ViewComponent::Base
+        end
+      RUBY
+
+      expect { cop.send(:view_component_parent_class?, source.ast) }.to raise_error(
+        RuntimeError,
+        /UseProjectIndex/
+      )
+    end
+  end
+
+  describe "#inside_view_component?" do
+    it "raises when project_index is not set" do
+      source = parse_source(<<~RUBY)
+        class Foo < ViewComponent::Base
+          def call; end
+        end
+      RUBY
+
+      method_node = source.ast.body
+
+      expect { cop.send(:inside_view_component?, method_node) }.to raise_error(
+        RuntimeError,
+        /UseProjectIndex/
+      )
+    end
+  end
+end

data/spec/rubocop/cop/view_component/component_suffix_spec.rb

@@ -74,64 +74,6 @@ RSpec.describe RuboCop::Cop::ViewComponent::ComponentSuffix, :config do
     end
   end
 
-  context "when ViewComponentParentClasses is configured with merge" do
-    let(:config) do
-      RuboCop::Config.new(
-        "ViewComponent/ComponentSuffix" => {
-          "ViewComponentParentClasses" => ["ViewComponent::Base", "ApplicationComponent", "Primer::Component"]
-        }
-      )
-    end
-
-    it "registers an offense for classes inheriting from a configured parent" do
-      expect_offense(<<~RUBY)
-        class FooBar < Primer::Component
-              ^^^^^^ ViewComponent class names should end with `Component`.
-        end
-      RUBY
-    end
-
-    it "does not register offense when class name ends with Component" do
-      expect_no_offenses(<<~RUBY)
-        class FooBarComponent < Primer::Component
-        end
-      RUBY
-    end
-
-    it "still recognizes the default parent classes" do
-      expect_offense(<<~RUBY)
-        class FooBar < ViewComponent::Base
-              ^^^^^^ ViewComponent class names should end with `Component`.
-        end
-      RUBY
-    end
-  end
-
-  context "when ViewComponentParentClasses is configured replacing defaults" do
-    let(:config) do
-      RuboCop::Config.new(
-        "ViewComponent/ComponentSuffix" => {
-          "ViewComponentParentClasses" => ["Primer::Component"]
-        }
-      )
-    end
-
-    it "registers an offense for classes inheriting from a configured parent" do
-      expect_offense(<<~RUBY)
-        class FooBar < Primer::Component
-              ^^^^^^ ViewComponent class names should end with `Component`.
-        end
-      RUBY
-    end
-
-    it "does not recognize default parent classes that were replaced" do
-      expect_no_offenses(<<~RUBY)
-        class FooBar < ViewComponent::Base
-        end
-      RUBY
-    end
-  end
-
   context "with compact nested class syntax" do
     it "registers offense for compact syntax" do
       expect_offense(<<~RUBY)

data/spec/rubocop/cop/view_component/missing_preview_spec.rb

@@ -5,8 +5,7 @@ RSpec.describe RuboCop::Cop::ViewComponent::MissingPreview, :config do
     RuboCop::Config.new(
       "ViewComponent/MissingPreview" => {
         "Enabled" => true,
-        "PreviewPaths" => ["/previews"],
-        "ViewComponentParentClasses" => %w[ViewComponent::Base ApplicationComponent]
+        "PreviewPaths" => ["/previews"]
       }
     )
   end
@@ -172,45 +171,5 @@ RSpec.describe RuboCop::Cop::ViewComponent::MissingPreview, :config do
         end
       RUBY
     end
-
-    context "when a custom parent class is configured" do
-      let(:config) do
-        RuboCop::Config.new(
-          "ViewComponent/MissingPreview" => {
-            "Enabled" => true,
-            "PreviewPaths" => ["/previews"],
-            "ViewComponentParentClasses" => %w[ViewComponent::Base ApplicationComponent BaseComponent]
-          }
-        )
-      end
-
-      it "does not register an offense for the custom parent class" do
-        expect_no_offenses(<<~RUBY, "/app/components/base_component.rb")
-          class BaseComponent < ViewComponent::Base
-          end
-        RUBY
-      end
-    end
-
-    context "when a namespaced custom parent class is configured" do
-      let(:config) do
-        RuboCop::Config.new(
-          "ViewComponent/MissingPreview" => {
-            "Enabled" => true,
-            "PreviewPaths" => ["/previews"],
-            "ViewComponentParentClasses" => %w[ViewComponent::Base ApplicationComponent MyApp::BaseComponent]
-          }
-        )
-      end
-
-      it "does not register an offense for the namespaced custom parent class" do
-        expect_no_offenses(<<~RUBY, "/app/components/my_app/base_component.rb")
-          module MyApp
-            class BaseComponent < ViewComponent::Base
-            end
-          end
-        RUBY
-      end
-    end
   end
 end

data/spec/rubocop/cop/view_component/prefer_composition_spec.rb

@@ -88,21 +88,4 @@ RSpec.describe RuboCop::Cop::ViewComponent::PreferComposition, :config do
       RUBY
     end
   end
-
-  context "when ViewComponentParentClasses is configured" do
-    let(:config) do
-      RuboCop::Config.new(
-        "ViewComponent/PreferComposition" => {
-          "ViewComponentParentClasses" => ["Primer::Component"]
-        }
-      )
-    end
-
-    it "does not register an offense for configured parent classes" do
-      expect_no_offenses(<<~RUBY)
-        class FooBarComponent < Primer::Component
-        end
-      RUBY
-    end
-  end
 end

data/spec/rubocop/cop/view_component/prefer_private_methods_spec.rb

@@ -147,8 +147,7 @@ RSpec.describe RuboCop::Cop::ViewComponent::PreferPrivateMethods, :config do
           "AllCops" => { "DisplayCopNames" => true },
           "ViewComponent/PreferPrivateMethods" => {
             "AllowedPublicMethods" => %w[initialize call],
-            "AllowedPublicMethodPatterns" => ["^render_", "^with_"],
-            "ViewComponentParentClasses" => %w[ViewComponent::Base ApplicationComponent]
+            "AllowedPublicMethodPatterns" => ["^render_", "^with_"]
           }
         )
       end
@@ -190,8 +189,7 @@ RSpec.describe RuboCop::Cop::ViewComponent::PreferPrivateMethods, :config do
         "AllCops" => { "DisplayCopNames" => true },
         "ViewComponent/PreferPrivateMethods" => {
           "AllowedPublicMethods" => %w[initialize call custom_public_method],
-          "AllowedPublicMethodPatterns" => [],
-          "ViewComponentParentClasses" => %w[ViewComponent::Base ApplicationComponent]
+          "AllowedPublicMethodPatterns" => []
         }
       )
     end

data/spec/spec_helper.rb

@@ -2,6 +2,7 @@
 
 require "rubocop-view_component"
 require "rubocop/rspec/support"
+require_relative "support/project_index_helpers"
 
 RSpec.configure do |config|
   config.disable_monkey_patching!
@@ -11,4 +12,13 @@ RSpec.configure do |config|
 
   config.order = :random
   Kernel.srand config.seed
+
+  config.include ViewComponent::ProjectIndexHelpers
+
+  config.before do |example|
+    next unless example.metadata[:config]
+
+    graph = build_index
+    cop.project_index = ViewComponent::ProjectIndexHelpers::LazyIndex.new(graph, cop)
+  end
 end

data/spec/support/project_index_helpers.rb

@@ -0,0 +1,71 @@
+# frozen_string_literal: true
+
+require "rubydex"
+
+module ViewComponent
+  module ProjectIndexHelpers
+    DEFAULT_SOURCES = {
+      "file:///view_component.rb" => <<~RUBY,
+        module ViewComponent
+          class Base
+          end
+        end
+      RUBY
+      "file:///application_component.rb" => <<~RUBY,
+        class ApplicationComponent < ViewComponent::Base
+        end
+      RUBY
+      "file:///user_component.rb" => <<~RUBY
+        class UserComponent < ApplicationComponent
+        end
+      RUBY
+    }.freeze
+
+    def build_index(sources = {})
+      graph = Rubydex::Graph.new
+      DEFAULT_SOURCES.merge(sources).each { |uri, source| graph.index_source(uri, source, "ruby") }
+      graph.resolve
+      graph
+    end
+
+    # Wraps a graph to lazily index the source being inspected when
+    # resolve_constant is called. This mirrors how the real RuboCop runner
+    # indexes all project files, including the one being inspected.
+    class LazyIndex
+      def initialize(base_graph, cop)
+        @base_graph = base_graph
+        @cop = cop
+        @rebuilt = false
+      end
+
+      def resolve_constant(name, nesting)
+        result = @base_graph.resolve_constant(name, nesting)
+        return result if result
+
+        rebuild_once
+        @base_graph.resolve_constant(name, nesting)
+      end
+
+      def method_missing(name, ...)
+        @base_graph.send(name, ...)
+      end
+
+      def respond_to_missing?(name, include_private = false)
+        @base_graph.respond_to?(name, include_private) || super
+      end
+
+      private
+
+      def rebuild_once
+        return if @rebuilt
+
+        @rebuilt = true
+        source = @cop&.processed_source
+        return unless source&.raw_source
+
+        @base_graph.index_source("file:///test_source.rb", source.raw_source, "ruby")
+        @base_graph.resolve
+      end
+    end
+  end
+end

data/verification/govuk_rubocop_config.yml

@@ -1,9 +1,6 @@
-ViewComponent:
-  inherit_mode:
-    merge:
-      - ViewComponentParentClasses
-  ViewComponentParentClasses:
-    - GovukComponent::Base
+AllCops:
+  UseProjectIndex: true
+  ProjectIndexIncludesGems: true
 
 # x-govuk components do not use ViewComponent previews
 ViewComponent/MissingPreview:

data/verification/polaris_rubocop_config.yml

@@ -1,10 +1,6 @@
-ViewComponent:
-  inherit_mode:
-    merge:
-      - ViewComponentParentClasses
-  ViewComponentParentClasses:
-    - Polaris::Component
-    - Component
+AllCops:
+  UseProjectIndex: true
+  ProjectIndexIncludesGems: true
 
 ViewComponent/MissingPreview:
   PreviewPaths:

data/verification/primer_rubocop_config.yml

@@ -1,10 +1,6 @@
-ViewComponent:
-  inherit_mode:
-    merge:
-      - ViewComponentParentClasses
-  ViewComponentParentClasses:
-    - Primer::Component
-    - Primer::BaseComponent
+AllCops:
+  UseProjectIndex: true
+  ProjectIndexIncludesGems: true
 
 # Primer seems to intentionally omit the Component suffix from most class names
 # (116 out of 131 components), so this cop is not useful here.
@@ -31,3 +27,5 @@ ViewComponent/MissingPreview:
     - previews
   Exclude:
     - app/components/primer/base_component.rb
+    # Deprecated wrapper with no preview
+    - app/components/primer/navigation/tab_component.rb

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-view_component
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 0.7.0
 platform: ruby
 authors:
 - Andy Waite
@@ -65,20 +65,34 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubydex
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.72.2
+        version: 1.89.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.72.2
+        version: 1.89.0
 description: A RuboCop extension that enforces ViewComponent best practices and conventions
 email:
 - andyw8@users.noreply.github.com
@@ -88,11 +102,14 @@ extra_rdoc_files: []
 files:
 - ".rspec"
 - ".rubocop.yml"
+- Appraisals
 - CLAUDE.md
 - LICENSE.txt
 - README.md
 - Rakefile
 - config/default.yml
+- gemfiles/rubocop_minimum.gemfile
+- gemfiles/rubocop_minimum.gemfile.lock
 - lib/rubocop-view_component.rb
 - lib/rubocop/cop/view_component/base.rb
 - lib/rubocop/cop/view_component/component_suffix.rb
@@ -113,6 +130,7 @@ files:
 - spec/expected_primer_failures.yml
 - spec/fixtures/components/template_method_component.html.erb
 - spec/fixtures/components/template_method_component.rb
+- spec/rubocop/cop/view_component/base_spec.rb
 - spec/rubocop/cop/view_component/component_suffix_spec.rb
 - spec/rubocop/cop/view_component/missing_preview_spec.rb
 - spec/rubocop/cop/view_component/no_global_state_spec.rb
@@ -121,6 +139,7 @@ files:
 - spec/rubocop/cop/view_component/prefer_slots_spec.rb
 - spec/rubocop/cop/view_component/test_rendered_output_spec.rb
 - spec/spec_helper.rb
+- spec/support/project_index_helpers.rb
 - verification/govuk_rubocop_config.yml
 - verification/libraries.yml
 - verification/polaris_rubocop_config.yml
@@ -147,7 +166,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.9
+rubygems_version: 4.0.16
 specification_version: 4
 summary: RuboCop extension for ViewComponent best practices
 test_files: []