rubocop-view_component 0.5.1 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 93f6d112da7bf592a3d0a114d492211798067caea8c8286feee1930d2b56810d
-  data.tar.gz: b5bb3fcbf1e270cff0410dd743145130ba1de2089374c6f4c6b0618037e64e92
+  metadata.gz: be0a1c1c9a7489ed311953b5f67c7108dbca8b1f43debef36026ec011781a549
+  data.tar.gz: 0b62b04534ab81725ab96d28c0b1931671d92944277ac7b5217f4d36d9d91f9b
 SHA512:
-  metadata.gz: 92322d18a8ced7cb42d053bbd595e926b11059a49162ae7c7b3e01721397d45b61ca4b00715955b808b1699fa4d8d2ecdc05a68f6f0114e62b32081a92e2b174
-  data.tar.gz: d55bb666487e1782dfce9298d78a920c989c58c6c33fc34a7f47f4bddae52543e05741b1f18da1ecbb2fa847345d09cab01c23ef759958204982ac27ee889f8a
+  metadata.gz: 7fc23bef50c35486b422362f9e738e5347b41eaeb8171f2dfca21884dbd87542f2db1e22618c1b239a1bfd2d878b448cb208539678c37b6e622086c1ee4d2871
+  data.tar.gz: f67e8fc0ec682da84318f7078bc5eaffd4a7e9907e9d4e281a224e240e57a13b4f4ec010ef31cce3f20528b4f6fc4ce5acf538385736a837095ef21a90fcf641

data/.rubocop.yml

@@ -1,7 +1,39 @@
 plugins:
   - rubocop-internal_affairs
+  - rubocop-rake
+  - rubocop-rspec
   - rubocop-view_component
 
+inherit_mode:
+  merge:
+    - Exclude
+
+AllCops:
+  TargetRubyVersion: 3.2
+  NewCops: enable
+  SuggestExtensions: false
+  Exclude:
+    - 'verification/**/*'
+    - 'script/verify'
+    - 'spec/fixtures/**/*'
+
+Metrics/BlockLength:
+  Exclude:
+    - 'spec/**/*'
+    - '*.gemspec'
+
+RSpec/ExampleLength:
+  Max: 20
+
+Style/StringLiterals:
+  EnforcedStyle: double_quotes
+
+Style/StringLiteralsInInterpolation:
+  EnforcedStyle: double_quotes
+
+InternalAffairs/RedundantLetRuboCopConfigNew:
+  Enabled: false
+
 Naming/FileName:
   Exclude:
     - lib/rubocop-view_component.rb

data/CLAUDE.md

@@ -11,7 +11,7 @@ This is a RuboCop extension that enforces ViewComponent best practices. It provi
 ### Testing
 - `rake spec` - Run all RSpec tests
 - `bundle exec rspec spec/rubocop/cop/view_component/FILENAME_spec.rb` - Run a specific spec file
-- `rake standard` - Run Standard (RuboCop) linting
+- `rake rubocop` - Run RuboCop linting
 - `rake` - Run both tests and linting (default task)
 
 ### Verification
@@ -52,17 +52,17 @@ All cops inherit from `RuboCop::Cop::Base` and are located in `lib/rubocop/cop/v
 
 ### Configuration
 
-The `AllCops` config supports `ViewComponentParentClasses` to configure additional base classes beyond `ViewComponent::Base` and `ApplicationComponent`:
+The `ViewComponent` config supports `ViewComponentParentClasses` to configure additional base classes beyond `ViewComponent::Base` and `ApplicationComponent`:
 
 ```yaml
-AllCops:
+ViewComponent:
   ViewComponentParentClasses:
     - MyApp::BaseComponent
 ```
 
 ### Verification System
 
-The `script/verify` script downloads real component libraries, runs all ViewComponent cops, and compares results to checked-in snapshots. This catches regressions when cop behavior changes. Libraries are configured in `verification/libraries.yml`, downloaded to `verification/LIBRARY/`, and expected results stored in `spec/expected_LIBRARY_failures.json`.
+The `script/verify` script downloads real component libraries, runs all ViewComponent cops, and compares results to checked-in snapshots. This catches regressions when cop behavior changes. Libraries are configured in `verification/libraries.yml`, downloaded to `verification/LIBRARY/`, and expected results stored in `spec/expected_LIBRARY_failures.yml`.
 
 ## Implementation Notes
 

data/README.md

@@ -27,24 +27,49 @@ This gem provides several cops to enforce ViewComponent best practices:
 - **ViewComponent/PreferSlots** - Detect HTML parameters that should be slots
 - **ViewComponent/PreferComposition** - Avoid inheriting one ViewComponent from another (prefer composition)
 - **ViewComponent/TestRenderedOutput** - Encourage testing rendered output over private methods
-- **ViewComponent/MissingPreview** - Ensure every ViewComponent has a corresponding preview file (requires `PreviewPaths` configuration)
+- **ViewComponent/MissingPreview** - Ensure every ViewComponent has a corresponding preview file (requires `PreviewPaths` configuration). Classes listed in `ViewComponentParentClasses` are automatically exempt, as abstract base classes are not rendered standalone.
 
 ## Optional Configuration
 
 ### Base Class
 
-By default, the cops detect classes that inherit from `ViewComponent::Base` or `ApplicationComponent`. If your project uses a different base class (e.g. `Primer::Component`), you can configure additional parent classes under `AllCops`, for example:
+By default, the cops detect classes that inherit from `ViewComponent::Base` or `ApplicationComponent`. To add extra parent classes, use `inherit_mode: merge` so the defaults are preserved:
 
 ```yaml
 # .rubocop.yml
-AllCops:
+ViewComponent:
+  inherit_mode:
+    merge:
+      - ViewComponentParentClasses
   ViewComponentParentClasses:
     - MyApp::BaseComponent
 ```
 
+To replace the defaults entirely (e.g. if your project has renamed `ApplicationComponent`), omit `inherit_mode`:
+
+```yaml
+# .rubocop.yml
+ViewComponent:
+  ViewComponentParentClasses:
+    - ViewComponent::Base
+    - MyApp::BaseComponent
+```
+
+### Components Directory
+
+Several cops (`ComponentSuffix`, `PreferComposition`, `MissingPreview`, `TestRenderedOutput`) default to running only on files under `app/components/`. If your project uses a different path, override `Include` in your `.rubocop.yml`:
+
+```yaml
+# .rubocop.yml
+ViewComponent/ComponentSuffix:
+  Include:
+    - 'app/components/**/*.rb'
+    - 'engines/*/app/components/**/*.rb'
+```
+
 ### No Super
 
-View Component convention is to not calling `super` in component initializers, but that may cause `Lint/MissingSuper` failures from RuboCop. We suggest disabling that rule for your view components directory, for example:
+ViewComponent convention is to not call `super` in component initializers, but that may cause `Lint/MissingSuper` failures from RuboCop. We suggest disabling that rule for your view components directory, for example:
 
 ```yaml
 # .rubocop.yml

data/Rakefile

@@ -1,13 +1,11 @@
 # frozen_string_literal: true
 
 require "bundler/gem_tasks"
-require "minitest/test_task"
+require "rubocop/rake_task"
 
-Minitest::TestTask.create
+RuboCop::RakeTask.new
 
-require "standard/rake"
-
-task default: %i[spec standard]
+task default: %i[spec rubocop]
 
 require "rspec/core/rake_task"
 

data/config/default.yml

@@ -1,5 +1,7 @@
 ViewComponent:
-  ViewComponentParentClasses: []
+  ViewComponentParentClasses:
+    - ViewComponent::Base
+    - ApplicationComponent
   ComponentNamespaces: []
 
 ViewComponent/ComponentSuffix:
@@ -8,6 +10,8 @@ ViewComponent/ComponentSuffix:
   VersionAdded: '0.1'
   Severity: convention
   StyleGuide: 'https://viewcomponent.org/best_practices.html'
+  Include:
+    - 'app/components/**/*.rb'
 
 ViewComponent/MissingPreview:
   Description: 'Ensure every ViewComponent has a corresponding preview file.'
@@ -52,6 +56,8 @@ ViewComponent/PreferComposition:
   VersionAdded: '0.3'
   Severity: convention
   StyleGuide: 'https://viewcomponent.org/best_practices.html#avoid-inheritance'
+  Include:
+    - 'app/components/**/*.rb'
   ComponentNamespaces: []
 
 ViewComponent/PreferSlots:

data/lib/rubocop/cop/view_component/base.rb

@@ -9,7 +9,7 @@ module RuboCop
         def view_component_class?(node)
           return false unless node&.class_type?
 
-          class_source = node.identifier.source
+          class_source = fully_qualified_name(node)
           return true if component_namespaces.any? { |ns| class_source.start_with?(ns) }
 
           parent_class = node.parent_class
@@ -18,16 +18,26 @@ module RuboCop
           view_component_parent?(parent_class)
         end
 
-        # Check if node represents ViewComponent::Base, ApplicationComponent,
-        # or a configured additional parent class
+        # Check if node represents a configured parent class
         def view_component_parent?(node)
           return false unless node.const_type?
 
-          source = node.source
-          return true if source == "ViewComponent::Base" || source == "ApplicationComponent"
+          (cop_config["ViewComponentParentClasses"] || []).include?(node.source)
+        end
+
+        # Check if a class node is itself one of the registered parent classes.
+        def view_component_parent_class?(node)
+          return false unless node&.class_type?
+
+          (cop_config["ViewComponentParentClasses"] || []).include?(fully_qualified_name(node))
+        end
+
+        def fully_qualified_name(node)
+          namespace = node.parent_module_name
+          short_name = node.identifier.source
+          return short_name if namespace.nil? || namespace == "Object"
 
-          additional = cop_config["ViewComponentParentClasses"] || []
-          additional.include?(source)
+          "#{namespace}::#{short_name}"
         end
 
         def component_namespaces

data/lib/rubocop/cop/view_component/missing_preview.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require "active_support/inflector"
+
 module RuboCop
   module Cop
     module ViewComponent
@@ -15,8 +17,9 @@ module RuboCop
 
         def on_class(node)
           return unless view_component_class?(node)
+          return if view_component_parent_class?(node)
 
-          class_name = node.identifier.source
+          class_name = fully_qualified_name(node)
           return if preview_exists?(class_name)
 
           add_offense(node.identifier, message: format(MSG, component: class_name, paths: preview_paths.join(", ")))
@@ -33,12 +36,11 @@ module RuboCop
         end
 
         def candidate_filenames(class_name)
-          base = class_name.gsub(/Component$/, "").gsub("::", "/").gsub(/([A-Z])/, '_\1').downcase.gsub("/_", "/")
-          base = base.delete_prefix("_").delete_prefix("/")
-          [
-            "#{base}_preview.rb",
-            "#{base}_component_preview.rb"
-          ]
+          bases = [ActiveSupport::Inflector.underscore(class_name.delete_suffix("Component"))]
+          short_name = class_name.split("::").last
+          short_base = ActiveSupport::Inflector.underscore(short_name.delete_suffix("Component"))
+          bases << short_base if short_base != bases.first
+          bases.flat_map { |base| ["#{base}_preview.rb", "#{base}_component_preview.rb"] }
         end
 
         def preview_paths

data/lib/rubocop/cop/view_component/no_global_state.rb

@@ -45,18 +45,32 @@ module RuboCop
 
         RESTRICT_ON_SEND = GLOBAL_STATE_METHODS
 
+        # @!method global_state_access?(node)
         def_node_matcher :global_state_access?, <<~PATTERN
           (send nil? ${:params :request :session :cookies :flash} ...)
         PATTERN
 
+        # @!method sorbet_sig_block?(node)
+        def_node_matcher :sorbet_sig_block?, <<~PATTERN
+          (block (send nil? :sig) ...)
+        PATTERN
+
         def on_send(node)
           return unless inside_view_component?(node)
 
           method_name = global_state_access?(node)
           return unless method_name
+          return if sorbet_signature?(node)
 
           add_offense(node, message: format(MSG, method: method_name))
         end
+        alias on_csend on_send
+
+        private
+
+        def sorbet_signature?(node)
+          node.each_ancestor(:block).any? { |ancestor| sorbet_sig_block?(ancestor) }
+        end
       end
     end
   end

data/lib/rubocop/cop/view_component/prefer_private_methods.rb

@@ -40,29 +40,32 @@ module RuboCop
         private
 
         def check_public_methods(class_node)
-          current_visibility = :public
-          template_method_calls = methods_called_in_templates
-
           body = class_node.body
           return unless body
 
           children = body.begin_type? ? body.children : [body]
+          check_children(children, methods_called_in_templates)
+        end
+
+        def check_children(children, template_method_calls)
+          current_visibility = :public
 
           children.each do |child|
             if visibility_modifier?(child)
               current_visibility = child.method_name
-              next
+            elsif should_flag?(child, current_visibility, template_method_calls)
+              add_offense(child, message: format(MSG, method_name: child.method_name))
             end
-
-            next unless child.def_type?
-            next unless current_visibility == :public
-            next if allowed_public_method?(child.method_name)
-            next if template_method_calls.include?(child.method_name)
-
-            add_offense(child, message: format(MSG, method_name: child.method_name))
           end
         end
 
+        def should_flag?(child, visibility, template_method_calls)
+          child.def_type? &&
+            visibility == :public &&
+            !allowed_public_method?(child.method_name) &&
+            !template_method_calls.include?(child.method_name)
+        end
+
         def allowed_public_method?(method_name)
           allowed_public_methods.include?(method_name.to_s) ||
             allowed_public_method_patterns.any? { |pattern| method_name.to_s.match?(pattern) }
@@ -84,8 +87,7 @@ module RuboCop
           template_paths.each_with_object(Set.new) do |path, methods|
             methods.merge(extract_method_calls(path))
           end
-        rescue => e
-          # Graceful degradation on errors
+        rescue StandardError => e
           warn "Warning: Failed to analyze templates: #{e.message}" if ENV["RUBOCOP_DEBUG"]
           Set.new
         end

data/lib/rubocop/cop/view_component/prefer_slots.rb

@@ -31,6 +31,7 @@ module RuboCop
 
         HTML_PARAM_PATTERN = /_html$/
 
+        # @!method html_safe_call?(node)
         def_node_search :html_safe_call?, "(send _ :html_safe)"
 
         def on_class(node)
@@ -46,29 +47,23 @@ module RuboCop
 
         def find_initialize(class_node)
           class_node.each_descendant(:def).find do |def_node|
-            def_node.method_name == :initialize
+            def_node.method?(:initialize)
           end
         end
 
         def check_initialize_params(initialize_node)
           initialize_node.arguments.each do |arg|
-            next unless arg.kwoptarg_type? || arg.kwarg_type?
+            next unless arg.type?(:kwoptarg, :kwarg)
 
-            param_name = arg.children[0]
+            check_param(arg)
+          end
+        end
 
-            # Check parameter name patterns
-            if html_param_name?(param_name)
-              suggested_slot = suggest_slot_name(param_name)
-              add_offense(arg, message: format(MSG, slot_method: suggested_slot))
-              next
-            end
+        def check_param(arg)
+          param_name = arg.children[0]
+          return unless html_param_name?(param_name) || (arg.kwoptarg_type? && html_safe_call?(arg))
 
-            # Check for html_safe in default value
-            if arg.kwoptarg_type? && html_safe_call?(arg)
-              suggested_slot = suggest_slot_name(param_name)
-              add_offense(arg, message: format(MSG, slot_method: suggested_slot))
-            end
-          end
+          add_offense(arg, message: format(MSG, slot_method: suggest_slot_name(param_name)))
         end
 
         def html_param_name?(name)

data/lib/rubocop/cop/view_component/template_analyzer.rb

@@ -16,26 +16,26 @@ module RuboCop
           base_path = component_path.sub(/\.rb$/, "")
           component_dir = File.dirname(component_path)
           component_name = File.basename(component_path, ".rb")
+          sidecar_dir = File.join(component_dir, component_name)
 
-          paths = []
-
-          # Check for sibling template: same_name.html.erb
-          sibling_template = "#{base_path}.html.erb"
-          paths << sibling_template if File.exist?(sibling_template)
-
-          # Check for sidecar template: same_name/same_name.html.erb
-          sidecar_template = File.join(component_dir, component_name, "#{component_name}.html.erb")
-          paths << sidecar_template if File.exist?(sidecar_template)
-
-          # Check for variants: same_name.*.html.erb
-          variant_pattern = "#{base_path}.*.html.erb"
-          paths.concat(Dir.glob(variant_pattern))
+          paths = sibling_templates(base_path) + sidecar_templates(sidecar_dir, component_name)
+          paths.uniq
+        end
 
-          # Check for sidecar variants: same_name/same_name.*.html.erb
-          sidecar_variant_pattern = File.join(component_dir, component_name, "#{component_name}.*.html.erb")
-          paths.concat(Dir.glob(sidecar_variant_pattern))
+        def sibling_templates(base_path)
+          paths = []
+          sibling = "#{base_path}.html.erb"
+          paths << sibling if File.exist?(sibling)
+          paths.concat(Dir.glob("#{base_path}.*.html.erb"))
+          paths
+        end
 
-          paths.uniq
+        def sidecar_templates(sidecar_dir, component_name)
+          paths = []
+          sidecar = File.join(sidecar_dir, "#{component_name}.html.erb")
+          paths << sidecar if File.exist?(sidecar)
+          paths.concat(Dir.glob(File.join(sidecar_dir, "#{component_name}.*.html.erb")))
+          paths
         end
 
         # Extract method calls from an ERB template
@@ -49,7 +49,7 @@ module RuboCop
 
           # Parse the extracted Ruby code
           parse_ruby_for_method_calls(ruby_code)
-        rescue => e
+        rescue StandardError => e
           # Graceful degradation on parse errors
           warn "Warning: Failed to parse template #{template_path}: #{e.message}" if ENV["RUBOCOP_DEBUG"]
           Set.new
@@ -78,7 +78,7 @@ module RuboCop
           return unless node.respond_to?(:type)
 
           # Look for send nodes with nil receiver (local method calls)
-          if node.type == :send && node.receiver.nil?
+          if node.send_type? && node.receiver.nil?
             method_name = node.method_name
             method_calls.add(method_name)
           end

data/lib/rubocop/cop/view_component/test_rendered_output.rb

@@ -28,6 +28,7 @@ module RuboCop
         # Check Minitest-style test methods
         def on_def(node)
           return unless within_test_paths?
+
           method_name = node.method_name.to_s
           return unless method_name.start_with?("test_")
           return unless instantiates_component?(node)
@@ -45,6 +46,7 @@ module RuboCop
 
           add_offense(node)
         end
+        alias on_numblock on_block
 
         private
 
@@ -58,7 +60,7 @@ module RuboCop
 
         def instantiates_component?(node)
           node.each_descendant(:send).any? do |send_node|
-            next unless send_node.method_name == :new
+            next unless send_node.method?(:new)
 
             send_node.receiver&.const_type?
           end

data/lib/rubocop/view_component/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module ViewComponent
-    VERSION = "0.5.1"
+    VERSION = "0.6.0"
   end
 end

data/script/verify

@@ -68,8 +68,8 @@ def parse_library_arg(libraries)
   library_arg = ARGV.find { |arg| !arg.start_with?("--") }
 
   if library_arg.nil?
-    abort "Usage: #{$PROGRAM_NAME} <library> [--regenerate] [--update]\n" \
-          "  library: #{libraries.keys.join(", ")}"
+    abort "Usage: #{$PROGRAM_NAME} <library> [--regenerate] [--update]\n  " \
+          "library: #{libraries.keys.join(", ")}"
   end
 
   unless libraries.key?(library_arg)
@@ -79,8 +79,8 @@ def parse_library_arg(libraries)
   library_arg
 end
 
-def system!(*args)
-  system(*args, exception: true)
+def system!(*)
+  system(*, exception: true)
 end
 
 def download_source(dir, tarball_url, display_name)
@@ -97,10 +97,10 @@ def configure_rubocop(config_file, display_name)
   # Merge the library config into the existing config
   library_config.each do |key, value|
     config[key] = if config[key].is_a?(Hash) && value.is_a?(Hash)
-      config[key].merge(value)
-    else
-      value
-    end
+                    config[key].merge(value)
+                  else
+                    value
+                  end
   end
 
   File.write(".rubocop.yml", YAML.dump(config))
@@ -118,16 +118,15 @@ def run_rubocop
   puts "Running RuboCop (ViewComponent cops only)..."
   output, status = Open3.capture2(
     "bundle", "exec", "rubocop",
-    "--require", "rubocop-view_component",
+    "--plugin", "rubocop-view_component",
     "--only", "ViewComponent",
+    "--config", ".rubocop.yml",
     "--format", "json"
   )
 
   puts "RuboCop exit status: #{status.exitstatus}"
 
-  if output.strip.empty?
-    abort "ERROR: RuboCop produced no output (exit status: #{status.exitstatus})"
-  end
+  abort "ERROR: RuboCop produced no output (exit status: #{status.exitstatus})" if output.strip.empty?
 
   output
 end
@@ -166,11 +165,9 @@ def load_expected(results_file)
 end
 
 def verify(offenses, results_file)
-  unless File.exist?(results_file)
-    abort "ERROR: #{results_file} not found. Run '#{$PROGRAM_NAME} --regenerate' first."
-  end
+  abort "ERROR: #{results_file} not found. Run '#{$PROGRAM_NAME} --regenerate' first." unless File.exist?(results_file)
 
-  expected = load_expected(results_file)
+  expected = load_expected(results_file) || {}
 
   if offenses == expected
     puts "Verification passed: output matches #{results_file}"

data/spec/expected_polaris_failures.yml

@@ -22,7 +22,6 @@ ViewComponent/MissingPreview:
   - 'app/components/polaris/placeholder_component.rb'
   - 'app/components/polaris/shopify_navigation_component.rb'
   - 'app/components/polaris/text_field_component.rb'
-  - 'app/components/polaris/toast_component.rb'
 ViewComponent/NoGlobalState:
   - 'app/components/polaris/shopify_navigation_component.rb'
 ViewComponent/PreferPrivateMethods:

data/spec/rubocop/cop/view_component/component_suffix_spec.rb

@@ -74,11 +74,11 @@ RSpec.describe RuboCop::Cop::ViewComponent::ComponentSuffix, :config do
     end
   end
 
-  context "when ViewComponentParentClasses is configured" do
+  context "when ViewComponentParentClasses is configured with merge" do
     let(:config) do
       RuboCop::Config.new(
         "ViewComponent/ComponentSuffix" => {
-          "ViewComponentParentClasses" => ["Primer::Component"]
+          "ViewComponentParentClasses" => ["ViewComponent::Base", "ApplicationComponent", "Primer::Component"]
         }
       )
     end
@@ -107,6 +107,31 @@ RSpec.describe RuboCop::Cop::ViewComponent::ComponentSuffix, :config do
     end
   end
 
+  context "when ViewComponentParentClasses is configured replacing defaults" do
+    let(:config) do
+      RuboCop::Config.new(
+        "ViewComponent/ComponentSuffix" => {
+          "ViewComponentParentClasses" => ["Primer::Component"]
+        }
+      )
+    end
+
+    it "registers an offense for classes inheriting from a configured parent" do
+      expect_offense(<<~RUBY)
+        class FooBar < Primer::Component
+              ^^^^^^ ViewComponent class names should end with `Component`.
+        end
+      RUBY
+    end
+
+    it "does not recognize default parent classes that were replaced" do
+      expect_no_offenses(<<~RUBY)
+        class FooBar < ViewComponent::Base
+        end
+      RUBY
+    end
+  end
+
   context "with compact nested class syntax" do
     it "registers offense for compact syntax" do
       expect_offense(<<~RUBY)

data/spec/rubocop/cop/view_component/missing_preview_spec.rb

@@ -5,14 +5,16 @@ RSpec.describe RuboCop::Cop::ViewComponent::MissingPreview, :config do
     RuboCop::Config.new(
       "ViewComponent/MissingPreview" => {
         "Enabled" => true,
-        "PreviewPaths" => ["/previews"]
+        "PreviewPaths" => ["/previews"],
+        "ViewComponentParentClasses" => %w[ViewComponent::Base ApplicationComponent]
       }
     )
   end
 
   context "when a preview file exists" do
     it "does not register an offense" do
-      allow(File).to receive(:exist?).and_return(true)
+      allow(File).to receive(:exist?).and_return(false)
+      allow(File).to receive(:exist?).with("/previews/user_preview.rb").and_return(true)
 
       expect_no_offenses(<<~RUBY, "/app/components/user_component.rb")
         class UserComponent < ViewComponent::Base
@@ -23,7 +25,8 @@ RSpec.describe RuboCop::Cop::ViewComponent::MissingPreview, :config do
 
   context "when no preview file exists" do
     it "registers an offense" do
-      allow(File).to receive(:exist?).and_return(false)
+      allow(File).to receive(:exist?).with("/previews/user_preview.rb").and_return(false)
+      allow(File).to receive(:exist?).with("/previews/user_component_preview.rb").and_return(false)
 
       expect_offense(<<~RUBY, "/app/components/user_component.rb")
         class UserComponent < ViewComponent::Base
@@ -45,7 +48,10 @@ RSpec.describe RuboCop::Cop::ViewComponent::MissingPreview, :config do
     end
 
     it "registers an offense for a component in a configured namespace" do
-      allow(File).to receive(:exist?).and_return(false)
+      allow(File).to receive(:exist?).with("/previews/v2/table_preview.rb").and_return(false)
+      allow(File).to receive(:exist?).with("/previews/v2/table_component_preview.rb").and_return(false)
+      allow(File).to receive(:exist?).with("/previews/table_preview.rb").and_return(false)
+      allow(File).to receive(:exist?).with("/previews/table_component_preview.rb").and_return(false)
 
       expect_offense(<<~RUBY, "/app/components/v2/table.rb")
         class V2::Table < SomeBase
@@ -82,16 +88,129 @@ RSpec.describe RuboCop::Cop::ViewComponent::MissingPreview, :config do
         end
       RUBY
     end
+
+    it "registers an offense for a component declared with nested module form when no preview exists" do
+      allow(File).to receive(:exist?).and_return(false)
+
+      expect_offense(<<~RUBY, "/app/components/v2/table.rb")
+        module V2
+          class Table < SomeBase
+                ^^^^^ No preview found for V2::Table (looked in: /previews).
+          end
+        end
+      RUBY
+    end
+
+    it "does not register an offense for a component declared with nested module form when preview exists" do
+      allow(File).to receive(:exist?).and_return(false)
+      allow(File).to receive(:exist?).with("/previews/v2/grouped_multi_select_preview.rb").and_return(true)
+
+      expect_no_offenses(<<~RUBY, "/app/components/v2/grouped_multi_select.rb")
+        module V2
+          class GroupedMultiSelect < V2::MultiSelect
+          end
+        end
+      RUBY
+    end
   end
 
-  context "when not a ViewComponent" do
-    it "does not register an offense" do
+  context "when the component is declared with nested module form" do
+    it "does not register an offense when preview exists at the namespaced path" do
+      allow(File).to receive(:exist?).and_return(false)
+      allow(File).to receive(:exist?).with("/previews/admin/page_component_preview.rb").and_return(true)
+
+      expect_no_offenses(<<~RUBY, "/app/components/admin/page_component.rb")
+        module Admin
+          class PageComponent < ApplicationComponent
+          end
+        end
+      RUBY
+    end
+
+    it "registers an offense when no preview exists" do
       allow(File).to receive(:exist?).and_return(false)
 
+      expect_offense(<<~RUBY, "/app/components/admin/page_component.rb")
+        module Admin
+          class PageComponent < ApplicationComponent
+                ^^^^^^^^^^^^^ No preview found for Admin::PageComponent (looked in: /previews).
+          end
+        end
+      RUBY
+    end
+  end
+
+  context "when the namespace contains an acronym" do
+    it "does not register an offense when preview exists at the correct path" do
+      ActiveSupport::Inflector.inflections(:en) { |i| i.acronym "UI" }
+
+      allow(File).to receive(:exist?).and_return(false)
+      allow(File).to receive(:exist?).with("/previews/ui/button_component_preview.rb").and_return(true)
+
+      expect_no_offenses(<<~RUBY, "/app/components/ui/button_component.rb")
+        module UI
+          class ButtonComponent < ViewComponent::Base
+          end
+        end
+      RUBY
+    end
+  end
+
+  context "when not a ViewComponent" do
+    it "does not register an offense" do
       expect_no_offenses(<<~RUBY, "/app/components/user_component.rb")
         class UserComponent
         end
       RUBY
     end
   end
+
+  context "when the class is itself a registered parent class" do
+    it "does not register an offense for a built-in parent class" do
+      expect_no_offenses(<<~RUBY, "/app/components/application_component.rb")
+        class ApplicationComponent < ViewComponent::Base
+        end
+      RUBY
+    end
+
+    context "when a custom parent class is configured" do
+      let(:config) do
+        RuboCop::Config.new(
+          "ViewComponent/MissingPreview" => {
+            "Enabled" => true,
+            "PreviewPaths" => ["/previews"],
+            "ViewComponentParentClasses" => %w[ViewComponent::Base ApplicationComponent BaseComponent]
+          }
+        )
+      end
+
+      it "does not register an offense for the custom parent class" do
+        expect_no_offenses(<<~RUBY, "/app/components/base_component.rb")
+          class BaseComponent < ViewComponent::Base
+          end
+        RUBY
+      end
+    end
+
+    context "when a namespaced custom parent class is configured" do
+      let(:config) do
+        RuboCop::Config.new(
+          "ViewComponent/MissingPreview" => {
+            "Enabled" => true,
+            "PreviewPaths" => ["/previews"],
+            "ViewComponentParentClasses" => %w[ViewComponent::Base ApplicationComponent MyApp::BaseComponent]
+          }
+        )
+      end
+
+      it "does not register an offense for the namespaced custom parent class" do
+        expect_no_offenses(<<~RUBY, "/app/components/my_app/base_component.rb")
+          module MyApp
+            class BaseComponent < ViewComponent::Base
+            end
+          end
+        RUBY
+      end
+    end
+  end
 end

data/spec/rubocop/cop/view_component/no_global_state_spec.rb

@@ -105,6 +105,19 @@ RSpec.describe RuboCop::Cop::ViewComponent::NoGlobalState, :config do
     end
   end
 
+  context "with Sorbet signatures" do
+    it "does not register offense for params in sig block" do
+      expect_no_offenses(<<~RUBY)
+        class UserComponent < ViewComponent::Base
+          sig { params(descriptor: String, admin_view: T::Boolean).returns(T.nilable(String)) }
+          def call(descriptor:, admin_view:)
+            @descriptor = descriptor
+          end
+        end
+      RUBY
+    end
+  end
+
   context "when not in a ViewComponent" do
     it "does not register offense in regular classes" do
       expect_no_offenses(<<~RUBY)

data/spec/rubocop/cop/view_component/prefer_private_methods_spec.rb

@@ -144,10 +144,11 @@ RSpec.describe RuboCop::Cop::ViewComponent::PreferPrivateMethods, :config do
     context "with custom patterns" do
       let(:config) do
         RuboCop::Config.new(
-          "AllCops" => {"DisplayCopNames" => true},
+          "AllCops" => { "DisplayCopNames" => true },
           "ViewComponent/PreferPrivateMethods" => {
             "AllowedPublicMethods" => %w[initialize call],
-            "AllowedPublicMethodPatterns" => ["^render_", "^with_"]
+            "AllowedPublicMethodPatterns" => ["^render_", "^with_"],
+            "ViewComponentParentClasses" => %w[ViewComponent::Base ApplicationComponent]
           }
         )
       end
@@ -186,10 +187,11 @@ RSpec.describe RuboCop::Cop::ViewComponent::PreferPrivateMethods, :config do
   context "with custom AllowedPublicMethods" do
     let(:config) do
       RuboCop::Config.new(
-        "AllCops" => {"DisplayCopNames" => true},
+        "AllCops" => { "DisplayCopNames" => true },
         "ViewComponent/PreferPrivateMethods" => {
           "AllowedPublicMethods" => %w[initialize call custom_public_method],
-          "AllowedPublicMethodPatterns" => []
+          "AllowedPublicMethodPatterns" => [],
+          "ViewComponentParentClasses" => %w[ViewComponent::Base ApplicationComponent]
         }
       )
     end
@@ -261,7 +263,7 @@ RSpec.describe RuboCop::Cop::ViewComponent::PreferPrivateMethods, :config do
   context "with template files" do
     let(:component_file) { "spec/fixtures/components/template_method_component.rb" }
 
-    it "does not flag methods called in template, but flags unused methods" do
+    it "registers methods called in template, but flags unused methods" do
       expect_offense(<<~RUBY, component_file)
         # frozen_string_literal: true
 

data/spec/rubocop/cop/view_component/test_rendered_output_spec.rb

@@ -99,7 +99,7 @@ RSpec.describe RuboCop::Cop::ViewComponent::TestRenderedOutput, :config do
   context "with TestPaths configured" do
     let(:config) do
       RuboCop::Config.new(
-        "AllCops" => {"DisplayCopNames" => true},
+        "AllCops" => { "DisplayCopNames" => true },
         "ViewComponent/TestRenderedOutput" => {
           "TestPaths" => ["spec/components/v2/"]
         }

data/verification/govuk_rubocop_config.yml

@@ -1,4 +1,7 @@
 ViewComponent:
+  inherit_mode:
+    merge:
+      - ViewComponentParentClasses
   ViewComponentParentClasses:
     - GovukComponent::Base
 

data/verification/polaris_rubocop_config.yml

@@ -1,4 +1,7 @@
 ViewComponent:
+  inherit_mode:
+    merge:
+      - ViewComponentParentClasses
   ViewComponentParentClasses:
     - Polaris::Component
     - Component

data/verification/primer_rubocop_config.yml

@@ -1,4 +1,7 @@
 ViewComponent:
+  inherit_mode:
+    merge:
+      - ViewComponentParentClasses
   ViewComponentParentClasses:
     - Primer::Component
     - Primer::BaseComponent

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-view_component
 version: !ruby/object:Gem::Version
-  version: 0.5.1
+  version: 0.6.0
 platform: ruby
 authors:
 - Andy Waite
@@ -9,6 +9,20 @@ bindir: exe
 cert_chain: []
 date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: activesupport
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: herb
   requirement: !ruby/object:Gem::Requirement
@@ -118,6 +132,7 @@ metadata:
   homepage_uri: https://github.com/andyw8/rubocop-view_component
   source_code_uri: https://github.com/andyw8/rubocop-view_component
   default_lint_roller_plugin: RuboCop::ViewComponent::Plugin
+  rubygems_mfa_required: 'true'
 rdoc_options: []
 require_paths:
 - lib
@@ -125,7 +140,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.7.0
+      version: 3.2.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="