rubocop-vicenzo 0.4.0 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2caba14e7971e328ef6fc5c5fb203fe11a26cbd1f78f534f223f01f9d99c240f
-  data.tar.gz: 2eb689487018dfa035aff365831cc219cf71dfce583885639656f314fbcffc82
+  metadata.gz: a18abf5413cb9807bf31adf6adeb6ac47e3fd0e7ec8cb2d47217db9b1617ed40
+  data.tar.gz: 871b1cb1de89c418517b67919402004ea95044aad2b1a8a0602ceb29953d1093
 SHA512:
-  metadata.gz: e1c048efe4a3c8b7f7de35d8fcbe76908efcceb50bf053df761e59d53ea8fa9d74f779f223bb0d6e6ff1274e4ec2c83daf9a561084f970cdd5a48c8b7d4f7dce
-  data.tar.gz: f8c2f91bd54d5845ae68928a5ff783f6b161a47ca0e2e1d0afdc177473761416487d2e0d5c984f9b6d064a98ef3cc64db98baf3454f3989be19bb146172a3620
+  metadata.gz: c629161e84a929d57e0ef7fdec80d17a21742adc08c7f1bafb601356815e99862d987806bfced0e88fb5d1c085af35a4f0e6039dde7cdd664c635a51e9984110
+  data.tar.gz: 05ddcb76888e50820eda315fa63087c12a01ace730090bd5250f363a2a01b46e8277342ff903d371a5b5d6a0d8c9abcf28023a88caca421c7bfca558acbae110

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 ## [Unreleased]
 
+## [0.5.0] - 2026-06-29
+
+- Add RuboCop::Cop::Vicenzo::Style::JsonParseSymbolizeNames #23;
+
 ## [0.4.0] - 2026-03-28
 
 - Add RuboCop::Cop::Vicenzo::RSpec::ConditionalInSpec #19;

data/antora-playbook.yml

@@ -1,6 +1,7 @@
 site:
   title: RuboCop Vicenzo
   url: https://bvicenzo.github.io/rubocop-vicenzo
+  start_page: rubocop-vicenzo::index.adoc
 
 content:
   sources:

data/config/default.yml

@@ -69,6 +69,12 @@ Vicenzo/RSpec/LeakyDefinition:
     - '**/spec/support/**/*'
     - '**/spec/factories/**/*'
 
+Vicenzo/Style/JsonParseSymbolizeNames:
+  Description: 'Enforces passing `symbolize_names: true` to `JSON.parse` so keys are symbols.'
+  Enabled: true
+  Severity: convention
+  VersionAdded: '0.5.0'
+
 Vicenzo/Style/MultilineMethodCallParentheses:
   Description: 'Enforces parentheses for method calls with arguments that span multiple lines.'
   Enabled: true

data/lib/rubocop/cop/vicenzo/style/json_parse_symbolize_names.rb

@@ -0,0 +1,74 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Vicenzo
+      module Style
+        # Enforces passing `symbolize_names: true` to `JSON.parse` so the
+        # resulting hash uses symbol keys instead of strings.
+        #
+        # An explicit `symbolize_names: false` is treated as a deliberate
+        # opt-out and is allowed. Calls whose options cannot be analyzed
+        # statically (a variable, splat, or double splat) are ignored to
+        # avoid false positives.
+        #
+        # @example
+        #   # bad
+        #   JSON.parse(payload)
+        #
+        #   # bad
+        #   JSON.parse(payload, max_nesting: 5)
+        #
+        #   # good
+        #   JSON.parse(payload, symbolize_names: true)
+        #
+        #   # good (deliberate opt-out)
+        #   JSON.parse(payload, symbolize_names: false)
+        class JsonParseSymbolizeNames < Base
+          MSG = 'Pass `symbolize_names: true` to `JSON.parse` so keys are symbols. ' \
+                'Only when string keys are truly required, set `symbolize_names: false` explicitly.'
+
+          RESTRICT_ON_SEND = [:parse].freeze
+
+          # @!method json_parse?(node)
+          def_node_matcher :json_parse?, <<~PATTERN
+            (send (const {nil? cbase} :JSON) :parse ...)
+          PATTERN
+
+          def on_send(node)
+            return unless json_parse?(node)
+
+            add_offense(node) if missing_symbolize_names?(node)
+          end
+          alias on_csend on_send
+
+          private
+
+          def missing_symbolize_names?(node)
+            return false if node.arguments.any?(&:splat_type?)
+
+            options = options_hash(node)
+            return node.arguments.one? if options.nil?
+            return false if options.children.any?(&:kwsplat_type?)
+
+            !symbolize_names?(options)
+          end
+
+          # The options hash is the last argument when it is a hash literal
+          # (covers both `{ ... }` and trailing keyword arguments). A non-hash
+          # last argument (e.g. a variable) means we cannot inspect it.
+          def options_hash(node)
+            last_argument = node.last_argument
+            return unless last_argument&.hash_type?
+
+            last_argument
+          end
+
+          def symbolize_names?(options)
+            options.each_pair.any? { |pair| pair.key.sym_type? && pair.key.value == :symbolize_names }
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/vicenzo_cops.rb

@@ -10,4 +10,5 @@ require_relative 'vicenzo/rspec/nested_subject_redefinition'
 require_relative 'vicenzo/rspec/leaky_definition'
 require_relative 'vicenzo/rails/enum_inclusion_of_validation'
 require_relative 'vicenzo/layout/multiline_method_call_line_breaks'
+require_relative 'vicenzo/style/json_parse_symbolize_names'
 require_relative 'vicenzo/style/multiline_method_call_parentheses'

data/lib/rubocop/vicenzo/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module Vicenzo
-    VERSION = '0.4.0'
+    VERSION = '0.5.0'
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-vicenzo
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.5.0
 platform: ruby
 authors:
 - Bruno Vicenzo
@@ -81,6 +81,7 @@ files:
 - lib/rubocop/cop/vicenzo/rspec/nested_context_improper_start.rb
 - lib/rubocop/cop/vicenzo/rspec/nested_let_redefinition.rb
 - lib/rubocop/cop/vicenzo/rspec/nested_subject_redefinition.rb
+- lib/rubocop/cop/vicenzo/style/json_parse_symbolize_names.rb
 - lib/rubocop/cop/vicenzo/style/multiline_method_call_parentheses.rb
 - lib/rubocop/cop/vicenzo_cops.rb
 - lib/rubocop/vicenzo.rb