rubocop-vendor 0.9.2 → 0.11.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3aaeec03267633acaabb79d26b67a746cbf6f6c948caf17a23d09f849c848e28
-  data.tar.gz: ae8181215d4429dc949c8be90b2bed61edc6537a5594d303abf464609cc6020a
+  metadata.gz: f69fd94e8d9429fec0334913a5d2bcfa8f2e2873e777ec17879a37d0ca044eb6
+  data.tar.gz: 6a012a6071337d04d50cefd51ddc07c63abe07f96f70eae9acd094e9a8d8ee27
 SHA512:
-  metadata.gz: ab196d519384425d33f216d7d62c92f3d0f78a57784375ffebb920810cb40ad4e0120c1bdd9a82e0ac6192697b7e93ae0d0c4ce6866f1f945eefc35be184fd85
-  data.tar.gz: 5cd67595559509195643f091ef0ee35cde3e67b9b11e128360cbd76e6d0c087b568efe3055fc78a5b61aff7ab0726cb5ad6fb4da8ef246960896a22f8b0218dc
+  metadata.gz: 6406158144116b3cc61af8e30c8e68c2285073b8eb5ed0ed2fba58f7570a3c5d73732a1ed331beb1333957e08606228faefc1bd1803fdac34d2ab903015d8008
+  data.tar.gz: 470e41a804dba4c86ac1b8654a2204fdf4de33dec852d1c185e98b9fbc2f509cf28e7eec4a7fed575374c0cf23cc45cb19ffb30abc2caa6fb89f9b4898c0730d

data/lib/rubocop/cop/vendor/active_record_connection_execute.rb

@@ -0,0 +1,44 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Vendor
+      # This cop checks for `ActiveRecord::Connection#execute` usage and suggests
+      # using non-manually memory managed objects instead.
+      #
+      # The main reason for this is this is a common way to leak memory in a Ruby on Rails application.
+      # see {
+      # https://github.com/rails/rails/blob/a19b13b61f7af612569943ec7d536185cbec875c/activerecord/lib/active_record/connection_adapters/abstract/database_statements.rb#L127
+      # ActiveRecord documentation
+      # }.
+      #
+      # @example
+      #   # bad
+      #   ActiveRecord::Base.connection.execute('SELECT * FROM users')
+      #   ApplicationRecord.connection.execute('SELECT * FROM users')
+      #   User.connection.execute('SELECT * FROM users')
+      #
+      #   # good
+      #   ActiveRecord::Base.connection.select_all('SELECT * FROM users')
+      #   ApplicationRecord.connection.select_all('SELECT * FROM users')
+      #   User.connection.select_all('SELECT * FROM users')
+      #
+      class ActiveRecordConnectionExecute < Base
+        MSG = <<-STR.strip
+          Use of `ActiveRecord::Connection#execute` returns manually memory managed object, consider using `select_one`, `select_all`, `insert`, `update`, `delete`. If necessary, you can also use `exec_query`, `exec_insert`, `exec_update`, `exec_delete`.
+        STR
+
+        # @!method connection_execute_method_call?(node)
+        def_node_matcher :connection_execute_method_call?, <<-PATTERN
+          (send (send _ :connection) :execute ...)
+        PATTERN
+
+        def on_send(node)
+          return unless connection_execute_method_call?(node)
+
+          add_offense(node)
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/vendor/sidekiq_throttled_gem.rb

@@ -0,0 +1,36 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Vendor
+      # This cop flags uses of the sidekiq-throttled gem.
+      #
+      # sidekiq-throttled overrides sidekiq-pro and sidekiq-enterprise features,
+      # resulting in at-most once delivery of sidekiq jobs, instead of at-least once delivery
+      # of sidekiq jobs. This means there is a relatively good chance you will LOSE JOBS that were enqueued
+      # if the sidekiq-process runs out of memory or does not shutdown gracefully.
+      #
+      # https://wealthsimple.slack.com/archives/C19UB3HNZ/p1683721247371709 for more details
+      class SidekiqThrottledGem < Base
+        MSG = <<~MSG.strip
+          Do not use the sidekiq-throttled gem. sidekiq-throttled overrides the fetcher of sidekiq-pro and sidekiq-enterprise resulting in the ability to lose jobs (switch to at-most once processing).
+        MSG
+
+        def on_new_investigation
+          return if processed_source.blank?
+
+          gem_declarations(processed_source.ast).each do |declaration|
+            next unless declaration.first_argument.str_content.match?('sidekiq-throttled')
+
+            add_offense(declaration)
+          end
+        end
+
+        # @!method gem_declarations(node)
+        def_node_search :gem_declarations, <<~PATTERN
+          (:send nil? :gem str ...)
+        PATTERN
+      end
+    end
+  end
+end

data/lib/rubocop/cop/vendor_cops.rb

@@ -3,7 +3,9 @@
 module RuboCop
 end
 
+require_relative 'vendor/active_record_connection_execute'
 require_relative 'vendor/recursive_open_struct_gem'
+require_relative 'vendor/sidekiq_throttled_gem'
 require_relative 'vendor/recursive_open_struct_use'
 require_relative 'vendor/rollbar_inside_rescue'
 require_relative 'vendor/rollbar_interpolation'

data/lib/rubocop/vendor/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module Vendor
-    VERSION = '0.9.2'
+    VERSION = '0.11.0'
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-vendor
 version: !ruby/object:Gem::Version
-  version: 0.9.2
+  version: 0.11.0
 platform: ruby
 authors:
 - Danilo Cabello
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-04-14 00:00:00.000000000 Z
+date: 2023-05-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -82,6 +82,7 @@ files:
 - README.md
 - config/default.yml
 - lib/rubocop-vendor.rb
+- lib/rubocop/cop/vendor/active_record_connection_execute.rb
 - lib/rubocop/cop/vendor/base.rb
 - lib/rubocop/cop/vendor/recursive_open_struct_gem.rb
 - lib/rubocop/cop/vendor/recursive_open_struct_use.rb
@@ -90,6 +91,7 @@ files:
 - lib/rubocop/cop/vendor/rollbar_log.rb
 - lib/rubocop/cop/vendor/rollbar_logger.rb
 - lib/rubocop/cop/vendor/rollbar_with_exception.rb
+- lib/rubocop/cop/vendor/sidekiq_throttled_gem.rb
 - lib/rubocop/cop/vendor/strict_dry_struct.rb
 - lib/rubocop/cop/vendor_cops.rb
 - lib/rubocop/vendor.rb