rubocop-thread_safety 0.3.0 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 88d48cd3238f82a82b8fb0a8a29543e111ff34f5
-  data.tar.gz: 2a150df94ee24d94dc9173fa13837bcd82044590
+SHA256:
+  metadata.gz: 33c8f2c01aa5f51c5ae09093a3ebb895a764330600ef32c05995836891cc1bd2
+  data.tar.gz: 5d4bc3124aff9203407cb61b000564084962e0ad18d72fff954d0994eb944276
 SHA512:
-  metadata.gz: 13c4f7b7cb97c02a1cd0e7cb33bb87453ee3b3e5e9bb826c936f2f266c7536ce3ce4234e6c6dd50bc742089604efbe8c7fcc77a21cb9bcda712fb78533e24fb3
-  data.tar.gz: bdb1ec4b1c42ec44f29c272a0cfaf27226d2b961822eeb64eb2462be22d537b9fb8329dd6045ec7619414a4da7bc012cdd81afdb3f398e58f7a78359d5ac601e
+  metadata.gz: 130074abe1ba664fad05877bf2f215ed6965a8da36a92ba8865d05305c1f3661d9f2acfe67836620446c43bee81b3819111c764f37cbe2506474de3b0597de87
+  data.tar.gz: ed769cdad040ba59dba88a68af2cadbf04e3eaedd1c389261050cd0917ec4a629b775798c20d3e893650796deea250dc01c80c05a32d5c2c19151fd9d88667d0

data/.rubocop.yml

@@ -1,14 +1,14 @@
 AllCops:
   DisplayCopNames: true
-  Include:
-    - Gemfile
-    - Rakefile
+
+Metrics/BlockLength:
   Exclude:
-    - vendor/**/*
+    - "spec/**/*"
 
-Style/FileName:
+Naming/FileName:
   Exclude:
     - lib/rubocop-thread_safety.rb
+    - rubocop-thread_safety.gemspec
 
 # Enable more cops that are disabled by default:
 

data/.travis.yml

@@ -2,18 +2,14 @@ sudo: false
 cache: bundler
 language: ruby
 rvm:
-  - 2.0.0
-  - 2.1
-  - 2.2
+  - jruby-9.1.14.0
   - 2.3.0
-  - ruby-head
-  - jruby-9.0.1.0
-  - rbx-3
+  - 2.4
+  - 2.5
+  - 2.6
+  - 2.7
 
 matrix:
-  allow_failures:
-    - rvm: ruby-head
-    - rvm: rbx-3
   fast_finish: true
 
 before_install: gem install --remote bundler

data/Gemfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 # Specify your gem's dependencies in rubocop-thread_safety.gemspec

data/LICENSE.txt

@@ -0,0 +1,7 @@
+Copyright 2016-2020 CoverMyMeds
+
+Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

data/README.md

@@ -32,7 +32,7 @@ Install the gem:
 
 Scan the application for just thread-safety issues:
 
-    $ rubocop -r rubocop-thread_safety --only Threadsafety,Style/GlobalVars,Style/ClassVars,Style/MutableConstant
+    $ rubocop -r rubocop-thread_safety --only ThreadSafety,Style/GlobalVars,Style/ClassVars,Style/MutableConstant
 
 ## Development
 
@@ -44,3 +44,7 @@ To install this gem onto your local machine, run `bundle exec rake install`. To
 
 Bug reports and pull requests are welcome on GitHub at https://github.com/covermymeds/rubocop-thread_safety.
 
+## Copyright
+
+Copyright (c) 2016-2020 CoverMyMeds.
+See [LICENSE.txt](LICENSE.txt) for further details.

data/Rakefile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'bundler/gem_tasks'
 require 'rspec/core/rake_task'
 

data/bin/console

@@ -1,5 +1,7 @@
 #!/usr/bin/env ruby
 
+# frozen_string_literal: true
+
 require 'bundler/setup'
 require 'rubocop-thread_safety'
 

data/lib/rubocop-thread_safety.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rubocop'
 
 require 'rubocop/thread_safety/version'

data/lib/rubocop/cop/thread_safety/class_and_module_attributes.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop
@@ -14,23 +13,24 @@ module RuboCop
       #     cattr_accessor :current_user
       #   end
       class ClassAndModuleAttributes < Cop
-        MSG = 'Avoid mutating class and module attributes.'.freeze
+        MSG = 'Avoid mutating class and module attributes.'
 
-        def_node_matcher :mattr?, <<-END
-          (send nil
+        def_node_matcher :mattr?, <<-MATCHER
+          (send nil?
             {:mattr_writer :mattr_accessor :cattr_writer :cattr_accessor}
             ...)
-        END
+        MATCHER
 
-        def_node_matcher :attr?, <<-END
-          (send nil
+        def_node_matcher :attr?, <<-MATCHER
+          (send nil?
             {:attr :attr_accessor :attr_writer}
             ...)
-        END
+        MATCHER
 
         def on_send(node)
           return unless mattr?(node) || singleton_attr?(node)
-          add_offense(node, :expression, format(MSG, node.source))
+
+          add_offense(node, message: MSG)
         end
 
         private

data/lib/rubocop/cop/thread_safety/instance_variable_in_class_method.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop
@@ -15,13 +14,13 @@ module RuboCop
       #     end
       #   end
       class InstanceVariableInClassMethod < Cop
-        MSG = 'Avoid instance variables in class methods.'.freeze
+        MSG = 'Avoid instance variables in class methods.'
 
         def on_ivar(node)
           return unless class_method_definition?(node)
           return if synchronized?(node)
 
-          add_offense(node, :name, MSG)
+          add_offense(node, location: :name, message: MSG)
         end
         alias on_ivasgn on_ivar
 
@@ -44,23 +43,26 @@ module RuboCop
             ancestor.type == :def
           end
 
-          defn && defn.ancestors.any? do |ancestor|
+          defn&.ancestors&.any? do |ancestor|
             ancestor.type == :sclass
           end
         end
 
         def singleton_method_definition?(node)
           node.ancestors.any? do |ancestor|
-            next unless ancestor.children.first.is_a? Node
+            next unless ancestor.children.first.is_a? AST::SendNode
+
             ancestor.children.first.command? :define_singleton_method
           end
         end
 
         def synchronized?(node)
-          p = node.parent
-          return false unless p.block_type?
-          s = p.children.first
-          s.send_type? && s.children.last == :synchronize
+          node.ancestors.find do |ancestor|
+            next unless ancestor.block_type?
+
+            s = ancestor.children.first
+            s.send_type? && s.children.last == :synchronize
+          end
         end
       end
     end

data/lib/rubocop/cop/thread_safety/new_thread.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 module RuboCop
@@ -12,15 +11,16 @@ module RuboCop
       #   # bad
       #   Thread.new { do_work }
       class NewThread < Cop
-        MSG = 'Avoid starting new threads.'.freeze
+        MSG = 'Avoid starting new threads.'
 
-        def_node_matcher :new_thread?, <<-END
-          (send (const nil :Thread) :new)
-        END
+        def_node_matcher :new_thread?, <<-MATCHER
+          (send (const nil? :Thread) :new)
+        MATCHER
 
         def on_send(node)
           return unless new_thread?(node)
-          add_offense(node, :expression, format(MSG, node.source))
+
+          add_offense(node, message: MSG)
         end
       end
     end

data/lib/rubocop/thread_safety/version.rb

@@ -1,5 +1,7 @@
+# frozen_string_literal: true
+
 module RuboCop
   module ThreadSafety
-    VERSION = '0.3.0'.freeze
+    VERSION = '0.4.0'
   end
 end

data/rubocop-thread_safety.gemspec

@@ -1,5 +1,6 @@
-# coding: utf-8
-lib = File.expand_path('../lib', __FILE__)
+# frozen_string_literal: true
+
+lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'rubocop/thread_safety/version'
 
@@ -10,21 +11,26 @@ Gem::Specification.new do |spec|
   spec.email         = ['michaelpgee@gmail.com']
 
   spec.summary       = 'Thread-safety checks via static analysis'
-  spec.description   = <<-end_description
+  spec.description   = <<-DESCRIPTION
     Thread-safety checks via static analysis.
     A plugin for the RuboCop code style enforcing & linting tool.
-  end_description
-  spec.homepage      = 'https://github.com/covermymeds/rubocop-thread_safety'
+  DESCRIPTION
+  spec.homepage = 'https://github.com/covermymeds/rubocop-thread_safety'
+  spec.licenses = ['MIT']
+
+  spec.files = `git ls-files -z`.split("\x0").reject do |f|
+    f.match(%r{^(test|spec|features)/})
+  end
 
-  spec.files         = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
   spec.bindir        = 'exe'
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
-  spec.add_runtime_dependency 'rubocop', '>= 0.41.1'
+  spec.add_runtime_dependency 'rubocop', '>= 0.51.0'
 
-  spec.add_development_dependency 'bundler', '~> 1.10'
-  spec.add_development_dependency 'rake', '~> 10.0'
-  spec.add_development_dependency 'rspec', '~> 3.0'
+  spec.add_development_dependency 'bundler', '>= 1.10', '< 3'
+  spec.add_development_dependency 'powerpack', '~> 0.1'
   spec.add_development_dependency 'pry' unless ENV['CI']
+  spec.add_development_dependency 'rake', '>= 10.0'
+  spec.add_development_dependency 'rspec', '~> 3.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-thread_safety
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors:
 - Michael Gee
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-10-01 00:00:00.000000000 Z
+date: 2020-06-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,70 +16,90 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.41.1
+        version: 0.51.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.41.1
+        version: 0.51.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '1.10'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '1.10'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '3'
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: powerpack
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '0.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '0.1'
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: pry
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '10.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '10.0'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.0'
 description: |2
       Thread-safety checks via static analysis.
       A plugin for the RuboCop code style enforcing & linting tool.
@@ -94,6 +114,7 @@ files:
 - ".rubocop.yml"
 - ".travis.yml"
 - Gemfile
+- LICENSE.txt
 - README.md
 - Rakefile
 - bin/console
@@ -105,7 +126,8 @@ files:
 - lib/rubocop/thread_safety/version.rb
 - rubocop-thread_safety.gemspec
 homepage: https://github.com/covermymeds/rubocop-thread_safety
-licenses: []
+licenses:
+- MIT
 metadata: {}
 post_install_message: 
 rdoc_options: []
@@ -122,10 +144,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.4.8
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Thread-safety checks via static analysis
 test_files: []
-has_rdoc: