rubocop-sorbet 0.7.5 → 0.7.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9b2451806224baad5c72fb848ae38e6510037b2e26415afc236c3639f8504655
-  data.tar.gz: e55c4a39d87a4fe345a6257e14483de155738ea5d39c25ef1e7822a2174321cb
+  metadata.gz: 8a1efe9f67422bb3173e5d5f91b3ccfd9f3862218af34495ca45e37be474ce6d
+  data.tar.gz: aeef803f94dd5084efa7d95cb1e899dd1e901b0a992acdb1e1bfe5b3613b78d7
 SHA512:
-  metadata.gz: d05d0627ce52223c931f3461e221f6cb105838c21eeae6d68a7270934e6e292fcd2a7390453583c95d721bc1544125cb74f2d65ef6161c4d8fe823c3ee8217e6
-  data.tar.gz: adf840bad5a49581286937604e83b3ee864f45031efb115db9faed9032da04d4178d7022b3d2040e08e8b10dc5f7a95bc8bf8a0ee1ac06ba74780b135d947b26
+  metadata.gz: 607f488db395a271ab0fe3997f710f1f275d04c62b0fdd00bfb3bf4b3ffbd0274315d65d284440078fe92415b3ba7b66f364de415af004ab45f745238081de31
+  data.tar.gz: d55d280a2c2404fe754bcb59445369b3c67c03329b4055700984e99effef6b6c53b7c44560925ee029f1a963649cbc65d30f49d30cb406fca7d92eafc83a6859

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    rubocop-sorbet (0.7.5)
+    rubocop-sorbet (0.7.7)
       rubocop (>= 0.90.0)
 
 GEM

data/README.md

@@ -69,6 +69,14 @@ inherit_gem:
 
 This will turn off default cops for `**/*.rbi` files and enable the RBI specific cops.
 
+You'll also need to add an entry to the main `.rubocop.yml` so that RBI files are included, e.g.:
+
+```yaml
+AllCops:
+  Include:
+    - "sorbet/rbi/shims/**/*.rbi"
+```
+
 ## The Cops
 All cops are located under [`lib/rubocop/cop/sorbet`](lib/rubocop/cop/sorbet), and contain examples/documentation.
 

data/config/default.yml

@@ -89,6 +89,11 @@ Sorbet/ForbidIncludeConstLiteral:
   VersionAdded: 0.2.0
   VersionChanged: 0.5.0
 
+Sorbet/ForbidTypeAliasedShapes:
+  Description: 'Forbids defining type aliases that contain shapes'
+  Enabled: false
+  VersionAdded: 0.7.6
+
 Sorbet/ForbidSuperclassConstLiteral:
   Description: 'Forbid superclasses which are non-literal constants.'
   Enabled: false
@@ -288,3 +293,8 @@ Sorbet/ValidSigil:
   - bin/**/*
   - db/**/*.rb
   - script/**/*
+
+Sorbet/VoidCheckedTests:
+  Description: 'Forbid `.void.checked(:tests)`'
+  Enabled: true
+  VersionAdded: 0.7.7

data/lib/rubocop/cop/sorbet/forbid_type_aliased_shapes.rb

@@ -0,0 +1,44 @@
+# frozen_string_literal: true
+
+require "rubocop"
+
+module RuboCop
+  module Cop
+    module Sorbet
+      # Disallows defining type aliases that contain shapes
+      #
+      # @example
+      #
+      #  # bad
+      #  Foo = T.type_alias { { foo: Integer } }
+      #
+      #  # good
+      #  class Foo
+      #    extend T::Sig
+      #
+      #    sig { params(foo: Integer).void }
+      #    def initialize(foo)
+      #      @foo = foo
+      #    end
+      #  end
+      class ForbidTypeAliasedShapes < RuboCop::Cop::Base
+        MSG = "Type aliases shouldn't contain shapes because of significant performance overhead"
+
+        # @!method shape_type_alias?(node)
+        def_node_matcher(:shape_type_alias?, <<-PATTERN)
+          (block
+            (send (const {nil? cbase} :T) :type_alias)
+            (args)
+            `hash
+          )
+        PATTERN
+
+        def on_block(node)
+          add_offense(node) if shape_type_alias?(node)
+        end
+
+        alias_method :on_numblock, :on_block
+      end
+    end
+  end
+end

data/lib/rubocop/cop/sorbet/signatures/signature_build_order.rb

@@ -23,11 +23,11 @@ module RuboCop
       #   # good
       #   sig { abstract.void }
       #
-      #  # bad
-      #  sig { returns(Integer).params(x: Integer) }
+      #   # bad
+      #   sig { returns(Integer).params(x: Integer) }
       #
-      #  # good
-      #  sig { params(x: Integer).returns(Integer) }
+      #   # good
+      #   sig { params(x: Integer).returns(Integer) }
       class SignatureBuildOrder < ::RuboCop::Cop::Cop # rubocop:todo InternalAffairs/InheritDeprecatedCopClass
         include SignatureHelp
 

data/lib/rubocop/cop/sorbet/signatures/void_checked_tests.rb

@@ -0,0 +1,85 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Sorbet
+      # Disallows the usage of `.void.checked(:tests)`.
+      #
+      # Using `.void` changes the value returned from the method, but only if
+      # runtime type checking is enabled for the method. Methods marked `.void`
+      # will return different values in tests compared with non-test
+      # environments. This is particularly troublesome if branching on the
+      # result of a `.void` method, because the returned value in test code
+      # will be the truthy `VOID` value, while the non-test return value may be
+      # falsy depending on the method's implementation.
+      #
+      # - Use `.returns(T.anything).checked(:tests)` to keep the runtime type
+      #   checking for the rest of the parameters.
+      # - Use `.void.checked(:never)` if you are on an older version of Sorbet
+      #   which does not have `T.anything` (meaning versions 0.5.10781 or
+      #   earlier. Versions released after 2023-04-14 include `T.anything`.)
+      #
+      # @example
+      #
+      #   # bad
+      #   sig { void.checked(:tests) }
+      #
+      #   # good
+      #   sig { void }
+      #   sig { returns(T.anything).checked(:tests) }
+      #   sig { void.checked(:never) }
+      class VoidCheckedTests < ::RuboCop::Cop::Base
+        include(RuboCop::Cop::RangeHelp)
+        include(RuboCop::Cop::Sorbet::SignatureHelp)
+        extend AutoCorrector
+
+        # @!method checked_tests(node)
+        def_node_search(:checked_tests, <<~PATTERN)
+          ({csend send} _ :checked (sym :tests))
+        PATTERN
+
+        MESSAGE =
+          "Returning `.void` from a sig marked `.checked(:tests)` means that the " \
+            "method will return a different value in non-test environments (possibly " \
+            "with different truthiness). Either use `.returns(T.anything).checked(:tests)` " \
+            "to keep checking in tests, or `.void.checked(:never)` to leave it untouched."
+        private_constant(:MESSAGE)
+
+        private def top_level_void(node)
+          return unless node.is_a?(RuboCop::AST::SendNode)
+
+          if node.method?(:void)
+            node
+          elsif (recv = node.receiver)
+            top_level_void(recv)
+          end
+        end
+
+        def on_signature(node)
+          checked_send = checked_tests(node).first
+          return unless checked_send
+
+          if (parent = node.parent) && (sibling_index = node.sibling_index)
+            later_siblings = parent.children[(sibling_index + 1)..]
+            if (def_node = later_siblings.find { |sibling| sibling.is_a?(RuboCop::AST::DefNode) })
+              # Sorbet requires that `initialize` methods return `.void`
+              # (A stylistic convention which happens to be enforced by Sorbet)
+              return if def_node.method?(:initialize)
+            end
+          end
+
+          void_send = top_level_void(node.body)
+
+          return unless void_send
+
+          add_offense(
+            void_send.selector,
+            message: MESSAGE,
+          ) do |corrector|
+            corrector.replace(void_send.selector, "returns(T.anything)")
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/sorbet_cops.rb

@@ -7,6 +7,7 @@ require_relative "sorbet/binding_constant_without_type_alias"
 require_relative "sorbet/constants_from_strings"
 require_relative "sorbet/forbid_superclass_const_literal"
 require_relative "sorbet/forbid_include_const_literal"
+require_relative "sorbet/forbid_type_aliased_shapes"
 require_relative "sorbet/forbid_untyped_struct_props"
 require_relative "sorbet/implicit_conversion_method"
 require_relative "sorbet/one_ancestor_per_line"
@@ -25,6 +26,7 @@ require_relative "sorbet/rbi/single_line_rbi_class_module_definitions"
 
 require_relative "sorbet/signatures/allow_incompatible_override"
 require_relative "sorbet/signatures/checked_true_in_signature"
+require_relative "sorbet/signatures/void_checked_tests"
 require_relative "sorbet/signatures/keyword_argument_ordering"
 require_relative "sorbet/signatures/signature_build_order"
 require_relative "sorbet/signatures/enforce_signatures"

data/lib/rubocop/sorbet/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module Sorbet
-    VERSION = "0.7.5"
+    VERSION = "0.7.7"
   end
 end

data/manual/cops.md

@@ -23,6 +23,7 @@ In the following section you find all available cops:
 * [Sorbet/ForbidTStruct](cops_sorbet.md#sorbetforbidtstruct)
 * [Sorbet/ForbidTUnsafe](cops_sorbet.md#sorbetforbidtunsafe)
 * [Sorbet/ForbidTUntyped](cops_sorbet.md#sorbetforbidtuntyped)
+* [Sorbet/ForbidTypeAliasedShapes](cops_sorbet.md#sorbetforbidtypealiasedshapes)
 * [Sorbet/ForbidUntypedStructProps](cops_sorbet.md#sorbetforbiduntypedstructprops)
 * [Sorbet/HasSigil](cops_sorbet.md#sorbethassigil)
 * [Sorbet/IgnoreSigil](cops_sorbet.md#sorbetignoresigil)
@@ -38,6 +39,7 @@ In the following section you find all available cops:
 * [Sorbet/TrueSigil](cops_sorbet.md#sorbettruesigil)
 * [Sorbet/TypeAliasName](cops_sorbet.md#sorbettypealiasname)
 * [Sorbet/ValidSigil](cops_sorbet.md#sorbetvalidsigil)
+* [Sorbet/VoidCheckedTests](cops_sorbet.md#sorbetvoidcheckedtests)
 
 <!-- END_COP_LIST -->
 

data/manual/cops_sorbet.md

@@ -496,6 +496,31 @@ sig { params(my_argument: String).void }
 def foo(my_argument); end
 ```
 
+## Sorbet/ForbidTypeAliasedShapes
+
+Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
+--- | --- | --- | --- | ---
+Disabled | Yes | No | 0.7.6 | -
+
+Disallows defining type aliases that contain shapes
+
+### Examples
+
+```ruby
+# bad
+Foo = T.type_alias { { foo: Integer } }
+
+# good
+class Foo
+  extend T::Sig
+
+  sig { params(foo: Integer).void }
+  def initialize(foo)
+    @foo = foo
+  end
+end
+```
+
 ## Sorbet/ForbidUntypedStructProps
 
 Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
@@ -715,12 +740,6 @@ Checks for the correct order of sig builder methods:
 - returns, or void
 - soft, checked, or on_failure
 
- # bad
- sig { returns(Integer).params(x: Integer) }
-
- # good
- sig { params(x: Integer).returns(Integer) }
-
 ### Examples
 
 ```ruby
@@ -729,6 +748,12 @@ sig { void.abstract }
 
 # good
 sig { abstract.void }
+
+# bad
+sig { returns(Integer).params(x: Integer) }
+
+# good
+sig { params(x: Integer).returns(Integer) }
 ```
 
 ## Sorbet/SingleLineRbiClassModuleDefinitions
@@ -859,3 +884,37 @@ MinimumStrictness | `nil` | String
 ExactStrictness | `nil` | String
 Include | `**/*.{rb,rbi,rake,ru}` | Array
 Exclude | `bin/**/*`, `db/**/*.rb`, `script/**/*` | Array
+
+## Sorbet/VoidCheckedTests
+
+Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
+--- | --- | --- | --- | ---
+Enabled | Yes | Yes  | 0.7.7 | -
+
+Disallows the usage of `.void.checked(:tests)`.
+
+Using `.void` changes the value returned from the method, but only if
+runtime type checking is enabled for the method. Methods marked `.void`
+will return different values in tests compared with non-test
+environments. This is particularly troublesome if branching on the
+result of a `.void` method, because the returned value in test code
+will be the truthy `VOID` value, while the non-test return value may be
+falsy depending on the method's implementation.
+
+- Use `.returns(T.anything).checked(:tests)` to keep the runtime type
+  checking for the rest of the parameters.
+- Use `.void.checked(:never)` if you are on an older version of Sorbet
+  which does not have `T.anything` (meaning versions 0.5.10781 or
+  earlier. Versions released after 2023-04-14 include `T.anything`.)
+
+### Examples
+
+```ruby
+# bad
+sig { void.checked(:tests) }
+
+# good
+sig { void }
+sig { returns(T.anything).checked(:tests) }
+sig { void.checked(:never) }
+```

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-sorbet
 version: !ruby/object:Gem::Version
-  version: 0.7.5
+  version: 0.7.7
 platform: ruby
 authors:
 - Ufuk Kayserilioglu
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2023-10-31 00:00:00.000000000 Z
+date: 2024-02-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -95,6 +95,7 @@ files:
 - lib/rubocop/cop/sorbet/forbid_t_struct.rb
 - lib/rubocop/cop/sorbet/forbid_t_unsafe.rb
 - lib/rubocop/cop/sorbet/forbid_t_untyped.rb
+- lib/rubocop/cop/sorbet/forbid_type_aliased_shapes.rb
 - lib/rubocop/cop/sorbet/forbid_untyped_struct_props.rb
 - lib/rubocop/cop/sorbet/implicit_conversion_method.rb
 - lib/rubocop/cop/sorbet/mixin/signature_help.rb
@@ -121,6 +122,7 @@ files:
 - lib/rubocop/cop/sorbet/signatures/enforce_signatures.rb
 - lib/rubocop/cop/sorbet/signatures/keyword_argument_ordering.rb
 - lib/rubocop/cop/sorbet/signatures/signature_build_order.rb
+- lib/rubocop/cop/sorbet/signatures/void_checked_tests.rb
 - lib/rubocop/cop/sorbet/type_alias_name.rb
 - lib/rubocop/cop/sorbet_cops.rb
 - lib/rubocop/sorbet.rb
@@ -154,7 +156,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.21
+rubygems_version: 3.5.6
 signing_key: 
 specification_version: 4
 summary: Automatic Sorbet code style checking tool.