rubocop-sorbet 0.7.1 → 0.7.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c0d4456bcb92b2f40f1208842fce6a102f6ce2ba88ff491840d77a3001784677
-  data.tar.gz: 5e389a2c6c772f68aaf95555da670732ac70a9c5262be18c0418e0d787feb5de
+  metadata.gz: a0c73cc4c4d3b4982d210699da94d0dca321a93bf95e98579dc32521714e2921
+  data.tar.gz: b9aa475dea9aa87511868680e92fb1ad5dff83a5b8186439179c17371eaf35f5
 SHA512:
-  metadata.gz: c2cb4129f91d6c52aa3affe2728a9c049635ce9ccefdcaa86520bbf0a1d25b7160a3d253597329008661f4207bf953ec36058c3908874b6f9077da0742a9f15f
-  data.tar.gz: c4736a927b8f377f81bf7982e9a6d6fa4669b6ebc7dea5c60bba7a8e54adc843f096c8bfe6a0eea7fc47e34cc4374c4675495936d5c9b1289a17b2d226c44375
+  metadata.gz: 03a722e469cf1796ba965b044475dabbbe2d99a6b0b79efc083d605bd8dd0973ed1d320dbe511241dd6bfad3c9df7acb6354217ded268db5939ad7f8bf7684aa
+  data.tar.gz: 9fd995f27b0881e5ec939da2b0b1a87372bc910faa4f27cbaf0de43c367d877e1c5b077397f80130ec58f1caa7b6047a7c51ea1eb0872f194f118ce27dbfa10d

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    rubocop-sorbet (0.7.1)
+    rubocop-sorbet (0.7.3)
       rubocop (>= 0.90.0)
 
 GEM

data/lib/rubocop/cop/sorbet/sigils/valid_sigil.rb

@@ -51,7 +51,7 @@ module RuboCop
         protected
 
         STRICTNESS_LEVELS = ["ignore", "false", "true", "strict", "strong"]
-        SIGIL_REGEX = /^\s*#\s+typed:(?:\s+([\w]+))?/
+        SIGIL_REGEX = /^[[:blank:]]*#[[:blank:]]+typed:(?:[[:blank:]]+([\S]+))?/
 
         # extraction
 

data/lib/rubocop/cop/sorbet/signatures/allow_incompatible_override.rb

@@ -23,25 +23,53 @@ module RuboCop
           "Instead, strive to write interfaces which respect subtyping principles and remove `allow_incompatible`"
         RESTRICT_ON_SEND = [:override].freeze
 
-        # @!method allow_incompatible_override?(node)
-        def_node_matcher(:allow_incompatible_override?, <<~PATTERN)
+        # @!method sig_dot_override?(node)
+        def_node_matcher(:sig_dot_override?, <<~PATTERN)
           (send
-            #sig?
+            [!nil? #sig?]
             :override
             (hash <$(pair (sym :allow_incompatible) true) ...>)
           )
         PATTERN
 
         # @!method sig?(node)
-        def_node_search :sig?, <<~PATTERN
+        def_node_search(:sig?, <<~PATTERN)
           (send _ :sig ...)
         PATTERN
 
+        # @!method override?(node)
+        def_node_matcher(:override?, <<~PATTERN)
+          (send
+            _
+            :override
+            (hash <$(pair (sym :allow_incompatible) true) ...>)
+          )
+        PATTERN
+
         def on_send(node)
-          allow_incompatible_override?(node) do |allow_incompatible_pair|
+          sig_dot_override?(node) do |allow_incompatible_pair|
             add_offense(allow_incompatible_pair)
           end
         end
+
+        def on_block(node)
+          return unless sig?(node.send_node)
+
+          block = node.children.last
+          return unless block.send_type?
+
+          receiver = block.receiver
+          while receiver
+            allow_incompatible_pair = override?(receiver)
+            if allow_incompatible_pair
+              add_offense(allow_incompatible_pair)
+              break
+            end
+            receiver = receiver.receiver
+          end
+        end
+
+        alias_method :on_numblock, :on_block
       end
     end
   end

data/lib/rubocop/sorbet/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module Sorbet
-    VERSION = "0.7.1"
+    VERSION = "0.7.3"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-sorbet
 version: !ruby/object:Gem::Version
-  version: 0.7.1
+  version: 0.7.3
 platform: ruby
 authors:
 - Ufuk Kayserilioglu
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2023-08-03 00:00:00.000000000 Z
+date: 2023-08-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -152,7 +152,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.17
+rubygems_version: 3.4.18
 signing_key: 
 specification_version: 4
 summary: Automatic Sorbet code style checking tool.