rubocop-sorbet 0.6.7 → 0.6.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: abb9e641bb3b12d53d9364cd235ab21b63c48339d2ffba858f593d421d029868
-  data.tar.gz: 5e2758c93d99a35d2c93914bd3e2c2bba08de4770eb2519a6b9a938460cddd3e
+  metadata.gz: eda9e8cef015959394e43c9aa03ba35fd39ce07b629e285799c65670a1694b64
+  data.tar.gz: 9be1efcb8eaa30dcfe7fa1e9fb8a59ae73257392d78f432440d98566bb5e3333
 SHA512:
-  metadata.gz: d0ae42fc7fb217d55f94ed40dfe8d721c18666d9b5bfe5c87035694c978c4165a41089dac38db2594904befffb3c33c80d62f7fbee440bdcbfa3e1d1e9687bc3
-  data.tar.gz: e418a1bdbdcd084c0ebe76a976ee813836be481fdfa336eb3387ab569adacabdd3bea6f9b9fefb74a9968bb56c8ad4a2ec1d5915b467626ecddb6a4904f1d738
+  metadata.gz: ddb3cfc072f18d9d8a30db0429b8998e2c1971a5d662dcade2abdf51c3ee122d9e1db1e0ee1d43682ef2ed2459b11d9f40afc9fbdec8b429ba89f00cd24413dc
+  data.tar.gz: 4217f8c4cda4881cb7d89fd0c2644008f3f5fd41660bdb3aa7a647c9b8e1a69981a9522e2b47de4440d75bf5541544ce35c9b7a12b88ecaacb5a9182cd43c346

data/.github/workflows/ci.yml

@@ -11,7 +11,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        ruby: [ 2.5, 2.6, 2.7, 3.0 ]
+        ruby: [ '2.5', '2.6', '2.7', '3.0', '3.1' ]
     name: Test Ruby ${{ matrix.ruby }}
     steps:
       - uses: actions/checkout@v2

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    rubocop-sorbet (0.6.7)
+    rubocop-sorbet (0.6.10)
       rubocop (>= 0.90.0)
 
 GEM

data/README.md

@@ -60,13 +60,15 @@ end
 
 ### Rubocop rules for RBI files
 
-Put this into your `.rubocop.yml`:
+To enable the cops related to RBI files under the `sorbet/rbi/` directory, put this in `sorbet/rbi/.rubocop.yml`:
 
 ```yaml
 inherit_gem:
   rubocop-sorbet: config/rbi.yml
 ```
 
+This will turn off default cops for `**/*.rbi` files and enable the RBI specific cops.
+
 ## The Cops
 All cops are located under [`lib/rubocop/cop/sorbet`](lib/rubocop/cop/sorbet), and contain examples/documentation.
 

data/config/default.yml

@@ -97,6 +97,12 @@ Sorbet/ForbidTUnsafe:
   VersionAdded: 0.7.0
   VersionChanged: 0.7.0
 
+Sorbet/ForbidTUntyped:
+  Description: 'Forbid usage of T.untyped'
+  Enabled: false
+  VersionAdded: 0.6.9
+  VersionChanged: 0.7.0
+
 Sorbet/ForbidUntypedStructProps:
   Description: >-
                   Disallows use of `T.untyped` or `T.nilable(T.untyped)` as a

data/lib/rubocop/cop/sorbet/binding_constants_without_type_alias.rb

@@ -57,12 +57,18 @@ module RuboCop
           )
         PATTERN
 
-        def_node_matcher(:generic_parameter_decl?, <<-PATTERN)
+        def_node_matcher(:generic_parameter_decl_call?, <<-PATTERN)
           (
             send nil? {:type_template :type_member} ...
           )
         PATTERN
 
+        def_node_matcher(:generic_parameter_decl_block_call?, <<-PATTERN)
+          (block
+            (send nil? {:type_template :type_member} ...) ...
+          )
+        PATTERN
+
         def_node_search(:method_needing_aliasing_on_t?, <<-PATTERN)
           (
             send
@@ -81,7 +87,7 @@ module RuboCop
         end
 
         def not_generic_parameter_decl?(node)
-          !generic_parameter_decl?(node)
+          !generic_parameter_decl_call?(node) && !generic_parameter_decl_block_call?(node)
         end
 
         def not_nil?(node)

data/lib/rubocop/cop/sorbet/forbid_t_untyped.rb

@@ -0,0 +1,29 @@
+# frozen_string_literal: true
+
+require "rubocop"
+
+module RuboCop
+  module Cop
+    module Sorbet
+      # This cop disallows using `T.untyped` anywhere.
+      #
+      # @example
+      #
+      #   # bad
+      #   sig { params(my_argument: T.untyped).void }
+      #   def foo(my_argument); end
+      #
+      #   # good
+      #   sig { params(my_argument: String).void }
+      #   def foo(my_argument); end
+      #
+      class ForbidTUntyped < RuboCop::Cop::Cop
+        def_node_matcher(:t_untyped?, "(send (const nil? :T) :untyped)")
+
+        def on_send(node)
+          add_offense(node, message: "Do not use `T.untyped`.") if t_untyped?(node)
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/sorbet/mutable_constant_sorbet_aware_behaviour.rb

@@ -0,0 +1,29 @@
+# frozen_string_literal: true
+
+require "rubocop/cop/style/mutable_constant"
+
+module RuboCop
+  module Cop
+    module Sorbet
+      module MutableConstantSorbetAwareBehaviour
+        def self.prepended(base)
+          base.def_node_matcher(:t_let, <<~PATTERN)
+            (send (const nil? :T) :let $_constant _type)
+          PATTERN
+        end
+
+        def on_assignment(value)
+          t_let(value) do |constant|
+            value = constant
+          end
+
+          super(value)
+        end
+      end
+    end
+  end
+end
+
+RuboCop::Cop::Style::MutableConstant.prepend(
+  RuboCop::Cop::Sorbet::MutableConstantSorbetAwareBehaviour
+)

data/lib/rubocop/cop/sorbet/sigils/valid_sigil.rb

@@ -49,7 +49,7 @@ module RuboCop
         protected
 
         STRICTNESS_LEVELS = ["ignore", "false", "true", "strict", "strong"]
-        SIGIL_REGEX = /#\s+typed:(?:\s+([\w]+))?/
+        SIGIL_REGEX = /^\s*#\s+typed:(?:\s+([\w]+))?/
 
         # extraction
 

data/lib/rubocop/cop/sorbet_cops.rb

@@ -7,6 +7,7 @@ require_relative "sorbet/forbid_untyped_struct_props"
 require_relative "sorbet/one_ancestor_per_line"
 require_relative "sorbet/callback_conditionals_binding"
 require_relative "sorbet/forbid_t_unsafe"
+require_relative "sorbet/forbid_t_untyped"
 require_relative "sorbet/type_alias_name"
 
 require_relative "sorbet/rbi/forbid_extend_t_sig_helpers_in_shims"
@@ -28,3 +29,5 @@ require_relative "sorbet/sigils/strict_sigil"
 require_relative "sorbet/sigils/strong_sigil"
 require_relative "sorbet/sigils/enforce_sigil_order"
 require_relative "sorbet/sigils/enforce_single_sigil"
+
+require_relative "sorbet/mutable_constant_sorbet_aware_behaviour"

data/lib/rubocop/sorbet/version.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 module RuboCop
   module Sorbet
-    VERSION = "0.6.7"
+    VERSION = "0.6.10"
   end
 end

data/manual/cops.md

@@ -19,6 +19,7 @@ In the following section you find all available cops:
 * [Sorbet/ForbidRBIOutsideOfAllowedPaths](cops_sorbet.md#sorbetforbidrbioutsideofallowedpaths)
 * [Sorbet/ForbidSuperclassConstLiteral](cops_sorbet.md#sorbetforbidsuperclassconstliteral)
 * [Sorbet/ForbidTUnsafe](cops_sorbet.md#sorbetforbidtunsafe)
+* [Sorbet/ForbidTUntyped](cops_sorbet.md#sorbetforbidtuntyped)
 * [Sorbet/ForbidUntypedStructProps](cops_sorbet.md#sorbetforbiduntypedstructprops)
 * [Sorbet/HasSigil](cops_sorbet.md#sorbethassigil)
 * [Sorbet/IgnoreSigil](cops_sorbet.md#sorbetignoresigil)
@@ -34,3 +35,8 @@ In the following section you find all available cops:
 * [Sorbet/ValidSigil](cops_sorbet.md#sorbetvalidsigil)
 
 <!-- END_COP_LIST -->
+
+In addition to the cops defined in this gem, it also modifies the behaviour of some other cops
+defined in other RuboCop gems:
+
+* [Style/MutableConstant](https://docs.rubocop.org/rubocop/cops_style.html#stylemutableconstant): In addition to the default behaviour, RuboCop Sorbet makes this cop `T.let` aware, so that `CONST = T.let([1, 2, 3], T::Array[Integer])` is also treated as a mutable literal constant value.

data/manual/cops_sorbet.md

@@ -274,7 +274,7 @@ Include | `**/*.rbi` | Array
 
 Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
 --- | --- | --- | --- | ---
-Disabled | Yes | No | 0.2.0 | 0.5.0
+Disabled | Yes | Yes  | 0.2.0 | 0.5.0
 
 No documentation
 
@@ -284,7 +284,7 @@ Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChan
 --- | --- | --- | --- | ---
 Enabled | Yes | No | 0.6.1 | -
 
-This cop makes sure that RBI files are always located under the defined allowed paths
+This cop makes sure that RBI files are always located under the defined allowed paths.
 
 Options:
 
@@ -341,6 +341,26 @@ T.unsafe(foo)
 foo
 ```
 
+## Sorbet/ForbidTUntyped
+
+Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
+--- | --- | --- | --- | ---
+Disabled | Yes | No | 0.6.9 | 0.7.0
+
+This cop disallows using `T.untyped` anywhere.
+
+### Examples
+
+```ruby
+# bad
+sig { params(my_argument: T.untyped).void }
+def foo(my_argument); end
+
+# good
+sig { params(my_argument: String).void }
+def foo(my_argument); end
+```
+
 ## Sorbet/ForbidUntypedStructProps
 
 Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-sorbet
 version: !ruby/object:Gem::Version
-  version: 0.6.7
+  version: 0.6.10
 platform: ruby
 authors:
 - Ufuk Kayserilioglu
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2022-02-11 00:00:00.000000000 Z
+date: 2022-06-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -91,7 +91,9 @@ files:
 - lib/rubocop/cop/sorbet/forbid_include_const_literal.rb
 - lib/rubocop/cop/sorbet/forbid_superclass_const_literal.rb
 - lib/rubocop/cop/sorbet/forbid_t_unsafe.rb
+- lib/rubocop/cop/sorbet/forbid_t_untyped.rb
 - lib/rubocop/cop/sorbet/forbid_untyped_struct_props.rb
+- lib/rubocop/cop/sorbet/mutable_constant_sorbet_aware_behaviour.rb
 - lib/rubocop/cop/sorbet/one_ancestor_per_line.rb
 - lib/rubocop/cop/sorbet/rbi/forbid_extend_t_sig_helpers_in_shims.rb
 - lib/rubocop/cop/sorbet/rbi/forbid_rbi_outside_of_allowed_paths.rb
@@ -120,7 +122,7 @@ files:
 - manual/cops_sorbet.md
 - rubocop-sorbet.gemspec
 - service.yml
-- shipit.yml
+- shipit.production.yml
 - tasks/cops_documentation.rake
 homepage: https://github.com/shopify/rubocop-sorbet
 licenses:
@@ -144,7 +146,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.20
+rubygems_version: 3.3.3
 signing_key: 
 specification_version: 4
 summary: Automatic Sorbet code style checking tool.