rubocop-sorbet 0.6.6 → 0.6.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fbc8c95598a4e9bdcc08915198dc90cea5df439d3f06ec72f7a36b6a8a792207
-  data.tar.gz: 7bff9273f2f52f43e18d32f32b3f58ccb988274ffc2bde3746b45556c981bf51
+  metadata.gz: a0ecbebf2964b6ed70b3afb61766ab16e0008eb639a30ba8672991b6d6d6347b
+  data.tar.gz: ac96a86a59ecb5e9d5ed0130583f1b25095c481a81fe7401febc2291c6637d54
 SHA512:
-  metadata.gz: 3c749f0f371cb8e764c1db26221d3f0bebc83afc8466b7d07753c702f6e87d67657e2b0bed70f2c738d820377538356ed1259ab7317878c254fc6d2c86dc3aaf
-  data.tar.gz: 359d7e9082d01e25c088b902de0fa80d93625351caaaec52983c93eaaebbf5a9488977b4c18b0d0c1d5771cc2e97cc698c4b741addf765e739e737c01274597b
+  metadata.gz: efe418f824b02888f8ef7ba71df10487547b4a9d979f25cf1abd7911729caddbabd0206ca3503acfa7663f0ebd61cb6f4030f2750e9e77398abaf4f8c2991573
+  data.tar.gz: fe962280fb970c51b2c5b755d1b3f644c1a7345193a92eb1c4d9c72a8a8708fc3e3babbe1f69806377d58d968a926388e5f5ba5aa46df0602b4e3cbb4e833c39

data/.github/workflows/ci.yml

@@ -11,7 +11,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        ruby: [ 2.5, 2.6, 2.7, 3.0 ]
+        ruby: [ '2.5', '2.6', '2.7', '3.0', '3.1' ]
     name: Test Ruby ${{ matrix.ruby }}
     steps:
       - uses: actions/checkout@v2

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    rubocop-sorbet (0.6.6)
+    rubocop-sorbet (0.6.9)
       rubocop (>= 0.90.0)
 
 GEM

data/README.md

@@ -60,13 +60,15 @@ end
 
 ### Rubocop rules for RBI files
 
-Put this into your `.rubocop.yml`:
+To enable the cops related to RBI files under the `sorbet/rbi/` directory, put this in `sorbet/rbi/.rubocop.yml`:
 
 ```yaml
 inherit_gem:
   rubocop-sorbet: config/rbi.yml
 ```
 
+This will turn off default cops for `**/*.rbi` files and enable the RBI specific cops.
+
 ## The Cops
 All cops are located under [`lib/rubocop/cop/sorbet`](lib/rubocop/cop/sorbet), and contain examples/documentation.
 

data/config/default.yml

@@ -39,7 +39,7 @@ Sorbet/EnforceSigilOrder:
   Enabled: true
   VersionAdded: 0.3.4
 
-Sorbet/sigils/EnforceSingleSigil:
+Sorbet/EnforceSingleSigil:
   Description: 'Ensures that there is only one Sorbet sigil in a file.'
   Enabled: true
   VersionAdded: '<<next>>'

data/lib/rubocop/cop/sorbet/binding_constants_without_type_alias.rb

@@ -57,12 +57,18 @@ module RuboCop
           )
         PATTERN
 
-        def_node_matcher(:generic_parameter_decl?, <<-PATTERN)
+        def_node_matcher(:generic_parameter_decl_call?, <<-PATTERN)
           (
             send nil? {:type_template :type_member} ...
           )
         PATTERN
 
+        def_node_matcher(:generic_parameter_decl_block_call?, <<-PATTERN)
+          (block
+            (send nil? {:type_template :type_member} ...) ...
+          )
+        PATTERN
+
         def_node_search(:method_needing_aliasing_on_t?, <<-PATTERN)
           (
             send
@@ -81,7 +87,7 @@ module RuboCop
         end
 
         def not_generic_parameter_decl?(node)
-          !generic_parameter_decl?(node)
+          !generic_parameter_decl_call?(node) && !generic_parameter_decl_block_call?(node)
         end
 
         def not_nil?(node)

data/lib/rubocop/cop/sorbet/forbid_t_untyped.rb

@@ -0,0 +1,29 @@
+# frozen_string_literal: true
+
+require "rubocop"
+
+module RuboCop
+  module Cop
+    module Sorbet
+      # This cop disallows using `T.untyped` anywhere.
+      #
+      # @example
+      #
+      #   # bad
+      #   sig { params(my_argument: T.untyped).void }
+      #   def foo(my_argument); end
+      #
+      #   # good
+      #   sig { params(my_argument: String).void }
+      #   def foo(my_argument); end
+      #
+      class ForbidTUntyped < RuboCop::Cop::Cop
+        def_node_matcher(:t_untyped?, "(send (const nil? :T) :untyped)")
+
+        def on_send(node)
+          add_offense(node, message: "Do not use `T.untyped`.") if t_untyped?(node)
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/sorbet/mutable_constant_sorbet_aware_behaviour.rb

@@ -0,0 +1,29 @@
+# frozen_string_literal: true
+
+require "rubocop/cop/style/mutable_constant"
+
+module RuboCop
+  module Cop
+    module Sorbet
+      module MutableConstantSorbetAwareBehaviour
+        def self.prepended(base)
+          base.def_node_matcher(:t_let, <<~PATTERN)
+            (send (const nil? :T) :let $_constant _type)
+          PATTERN
+        end
+
+        def on_assignment(value)
+          t_let(value) do |constant|
+            value = constant
+          end
+
+          super(value)
+        end
+      end
+    end
+  end
+end
+
+RuboCop::Cop::Style::MutableConstant.prepend(
+  RuboCop::Cop::Sorbet::MutableConstantSorbetAwareBehaviour
+)

data/lib/rubocop/cop/sorbet/sigils/valid_sigil.rb

@@ -49,7 +49,7 @@ module RuboCop
         protected
 
         STRICTNESS_LEVELS = ["ignore", "false", "true", "strict", "strong"]
-        SIGIL_REGEX = /#\s+typed:(?:\s+([\w]+))?/
+        SIGIL_REGEX = /^\s*#\s+typed:(?:\s+([\w]+))?/
 
         # extraction
 

data/lib/rubocop/cop/sorbet_cops.rb

@@ -7,6 +7,7 @@ require_relative "sorbet/forbid_untyped_struct_props"
 require_relative "sorbet/one_ancestor_per_line"
 require_relative "sorbet/callback_conditionals_binding"
 require_relative "sorbet/forbid_t_unsafe"
+require_relative "sorbet/forbid_t_untyped"
 require_relative "sorbet/type_alias_name"
 
 require_relative "sorbet/rbi/forbid_extend_t_sig_helpers_in_shims"
@@ -28,3 +29,5 @@ require_relative "sorbet/sigils/strict_sigil"
 require_relative "sorbet/sigils/strong_sigil"
 require_relative "sorbet/sigils/enforce_sigil_order"
 require_relative "sorbet/sigils/enforce_single_sigil"
+
+require_relative "sorbet/mutable_constant_sorbet_aware_behaviour"

data/lib/rubocop/sorbet/version.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 module RuboCop
   module Sorbet
-    VERSION = "0.6.6"
+    VERSION = "0.6.9"
   end
 end

data/manual/cops.md

@@ -34,3 +34,8 @@ In the following section you find all available cops:
 * [Sorbet/ValidSigil](cops_sorbet.md#sorbetvalidsigil)
 
 <!-- END_COP_LIST -->
+
+In addition to the cops defined in this gem, it also modifies the behaviour of some other cops
+defined in other RuboCop gems:
+
+* [Style/MutableConstant](https://docs.rubocop.org/rubocop/cops_style.html#stylemutableconstant): In addition to the default behaviour, RuboCop Sorbet makes this cop `T.let` aware, so that `CONST = T.let([1, 2, 3], T::Array[Integer])` is also treated as a mutable literal constant value.

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-sorbet
 version: !ruby/object:Gem::Version
-  version: 0.6.6
+  version: 0.6.9
 platform: ruby
 authors:
 - Ufuk Kayserilioglu
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2022-02-09 00:00:00.000000000 Z
+date: 2022-06-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -91,7 +91,9 @@ files:
 - lib/rubocop/cop/sorbet/forbid_include_const_literal.rb
 - lib/rubocop/cop/sorbet/forbid_superclass_const_literal.rb
 - lib/rubocop/cop/sorbet/forbid_t_unsafe.rb
+- lib/rubocop/cop/sorbet/forbid_t_untyped.rb
 - lib/rubocop/cop/sorbet/forbid_untyped_struct_props.rb
+- lib/rubocop/cop/sorbet/mutable_constant_sorbet_aware_behaviour.rb
 - lib/rubocop/cop/sorbet/one_ancestor_per_line.rb
 - lib/rubocop/cop/sorbet/rbi/forbid_extend_t_sig_helpers_in_shims.rb
 - lib/rubocop/cop/sorbet/rbi/forbid_rbi_outside_of_allowed_paths.rb
@@ -120,7 +122,7 @@ files:
 - manual/cops_sorbet.md
 - rubocop-sorbet.gemspec
 - service.yml
-- shipit.yml
+- shipit.production.yml
 - tasks/cops_documentation.rake
 homepage: https://github.com/shopify/rubocop-sorbet
 licenses:
@@ -144,7 +146,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.20
+rubygems_version: 3.3.3
 signing_key: 
 specification_version: 4
 summary: Automatic Sorbet code style checking tool.