rubocop-sorbet 0.6.3 → 0.6.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bd3fcc1ddd15ba9418aeb852d83149b3594fb315c7aa77ab4641c9046466d109
-  data.tar.gz: 2b446c026647ebb8d312e8be0034af253f61dc5ac8903c2b75bf42c11be903fe
+  metadata.gz: ff745a34cb220b2798dcae5138ade84288219f2ce6fb2d81c12d90258a722609
+  data.tar.gz: 3827b4ceb6ced335573ece62da965e8f3ecc4b97313887fd5da2b7b46e1d1877
 SHA512:
-  metadata.gz: dd23c876c6224baf1a3888c169291b6260286326329d9b48650d1c4113571257837e0fa96d12b4357d4aee62e78b20e1be6373295b0d1e7d065c139e8cf3e25f
-  data.tar.gz: 12c3c8aae878c4474284fd41f79da1f4671399bb8e1f01403fe556d36e25274d951f42771ecd0dfc0c3527686b0f3aa1a0d3a22db9b7287c802adf9c43cbc718
+  metadata.gz: de19c77ff90f52a4e045509c1f7c82edb6c844a6eab9cf0d37f10d70fc7d08a6abc3b9c13cad7762445c77ed0125ed24044a068718553d48af781c84956541c1
+  data.tar.gz: 6dc626e0f057d495164b775f2730900acae4ea1b95d8944f42912fe20c26c416306ded1a5b4e321c47bb90bbb44b411d00f4b98f048c66df31346883ef88f635

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    rubocop-sorbet (0.6.3)
+    rubocop-sorbet (0.6.4)
       rubocop (>= 0.90.0)
 
 GEM

data/README.md

@@ -1,7 +1,5 @@
 # Rubocop-Sorbet
 
-[![Build Status](https://travis-ci.org/Shopify/rubocop-sorbet.svg?branch=master)](https://travis-ci.org/Shopify/rubocop-sorbet)
-
 A collection of Rubocop rules for Sorbet.
 
 ## Installation
@@ -17,7 +15,7 @@ or, if you use `Bundler`, add this line your application's `Gemfile`:
 gem 'rubocop-sorbet', require: false
 ```
 
-Note: in order to use the [Sorbet/SignatureBuildOrder](https://github.com/Shopify/rubocop-sorbet/blob/master/manual/cops_sorbet.md#sorbetsignaturebuildorder) cop autocorrect feature, it is necessary
+Note: in order to use the [Sorbet/SignatureBuildOrder](https://github.com/Shopify/rubocop-sorbet/blob/main/manual/cops_sorbet.md#sorbetsignaturebuildorder) cop autocorrect feature, it is necessary
 to install `unparser` in addition to `rubocop-sorbet`.
 
 ```ruby
@@ -111,8 +109,8 @@ bundle exec rake generate_cops_documentation
 
 ## License
 
-The gem is available as open source under the terms of the [MIT License](https://github.com/Shopify/rubocop-sorbet/blob/master/LICENSE.txt).
+The gem is available as open source under the terms of the [MIT License](https://github.com/Shopify/rubocop-sorbet/blob/main/LICENSE.txt).
 
 ## Code of Conduct
 
-Everyone interacting in the Rubocop::Sorbet project’s codebases, issue trackers, chat rooms and mailing lists is expected to follow the [code of conduct](https://github.com/Shopify/rubocop-sorbet/blob/master/CODE_OF_CONDUCT.md).
+Everyone interacting in the Rubocop::Sorbet project’s codebases, issue trackers, chat rooms and mailing lists is expected to follow the [code of conduct](https://github.com/Shopify/rubocop-sorbet/blob/main/CODE_OF_CONDUCT.md).

data/lib/rubocop/cop/sorbet/rbi/forbid_rbi_outside_of_allowed_paths.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require "pathname"
+
 module RuboCop
   module Cop
     module Sorbet
@@ -21,25 +23,41 @@ module RuboCop
         include RangeHelp
 
         def investigate(processed_source)
+          paths = allowed_paths
+
+          if paths.nil?
+            add_offense(
+              nil,
+              location: source_range(processed_source.buffer, 1, 0),
+              message: "AllowedPaths expects an array"
+            )
+            return
+          elsif paths.empty?
+            add_offense(
+              nil,
+              location: source_range(processed_source.buffer, 1, 0),
+              message: "AllowedPaths cannot be empty"
+            )
+            return
+          end
+
+          # When executed the path to the source file is absolute.
+          # We need to remove the exec path directory prefix before matching with the filename regular expressions.
+          rel_path = processed_source.file_path.sub("#{Dir.pwd}/", "")
+
           add_offense(
             nil,
             location: source_range(processed_source.buffer, 1, 0),
-            message: message
-          ) if allowed_paths.none? { |pattern| File.fnmatch(pattern, processed_source.file_path) }
+            message: "RBI file path should match one of: #{paths.join(", ")}"
+          ) if paths.none? { |pattern| File.fnmatch(pattern, rel_path) }
         end
 
         private
 
         def allowed_paths
-          cop_config["AllowedPaths"]&.compact || []
-        end
-
-        def message
-          if allowed_paths.empty?
-            "RBI files should be located in an allowed path, but AllowedPaths is empty or nil"
-          else
-            "RBI file path should match one of: #{allowed_paths.join(", ")}"
-          end
+          paths = cop_config["AllowedPaths"]
+          return nil unless paths.is_a?(Array)
+          paths.compact
         end
       end
     end

data/lib/rubocop/sorbet/version.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 module RuboCop
   module Sorbet
-    VERSION = "0.6.3"
+    VERSION = "0.6.4"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-sorbet
 version: !ruby/object:Gem::Version
-  version: 0.6.3
+  version: 0.6.4
 platform: ruby
 authors:
 - Ufuk Kayserilioglu
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2021-12-03 00:00:00.000000000 Z
+date: 2021-12-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec